summaryrefslogtreecommitdiffstats
path: root/chrome/browser/cocoa/tab_controller.h
Commit message (Collapse)AuthorAgeFilesLines
* Several theming fixes for the Mac. Sorry for the extensive change, but theythakis@chromium.org2009-10-091-5/+4
| | | | | | | | | | | | | | | | | | were all sort of intertwined. Fixes up patterns in general so that they are all in phase. Moves the window widget buttons down by two pixels. Draws overlays correctly. Fixes up some accessibility issues with the default window widgets. Gets rid of some out of date files (tab_cell). BUG=18438, 18547, 19851, 20295, 22213, 23651, 24338 TEST=Launch Chrome. Switch to "dots" theme from the Google themes. Create a couple of tabs. Check to make sure that the background pattern line up with the tabs. Move the tabs around. Check that the hightlight colors and text colors look correct for all of the tabs. Make sure the patterns stay lined up. Resize the window, make sure none of the patterns move around. Create new windows by dragging the tabs out of the windows and make sure a new window is created with the correct pattern. Show the "find" bar. Make sure its pattern lines up correctly with the tabbar. Switch to default theme. Make sure it looks correct and draws properly. Switch to Zen theme and make sure that the overlay at the top draws correctly. Create a new window. make sure that the rollovers in the window widgets work correctly in both the active and inactive window. Mouse down on the zoom button in the inactive window and notice that the window context changes. Move off of the zoom button and mouse up. Mouse down on the miniaturize button on the inactive window and notice that the window context does not change. Move off of the miniaturize button and mouse up. Do the same thing you did for the miniaturize button for the close button. Start up Accessibility Inspector from the developer tools. Make sure that the window widgets report their accessibility information correctly. Review URL: http://codereview.chromium.org/260009 Patch from dmaclach@chromium.org. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28613 0039d316-1c4b-4281-b951-d872f2087c98
* Don't show favicons or throbbers for the New Tab page on the Mac.mark@chromium.org2009-09-021-3/+7
| | | | | | | | | | | | | | | | | | | | This change nets another 35ms (15%) improvement in the duration between the renderer requesting the NTP and it having all of the resources for the NTP available and being completely done with layout on my Mac laptop in release mode. For any page which DOMUI indicates no icon should be shown, including the New Tab page, don't show a favicon or throbber. When the icon is removed, the title should expand to the left to fill the void. Compare to the behavior on Windows and Linux. http://groups.google.com/group/chromium-dev/browse_thread/thread/7148074f807dc5f7 BUG=13337 20378 TEST=No throbber or favicon on the New Tab page Review URL: http://codereview.chromium.org/184003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25167 0039d316-1c4b-4281-b951-d872f2087c98
* (Mac) Make mashing the close tab button work.viettrungluu@chromium.org2009-09-011-0/+6
| | | | | | | | | | | | | | | | | | To do this, I had to commit several crimes against humanity. In particular, Cocoa doesn't generate the required extra hit tests during animations, so we have to. Sometimes, it gets really messed up and ends up hitting the "drag blocking view". Moreover, we have to account for the possibility of the mouse down hitting a moving tab, and going up on the close button, etc. BUG=17720 TEST=Mash the close tabs button under a wide variety of situations. \ Also make sure that the handling of the tabs (dragging, etc.) \ hasn't accidentally been messed up. Review URL: http://codereview.chromium.org/174461 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25029 0039d316-1c4b-4281-b951-d872f2087c98
* Updates to clean up default theme and add hover states.avi@chromium.org2009-08-311-1/+3
| | | | | | | | | | | | Patch by Cole. BUG=http://crbug.com/18573;http://crbug.com/18574;http://crbug.com/18360;http://crbug.com/18438 TEST=none Review URL: http://codereview.chromium.org/165499 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24881 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 24700.avi@chromium.org2009-08-281-3/+1
| | | | | | Review URL: http://codereview.chromium.org/181002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24708 0039d316-1c4b-4281-b951-d872f2087c98
* Updates to clean up default theme and add hover states.avi@chromium.org2009-08-271-1/+3
| | | | | | | | | | | | Patch by Cole. BUG=http://crbug.com/18573;http://crbug.com/18574;http://crbug.com/18360;http://crbug.com/18438 TEST=none Review URL: http://codereview.chromium.org/165499 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24700 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 24512.avi@chromium.org2009-08-261-3/+1
| | | | | | Review URL: http://codereview.chromium.org/174558 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24527 0039d316-1c4b-4281-b951-d872f2087c98
* Updates to clean up default theme and add hover states.avi@chromium.org2009-08-261-1/+3
| | | | | | | | | | | | Path by Cole. BUG=http://crbug.com/18573;http://crbug.com/18574;http://crbug.com/18360;http://crbug.com/18438 TEST=none Review URL: http://codereview.chromium.org/165499 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24512 0039d316-1c4b-4281-b951-d872f2087c98
* Give crashed tabs the crashed tab icon on the Mac.avi@chromium.org2009-07-271-0/+1
| | | | | | | | | BUG=none TEST=crash a page and see if the icon shows up (animated) Review URL: http://codereview.chromium.org/160113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21648 0039d316-1c4b-4281-b951-d872f2087c98
* Make tabs go all the way to the right edge and stop using less of the strip ↵pinkerton@chromium.org2009-07-231-1/+9
| | | | | | | | | | as more tabs are added. Don't resize on selection when tabs are very small, except just enough to show a close box. Clip closebox and favicon as tab gets very small. Fix z-order to be consistent among all unselected tabs. Fix incognito man disappearing when dragging window via the tab. Tabs can now get about as small as they do on windows allowing many more to fit. BUG=14911, 14913, 17372 TEST=adding and removing lots of tabs and making sure nothing goes wrong. Review URL: http://codereview.chromium.org/159206 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21432 0039d316-1c4b-4281-b951-d872f2087c98
* Add context menus to tabs.pinkerton@chromium.org2009-07-081-1/+5
| | | | | | | | BUG=14920 TEST=context menus on tabs. Review URL: http://codereview.chromium.org/155173 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20155 0039d316-1c4b-4281-b951-d872f2087c98
* Given the results of Rohit's investigation, I think that the times that we'remark@chromium.org2009-06-261-9/+13
| | | | | | | | | | | | | getting out of the pageload tests right now are highly suspect because we're not actually getting the bits from each page to the screen. As such, I'm much less inclined to treat the "regression" in these tests as a problem. BUG=15232 TEST=throbber changes between waiting (gray) and loading (blue) at appropriate times; animation still disabled Review URL: http://codereview.chromium.org/147211 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19383 0039d316-1c4b-4281-b951-d872f2087c98
* Back out all sorts of stuff back to pre-r18933 so that we can regroup andmark@chromium.org2009-06-241-13/+9
| | | | | | | | | | figure these perf regressions out. TEST=graphs BUG=15232 Review URL: http://codereview.chromium.org/147113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19187 0039d316-1c4b-4281-b951-d872f2087c98
* Rewrite some tab controller stuff to maybe (but probably not) improve perf.mark@chromium.org2009-06-241-9/+13
| | | | | | | | BUG=15232 TEST=watch perf graphs Review URL: http://codereview.chromium.org/147103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19167 0039d316-1c4b-4281-b951-d872f2087c98
* Display a tooltip when mousing over a tab title.jeremy@chromium.org2009-06-021-0/+4
| | | | | | | | This allows a user to see the full page title. Review URL: http://codereview.chromium.org/118095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17429 0039d316-1c4b-4281-b951-d872f2087c98
* Implement a status throbber on the mac, currently using the Win artwork. ↵pinkerton@chromium.org2009-05-191-4/+21
| | | | | | | | Made the tab cell use a generic NSView for showing the icon instead of relying on the NSButtonCell to draw it, so a NSImageView is in place by default. Remove un-needed outlets, bindings, and views from the nib. BUG=11916. TEST=loading pages, opening and closing tabs. Review URL: http://codereview.chromium.org/115527 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16410 0039d316-1c4b-4281-b951-d872f2087c98
* Add a test helper to pull out some common code. Add a test for tab ↵pinkerton@chromium.org2009-04-161-1/+1
| | | | | | | | controller. Don't dead-strip un-referenced objective-C code in the unit_test target. Use the appropriate bundle when loading the tab nib. (take two, most of this was backed out earlier). Review URL: http://codereview.chromium.org/77004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13859 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 13839,13838.awalker@google.com2009-04-161-1/+1
| | | | | | Review URL: http://codereview.chromium.org/67220 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13840 0039d316-1c4b-4281-b951-d872f2087c98
* Allow unit_tests (and other non-bundle executables) to rely on objectiveC that'spinkerton@chromium.org2009-04-161-1/+1
| | | | | | | not directly referenced (such as only in a nib file). Add test for tab controller. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13838 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up close button in tabs. Patch from rohitrao@google.com.pinkerton@chromium.org2009-03-271-2/+6
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12656 0039d316-1c4b-4281-b951-d872f2087c98
* Add a TabController class to manage a TabView (with corresponding xib). ↵pinkerton@chromium.org2009-03-121-0/+44
Rewrite strip controller to create and manage TabControllers instead of NSButtons. Review URL: http://codereview.chromium.org/43137 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11541 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 22:04:57 +0000