summaryrefslogtreecommitdiffstats
path: root/chrome/browser/cocoa/tab_controller.mm
Commit message (Collapse)AuthorAgeFilesLines
* Move nsimage_cache into base so that it can be accessed from outside of chrome.mark@chromium.org2009-10-051-1/+0
| | | | | | | | | | This is in support of the next round of rebundling. TEST=does it still build, do the unit tests still pass, does it still work? BUG=14610 Review URL: http://codereview.chromium.org/243100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28016 0039d316-1c4b-4281-b951-d872f2087c98
* Don't show favicons or throbbers for the New Tab page on the Mac.mark@chromium.org2009-09-021-24/+79
| | | | | | | | | | | | | | | | | | | | This change nets another 35ms (15%) improvement in the duration between the renderer requesting the NTP and it having all of the resources for the NTP available and being completely done with layout on my Mac laptop in release mode. For any page which DOMUI indicates no icon should be shown, including the New Tab page, don't show a favicon or throbber. When the icon is removed, the title should expand to the left to fill the void. Compare to the behavior on Windows and Linux. http://groups.google.com/group/chromium-dev/browse_thread/thread/7148074f807dc5f7 BUG=13337 20378 TEST=No throbber or favicon on the New Tab page Review URL: http://codereview.chromium.org/184003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25167 0039d316-1c4b-4281-b951-d872f2087c98
* (Mac) Make mashing the close tab button work.viettrungluu@chromium.org2009-09-011-0/+10
| | | | | | | | | | | | | | | | | | To do this, I had to commit several crimes against humanity. In particular, Cocoa doesn't generate the required extra hit tests during animations, so we have to. Sometimes, it gets really messed up and ends up hitting the "drag blocking view". Moreover, we have to account for the possibility of the mouse down hitting a moving tab, and going up on the close button, etc. BUG=17720 TEST=Mash the close tabs button under a wide variety of situations. \ Also make sure that the handling of the tabs (dragging, etc.) \ hasn't accidentally been messed up. Review URL: http://codereview.chromium.org/174461 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25029 0039d316-1c4b-4281-b951-d872f2087c98
* Updates to clean up default theme and add hover states.avi@chromium.org2009-08-311-6/+20
| | | | | | | | | | | | Patch by Cole. BUG=http://crbug.com/18573;http://crbug.com/18574;http://crbug.com/18360;http://crbug.com/18438 TEST=none Review URL: http://codereview.chromium.org/165499 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24881 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 24700.avi@chromium.org2009-08-281-20/+6
| | | | | | Review URL: http://codereview.chromium.org/181002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24708 0039d316-1c4b-4281-b951-d872f2087c98
* Updates to clean up default theme and add hover states.avi@chromium.org2009-08-271-6/+20
| | | | | | | | | | | | Patch by Cole. BUG=http://crbug.com/18573;http://crbug.com/18574;http://crbug.com/18360;http://crbug.com/18438 TEST=none Review URL: http://codereview.chromium.org/165499 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24700 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 24512.avi@chromium.org2009-08-261-20/+6
| | | | | | Review URL: http://codereview.chromium.org/174558 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24527 0039d316-1c4b-4281-b951-d872f2087c98
* Updates to clean up default theme and add hover states.avi@chromium.org2009-08-261-6/+20
| | | | | | | | | | | | Path by Cole. BUG=http://crbug.com/18573;http://crbug.com/18574;http://crbug.com/18360;http://crbug.com/18438 TEST=none Review URL: http://codereview.chromium.org/165499 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24512 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure we don't show the icon when setting the icon view explicitly.pinkerton@chromium.org2009-08-211-0/+4
| | | | | | | | BUG=18359 TEST=create a ton of tabs, tabs that are still loading or have favicons should not show the throbber/icon once the tab is too small even though it's still going. Ensure that favicons still show up when tab is correctly sized. Review URL: http://codereview.chromium.org/174238 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24006 0039d316-1c4b-4281-b951-d872f2087c98
* Make tabs go all the way to the right edge and stop using less of the strip ↵pinkerton@chromium.org2009-07-231-1/+62
| | | | | | | | | | as more tabs are added. Don't resize on selection when tabs are very small, except just enough to show a close box. Clip closebox and favicon as tab gets very small. Fix z-order to be consistent among all unselected tabs. Fix incognito man disappearing when dragging window via the tab. Tabs can now get about as small as they do on windows allowing many more to fit. BUG=14911, 14913, 17372 TEST=adding and removing lots of tabs and making sure nothing goes wrong. Review URL: http://codereview.chromium.org/159206 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21432 0039d316-1c4b-4281-b951-d872f2087c98
* Initial support for theming on Mac OS X.avi@chromium.org2009-07-131-1/+2
| | | | | | | | | | | | | Patch by alcor. Original review: http://codereview.chromium.org/149204 BUG=http://crbug.com/14451 TEST=Open a theme, watch it apply. Review URL: http://codereview.chromium.org/155355 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20560 0039d316-1c4b-4281-b951-d872f2087c98
* Added an helper namespace that provides fetches images from the app bundle ↵thomasvl@chromium.org2009-07-091-1/+2
| | | | | | | | | | | | | and caches them, line NSImage imageNamed: but lets us control the bundle that's checked. Unittest for the helper. Updated the current places that use +[NSImage imageNamed:] to use our cache helper. BUG=none TEST=All the ui images still load. Review URL: http://codereview.chromium.org/149393 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20309 0039d316-1c4b-4281-b951-d872f2087c98
* Add context menus to tabs.pinkerton@chromium.org2009-07-081-0/+16
| | | | | | | | BUG=14920 TEST=context menus on tabs. Review URL: http://codereview.chromium.org/155173 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20155 0039d316-1c4b-4281-b951-d872f2087c98
* Given the results of Rohit's investigation, I think that the times that we'remark@chromium.org2009-06-261-2/+1
| | | | | | | | | | | | | getting out of the pageload tests right now are highly suspect because we're not actually getting the bits from each page to the screen. As such, I'm much less inclined to treat the "regression" in these tests as a problem. BUG=15232 TEST=throbber changes between waiting (gray) and loading (blue) at appropriate times; animation still disabled Review URL: http://codereview.chromium.org/147211 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19383 0039d316-1c4b-4281-b951-d872f2087c98
* Back out all sorts of stuff back to pre-r18933 so that we can regroup andmark@chromium.org2009-06-241-1/+2
| | | | | | | | | | figure these perf regressions out. TEST=graphs BUG=15232 Review URL: http://codereview.chromium.org/147113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19187 0039d316-1c4b-4281-b951-d872f2087c98
* Rewrite some tab controller stuff to maybe (but probably not) improve perf.mark@chromium.org2009-06-241-2/+1
| | | | | | | | BUG=15232 TEST=watch perf graphs Review URL: http://codereview.chromium.org/147103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19167 0039d316-1c4b-4281-b951-d872f2087c98
* Display a tooltip when mousing over a tab title.jeremy@chromium.org2009-06-021-0/+9
| | | | | | | | This allows a user to see the full page title. Review URL: http://codereview.chromium.org/118095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17429 0039d316-1c4b-4281-b951-d872f2087c98
* Implement a status throbber on the mac, currently using the Win artwork. ↵pinkerton@chromium.org2009-05-191-3/+14
| | | | | | | | Made the tab cell use a generic NSView for showing the icon instead of relying on the NSButtonCell to draw it, so a NSImageView is in place by default. Remove un-needed outlets, bindings, and views from the nib. BUG=11916. TEST=loading pages, opening and closing tabs. Review URL: http://codereview.chromium.org/115527 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16410 0039d316-1c4b-4281-b951-d872f2087c98
* Add a test helper to pull out some common code. Add a test for tab ↵pinkerton@chromium.org2009-04-161-1/+2
| | | | | | | | controller. Don't dead-strip un-referenced objective-C code in the unit_test target. Use the appropriate bundle when loading the tab nib. (take two, most of this was backed out earlier). Review URL: http://codereview.chromium.org/77004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13859 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 13839,13838.awalker@google.com2009-04-161-2/+1
| | | | | | Review URL: http://codereview.chromium.org/67220 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13840 0039d316-1c4b-4281-b951-d872f2087c98
* Allow unit_tests (and other non-bundle executables) to rely on objectiveC that'spinkerton@chromium.org2009-04-161-1/+2
| | | | | | | not directly referenced (such as only in a nib file). Add test for tab controller. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13838 0039d316-1c4b-4281-b951-d872f2087c98
* Correctly initialize all parts of the tab to unselected when it's created, ↵pinkerton@chromium.org2009-04-061-6/+12
| | | | | | | | keeping it in sync with the member var. Review URL: http://codereview.chromium.org/62074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13192 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up close button in tabs. Patch from rohitrao@google.com.pinkerton@chromium.org2009-03-271-4/+8
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12656 0039d316-1c4b-4281-b951-d872f2087c98
* Make the standard tab width wider to better match windows.pinkerton@chromium.org2009-03-261-1/+1
| | | | | | Review URL: http://codereview.chromium.org/42652 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12575 0039d316-1c4b-4281-b951-d872f2087c98
* Don't rely on subview ordering to be equivalent to tab ordering. Allows us ↵pinkerton@chromium.org2009-03-121-0/+5
| | | | | | | | to correctly set z-order on tabs. Add animation to tabs closing. Fix issue where new tab button would not draw correctly by pulling it from the nib. Fix memory leak in TabController. Fix console output about missing image. Review URL: http://codereview.chromium.org/43144 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11575 0039d316-1c4b-4281-b951-d872f2087c98
* Add a TabController class to manage a TabView (with corresponding xib). ↵pinkerton@chromium.org2009-03-121-0/+53
Rewrite strip controller to create and manage TabControllers instead of NSButtons. Review URL: http://codereview.chromium.org/43137 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11541 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 17:56:52 +0000