summaryrefslogtreecommitdiffstats
path: root/chrome/browser/cocoa/tab_strip_controller.mm
Commit message (Collapse)AuthorAgeFilesLines
* Move browser/cocoa to browser/ui/cocoaben@chromium.org2010-12-011-1879/+0
| | | | | | | | | BUG=none TEST=none TBR=brettw git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67854 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Force tab titles and favicons to update when committing an instant ↵rohitrao@chromium.org2010-11-291-0/+5
| | | | | | | | | | preview. BUG=61939 TEST=Enable instant. Type a url into the omnibox and wait for the preview to load. Press enter. Tab title and favicon should be correct. Review URL: http://codereview.chromium.org/5363003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67533 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Include browser.h -> ui/browser.h [Final].jhawkins@chromium.org2010-11-181-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5197001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66668 0039d316-1c4b-4281-b951-d872f2087c98
* Make pink's TabContentsWrapper change compile on Windows.ben@chromium.org2010-11-181-34/+41
| | | | | | | | | | Code by pinkerton@, with modifications by evanm and myself to get it to build on windows/linux/chromeos. BUG=none TEST=none Review URL: http://codereview.chromium.org/4694008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66626 0039d316-1c4b-4281-b951-d872f2087c98
* Handle resize corner layout entirely in the BrowserView (views) or ↵alekseys@chromium.org2010-11-161-3/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | BrowserWindow* (Mac) and extend RenderViewHost with a concept of reserved contents rect, a place to show extra stuff, such as Sidebar's mini tab UI. sidebar UI implementation warranted this change (mini tabs UI and resize corner area for sidebar contents). TabContentsDelegate::GetRootWindowResizerRect() is no more, reserved contents area is now cached in RenderWidgetHostView and updated upon view resize. Views: BrowserView is responsible for the actual layout and reserved contents area update. Mac: TabContentsController now manages all TabContents views in the main browser window to solve two problems, first to prevent contents flickering during tab change not only for the page, but for the sidebar and devtools contents too and, second, to monitor contents view frame changes and update reserved contents area accordingly. BUG=51084 TEST=All tests should pass, this is a refactoring CL. Review URL: http://codereview.chromium.org/3547008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66332 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove chrome/browser/browser_navigator.* and references.jhawkins@chromium.org2010-11-121-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/4840001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65881 0039d316-1c4b-4281-b951-d872f2087c98
* Split out command IDs from chrome_dll_resource.h.evan@chromium.org2010-11-081-1/+1
| | | | | | | | | | | | The name of this file is a leftover from Windows. Split the command ids (which are used on all platforms) out, leaving just the Windows-specific resource IDs in the original file. TEST=compiles Review URL: http://codereview.chromium.org/4710001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65453 0039d316-1c4b-4281-b951-d872f2087c98
* Add pinned property to tabs.update and create.jstritar@chromium.org2010-11-081-0/+5
| | | | | | | | | | | Fire tabs.onUpdated event if a tab's pinned state changes. BUG=24781 TEST=ExtensionApiTest Review URL: http://codereview.chromium.org/3816005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65379 0039d316-1c4b-4281-b951-d872f2087c98
* Make all browser code use browser::Navigate to open tabs.ben@chromium.org2010-11-021-4/+6
| | | | | | | | | BUG=none TEST=existing unittests. Also, test all places where new tabs and windows are opened from UI, e.g. links in options, new tab button, Ctrl+T, popup windows, etc. Review URL: http://codereview.chromium.org/3834002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64745 0039d316-1c4b-4281-b951-d872f2087c98
* Move all ResourceBundle::GetNSImageNamed() calls to GetNativeImageNamed().rsesek@chromium.org2010-10-211-5/+5
| | | | | | | | | | | This is part of the first stage of cleaning up ResourceBundle's interface. BUG=58030 TEST=Compile and unit tests. Review URL: http://codereview.chromium.org/3806007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63367 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Handle TabReplacedAt() notifications in TabStripModelObserverBridge. ↵rohitrao@chromium.org2010-10-081-3/+22
| | | | | | | | | | | Adds a new |-tabReplacedWithContents:previousContents:atIndex:| method and calls that if it exists. TabStripController now listens for this notification and replaces the corresponding entry in its |tabContentsArray_|. BUG=56385 TEST=No visible changes. This notification is not sent on Mac (yet). Review URL: http://codereview.chromium.org/3606020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62000 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Delete TabContents.xib and instead create the TabContentsController's ↵rohitrao@chromium.org2010-10-061-2/+1
| | | | | | | | | | | | view programatically. TabContents.xib has dwindled to a single NSView, so there is little point in keeping it around. BUG=None TEST=None Review URL: http://codereview.chromium.org/3613012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61705 0039d316-1c4b-4281-b951-d872f2087c98
* Replace Browser::AddTabWithURL(...) with:ben@chromium.org2010-10-051-5/+7
| | | | | | | | | | | | | | - Browser::AddSelectedTabWithURL(const GURL& url, PageTransition::Type transition) -> A good many callsites just wanted a way to open a tab somewhere and select it. - Browser::AddTabWithURL(AddTabWithURLParams* params) -> For the callsites with specialized needs, this new signature allows the parameter set to change as features are added without having to update a bunch of callers every time. BUG=none TEST=existing unit tests Review URL: http://codereview.chromium.org/3599006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61517 0039d316-1c4b-4281-b951-d872f2087c98
* Rip out phantom tabs and corresponding unit tests.andybons@chromium.org2010-10-021-16/+0
| | | | | | | | | | | Also get rid of the type enum passed to TabReplacedAt since it can only be one option after phantom tabs are removed. BUG=none TEST=compile? good. pass tests? good. Review URL: http://codereview.chromium.org/3539010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61303 0039d316-1c4b-4281-b951-d872f2087c98
* Resize page contents view to match window size first time it's added into ↵alekseys@chromium.org2010-09-131-0/+1
| | | | | | | | | | | | | | view hierarchy to avoid flashing. BUG=55093 TEST=1. Make sure "Always show bookmark bar" is checked 2. close all Chromium windows (but don't quit) 3. open a new Chromium window by clicking on the Dockicon or by hitting CMD+N 4. Take a look on the NewTabPage while the window opens, scrollbars should not flash Review URL: http://codereview.chromium.org/3323024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59233 0039d316-1c4b-4281-b951-d872f2087c98
* Move devtools and sidebar handling to BWC and ensure the order of layout ↵alekseys@chromium.org2010-09-091-73/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | adjustments during tab change updates to eliminate UI flickering. TabContents.xib changes: devtools and sidebar NSSplitViews removed (moved to BrowserWindow.xib), contentsContainer_ view removed (now it's inserted at runtime). BrowserWindow.xib chnages: devtools and sidebar NSSplitViews added into FastResizeView. BUG=22717, 31633 TEST=Run unit_tests, browser_tests and interactive_ui_tests. Open google.com in one tab (it's easy to spot content relayout on google.com), trigger an infobar and content scroll bar on another tab (ru.wikipedia.org with translation infobar will do), switch tabs back and forth. Content should not relayout, scroll bar should not "jump". Open new tab and make sure bookmark bar is not always visible, open any site which triggers infobar and big enough to show content scroll bar on another tab, switch tabs back and forth. Content should not relayout, scroolbar should not "jump". Repeat the tests above with sidebar opened on any of these tabs, page and sidebar content should not relayout, sidebar should stay the same width, scrollbar should not "jump". Repeat the tests above with devtools docked. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58964 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Fix a bug where the moving a tab via an extension was failing.andybons@chromium.org2010-09-031-0/+2
| | | | | | | | | | | This was due to a lack of re-layout within the function that the TabModelObserverBridge calls within the TabStripController class, violating its contract. BUG=40371 TEST=see bug for an example extension that tests this. Review URL: http://codereview.chromium.org/3312006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58436 0039d316-1c4b-4281-b951-d872f2087c98
* Sidebar view, Mac implementation (common sidebar code and Windows version is ↵thakis@chromium.org2010-08-301-3/+42
| | | | | | | | | | | | | | | | | already submitted). TabContents.xib changes: it was converted to the latest IB version and vertical NSSplitView was added to it as a child for existing horizontal NSSplitView hosting devTools; new one hosts page content and sidebar content. BrowserWindowCocoa instance listen to SIDEBAR_CHANGED notification and updates sidebar content view according to the sidebar state linked to the current tab (adds or removes the corresponding view). Sidebar API design doc: http://www.chromium.org/developers/design-documents/extensions/sidebar-extension-api. BUG=51084 TEST=Run browser_tests and interactive_ui_tests. Review URL: http://codereview.chromium.org/3228003 Patch from Aleksey Shlyapnikov <alekseys@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57898 0039d316-1c4b-4281-b951-d872f2087c98
* Don't use rapid-close mode when middle-clicking a pinned tab to close it as ↵pinkerton@chromium.org2010-08-261-2/+9
| | | | | | | | | | the calculations get all messed up due to the differences in widths. BUG=51298 TEST=closing tabs and middle-click closing tabs, making sure everything resizes as expected. Review URL: http://codereview.chromium.org/3116037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57511 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Fix the new tab button hover bounds to match what we test for in hitTest.rohitrao@chromium.org2010-08-181-19/+37
| | | | | | | | BUG=52302 TEST=New tab button should never highlight when the mouse is close to but still outside the button. Review URL: http://codereview.chromium.org/3153016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56576 0039d316-1c4b-4281-b951-d872f2087c98
* Clone of issue 2941001. See initial review below.twiz@google.com2010-08-121-1/+1
| | | | | | | | | | | | | | http://codereview.chromium.org/2941001 Initial submit broke the chromeos build. This patch includes the original change, and fixes to compile ChromeOs properly. BUG=None TEST=None Review URL: http://codereview.chromium.org/2819086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55951 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac]Implement ViewID support. (third approach)suzhe@chromium.org2010-07-201-0/+4
| | | | | | | | | | | | | | | | This CL adds several extension methods to NSView class for ViewID support, and uses a map to store ViewIDs of views. Each view requiring ViewID support can set its ViewID upon initialization and unset it before destruction. When looking up a view with a specific ViewID, just search all sub views recursively from the root view of a window. BUG=44692 need ViewIds on mac TEST=none Review URL: http://codereview.chromium.org/2878037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53067 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Finish implementation of App Tabs. This takes into account the UI ↵andybons@chromium.org2010-07-141-13/+16
| | | | | | | | | | consolidation of pinned and nano tabs tracked in issue 49013. TEST=none BUG=45539,49013 Review URL: http://codereview.chromium.org/2952004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52394 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Context Menu broken when tab dragged out to new window.jeremy@chromium.org2010-07-141-1/+1
| | | | | | | | | | | | | | | The cause of this bug was that in new windows created by dragging a tab out, the content view was ending up in front of the TabStripView and eating it's right-clicks. The reason this was happening has to do with the order that the views were reconstitued in the new window in [TabWindowController moveViewsBetweenWindowAndOverlay]. This CL also fixes a few minor spelling issues seen in passing. BUG=44023 TEST=Drag a tab out into a new Window, right click on the bottom half of the newly dragged out tab. Context menu should open. Previously such a click would do nothing. See comment #10 on the bug for a screenshot of the area that used to be problematic. Review URL: http://codereview.chromium.org/2918009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52322 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Initial implementation of app tabs. Loads the app and displays the ↵andybons@chromium.org2010-07-071-18/+21
| | | | | | | | | | | | | | | correct icon (http://cl.ly/97c1b5e22eb32075d497). Still to be done: o there should be a much smaller overlap of app tabs with other tabs. o The toolbar should hide when necessary. o The context menu for the tab should have the option of hiding/showing the toolbar on a per-app basis. TEST=none BUG=45539 Review URL: http://codereview.chromium.org/2847052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51737 0039d316-1c4b-4281-b951-d872f2087c98
* Ben said make the tab animations faster. Pink smash tab animation!pinkerton@chromium.org2010-06-301-1/+1
| | | | | | | | BUG=45737 TEST=opening and closing tabs really fast Review URL: http://codereview.chromium.org/2863033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51257 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt 2 at Moving Browser::AddTypes to TabStripModel. The firstsky@chromium.org2010-06-281-3/+5
| | | | | | | | | | | | | | | | | | | | | | | | | attempt caused some flakiness on the new tab warm startup test. The only difference between this and the last is that I'm leaving some suspcious code in TabStripModel::InsertTabContents and Browser::AddTabWithURL. I'll try to isolate why those changes caused flakiness after I land the rest. Here's the description: Moves Browser::AddTypes to TabStripModel. This patch is primarily cleanup before I fix 29933, but has a couple of interesting bits beyond the enum change: . AddTabContents now supports adding pinned. . Converted InsertTabContents call in extensionstabmodule to pass in nothing (Rafael said old code was wrong). BUG=29933 TEST=none TBR=ben@chromium.org Review URL: http://codereview.chromium.org/2866024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50981 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 50752 - Moves Browser::AddTypes to TabStripModel. This patch is primarilysky@chromium.org2010-06-241-5/+3
| | | | | | | | | | | | | | | | | | | | | | | | cleanup before I fix 29933, but has a couple of interesting bits beyond the enum change: . AddTabContents now supports adding pinned. . Nuked duplicate code in Browser::addTabWithURL that invoked wasHidden on the TabContents. This code is already in TabStripModel. . Moved code for setting visibility of tabcontents from TabStripModel::AddTabContents to InsertTabContentsAt. Since everything ends up in InsertTabContentsAt it should be there. . Converted InsertTabContents call in extensionstabmodule to pass in nothing (Rafael said old code was wrong). BUG=29933 TEST=none Review URL: http://codereview.chromium.org/2863021 TBR=sky@chromium.org Review URL: http://codereview.chromium.org/2849025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50776 0039d316-1c4b-4281-b951-d872f2087c98
* Moves Browser::AddTypes to TabStripModel. This patch is primarilysky@chromium.org2010-06-241-3/+5
| | | | | | | | | | | | | | | | | | | | | cleanup before I fix 29933, but has a couple of interesting bits beyond the enum change: . AddTabContents now supports adding pinned. . Nuked duplicate code in Browser::addTabWithURL that invoked wasHidden on the TabContents. This code is already in TabStripModel. . Moved code for setting visibility of tabcontents from TabStripModel::AddTabContents to InsertTabContentsAt. Since everything ends up in InsertTabContentsAt it should be there. . Converted InsertTabContents call in extensionstabmodule to pass in nothing (Rafael said old code was wrong). BUG=29933 TEST=none Review URL: http://codereview.chromium.org/2863021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50752 0039d316-1c4b-4281-b951-d872f2087c98
* Implement side tab view and controller and hook up their creation. ↵pinkerton@chromium.org2010-06-231-32/+95
| | | | | | | | | | | Parameterize tab strip layout so it can be vertical in addition to horizontal without breaking up the code too much. Abstracted some of the side tab knowledge into TabWindowController with overrides in BrowserWindowController. Nib change: added a SideTabStripView custom view to BrowserWindow and hooked it to an outlet. Renamed the outlets to better reflect both views. BUG=44773 TEST=Tab layout, full screen, dragging tabs within and to other windows to make sure they reflow and draw correctly. Side tabs themselves are still behind a flag, but this cl touches many normal codepaths. Review URL: http://codereview.chromium.org/2846028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50606 0039d316-1c4b-4281-b951-d872f2087c98
* Add a 1px white bezel under the dark line separating the tab strip and the ↵pinkerton@chromium.org2010-06-171-1/+1
| | | | | | | | | | toolbar. Tabs are now responsible for mimicing this line when drawing unselected. BUG=44574 TEST=none. Review URL: http://codereview.chromium.org/2833014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50137 0039d316-1c4b-4281-b951-d872f2087c98
* Adds ability to determine if a tab was explicitly closed by thesky@chromium.org2010-05-211-1/+4
| | | | | | | | | | | | user. This will be used to determine if the tab should be restored on startup or not. BUG=4923 TEST=none Review URL: http://codereview.chromium.org/2087012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47923 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Plumb the pinned tab flag through TabController so the context menu ↵rsesek@chromium.org2010-05-101-2/+3
| | | | | | | | | | | uses the correct state. BUG=42339 TEST=Create tab, pin it. Unpin it. Context menu works as before. Review URL: http://codereview.chromium.org/2057002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46825 0039d316-1c4b-4281-b951-d872f2087c98
* Nukes one of the AddTabWithURL variants.sky@chromium.org2010-04-291-2/+3
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1736022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45902 0039d316-1c4b-4281-b951-d872f2087c98
* Use the native Mac localization bundle utility functions.avi@chromium.org2010-04-271-3/+1
| | | | | | | | | BUG=none TEST=no change Review URL: http://codereview.chromium.org/1791004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45694 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Fix MouseDown/MouseUp error for Steve animation effectsthomasvl@chromium.org2010-04-141-1/+1
| | | | | | | | | | | | | - Pull in new GTM with Animation fixes - Switch masks to be mouse up, not down. - Remove the steve effect from places where users don't really trigger the animation, so the effect doesn't seem "random" - Move the animation duration set to be per click in the prefs window instead of binding the time at window open. BUG=41393 TEST=Steve animation effects are back. Review URL: http://codereview.chromium.org/1618021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44516 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Add a call to |-layoutTabs| so that restored pinned tabs look as they ↵rsesek@chromium.org2010-04-061-0/+4
| | | | | | | | | | | should. BUG=39900 TEST=Open a new tab, navigate, and pin it. Close the window. Restore the window. Tab should still appear pinned. Review URL: http://codereview.chromium.org/1628004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43720 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Re-enable pinned tabs; add support for mini-tabs and phantom tabs.rsesek@chromium.org2010-03-241-72/+72
| | | | | | | | | | | | | | | This CL rewires the old support for pinned tabs to support mini-tabs. This also removes the kEnablePinnedTabs browser default now that all platforms support it. Note that pinning is now only accessible through the context menu; drag-to-pin has been removed. BUG=36798, 32845 TEST=Right-click and pin two tabs. Test dragging on and off and around the tab strip. TEST=Cmd+W a pinned tab and it should go phantom (renderer closes down) and the tab is made alpha. Review URL: http://codereview.chromium.org/1119005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42548 0039d316-1c4b-4281-b951-d872f2087c98
* UMA cleanup. Replacing calls to RecordAction(char*) to use a new structure.evan@chromium.org2010-03-231-3/+6
| | | | | | | | | | | | That way it is easier to keep track of those constants in reporting tools. TEST=Covered with standard ui tests Patch by Frank Mantek <fmantek@google.com>. Review URL: http://codereview.chromium.org/811005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42362 0039d316-1c4b-4281-b951-d872f2087c98
* Pick up a GTM roll and update the apis that changed in this roll.thomasvl@chromium.org2010-03-111-1/+2
| | | | | | | | BUG=none TEST=everything still works Review URL: http://codereview.chromium.org/793003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41295 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: incognito badge fixes.viettrungluu@chromium.org2010-03-091-0/+7
| | | | | | | | | | | | 1. Make the incognito badge appear in fullscreen mode. 2. Make the new tab button not run into the incognito badge. BUG=37574, 37745 TEST=Make an incognito window and go to fullscreen mode; incognito badge should be visible in upper right. Make an incognito window with lots of tabs; new tab button (and tabs) shouldn't run into the badge; resize the window and make sure the badge stays in the right place. Review URL: http://codereview.chromium.org/691003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41031 0039d316-1c4b-4281-b951-d872f2087c98
* Base coordinate system != Window base coordinate system. Fixing.avi@chromium.org2010-03-031-2/+1
| | | | | | | | | BUG=http://crbug.com/36485 TEST=everything should still work Review URL: http://codereview.chromium.org/661322 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40519 0039d316-1c4b-4281-b951-d872f2087c98
* Base coordinate system != Window base coordinate system. Marking things to ↵avi@chromium.org2010-02-251-0/+1
| | | | | | | | | | | be fixed. BUG=http://crbug.com/36485 TEST=none; marking things to be fixed Review URL: http://codereview.chromium.org/661047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40026 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Prevent a fullscreen crash by destroying the GTMWindowSheetController ↵rohitrao@chromium.org2010-02-161-0/+6
| | | | | | | | | | in setFullscreen. BUG=31638 TEST=Trigger a sheet (ex: http auth dialog) after going fullscreen. Should not crash. Review URL: http://codereview.chromium.org/606029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39141 0039d316-1c4b-4281-b951-d872f2087c98
* Remove outdated comments, add reference to design doc.pinkerton@chromium.org2010-02-121-3/+0
| | | | | | | | BUG=34659 TEST=none Review URL: http://codereview.chromium.org/600080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38891 0039d316-1c4b-4281-b951-d872f2087c98
* Add bugs, update, and remove TODOs that are no longer validpinkerton@chromium.org2010-02-051-7/+3
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/577021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38211 0039d316-1c4b-4281-b951-d872f2087c98
* Adjusts tab strip model to deal with app tabs. There were a couple ofsky@chromium.org2010-02-021-1/+2
| | | | | | | | | | | | | places where I left them using the variable with pinned when it should be app because those places need to be radically whacked. I'll do that next. BUG=32845 TEST=none yet Review URL: http://codereview.chromium.org/555173 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37880 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Makes the tab strip left-side indent changeable. Prereq for fullscreen.rohitrao@chromium.org2010-01-251-8/+14
| | | | | | | | | | | (Changes really made by viettrungluu@chromium.org.) BUG=31638 TEST=Tab strip should still draw with the proper indent. Review URL: http://codereview.chromium.org/551145 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37038 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: fix yet another TabStripController index/model index bug (crasher).viettrungluu@chromium.org2010-01-251-3/+5
| | | | | | | | | BUG=29906 TEST=Create a bunch of tabs; click on some close tab button while holding shift down to slow down animation; while animating, select another tab; repeat many, many times. Should not crash. Review URL: http://codereview.chromium.org/553068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37010 0039d316-1c4b-4281-b951-d872f2087c98
* Tab-modal dialog improvements:zelidrag@google.com2010-01-151-45/+8
| | | | | | | | | | | | | | | | - treat constrained dialogs as tab-modal - only one shows at the time - added visual indication (tab pulsing) to the tab strip when a tab is blocked by a tab-modal dialog - blocked all UI activity from rendrer host and forced refocusing on constrained (tab-modal) dialogs This CL reverts http://codereview.chromium.org/384113 and instead incorporates the changes from http://codereview.chromium.org/392018. BUG=456,27585,27620 TEST=Go to http://www/~thakis/cgi-bin/test.html, hit esc. Review URL: http://codereview.chromium.org/541056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36415 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-08 22:26:32 +0000