summaryrefslogtreecommitdiffstats
path: root/chrome/browser/cocoa/toolbar_controller.mm
Commit message (Collapse)AuthorAgeFilesLines
* Cleanup: Remove unneeded headers from app/ (part 3)thestig@chromium.org2010-07-311-0/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3054029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54436 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] First pass at final sizing of toolbar items.shess@chromium.org2010-07-291-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Toolbar.xib changes: - buttons from 31x27 to 29x29 so that the visual is 27x27. - shift things left to take up opened space. - omnibox to 29 pixels tall. - wrench also to 29x29. - all of that raised a single pixel to recenter. - swap positions of home and reload. Modify home-button-adjustment code to reflect rearranged home/reload positions. Increase Omnibox font size by one point to match increased field height (and Windows Omnibox). Revise various font clients to recognize this. Shift Omnibox baseline and other measurements to account for increased height. Shift globe/search icon in by one pixel so icons on both sides of Omnibox are 4px from border. Matching shift in popup. Fix EV-bubble to use appropriate green for text, rather than black. Push out bubble to have a single-pixel space WRT Omnibox border. Tighten corners to tuck into Omnibox corners. Handle different lhs padding versus location icon (image should end up in same spot, even though the bubble draws outside the image). BUG=50575 TEST=none Review URL: http://codereview.chromium.org/3046029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54188 0039d316-1c4b-4281-b951-d872f2087c98
* Use a PDF for the upgrade dot.avi@chromium.org2010-07-281-8/+1
| | | | | | | | | BUG=http://crbug.com/49668 TEST=turn up resolution; make sure dot is crisp and clear Review URL: http://codereview.chromium.org/3066009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53943 0039d316-1c4b-4281-b951-d872f2087c98
* Unblackify the upgrade ball.avi@chromium.org2010-07-211-14/+22
| | | | | | | | | BUG=http://crbug.com/49370 TEST=as in bug Review URL: http://codereview.chromium.org/3047005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53181 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac]Implement ViewID support. (third approach)suzhe@chromium.org2010-07-201-0/+17
| | | | | | | | | | | | | | | | This CL adds several extension methods to NSView class for ViewID support, and uses a map to store ViewIDs of views. Each view requiring ViewID support can set its ViewID upon initialization and unset it before destruction. When looking up a view with a specific ViewID, just search all sub views recursively from the root view of a window. BUG=44692 need ViewIds on mac TEST=none Review URL: http://codereview.chromium.org/2878037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53067 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the page and app menus.pkasting@chromium.org2010-07-201-1/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3033007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52985 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Implement the update available notification in the wrench menu.rsesek@chromium.org2010-07-191-9/+49
| | | | | | | | | | | | The changes to restart_browser.mm also affect the sheet displayed in the About window. Note that the badge on the wrench menu looks bad. BUG=45147 TEST=difficult Review URL: http://codereview.chromium.org/2856042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52911 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Toolbar UI tweaks.andybons@chromium.org2010-07-161-1/+4
| | | | | | | | | | | | | o 4px between wrench menu and location bar/edge of window. o 4px between reload button and location bar. o Adjust size of wrench menu to be the same size as every other button. o Fix bug where location bar would be too close to the wrench menu when disabling the last visible browser action. BUG=46738,48678 TEST=visual Review URL: http://codereview.chromium.org/3027005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52738 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Convert page-action icons to PageActionDecoration.shess@chromium.org2010-07-161-1/+0
| | | | | | | | | | | | | | | | Removes specific knowledge of page-actions from AutocompleteTextField (and Cell and Editor). LocationBarViewMac owns and manages them. PageActionDecoration class pulls some of the specific knowledge out of location_bar_view_mac.mm. BUG=none TEST=Page actions still appear in the right place. TEST=Page action clicks work. TEST=Page action context menus work. Review URL: http://codereview.chromium.org/2861050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52686 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Put buttons into the new unified Wrench menu.rsesek@chromium.org2010-07-151-3/+8
| | | | | | | | | | | | This also makes changes to MenuController to support NIB-based initialization. Screen shots: http://cl.ly/1cyU (en) and http://cl.ly/1cyE (ru). BUG=47848 TEST=Click on Wrench menu and see buttons. Buttons perform their function. Review URL: http://codereview.chromium.org/2923009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52485 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Simplify getting page-action info-bubble point.shess@chromium.org2010-07-141-1/+1
| | | | | | | | | | | | | | | | | | LocationBarViewMac::GetPageActionBubblePoint() calculates the info-bubble point directly, rather than exposing multiple entry points so that extension code can calculate it. Also convert -locationBarBridge from returning |LocationBar*| to returning |LocationBarViewMac*|. Various code was doing static_cast<LocationBarViewMac*>() on the result, so it wasn't safe anyhow. BUG=none TEST=none Review URL: http://codereview.chromium.org/2998004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52378 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Tighten up the top chrome (move the buttons closer, reduce the toolbar ↵andybons@chromium.org2010-07-081-17/+5
| | | | | | | | | | height). Replace the stop/reload images with ones that fit the weight better. Also replace the wrench menu icon. BUG=none TEST=make sure dat toolbar is TIGHT. Review URL: http://codereview.chromium.org/2811047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51851 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Don't change state from stop to reload when hovered.shess@chromium.org2010-07-071-10/+3
| | | | | | | | | | | | | | | | | | Hold the reload button state change from stop to reload until the mouse exits. Also short-circuit the stop message when the real state should be reload. Also prevent multi-clicks from sending multiple actions. Toolbar.xib: reload button made kind of ReloadButton. BUG=47184 TEST=Browse to a slow page, mouse over stop button. Should not go to reload button when throbber (in tab) stops. TEST=After page loaded, click stop. Should not crash. TEST=Hover over reload button. Command-r should start a reload and change the button to stop button. Review URL: http://codereview.chromium.org/2847051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51787 0039d316-1c4b-4281-b951-d872f2087c98
* Toolbar facelift. Main buttons larger and more spread out, only get borders ↵pinkerton@chromium.org2010-06-291-0/+4
| | | | | | | | | | | when mouse is inside. Fix to gradient button to not show border on mouseover when disabled. Adjust "overlap" between the toolbar and bookmark bar to allow for larger buttons w/out clipping. Nib change: All buttons changed to not bordered, button cell tags are 0. Buttons are 31x31 and spread out a bit more. BUG=44574 TEST=toolbar and bookmark bar appearance, hidden, always showing, and detached on NTP. Review URL: http://codereview.chromium.org/2806041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51143 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Push location bar implementation into subdir.shess@chromium.org2010-06-251-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | Move these files from cocoa/ to cocoa/location_bar/: autocomplete_text_field.h autocomplete_text_field.mm autocomplete_text_field_cell.h autocomplete_text_field_cell.mm autocomplete_text_field_cell_unittest.mm autocomplete_text_field_editor.h autocomplete_text_field_editor.mm autocomplete_text_field_editor_unittest.mm autocomplete_text_field_unittest.mm autocomplete_text_field_unittest_helper.h autocomplete_text_field_unittest_helper.mm location_bar_view_mac.h location_bar_view_mac.mm location_bar_view_mac_unittest.mm BUG=none TEST=none Review URL: http://codereview.chromium.org/2807024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50873 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Remove knowledge of AutocompleteTextField from ToolbarController.shess@chromium.org2010-06-251-3/+2
| | | | | | | | | | | | | Concentrate the calculation in the location bar. Was going to do this in rewiring omnibox decorations, pulled it out before creating cocoa/location_bar/ subdir. BUG=none TEST=none Review URL: http://codereview.chromium.org/2846030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50797 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Give the Wrench menu keyboard shortcuts.rsesek@chromium.org2010-06-221-3/+19
| | | | | | | | | | | Note that these key equivalents are for display only and do not get fired. Commands are routed through the main menu/CommandUpdater. BUG=45098 TEST=Open Wrench menu, see keyboard shortcuts. Review URL: http://codereview.chromium.org/2800019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50452 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] UI changes for the Browser Actions toolbar container.andybons@chromium.org2010-06-211-16/+6
| | | | | | | | | | | o Grippy is hidden for now pending new UI. You can still resize just fine. o The right divider is removed since the wrench menu is now always being shown. TEST=none BUG=45764 Review URL: http://codereview.chromium.org/2863013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50375 0039d316-1c4b-4281-b951-d872f2087c98
* Unify the page and wrench menus into one wrench menu. Remove pref to hide menu. pinkerton@chromium.org2010-06-151-60/+15
| | | | | | | | | | | Nib updates: Toolbar.xib: Removed page menu and moved everything over to accomodate. Prefs.xib: Removed "show options page/wrench menu" checkbox and moved everything up to accomodate. BUG=45756 TEST=migration from having the pref hidden. It should become visible. Review URL: http://codereview.chromium.org/2828005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49830 0039d316-1c4b-4281-b951-d872f2087c98
* Detach reload from omnibox, combine with stop, and eliminate go.pkasting@chromium.org2010-06-111-98/+43
| | | | | | | | | | This does the basic surgery on all three OSes without trying to fix up the visual appearance. As a result, things look pretty ugly. My intent is to at least put endcaps on the omnibox in a subsequent patch. BUG=45745,45762,45763 TEST=Reload and stop should be combined; go should be gone. Review URL: http://codereview.chromium.org/2677003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49492 0039d316-1c4b-4281-b951-d872f2087c98
* Initial cut at scaffolding for mac sidetabs. No visible changes to browser ↵pinkerton@chromium.org2010-06-021-3/+20
| | | | | | | | | | without --enable-vertical-tabs, and even then, don't expect it to work. BUG=44773 TEST=infobars, bookmark bar, tab strip, etc should all behave correctly when showing, hiding, and widnow resizing. This cl should have no visible impact without the above flag on the command line. Review URL: http://codereview.chromium.org/2475002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48765 0039d316-1c4b-4281-b951-d872f2087c98
* Mac cleanup: remove a TODO and add ToolbarControllerTest.NoLocationBar ↵viettrungluu@chromium.org2010-04-241-2/+1
| | | | | | | | | | | (another TODO). BUG=none TEST=ToolbarControllerTest.NoLocationBar passes Review URL: http://codereview.chromium.org/1737013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45543 0039d316-1c4b-4281-b951-d872f2087c98
* Re-instate the temporary revert from r45267. That reverted certainshess@chromium.org2010-04-231-89/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Omnibox, toolbar, tab animations, and other UI changes for purposes of testing and merging into mstone-5. Additionally reverts these CLs to fix the earlier revert: r45271: [Mac] Image references missing from Omnibox revert. r45268: GTK fix merge failure in uber-revert. Additional revert which fixed a bug for the branch: r45381: [Mac] Omnibox popup icons and text lined up under toolbar. Slight merge conflict which should be good: r45322: GTK: Implement OnDragCanceled() for autocomplete... Also ++kThemePackVersion and regenerate the cached theme pak. Re-instated changes: r45213: GTK: Override cursor colors in chrome-theme mode. r45103: Support drawing nano tabs in the tabstrip. r45084: GTK: Position the EV certificate stuff inside a green bubble. r44979: Subclassing the InfoBubble to handle anchoring bubbles basedon... r44957: GTK: Tint the geolocation icons in gtk mode. r44943: Changes FormatURL to not strip http if the host starts with ft... r44930: Remove an icon that is no longer used. r44929: SSL UI changes, Windows, code side (images are separate). r44859: SSL UI changes (icons). TBRed since trybots hate binary patches. r44822: GTK: Select better greens in the native omnibox popup. r44814: GTK: navigate to URL on PRIMARY when middle-clicking the locat... r44789: [Mac] Bookmark star missing on NTP and BMM. r44775: [Mac] Centralize hack to make tests work with AutocompleteClas... r44678: Display the SECURITY_WARNING status in the location bar for the r44648: [Mac] Add an arrow cursor rect for the location image. r44615: Revert r44611 because it may have broken "unit_tests" on "Vist... r44611: Display the SECURITY_WARNING status in the location bar for the r44577: Revert 44572 - [Mac] Update locationbar icon as user types. r44572: [Mac] Update location-bar icon as user types. r44555: GTK: Use correct button mask on reload button. r44545: [Mac] Omnibox text drag drag URL when select-all. r44523: GTK: Prevent inappropriate drag of location bar location icon. r44519: GTK: make the primary selection include the url's scheme when ... r44492: [Mac] Fix search icon in keyword search to be right-side-up. r44415: GTK: Update top padding on icons in the autocomplete popup. r44401: GTK: Tint omnibox icons in GTK mode differently. r44380: GTK: Move reload in gtk mode and fix omnibox popup location. r44282: Fixes crash in autocomplete when typing some URLs. The problem r44273: [Mac] PDF icons for omnibox nits. r44269: Fix build break due to bad merge resolve r44268: Shift omnibox dropdown in and up on Windows, and square off th... r44178: GTK: fix TTS padding. r44177: Round the top left and right edges of the toolbar. r44171: Images only checkin for try server goodness. r44163: GTK: fix padding of autocomplete popup. r44152: [Mac] PDF icons for omnibox. r44145: GTK: Theme the icons in the location bar and use GTK colors fo... r44140: Strips http from the omnibox r44131: Fixes bugs in new tab strip animations where they weren't doin... r44116: Change the default theme colors. r44117: Add newline to EOF to fix CrOS builder. r44115: Make the bottom edges of the opaque frame rounded. r44091: [Mac] No star icon or page actions in omnibox on popups. r44087: Don't allow drag or click on location icon when editing in omn... r44021: [GTK] Add TTS lens graphic to linux TTS box. r44008: [Mac] Tweak location icon spacing in omnibox. r43977: GTK: don't show the star or page actions in ShouldOnlyShowLoca... r43972: Make the firstrun bubble point at a better spot now that the l... r43971: [Mac] Location icon in omnibox as drag source. r43970: Make the star and page action icons not appear on popup windows. r43954: Fixes bug in TabStrip where dragging tab out then back in rapidly r43864: Tweaks to BoundsAnimator/SlideAnimation and TabStrip: r43787: Allow location icon to be dragged & dropped. This also fixes ... r43759: Changes end cap of tab-to-search images. r43740: Change bookmark bar toggle to ctrl-shift-b. r43723: Show Page Info dialog on mouse up, not mouse down. r43677: Fix Mac build failure. r43676: Replace omnibox icons with new set that are all the same size ... r43596: Fix browser test TestStarButtonAccObj. r43593: Disables TestStarButtonAccObj. r43582: Changes tab strip to use BoundsAnimator for tab strip animatio... r43563: GTK: don't show reload button for popup/app windows. r43562: Star/reload shuffle, Windows version. r43540: [Mac] Magnifying glass in keyword-search bubble. r43482: Adds images needed for new tab animation. I'm separating this ... r43422: Add reload mask resource. r43392: GTK: make the location icon a drag source. r43376: [Mac] Move star button into page-actions area of omnibox. r43357: [Mac] Line up omnibox popup under field. r43290: gtk: fix display of icons in omnibox popup r43269: GTK: fix reload button. r43249: [Mac] Rearrange SSL status icon/label in omnibox. r43248: BrowserThemePack: Adds persistant ids for the reload endcaps. r43241: GTK: more location bar updates. r43191: Fix memory leak in BrowserThemePack. r43154: GTK: set the new star button's ID r43151: Fix bad conflict resolution for r43146. r43146: GTK: toolbar reload/star shuffle. r43025: Show the location bar icon (almost) all the time, and have its... r43023: Add new images for new reload button. No code change. r42782: Remove this icon, now that it's no longer used (due to my secu... r42502: Omnibox M5 work, part 1: Security changes r42245: Check in new icons for omnibox security changes alone, so that... BUG=none TEST=People go back to complaining about missing http://. R=pkasting@chromium.org,beng@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45474 0039d316-1c4b-4281-b951-d872f2087c98
* Don't select all when autofocusing the location bar on New Tab creation. ↵pkasting@chromium.org2010-04-231-4/+3
| | | | | | | | | | Users could already be typing in the omnibox before the load commits (e.g. due to a slow renderer process startup) and this typing would then be selected and overwritten. BUG=41466 TEST=On a very slow machine, typing before a new tab finishes loading should not be selected or cleared once the tab finishes loading. Review URL: http://codereview.chromium.org/1738004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45406 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily revert certain Omnibox, toolbar, tab animations, and othershess@chromium.org2010-04-221-15/+89
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | UI changes for purposes of testing and merging into mstone-5. Also ++kThemePackVersion and regenerate the cached theme pak. Reverted changes: r45213: GTK: Override cursor colors in chrome-theme mode. r45103: Support drawing nano tabs in the tabstrip. r45084: GTK: Position the EV certificate stuff inside a green bubble. r44979: Subclassing the InfoBubble to handle anchoring bubbles basedon... r44957: GTK: Tint the geolocation icons in gtk mode. r44943: Changes FormatURL to not strip http if the host starts with ft... r44930: Remove an icon that is no longer used. r44929: SSL UI changes, Windows, code side (images are separate). r44859: SSL UI changes (icons). TBRed since trybots hate binary patches. r44822: GTK: Select better greens in the native omnibox popup. r44814: GTK: navigate to URL on PRIMARY when middle-clicking the locat... r44789: [Mac] Bookmark star missing on NTP and BMM. r44775: [Mac] Centralize hack to make tests work with AutocompleteClas... r44678: Display the SECURITY_WARNING status in the location bar for the r44648: [Mac] Add an arrow cursor rect for the location image. r44615: Revert r44611 because it may have broken "unit_tests" on "Vist... r44611: Display the SECURITY_WARNING status in the location bar for the r44577: Revert 44572 - [Mac] Update locationbar icon as user types. r44572: [Mac] Update location-bar icon as user types. r44555: GTK: Use correct button mask on reload button. r44545: [Mac] Omnibox text drag drag URL when select-all. r44523: GTK: Prevent inappropriate drag of location bar location icon. r44519: GTK: make the primary selection include the url's scheme when ... r44492: [Mac] Fix search icon in keyword search to be right-side-up. r44415: GTK: Update top padding on icons in the autocomplete popup. r44401: GTK: Tint omnibox icons in GTK mode differently. r44380: GTK: Move reload in gtk mode and fix omnibox popup location. r44282: Fixes crash in autocomplete when typing some URLs. The problem r44273: [Mac] PDF icons for omnibox nits. r44269: Fix build break due to bad merge resolve r44268: Shift omnibox dropdown in and up on Windows, and square off th... r44178: GTK: fix TTS padding. r44177: Round the top left and right edges of the toolbar. r44171: Images only checkin for try server goodness. r44163: GTK: fix padding of autocomplete popup. r44152: [Mac] PDF icons for omnibox. r44145: GTK: Theme the icons in the location bar and use GTK colors fo... r44140: Strips http from the omnibox r44131: Fixes bugs in new tab strip animations where they weren't doin... r44116: Change the default theme colors. r44117: Add newline to EOF to fix CrOS builder. r44115: Make the bottom edges of the opaque frame rounded. r44091: [Mac] No star icon or page actions in omnibox on popups. r44087: Don't allow drag or click on location icon when editing in omn... r44021: [GTK] Add TTS lens graphic to linux TTS box. r44008: [Mac] Tweak location icon spacing in omnibox. r43977: GTK: don't show the star or page actions in ShouldOnlyShowLoca... r43972: Make the firstrun bubble point at a better spot now that the l... r43971: [Mac] Location icon in omnibox as drag source. r43970: Make the star and page action icons not appear on popup windows. r43954: Fixes bug in TabStrip where dragging tab out then back in rapidly r43864: Tweaks to BoundsAnimator/SlideAnimation and TabStrip: r43787: Allow location icon to be dragged & dropped. This also fixes ... r43759: Changes end cap of tab-to-search images. r43740: Change bookmark bar toggle to ctrl-shift-b. r43723: Show Page Info dialog on mouse up, not mouse down. r43677: Fix Mac build failure. r43676: Replace omnibox icons with new set that are all the same size ... r43596: Fix browser test TestStarButtonAccObj. r43593: Disables TestStarButtonAccObj. r43582: Changes tab strip to use BoundsAnimator for tab strip animatio... r43563: GTK: don't show reload button for popup/app windows. r43562: Star/reload shuffle, Windows version. r43540: [Mac] Magnifying glass in keyword-search bubble. r43482: Adds images needed for new tab animation. I'm separating this ... r43422: Add reload mask resource. r43392: GTK: make the location icon a drag source. r43376: [Mac] Move star button into page-actions area of omnibox. r43357: [Mac] Line up omnibox popup under field. r43290: gtk: fix display of icons in omnibox popup r43269: GTK: fix reload button. r43249: [Mac] Rearrange SSL status icon/label in omnibox. r43248: BrowserThemePack: Adds persistant ids for the reload endcaps. r43241: GTK: more location bar updates. r43191: Fix memory leak in BrowserThemePack. r43154: GTK: set the new star button's ID r43151: Fix bad conflict resolution for r43146. r43146: GTK: toolbar reload/star shuffle. r43025: Show the location bar icon (almost) all the time, and have its... r43023: Add new images for new reload button. No code change. r42782: Remove this icon, now that it's no longer used (due to my secu... r42502: Omnibox M5 work, part 1: Security changes r42245: Check in new icons for omnibox security changes alone, so that... BUG=none TEST=Eyjafjallajokull R=pkasting@chromium.org,beng@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45267 0039d316-1c4b-4281-b951-d872f2087c98
* Shift omnibox dropdown in and up on Windows, and square off the top, so it ↵pkasting@chromium.org2010-04-121-36/+0
| | | | | | | | | | | | connects to the location bar. Also fix info bubble positioning against location bar icons to put the arrow "up against the icon edge" (fixes the arrow overlapping some page action icons). Remove BubblePositioner, which is now no longer needed. BUG=27570,40730 TEST=Omnibox dropdown should line up with editable area edges, icons and text should line up with icon and text in the omnibox. Info bubbles should still be positioned correctly Review URL: http://codereview.chromium.org/1578021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44268 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] No star icon or page actions in omnibox on popups.shess@chromium.org2010-04-091-1/+1
| | | | | | | | | BUG=40730 TEST=install "lights out" extension. Go to www.popuptest.com. See if the page-action and the star are still in a popup. Review URL: http://codereview.chromium.org/1627012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44091 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Move star button into page-actions area of omnibox.shess@chromium.org2010-04-011-40/+14
| | | | | | | | | | | | | | | | | | | | | | | | | Removes the star button from the toolbar entirely. Adds a LocationBarImageView subclass for the star icon and wires it to the RHS of the field. Adjust the bookmark bubble to move the arrow to the RHS and position appropriately. BookmarkBubble.xib: outlet to view so that controller can change the arrow from left to right. Toolbar.xib: Move reload icon to where star was, remove star icon, adjust spacing. All spacing was adjusted to specific positions in the relevant inspector, not by mouse drag, so hopefully there's nothing awry there. BUG=37865 TEST=No star icon on toolbar. TEST=Optional home button adjustments should work right. TEST=Star action in omnibox when showing an URL. TEST=Star action can be clicked to bookmark current page. TEST=Bookmark bubble arrow points at star like before. TEST=Command-d brings up bookmark bubble. TEST=Star action changes from blank to yellow depending on state. TEST=Star action tooltip changes depending on state. Review URL: http://codereview.chromium.org/1540009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43376 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Line up omnibox popup under field.shess@chromium.org2010-04-011-17/+5
| | | | | | | | | | | | Also line up the icons. Spacing can be adjusted later. BUG=37865 TEST=Popup edges line up under field edges. TEST=Popup icons and text should line up under field icon and text. Review URL: http://codereview.chromium.org/1608001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43357 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Fixes bug where disabling the last browser action would cause the ↵andybons@chromium.org2010-04-011-1/+3
| | | | | | | | | | location bar and go button to overlap with the page and wrench menus (if they were visible). TEST=none BUG=40003 Review URL: http://codereview.chromium.org/1555004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43346 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 43282 - [Mac] Prep for animating the Browser Action Buttons in and out.andybons@chromium.org2010-04-011-5/+2
| | | | | | | | | | | | | Also fixes bug where the go button would overlap with the page/wrench menus upon uninstalling the last extension. BUG=40003,39200 TEST=none Review URL: http://codereview.chromium.org/1551009 TBR=andybons@chromium.org Review URL: http://codereview.chromium.org/1589009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43295 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Prep for animating the Browser Action Buttons in and out.andybons@chromium.org2010-03-311-2/+5
| | | | | | | | | | Also fixes bug where the go button would overlap with the page/wrench menus upon uninstalling the last extension. BUG=40003,39200 TEST=none Review URL: http://codereview.chromium.org/1551009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43282 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Enables drag N' drop for the buttons within the Browser Actions ↵andybons@chromium.org2010-03-261-9/+15
| | | | | | | | | | | | container. Also fixes an issue where the grippy was being shown when no Browser Actions were installed. Known issue: You can drag the buttons outside of the container, even though they will recover by snapping back into place. This will be fixed in a further revision. TEST=try dragging browser action buttons in order to reorder them. BUG=26990 Review URL: http://codereview.chromium.org/1418003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42845 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Finish up the resizing code for the Browser Actions container complete ↵andybons@chromium.org2010-03-241-24/+52
| | | | | | | | | | | | | | with animations and all. Also added basic skeleton unit test for container. Polish bugs to be filed: o Resizing the container is not synced across windows. o Buttons do not animate in/out when added/removed. TEST=none BUG=32101 Review URL: http://codereview.chromium.org/1198001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42511 0039d316-1c4b-4281-b951-d872f2087c98
* Make repost form warning tab-modal on Mac.bauerb@chromium.org2010-03-181-0/+3
| | | | | | | | | | | | | | Reloading a page for the second time dismisses the warning before showing it again. CLs for other platforms forthcoming. BUG=26271 TEST=RepostFormWarningTest.TestDoubleReload Manual test: Go to http://www.cs.unc.edu/~jbs/resources/perl/perl-cgi/programs/form1-POST.html, hit Submit, then reload. The warning sheet should be tab-modal, not window-modal. Hit reload again. The warning sheet should close and immediately reopen. Review URL: http://codereview.chromium.org/969003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41898 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bubbles (bookmark, status, blocked content, both extension ones) in ↵avi@chromium.org2010-03-161-2/+1
| | | | | | | | | | | resolution independence. BUG=http://crbug.com/19476, http://crbug.com/36366 TEST=click the star in RI and the bubble should position itself correctly; status bubble should have adequate height for text Review URL: http://codereview.chromium.org/851009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41748 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: toggle between "Enter/Exit Full Screen" in menus.viettrungluu@chromium.org2010-03-161-0/+15
| | | | | | | | | BUG=24390 TEST=When *not* fullscreen, menu items (under View in main menu and in app menu) should be "Enter Full Screen"; when fullscreen, they should be "Exit Full Screen"; menu items should still work; keyboard shortcuts should still work. Review URL: http://codereview.chromium.org/1011002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41726 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Add support for showing extensions in incognito mode, while fixing a ↵andybons@chromium.org2010-03-151-1/+6
| | | | | | | | | | bug where the Browser Actions container was displayed and sized in a popup window. TEST=none. BUG=38094 Review URL: http://codereview.chromium.org/1001001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41644 0039d316-1c4b-4281-b951-d872f2087c98
* Move base/gfx contents to gfx/ben@chromium.org2010-03-141-1/+1
| | | | | | | | | TBR=darin BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41559 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] More progress towards resizing the Browser Actions container.andybons@chromium.org2010-03-101-82/+124
| | | | | | | | | | | | | | | | o Icons fade out as they are moved off screen by resizing the window. o Dragging the resizer actually resizes the container. o Known issues include: + no chevron. + no updating of other windows if the size of the container changes. + the cursor is a bit wonky in updating its state. o Fixes a slew of janky UI bugs relating to having a lot of extensions installed. BUG=26990,29838 TEST=none Review URL: http://codereview.chromium.org/657038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41114 0039d316-1c4b-4281-b951-d872f2087c98
* Move pref_{member,service} and important_file_writer from chrome/commonphajdan.jr@chromium.org2010-02-191-1/+1
| | | | | | | | | | | | | to chrome/browser. This is a part of an effort to remove bad dependency of chrome/common on chrome/browser. TEST=unit_tests and ui_tests, just moving code BUG=none Review URL: http://codereview.chromium.org/621004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39428 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Adds grippys to the left side of the Browser Actions container to ↵andybons@chromium.org2010-02-171-31/+6
| | | | | | | | | | | | resize the container (they do not work yet), refactors a bunch of code out of toolbar_controller.mm and adds a slight gradient'ed divider between the container and the page/wrench menus buttons. http://imgur.com/OqKGF.png TEST=none BUG=26990 Review URL: http://codereview.chromium.org/606079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39231 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: fix clicking on security or blocked contents of non-active window ↵mattm@chromium.org2010-02-101-2/+2
| | | | | | | | | | | | | | | showing wrong data. Change the location bar code on all platforms to not use BrowserList::GetLastActive. Makes GetTabContents part of the LocationBar interface. BUG=none TEST=open two windows that show security or blocked popups. click the icon in the non-focused one. Review URL: http://codereview.chromium.org/573038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38705 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Use the ExtensionToolbarModel for ordering of the Browser Actions. ↵andybons@chromium.org2010-02-101-0/+1
| | | | | | | | | | | | Prep for drag and drop for re-ordering. Also fixes crashers where if you tried to disable an extension via its context menu while an incognito window was key, boom. BUG=26990 TEST=none Review URL: http://codereview.chromium.org/595017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38632 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] o Adds a slight drop shadow to the drawn images within Browser Action ↵andybons@chromium.org2010-02-051-12/+9
| | | | | | | | | | | | | buttons. o Adds initial BrowserActionsContainerView class that simply draws a right border at this time but will be used for more complex UI later. o Alters Toolbar.xib to use the new view class instead of a plain NSView. TEST=none BUG=none Review URL: http://codereview.chromium.org/565048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38278 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Make the extension popup a singleton instance to avoid maintaining ↵andybons@chromium.org2010-02-021-3/+2
| | | | | | | | | | | | multiple pointer references to a class that, by design, can only have one popup open at a time. The bug fixed in this change has to do with PageActionView having a dirty pointer to a popup if it was closed via losing its key state. Once a notification like EXTENSION_HOST_VIEW_SHOULD_CLOSE was fired, then the PageActionView would assume the pointer was valid and call on dirty memory. TEST=none BUG=29492,33590 Review URL: http://codereview.chromium.org/561013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37873 0039d316-1c4b-4281-b951-d872f2087c98
* ExtensionInstalledBubble for Mac.mirandac@chromium.org2010-01-311-4/+4
| | | | | | | | | | Adds ExtensionInstalledBubble.xib, which contains the framework for the bubble itself (icon view, close button, and three message fields). BUG= 26974 TEST= Install an extension. Bubble should show same information as windows bubble. Review URL: http://codereview.chromium.org/527012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37671 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Hide browser action buttons when they would otherwise overflow with ↵andybons@chromium.org2010-01-211-6/+80
| | | | | | | | | | the omnibar. TEST=none BUG=29838 Review URL: http://codereview.chromium.org/553038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36789 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Refactors BrowserActionButton to be within its own file, also breaking ↵andybons@chromium.org2010-01-191-0/+1
| | | | | | | | | | a circular dependency on BrowserActionsController. BUG=none TEST=none Review URL: http://codereview.chromium.org/543117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36545 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Implementation of Page Action tooltips. Also adds cursor rects to the ↵andybons@chromium.org2009-12-291-0/+2
| | | | | | | | | | address bar for any icon you can click within it so that the default pointer is shown instead of the I-beam. BUG=12281 TEST=Hover over a Page Action that has a tooltip, observe that the tooltip shows up and that the cursor is a pointer, not an I-Beam. Review URL: http://codereview.chromium.org/523015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35347 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-01 15:09:21 +0000