summaryrefslogtreecommitdiffstats
path: root/chrome/browser/cocoa
Commit message (Collapse)AuthorAgeFilesLines
* [GTTF] Reduce header dependencies in chrome.phajdan.jr@chromium.org2009-11-305-0/+6
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/454004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33301 0039d316-1c4b-4281-b951-d872f2087c98
* Clear the target/action of the close button when the view goes into the ↵pinkerton@chromium.org2009-11-302-1/+12
| | | | | | | | | closing state in an attempt to prevent errant messages to dead objects. BUG=24987 TEST=open a ton of tabs, rapidly click the close box, hope nothing crashes and the tabs still close correctly. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33291 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: improve apparent z-order problems when switching Spaces.viettrungluu@chromium.org2009-11-303-12/+33
| | | | | | | | | | | | | | | | | Remove the status bubble as child window when hidden, rather than just setting its opacity to 0. I'm not sure about the effects, if any, of doing this rather than destroying the window completely. This doesn't eliminate z-order problems with Spaces, but should improve it considerably. This may also ameliorate the problems with moving windows between Spaces using Expose. BUG=28107, 24956 TEST=Create a bunch of windows; get the status bubble to appear in the active (key) window and then get it to disappear; switch to another spaces and back; make sure the active window is on top; repeat. Review URL: http://codereview.chromium.org/434120 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33287 0039d316-1c4b-4281-b951-d872f2087c98
* In-application Keystone ticket promotion.mark@chromium.org2009-11-2813-53/+2029
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The concept of "ticket promotion" is added to the application when Keystone is in use. Ticket promotion is used to turn a user Keystone ticket, which Chrome normally establishes when it launches, into a system Keystone ticket, after successful user authentication and authorization. Having a system Keystone with a system ticket means that updates are applied with root privileges instead of user privileges, essentially eliminating the possibility that a user will fall off of the auto-update train because they can read and execute but not write the application. Two principles of promotion apply: - An application on a user ticket NEEDS promotion if it determines that it doesn't have permission to write to itself. Being on a user ticket, an update attempt would fail. - An application on a user ticket WANTS promotion if it already NEEDS promotion. Additionally, if it is installed in a system-wide location such as /Applications, it will WANT promotion, even if it does not NEED it. If promotion is needed, an info bar will show up on launch requesting it. This info bar works similarly to the default browser info bar: it has a "don't bother me again" button, it will only show up after the first launch, it won't disappear on navigation if the navigation happens very quickly, and it won't show itself if another info bar is up. This means that if both the default browser info bar and the promotion info bar have a shot at showing, only one will win. In my experience, each wins about half of the time. If promotion is needed, the update UI in the About window will be hidden. Checking for updates and offering to apply them doesn't make much sense when the update won't be able to install successfully. All of the auto-update machinery is still working in the background, but the About window UI is hidden. If promotion is wanted, the About window will contain a new button allowing the user to enter promotion. This gives access to the same promotion routine as the promotion info bar. It can be used even from an administrative account that is able to update the application without promotion. It's intended to be used by the system administrator of the family without requiring them to switch to one of the kids' accounts. BUG=16360 TEST=Exhaustively, please. Review URL: http://codereview.chromium.org/437053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33241 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: give visual feedback for bookmark button drags.viettrungluu@chromium.org2009-11-256-13/+151
| | | | | | | | | | | | | | | Draw a "ugly black bar" (where "black" is actually a theme colour) to indicate where a bookmark button that's being dragged will end up if dropped. This is a stopgap measure for the beta. Later, we will make the buttons move around instead (even if implementable in the time remaining, such animations would be a crash risk). BUG=17608 TEST=Drag bookmark bar buttons around. Make sure that the bar indicating where a button will be dropped is visible enough and accurate. Repeat with various themes. Review URL: http://codereview.chromium.org/437051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33079 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: fix Esc-key cancellation of bookmark bar button drags.viettrungluu@chromium.org2009-11-252-8/+17
| | | | | | | | | | | | | The drag would be cancelled after pressing Esc, but moving the mouse again would cause the bookmark bar button to see a drag again and start a new drag. This patch makes the button wait for the next mouse down. BUG=28502 TEST=Drag bookmark bar button and keep mouse button; press Esc (and see cancellation animation); move mouse again and make sure a new drag doesn't start. Review URL: http://codereview.chromium.org/437055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33067 0039d316-1c4b-4281-b951-d872f2087c98
* Changed SyncStatusUIHelper namespace class into a real namespace ↵akalin@chromium.org2009-11-254-6/+6
| | | | | | | | | | | | | | | | | | | (sync_ui_util), per style guide. Changed static functions into anonymous-namespace functions. Renamed files/namespaces from sync_status_ui_helper to sync_ui_util. Moved sync_ui_util_mac.mm functions into sync_ui_util namespace. Updated all callers. BUG=none TEST=trybots Review URL: http://codereview.chromium.org/414065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33044 0039d316-1c4b-4281-b951-d872f2087c98
* Allow the window to be moved when dragging on the incognito iconviettrungluu@chromium.org2009-11-241-2/+13
| | | | | | | | | | BUG=25028 TEST=Drag the window from both incognito view and regular window bar while it's in foreground and background Review URL: http://codereview.chromium.org/434030 Patch from feldstein. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32997 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: make bookmark bar drag buttons prettier.viettrungluu@chromium.org2009-11-243-26/+138
| | | | | | | | | | | (In particular, clip them to their rounded rectangle.) BUG=28593 TEST=Drag bookmark bar buttons with a wide variety of themes; make sure edges/corners are correctly clipped from drag images. Review URL: http://codereview.chromium.org/435028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32995 0039d316-1c4b-4281-b951-d872f2087c98
* o Updates the browser action buttons when a tab is changed. This is needed ↵andybons@chromium.org2009-11-243-1/+17
| | | | | | | | | | | | for tab-specific browser action buttons. o If a tooltip is not present on a browser action button, clear the tooltip of the button. BUG=28719 TEST=Load chrome/test/data/extensions/api_test/browser_tab_specific_state, play around with it in different tabs and make sure that the state remains the same per tab. Review URL: http://codereview.chromium.org/434047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32980 0039d316-1c4b-4281-b951-d872f2087c98
* Switch theme loading to use its own string.avi@google.com2009-11-241-2/+1
| | | | | | | | | BUG=http://crbug.com/24177 TEST=no visible change Review URL: http://codereview.chromium.org/361006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32934 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: improve hover/clicked state appearance of bookmark bar buttons.viettrungluu@chromium.org2009-11-241-33/+56
| | | | | | | | | | | | | I more or less implemented things as per discussion with Cole and Glen. (This does not re-create the appearance on Win Chrome, which is not exactly right either.) BUG=28477 TEST=Load various themes (in particular, "Karim Rashid") and make sure bookmark bar buttons look good and legible in hover and pressed states. Review URL: http://codereview.chromium.org/440001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32930 0039d316-1c4b-4281-b951-d872f2087c98
* Fix to prevent selecting a popup menu item from crashing when the item is ↵avi@google.com2009-11-241-2/+5
| | | | | | | | | | | auto-opened. BUG=http://crbug.com/28215 TEST=as in bug Review URL: http://codereview.chromium.org/431019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32925 0039d316-1c4b-4281-b951-d872f2087c98
* Added main menu item for Sync in OS X. (Right below "Preferences..."). Made ↵akalin@chromium.org2009-11-245-142/+37
| | | | | | | | | | | | | it work without a browser window being present. Moved menu verification code into sync_status_ui_helper_mac{.h,.mm,_unittest.mm}. BUG=27995 TEST=tested that the main menu item worked with or without a browser window. tested that the main menu item didn't show up unless --enable-sync was passed in. Review URL: http://codereview.chromium.org/423004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32892 0039d316-1c4b-4281-b951-d872f2087c98
* Removed browser owned by HtmlDialogWindowController. This fixes the crashakalin@chromium.org2009-11-232-28/+48
| | | | | | | | | | | | | | | | | | described in issue 28329. Use a non-incognito profile for HTML dialogs and any links launched from them. This diverges from the behavior on Windows, but according to beng this is okay. Made it so that HTML dialog boxes don't keep history. BUG=28329 TEST=made sure there is no crash when closing the browser with the sync setup wizard open Review URL: http://codereview.chromium.org/416004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32851 0039d316-1c4b-4281-b951-d872f2087c98
* Add platform abstraction for simple error box, and use it in a couple ↵estade@chromium.org2009-11-231-10/+0
| | | | | | | | | | | | extensions-related places. Also add a virtual destructor in some unrelated infobar. BUG=27691 Review URL: http://codereview.chromium.org/427002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32840 0039d316-1c4b-4281-b951-d872f2087c98
* Take 2 at moving NTP CSS resources into the NTP resource cache.tony@chromium.org2009-11-231-0/+1
| | | | | | | | | | | | | | | | | | Moving the HTML to the cache saved 8ms on New Tab Warm on Windows, maybe we can shave a few more ms off by moving the CSS. The last change had a regression on the mac new tab perf, so I suspect it's the extra round trip to the UI thread when trying to load the CSS (the UI thread is probably just busy at that time). Instead, I'm moving the generation of the CSS to the time the object is constructed, rather than when the resource is requested. This is like the code before, except sometimes we'll hit the cache. BUG=26228 Review URL: http://codereview.chromium.org/427003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32815 0039d316-1c4b-4281-b951-d872f2087c98
* Improve unit test robustness.mrossetti@chromium.org2009-11-231-1/+1
| | | | | | | | | BUG=28405 TEST=none Review URL: http://codereview.chromium.org/425007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32814 0039d316-1c4b-4281-b951-d872f2087c98
* Call FNNotify on download complete; this should help apps watching the ↵avi@google.com2009-11-231-1/+8
| | | | | | | | | | | | downloads folder. BUG=none TEST=If Transmission is watching the Downloads folder, it should catch a completed download immediately. Review URL: http://codereview.chromium.org/437006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32808 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: fix toolbar sizing bug upon unloading extension/theme.viettrungluu@chromium.org2009-11-221-0/+7
| | | | | | | | | BUG=28476 TEST=Install any theme (e.g., "Classic"); click "undo" in infobar; toolbar layout shouldn't change (and the toolbar's contents should be sized correctly). Review URL: http://codereview.chromium.org/418048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32792 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: minor cleanup of constants in toolbar_controller.mm.viettrungluu@chromium.org2009-11-221-12/+16
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/418049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32779 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Implement profile error dialog.thakis@chromium.org2009-11-211-1/+18
| | | | | | | | | | | | | | | The "active window" change was done for linux in http://codereview.chromium.org/147091 and might fix other problems too. Without this, BrowserList::GetLastActive() returns NULL in Browser::Observe(), which caused the new function not to be called. It looks something like http://imgur.com/6PHQm . BUG=26377 TEST= chmod -r ~/Library/Application\ Support/Chromium/Default/History* Then start chromium (release build, so that we survive some sqlite dchecks) and make sure it displays an error message (then chmod +r again) Review URL: http://codereview.chromium.org/418040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32738 0039d316-1c4b-4281-b951-d872f2087c98
* Replaced HungRendererDialog class with hung_renderer_dialog namespace.akalin@chromium.org2009-11-201-4/+8
| | | | | | | | | BUG= TEST=trybots Review URL: http://codereview.chromium.org/415006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32697 0039d316-1c4b-4281-b951-d872f2087c98
* Ensures the renderer gets focus/blur message when switching tabs.jcampan@chromium.org2009-11-203-2/+21
| | | | | | | | | | | BUG=26610 TEST=Open a page in a teb that prints out when the window object gets focused blured. Switch to another tab then come back to that tab. A blur and focus events should have been fired. Review URL: http://codereview.chromium.org/402091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32696 0039d316-1c4b-4281-b951-d872f2087c98
* Allow folders to be created with empty names.mrossetti@chromium.org2009-11-202-9/+20
| | | | | | | | | BUG=28318 TEST=Bring up the Add Folder sheet by choosing Add Folder... from the contextual menu. The OK button should always be active. Click OK and a new, unnamed folder should be added. Review URL: http://codereview.chromium.org/414055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32693 0039d316-1c4b-4281-b951-d872f2087c98
* Apply theme color to bookmark button text.jrg@chromium.org2009-11-206-13/+129
| | | | | | | | | | | | | | | | BUG=http://crbug.com/17608 TEST=Add some bookmarks (you must use both folders and marks). Apply a theme and make sure theme color applies bookmark button text for all buttons (including "Other bookmarks"). Create new window and make sure bookmark buttons still fine in new window. Quit and restart Chrome. Make sure theme color still applied to bookmark button text in the same way as before quitting (e.g. same color and still applies to all). Change theme 1 more time and verify color. Review URL: http://codereview.chromium.org/424004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32690 0039d316-1c4b-4281-b951-d872f2087c98
* Change popup construction logic so that folders with empty name is no longer ↵mrossetti@chromium.org2009-11-202-2/+38
| | | | | | | | | | | used for excluding the root node from display, rather, user is_root() for that purpose. A folder with an empty name is now shown as a blank line in the popup. BUG=28313 TEST=Create a new folder with a blank name and add an URL to that folder. Select the new bookmark. Bring up the bubble and click either 'Edit' or 'Close'. It should not crash at this point. Also, click on the popup and a blank line should appear representing the newly created folder. Review URL: http://codereview.chromium.org/418027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32681 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed and clarified comments in html_dialog_window_controller.mm.akalin@chromium.org2009-11-201-3/+4
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/414008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32653 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: remove cursor turd from About dialog.viettrungluu@chromium.org2009-11-202-1/+16
| | | | | | | | | | | | | (The cursor was displayed with full keyboard accessibility enabled.) Changes to About.xib: changed the class of the view containing the legal text to |AboutLegalTextView| (from |NSTextView|). BUG=25570 TEST=Enable Full Keyboard Access, All controls in System Preferences; look in the About Chromium/Google Chrome; there should be no cursor displayed (at the end of the text). Review URL: http://codereview.chromium.org/414028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32598 0039d316-1c4b-4281-b951-d872f2087c98
* Adds popups to browser actions, completing the feature.andybons@chromium.org2009-11-208-17/+403
| | | | | | | | | | | | Adds functionality to choose between two different InfoBubbleView types: white background and gradient background. Screenshot: http://andybons.com/chrome/news_popup.png BUG=23881 TEST=Install a browser action extension that has a popup, click and observe the popup being shown. Initial unit test added, but disabled. Review URL: http://codereview.chromium.org/402077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32589 0039d316-1c4b-4281-b951-d872f2087c98
* Undo my revert at r32524 due to a startup test regression.mpcomplete@chromium.org2009-11-201-1/+1
| | | | | | | | | | | | ExtensionHosts once again spawn extension processes asynchronously. However, if the process is already started, we now initialize the RenderView synchronously. This is so bug 28049 stays fixed. BUG=28049 Review URL: http://codereview.chromium.org/402101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32578 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Add support for growing or shrinking the window during animations.rohitrao@chromium.org2009-11-197-44/+174
| | | | | | | | BUG=http://crbug.com/14900 TEST=No visible impact, yet. Review URL: http://codereview.chromium.org/391035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32560 0039d316-1c4b-4281-b951-d872f2087c98
* Moved a whole pile of unittests over to CocoaTest.dmaclach@chromium.org2009-11-1945-614/+430
| | | | | | | | | | | AboutIPC.xib - Connected up controller to its window and the window delegate to the controller. BUG=26484, 26484 TEST=See repro steps in bugs. Review URL: http://codereview.chromium.org/402066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32551 0039d316-1c4b-4281-b951-d872f2087c98
* Removed parentWindow parameter from HtmlDialogWindowController.akalin@chromium.org2009-11-194-44/+16
| | | | | | | | | | | Center HTML dialogs using [window screen]. BUG= TEST=manual Review URL: http://codereview.chromium.org/407010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32549 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Rename a poorly named class.rohitrao@chromium.org2009-11-191-5/+5
| | | | | | | | BUG=http://crbug.com/28261 TEST=None Review URL: http://codereview.chromium.org/402088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32541 0039d316-1c4b-4281-b951-d872f2087c98
* Moved HtmlDialogWindowDelegateBridge into html_dialog_window_controller.mm.akalin@chromium.org2009-11-192-66/+65
| | | | | | | | | BUG= TEST=trybots,manually compiled Review URL: http://codereview.chromium.org/402075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32537 0039d316-1c4b-4281-b951-d872f2087c98
* Implement "Import Bookmarks and Settings".mrossetti@chromium.org2009-11-194-1/+484
| | | | | | | | | | | | | Changed to MainMenu.xib: Added a new menu item under the ^IDS_SHORT_PRODUCT_NAME menu with the name . This menu item has a tag of 40014 corredponsing to IDC_IMPORT_SETTINGS and is connected to the commandDispatch: action of the CrApplication (First Responder). Changes to Toolbar.xib: Added a new menu item with the name ^IDS_IMPORT_SETTINGS in the same manner as above. BUG=26157 TEST=Launch Chrome and inspect the current bookmarks and settings. With no browser window open and then with a browser window open choose the "Import Bookmarks and Settings..." menu option found under the "Chromium" menu. Also, with a browser window open, hoose the "Import Bookmarks and Settings..." menu option found under the page's tool menu. Select a browser from the popup, choose the items to be imported, and press OK. Then inspect the bookmarks and other settings to insure that the selected items have indeed been imported. Review URL: http://codereview.chromium.org/378036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32526 0039d316-1c4b-4281-b951-d872f2087c98
* Revert old change that created an ExtensionHost's RenderView asynchronously.mpcomplete@chromium.org2009-11-191-1/+1
| | | | | | | | | | | | | With jam's recent change to spawn renderers from a background thread, ExtensionHost spawns processes asynchronously for free. Reverting this change also fixes a bug due to an extension popup closing before the next one can be created. BUG=28049 Review URL: http://codereview.chromium.org/399098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32524 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Bounce the downloads folder (in the Dock) on completed downloads.avi@google.com2009-11-193-3/+18
| | | | | | | | | BUG=none TEST=download something on SL, watch the Dock bounce. Bounce, Dock, bounce! Review URL: http://codereview.chromium.org/404043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32493 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Fix regression in NTP detached bookmark bar colours.viettrungluu@chromium.org2009-11-191-3/+7
| | | | | | | | | | | The regression was caused by r32425. BUG=28203 TEST=Look at NTP detached bookmark bar: it should be medium-ish grey, not black (or is that dark grey)? Review URL: http://codereview.chromium.org/406009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32461 0039d316-1c4b-4281-b951-d872f2087c98
* Made HtmlDialogWindowController on OS X use its own browser object.akalin@chromium.org2009-11-194-77/+86
| | | | | | | | | | | | | | | Fixed some style violations. Made HtmlDialogWindowDelegateBridge stop doing anything after it receives a close notification. This fixes the crash described in issue 28039. BUG=28039 TEST=trybots,manual Review URL: http://codereview.chromium.org/402065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32445 0039d316-1c4b-4281-b951-d872f2087c98
* Change the folder presentation in the Bookmark Editor and the Bookmark All ↵mrossetti@chromium.org2009-11-199-407/+585
| | | | | | | | | | | | | | Tabs dialogs to a tree view. Nib changes: Removed the NSBrowser and added an NSOutlineView. BUG=26647,26643,26718,27634 TEST=Bring up the bookmark editor by control-clicking in the bookmarks bar and selecting Add Page... or by selecting the Bookmark this Page... menu item found in the Bookmarks menu. Observe that the folder presentation is now a tree view. Select any folder and click New Folder to verify that new folders can be added. Double-click on the newly created folder to change its name. Added folders will not commit until OK is pressed, which will require that a bookmark actually be added. Also bring up the Bookmark All Tabs dialog by control-clicking in the tab bar with more than one tab open and verify that the folder structure is shown in a tree view. Review URL: http://codereview.chromium.org/393006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32441 0039d316-1c4b-4281-b951-d872f2087c98
* Move some more tests over to CocoaTestdmaclach@chromium.org2009-11-182-21/+27
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/405022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32426 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: animate NTP detached bookmark bar <-> normal bookmark bar.viettrungluu@chromium.org2009-11-1815-234/+518
| | | | | | | | | | | Also mostly fix the placement of the "For quick access, place your bookmarks here [...]" message (when there are no bookmarks). It's not quite right in the new animation (detached <-> normal). BUG=25600, 27692, 27693 TEST=Go to NTP and press Cmd-Shift-B a few times while watching closely. The detached bar should "morph" smoothly to the normal bar and vice versa. Switch themes and repeat; please test at least the default theme and the Brushed theme. Review URL: http://codereview.chromium.org/400020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32425 0039d316-1c4b-4281-b951-d872f2087c98
* Tiny style fix.viettrungluu@chromium.org2009-11-181-2/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/402067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32420 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: implement Pin Tab.viettrungluu@chromium.org2009-11-185-97/+196
| | | | | | | | | | | | | | | | | | Note that, per Apple's HIG, the context menu alternates between Pin/Unpin Tab instead of toggling a checkmark. Changes to TabView.xib: - add Pin Tab item (to match Windows) Still to do: - dragging/dropping tabs needs visual feedback to indicate how pinned state will change (need input from UI team) - on Windows, you can pin a tab by dragging it slightly to the right of the rightmost pinned tab; this needs to be done BUG=25481 TEST=not yet Review URL: http://codereview.chromium.org/375010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32384 0039d316-1c4b-4281-b951-d872f2087c98
* move DownloadShelfMac tests over to CocoaTestdmaclach@chromium.org2009-11-181-2/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/407004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32374 0039d316-1c4b-4281-b951-d872f2087c98
* Move status_bubble_mac_unittest over to CocoaTest.dmaclach@chromium.org2009-11-181-9/+16
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/404030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32372 0039d316-1c4b-4281-b951-d872f2087c98
* Move HungRenderedControllerUnitTest over to CocoaTest.dmaclach@chromium.org2009-11-181-3/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/406003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32371 0039d316-1c4b-4281-b951-d872f2087c98
* move delayedmenu_button_unittest over to CocoaTestdmaclach@chromium.org2009-11-181-18/+8
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/406004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32370 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 21:17:43 +0000