summaryrefslogtreecommitdiffstats
path: root/chrome/browser/cocoa
Commit message (Collapse)AuthorAgeFilesLines
* Chrome side of consolidating zoom code for pepper plugins (i.e. pdf) and the ↵jam@chromium.org2010-10-011-6/+0
| | | | | | | | rest of Chrome. Allows plugins to have different zoom ranges, and also to update zoom on its own. Review URL: http://codereview.chromium.org/3419023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61153 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Convert the page info window to a bubble.rsesek@chromium.org2010-09-3010-9/+688
| | | | | | | | | BUG=52430,52916 TEST=Enable Page Info Bubble in about:labs and click on the lock icon. Review URL: http://codereview.chromium.org/3461016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61077 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: use chrome/test/test_timeouts in more places.phajdan.jr@chromium.org2010-09-301-6/+8
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3512001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61038 0039d316-1c4b-4281-b951-d872f2087c98
* Convert ElideFilename from using wstring to string16.tony@chromium.org2010-09-292-3/+4
| | | | | | | | | | Some small cleanups of wstring::npos usage. BUG=23581 Review URL: http://codereview.chromium.org/3390035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61003 0039d316-1c4b-4281-b951-d872f2087c98
* Use PrefChangeRegistrar everywheredanno@chromium.org2010-09-296-42/+17
| | | | | | | | | | | BUG=54955 TEST=PrefChangeRegistrarTest.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60169 Review URL: http://codereview.chromium.org/3304015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60935 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: remove flaky mark from following tests:phajdan.jr@chromium.org2010-09-291-3/+1
| | | | | | | | | | | | | | | | | | | | | | | | | - FilePathWatcherTest.DeleteAndRecreate (bug 54822) - FilePathWatcherTest.DirectoryChain (bug 54822) - FilePathWatcherTest.MoveChild (bug 54822) - FilePathWatcherTest.MoveParent (bug 54822) - FilePathWatcherTest.NonExistentDirectory (bug 54822) - AccountScreenTest.TestSchemeInspector (bug 46274) - SavePageBrowserTest.SaveCompleteHTML (bug 52292) - DownloadRequestLimiterTest.Allow (bug 39753) - PPAPITest.Graphics2D (bug 54150) - ExtensionApiTest.Storage (bug 42943) - BrowserEncodingTest.TestEncodingAliasMapping (bug 51716) - BrowserCrApplicationAppleScriptTest.InsertWindow (bug 53584) - ExtensionInstallUIBrowserTest.TestThemeInstallUndoResetsToDefault (bug 43441) TBR=mal BUG=54822, 46274, 52292, 39753, 54150, 42943, 51716, 53584, 43441 TEST=none Review URL: http://codereview.chromium.org/3545003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60923 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor AppModalDialog to more clearly isolate platform specific UI pieces ↵ben@chromium.org2010-09-282-0/+266
| | | | | | | | | | | and eliminate the dependency on individual frontends from cross platform code. BUG=none TEST=none Review URL: http://codereview.chromium.org/3398015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60785 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Remove flaky mark from the following tests:phajdan.jr@chromium.org2010-09-281-2/+1
| | | | | | | | | | | | | | | | | | | | | | - AccountScreenTest.TestBasic (bug 49004) - NPAPIVisiblePluginTester.VerifyNPObjectLifetimeTest (bug 34997) - ChromeFrameTestWithWebServer.WidgetModeFF_CFInstanceSingleton (bug 31532, still one test to be fixed in that bug) - SavePageBrowserTest.FileNameFromPageTitle (bug 52292) - FilePathWatcherTest.DisappearingDirectory (bug 54822) - FilePathWatcherTest.DestroyWithPendingNotification (bug 54822) - FilePathWatcherTest.WatchDirectory (bug 54822) - FilePathWatcherTest.Unregister (bug 54822) - FilePathWatcherTest.DeleteDuringNotify (bug 54822) - WindowAppleScriptTest.WindowOrder (bug 53584) TBR=mal BUG=49004, 34997, 31532, 52292, 54822, 53584 TEST=none Review URL: http://codereview.chromium.org/3471020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60776 0039d316-1c4b-4281-b951-d872f2087c98
* Add search engine selection dialog for Mac, do new-style first-run.avi@chromium.org2010-09-274-78/+369
| | | | | | | | | | | | SearchEngineDialog.xib: creation FirstRunDialog.xib: removal of import and cancel UI elements BUG=47651 TEST=reset profile, run. Make sure goto/chromefirstrun is satisfied. Review URL: http://codereview.chromium.org/3223010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60699 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Do not insert an "About Chrome" item when the Wrench menu shows an ↵rsesek@chromium.org2010-09-273-35/+0
| | | | | | | | | | | | | | | available update. Changes to the WrenchMenuModel have made |-[WrenchMenuController insertUpdateAvailableItem]| obsolete. The Upgrade item is now inserted when the menu is built but is just marked as hidden; the About item is now distinct and never inserted on Mac. BUG=56023 TEST=Be out of date with 1 window open. Wait for the upgrade ball to appear. Open the Wrench menu and do not see an "About Chrome" item. Review URL: http://codereview.chromium.org/3455027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60695 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Cmd-clicking a download button shows the download instead of opening it.thakis@chromium.org2010-09-271-2/+8
| | | | | | | | | BUG=55052 TEST=Download something. Cmd-click the download in the shelf, should show it in finder. Click the item in the shelf, it should open. Review URL: http://codereview.chromium.org/3387019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60646 0039d316-1c4b-4281-b951-d872f2087c98
* Also use plugin group identifiers in PluginExceptionsTableModel.bauerb@chromium.org2010-09-261-11/+15
| | | | | | | | | BUG=39252 TEST=TableModelArrayControllerTest.*:PluginExceptionsTableModelTest.* Review URL: http://codereview.chromium.org/3474010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60615 0039d316-1c4b-4281-b951-d872f2087c98
* Do not save identity preferences on OS Xdavidben@chromium.org2010-09-251-5/+0
| | | | | | | | | | | | | Chrome largely does not use them and interprets them differently from Safari. R=wtc BUG=41669 TEST=logging in with client certificate does not add to Keychain Review URL: http://codereview.chromium.org/3400007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60566 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Ignore omnibox selection changes that come from programmatic eventsisherman@chromium.org2010-09-242-21/+27
| | | | | | | | | BUG=56149,56720 TEST=start typing a url, arrow around in the autocomplete popup menu -- the results should not change. Review URL: http://codereview.chromium.org/3397019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60530 0039d316-1c4b-4281-b951-d872f2087c98
* Add IndexedDB to cookie tree.bauerb@chromium.org2010-09-246-46/+142
| | | | | | | | | | | XIB changes: Add another view with IndexedDB details to CookieDetailsView.xib. BUG=56248 TEST=CookiesTreeModelTest.*:CookiesDetailsTest.*:CookiesViewTest.*: Review URL: http://codereview.chromium.org/3429020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60470 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Move virtual methods to implementation files.erg@google.com2010-09-232-0/+2
| | | | | | | | | | | Remove logging.h and other headers where possible. BUG=none TEST=none Review URL: http://codereview.chromium.org/3461019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60369 0039d316-1c4b-4281-b951-d872f2087c98
* Move task manager code into a subdirectory.evan@chromium.org2010-09-231-1/+1
| | | | | | | | | BUG=50548 TEST=compiles Review URL: http://codereview.chromium.org/3454028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60325 0039d316-1c4b-4281-b951-d872f2087c98
* Earlier we used to show a static image in this state, instead we now show ↵satish@chromium.org2010-09-231-4/+5
| | | | | | | | | | | | | | | the animation. The images for each step of the animation are stored horizontally next to each other in a sprite image and during the animation we just draw the same bitmap with the x origin moving around from one step to another and wrapping around. BUG=53598 TEST=manual, start speech recognition, speak something and wait for the animation to show up on screen. Review URL: http://codereview.chromium.org/3417012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60282 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] 1) Status bubble respects page contents view bounds, not just its ↵alekseys@chromium.org2010-09-236-49/+136
| | | | | | | | | | | | | vertical size; 2) Bubble expansion preserves bubble's current position; 3) Bubble won't expand if it's going to cover current mouse position in the expanded state. BUG=54882,56434 TEST=All usual status bubble tests (mouse evasion, fullscreen mode, devtools and download panel interaction) plus the same with sidebar open. Status bubble should behave as expected plus it should not cover sidebar content in mouse or screen bottom evading mode. Review URL: http://codereview.chromium.org/3347022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60240 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Don't allow new I/O after profile dir is gone.shess@chromium.org2010-09-221-4/+9
| | | | | | | | | | | | | | | | Mac tests have lots of failures in ImportantFileWriter. It is because the scoped temp dir associated with the testing profile is being deleted before the background task on the FILE thread scheduled by ImportantFileWriter is run. Other places in the code simply don't have a FILE thread, so the task is dropped. This gets rid of those threads before deleting the testing profile in ~BrowserTestHelper(). BUG=none TEST=fewer nuisance log lines in unit_tests. Review URL: http://codereview.chromium.org/3440012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60222 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 60169 - Use PrefChangeRegistrar everywheredanno@chromium.org2010-09-225-16/+40
| | | | | | | | | | | BUG=54955 TEST=PrefChangeRegistrarTest.* Review URL: http://codereview.chromium.org/3304015 TBR=danno@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60170 0039d316-1c4b-4281-b951-d872f2087c98
* Use PrefChangeRegistrar everywheredanno@chromium.org2010-09-225-40/+16
| | | | | | | | | BUG=54955 TEST=PrefChangeRegistrarTest.* Review URL: http://codereview.chromium.org/3304015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60169 0039d316-1c4b-4281-b951-d872f2087c98
* Makes match preview send the dimensions of the omnibox to the page.sky@chromium.org2010-09-222-0/+7
| | | | | | | | | BUG=54833 TEST=none Review URL: http://codereview.chromium.org/3417011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60153 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: clang buildthakis@chromium.org2010-09-222-2/+8
| | | | | | | | | | | | | Fixes the last few warnings / errors necessary to build chrome/mac with clang. See http://code.google.com/p/chromium/wiki/Clang BUG=none TEST=none Review URL: http://codereview.chromium.org/2762014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60131 0039d316-1c4b-4281-b951-d872f2087c98
* Extend speech input bubble in Mac to display error messages with try-again ↵satish@chromium.org2010-09-212-36/+110
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | and cancel buttons. The SpeechInputBubbleImpl object now lives longer than the actual info bubble window, and allows the caller to create a bubble on screen or update with an error message when needed. When recording speech, the layout of controls are (vertical): - Label ('Speak now') - Icon (Mic or wait) - Button Bar (Horizontal, 1 button, 'Cancel') When showing a message, the layout of controls are (vertical): - Label (message text) - Button Bar (Horizontal, 2 buttons, 'Try Again' and 'Cancel') Also made a small correction to the info bubble's anchor point to get the arrow point at the correct starting point of the given element rect. XIB changes: - Added a 'try again' button and hooked it up to the tryAgainButton outlet in the controller - Moved position of the cancel button for easier editing in interface builder BUG=53598 TEST=manual, unplug mic and start recognition to check error message, and similarly give no speech to check. Review URL: http://codereview.chromium.org/3438002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60112 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Unbreak doubleclicking task manager rows.thakis@chromium.org2010-09-211-1/+1
| | | | | | | | | BUG=54910 TEST=see bug Review URL: http://codereview.chromium.org/3414012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60111 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bunch of clang warnings/errors.thakis@chromium.org2010-09-213-6/+9
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/3473006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60109 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable BrowserWindowControllerTest.TestNormalisherman@chromium.org2010-09-211-2/+1
| | | | | | | | | BUG=54945 TEST=BrowserWindowControllerTest.TestNormal Review URL: http://codereview.chromium.org/3440014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60097 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Fix a problem with flicker when moving the mouse off the reload button.rohitrao@chromium.org2010-09-211-0/+9
| | | | | | | | BUG=46981 TEST=Click on the reload button and leave the mouse inside. When the page is finished reloading, move the mouse out of the button. The button should re-enable and change from stop to reload, but the border should not flicker. Review URL: http://codereview.chromium.org/3467003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60085 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Explicitly set Space when existing full screen rohitrao@chromium.org2010-09-213-0/+135
| | | | | | | | | | | | | | | | | | | | If a user moves the full screen window to a different space they get snapped back to the original space when they exit full screen. The problem is that internally the full screen window is a different window than the normal browser window. This means that any changes the user makes to the full screen window aren't reflected on the normal browser window. The correct fix for this bug is to create a new browser window when the user exits full screen. This new window would then be on the correct space. This would require a fairly large architectural change to the BrowserWindowController class. My proposed fix is much simpler. When exiting full screen we simply move the normal browser window to the Space that the full screen window is on. Original review at: http://codereview.chromium.org/3345005/show Patch by Sailesh Agrawal <fnepal@gmail.com>. BUG=41693 TEST=Moved the full screen window to a different Space. Verified that exiting full screen didn't change the active Space. Review URL: http://codereview.chromium.org/3386015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60063 0039d316-1c4b-4281-b951-d872f2087c98
* Add a unique identifier for plugin groups and use it to identify blocked ↵bauerb@chromium.org2010-09-211-6/+7
| | | | | | | | | | | | | | | plugins. Currently we use the plugin path as identifier for per-plugin content settings, which is not stable across Chrome updates or plugin moves. The new identifier is either hardcoded (for predefined plugin groups), or the filename without path. BUG=39252 TEST=none Review URL: http://codereview.chromium.org/3384014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60054 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Refactor the DevToolsController and SidebarController to create their ↵rohitrao@chromium.org2010-09-1710-123/+152
| | | | | | | | | | | | | | | | views directly. Remove references to the devtools and sidebar NSSplitViews from TabWindowController. This also fixes the issue where the findbar and resize widget would disappear. For some reason, the NSSplitViews were indicating that they were opaque when instantiated in the xib files, but this does not happen when they are created programmatically. Xib changes: - BrowserWindow.xib no longer contains the two NSSplitViews. BUG=55228,55441 TEST=All unittest should pass. TEST=Findbar and resize widget should not disappear when scrolling. Review URL: http://codereview.chromium.org/3436009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59841 0039d316-1c4b-4281-b951-d872f2087c98
* Remove vestigial cookie/web app permissions prompting UI now that the async ↵ben@chromium.org2010-09-1713-628/+7
| | | | | | | | | | UI has been approved for M7.This allows me to more easily change the way the appmodal dialog system works. http://crbug.com/55121 TEST=existing tests Review URL: http://codereview.chromium.org/3299020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59838 0039d316-1c4b-4281-b951-d872f2087c98
* Make status bubble expand on Mac to fit URLs longer than the standard width.mirandac@chromium.org2010-09-173-9/+192
| | | | | | | | | BUG=43193, 55770 TEST=status bubble resizes on Mac to fit URLs longer than standard bubble size. Review URL: http://codereview.chromium.org/3437002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59832 0039d316-1c4b-4281-b951-d872f2087c98
* Update omnibox popup when selection changes.isherman@chromium.org2010-09-171-0/+11
| | | | | | | | | | | | | The original motivation for this cl corresponds to bug 47210: If the user changes the selection by arrowing around in the omnibox, we should detect this as accepting the inline autocomplete suggestion. Otherwise, if the user subsequently presses ctrl (e.g. as part of the keystroke ctrl-d to perform a forward delete), the omnibox contents are reverted as if the user had never arrowed around. The other motivation is just to match the behavior on Windows, which detects changes to the selection. BUG=47210 TEST=none Review URL: http://codereview.chromium.org/3126024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59770 0039d316-1c4b-4281-b951-d872f2087c98
* Moves TabStripModelObserver/Delegate into their own headers.sky@chromium.org2010-09-166-1/+9
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3425009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59733 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Add a few more keyboard shortcuts to tabpose.thakis@chromium.org2010-09-161-20/+184
| | | | | | | | | | | | | | * shift / tab-shift cycle through all open tabs * arrow keys move selection up, down, left, right * cmd-1-8 selects tab 1-8 and exits tabpose, cmd-9 selects last tab and exits tabpose * cmd-ctrl-t exits tabpose BUG=50307,55530 TEST=try it Review URL: http://codereview.chromium.org/3389010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59703 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Size popup windows correctly.rohitrao@chromium.org2010-09-161-1/+26
| | | | | | | | BUG=48428 TEST=Popup windows should open with the correct content size (while still respecting the 400x250 minimum window size). Review URL: http://codereview.chromium.org/3408003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59678 0039d316-1c4b-4281-b951-d872f2087c98
* Show a volume indicator as audio is being recorded.satish@chromium.org2010-09-161-2/+2
| | | | | | | | | | | | | | | | | | | Per UX input from Cole, this matches the implementation in the android voice actions app. Changes in this CL: - Instead of the old mic icon use the recently added mic-volume-empty, mic-volume-full and mask images for the volume indicator. - Extended the endpointer code to return the audio RMS level (copied from the original source). - SpeechRecognizer receives the above calculated RMS level and computes a volume level in the [0.0-1.0] range. - SpeechInputManager receives the above computed volume level and passes it to SpeechInputBubbleController for display, which passes it to SpeechInputBubble. - SpeechInputBubbleBase creates the appropriate skia bitmap for the volume indicator and passes to the platform specific code for display. - As part of the above SpeechInputBubbleController addition for volume level, I wrote a single function to process all calls received by it and handled in the UI thread for simplicity. BUG=53598 TEST=updated existing tests. Also test manually, use speech input and verify the audio level changes appropriately in the UI as mic is moved near and far. Review URL: http://codereview.chromium.org/3384005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59638 0039d316-1c4b-4281-b951-d872f2087c98
* Factor an ExtensionIconSet class out of Extension. This canaa@chromium.org2010-09-161-4/+6
| | | | | | | | | | | | | | be passed to the IO thread or into renderers, where its functionality can be reused without having to reimplement. This will be used in the fix for bug 53495. BUG=53495 TEST=unit_tests --gtest_filter=Extension* Review URL: http://codereview.chromium.org/3432001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59597 0039d316-1c4b-4281-b951-d872f2087c98
* Unsubscribe SidebarController from NSSplitView updates in dealloc (no zombies).alekseys@chromium.org2010-09-152-3/+6
| | | | | | | | | | | Enable ViewIDTest.Fullscreen back. BUG=55643 TEST=browser_tests --gtest_filter=ViewIdTest.Fullscreen Review URL: http://codereview.chromium.org/3424006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59532 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Add per-plugin exceptions to content settings.bauerb@chromium.org2010-09-157-119/+532
| | | | | | | | | | | | | | | Screenshot: http://www.dropmocks.com/mXMd I'm adding a subclass of NSArrayController, TableModelArrayController, that binds to a RemoveRowsTableModel that can use groups and displays them using group rows in an NSTableView. This cleans up SimpleContentExceptionsWindowController a lot, and the class could also be used for other table models that use groups (keyword editor and autofill). XIB changes: In SimpleContentExceptionsWindow.xib, bind table view to TableModelArrayController instead of using the dataSource outlet. Buttons call actions on TableModelArrayController, and table view delegate also points to it. BUG=39252 TEST=SimpleContentExceptionsWindowControllerTest.*:TableModelArrayControllerTest.*:PluginExceptionsTableModelTest.* Review URL: http://codereview.chromium.org/3327016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59501 0039d316-1c4b-4281-b951-d872f2087c98
* Disable ViewIDTest.Fullscreen -- it's crashyisherman@chromium.org2010-09-151-1/+3
| | | | | | | | | BUG=55643 TEST=browser_tests --gtest_filter=ViewIdTest.Fullscreen Review URL: http://codereview.chromium.org/3446003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59461 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Refactor FramedBrowserWindowTest.DoesHideTitle for valgrind.shess@chromium.org2010-09-143-26/+14
| | | | | | | | | | | | Revised to use NSBitmapImageRep to snapshot, rather than going through PDF, so it doesn't need a bunch of new valgrind suppressions. BUG=30384 TEST=valgrind green Review URL: http://codereview.chromium.org/3297019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59457 0039d316-1c4b-4281-b951-d872f2087c98
* Bunch of match preview tweaks:sky@chromium.org2010-09-144-0/+18
| | | | | | | | | | | | | | | | . Makes MatchPreview owned by Browser rather than each TabContents. . Makes MatchPreview dismiss when the omnibox closes. . Supports the ability to send script to the page rather than reloading on every keystroke. . Supports receiving results from the page that drives the suggest text in the omnbox. BUG=54833 TEST=none Review URL: http://codereview.chromium.org/3332022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59428 0039d316-1c4b-4281-b951-d872f2087c98
* Add to the task manager the v8 column on mac and the javascript column on ↵thakis@chromium.org2010-09-141-0/+19
| | | | | | | | | | | mac and linux. BUG=None (js column was added for windows in http://codereview.chromium.org/276009 ), 27226 (v8 column) TEST=Add v8 and javascript columns using the task manager's context menu. should work on all platforms now. Review URL: http://codereview.chromium.org/3419001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59366 0039d316-1c4b-4281-b951-d872f2087c98
* Fix SessionStoragejorlow@chromium.org2010-09-144-4/+6
| | | | | | | | | | | | | | | Apparently the session storage code was pretty horribly broken. It didn't correctly handle tabs being restored, didn't have the proper lifetime (this was the issue exposed in the bug), and had many leaks. To fix this, things had to be plumbed fairly differently. We need to pass session storage in on TabContents creation to ensure that the first RenderView will have the correct session storage id. When closing a tab, we need to save the session storage with the restoration service. When restoring a tab, we pass it back into the tab contents class. When duplicating a tab, we clone the storage. Lifetimes are now handled by standard reference counting code. A SessionStorageNamespace object wraps an ID. When it's instantiated, it allocates an ID. When it's destroyed, it deletes the ID. IDs make this process very lightweight (the heavyweight stuff is allocated on first use of SessionStorage) and it seperates the more complex lifetimes of SessionStorage namespaces (where less deterministic shutdown is more tollerable) from the LocalStorage namespace which needs to shutdown very precisely. BUG=52393 TEST=Set some variable on session storage; close the tab; re-open the tab; the variable should still be set. You can also run through the repro steps in the bug. Review URL: http://codereview.chromium.org/3325012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59350 0039d316-1c4b-4281-b951-d872f2087c98
* Create a DefaultPrefStore to hold registered application-default preference ↵pam@chromium.org2010-09-141-2/+1
| | | | | | | | | | | | | | | values. Also rework preference notifications so they're not sent when a pref store rewrites the same value it already had, to avoid infinite recursion in places that set a pref in response to a notification that that pref has changed. This allows notifications to be sent properly when another PrefStore takes control from a default value. BUG=52719, 54950 TEST=covered by unit tests (PrefValueStoreTest.*, PrefNotifierTest.*, and ExtensionPrefStoreTest.*) Review URL: http://codereview.chromium.org/3323022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59345 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: push back the detached tab position inside the dragging window. tkent@chromium.org2010-09-142-1/+34
| | | | | | | | | BUG=32597 TEST=manual Patch by morrita@google Original code review: http://codereview.chromium.org/3333018/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59342 0039d316-1c4b-4281-b951-d872f2087c98
* Remove create_app_shortcut param from ↵tfarina@chromium.org2010-09-144-15/+5
| | | | | | | | | | | | | | | ExtensionInstallUI::Delegate::InstallUIProceed. Reason: We don't support shortcut creation from this dialog anymore. (Note: this was a TODO for Aaron). BUG=None TEST=trybots Review URL: http://codereview.chromium.org/3305030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59323 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-03 21:45:25 +0000