| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
TBR=darin
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41812 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Added AddSystemNotification to add system notification
and UpdateNotification to update a notification.
* refactored NotificationObjectProxy and added NotificationDelegate class.
* Added notification_browser.cc.
BUG=33306
TEST=added notification_browser.cc with minimal test. I'll add more in next step.
Review URL: http://codereview.chromium.org/1013002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41801 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Only the chromium part is for review. The webkit part shows how that will look when I create the patch for webkit later. This can be landed without the change to webkit.
TODO later:
- use the image on windows, mac
- implement the other DragImageRef functions
TEST=drag an image from the render view in GTK
BUG=11457
Review URL: http://codereview.chromium.org/668125
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41799 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I hijacked the extension install/uninstall dialog, and added another type that
it can transmogrify into.
BUG=32365
Review URL: http://codereview.chromium.org/1041002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41787 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- coding style fixes for ivars
- fixed some 10.6 toolchain warnings from the xib
- provide custom getters for two properties to always return false when the matching controls are hidden.
- Autosize the window to handle any possible l10n now
- Make headers, buttons, and all by the stats/breakpad checkbox force the window to grow as needed.
- Wrap the stats/breakpad checkbox to the resulting width (it will never fit otherwise).
- Layout/shuffling things based on the views that get hidden (no other browsers to import from, not stats pref).
BUG=37743
TEST=text isn't clipped in any language
Review URL: http://codereview.chromium.org/995002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41758 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/790006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
resolution independence.
BUG=http://crbug.com/19476, http://crbug.com/36366
TEST=click the star in RI and the bubble should position itself correctly; status bubble should have adequate height for text
Review URL: http://codereview.chromium.org/851009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=24390
TEST=When *not* fullscreen, menu items (under View in main menu and in app menu) should be "Enter Full Screen"; when fullscreen, they should be "Exit Full Screen"; menu items should still work; keyboard shortcuts should still work.
Review URL: http://codereview.chromium.org/1011002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41726 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Intended as a temporary fix.
BUG=36225
Review URL: http://codereview.chromium.org/998004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41678 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=38242
TEST=Right-click on bar (not button); pick "add folder". Does not DCHECK in debug build.
Review URL: http://codereview.chromium.org/992002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41677 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The default mouseEntered: implementation forwards to the next responder, and this ends up being the window. Cells don't usually forward this to their view (views only get this if they install tracking areas). So don't forward this to super.
TEST=mouse over a bookmark. Close button shouldn't highlight.
BUG=36814
Review URL: http://codereview.chromium.org/998003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41648 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
bug where the Browser Actions container was displayed and sized in a popup window.
TEST=none.
BUG=38094
Review URL: http://codereview.chromium.org/1001001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41644 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=37912
TEST=Insure the bookmark bar is showing. Click on a folder in the bookmark bar such that the folder contents are shown in a folder menu. Press <cmd-shift-B> and insure that the folder menu is withdrawn as the bookmark bar is hidden.
Review URL: http://codereview.chromium.org/887004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41642 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=37271,37433,37937
TEST=Go fullscreen on the NTP with the bookmark bar detached. Drag a bookmark around. Overlay should not open.
TEST=Go fullscreen on the NTP with the bookmark bar detached. Open a bookmark folder. Overlay should not open.
Review URL: http://codereview.chromium.org/881003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41589 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
back at r41284).
BUG=None
TEST=New unit tests, tree should stay green after this checkin.
Revert "Reland translate toolbar unit tests (originally landed as r41274, rolled back at r41284)."
Revert r41569 - 10.6 unit tests not passing.
Review URL: http://codereview.chromium.org/962001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41579 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Change in xib file disables "avoid empty selection" which leads to an item in the tree already being selected when the dialog opens.
BUG=http://crbug/38069
TEST=manual testing and existing flaky unit test FLAKY_RemoveButtonEnabled
Review URL: http://codereview.chromium.org/841004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41576 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
rolled back at r41284)."
Revert r41569 - 10.6 unit tests not passing.
Review URL: http://codereview.chromium.org/959001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41570 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
back at r41284).
BUG=None
TEST=New unit tests, tree should stay green after this checkin.
Review URL: http://codereview.chromium.org/938001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41569 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=darin
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41559 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/851010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41539 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41534 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=32072
TEST=Ctrl+Click on a page action opens the context menu. A real right-click still does the same.
Review URL: http://codereview.chromium.org/894004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41533 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=36487
TEST=Open bookmark folder. Clicking both the bookmark bar and its opening folder should dismiss it.
Review URL: http://codereview.chromium.org/857009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41480 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
"Change Mac to DCHECK if NetworkChangeNotifier observer list is not empty by destruction time."
Apparently NetworkChangeNotifierMac's observers are still getting leaked in ExtensionApiTest.ShowPageActionPopup.
Review URL: http://codereview.chromium.org/871007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41464 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
destruction time.
Review URL: http://codereview.chromium.org/870003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41459 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=19476
TEST=prefs dialog is usable under RI (scrolling Under the Hood is wonky; don't think we can fix that)
Review URL: http://codereview.chromium.org/915001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41452 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The code for that was already there, but it didn't fire, because clicking on a bookmark button dismissed the bookmark folder controller.
BUG=36487
TEST=click bookmark bar folder twice. first click should open menu, second should close.
Review URL: http://codereview.chromium.org/870006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41438 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
"broken but pretty".
BUG=http://crbug.com/19476
TEST=run in RI and see themes. Still broken a bit but a lot better.
Review URL: http://codereview.chromium.org/879003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41437 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
If it's set (in System Prefs) to minimize windows on double-click (on the title
bar), double-clicking on the blank area of the floating bar will beep.
BUG=37972
TEST=Make sure Minimize is disabled in the Window menu, Cmd-M shouldn't work, and double-clicking on the blank area of the floating bar shouldn't minimize (it should beep if System Prefs is set as described above).
Review URL: http://codereview.chromium.org/862007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41431 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/884003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41419 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also make the fullscreen code do the right thing in theory, even though it
doesn't work and I'll probably shortly remove it.
BUG=none
TEST=Double-clicking on the tab strip should or should not minimize the window according to the system prefs setting; click in the area beside the tabs.
Review URL: http://codereview.chromium.org/859004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41413 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Make them a bit smaller, and make them stay on-screen horizontally (like normal menus)
BUG=36487
TEST=open menu while its folder is close to the screen edge.
Review URL: http://codereview.chromium.org/857007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added two new xibs. The first is a cookie info view that is shared between the tree that shows browser data and the cookie modal prompt to block accepting cookies. The second is a window to replace the NSAlert modal dialog for the cookie prompt. Modified cookie tree code and added cookie prompt code to use new xibs.
Changed "hidden" handling of cookie detail view to use bindings rather than explicit code.
TODOs for http://crbug.com/36948 not in this CL:
- changing the expiration for cookies isn't implemented
TEST=manually testing of modal cookie prompt, new unit tests
BUG=http://crbug.com/36948
Review URL: http://codereview.chromium.org/669127
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=34522
TEST=see bug; it's quite clear.
TBR=mrossetti@chromium.org
Review URL: http://codereview.chromium.org/902004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41396 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When we rebuild the bookmark bar (e.g. something changed), clear the
dragging pasteboard to avoid stale pointers.
BUG=34522
TEST=see bug; it's quite clear.
Review URL: http://codereview.chromium.org/836004
TBR=jrg@chromium.org
Review URL: http://codereview.chromium.org/904002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41395 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
When we rebuild the bookmark bar (e.g. something changed), clear the
dragging pasteboard to avoid stale pointers.
BUG=34522
TEST=see bug; it's quite clear.
Review URL: http://codereview.chromium.org/836004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41392 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bookmark bar menu/folder maximum window width is now 1000, not 150.
High cosmetic impact.
BUG=36487, 17608
TEST=\
1) Add bookmarks on the bar with small (e.g. 'x') and big titles.
Make sure all looks OK (e.g. small ones are small.)
2) Add bookmarks in a folder.
Make sure text is left aligned on the menus.
3) Add bookmarks in a folder with long names (e.g. 100 characters).
Make sure folder/menus are now much wider.
4) Add bookmarks in a folder with mega long names (e.g. 4000 characters).
Make sure menus have a maximum size of ~1000 pixes (no need to be exact but 'no limit' is fail).
5) In a folder, add a subfolder named 'x' and a bookmark with a REAL long name.
Make sure the "button" (menu item) is the full width of the menu.
Review URL: http://codereview.chromium.org/842005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/905001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41384 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=37807
TEST=\
Run a debug build of Chrome like this:
NSZombieEnabled=YES xcodebuild/Debug/Chromium.app/Contents/MacOS/Chromium
Open a bubble then Cmd-Q.
Make sure you don't see a line like this:
2010-03-10 19:24:20.381 Chromium[73024:903] *** -[ChromeBrowserWindow removeChildWindow:]: message sent to deallocated instance 0x18f8b2a0
Repeat 20 times.
Review URL: http://codereview.chromium.org/851005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Create the "off the side" menu on demand (since that has "all the rest" in it).
BUG= http://crbug.com/32843
TEST=1) Do the "sync 1000+ bookmarks" test from the bug and watch Chrome NOT run out of memory.
Make sure these bookmarks are all children of the bar for it to be even harder.
2) Add about 5 bookmarks. Make sure you can grow and shrink (in
width) the window to cause the off-the-side chevron to appear and
disappear as appropriate, and that the off-the-side menu always has
the right contents (bookmarks which fall off the side).
3) Change theme then relaunch; make sure theme set on launch for bookmarks.
4) Using both a big and a small width, make sure the chevron shows (or
not, as appropriate) on launch of Chrome.
Review URL: http://codereview.chromium.org/853001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41359 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/37807
TEST=\
Run a debug build of Chrome like this:
NSZombieEnabled=YES xcodebuild/Debug/Chromium.app/Contents/MacOS/Chromium
Open a bubble then CmdQ.
Make sure you don't see a line like this:
20100310 19:24:20.381 Chromium[73024:903] *** [ChromeBrowserWindow removeChildWindow:]: message sent to deallocated instance 0x18f8b2a0
Repeat 20 times.
Review URL: http://codereview.chromium.org/839003
TBR=jrg@chromium.org
Review URL: http://codereview.chromium.org/902001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41350 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=37717
TEST=none
Review URL: http://codereview.chromium.org/863005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41345 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/37807
TEST=\
Run a debug build of Chrome like this:
NSZombieEnabled=YES xcodebuild/Debug/Chromium.app/Contents/MacOS/Chromium
Open a bubble then Cmd-Q.
Make sure you don't see a line like this:
2010-03-10 19:24:20.381 Chromium[73024:903] *** -[ChromeBrowserWindow removeChildWindow:]: message sent to deallocated instance 0x18f8b2a0
Repeat 20 times.
Review URL: http://codereview.chromium.org/839003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41342 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=37967
TEST=\
1) make sure bookmark buttons still work (click to open)
2) make sure basic DnD of bookmark buttons still works
3) In Debug build, drag a bookmark button. ESC to cancel. Then mouse up.
Make sure no crash.
Review URL: http://codereview.chromium.org/871002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41340 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is enabled.
From http://developer.apple.com/mac/library/DOCUMENTATION/UserExperience/Conceptual/HiDPIOverview/HiDPISupport/HiDPISupport.html:
"Because of scaling, the coordinates of the window frame and its top-level view (the frame view) are not always the same. [...] These methods provide the means to transform geometry to and from a base coordinate space that is pixel-aligned with the backing store into which the view is being drawn."
Stuff is still pretty broken with this patch (it used to be better), but it's a low-hanging fruit.
BUG=19476
TEST=Open QuartzDebug, set scale factor to e.g. 1.5. Reopen Chrome. Tabs should be visible.
Review URL: http://codereview.chromium.org/893001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41336 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=37989
TEST=Go fullscreen on a secondary monitor. Should not hide the menubar.
Review URL: http://codereview.chromium.org/872003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41327 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=37797
TEST=See test cases in bug.
Review URL: http://codereview.chromium.org/801008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41317 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
ToolbarController's) so we stop violating the ODR and things start working properly.
BUG=http://crbug.com/37898
TEST=as in bug
Review URL: http://codereview.chromium.org/887002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41306 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=everything still works
Review URL: http://codereview.chromium.org/793003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41295 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ctrl-enter.
this only hooks up ctrl-enter on gtk for now, but adding it on windows/mac should be trivial
webkit side, which needs to land first, is here:
https://bugs.webkit.org/show_bug.cgi?id=35407
This also enables the FindInPageControllerTest tests on linux/gtk.
BUG=29500
TEST=FindInPageControllerTest.ActivateLinkNavigatesPage
Review URL: http://codereview.chromium.org/660137
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41291 0039d316-1c4b-4281-b951-d872f2087c98
|