summaryrefslogtreecommitdiffstats
path: root/chrome/browser/cocoa
Commit message (Collapse)AuthorAgeFilesLines
* Adds ability to determine if a tab was explicitly closed by thesky@chromium.org2010-05-211-1/+4
| | | | | | | | | | | | user. This will be used to determine if the tab should be restored on startup or not. BUG=4923 TEST=none Review URL: http://codereview.chromium.org/2087012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47923 0039d316-1c4b-4281-b951-d872f2087c98
* Simple code rearranging to better group by function area and protocol.mrossetti@chromium.org2010-05-203-1583/+1601
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/2136020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47838 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 47675.mirandac@chromium.org2010-05-202-2/+2
| | | | | | | | | | Instead of moving data types into common/, create a special class of IPC messages that live in the browser directory, specifically for importing browser-related data. BUG=18774 TEST=none Review URL: http://codereview.chromium.org/2095020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47827 0039d316-1c4b-4281-b951-d872f2087c98
* Elide the EV bubble when it's extremely long. This limits it to half the ↵pkasting@chromium.org2010-05-202-4/+6
| | | | | | | | | | location bar width, unless eliding to that would result in a width of less than 150 px. BUG=42856 TEST=Visit https://www.barbican.org.uk/eticketing/index.asp and make the window smaller. The EV bubble should shrink, eliding in middle, until it hits a minimum size. Review URL: http://codereview.chromium.org/2084012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47819 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Add a preference for the tab key cycling between just form fields, or ↵rsesek@chromium.org2010-05-202-0/+18
| | | | | | | | | | | | | | | links as well. XIB change: Add a checkbox bound to FilesOwner.tabsToLinks underneath the translate webpages preference. BUG=31177 TEST=Uncheck Chromium-->Preferences-->Under the Hood-->Pressing Tab... Then press Tab on Google.com and the links don't get focus; it alternates between search field and location bar. Review URL: http://codereview.chromium.org/2082011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47807 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent valgrind errors due to incomplete animations by providing a test ↵mrossetti@chromium.org2010-05-205-5/+29
| | | | | | | | | | | setting to have animations ignored. Apply it to the BookmarkBarControllerTest.OffTheSideButtonHidden unit test. BookmarkBarController and BookmarkBarFolderController now have a -[setIgnoreAnimations:] function for accomplishing this. BUG=44563 TEST=None Review URL: http://codereview.chromium.org/2095017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47799 0039d316-1c4b-4281-b951-d872f2087c98
* Submitting http://codereview.chromium.org/2081006/show on behalf of ↵zelidrag@chromium.org2010-05-201-0/+1
| | | | | | | | | | | | | | | rkc@chromium.org: Changes for sending user e-mail along with the feedback Changes to implement complete userfeedback stack. TBR=zelidrag@chromium.org TEST=none BUG=chromium-os:2761 Review URL: http://codereview.chromium.org/2090011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47777 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup a bunch of TODO(shess).shess@chromium.org2010-05-195-15/+2
| | | | | | | | | | | | | | | | | | The TODO on AutocompleteEditViewMac about the popup needing the field for placement and font got half done. The placement part just seemed too intrusive to be worthwhile, but the font part seemed reasonable to get rid of. The others are all either not sensible anymore, or were addressed without being removed, or have been in there long enough that if nobody has complained by now, their subject must not matter. BUG=none TEST=none Review URL: http://codereview.chromium.org/2127009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47732 0039d316-1c4b-4281-b951-d872f2087c98
* Another bookmark sync issue.jrg@chromium.org2010-05-191-0/+4
| | | | | | | | | | | | If deleting a bookmark button (due to sync) while a bookmark folder is open, be sure to close the folder. Surprisingly this is among the top browser crashes. BUG=37782 Review URL: http://codereview.chromium.org/2113014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47699 0039d316-1c4b-4281-b951-d872f2087c98
* Move data types used in the importer process to common/, in preparation for ↵mirandac@chromium.org2010-05-192-3/+4
| | | | | | | | | | | import to run out of process. BUG= 18774 TEST= none. Review URL: http://codereview.chromium.org/2106015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47675 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Implement NSObject zombies.shess@chromium.org2010-05-192-0/+433
| | | | | | | | | | | | | | | | | | | | | Apple's NSZombieEnabled setting makes it easier to catch messages to freed objects, but is mostly only useful in debugging environments. This implements a facility like NSZombieEnabled with the following additions: - The number of outstanding zombies can be configured. - Classes can opt-in to becoming zombies. - C++ destructors are correctly called on Leopard. The goal is to allow us to enable zombies in certain production builds to help debug some of the message-after-free bugs we have. BUG=35590,24987 TEST=everything Review URL: http://codereview.chromium.org/660411 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47674 0039d316-1c4b-4281-b951-d872f2087c98
* Speculative bookmark crash fix.jrg@chromium.org2010-05-194-4/+59
| | | | | | | | | | | | | | | | | | The crash in http://crbug.com/43881 might be a reference to a dangling pointer. One theory for this crash is: - use bookmark sync - 1st machine: open a context menu on a bookmark button - 2nd machine: delete that bookmark (or it's parent), or rearrange things somehow - 1st machine: select Delete on the menu Fix is to close context menus when we see a model change. BUG=43881 Review URL: http://codereview.chromium.org/2132012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47632 0039d316-1c4b-4281-b951-d872f2087c98
* If the off-the-side menu is showing and one of its bookmarks is removed then ↵mrossetti@chromium.org2010-05-182-0/+18
| | | | | | | | | | | also remove the associated button. BUG=43351 TEST=Add enough bookmarks to the bookmar bar to cause the off-the-side chevron to appear. Pop up the off-the-side folder menu. Delete one of the bookmarks shown therein using the contextual menu. Verify that the bookmark button disappears. Mouse over other bookmarks in the menu and verify no crash occurs. Review URL: http://codereview.chromium.org/2122010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47546 0039d316-1c4b-4281-b951-d872f2087c98
* Rename "mixed content" to "insecure content" in as many places as possible, ↵pkasting@chromium.org2010-05-181-1/+1
| | | | | | | | | | to standardize on a consistent naming scheme. BUG=none TEST=none Review URL: http://codereview.chromium.org/2069005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47531 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Make the size text field in the font settings editable.rsesek@chromium.org2010-05-181-1/+2
| | | | | | | | | BUG=33406 TEST=Chromium-->Preferences-->Under the Hood-->Change font settings-->Change. Type into the size field. The font size changes. Review URL: http://codereview.chromium.org/2136014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47529 0039d316-1c4b-4281-b951-d872f2087c98
* Don't delete and re-add bookmark nodes which have been edited, instead, ↵mrossetti@chromium.org2010-05-181-17/+19
| | | | | | | | | | | update its URL and title and then move to its new parent only if necessary. BUG=44094 TEST=1) Edit a bookmark on the bookmark bar without changing its parent (moving it to a folder) and verify that there is no 'poof' animation. 2) Edit a bookmark on the bookmark bar but change its parent to be a folder and verify that it moved to the last place in the new parent and does not show the poof animation. 3) Edit a bookmark in a folder moving it to the bookmark bar and verify that it moves to the last position on the bar and does not show a poof animation. Review URL: http://codereview.chromium.org/2120006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47527 0039d316-1c4b-4281-b951-d872f2087c98
* Implement drag from bookmark manager to bookmark bar or a folder thereof. ↵mrossetti@chromium.org2010-05-1815-335/+1136
| | | | | | | | | | | | | | | | | | | Implement drag of other bookmark and URL sources such as from the Desktop or a text selection. BUG=39884,44228 TEST=Note: For all drag operations verify that the appropriate drop indicator is presented while dragging. When dragging onto a bookmark bar folder the folder button should be highlighted and, after a short delay, open into a menu. When dragging between folders or on top of a non-folder bookmark an insertion bar (vertical when in the bookmark bar, horizontal when in a folder menu) should be presented. For 'copy' moves the drag image should be adorned with a plus sign in a green circle. A non-copy move should show no such tag. 1) Drag a non-folder bookmark from the bookmark manager to the bookmark bar such that it falls on a non-folder bookmark. Verify that the bookmark is moved to be on the bar just before the bookmark upon which is was dropped. 2) Drag a folder bookmark from the manager to the bookmark bar such that it falls on a non-folder bookmark. Verify that the folder (as a folder) is moved to be on the bar just before the bookmark upon which is was dropped. 3) Drag a bookmark from the manager to a folder on the bookmark bar. Verify that the bookmark is added to the folder at the end and removed from the old location in the manager. 4) Drag a bookmark from the manager to a folder on the bookmark bar and wait for the folder to open and then drag to within the folder. Verify that dropping places the bookmark and removes it from the old location in the manager. 5) Drag a bookmark from the bar to the manager and verify that the manager now shows the dragged bookmark. (Note that this should be a 'move' but is currently a 'copy'. See http://crbug.com/44039.) 6) Drag a bookmark clipping from the Finder Desktop to the bookmark bar. Verify that it is added to the bar as a new bookmark. 7) Drag a bookmark clipping from the Finder Desktop to a folder on the bookmark bar and drop it within the folder menu. Verify that it is added to the folder as a new bookmark. 8) Create a URL in TextEdit or Stickies, select it and drag to the bookmark bar. Verify that it is added to the bar. 9) Create a URL in TextEdit or Stickies, select it and drag to a folder on the bookmark bar and drop it within the folder menu. Verify that it is added to the folder. Review URL: http://codereview.chromium.org/2066001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47523 0039d316-1c4b-4281-b951-d872f2087c98
* Replace hard-coded strings in CookiesWindowControllerTest with their GRIT ↵rsesek@chromium.org2010-05-171-10/+22
| | | | | | | | | | | values. BUG=none TEST=CookiesWindowControllerTest.* Review URL: http://codereview.chromium.org/2129006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47463 0039d316-1c4b-4281-b951-d872f2087c98
* Provide accessibility support for Window_win.ctguil@chromium.org2010-05-172-3/+5
| | | | | | | | TEST=Ensure that the About Chrome dialog has proper accessibility role. BUG=none Review URL: http://codereview.chromium.org/1838002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47454 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] stop the animation during window close and clear the animation ↵thomasvl@chromium.org2010-05-171-0/+11
| | | | | | | | | | delegate to avoid stale weak references. BUG=44225 TEST=see bug Review URL: http://codereview.chromium.org/2122008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47430 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a Memcheck:Cond caused by not setting |cert_id_| in the ↵rsesek@chromium.org2010-05-141-1/+2
| | | | | | | | | | | PageInfoWindowMac testing ctor. BUG=none TEST=Mac Valgrind unit goes green. Review URL: http://codereview.chromium.org/2088005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47320 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Rewrite the page info window to be built dynamically.rsesek@chromium.org2010-05-146-188/+412
| | | | | | | | | | | | | | | Rather than using a XIB, the window is now built entirely in code. The Controller's unit test has been removed because after this it is functionally useless. A new test for the bridge has been added. This also fixes the text clipping bug for the mixed content warning. BUG=23438,30843 TEST=No functional change; partially covered by unit tests. Review URL: http://codereview.chromium.org/2066003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47301 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: expand status bar when user hovers over a link for long enough.estade@chromium.org2010-05-142-5/+0
| | | | | | | | | BUG=43192 TEST=none Review URL: http://codereview.chromium.org/2033010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47285 0039d316-1c4b-4281-b951-d872f2087c98
* Commiting http://codereview.chromium.org/2017007/show on behalf of ↵zelidrag@chromium.org2010-05-142-2/+9
| | | | | | | | | | | | | | | | | | | | rkc@chromium.org. This change hooks issue report dialog with Google Feedback backend for ChromeOS. The dialog is going to be used only for Chrome OS at the moment, the previous mechanism is kept intact for other operating systems. Image and System Info reporting is disabled at the moment; for image, we need feedback to get their changes in production, for reporting, the system scripts need to be added (basic Chrome and OS version info is being sent with the report) BUG=chromium-os:2761 TEST=none, work in progress TBR=zelidrag Review URL: http://codereview.chromium.org/2068004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47244 0039d316-1c4b-4281-b951-d872f2087c98
* [Large; Chromium OS] Work to host the cloud print dialog when builtmaruel@chromium.org2010-05-142-1/+3
| | | | | | | | | | | | | | | for Chromium OS. Currently disabled by default behind a command line switch, and containing a non-real URL for now, this code is at prototype level. It works (when enabled and pointed at a functioning cloud print service URL), has the beginnings of some unit tests, and has the beginnings of deeper communication with the dialog contents, and it shuts off the DOM UI access from the dialog contents. Patch contributed by Scott Byer Review URL: http://codereview.chromium.org/1769006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47228 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure the Omnibox is hidden when toolbar is collapsed.finnur@chromium.org2010-05-131-0/+2
| | | | | | | | | BUG=None TEST=Visual inspection. The Omnibox should never become visible for tabs with a collapsed toolbar (app tabs). F11 twice should not show the Omnibox. Review URL: http://codereview.chromium.org/2032015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47119 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Automatically wrap the Customize Sync dialog to fit contentsakalin@chromium.org2010-05-132-0/+20
| | | | | | | | | | | xib changes: Adjusted customize sync text field to be as wide as the content view and made it wrap. Created customizeSyncDescriptionTextField_ outlet and hooked it up. BUG=43945 TEST=manual with French Review URL: http://codereview.chromium.org/2001018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47110 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] If the clear all button is wider then the content view, size up the ↵thomasvl@chromium.org2010-05-121-4/+18
| | | | | | | | | | | | bubble to fit. Also fix the button leak that was in here. BUG=43950 TEST=see bug Review URL: http://codereview.chromium.org/1996017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47069 0039d316-1c4b-4281-b951-d872f2087c98
* Re-organize RenderViewContextMenu to the use cross-platform MenuModel class.estade@chromium.org2010-05-111-4/+4
| | | | | | | | | | | | | | | | | | Benefits: - less code - more straightforward code - more shared code unresolved issues: - RenderViewContextMenu{Gtk,Mac,Views} should not be a subclass of RenderViewContextMenu - On Linux, IMEs are added in the wrong place (not near the other editable stuff) BUG=31365 TEST=manual + trybots Review URL: http://codereview.chromium.org/2017001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46987 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce header dependencies in chrome/phajdan.jr@chromium.org2010-05-115-0/+7
| | | | | | | | | TEST=if it compiles, it is perfect BUG=none Review URL: http://codereview.chromium.org/2001007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46894 0039d316-1c4b-4281-b951-d872f2087c98
* Update comments to clarify purpose of a function.mrossetti@chromium.org2010-05-101-0/+6
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/2022005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46852 0039d316-1c4b-4281-b951-d872f2087c98
* Discontinue tracking folder menus as soon as any bookmark is clicked.mrossetti@chromium.org2010-05-103-13/+40
| | | | | | | | | BUG=43622 TEST=Pop open a folder on the bookmark bar and verify that mousing over various folders causes their menus to appear. Find a bookmark within one of those folders and click on it. Verify that mousing over folders in the bookmark bar no longer cause the folder menus to appear. Review URL: http://codereview.chromium.org/2044006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46827 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Plumb the pinned tab flag through TabController so the context menu ↵rsesek@chromium.org2010-05-103-4/+7
| | | | | | | | | | | uses the correct state. BUG=42339 TEST=Create tab, pin it. Unpin it. Context menu works as before. Review URL: http://codereview.chromium.org/2057002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46825 0039d316-1c4b-4281-b951-d872f2087c98
* Collapse toolbars in app tabs.aa@chromium.org2010-05-081-0/+1
| | | | | | Review URL: http://codereview.chromium.org/2016002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46775 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor menu window height, position, and presence of scrolling arrows code ↵mrossetti@chromium.org2010-05-074-150/+266
| | | | | | | | | | out of configureWindow and into a new adjustWindowForHeight: method. Call this method when adding or removing bookmark nodes to the menu, such as for dropping or pasting. When adjusting the button widths consider the best cell width, which may be less than the current button width, so that folder menus can shrink as well as grow. When adding the first bookmark to an empty folder remove the '(empty)' placeholder and when removing the last real bookmark from a folder insert the '(empty)' placeholder. BUG=42868,43227 TEST=In addition to attempting to recreate the problems as described in the bug reports: 1) Add (by dragging in or pasting) a new bookmark to a folder which is on the edge of being too big and needing to scroll and verify that it does become scrollable, 2) remove a bookmark (by cutting or deleting) from the folder which just became scrollable and verify that it is no longer scrollable, 3) create a new, empty folder and verify that it shows '(empty)' , 4) add a bookmark (by dragging or pasting) to the newly created empty folder and verify that there is only one bookmark shown and that it is not the '(empty)' placeholder, and 5) remove the single bookmark just added to the folder (by cutting or deleting) and verify that the menu now shows the '(empty)' placeholder. Review URL: http://codereview.chromium.org/2024004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46744 0039d316-1c4b-4281-b951-d872f2087c98
* Moved URLFetcher and related classes to chrome/common/net.sanjeevr@chromium.org2010-05-071-1/+1
| | | | | | | | BUG=None TEST=Build and Unittests Review URL: http://codereview.chromium.org/1995008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46739 0039d316-1c4b-4281-b951-d872f2087c98
* Crashes, bookmark text, menu hiding.jrg@chromium.org2010-05-072-2/+74
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make sure "bookmarks go here" text goes away when adding the 1st bookmark (and comes back when deleting the last one). When deleting the last item from an "off the side menu" (which would cause the "off the side" chevron button to go away), close that menu. Make sure the "off the side" button is deleted in the autorelease pool, like all other buttons, in case "just one more" event is about to come in. This is an attempt at fixing the top Mac browser crash. BUG=43345,43501,43502 TEST=\ 1) New profile. Open bookmark bar --> see "bookmarks go here" Add bookmark --> text goes away Delete bookmark --> text comes back. 2) Add enough bookmarks so the "off the side" menu just barely appears. Open the off the side menu, and right click --> delete the bookmark. Expect to see the menu go away and the off-the-side button to go away. Review URL: http://codereview.chromium.org/2025002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46703 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of a couple more wstrings.viettrungluu@chromium.org2010-05-071-5/+0
| | | | | | | | | | | This one was really easy, since they weren't even used. BUG=none TEST=builds Review URL: http://codereview.chromium.org/2042004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46695 0039d316-1c4b-4281-b951-d872f2087c98
* Icon-only (titleless) bookmarks are squeezed closer.jrg@chromium.org2010-05-072-3/+45
| | | | | | | | | BUG=42516 TEST=change some bookmark titles to "" and watch them get Kate Mossified. Review URL: http://codereview.chromium.org/2045002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46644 0039d316-1c4b-4281-b951-d872f2087c98
* Mousing over the bookmark bar now behaves properly when traversing a ↵mrossetti@chromium.org2010-05-063-40/+76
| | | | | | | | | | | non-folder item; this would previously cause folder menus to discontinue appearing. Now once the bar folder menus are showing they will continue showing even when a non-folder bookmark bar item is traversed. Folder menus will discontinue showing when 1) a bar folder button is clicked, 2) a bookmark choice is made, 3) a click is made somewhere else in the browser window, 4) when the window loses focus, etc. BUG=None TEST=1) Mouse over the bar without clicking and verify that no folder menus appear. 2) Click on a folder button in the bar and verify that its folder menu appears. 3) Mouse over other folders in the bar and verify that the old menu closes and a new one opens. 4) Mouse over a non-folder button in the bar and verify that the old menu closes and another does not appear. 5) Mouse over a folder button and verify that the folder's menu appears. 6) Click on a folder button in the bar and verify that the menu closes. 7) Mouse over other folder buttons and verify no menu appears. Review URL: http://codereview.chromium.org/1912008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46626 0039d316-1c4b-4281-b951-d872f2087c98
* some more fixes for ignored scoped_ptr::release() callsestade@chromium.org2010-05-063-9/+11
| | | | | | | | | BUG=42904 TEST=bots Review URL: http://codereview.chromium.org/1982001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46622 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: add a l10n_util::GetNSStringF() which gets offsets as well.viettrungluu@chromium.org2010-05-061-6/+5
| | | | | | | | | | | | | | ... and get rid of a wstring. (More string16 versions of GetStringF() and corresponding versions GetNSStringF() should be implemented.) BUG=none TEST=on a branded build (on Mac), in the about dialog, make sure the text is still correct and the links still work correctly Review URL: http://codereview.chromium.org/2042002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46616 0039d316-1c4b-4281-b951-d872f2087c98
* Removed drek left over from an earlier expirement.mrossetti@chromium.org2010-05-061-3/+0
| | | | | | | | BUG=None TEST=None git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46571 0039d316-1c4b-4281-b951-d872f2087c98
* The button was being told to highlight but then it was not being told it ↵mrossetti@chromium.org2010-05-061-0/+4
| | | | | | | | | | | needed to be redrawn. BUG=43225 TEST=Drag a bookmark into a bar folder and then a subfolder and verify that the buttons in the path to the open subfolder are all highlighted. Review URL: http://codereview.chromium.org/2006001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46570 0039d316-1c4b-4281-b951-d872f2087c98
* Make the app launcher bubble fit its contents.jcivelli@google.com2010-05-051-2/+4
| | | | | | | | | | | | | | It remains at least as wide as the browser location bar (that way it can always point at the + button). InfoBubble was modified so it can be resized. BUG=42260 TEST=Open the app launcher multiple-times. The app launcher should fit its contents nicely. Review URL: http://codereview.chromium.org/1739020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46482 0039d316-1c4b-4281-b951-d872f2087c98
* Remove NOTIMPLEMENTED log spew for BrowserWindowCocoa::ShelfVisibilityChanged().mark@chromium.org2010-05-051-1/+1
| | | | | | | | BUG=43196 TEST=Spew gone. Review URL: http://codereview.chromium.org/1960002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46480 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure the directory for the brand file exists before trying to write to it.thomasvl@chromium.org2010-05-051-0/+12
| | | | | | | | BUG=42988 TEST=see bug Review URL: http://codereview.chromium.org/1903004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46458 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill profile shouldn't be saved when cancelled during initial setup.dhollowa@chromium.org2010-05-053-114/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | Relanding after revert of: 46424 http://codereview.chromium.org/1902003 Fixing compile error on Windows. For first encounter with fillable form, the AutoFillManager::OnInfoBarAccepted() call now passes the new profile and credit card information to the dialog directly instead of saving it to the database and then invoking the dialog. This facilitates "Cancel" in the dialog where the new information is not persisted. This was a good opportunity to refactor the deferred PersonalDataManager::Observer() logic out of the preferences dialog and into the AutoFillDialogController itself. This also consolidates the Windows, Mac, and Linux interfaces for the ShowAutoFillDialog() call. More work is required on Linux and Windows to properly conform to this interface and fix bug 41010. The Linux and Windows implementations will need to respect the new input parameters |imported_profile| and |imported_credit_card|. BUG=41010 TEST=AutoFillDialogControllerTest.WaitForDataToLoad, AutoFillDialogControllerTest.ImportedParameters Review URL: http://codereview.chromium.org/1952002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46430 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 46424 - AutoFill profile shouldn't be saved when cancelled during ↵dhollowa@chromium.org2010-05-053-3/+114
| | | | | | | | | | | | | | | | | | | | | | | | | | | initial setup. For first encounter with fillable form, the AutoFillManager::OnInfoBarAccepted() call now passes the new profile and credit card information to the dialog directly instead of saving it to the database and then invoking the dialog. This facilitates "Cancel" in the dialog where the new information is not persisted. This was a good opportunity to refactor the deferred PersonalDataManager::Observer() logic out of the preferences dialog and into the AutoFillDialogController itself. This also consolidates the Windows, Mac, and Linux interfaces for the ShowAutoFillDialog() call. More work is required on Linux and Windows to properly conform to this interface and fix bug 41010. The Linux and Windows implementations will need to respect the new input parameters |imported_profile| and |imported_credit_card|. BUG=41010 TEST=AutoFillDialogControllerTest.WaitForDataToLoad, AutoFillDialogControllerTest.ImportedParameters Review URL: http://codereview.chromium.org/1930002 TBR=dhollowa@chromium.org Review URL: http://codereview.chromium.org/1902003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46426 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill profile shouldn't be saved when cancelled during initial setup.dhollowa@chromium.org2010-05-053-114/+3
| | | | | | | | | | | | | | | | | | | | | | For first encounter with fillable form, the AutoFillManager::OnInfoBarAccepted() call now passes the new profile and credit card information to the dialog directly instead of saving it to the database and then invoking the dialog. This facilitates "Cancel" in the dialog where the new information is not persisted. This was a good opportunity to refactor the deferred PersonalDataManager::Observer() logic out of the preferences dialog and into the AutoFillDialogController itself. This also consolidates the Windows, Mac, and Linux interfaces for the ShowAutoFillDialog() call. More work is required on Linux and Windows to properly conform to this interface and fix bug 41010. The Linux and Windows implementations will need to respect the new input parameters |imported_profile| and |imported_credit_card|. BUG=41010 TEST=AutoFillDialogControllerTest.WaitForDataToLoad, AutoFillDialogControllerTest.ImportedParameters Review URL: http://codereview.chromium.org/1930002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46424 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-03 10:42:01 +0000