summaryrefslogtreecommitdiffstats
path: root/chrome/browser/cocoa
Commit message (Collapse)AuthorAgeFilesLines
* Add temporary download progress overlay to the dock icon for the Mac (real ↵avi@chromium.org2010-02-013-0/+262
| | | | | | | | | | | UI coming soon), and provide the hooks for the Win7 implementation. BUG=http://crbug.com/8039 TEST=download; see progress in the dock icon Review URL: http://codereview.chromium.org/545157 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37698 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Reduce jank in the cookie manager by lazily creating child nodes for ↵rsesek@chromium.org2010-02-014-12/+23
| | | | | | | | | | | | | the UI. Also selects the first cookie node whene expanding an origin node. BUG=33248 TEST=With a lot of cookies in your profile: Chromium-->Preferences-->Under the Hood-->Show cookies... Filter by a domain, expand the domain and the first cookie should be selected. Clear the filter and list should reappear speadily. Review URL: http://codereview.chromium.org/554151 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37695 0039d316-1c4b-4281-b951-d872f2087c98
* Keep packages from being selected in a Cocoa open single file dialog.avi@chromium.org2010-02-011-0/+24
| | | | | | | | | | | | Patch from Vernon Tang. BUG=33483 TEST=Check that user can't select an .app using an html file input element. Check that the "load unpacked extension" and "pack extension" browse dialogs in chrome://extensions/ continue to work as expected. Review URL: http://codereview.chromium.org/548199 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37693 0039d316-1c4b-4281-b951-d872f2087c98
* OS X: Import settings dialog cleanup.jeremy@chromium.org2010-02-015-67/+58
| | | | | | | | | | | | | * Make Import settings dialog app modal. * No longer allow display of multiple dialogs at once. * For some reason, unit test was present but missing from .gyp file - re-added and freshened up. BUG=33011 TEST=selecting Chrome->Import Bookmarks and settings multiple times should only open bookmarks once. Review URL: http://codereview.chromium.org/556097 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37689 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Theme status text of download items.thakis@chromium.org2010-01-311-30/+67
| | | | | | | | | | | Slightly complicated because the default theme's "clicked" gradient is not transparent. BUG=21176 TEST=Start long download (e.g. ubuntu disk image), then go through a lot of themes and make sure the status text stays readable, both in normal and clicked states. Also check with default theme. Review URL: http://codereview.chromium.org/551224 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37676 0039d316-1c4b-4281-b951-d872f2087c98
* Initialize arrowPoint so that warnings don't break Mac compile in new ↵mirandac@chromium.org2010-01-311-1/+1
| | | | | | | | | | | extension bubble. BUG= none TEST= none Review URL: http://codereview.chromium.org/556098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37672 0039d316-1c4b-4281-b951-d872f2087c98
* ExtensionInstalledBubble for Mac.mirandac@chromium.org2010-01-3113-9/+823
| | | | | | | | | | Adds ExtensionInstalledBubble.xib, which contains the framework for the bubble itself (icon view, close button, and three message fields). BUG= 26974 TEST= Install an extension. Bubble should show same information as windows bubble. Review URL: http://codereview.chromium.org/527012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37671 0039d316-1c4b-4281-b951-d872f2087c98
* Trivial fix: static -> const.viettrungluu@chromium.org2010-01-301-2/+2
| | | | | | | | | BUG=none TEST=still compiles Review URL: http://codereview.chromium.org/555189 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37641 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: fix crash when blank URL lists dragged to/over web content.viettrungluu@chromium.org2010-01-303-30/+70
| | | | | | | | | BUG=33696 TEST=See bug report for repro steps and make sure they no longer apply. Verify that dragging stuff to web contents works as before. Review URL: http://codereview.chromium.org/551221 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37639 0039d316-1c4b-4281-b951-d872f2087c98
* Changes to support new cookie policy.darin@chromium.org2010-01-301-12/+1
| | | | | | | | | | | | | | Changes: 1- net::CookiePolicy becomes an interface. 2- Old implementaiton of CookiePolicy copied to StaticCookiePolicy. 3- ChromeULRRequestContext implements CookiePolicy. 4- HostContentSettingsMap gets a global "BlockThirdPartyCookies" pref. R=pkasting Review URL: http://codereview.chromium.org/556095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37624 0039d316-1c4b-4281-b951-d872f2087c98
* Make download items drag sources on OS X.thakis@chromium.org2010-01-3011-128/+262
| | | | | | | | | | | | | Extract button dragging out of BookmarkButton into DraggableButton. Make BookmarkButton a subclass of DraggableButton. Create new class DownloadItemButton and make it a subclass of DraggableButton. xib change: Make download item a DownloadItemButton instead of an NSButton. BUG=15776 TEST=Download something, wait for it to complete, then drag it from the download shelf to somewhere. It should now work. Bookmarks should still be draggable in the bookmarks bar. Review URL: http://codereview.chromium.org/180036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37621 0039d316-1c4b-4281-b951-d872f2087c98
* Add basic support for Content Blocked icons in the omnibox. Not yet pkasting@chromium.org2010-01-302-2/+7
| | | | | | | | | | hooked to anything, so they'll never appear. BUG=33314 TEST=none Review URL: http://codereview.chromium.org/556077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37609 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Selecting a row in taskman should select other rows in the same process.thakis@chromium.org2010-01-291-9/+15
| | | | | | | | | BUG=33077 TEST=See bug. Review URL: http://codereview.chromium.org/556082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37560 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r37535.darin@chromium.org2010-01-292-12/+4
| | | | | | | | | | | | | There was no LGTM, and there was still open discussion in the code review. See http://codereview.chromium.org/554119. This was not ready to land. TBR=pkasting BUG=none TEST=none Review URL: http://codereview.chromium.org/553154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37556 0039d316-1c4b-4281-b951-d872f2087c98
* Implement extended cookie controls.jochen@chromium.org2010-01-292-4/+12
| | | | | | | | | BUG=32782 TEST=none Review URL: http://codereview.chromium.org/554119 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37535 0039d316-1c4b-4281-b951-d872f2087c98
* Mac bookmark manager: Crash after deleting folder in left panesnej@chromium.org2010-01-293-10/+33
| | | | | | | | BUG=33083 TEST=BookmarkTreeControllerTest.Deletion git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37521 0039d316-1c4b-4281-b951-d872f2087c98
* Mac bookmark mgr: Restore previously selected group when search field is ↵snej@chromium.org2010-01-284-4/+83
| | | | | | | | | | | cleared. BUG=32734 TEST=none Review URL: http://codereview.chromium.org/555112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37444 0039d316-1c4b-4281-b951-d872f2087c98
* Add import/export extension apisfeldstein@chromium.org2010-01-282-2/+18
| | | | | | | | | | | This is a duplicate of 543094. That code review seems to have gotten corrupted as i can no longer publish anything from their web UI. It was LGTM'd+nits by arv, which i've fixed here. BUG=32194 TEST=Import and export bookmarks from the extension Review URL: http://codereview.chromium.org/548167 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37351 0039d316-1c4b-4281-b951-d872f2087c98
* Mac bookmark mgr: Remove bold style for root folders. Thin window border.snej@chromium.org2010-01-271-7/+0
| | | | | | | | | | (Xib change: move left/right edges of outer splitview out 1 pixel.) BUG=33119 TEST=none (visual appearance only) Review URL: http://codereview.chromium.org/556048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37339 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Makes BrowserWindowCocoa use the proper window, regardless of current ↵rohitrao@chromium.org2010-01-272-17/+25
| | | | | | | | | | fullscreen settings. Prereq for fullscreen mode. BUG=31638 TEST=No visible changes. Review URL: http://codereview.chromium.org/555133 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37283 0039d316-1c4b-4281-b951-d872f2087c98
* Page actions should be able to change the popup on a per-tab basis.skerner@chromium.org2010-01-272-16/+31
| | | | | | | | | | | This change is a prerequisite to change 545068. BUG=27526 TEST=Added unit tests, manual testing on mac, linux, windows. Review URL: http://codereview.chromium.org/543176 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37257 0039d316-1c4b-4281-b951-d872f2087c98
* Fix an invalid read in CocoaCookieTreeNode that occurs when filtering ↵rsesek@chromium.org2010-01-274-19/+61
| | | | | | | | | | | cookies by origin. BUG=none TEST=Mac Valgrind unit_tests Review URL: http://codereview.chromium.org/555124 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37252 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac]Implement Cut, Copy and Paste from page menusuzhe@chromium.org2010-01-272-0/+15
| | | | | | | | | BUG=none TEST=Cut/Copy/Paste items in page menu should work in both omnibox and web content. Review URL: http://codereview.chromium.org/556016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37231 0039d316-1c4b-4281-b951-d872f2087c98
* Change hardcoded strings (!) in Mac unittest to match real string changes.pkasting@chromium.org2010-01-271-2/+2
| | | | | | | | | TBR=rsesek BUG=32719 TEST=none Review URL: http://codereview.chromium.org/556033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37196 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Possibly prevent crashes by properly handling missing/invalid favicons ↵rohitrao@chromium.org2010-01-261-1/+10
| | | | | | | | | | in HungRendererController. BUG=33160 TEST=None. (No repro case. Hopefully crashes will go away.) Review URL: http://codereview.chromium.org/556022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37161 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Give the cookies manager a search field.rsesek@chromium.org2010-01-263-0/+65
| | | | | | | | | | | | | | | XIB changes: * Add an NSSearchField and adjust window size. * Add an outlet for the NSOutlineView so we can clear the delegate to avoid potential crashes during sheet closing. * Change the control size of the NSOutlineView to small (looks better). BUG=32328 TEST=Chromium-->Preferences-->Under the Hood-->Show cookies... Enter a domain or domain substring and, without hitting enter, results should be filtered. Review URL: http://codereview.chromium.org/557002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37139 0039d316-1c4b-4281-b951-d872f2087c98
* Mac bookmark mgr: Add tooltips to buttons.snej@chromium.org2010-01-262-3/+13
| | | | | | | | | BUG=32735 TEST=Hover cursor over +/-/gear buttons Review URL: http://codereview.chromium.org/549143 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37121 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Improve task manager column resizing, set min window size.thakis@chromium.org2010-01-261-2/+57
| | | | | | | | | | | | | xib changes: Set min window size to 300x200, change table view column resizing to "Uniform". Give task manager columns min max widths. BUG=33133,33134 TEST=See bugs. Review URL: http://codereview.chromium.org/551148 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37114 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for Mac tooltip crasher.snej@chromium.org2010-01-262-0/+8
| | | | | | | | | BUG=23397 TEST=none Review URL: http://codereview.chromium.org/543200 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37110 0039d316-1c4b-4281-b951-d872f2087c98
* Enable "Import Settings" button in preferences dialog.jeremy@chromium.org2010-01-261-1/+7
| | | | | | | | | BUG=29819 TEST=Open settings dialog, go to "Personal Stuff" Tab, Import Data... button should function Review URL: http://codereview.chromium.org/555065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37101 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Rebuild Bookmarks menu only when it's pulled down.snej@chromium.org2010-01-255-21/+90
| | | | | | | | | BUG=30600 TEST=BookmarkMenuBridgeTest Review URL: http://codereview.chromium.org/555079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37056 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Add methods to prevent tab detaching or window moving if needed. ↵rohitrao@chromium.org2010-01-253-12/+26
| | | | | | | | | | | | Modify tab view to respect these new settings. Prereq for fullscreen. (Changes really made by viettrungluu@chromium.org.) BUG=31638 TEST=Tab dragging and window moving should still work when not in fullscreen mode. Review URL: http://codereview.chromium.org/554064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37045 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Makes the tab strip left-side indent changeable. Prereq for fullscreen.rohitrao@chromium.org2010-01-252-9/+24
| | | | | | | | | | | (Changes really made by viettrungluu@chromium.org.) BUG=31638 TEST=Tab strip should still draw with the proper indent. Review URL: http://codereview.chromium.org/551145 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37038 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Changes to enable performClose: for fullscreen windows.rohitrao@chromium.org2010-01-253-16/+61
| | | | | | | | | | (Changes really made by viettrungluu@chromium.org.) BUG=31638 TEST=None. (Unittests should still pass.) Review URL: http://codereview.chromium.org/552133 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37029 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: fix yet another TabStripController index/model index bug (crasher).viettrungluu@chromium.org2010-01-251-3/+5
| | | | | | | | | BUG=29906 TEST=Create a bunch of tabs; click on some close tab button while holding shift down to slow down animation; while animating, select another tab; repeat many, many times. Should not crash. Review URL: http://codereview.chromium.org/553068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37010 0039d316-1c4b-4281-b951-d872f2087c98
* Adds local storage nodes to cookie tree model and cookies view.bulach@chromium.org2010-01-254-14/+33
| | | | | | | | BUG=none TEST=The show cookie dialog box should have a new node "local storage" when appropriate. When selected, it should display details of local storage (name, size on disk, last modified) in the details frame. Review URL: http://codereview.chromium.org/523139 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37001 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: make pinned tab title change alert more noticeable.viettrungluu@chromium.org2010-01-241-20/+20
| | | | | | | | | | | | Make the alert glow fade in to look like a selected tab, which should be quite visible on all themes, including the default theme (i.e., no theme). BUG=32791 TEST=Go to <http://www.surflocal.net/Awards/submit/animatedtitle.html>, pin that tab, and create and select a new tab. Watch the pinned tab "glow" in and out quite visibly (but smoothly). Check that it behaves properly when the mouse moves over it. Check with lots of different themes. Review URL: http://codereview.chromium.org/549144 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36982 0039d316-1c4b-4281-b951-d872f2087c98
* Mac bookmark mgr: Enable menu cmd when no window's open.snej@chromium.org2010-01-231-1/+9
| | | | | | | | | Also fixes a related bug not mentioned in the report: app global commands like New Window etc. are disabled when the bookmark manager is active. BUG=32200 TEST=none (see bug description) Review URL: http://codereview.chromium.org/551100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36951 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Fix a bunch of crahes related to opening preferences from an incognito ↵rsesek@chromium.org2010-01-221-1/+1
| | | | | | | | | | | window BUG=32827 TEST=Open incognito window. Wrench menu --> Preferences --> Basics --> Manage. Don't crash. Review URL: http://codereview.chromium.org/545177 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36907 0039d316-1c4b-4281-b951-d872f2087c98
* Add one more cast to placate the 10.6 SDK.mark@chromium.org2010-01-221-1/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/543158 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36892 0039d316-1c4b-4281-b951-d872f2087c98
* Mac bookmark mgr: Fix crash with New Folder when Recents selected. Enable ↵snej@chromium.org2010-01-224-36/+91
| | | | | | | | | | New Folder when Bookmark Bar or Others selected. BUG=32732,32733 TEST=BookmarkTreeControllerTest.NewFolder Review URL: http://codereview.chromium.org/549125 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36875 0039d316-1c4b-4281-b951-d872f2087c98
* Adds support for phantom tabs. A pinned tab becomes a phantom tab whensky@chromium.org2010-01-221-1/+1
| | | | | | | | | | | | | | | | | it is closed, and effectively unloads the renderer and replaces it with a new TabContents that loads when selected. A phantom tab is currently rendered without a border. Phantom tabs do not prevent a window from closing. Long term only pinned app tabs will have the ability to be made phantom, but this allows us to test the feature until app support is all wired in. BUG=32845 TEST=none yet Review URL: http://codereview.chromium.org/553008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36815 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a comment long-obsolete.avi@chromium.org2010-01-211-3/+0
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/545160 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36810 0039d316-1c4b-4281-b951-d872f2087c98
* Implemented Esc/Command-. shortcuts for HTML dialogs.akalin@chromium.org2010-01-211-0/+20
| | | | | | | | | BUG=32216 TEST=manually Review URL: http://codereview.chromium.org/548051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36800 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Fix a crash in the cookies manager that was caused by an invalid ↵rsesek@chromium.org2010-01-213-0/+87
| | | | | | | | | | | | | | | | selection. XIB change: Change the "Remove" button's |enabled| binding from just looking at the count of the selection to FilesOwner.removeButtonEnabled. BUG=32627 TEST=Covered by unit tests. TEST=Open cookies manager. Select one item, make sure "Remove" is enabled. TEST=Open cookies manager. Try to select two items. You shouldn't be able to. Review URL: http://codereview.chromium.org/546102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36796 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] relayout the import data and clear browser data buttons in the prefs ↵thomasvl@chromium.org2010-01-211-13/+0
| | | | | | | | | | for the string changes that already landed. more work will be needed to make the window match the new wants, but this gets the tests passing again. BUG=32719 TEST=unittests green up Review URL: http://codereview.chromium.org/551103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36793 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Hide browser action buttons when they would otherwise overflow with ↵andybons@chromium.org2010-01-215-7/+101
| | | | | | | | | | the omnibar. TEST=none BUG=29838 Review URL: http://codereview.chromium.org/553038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36789 0039d316-1c4b-4281-b951-d872f2087c98
* Mac bookmark mgr: Fix crash after closing incognito window.snej@chromium.org2010-01-211-1/+5
| | | | | | | | BUG=32594 TEST=none (see steps to reproduce) Review URL: http://codereview.chromium.org/554034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36772 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash in tab's close button.feldstein@chromium.org2010-01-211-0/+6
| | | | | | | | | | | If you click and hold on a close button that is being animated closed, it will crash if you release it after the tab is completely closed. The button is being freed when the |super mouseDown| call is in it's tracking loop, so we need to hold on to it with a scoped_nsobject until we're done with it. The checkImageState call is called unnecessarily, but it shouldn't hurt anything. BUG=28220 TEST=Click and hold on the close button of a tab that is animating closed. Release it a couple of seconds after the tab is fully hidden. To help test, you can change the kAnimationDuration in tab_strip_controller.mm to a higher value. Review URL: http://codereview.chromium.org/555018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36769 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Localize the cookie manager. Also rolls GTM r259:280.rsesek@chromium.org2010-01-211-2/+0
| | | | | | | | | BUG=32338 TEST=Preferences-->Under the Hood-->Show cookies... should now be localized. Review URL: http://codereview.chromium.org/543128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36766 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-19 09:20:23 +0000