summaryrefslogtreecommitdiffstats
path: root/chrome/browser/cocoa
Commit message (Collapse)AuthorAgeFilesLines
...
* Cleanup: Include browser.h -> ui/browser.h [Part 1].jhawkins@chromium.org2010-11-161-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5043001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66198 0039d316-1c4b-4281-b951-d872f2087c98
* Add a help bubble pointing to the omnibox when installing an extension withmpcomplete@chromium.org2010-11-163-22/+53
| | | | | | | | | | | an omnibox keyword. BUG=54353 TEST=Install chrome_search from the extension examples folder. You should see a help bubble pointing to the omnibox explaining how to use the omnibox keyword. Review URL: http://codereview.chromium.org/4724005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66197 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Removes the match preview tear image. Also removes the underlying ↵rohitrao@chromium.org2010-11-153-60/+2
| | | | | | | | | | | | resource files. Xib changes: Removed the close button and tear image. BUG=59068 TEST=Tear image should be gone. Review URL: http://codereview.chromium.org/5031001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66185 0039d316-1c4b-4281-b951-d872f2087c98
* Makes the current page dim out when transitioning to instant preview.sky@chromium.org2010-11-152-0/+5
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/4932001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66164 0039d316-1c4b-4281-b951-d872f2087c98
* Move click-to-play to about:flags.bauerb@chromium.org2010-11-126-102/+75
| | | | | | | | | | | | | | | | XIB changes: Add an outlet |pluginDefaultSettingMatrix_| to ContentSettingsDialogController, hooked up to the associated matrix, to remove the click-to-play radio button. While I'm at it, clean up a bit: * Remove the old --disable-click-to-play flag that reverted to the M6 behavior for blocked plugins * Make ContentExceptionsWindowController use ContentSettingComboModel for the action popup. * Make HostContentSettingsMapTest use AutoReset to reset command line switches. BUG=62091 TEST=unit_tests Review URL: http://codereview.chromium.org/4643007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65953 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 65879 - When an extension is uninstalled, close all desktop ↵johnnyg@chromium.org2010-11-122-3/+1
| | | | | | | | | | | | | | | | | | notifications from that extension. This change also refactors the balloon collection code to remove duplication between chrome and chromeos. Removes some gross removal code which was using fake notifications just to get the right ID. BUG=58266 TEST=open notifications from extension, uninstall extensions Review URL: http://codereview.chromium.org/4635007 TBR=johnnyg@chromium.org Review URL: http://codereview.chromium.org/4855002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65896 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove chrome/browser/browser_navigator.* and references.jhawkins@chromium.org2010-11-122-2/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/4840001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65881 0039d316-1c4b-4281-b951-d872f2087c98
* When an extension is uninstalled, close all desktop notifications from that ↵johnnyg@chromium.org2010-11-122-1/+3
| | | | | | | | | | | | | | | extension. This change also refactors the balloon collection code to remove duplication between chrome and chromeos. Removes some gross removal code which was using fake notifications just to get the right ID. BUG=58266 TEST=open notifications from extension, uninstall extensions Review URL: http://codereview.chromium.org/4635007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65879 0039d316-1c4b-4281-b951-d872f2087c98
* OS X: Allow a stat in the file dialog function on the UI threaddavidben@chromium.org2010-11-111-0/+4
| | | | | | | | | | R=avi BUG=none TEST=OS X file dialogs don't trigger AssertIOAllowed DCHECKS Review URL: http://codereview.chromium.org/4673009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65863 0039d316-1c4b-4281-b951-d872f2087c98
* Makes the instant suggested text autocomplete after 1.3 seconds. Theresky@chromium.org2010-11-112-0/+5
| | | | | | | | | | | | are a number of parts of this patch that need work, but it should be good enough for us to decide if we want to pursue it. BUG=none TEST=none Review URL: http://codereview.chromium.org/4385001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65741 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Prevent stale reload button tooltips from remaining after state change.shess@chromium.org2010-11-103-26/+67
| | | | | | | | | | | | | | | | | | | | Apparently -[NSView setToolTip:] don't handle removing any existing display. -removeAllToolTips or -setToolTip:nil both appear to do the right thing. This handles both transitions because you can go from reload mode to stop mode due to in-page activity. Unfortunately, after transition the new tooltip will never appear. AFAICT, you can't force a tooltip up, we'd probably have to fake out the appkit machinery, which seems excessive to me. BUG=61556 TEST=See bug. Review URL: http://codereview.chromium.org/4451003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65708 0039d316-1c4b-4281-b951-d872f2087c98
* chromeos: Update help URLs.derat@chromium.org2010-11-103-7/+13
| | | | | | | | | | | | This also moves some untranslatable URL strings out of .grd files and into code so we don't duplicate them per-language. BUG=chromium-os:8117 TEST=trybots; also built and ran the chrome os version Review URL: http://codereview.chromium.org/4495001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65683 0039d316-1c4b-4281-b951-d872f2087c98
* Split out command IDs from chrome_dll_resource.h.evan@chromium.org2010-11-0831-31/+31
| | | | | | | | | | | | The name of this file is a leftover from Windows. Split the command ids (which are used on all platforms) out, leaving just the Windows-specific resource IDs in the original file. TEST=compiles Review URL: http://codereview.chromium.org/4710001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65453 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bubble offset issue (bubble x-coordinate pointing to wrong place) on OS X.mirandac@chromium.org2010-11-082-18/+10
| | | | | | | | | BUG=60576 TEST=first run bubble, cookies blocked bubble, + geolocation bubble all point to correct place. as do all other bubbles. Review URL: http://codereview.chromium.org/4544004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65452 0039d316-1c4b-4281-b951-d872f2087c98
* Remove "name" field from indexed databases.jochen@chromium.org2010-11-083-6/+2
| | | | | | | | | BUG=56248 TEST=unit_tests Review URL: http://codereview.chromium.org/4682002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65450 0039d316-1c4b-4281-b951-d872f2087c98
* Use .crdownload file path for 'Show In Folder' while download is in progresskinuko@chromium.org2010-11-084-14/+13
| | | | | | | | | BUG=57037 TEST=download a huge file and click 'Show In Folder' during the download Review URL: http://codereview.chromium.org/4460002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65418 0039d316-1c4b-4281-b951-d872f2087c98
* Add pinned property to tabs.update and create.jstritar@chromium.org2010-11-081-0/+5
| | | | | | | | | | | Fire tabs.onUpdated event if a tab's pinned state changes. BUG=24781 TEST=ExtensionApiTest Review URL: http://codereview.chromium.org/3816005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65379 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Use Linux WorkerPool code.shess@chromium.org2010-11-051-18/+54
| | | | | | | | | | | | | | | | | Adapts things to use the Linux WorkerPool code by default, with --disable-linux-workerpool to switch back to the old version. The old implementation uses NSOperationQueue, which is implemented in terms of pthread workqueues. These are implicated by the stack traces from the recent unit test flakiness. This change attempts to influence that flakiness. BUG=20471, 60426 TEST=Tree green. Review URL: http://codereview.chromium.org/4595001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65273 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug 42440: [mac] notifications bring chrome to the foreground on a clickjianli@chromium.org2010-11-053-1/+52
| | | | | | | | | BUG=42440 TEST=none Review URL: http://codereview.chromium.org/4280001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65228 0039d316-1c4b-4281-b951-d872f2087c98
* Header dependency reduction for notification headers.levin@chromium.org2010-11-057-22/+36
| | | | | | | | | BUG=None TEST=Build succeeds. Review URL: http://codereview.chromium.org/4535003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65222 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Turn down window-resize time for tests.shess@chromium.org2010-11-041-0/+10
| | | | | | | | | | | | | You know when you're running the unit tests and windows pop up and a sheet slides in? This makes them not do that. Found this setting while researching something else. BUG=none TEST=none Review URL: http://codereview.chromium.org/4410002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65026 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Add a confirm to quit experiment to about:flags.rsesek@chromium.org2010-11-033-0/+119
| | | | | | | | | BUG=27786,60591 TEST=Enable 'Confirm to Quit' in about:flags. When you press Cmd+Q, it brings up the floaty panel telling you to hold the key combo. When you do, it quits after 1.5 seconds. Review URL: http://codereview.chromium.org/4220005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64920 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent a crash in TaskManagerWindowController by nil-ing the dataSource and ↵rsesek@chromium.org2010-11-031-0/+6
| | | | | | | | | | | delegate in dealloc. BUG=61669 TEST=none Review URL: http://codereview.chromium.org/4234005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64907 0039d316-1c4b-4281-b951-d872f2087c98
* Cloud Print Dialog work.scottbyer@google.com2010-11-022-0/+2
| | | | | | | | | | | | Allow an HTML dialog to suppress the title bar in a Chromium OS bubble window. For the Cloud Print dialog, remember the last size requested by the contents. BUG=chromium-os:8494 TEST=none Review URL: http://codereview.chromium.org/4110010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64824 0039d316-1c4b-4281-b951-d872f2087c98
* Fix type inconsistency with StartImportingWithUI and ProfileInfo.tfarina@chromium.org2010-11-022-4/+2
| | | | | | | | | BUG=28153 TEST=compiles locally and trybots Review URL: http://codereview.chromium.org/4282003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64801 0039d316-1c4b-4281-b951-d872f2087c98
* Make all browser code use browser::Navigate to open tabs.ben@chromium.org2010-11-022-11/+16
| | | | | | | | | BUG=none TEST=existing unittests. Also, test all places where new tabs and windows are opened from UI, e.g. links in options, new tab button, Ctrl+T, popup windows, etc. Review URL: http://codereview.chromium.org/3834002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64745 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Dismiss content setting bubbles when opening a new tab via Cmd+T.rsesek@chromium.org2010-11-021-0/+2
| | | | | | | | | BUG=48086 TEST=Go to a site with a content setting icon in the Omnibox. Click icon to open bubble. Hit Cmd+T; bubble closes. Review URL: http://codereview.chromium.org/4241001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64736 0039d316-1c4b-4281-b951-d872f2087c98
* If the tab contents containing a constrained html dialog is closed, we need ↵johnnyg@chromium.org2010-11-021-1/+1
| | | | | | | | | | | to inform the ConstrainedHtmlUiDelegate that the dialog is also gone. BUG=60976 TEST=see bug Review URL: http://codereview.chromium.org/4219004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64695 0039d316-1c4b-4281-b951-d872f2087c98
* Adds the ability to show verbatim instant results rather thansky@chromium.org2010-11-012-0/+6
| | | | | | | | | | | predictive results. More work is needed if we decide this is the direction to go, but it's good enough for us to play with. BUG=61378 TEST=none Review URL: http://codereview.chromium.org/4196009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64662 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Re-enable the disabled stop/reload button after hovering briefly (1.35 ↵shess@chromium.org2010-11-013-19/+82
| | | | | | | | | | | | | seconds, to be exact). Mac version of http://codereview.chromium.org/4116003 BUG=58185 TEST=Navigate to cnn.com. Hover the stop button. After it changes to a disabled stop button, wait, and it should change to an enabled reload button. Review URL: http://codereview.chromium.org/4208004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64653 0039d316-1c4b-4281-b951-d872f2087c98
* Convert implicit scoped_refptr constructor calls to explicit ones, part 1thakis@chromium.org2010-11-012-3/+3
| | | | | | | | | | | This CL was created automatically by this clang rewriter: http://codereview.appspot.com/2776043/ . I manually fixed a few rough spots of the rewriter output (doh1-3) and fixed all presubmit errors. BUG=28083 TEST=None Review URL: http://codereview.chromium.org/4192012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64573 0039d316-1c4b-4281-b951-d872f2087c98
* Part 3 of immutable Extension refactor.mpcomplete@chromium.org2010-10-2915-40/+47
| | | | | | | | | | | | | Make ExtensionsService hold const Extension pointers only. This ensures that extensions can't be modified after they're created, and lets us share them between threads. BUG=56558 TEST=no functional change Review URL: http://codereview.chromium.org/4138006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64517 0039d316-1c4b-4281-b951-d872f2087c98
* Fix tabbing into web area not focusing first element.avi@chromium.org2010-10-292-0/+11
| | | | | | | | | BUG=49738 TEST=as in bug Review URL: http://codereview.chromium.org/3153039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64465 0039d316-1c4b-4281-b951-d872f2087c98
* Fix positioning of first run bubble.mirandac@chromium.org2010-10-292-1/+25
| | | | | | | | BUG=60576 TEST= trigger first run bubble by running Chrome with --first-run on an empty profile. Note that bubble points to a spot just to the right of the magnifying glass icon, where the user would begin typing a search term. Review URL: http://codereview.chromium.org/4143008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64440 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure fullscreen windows have entries in the Windows menu, fix title ↵avi@chromium.org2010-10-292-1/+19
| | | | | | | | | | | problem on enter/exit fullscreen. BUG=59733,61149 TEST=as in both bugs Review URL: http://codereview.chromium.org/4196006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64434 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Close info bubbles managed by BaseBubbleController when switching tabs.rsesek@chromium.org2010-10-283-0/+41
| | | | | | | | | BUG=48086,60781 TEST=Open the Page Info bubble and the Content Settings bubble. Each close when switching tabs. Review URL: http://codereview.chromium.org/4111007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64312 0039d316-1c4b-4281-b951-d872f2087c98
* If default browser is set to FF, and Chrome is run as first-run with an ↵mirandac@chromium.org2010-10-282-5/+12
| | | | | | | | | | empty profile, import ignores FF data and imports from Safari instead. BUG=61112 TEST=see bug. Review URL: http://codereview.chromium.org/4206002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64298 0039d316-1c4b-4281-b951-d872f2087c98
* The frame for the button for a bookmark which is dropped at the top of a ↵mrossetti@chromium.org2010-10-284-26/+87
| | | | | | | | | | | folder was never being recalculated and was left with the placeholder value. The placeholder value has been replaced with a default frame. Unit tests were enhanced to check for proper button vertical alignment. Comments were added to metric constants. A convenience constant was added for a frequently needed spacing from the base of one menu button to the base of the next. BUG=58962 TEST=Drop a bookmark at the top of a folder and verify that it is drawn in the top button position. Review URL: http://codereview.chromium.org/4168003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64185 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash in ExtensionGalleryInstallApiTest.InstallAndUninstall caused bympcomplete@chromium.org2010-10-272-5/+22
| | | | | | | | | | | | | | the ExtensionInstalledBubble. The info bubble was closing after the extension was uninstalled. This wouldn't always happen - sometimes the browser shut down first, so we didn't crash. BUG=56558 TEST=covered by browser_test Review URL: http://codereview.chromium.org/4112007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64177 0039d316-1c4b-4281-b951-d872f2087c98
* Convert ElideUrl to return a string16 instead of a wstring.tony@chromium.org2010-10-271-4/+4
| | | | | | | | BUG=23581 Review URL: http://codereview.chromium.org/4115003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64156 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Fix file selector moving up one dir each time you use it.avi@chromium.org2010-10-271-2/+8
| | | | | | | | | | | If default_path is a directory, start the file open dialog in that dir, rather than in the parent with that dir selected. BUG=49081 TEST=see #2 on bug Review URL: http://codereview.chromium.org/4106003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64146 0039d316-1c4b-4281-b951-d872f2087c98
* Unrevert again r63919: "Part 2 of immutable Extension refactor."mpcomplete@chromium.org2010-10-272-14/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | (Last landing broke chromeos and chromium linux builder.) I made Extension a refcounted object, and privitized the existing con/destructor and InitFromValue. The only way to get an Extension is to call a factory method. In the next CL, I plan to make the factory method return a const Extension, to guarantee that no one can modify the Extension object after creation. Note: There was a tricky part of this CL because of the difference in semantics between scoped_ptr and scoped_refptr. I had to be careful not to use ptr.release(), since that would result in leaks (an un-Released AddRef). BUG=56558 TEST=no functional change Original Review URL: http://codereview.chromium.org/3982001 TBR=aa Review URL: http://codereview.chromium.org/4119010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64139 0039d316-1c4b-4281-b951-d872f2087c98
* Changed flat button hover highlight to be 30% black.mrossetti@chromium.org2010-10-271-1/+1
| | | | | | | | | BUG=59056 TEST=Observe button highlight in a bookmark button folder menu. Review URL: http://codereview.chromium.org/4137005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64076 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Make sure user can see devtools pane after it has been restored.pfeldman@chromium.org2010-10-271-1/+1
| | | | | | | | BUG=60899 Review URL: http://codereview.chromium.org/4193002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64060 0039d316-1c4b-4281-b951-d872f2087c98
* Ignore the close button when accessibility is on. This seems to be the only ↵dtseng@chromium.org2010-10-272-0/+15
| | | | | | | | | | way for VoiceOver and AccessibilityInspector to ignore the close button which is seen as a child of the tab button. BUG=37336 TEST=BrowserAccessibilityTest.* and manually test VoiceOver on/off with new tabs. Verify that tabs are read correctly. Review URL: http://codereview.chromium.org/3926002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63988 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 63962 (broke chromeos and chromium linux builder) - Unrevert r63919: ↵thakis@chromium.org2010-10-262-11/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | "Part 2 of immutable Extension refactor." I made Extension a refcounted object, and privitized the existing con/destructor and InitFromValue. The only way to get an Extension is to call a factory method. In the next CL, I plan to make the factory method return a const Extension, to guarantee that no one can modify the Extension object after creation. Note: There was a tricky part of this CL because of the difference in semantics between scoped_ptr and scoped_refptr. I had to be careful not to use ptr.release(), since that would result in leaks (an un-Released AddRef). BUG=56558 TEST=no functional change Original Review URL: http://codereview.chromium.org/3982001 TBR=aa Review URL: http://codereview.chromium.org/4186002 TBR=mpcomplete@chromium.org Review URL: http://codereview.chromium.org/4130004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63976 0039d316-1c4b-4281-b951-d872f2087c98
* Unrevert r63919: "Part 2 of immutable Extension refactor."mpcomplete@chromium.org2010-10-262-14/+11
| | | | | | | | | | | | | | | | | | | | | | | | I made Extension a refcounted object, and privitized the existing con/destructor and InitFromValue. The only way to get an Extension is to call a factory method. In the next CL, I plan to make the factory method return a const Extension, to guarantee that no one can modify the Extension object after creation. Note: There was a tricky part of this CL because of the difference in semantics between scoped_ptr and scoped_refptr. I had to be careful not to use ptr.release(), since that would result in leaks (an un-Released AddRef). BUG=56558 TEST=no functional change Original Review URL: http://codereview.chromium.org/3982001 TBR=aa Review URL: http://codereview.chromium.org/4186002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63962 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r63919 "Part 2 of immutable Extension refactor."mpcomplete@chromium.org2010-10-262-11/+14
| | | | | | | | | | | | Compile failure on Linux x64. BUG=56558 TEST=no functional change TBR=aa Review URL: http://codereview.chromium.org/4156002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63925 0039d316-1c4b-4281-b951-d872f2087c98
* Part 2 of immutable Extension refactor.mpcomplete@chromium.org2010-10-262-14/+11
| | | | | | | | | | | | | | | | | | | | I made Extension a refcounted object, and privitized the existing con/destructor and InitFromValue. The only way to get an Extension is to call a factory method. In the next CL, I plan to make the factory method return a const Extension, to guarantee that no one can modify the Extension object after creation. Note: There was a tricky part of this CL because of the difference in semantics between scoped_ptr and scoped_refptr. I had to be careful not to use ptr.release(), since that would result in leaks (an un-Released AddRef). BUG=56558 TEST=no functional change Review URL: http://codereview.chromium.org/3982001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63919 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the title field from the SectionInfo struct. It is unused.finnur@chromium.org2010-10-261-3/+2
| | | | | | | | BUG=59030 TEST=None Review URL: http://codereview.chromium.org/3850003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63897 0039d316-1c4b-4281-b951-d872f2087c98