summaryrefslogtreecommitdiffstats
path: root/chrome/browser/cocoa
Commit message (Collapse)AuthorAgeFilesLines
* Rename chrome/browser/cocoa to chrome/browser/mac.mark@chromium.org2011-06-2013-2447/+0
| | | | | | | | | | | | | | | | | chrome/browser/cocoa was created in r74529 under Carnitas to break non-UI files from chrome/browser/ui/cocoa out of that directory. These non-UI files for the most part have nothing to do with Cocoa. It would be more appropriate to name this directory "mac". Three shell scripts used only by files that now live in this directory never moved along with their associated files. I'm moving them to the proper location now. BUG=none, or whatever bug tracks Carnitas cleanups TEST=none Review URL: http://codereview.chromium.org/7204034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89742 0039d316-1c4b-4281-b951-d872f2087c98
* Make FakeKeystoneRegistration a (fake) KSRegistration subclass. This appeasesmark@chromium.org2011-06-134-101/+196
| | | | | | | | | | | | | | clang, which is now able to check the type of +alloc and -init through its "related result types" feature. http://clang.llvm.org/docs/LanguageExtensions.html#objc_instancetype BUG=85885 TEST=clang compilation, Keystone still functions (check the About window in a Keystone-enabled build) Review URL: http://codereview.chromium.org/7003152 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88864 0039d316-1c4b-4281-b951-d872f2087c98
* Register with Keystone using a versionPath and versionKey.mark@chromium.org2011-05-241-10/+14
| | | | | | | | | | | | | | | | | | | | | | | Providing this data to Keystone will cause it to check the application's Info.plist to determine the installed version, rather than using the version embedded within the ticket. The version in the ticket can become stale in some rare situations through innocent user action. This allows a user to replace Chrome with an earlier version (perhaps on another channel) and not get "stuck" without autoupdates until that channel catches up with the version listed in the ticket. (b/2506062) This also prevents Keystone from believing an update is still available if Chrome is updated but not restarted and the user subsequently promotes Chrome's user ticket to a system ticket from within Chrome. (crbug.com/38696) BUG=38696 TEST=On a user ticket, ksadmin -p should show a versionPath and versionKey after Chrome is launched. If promoted to a system ticket, ksadmin -Sp should show these same two parameters. Review URL: http://codereview.chromium.org/6990046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86387 0039d316-1c4b-4281-b951-d872f2087c98
* Only the stable channel should have a brand code.mark@chromium.org2011-05-171-6/+23
| | | | | | | | BUG=82922 TEST=none Review URL: http://codereview.chromium.org/7017019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85659 0039d316-1c4b-4281-b951-d872f2087c98
* PWN chrome/browser/cocoa.mark@chromium.org2011-04-141-0/+2
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6853016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81629 0039d316-1c4b-4281-b951-d872f2087c98
* URL update.avi@chromium.org2011-03-301-2/+2
| | | | | | | | | BUG=none TEST=no code change Review URL: http://codereview.chromium.org/6675042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79829 0039d316-1c4b-4281-b951-d872f2087c98
* Move some files from base to base/memory.levin@chromium.org2011-03-282-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | raw_scoped_refptr_mismatch_checker.h ref_counted.cc ref_counted.h ref_counted_memory.cc ref_counted_memory.h ref_counted_unittest.cc scoped_callback_factory.h scoped_comptr_win.h scoped_handle.h scoped_native_library.cc scoped_native_library.h scoped_native_library_unittest.cc scoped_nsobject.h scoped_open_process.h scoped_ptr.h scoped_ptr_unittest.cc scoped_temp_dir.cc scoped_temp_dir.h scoped_temp_dir_unittest.cc scoped_vector.h singleton.h singleton_objc.h singleton_unittest.cc linked_ptr.h linked_ptr_unittest.cc weak_ptr.cc weak_ptr.h weak_ptr_unittest.cc BUG=None TEST=Compile Review URL: http://codereview.chromium.org/6714032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79524 0039d316-1c4b-4281-b951-d872f2087c98
* Carnitas: Move file_metadata out of browser/ui/cocoasail@chromium.org2011-03-062-0/+196
| | | | | | | | | | file_metadata.h is being used by cross platform code outside of browser/ui. Since file_metadata.h doesn't have UI code it should be OK to move it out of browser/ui/cocoa. BUG=None TEST=Compiled git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77081 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up CF To NS Casts and make them slightly saferdmaclach@chromium.org2011-03-032-3/+3
| | | | | | | | | | | | Also adds streaming for CFStringRefs and CFErrorRefs making it easier to add them to LOG() type statements. BUG=NONE TEST=BUILD Review URL: http://codereview.chromium.org/6594096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76714 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Remove some unneeded code to run Tasks in Cocoa run loops.rsesek@chromium.org2011-02-112-86/+0
| | | | | | | | | BUG=none TEST=Click to open Wrench menu. Click the +/- buttons. Page zooms and percentage updates. Review URL: http://codereview.chromium.org/6488016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74680 0039d316-1c4b-4281-b951-d872f2087c98
* Carnitas: Move non-ui Mac files out of browser/ui/cocoasail@chromium.org2011-02-1110-0/+2219
| | | | | | | | | | | | | | This is a part of the larger change to remove includes of browser/ui/cocoa/* from code that's outside of browser/ui. upgrade_detector.cc, browser_main.cc, and render_message_filter.cc were including files from browser/ui/cocoa/*. In this case all those files weren't actually UI related so I'm moving this out of browser/ui/cocoa and into browser/cocoa. BUG=None TEST=Compiling Review URL: http://codereview.chromium.org/6312165 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74529 0039d316-1c4b-4281-b951-d872f2087c98
* Move browser/cocoa to browser/ui/cocoaben@chromium.org2010-12-01634-95726/+0
| | | | | | | | | BUG=none TEST=none TBR=brettw git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67854 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Prevent constrained windows (sheets) from opening while instant ↵rohitrao@chromium.org2010-11-303-1/+10
| | | | | | | | | | | | | preview results are showing. The sheet will be shown when instant results are committed, either by mouse click or by pressing enter. If the instant results are destroyed, the sheet is never made visible. BUG=61373 TEST=Enable instant. Paste in a URL that opens an http auth sheet. The sheet should not be visible. No crashy, either. Press enter. The sheet should show. TEST=Enable instant. Paste in a URL that opens an http auth sheet, then delete the last character. Some sort of instant results should load, most likely a 404 page. Retype the last character. 404 page will continue to show, but the sheet will not open. Click on the preview. The sheet should show. Review URL: http://codereview.chromium.org/5301006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67712 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor: move HostContentSettingsMap to content_settingsgfeher@chromium.org2010-11-305-5/+5
| | | | | | | | | BUG=64660 TEST=build succeeds (no effective code change) Review URL: http://codereview.chromium.org/5367006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67706 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 67662 - FBTF: Remove unneeded headers from base/ (part 10)thestig@chromium.org2010-11-303-15/+14
| | | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5139006 TBR=thestig@chromium.org Review URL: http://codereview.chromium.org/5270010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67674 0039d316-1c4b-4281-b951-d872f2087c98
* Add "create Application Shortcut" to the app menu on NTP.skerner@google.com2010-11-302-2/+10
| | | | | | | | | BUG=52451 TEST=Manually create app shortcuts for urls and apps. Review URL: http://codereview.chromium.org/5273004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67664 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Remove unneeded headers from base/ (part 10)thestig@chromium.org2010-11-303-14/+15
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5139006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67662 0039d316-1c4b-4281-b951-d872f2087c98
* Makes predictive with autocompleted text the default. I'm leaving thesky@chromium.org2010-11-301-6/+1
| | | | | | | | | | | | | | | three variants in though as I'm going to add to about:flags the ability to choose between them. Because of the time I'm doing the minimal set of changes for Mac and TBRing this. Rohit, could you clean it up when you have a chance? BUG=none TEST=none TBR=estade@chromium.org, rohitra@chromium.org Review URL: http://codereview.chromium.org/5373006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67658 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for "New blocked popup UI" on Windowsgeorgey@chromium.org2010-11-303-3/+3
| | | | | | | | | | | | Changes: 1. new sets of strings indicating animation in chrome/browser/content_setting_image_model.cc - non-NULL id indicated that the situation is animated. 2. TabSpecificContentSettings has indicator that the new blockage occured, and was/was not messaged to the user. 3. ContentSettingImageView on Windows/ChromeOs is descended from LinearAnimation to allow animation of the popup indicator to the user. BUG=39260 TEST=Mocks Review URL: http://codereview.chromium.org/3120034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67630 0039d316-1c4b-4281-b951-d872f2087c98
* Remove chrome/browser/ui_thread_helpers.h because it's only used on Mac.rsesek@chromium.org2010-11-292-0/+86
| | | | | | | | | | | Move the Mac implementation to chrome/browser/cocoa/task_helpers.h. BUG=none TEST=no change Review URL: http://codereview.chromium.org/5360005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67576 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Disable UI elements in the content settings dialog if the controls are ↵thakis@chromium.org2010-11-292-13/+86
| | | | | | | | | | | | | | | | | managed. This disables the radio buttons and the exceptions button in the first 5 tabs (cookies, images, javascript, plugins, popups), and the "block 3rd party cookies" checkbox in the cookies tab. xib change: Hook up the "enabled" bindings of the buttons / radio buttons / checkbox to the new functions. (The cookie radio group's enabled state and exceptions button's enabled state is now bound to cookieSettingsManaged with a NSNegateBoolean value transformer. Likewise for images, javascript, plugins, popups.) BUG=63181 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67560 Review URL: http://codereview.chromium.org/5205008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67569 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 67560 - Mac: Disable UI elements in the content settings dialog if ↵thakis@chromium.org2010-11-292-85/+13
| | | | | | | | | | | | | | | | | | the controls are managed. This disables the radio buttons and the exceptions button in the first 5 tabs (cookies, images, javascript, plugins, popups), and the "block 3rd party cookies" checkbox in the cookies tab. xib change: Hook up the "enabled" bindings of the buttons / radio buttons / checkbox to the new functions. (The cookie radio group's enabled state and exceptions button's enabled state is now bound to cookieSettingsManaged with a NSNegateBoolean value transformer. Likewise for images, javascript, plugins, popups.) BUG=63181 TEST=none Review URL: http://codereview.chromium.org/5205008 TBR=thakis@chromium.org Review URL: http://codereview.chromium.org/5344009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67562 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Disable UI elements in the content settings dialog if the controls are ↵thakis@chromium.org2010-11-292-13/+85
| | | | | | | | | | | | | | | managed. This disables the radio buttons and the exceptions button in the first 5 tabs (cookies, images, javascript, plugins, popups), and the "block 3rd party cookies" checkbox in the cookies tab. xib change: Hook up the "enabled" bindings of the buttons / radio buttons / checkbox to the new functions. (The cookie radio group's enabled state and exceptions button's enabled state is now bound to cookieSettingsManaged with a NSNegateBoolean value transformer. Likewise for images, javascript, plugins, popups.) BUG=63181 TEST=none Review URL: http://codereview.chromium.org/5205008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67560 0039d316-1c4b-4281-b951-d872f2087c98
* Added a method to return the index of a bookmark with respect to its parent ↵pinkerton@chromium.org2010-11-294-5/+27
| | | | | | | | | | bookmark folder. Patch from v.a.shreyas@gmail.com. BUG=62522 TEST=Passes BookmarkFolderAppleScriptTest git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67559 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Force tab titles and favicons to update when committing an instant ↵rohitrao@chromium.org2010-11-291-0/+5
| | | | | | | | | | preview. BUG=61939 TEST=Enable instant. Type a url into the omnibox and wait for the preview to load. Press enter. Tab title and favicon should be correct. Review URL: http://codereview.chromium.org/5363003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67533 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Fix a memory corruption when closing a JS modal dialog.phajdan.jr@chromium.org2010-11-271-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | JSModalDialogCocoa::CloseAppModalDialog was calling [NSApp endSheet], which in turn was deleting the JSModalDialogCocoa (via a scoped_ptr in alertDidEnd). After that, the CloseAppModalDialog was writing NULL to the alert_ member variable, but at that point the object was deleted, so it was corrupting memory. GuardMalloc detected this corruption very quickly. It was also causing BrowserTest.JavascriptAlertActivatesTab to crash flakily on Mac. This change undisables that test. The bug contains more details, context, and stack traces. BUG=54896 TEST=browser_tests Review URL: http://codereview.chromium.org/5318007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67493 0039d316-1c4b-4281-b951-d872f2087c98
* Rename BookmarkDragData to BookmarkNodeData. Part 2.tfarina@chromium.org2010-11-269-19/+19
| | | | | | | | | BUG=37891 TEST=trybots Review URL: http://codereview.chromium.org/5249001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67477 0039d316-1c4b-4281-b951-d872f2087c98
* Makes committing the suggested text only update the default searchsky@chromium.org2010-11-241-2/+4
| | | | | | | | | | | provider and nothing else. BUG=none TEST=none Review URL: http://codereview.chromium.org/5270001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67218 0039d316-1c4b-4281-b951-d872f2087c98
* Remove background mode preferences UI.atwilson@chromium.org2010-11-242-41/+0
| | | | | | | | | BUG=64267 TEST=Existing tests suffice. Review URL: http://codereview.chromium.org/5361003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67205 0039d316-1c4b-4281-b951-d872f2087c98
* Make the search engine prefs relayout based on their localized strings.thomasvl@chromium.org2010-11-232-5/+63
| | | | | | | | | | Move the instant experiment into a spot where it won't cause l10n issues. BUG=64090 TEST=instant pref UI handles l10n correctly Review URL: http://codereview.chromium.org/5359001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67146 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Fixes a bug where instant suggest text would disappear on every other ↵rohitrao@chromium.org2010-11-231-1/+2
| | | | | | | | | | | | | | keystroke. Implements DeleteAtEndPressed(), which is needed for verbatim instant support. BUG=56385,59217,64212 TEST=Open chrome with instant enabled. Type "nswi" into omnibox. Should suggest "nswindow." Now type "n." Should continue to suggest "nswindow." TEST=Open chrome with instant enabled. Type "nswind" into omnibox. Should suggest "nswindow." Delete one character. Should not suggest "nswindow." Review URL: http://codereview.chromium.org/5288003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67129 0039d316-1c4b-4281-b951-d872f2087c98
* When waiting for server, show a 'Working' message instead of 'Speak now'.satish@chromium.org2010-11-231-2/+5
| | | | | | | | | | | | Also request the server to return a max of 3 results in the response. This is in preparation to test multiple recognition results in a future CL. BUG=none TEST=no change in functionality. Review URL: http://codereview.chromium.org/5281003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67115 0039d316-1c4b-4281-b951-d872f2087c98
* Update ViewIDTest on Mac and Linux for new viewstuartmorgan@chromium.org2010-11-231-1/+2
| | | | | | | | | | | TBR=rkc BUG=None TEST=Basic and Fullscreen ViewIDTest tests should pass. Review URL: http://codereview.chromium.org/5313001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67048 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Implement suggested results in the omnibox.rohitrao@chromium.org2010-11-227-2/+49
| | | | | | | | BUG=56385 TEST=Suggest text should appear when instant is on. Review URL: http://codereview.chromium.org/4643008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67022 0039d316-1c4b-4281-b951-d872f2087c98
* Tabpose/mac: Fix selecting a thumb by clicking if the mouse wasn't moved ↵thakis@chromium.org2010-11-221-1/+8
| | | | | | | | | | | previously. BUG=64127 TEST=See bug. Review URL: http://codereview.chromium.org/5258002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67020 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Make the Confirm to Quit floaty panel a singleton so multiple panels ↵rsesek@chromium.org2010-11-223-12/+31
| | | | | | | | | | | do not appear. BUG=61815 TEST=With the confirm-to-quit lab enabled, mash Cmd+Q. Only 1 floaty window appears. Review URL: http://codereview.chromium.org/5255001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67001 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Add a preference for Instant search.rsesek@chromium.org2010-11-225-0/+195
| | | | | | | | | | | | | | | | | | XIB Changes (Preferences.xib): * Add a NSButton checkbox for the Instant preference as an outlet (not with bindings). Hook up the action of the button to First Responder. * Add a "Learn more" link for Instant that sends the action to First Responder. * Increase the size of the Basics view to accommodate those new subviews. Note that this will not be properly sized-to-fit in some locales. See http://crbug.com/64090 for details. BUG=63651 TEST=Chromium-->Preferences. Toggle Instant and get the info sheet. Pressing OK enables it, Cancel does not. TEST=After the first enabling, the sheet does not appear again. Review URL: http://codereview.chromium.org/5090007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66994 0039d316-1c4b-4281-b951-d872f2087c98
* Change the X position of the InfoBubbleView's arrow tip. Also adjust padding ↵rsesek@chromium.org2010-11-222-7/+8
| | | | | | | | | | | for the PageInfoBubble. BUG=63153 TEST=Visual, as in the mock attached to the bug. Review URL: http://codereview.chromium.org/5196004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66962 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Add the instant opt-in UI to the omnibox dropdown.rohitrao@chromium.org2010-11-229-0/+360
| | | | | | | | BUG=58917, 56385 TEST=Once Instant opt-in is enabled, it should appear in omnibox, not look ugly. Review URL: http://codereview.chromium.org/5161003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66960 0039d316-1c4b-4281-b951-d872f2087c98
* REGRESSION: Show correct exe icon in the downloadshelfkinuko@chromium.org2010-11-192-5/+5
| | | | | | | | | | | | | The bug has been introduced in r65418. In r65418 I replaced some DownloadItem::full_path() with DownloadItem::GetUserVerifiedFileName() for loading icons, but on Windows it needed to be a full-path (rather than a file name). BUG=62495 TEST=download mini_installer.exe and see if the correct icon is shown in the downloadshelf after the download is finished. TEST=download regular files and see if the correct icon is shown (from the beginning). Review URL: http://codereview.chromium.org/5147006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66838 0039d316-1c4b-4281-b951-d872f2087c98
* When an extension is uninstalled, close all desktop notifications from that ↵johnnyg@chromium.org2010-11-192-1/+3
| | | | | | | | | | | | | | | | | | | extension. This change also refactors the balloon collection code to remove duplication between chrome and chromeos. Removes some gross removal code which was using fake notifications just to get the right ID. BUG=58266 TEST=open notifications from extension, uninstall extensions Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65879 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66571 Review URL: http://codereview.chromium.org/4635007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66829 0039d316-1c4b-4281-b951-d872f2087c98
* Adds support for proper handling of verbatim queries. That is, if thesky@chromium.org2010-11-191-5/+6
| | | | | | | | | | | | user enabled predictive instant we switch to verbatim in certain situations. BUG=59217 TEST=see bug Review URL: http://codereview.chromium.org/5225003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66805 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing the uninitialized value reported in http://crbug.com/63428.alekseys@chromium.org2010-11-181-18/+21
| | | | | | | | | | BUG=63428 TEST=mac_valgrind should not fail Review URL: http://codereview.chromium.org/5192001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66692 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Include browser.h -> ui/browser.h [Final].jhawkins@chromium.org2010-11-1835-54/+54
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5197001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66668 0039d316-1c4b-4281-b951-d872f2087c98
* Provides API for passing in whether verbatim or predictive should besky@chromium.org2010-11-181-0/+1
| | | | | | | | | | | | used when updating instant. I haven't wired this up to anything yet, so this doesn't change the actual behavior of anything. BUG=59217 TEST=none Review URL: http://codereview.chromium.org/5187001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66654 0039d316-1c4b-4281-b951-d872f2087c98
* Make pink's TabContentsWrapper change compile on Windows.ben@chromium.org2010-11-1814-114/+131
| | | | | | | | | | Code by pinkerton@, with modifications by evanm and myself to get it to build on windows/linux/chromeos. BUG=none TEST=none Review URL: http://codereview.chromium.org/4694008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66626 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 66571 - When an extension is uninstalled, close all desktop ↵johnnyg@chromium.org2010-11-182-3/+1
| | | | | | | | | | | | | | | | | | | | notifications from that extension. This change also refactors the balloon collection code to remove duplication between chrome and chromeos. Removes some gross removal code which was using fake notifications just to get the right ID. BUG=58266 TEST=open notifications from extension, uninstall extensions Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65879 Review URL: http://codereview.chromium.org/4635007 TBR=johnnyg@chromium.org Review URL: http://codereview.chromium.org/5162003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66572 0039d316-1c4b-4281-b951-d872f2087c98
* When an extension is uninstalled, close all desktop notifications from that ↵johnnyg@chromium.org2010-11-182-1/+3
| | | | | | | | | | | | | | | | | extension. This change also refactors the balloon collection code to remove duplication between chrome and chromeos. Removes some gross removal code which was using fake notifications just to get the right ID. BUG=58266 TEST=open notifications from extension, uninstall extensions Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65879 Review URL: http://codereview.chromium.org/4635007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66571 0039d316-1c4b-4281-b951-d872f2087c98
* Handle resize corner layout entirely in the BrowserView (views) or ↵alekseys@chromium.org2010-11-1612-93/+312
| | | | | | | | | | | | | | | | | | | | | | | | | | | BrowserWindow* (Mac) and extend RenderViewHost with a concept of reserved contents rect, a place to show extra stuff, such as Sidebar's mini tab UI. sidebar UI implementation warranted this change (mini tabs UI and resize corner area for sidebar contents). TabContentsDelegate::GetRootWindowResizerRect() is no more, reserved contents area is now cached in RenderWidgetHostView and updated upon view resize. Views: BrowserView is responsible for the actual layout and reserved contents area update. Mac: TabContentsController now manages all TabContents views in the main browser window to solve two problems, first to prevent contents flickering during tab change not only for the page, but for the sidebar and devtools contents too and, second, to monitor contents view frame changes and update reserved contents area accordingly. BUG=51084 TEST=All tests should pass, this is a refactoring CL. Review URL: http://codereview.chromium.org/3547008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66332 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Speculative fix: When a save panel closes, the returned |context| data ↵rohitrao@chromium.org2010-11-161-0/+10
| | | | | | | | | | is somehow NULL (according to crash reports). CHECK for this case to see if it is really happening. BUG=58959 TEST=No idea how to reproduce this crash. I hope there will be fewer crash reports. Review URL: http://codereview.chromium.org/3748003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66284 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-19 00:06:35 +0000