summaryrefslogtreecommitdiffstats
path: root/chrome/browser/cocoa
Commit message (Collapse)AuthorAgeFilesLines
* Added a method to check if a browser is closing.pinkerton@chromium.org2010-08-1024-0/+2459
| | | | | | | | | | | | | | | | Added a method to get the next node ID for bookmarks managed by the bookmark model. Added AppleScript support. Added scripting definition file. Added support for saving tab. Added localization support. Added consistent error nos/error messages. (patch developed by v.a.shreyas@gmail.com) BUG=27468 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55569 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Insert the Update Chrome item to existing Wrench menus when notified.rsesek@chromium.org2010-08-103-0/+38
| | | | | | | | | BUG=50659 TEST=Wait for upgrade. Get yellow ball on Wrench menu. Open menu, see Update Chrome item. Review URL: http://codereview.chromium.org/3124002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55568 0039d316-1c4b-4281-b951-d872f2087c98
* Add a session storage node to the cookies tree view for collected cookies.jochen@chromium.org2010-08-102-3/+3
| | | | | | | | | | | Furthermore, local storage and session storage accesses are recorded separately in the tab contents, so they can be displayed in the correct bucket. BUG=45230 TEST=none Review URL: http://codereview.chromium.org/3053052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55563 0039d316-1c4b-4281-b951-d872f2087c98
* Don't redraw the location bar if there's nothing to redraw.jochen@chromium.org2010-08-104-8/+18
| | | | | | | | | BUG=none TEST=perf improvement on page_cycler_intl1 Review URL: http://codereview.chromium.org/3168001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55561 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 55548 - Reland r55382. When blocking cookies, also show an icon in ↵jochen@chromium.org2010-08-102-13/+5
| | | | | | | | | | | | | | | | | | the location bar when cookies are accessed. If the user choses to block cookies per default, this will grant access to the collected cookies dialog as soon as the page accesses cookies. Right now, the icon is only shown if cookies were actually blocked. BUG=45230 TEST=Canned*.*:ContentSettingImage*.*:TabSpecific*.* Review URL: http://codereview.chromium.org/3014056 Review URL: http://codereview.chromium.org/3148002 TBR=jochen@chromium.org Review URL: http://codereview.chromium.org/3132003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55553 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r55382. When blocking cookies, also show an icon in the location bar ↵jochen@chromium.org2010-08-102-5/+13
| | | | | | | | | | | | | | | when cookies are accessed. If the user choses to block cookies per default, this will grant access to the collected cookies dialog as soon as the page accesses cookies. Right now, the icon is only shown if cookies were actually blocked. BUG=45230 TEST=Canned*.*:ContentSettingImage*.*:TabSpecific*.* Review URL: http://codereview.chromium.org/3014056 Review URL: http://codereview.chromium.org/3148002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55548 0039d316-1c4b-4281-b951-d872f2087c98
* Whitespace change to trigger bots.viettrungluu@chromium.org2010-08-101-1/+1
| | | | | | | | TBR=viettrungluu@chromium.org Review URL: http://codereview.chromium.org/2694003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55526 0039d316-1c4b-4281-b951-d872f2087c98
* Make GTK certificate selection dialog a constrained windowdavidben@chromium.org2010-08-101-2/+4
| | | | | | | | | | | | | | This makes the dialog tab-modal. Implementation on OS X is forthcoming. Windows will be messier; we'll need to implement our own dialog, but we want that anyway because of the annoying blocking call. R=wtc,mattm TEST=none BUG=50710 Review URL: http://codereview.chromium.org/3077008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55509 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Highlight selected tile in tabpose.thakis@chromium.org2010-08-092-18/+33
| | | | | | | | | | | BUG=50307 TEST=selected tile now has a blue border TBR=trungl Review URL: http://codereview.chromium.org/3140001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55505 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: more tabposethakis@chromium.org2010-08-094-22/+531
| | | | | | | | | | | | | | | | | | | | | | | | Add layout logic, add layers, add entry/exit animations, add mouse selection of layers. Most things are functional, but no thumbnail images are shown yet. Why is the Tile stuff c++ classes instead of objc classes? Because some of the linux folks said they'd like to see this on linux too, so I don't want to make it too hard for me to port this to other platforms if this survives the experiment stage. Why is the Tile stuff not in its own file then? Because things are still far from settled down, and this way it's easier for me to change things around. BUG=50307 TEST= * All the following happens only if --enable-expose-for-tabs is passed in, else all of it should be disabled. * Activate tabpose. One layer per tab should appear, they should be layed out in a sensible manner * Layout should also be sensible if the window has extreme width to height ratios. * Layers can be selected by hovering them with the mouse. enter, space, and clicking all select the currently selected layer. esc animated back to the initially selected layer * If shift is down when tabpose is entered or left, the animation plays in slow motion * For now, the layers are just black rects with a shadow or a white rect with a shadow for the selected layer. * Shadows are not shown while the entry or exit animations are running (because animating shadows is very slow, and it's not noticable that they're not there during the animation) * When a layer has been selected, the corresponding tab is selected once the exit animation is done * The selected layer should animate to the size of the tab contents (minus download shelf, if visible): It should include infobars, the detached bookmarks bar on the ntp, and devtools. Review URL: http://codereview.chromium.org/3063031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55482 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Fix kill button and selection in task managerthakis@chromium.org2010-08-073-15/+86
| | | | | | | | | BUG=51488,51486 TEST=Sort on a changing column such as %cpu or goats teleported. The selection should follow the selected rows (i.e. if the "maps" process jumps from row 2 to row 4, the selected row should follow). "Kill process" should kill the currently selected process, not the process that's at that index when no sorting is happening. Review URL: http://codereview.chromium.org/3047055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55361 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Remove unneeded headers from base/ (part 5)thestig@chromium.org2010-08-074-4/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3041049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55349 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Remove unneeded headers from base/ (part 4)thestig@chromium.org2010-08-071-1/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2819094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55345 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Do not use |+[NSColor selectedMenuItemColor]| in a gradient due to ↵rsesek@chromium.org2010-08-071-1/+1
| | | | | | | | | | | color space issues. BUG=49448 TEST=On both 10.5 and 10.6, open the Wrench menu and click a button. Button has blue gradient. Review URL: http://codereview.chromium.org/3046052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55327 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Don't fade text on bookmark items if we don't have to.jeremy@chromium.org2010-08-061-1/+1
| | | | | | | | | | | Fix a float <-> int comparison so items whose width is fractionally larger than the width of the cell aren't truncated. BUG=51183 TEST=See bug Review URL: http://codereview.chromium.org/3096007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55305 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Make the default background style for InfoBubbleView white, per alcor.rsesek@chromium.org2010-08-062-3/+4
| | | | | | | | | | | This affects the bookmark bubble and the extension installed bubble. BUG=51429 TEST=Press the Star button. Resulting bubble has a white, not gradient, background. Review URL: http://codereview.chromium.org/3038054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55298 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Use the new {EXPECT,ASSERT}_NS{EQ,NE} macros in unit tests where possible.rsesek@chromium.org2010-08-0631-279/+290
| | | | | | | | | BUG=none TEST=unit_tests Review URL: http://codereview.chromium.org/3095004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55280 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Don't indicate acceptance of non-url drag data.shess@chromium.org2010-08-061-0/+3
| | | | | | | | | | | | | If -performDragOperation: won't accept the data, then -draggingEntered: and -draggingUpdated: also need to deny the drag so that the OS doesn't show the drop indicator. BUG=32139 TEST=Try to drop an image from TextEdit into Omnibox or tab bar. Review URL: http://codereview.chromium.org/3077027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55263 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce a resource identifier for content settings.jochen@chromium.org2010-08-061-0/+10
| | | | | | | | | | | This will allow for having per plugin content settings, i.e. the content settings type would be plugin and the resource identifier would be to concrete plugin that is about to be loaded. BUG=39252 TEST=unit_tests Review URL: http://codereview.chromium.org/2878075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55213 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Remove unneeded headers from base/ (part 3)thestig@chromium.org2010-08-062-2/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3037044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55192 0039d316-1c4b-4281-b951-d872f2087c98
* Make reload accelerators more consistent across platforms.derat@chromium.org2010-08-061-4/+4
| | | | | | | | | | | | | | | | | | | | | | On Windows and Linux (both Views and GTK+), this makes Ctrl-R, F5, and regular clicks on the reload button do regular reloads, while Ctrl-Shift-R, Shift-F5, Control-F5, and holding Shift or Control while clicking the button all bypass the cache. It does the same for the reload button on Mac, but I'm not modifying any Mac keyboard shortcuts in this change (it looks like Command-Shift-R already bypasses the cache). I've updated http://crbug.com/38356 to mention that when the F5 shortcut is added to Mac, the cache-bypassing modifiers should also be supported. BUG=47383 TEST=none Review URL: http://codereview.chromium.org/2876008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55175 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Prevent a crash with the DownloadStartedAnimation.rsesek@chromium.org2010-08-061-1/+5
| | | | | | | | | | | | The initializer for the class can sometimes return nil. If so, do not try to access an ivar directly. BUG=51307 TEST=none Review URL: http://codereview.chromium.org/3060047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55165 0039d316-1c4b-4281-b951-d872f2087c98
* Fix unit_tests on Mac by renaming the MAc test name for DownloadUtilMacTest.phajdan.jr@chromium.org2010-08-051-4/+4
| | | | | | | | | | | TBR=thakis TEST=unit_tests BUG=48913, 21479 Review URL: http://codereview.chromium.org/3085015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55094 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up download code:phajdan.jr@chromium.org2010-08-051-5/+6
| | | | | | | | | | | | | | | | | | - move filename generation parts and related code out of DownloadManager download_util is not the best place for it, but it's better than DownloadManager which we're trying to minimize - clean up posting tasks to different threads. There's no need to create separate methods for that, it was cluttering the file needlessly - other minor cleanups, like using static_cast instead of C-style cast TEST=unit_tests, browser_tests, ui_tests BUG=48913 Review URL: http://codereview.chromium.org/3043048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55088 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Tweaks to the Wrench menu buttons.rsesek@chromium.org2010-08-053-0/+116
| | | | | | | | | | | | This changes the two-tone background to an even gradient and changes the push state of the buttons to use the blue selected menu item color. BUG=none TEST=visual Review URL: http://codereview.chromium.org/3072021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55007 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup of unused code.avi@chromium.org2010-08-041-1/+0
| | | | | | | | | BUG=none TEST=no change Review URL: http://codereview.chromium.org/3064040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54940 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Make clang compile unit_tests.thakis@chromium.org2010-08-042-2/+1
| | | | | | | | BUG=TEST=none Review URL: http://codereview.chromium.org/3012045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54924 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Some clang appeasing.thakis@chromium.org2010-08-048-13/+13
| | | | | | | | BUG=TEST=none Review URL: http://codereview.chromium.org/3089004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54870 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Integrate divider into browser-action overflow chevron.shess@chromium.org2010-08-036-1/+152
| | | | | | | | | | | Divider shows when the mouse is not hovering. BUG=50575 TEST=divider shows when the mouse is not hovering. Review URL: http://codereview.chromium.org/3014049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54843 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Adjust browser-action and content-setting popup pointsshess@chromium.org2010-08-033-17/+37
| | | | | | | | | | | | | | | Adjust the browser-action popup point to leave the top border of the window 2px below the bottom border of the Omnibox. This matches the Omnibox popup, the bookmark popup, and page-action popups. Likewise content-setting popup. BUG=50575 TEST=The popup is spaced correctly. Review URL: http://codereview.chromium.org/3054040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54839 0039d316-1c4b-4281-b951-d872f2087c98
* Remove double initialization which causes valgrind failure in unit test.johnnyg@chromium.org2010-08-031-1/+0
| | | | | | | | BUG=49590 TEST=this test Review URL: http://codereview.chromium.org/3085007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54824 0039d316-1c4b-4281-b951-d872f2087c98
* Reset chrome://newtab URLs when the user selects to configure it.mnissler@chromium.org2010-08-031-2/+5
| | | | | | | | | BUG=50927 TEST=Manually configure a profile with prefs::kHomepage = chrome://newtab and prefs::kHomePageIsNewTabPage = true, fire up chrome and try to configure a different homepage URL through the options dialog. Review URL: http://codereview.chromium.org/3092003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54807 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Enable click-drag-release behavior in the Wrench menu's custom items.rsesek@chromium.org2010-08-039-43/+307
| | | | | | | | | | | | | | XIB changes: * Replace the edit item's segmented control with 3 buttons * Make the root view of both items a MenuTrackedRootView * Use the custom MenuTrackedButton for all the buttons BUG=49356 TEST=Click open the Wrench menu, hold, and drag over the buttons and they perform their function. Review URL: http://codereview.chromium.org/3072014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54804 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Adjust toolbar spacing of browser actions for M6.shess@chromium.org2010-08-035-76/+65
| | | | | | | | | | | | | | | | | | | | | | | | Toolbar.xib change brings browser-action container view out from under Omnibox. Push browser-action sizing code into controller to reduce exposed constants. Make size consistent with other toolbar buttons. 4px visual spacing from omnibox to first browser action (grippy in that area), between browser actions, and last action to wrench menu. browser_actions_overflow_Template.pdf resource for browser-action chevron. Chevron same height as browser actions. Get rid of divider between browser actions and wrench (future CL will integrate it into chevron button). Chevron 4px from Omnibox or 2px from last browser action, then 4px to wrench menu. Chevron button has hover like other buttons. BUG=50575 TEST=Browser-actions area still works right WRT spacing and rearranging and everything else. Review URL: http://codereview.chromium.org/3012044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54782 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Fix merge mishap.thakis@chromium.org2010-08-031-1/+1
| | | | | | | | | BUG=50307 TEST=Start chrome with --enable-expose-for-tabs. cmd-f10 should toggle a grey overlay instead of doing something strange to the tabstrip. Review URL: http://codereview.chromium.org/3007028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54774 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] M6 Omnibox positioning changes.shess@chromium.org2010-08-035-29/+91
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3px from top and bottom of images to cell edges in popup. With this change baselines worked out without tweaking. Omnibox popup text wasn't quite aligned with field because previous change used leading 'w' (regression). This change measured using leading 'P'. Adjust keyword-hint decoration spacing around the image. Also adjust baseline to match font (regression). Modify ImageDecoration to center the image horizontally, which allows the decoration width to be independent of the image width. PageActionDecoration uses this to pin the effective size at |kPageActionIconMaxSize|. Position page-action and bookmark popups so top border is at same gap from Omnibox (2px) as Omnibox popup. The mocks actually show the bookmark point as an additional px from the star "crotch", but I think this is reasonable for M6. BUG=50575, 50765 TEST=none. Everything still works? Review URL: http://codereview.chromium.org/3015046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54767 0039d316-1c4b-4281-b951-d872f2087c98
* Remove number conversion functions from string_util. These moved to ↵brettw@chromium.org2010-08-032-4/+7
| | | | | | | | | | string_number_conversions. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3054036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54747 0039d316-1c4b-4281-b951-d872f2087c98
* Add "Load all plugins on this page" button to blocked plugins bubble if ↵bauerb@chromium.org2010-08-032-6/+52
| | | | | | | | | | | | | | | click-to-play is enabled. Screenshot: http://imgur.com/ZKsQB.png XIB changes: Add a rounded rect button hooked up to |loadAllPlugins:| in the File's Owner and referenced by its |loadAllPluginsButton_| outlet, wrapped in a GTMWidthBasedTweaker. BUG=49677 TEST=ContentSettingBubbleModelTest.* Review URL: http://codereview.chromium.org/3015036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54720 0039d316-1c4b-4281-b951-d872f2087c98
* When dropping a tab torn from a maximized window, inherit the restored size ↵pkasting@chromium.org2010-08-022-5/+4
| | | | | | | | | | and maximized state, instead of creating a restored window at the maximized size. BUG=22154 TEST=Drag a tab from a maximized window and drop it; it should create a maximized window. Review URL: http://codereview.chromium.org/3032039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54607 0039d316-1c4b-4281-b951-d872f2087c98
* Don't leak memory when displaying a SFChooseIdentityPaneldavidben@chromium.org2010-08-021-26/+32
| | | | | | | | | | | | | | | | | | | | SFChooseIdentityPanel has rather non-standard (buggy) referencing semantics as compared to other sheets. In particular, it fails to take a reference to itself while open. It also takes a reference to its delegate, introducing a reference cycle in our implementation. This removes the panel reference in the delegate, in light of the second behavior, and works around problems caused by the first with an autorelease. Also avoids an indexing error in release mode should a DCHECK fail. R=wtc,mark BUG=none TEST=displaying certificate selections still work in OS X Review URL: http://codereview.chromium.org/3044036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54588 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 54560 - nick@chromium.org2010-08-021-2/+0
| | | | | | | | | | | | | | | | Change removing method, GetBrowser from TabContentsDelegate, as this was breaking an abstraction layer. This routine was originally added in CL 434046, which required the Browser* to construct extension popup views from within Chrome-Frame instances. I changed all accesses to Browser instances from usage of the above method, to either iterating the BrowserList using the situation-specific profile as a search key, or modifying the appropriate delegate interfaces to provide the functionality that was previously used directly via the Browser. BUG=None TEST=None Review URL: http://codereview.chromium.org/2941001 TBR=twiz@google.com Review URL: http://codereview.chromium.org/3012042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54565 0039d316-1c4b-4281-b951-d872f2087c98
* Change removing method, GetBrowser from TabContentsDelegate, as this was ↵twiz@google.com2010-08-021-0/+2
| | | | | | | | | | | | | breaking an abstraction layer. This routine was originally added in CL 434046, which required the Browser* to construct extension popup views from within Chrome-Frame instances. I changed all accesses to Browser instances from usage of the above method, to either iterating the BrowserList using the situation-specific profile as a search key, or modifying the appropriate delegate interfaces to provide the functionality that was previously used directly via the Browser. BUG=None TEST=None Review URL: http://codereview.chromium.org/2941001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54560 0039d316-1c4b-4281-b951-d872f2087c98
* notifications: Convert some std::wstring over to string16.tfarina@chromium.org2010-08-012-3/+3
| | | | | | | | | | | BUG=43899 TEST=compiles, trybots. Signed-off-by: Thiago Farina <tfarina@chromium.org> Review URL: http://codereview.chromium.org/3010028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54484 0039d316-1c4b-4281-b951-d872f2087c98
* Also fix mac unit testsjochen@chromium.org2010-07-311-2/+6
| | | | | | | | | BUG=none TEST=unit_tests Review URL: http://codereview.chromium.org/2873086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54463 0039d316-1c4b-4281-b951-d872f2087c98
* Flip the default for the cookie prompt to disabled.jochen@chromium.org2010-07-313-6/+6
| | | | | | | | | BUG=50083 TEST=none Review URL: http://codereview.chromium.org/3030033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54461 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded headers from app/ (part 3)thestig@chromium.org2010-07-3114-5/+12
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3054029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54436 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Un-tweak omnibox height and spacing and font.shess@chromium.org2010-07-302-7/+4
| | | | | | | | | | | | | | | | | Partial revert of http://codereview.chromium.org/3046029 . Toolbar.xib change to make Omnibox 27px tall again. Omnibox font back to system size, shift baselines to match, inset location icon additional pixel to look good WRT text spacing, adjust ev and keyword bubbles to match, adjust popup to match. BUG=50765, 50575 TEST=See 50765 Review URL: http://codereview.chromium.org/2806098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54410 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Let task manager columns span entire window immediately.thakis@chromium.org2010-07-301-0/+1
| | | | | | | | | BUG=32148 TEST=Open task manager. It should immediately look like it did if you opened it and then resized it by 1px previously. Review URL: http://codereview.chromium.org/3056036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54387 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Give page actions a default image when preview enabled.shess@chromium.org2010-07-301-1/+10
| | | | | | | | | | | | During install it is possible to display (or layout) the action before the images have come in. Provide a default image for this case. BUG=50771 TEST=See bug. Review URL: http://codereview.chromium.org/3047031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54386 0039d316-1c4b-4281-b951-d872f2087c98
* Move the number conversions from string_util to a new file.brettw@chromium.org2010-07-303-8/+11
| | | | | | | | | | | | | Use the base namespace in the new file. Update callers. I removed all wstring variants and also the string->number ones that ignore the return value. That encourages people to write code and forget about error handling. TEST=included unit tests BUG=none Review URL: http://codereview.chromium.org/3056029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54355 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-14 04:08:07 +0000