summaryrefslogtreecommitdiffstats
path: root/chrome/browser/cocoa
Commit message (Collapse)AuthorAgeFilesLines
* Fix issue where dragging a newly created tab drags the entire window by ↵pinkerton@chromium.org2009-05-131-1/+13
| | | | | | | | commenting out some use of CoreAnimation. BUG=11829. TEST=dragging tags out of a new window. Review URL: http://codereview.chromium.org/113343 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15959 0039d316-1c4b-4281-b951-d872f2087c98
* This CL updates chrome to the latest version of skia, retrieved via DEPS, andsenorblanco@chromium.org2009-05-131-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | placed in third_party. All relevant skia changes (for all 3 platforms) have been upstreamed. Most of this CL is mind-numbingly repetitive. Things of interest are: skia.gyp (now points at third_party versions), DEPS, and SkUserConfig.h. stdint.h: Skia now requires C99 integer types, which MSVC doesn't support natively. I have put typedefs in config/win/stdint.h. Note that the new version of skia appears to render rects whose coordinates are "backwards" (ie., x2 < x1 or y2 < y1), which were formerly culled. There were a couple obvious instances of this in the code which I fixed, but there may be more. There were ~35 layout test failures due to minor pixel differences which I rebaselined on Windows and Linux, and 8 genuine failures related to masks and stroked text, which I have put in text_expectations.txt and assigned to myself. (There was another change which broke ~1700 tests on each platform, but I put that change behind an #ifdef for now). R=brettw Review URL: http://codereview.chromium.org/65012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15949 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for delegate ordering problem dragging tabs between windows. We now ↵pinkerton@chromium.org2009-05-124-43/+49
| | | | | | | | remove the delegate and re-instate the new one in the correct order. Clean up the API a little as well. BUG=11466. TEST=dragging a tab into an existing window then switching tabs back and forth in the destination window. Review URL: http://codereview.chromium.org/115240 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15864 0039d316-1c4b-4281-b951-d872f2087c98
* Record UI metric for closing tabs with the mouse.pinkerton@chromium.org2009-05-121-8/+13
| | | | | | Review URL: http://codereview.chromium.org/114021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15854 0039d316-1c4b-4281-b951-d872f2087c98
* Move the bookmark node iD generation to bookmark model isntead ofmunjal@chromium.org2009-05-122-17/+12
| | | | | | | | bookmark node. This will also make the IDs more dense. Review URL: http://codereview.chromium.org/99304 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15839 0039d316-1c4b-4281-b951-d872f2087c98
* Use Chrome facilities for omnibox state save and restore on Mac.shess@chromium.org2009-05-115-26/+22
| | | | | | | | | | | | | | | | | TabContents has a facility for storing a bag of stuff across current-tab changes. Wire up AutocompleteEditViewMac to use that facility. Unfork some code in Browser::TabSelectedAt() so that the new code gets used, and straighten up the Mac code along the code path between there and AutocompleteEditViewMac. This overall change also exposed a couple bugs/mis-features in the AutocompleteEditViewMac code. TEST=Text field maintains contents and selection across tab changes, even when edited. Review URL: http://codereview.chromium.org/114017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15790 0039d316-1c4b-4281-b951-d872f2087c98
* Add stubs for UserChangedThemes to Mac and Linux.glen@chromium.org2009-05-092-0/+5
| | | | | | Review URL: http://codereview.chromium.org/115156 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15708 0039d316-1c4b-4281-b951-d872f2087c98
* move this to app/gfx, part of previous commitben@chromium.org2009-05-081-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15688 0039d316-1c4b-4281-b951-d872f2087c98
* Fix default browser info string to change text and color instead of ↵pinkerton@chromium.org2009-05-081-20/+50
| | | | | | | | hiding/showing. Record default browser metric. Review URL: http://codereview.chromium.org/115129 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15638 0039d316-1c4b-4281-b951-d872f2087c98
* Enable the zoom button and stub out an implementation until we can get the ↵pinkerton@chromium.org2009-05-071-6/+33
| | | | | | | | real rect from WebCore. Review URL: http://codereview.chromium.org/115096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15568 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug with cocoa -> gfx coordinates.pinkerton@chromium.org2009-05-071-1/+1
| | | | | | Review URL: http://codereview.chromium.org/115089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15551 0039d316-1c4b-4281-b951-d872f2087c98
* Still need to release all top-level objects of a nib.avi@google.com2009-05-071-0/+1
| | | | | | Review URL: http://codereview.chromium.org/115045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15549 0039d316-1c4b-4281-b951-d872f2087c98
* Messed up dependency key in one case when applying feedback. TBR=thomasvlpinkerton@chromium.org2009-05-061-1/+1
| | | | | | Review URL: http://codereview.chromium.org/113049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15452 0039d316-1c4b-4281-b951-d872f2087c98
* Implement most of the "basics" pref panel on Mac, including code to set the ↵pinkerton@chromium.org2009-05-063-15/+414
| | | | | | | | default browser. Fix up some related comments around the code. Review URL: http://codereview.chromium.org/113032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15445 0039d316-1c4b-4281-b951-d872f2087c98
* Find bar:estade@chromium.org2009-05-062-3/+2
| | | | | | | | | - system bell for linux find bar when search not found - move "not found" logic to find bar controller Review URL: http://codereview.chromium.org/112002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15382 0039d316-1c4b-4281-b951-d872f2087c98
* Move l10n_util to app/ben@chromium.org2009-05-053-3/+3
| | | | | | | http://crbug.com/11387 Review URL: http://codereview.chromium.org/109043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15352 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes for 10.6jeremy@chromium.org2009-05-051-5/+34
| | | | | | | | | | | | | * Workaround for rdar://6857649 - NSGradient fails when using LAB Colorspace * Update sandbox config file for 10.6 BUG=11265 TEST=Open Chrome on 10.6, it should have tabs and the tab title should reflect the title of the page that's currently loaded. Review URL: http://codereview.chromium.org/109032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15328 0039d316-1c4b-4281-b951-d872f2087c98
* FindBarView::UpdateForResult is not a good place to finnur@chromium.org2009-05-052-0/+6
| | | | | | | | | | | | | | | | | beep if nothing was found on the page. The reason is that it is gets called when you switch from one tab to the other. I've added a function to FindBar that the controller can call and each platform can implement whatever sound they want to use. BUG=10823 TEST=Open google.com, search for z0, it should beep (no matches). Open new tab, switch back to the old tab and it should not beep. Review URL: http://codereview.chromium.org/99372 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15269 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: enable omni box ui test and automation proxy ui test.estade@chromium.org2009-05-051-1/+4
| | | | | | | | Enable a lot of (already essentially working) automation code along the way. Review URL: http://codereview.chromium.org/100278 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15258 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes focus issues when browsing on Mac.rohitrao@chromium.org2009-05-041-2/+7
| | | | | | | | | | http://crbug.com/10032 TEST=Open a new tab and browse to www.google.com. Type something and check that focus is correctly set to the text field. Review URL: http://codereview.chromium.org/99327 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15226 0039d316-1c4b-4281-b951-d872f2087c98
* Reset the omnibox contents when the user reloads the page. Patch by Yusuke ↵pkasting@chromium.org2009-05-042-0/+5
| | | | | | | | Sato (see http://codereview.chromium.org/100198 ), r=me. BUG=2985 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15211 0039d316-1c4b-4281-b951-d872f2087c98
* Replace all occurrances of WebContents with TabContents.brettw@chromium.org2009-05-043-24/+21
| | | | | | Review URL: http://codereview.chromium.org/99177 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15194 0039d316-1c4b-4281-b951-d872f2087c98
* This is the first part of the PageAction implementation. More work is ↵finnur@chromium.org2009-05-011-0/+1
| | | | | | | | | | | | | | | | required, but this is a good checkpoint. Design doc: http://dev.chromium.org/developers/design-documents/extensions/page-actions-api This checkin only covers Tab scoped page actions (not type "permanent"). It works end to end (if you have an extension that supplies the page action info -- I created an RSS page action that links to Google Reader). Please note that TabIndex is hard coded to 0 until the extension system can provide the tab id to the extensions (which I understand is in progress). This means that page action(s) only show up for the first tab in the tabstrip. :) BUG=None TEST=There is a unit test for the API, but apart from that it is not possible to test this manually without writing an extension that adds a PageAction. My RSS page action is not ready to be checked in but I can provide it if there is interest in a sneak preview during review/QA. Review URL: http://codereview.chromium.org/99253 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15105 0039d316-1c4b-4281-b951-d872f2087c98
* Changes the way we calculate hit rects in TabView to reducerohitrao@chromium.org2009-04-301-1/+9
| | | | | | | | | | | overlap between tabs. TEST=Open a few tabs, try clicking on the right half of the close button that's to the left of the selected tab. Review URL: http://codereview.chromium.org/99225 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14990 0039d316-1c4b-4281-b951-d872f2087c98
* Turn off unit test that fails on builder.pinkerton@chromium.org2009-04-301-0/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14981 0039d316-1c4b-4281-b951-d872f2087c98
* Add notification (and unit test) for closing prefs window so it can be ↵pinkerton@chromium.org2009-04-303-5/+37
| | | | | | | | cleaned up properly in the app controller. Make the prefs window controller the window's delegate so it gets close notifications. Review URL: http://codereview.chromium.org/99238 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14967 0039d316-1c4b-4281-b951-d872f2087c98
* Add a very basic preferences window controller with unit test. Fix the prefs ↵pinkerton@chromium.org2009-04-303-0/+106
| | | | | | | | nib to know the FileOwner is a NSWindowController and hook them together. Review URL: http://codereview.chromium.org/102015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14958 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding this, it was missing the Mac unit-test change, that was breaking ↵jcampan@chromium.org2009-04-301-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | the build. TBR=ben Closing the last tab with a download in-progress would cause the tab to be closed and become unusable if the user decides not to proceed with the browser shutdown. This is because we check for in-progress downloads when the browser is closed, and the tab is closed before that, leaving the tab-strip in a bad state. This CL ensures we also bring-up the confirmation dialog when the last tab is closed. BUG=10680 TEST=Start downloading a big file. While the file is downloading, close all tabs. When closing the last tab, the in-progress download dialog should be shown. Select the 'Wait for downloads', the download tab should be shown and the previous tab should still be displayed and functional. Close all tabs again, this time select the 'Close and cancel downloads' option, the browser should be closed. Review URL: http://codereview.chromium.org/100210 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14952 0039d316-1c4b-4281-b951-d872f2087c98
* Move window chrome into drag overlay so they stand out more during a drag ↵pinkerton@chromium.org2009-04-292-1/+14
| | | | | | | | out of a window. Review URL: http://codereview.chromium.org/99206 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14898 0039d316-1c4b-4281-b951-d872f2087c98
* Implement dropping of tabs into an existing tab strip from another window. ↵pinkerton@chromium.org2009-04-296-41/+162
| | | | | | | | Implement dragging and dropping of tabs within a window. Review URL: http://codereview.chromium.org/102010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14879 0039d316-1c4b-4281-b951-d872f2087c98
* Adds items to the Window menu on Mac.rohitrao@chromium.org2009-04-291-0/+21
| | | | | | | | | TEST=Open multiple windows, make sure the entries in the Window menu match the titles of the currently selected tabs. Review URL: http://codereview.chromium.org/100121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14841 0039d316-1c4b-4281-b951-d872f2087c98
* Fix mac build break.kuchhal@chromium.org2009-04-281-0/+1
| | | | | | | Review URL: http://codereview.chromium.org/100139 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14801 0039d316-1c4b-4281-b951-d872f2087c98
* Support for tabs reaching a threshold before tearing off (magnetism), ↵pinkerton@chromium.org2009-04-288-86/+264
| | | | | | showing position of where the tab will go in the destination tab strip. Use new close box icon. Don't draw the tab title over the close box. Patch from alcor@google.com git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14758 0039d316-1c4b-4281-b951-d872f2087c98
* Unittest for FindBarBridge.rohitrao@chromium.org2009-04-281-0/+33
| | | | | | | TEST=The new unittest passes. BUG=10802 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14729 0039d316-1c4b-4281-b951-d872f2087c98
* Swap NOTIMPLEMENTED with a bug comment.pinkerton@chromium.org2009-04-281-1/+1
| | | | | | Review URL: http://codereview.chromium.org/99085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14726 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up construction of LocationBarViewMac objects.shess@chromium.org2009-04-273-25/+2
| | | | | | | | | | | This removes the need for SetField() accessors on AutocompleteEditViewMac and AutocompletePopupViewMac, and also removes the Init() wart on LocationBarViewMac. Now everything is wired up in the constructor. Review URL: http://codereview.chromium.org/92136 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14641 0039d316-1c4b-4281-b951-d872f2087c98
* Add a stub test for TabStripController. It doesn't fully work because of issuespinkerton@chromium.org2009-04-272-1/+131
| | | | | | creating WebContents objects. A bug has been filed to come back to it. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14601 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a NOTIMPLEMENTED() that's not necessary on Mac.pinkerton@chromium.org2009-04-271-1/+5
| | | | | | Review URL: http://codereview.chromium.org/97004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14600 0039d316-1c4b-4281-b951-d872f2087c98
* Unittest for FindBarCocoaController.rohitrao@chromium.org2009-04-245-10/+105
| | | | | | | TEST=The new unittest passes. BUG=10802 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14424 0039d316-1c4b-4281-b951-d872f2087c98
* Allow appkit-driven animations in unit tests to work correctly.pinkerton@chromium.org2009-04-232-4/+5
| | | | | | Review URL: http://codereview.chromium.org/95003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14301 0039d316-1c4b-4281-b951-d872f2087c98
* Fix problem with bookmark bar introduced by window sharing; prefjrg@chromium.org2009-04-2316-172/+256
| | | | | | | | | | | | change needs to change all open windows with the same preferences, not just the current one). Improve unit testing. Limit bookmark menu size width (1st pass). Cleanup/delete of code which no longer does much. Review URL: http://codereview.chromium.org/79068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14282 0039d316-1c4b-4281-b951-d872f2087c98
* Fix DIR_SOURCE_ROOT to work in bundles like Chromium.app. Add more ui tests. ↵pinkerton@chromium.org2009-04-226-8/+28
| | | | | | | | Add a resource for tabs with no title on mac. Fix window title reporting. Remove the Browser dependency from the tab strip (only needs a TabStripModel). Review URL: http://codereview.chromium.org/93025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14212 0039d316-1c4b-4281-b951-d872f2087c98
* Unit test for sad tab view.pinkerton@chromium.org2009-04-211-0/+39
| | | | | | Review URL: http://codereview.chromium.org/87028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14099 0039d316-1c4b-4281-b951-d872f2087c98
* Unit tests for button cells we use in the UI.pinkerton@chromium.org2009-04-212-0/+83
| | | | | | Review URL: http://codereview.chromium.org/87023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14098 0039d316-1c4b-4281-b951-d872f2087c98
* Add a bunch of basic unit tests for view classes.pinkerton@chromium.org2009-04-215-0/+200
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14095 0039d316-1c4b-4281-b951-d872f2087c98
* Rename web_contents_view to tab_contents_view to fix the mac build.brettw@chromium.org2009-04-211-1/+1
| | | | | | Review URL: http://codereview.chromium.org/88019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14086 0039d316-1c4b-4281-b951-d872f2087c98
* Test forcing the display of the controller's view.pinkerton@chromium.org2009-04-203-0/+11
| | | | | | Review URL: http://codereview.chromium.org/86002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14047 0039d316-1c4b-4281-b951-d872f2087c98
* Add a unit test for BaseView. Add a helper to get the contentView more easily.pinkerton@chromium.org2009-04-203-1/+60
| | | | | | Review URL: http://codereview.chromium.org/82001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14030 0039d316-1c4b-4281-b951-d872f2087c98
* Initial implementation of the FindBar on Mac.rohitrao@chromium.org2009-04-1712-18/+492
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13969 0039d316-1c4b-4281-b951-d872f2087c98
* Implement a unit test for the toolbar controller. Plumb the profile into the ↵pinkerton@chromium.org2009-04-176-19/+143
| | | | | | | | loation bar instead of picking it up globally, which cannnot be unit tested. Review URL: http://codereview.chromium.org/79041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13959 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-13 04:56:39 +0000