summaryrefslogtreecommitdiffstats
path: root/chrome/browser/cocoa
Commit message (Collapse)AuthorAgeFilesLines
* Take two converting to scoped pointers, without ui_test failures.pinkerton@chromium.org2009-04-104-28/+32
| | | | | | Review URL: http://codereview.chromium.org/67039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13522 0039d316-1c4b-4281-b951-d872f2087c98
* backing out r13504 due to ui_test issuespinkerton@chromium.org2009-04-102-24/+25
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13512 0039d316-1c4b-4281-b951-d872f2087c98
* Fix dtor ordering, browser must destruct last.pinkerton@chromium.org2009-04-101-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13506 0039d316-1c4b-4281-b951-d872f2087c98
* Force c++ dtors to get called in objc interfaces (it was always on since ↵pinkerton@chromium.org2009-04-102-25/+24
| | | | | | | | gcc4.2, but this makes it explicit). Use scoped_* goodness. Review URL: http://codereview.chromium.org/70001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13504 0039d316-1c4b-4281-b951-d872f2087c98
* Re-order the steps used to create the new browser window on a tab drag in ↵pinkerton@chromium.org2009-04-092-7/+9
| | | | | | | | order to make sure the TabContents' delegate doesn't get clobbered. Fix the define of a file that had been moved a while ago. Review URL: http://codereview.chromium.org/67007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13455 0039d316-1c4b-4281-b951-d872f2087c98
* This CL adds a confirmation box when closing the browser with in-progress ↵jcampan@chromium.org2009-04-092-0/+6
| | | | | | | | | | downloads. BUG=1028 TEST=Start several bug downloads, close the browser. A dialog shows up to warn you are about to lose the downloads. Try the wait and continue button. Try again with several windows, and in Incognito mode. Review URL: http://codereview.chromium.org/62131 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13453 0039d316-1c4b-4281-b951-d872f2087c98
* Flatten down to a single toolbar per window, significantly simplifying the ↵pinkerton@chromium.org2009-04-0912-277/+347
| | | | | | | | tab strip as it now no longer needs to forward messages for everything. Created a toolbar controller to encapsulate much of the toolbar logic that was in the tab contents controller. Better parameterized the tab strip controller so that it could switch any view, not just the main window's content view, when switching tabs. Review URL: http://codereview.chromium.org/65011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13441 0039d316-1c4b-4281-b951-d872f2087c98
* Scaffolding cleanup.thestig@chromium.org2009-04-081-0/+2
| | | | | | Review URL: http://codereview.chromium.org/63142 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13394 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor tab model observer for cocoa into a separate class so it can be ↵pinkerton@chromium.org2009-04-086-106/+212
| | | | | | | | re-used. Mark tab as visible when switching to it so tabs loaded in the background work. Review URL: http://codereview.chromium.org/63087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13346 0039d316-1c4b-4281-b951-d872f2087c98
* Move location bar bridge out of tab_contents_controller.shess@chromium.org2009-04-085-75/+146
| | | | | | | | | | [So that I don't keep getting conflicts as I work to finish the omnibox change http://codereview.chromium.org/50074 ] Review URL: http://codereview.chromium.org/63096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13342 0039d316-1c4b-4281-b951-d872f2087c98
* Layout the tabs explicitly when creating a background tab. Update to correct ↵pinkerton@chromium.org2009-04-071-12/+20
| | | | | | | | tab model observer API so we once again get update messages. Review URL: http://codereview.chromium.org/63022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13249 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Initial implemention of Mac Omnibox."shess@chromium.org2009-04-075-234/+73
| | | | | | | | | | Reverts: http://codereview.chromium.org/50074 http://src.chromium.org/viewvc/chrome?view=rev&revision=13201 Review URL: http://codereview.chromium.org/63047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13227 0039d316-1c4b-4281-b951-d872f2087c98
* Initial implemention of Mac Omnibox.shess@chromium.org2009-04-065-73/+234
| | | | | | | | | | | | | | | | AutocompletePopupViewMac implements AutocompletePopupView in terms of a bare NSWindow containing an NSTableView. AutocompleteTableTarget implements an Obj-C class to bridge from appkit callbacks back to the popup view (and from there to the model which contains the data it needs). AutocompleteEditViewMac implements AutocompleteEditView in terms of an NSTextField, which is passed down from a nib owner. It works with the popup view to make sure the popup is positioned correctly. AutocompleteFieldDelegate is an internal Obj-C class to bridge from appkit callbacks back to the edit view (and then the edit model). LocationBarViewMac implements LocationBar for interacting with the rest of the browser, and AutocompleteEditController for managing the edit and popup views. It is mostly placeholder code stolen from the gtk implementation. --- I've tried to implement an amount of code which worked and was useful, but which didn't drag on and on into the future. So no tab to search or hints or anything, sometimes ugly, selection may be funky, etc. Review URL: http://codereview.chromium.org/50074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13201 0039d316-1c4b-4281-b951-d872f2087c98
* Correctly initialize all parts of the tab to unselected when it's created, ↵pinkerton@chromium.org2009-04-061-6/+12
| | | | | | | | keeping it in sync with the member var. Review URL: http://codereview.chromium.org/62074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13192 0039d316-1c4b-4281-b951-d872f2087c98
* Add some hysterisis to tab dragging on Mac.shess@chromium.org2009-04-031-0/+19
| | | | | | | | http://code.google.com/p/chromium/issues/detail?id=9670 Review URL: http://codereview.chromium.org/60072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13104 0039d316-1c4b-4281-b951-d872f2087c98
* Move HTML dialogs out of their own tab contents type. Moved functions to newbrettw@chromium.org2009-04-032-2/+2
| | | | | | | | | | | | | file html_dialog_ui.* Move WebContents view creation into the constructor, which makes a bunch of extra calls to CreateView unnecessary. Remove unused CallJavascriptFunction() functions in DOMUI. Review URL: http://codereview.chromium.org/56065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13065 0039d316-1c4b-4281-b951-d872f2087c98
* Make NTP work by correctly marking the kind of urls we type in. Patch from ↵pinkerton@chromium.org2009-03-301-1/+5
| | | | | | rohitrao@google.com. http://codereview.chromium.org/55058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12810 0039d316-1c4b-4281-b951-d872f2087c98
* Correctly position windows that are detached during a drag, instead of ↵pinkerton@chromium.org2009-03-272-14/+26
| | | | | | | | relying on the default window position in the nib. Stub a little more of WindowSizer, but only enough to get drag working. Default new windows to 1024x768. Review URL: http://codereview.chromium.org/55023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12677 0039d316-1c4b-4281-b951-d872f2087c98
* Forgot a file in last checkin.pinkerton@chromium.org2009-03-271-0/+14
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12657 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up close button in tabs. Patch from rohitrao@google.com.pinkerton@chromium.org2009-03-278-46/+33
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12656 0039d316-1c4b-4281-b951-d872f2087c98
* Don't order the bubble window front; it shows up just fine.avi@google.com2009-03-271-1/+0
| | | | | | | | | Fix by Rohit. http://crbug.com/9422 Review URL: http://codereview.chromium.org/55016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12655 0039d316-1c4b-4281-b951-d872f2087c98
* Fix leaks found by valgrind (which now works on the Mac!)jrg@chromium.org2009-03-273-8/+15
| | | | | | | | http://code.google.com/p/chromium/issues/detail?id=9376 Review URL: http://codereview.chromium.org/53116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12629 0039d316-1c4b-4281-b951-d872f2087c98
* Make the standard tab width wider to better match windows.pinkerton@chromium.org2009-03-261-1/+1
| | | | | | Review URL: http://codereview.chromium.org/42652 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12575 0039d316-1c4b-4281-b951-d872f2087c98
* Remove obsolete TODOs.pinkerton@chromium.org2009-03-261-9/+1
| | | | | | Review URL: http://codereview.chromium.org/49042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12552 0039d316-1c4b-4281-b951-d872f2087c98
* Allow live tabs to be dragged out of a window. Change TabStripModel such thatpinkerton@chromium.org2009-03-265-21/+87
| | | | | | | the caller must now explicitly show the newly created browser rather than it happening automatically. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12550 0039d316-1c4b-4281-b951-d872f2087c98
* Bookmark menu work. Notes:jrg@chromium.org2009-03-2510-56/+294
| | | | | | | | | | | | | - "add bookmark" menu item enable state (e.g. disabled if no windows) - bookmark menus built dynamically (like before) - bookmark menus rebuild when a bookmark is added/removed - bookmark menus take the current browser to where you want to go - works with multiple windows (main window goes to bookmark location) - works with no windows (bookmarks open a new window) Review URL: http://codereview.chromium.org/49005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12501 0039d316-1c4b-4281-b951-d872f2087c98
* Redone http://codereview.chromium.org/42571idanan@chromium.org2009-03-241-0/+2
| | | | | | | | | | | Issue 6477: Support modifier clicks on UI elements Mouse event flags transformed to WindoOpenDisposition so that browser commands can all inteterpert event modifiers. Implemented home, forward and backwards middle-click andshift middle click. Previously working on issue 358 which was market a duplicate and concerned with the home and tabstrip subset of this behavior: Can't open a new tab by middle-clicking home button. No functionality has been lost or altered, only the use ofmodifiers give access to increased functionality. BUG=6477 TBR=maruel Review URL: http://codereview.chromium.org/53020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12403 0039d316-1c4b-4281-b951-d872f2087c98
* Updating TODO list; turns out that the fade is working but too quickly for ↵avi@google.com2009-03-201-1/+0
| | | | | | | | my laptop to show. Review URL: http://codereview.chromium.org/47003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12188 0039d316-1c4b-4281-b951-d872f2087c98
* Rewrite tab layout to a centralized method rather than moving things around ↵pinkerton@chromium.org2009-03-201-61/+74
| | | | | | | | ad hoc in the insert and delete tab methods. Tabs now scale down in size (to a min size) rather than overflowing. Selected tab takes on normal size. Review URL: http://codereview.chromium.org/42411 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12186 0039d316-1c4b-4281-b951-d872f2087c98
* Stage 1 of tab dragging infrastructure, disabled. Put in a base class below ↵pinkerton@chromium.org2009-03-196-21/+368
| | | | | | | | the browser window for windows with tabs to promote re-use in contexts other than just the browser. Add code to the tab view to track drags, but it's disabled as it still needs much work. Review URL: http://codereview.chromium.org/42397 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12125 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing build by initializing all variables; TBR.avi@google.com2009-03-191-0/+6
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12106 0039d316-1c4b-4281-b951-d872f2087c98
* Make the status bubble avoid the mouse.avi@google.com2009-03-192-8/+96
| | | | | | Review URL: http://codereview.chromium.org/42398 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12103 0039d316-1c4b-4281-b951-d872f2087c98
* Fix mac build break.estade@chromium.org2009-03-181-1/+0
| | | | | | | | tbr=avi Review URL: http://codereview.chromium.org/48139 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11988 0039d316-1c4b-4281-b951-d872f2087c98
* Remove BrowserWindow::Init().estade@chromium.org2009-03-182-6/+0
| | | | | | | | This belongs as a private method of BrowserView. Neither mac nor linux uses it. Review URL: http://codereview.chromium.org/42298 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11982 0039d316-1c4b-4281-b951-d872f2087c98
* Mac bookmark work. jrg@chromium.org2009-03-1815-36/+626
| | | | | | | | | | | | | | | | | | | | | - The bookmark menu is populated dynamically with bookmarks, including subfolders --> submenus. E.g. star something --> shows up in menu. Menu items are disabled but always present and current. - Always Show Bookmarks" menu now live; reads from / writes to preference, and shows correct "toggle state". - Bookmark bar on each tab, present if requested. (Currently an empty box). - Random stuff; e.g. bookmark prefs init moved to a x-plat location. This CL does not contain Cole's views. Bried english description of the nib file changes: - add a new view for the bookmark bar in the tab; hook it up to the controller - Many tag sets (e.g. View-->Always Show Bookmarks Bar now 40009) - Remove dummy bookmark menu items Review URL: http://codereview.chromium.org/46078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11936 0039d316-1c4b-4281-b951-d872f2087c98
* First pass at Mac status bubble.avi@google.com2009-03-174-1/+297
| | | | | | Review URL: http://codereview.chromium.org/48070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11895 0039d316-1c4b-4281-b951-d872f2087c98
* Use URLFixerUpper to clean up potential url before going there.shess@chromium.org2009-03-161-1/+7
| | | | | | Review URL: http://codereview.chromium.org/42249 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11784 0039d316-1c4b-4281-b951-d872f2087c98
* Replace a NOTIMPLEMENTED() with a bug.pinkerton@chromium.org2009-03-161-1/+1
| | | | | | Review URL: http://codereview.chromium.org/42241 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11762 0039d316-1c4b-4281-b951-d872f2087c98
* Linux accelerators cleanup:estade@chromium.org2009-03-162-2/+2
| | | | | | | | | | | | | | | | - Give renderer a chance to handle accelerators before browser does. - Handle browser accelerators that aren't attached to any particular UI element in BrowserWindowGtk rather than in BrowserToolbarGtk - Use Browser::ExecuteCommand() to handle accelerator activation - Switch a random void* to gfx::NativeWindow - Enable three browser commands on linux : Focus Location, Focus Search, Open file This fully enables ctrl-l, ctrl-k, and ctrl-o. This fixes copy-pasta in the omnibox. This fixes the problem Dean described with <http://www.quirksmode.org/js/keys.html>. bug=8659 Review URL: http://codereview.chromium.org/42190 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11759 0039d316-1c4b-4281-b951-d872f2087c98
* RSS feed support (part 1), 2nd attempt.finnur@chromium.org2009-03-131-0/+1
| | | | | | | | | | | | | | | | | | | | | Part 1 is RSS feed auto-discovery. This will parse the web page header to find the feeds in the document and notify the browser to display the RSS icon in the toolbar. You can click on the icon, but it will just navigate to the first feed on the page, which (unless it has been designed to be browser friendly) will just dump XML as text on the user. For this reason I have disabled the code that makes the RSS icon appear and intend to enable it when we have a good landing page to display the XML. Review URL: http://codereview.chromium.org/46055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11672 0039d316-1c4b-4281-b951-d872f2087c98
* Adjust the plus button offset to match Windows more.avi@google.com2009-03-131-1/+1
| | | | | | Review URL: http://codereview.chromium.org/46042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11652 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 11640.finnur@chromium.org2009-03-131-1/+0
| | | | | | Reverting for now. Will try again later git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11645 0039d316-1c4b-4281-b951-d872f2087c98
* RSS feed support (part 1)finnur@chromium.org2009-03-131-0/+1
| | | | | | | | | | | | | | | | Part 1 is RSS feed auto-discovery. This will parse the web page header to find the feeds in the document and notify the browser to display the RSS icon in the toolbar. You can click on the icon, but it will just navigate to the first feed on the page, which (unless it has been designed to be browser friendly) will just dump XML as text on the user. For this reason I have disabled the code that makes the RSS icon appear and intend to enable it when we have a good landing page to display the XML. Review URL: http://codereview.chromium.org/43109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11640 0039d316-1c4b-4281-b951-d872f2087c98
* Don't rely on subview ordering to be equivalent to tab ordering. Allows us ↵pinkerton@chromium.org2009-03-123-44/+71
| | | | | | | | to correctly set z-order on tabs. Add animation to tabs closing. Fix issue where new tab button would not draw correctly by pulling it from the nib. Fix memory leak in TabController. Fix console output about missing image. Review URL: http://codereview.chromium.org/43144 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11575 0039d316-1c4b-4281-b951-d872f2087c98
* Add a TabController class to manage a TabView (with corresponding xib). ↵pinkerton@chromium.org2009-03-126-42/+221
| | | | | | | | Rewrite strip controller to create and manage TabControllers instead of NSButtons. Review URL: http://codereview.chromium.org/43137 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11541 0039d316-1c4b-4281-b951-d872f2087c98
* Bring over more code from cole to improve the appearance of tabs. Start ↵pinkerton@chromium.org2009-03-111-106/+132
| | | | | | | | building parts of GTM that are needed for theming. Review URL: http://codereview.chromium.org/42081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11482 0039d316-1c4b-4281-b951-d872f2087c98
* Getting rid of dead code.pinkerton@chromium.org2009-03-111-12/+2
| | | | | | Review URL: http://codereview.chromium.org/43090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11468 0039d316-1c4b-4281-b951-d872f2087c98
* Remove TabContents from scaffolding. Yay!pinkerton@chromium.org2009-03-112-1/+2
| | | | | | Review URL: http://codereview.chromium.org/43039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11435 0039d316-1c4b-4281-b951-d872f2087c98
* NO CODE CHANGEdeanm@chromium.org2009-03-101-2/+0
| | | | | | | | | Normalize end of file newlines in chrome/. All files end in a single newline. Review URL: http://codereview.chromium.org/42015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11331 0039d316-1c4b-4281-b951-d872f2087c98
* NO CODE CHANGE.maruel@google.com2009-03-051-1/+1
| | | | | | | Split the lines >80 cols. (Part 1) Review URL: http://codereview.chromium.org/39206 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11032 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-12 23:31:56 +0000