summaryrefslogtreecommitdiffstats
path: root/chrome/browser/cocoa
Commit message (Collapse)AuthorAgeFilesLines
* Fix contextual menu crash by disabling the contextual menu.avi@chromium.org2010-04-301-10/+11
| | | | | | | | | | BUG=http://crbug.com/42743 TEST=as in bug Review URL: http://codereview.chromium.org/1687025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46099 0039d316-1c4b-4281-b951-d872f2087c98
* Allow authenticated installs from the disk image.mark@chromium.org2010-04-307-142/+355
| | | | | | | | | | | | | | | | | | | | | When launching from a read-only disk image, if no installed copy exists in /Applications, and the user chooses to install from the disk image: If it appears that there isn't permission to write to /Applications, prompt the user to authenticate as an administrator. If authentication is successful, copy the application as root, set its permissions, and promote Keystone to use a system ticket. BUG=40265 TEST=Remove the application from /Applications and test, as both an admin user and a normal user, installation directly from the disk image. When installation occurs after authentication, Chrome should be on a system ticket. Also, make sure that normal in-app Keystone promotion continues to work as expected. Review URL: http://codereview.chromium.org/1792013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46091 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Small change to get the BrowserActionApiTest.IncognitoDragging test ↵kkania@chromium.org2010-04-301-7/+5
| | | | | | | | | | running. BUG=none TEST=none Review URL: http://codereview.chromium.org/1810008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46074 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt 2 at relanding your patch. I believe the problem was the removal of ↵sky@chromium.org2010-04-302-0/+5
| | | | | | | | | | | | the observer in ~TabStrip. By the time TabStrip's destructor was run the model's destructor had already run. I've changed BrowserView to explicitly delete the TabStrip before the browser. See the change between v1 and v2 of this patch in BrowserView for the relevant part. BUG=none TEST=none TBR=ben@chromium.org Review URL: http://codereview.chromium.org/1817001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46071 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 46049 - [Mac] Make exceptions dialog a sheet.bauerb@chromium.org2010-04-306-104/+36
| | | | | | | | | | | | | | | | | | | XIB changes (applying to ContentExceptionsWindow.xib and GeolocationExceptionsWindow.xib): The window is now drawn in Aqua style, with window margins, Aqua buttons and text labels for them. At the bottom right of the window there is an additional button for closing the sheet, hooked up to the |doneButton_| outlet in the file's owner and with action |closeSheet:|. The lefthand side buttons are inside a |GTMWidthBasedTweaker|, as is the done button. The actual tweaking is done by a newly added |GTMUILocalizerAndLayoutTweaker|. BUG=38021 TEST=Preferences > Under the Hood > Content Settings > Exceptions should be a sheet. Review URL: http://codereview.chromium.org/1760001 TBR=bauerb@chromium.org Review URL: http://codereview.chromium.org/1790009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46050 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Make exceptions dialog a sheet.bauerb@chromium.org2010-04-306-36/+104
| | | | | | | | | | | | | | | | XIB changes (applying to ContentExceptionsWindow.xib and GeolocationExceptionsWindow.xib): The window is now drawn in Aqua style, with window margins, Aqua buttons and text labels for them. At the bottom right of the window there is an additional button for closing the sheet, hooked up to the |doneButton_| outlet in the file's owner and with action |closeSheet:|. The lefthand side buttons are inside a |GTMWidthBasedTweaker|, as is the done button. The actual tweaking is done by a newly added |GTMUILocalizerAndLayoutTweaker|. BUG=38021 TEST=Preferences > Under the Hood > Content Settings > Exceptions should be a sheet. Review URL: http://codereview.chromium.org/1760001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46049 0039d316-1c4b-4281-b951-d872f2087c98
* Pasting on a folder now puts the pasted bookmark item in the folder as the ↵mrossetti@chromium.org2010-04-301-12/+13
| | | | | | | | | | | last bookmark within the folder. Bringing up a contextual menu on an open bookmark bar folder no longer closes the folder. BUG=32064 TEST=1) Copy a bookmark item. Using the contextual menu, paste the bookmark item just copied onto the top of a folder in the bookmark bar. Open that folder and verify that the pasted item appears as the last bookmark therein. 2) Copy a bookmark item. Pop open a bookmark bar folder which itself contains a folder. Paste the bookmark item onto the top of that subfolder. Verify that the subfolder now contains the pasted bookmark item as its last bookmark. 3) Pop open a bookmark folder. Bring up the contextual menu on that folder. Verify that the folder window is not automatically closed when the contextual menu is presented. Review URL: http://codereview.chromium.org/1732029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46032 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: add encoding meta-tag to HTML provided with NSHTMLPboardType.viettrungluu@chromium.org2010-04-301-1/+8
| | | | | | | | | | | Otherwise, US-ASCII is assumed. BUG=42661 TEST=dragging text from, e.g., Chinese-language web sites into TextEdit works Review URL: http://codereview.chromium.org/1820001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46029 0039d316-1c4b-4281-b951-d872f2087c98
* Remove accidental #if's. Make old folder window menu go away when mousing ↵mrossetti@chromium.org2010-04-292-15/+4
| | | | | | | | | | | over a non-folder bookmark in the bookmark bar. BUG=None. TEST=Pop up a folder bookmark item on the bookmark bar then mouse over a non-folder bookmark and verify that the old folder menu is dismissed. Review URL: http://codereview.chromium.org/1752020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45991 0039d316-1c4b-4281-b951-d872f2087c98
* Changing linux platform for chromeos. This involved moving platform_util ↵dhg@chromium.org2010-04-291-1/+1
| | | | | | | | | | and extension_error_reporter to browser, so that the UIs surrounding them can be in the browser. BUG=none TEST=none Review URL: http://codereview.chromium.org/1705009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45986 0039d316-1c4b-4281-b951-d872f2087c98
* Fix dragging a tab out of a window when the only tabs left behind are ↵pinkerton@chromium.org2010-04-294-2/+19
| | | | | | | | | | phantom tabs. BUG=42698 TEST=per bug. Might want to re-test dragging single tabs and dragging tabs out when there are pinned tabs (not phantoms). Review URL: http://codereview.chromium.org/1727013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45982 0039d316-1c4b-4281-b951-d872f2087c98
* Add and implement cut/copy/paste to the bookmark bar and folder context ↵mrossetti@chromium.org2010-04-2912-184/+1501
| | | | | | | | | | | | | | | | | | | | | | | | | | | menus.Prevent dropping bookmark folders onto their children to avoid creating cycles and crashing. Keep folder menu windows open after a cut/copy/paste/delete and drop operation. Add test helpers for easing comparison of bookmark model changes. BUG=41217,36614,32064, 41404 Add and implement cut/copy/paste to the bookmark bar and folder context menus.Prevent dropping bookmark folders onto their children to avoid creating cycles and crashing. Keep folder menu windows open after a cut/copy/paste/delete and drop operation. TEST=1) Present the context menu for the bookmark bar in various places and insure that the cut/copy/paste menu items are shown and properly enabled or disabled. 2) Present the context menu for a folder menu in various places and insure that the cut/copy/paste menu items are shown and properly enabled or disabled. 3) Perform cut/copy/paste/delete operations in a folder menu and subfolder menu and verify that the menu remains presented after the operation completes. 4) Drag a bookmark item from the bar to another location on the bar and verify that the button no longer shows up in the old location but does show up in the new location. 5) Drag a bookmark item from the bar to be within a folder located _after_ the item being dragged. Verify the bar no longer shows the bookmark item. Verify the folder does show the bookmark item. Verify that the folder window has shifted to the left so that it remains aligned with it corresponding bar folder indicator. 6) Drag a bookmark item from the bar to be within a folder located _before_ the item being dragged. Verify the bar no longer shows the bookmark item. Verify the folder does show the bookmark item. Verify that the folder window has _not_ shifted to the left and that it remains aligned with it corresponding bar folder indicator. 7) Drag a bookmark around within the same folder and verify that the folder window does not move. 8) Drag a bookmark item from a folder to the bar in a position _after_ the folder form which the item comes. The folder menu window should close. 9) Drag a bookmark item from a folder to a different folder and verify that the original folder closes and the new folder remains open. 10) Drag an item from a parent folder to a child folder and verify that both folders remain open. Verify that the subfolder remains aligned to its associated folder icon in the parent folder. 11) Drag an item from a child folder to a parent folder. Verify that the child folder closes and the parent folder remains open. 12) Try dragging a parent folder onto a child folder and verify that the drag is not allowed to complete. 13) Hover over a folder item in a folder menu window. Verify that the folder opens up a subview menu window. Now drag the original folder (the one being hovered over) and verify that its subfolder menu automatically closes. 14) Slowly shrink window width until "off the side" menu appears; make sure it appears as soon as the last button gets removed. Now slowly grow window and make sure it goes away at the right time. 15) Add enough bookmarks to the bookmark bar to nearly fill the width of the window. Verify that the off-the-side chevron is not showing. Slowly shrink the width of the window until the off-the-side-chevron appears. Verify that the right-most bookmark button has disappeared and does not draw over the top of the chevron. Continue to shrink the window and verify that bookmark buttons disappear. View the contents of the chevron and verify that the bookmark buttons which previously appeared on the bar now appear in the chevron. Slowly grow the window and verify that bookmark buttons reappear without drawing over the top of the chevron. Verify that those bookmark buttons no longer appear in the chevron when it is popped up. Continue growing the window until all bookmark buttons appear in the bar and the chevron disappears. 16) Shrink the window so that the off-the-side chevron appears and contains three or more bookmarks. Pop open the chevron. Drag bookmarks up and down in the chevron menu and verify that moves and copies are performed. Drag a bar bookmark into the chevron and verify that the chevron pops up and allows the drag. Verify that the bar and chevron contents rearrange such that buttons on the bar fill but do not overflow the bar. Drag a chevron bookmark out onto the bar. Once again verify that the bar and chevron buttons rearrange such that the bar is full but not overflowing. Review URL: http://codereview.chromium.org/1742003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45965 0039d316-1c4b-4281-b951-d872f2087c98
* Enable mouse enter/exit events for the content area on Macstuartmorgan@chromium.org2010-04-292-0/+34
| | | | | | | | | | | Fixes mouse-exit events for plugins touching the edge of the content area; likely also fixes similar bugs in HTML. BUG=33100 TEST=Plugins should receive mouse exit events on edges touching the content area edge. Review URL: http://codereview.chromium.org/1774014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45962 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some more BookmarkEditor::Handlers (in Mac code this time).viettrungluu@chromium.org2010-04-2910-68/+32
| | | | | | | | | | | (Continuing aftermath of native bookmark manager removal....) BUG=38908 TEST=everything continues to work Review URL: http://codereview.chromium.org/1747020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45917 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 45906 - Relands your patch to have an option for enabling vertical ↵sky@chromium.org2010-04-292-5/+0
| | | | | | | | | | | | | | | | | | tabs. I've added the following additions: . made the layout work for opaque_browser_frame. . Only show the menu if the user supplied enableverticaltabs. BUG=none TEST=none Review URL: http://codereview.chromium.org/1708014 TBR=sky@chromium.org Review URL: http://codereview.chromium.org/1795010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45915 0039d316-1c4b-4281-b951-d872f2087c98
* Change report bad webpage to be a web tab instead of native dialogfeldstein@chromium.org2010-04-291-5/+1
| | | | | | | | | | | | Change all 3 implementations of the report broken page dialog to just use one web form. BUG=none TEST=Make sure you can report bad pages on each platform Review URL: http://codereview.chromium.org/1737016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45908 0039d316-1c4b-4281-b951-d872f2087c98
* Relands your patch to have an option for enabling vertical tabs. I'vesky@chromium.org2010-04-292-0/+5
| | | | | | | | | | | | | added the following additions: . made the layout work for opaque_browser_frame. . Only show the menu if the user supplied --enable-vertical-tabs. BUG=none TEST=none Review URL: http://codereview.chromium.org/1708014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45906 0039d316-1c4b-4281-b951-d872f2087c98
* Nukes one of the AddTabWithURL variants.sky@chromium.org2010-04-291-2/+3
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1736022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45902 0039d316-1c4b-4281-b951-d872f2087c98
* Mac BookmarkBubbleController updateBookmarkNode crash.dhollowa@chromium.org2010-04-281-0/+5
| | | | | | | | | | | | | | | | It is possible that due to model change the bookmark bubble window has been closed but the popup is still showing and able to notify the controller of a folder change. We ignore the sender in this case. A better fix would be to close the popup programatically, but this is not a cocoa-friendly thing to do. I recommend this fix for M5, and for M6 we revisit to close the popup. BUG=41257, 42766 TEST=Manual testing according to but report. Requires two machines. Will only crash under 10.6. Review URL: http://codereview.chromium.org/1739015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45847 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of BookmarkEditor::Show()'s BookmarkEditor::Handler argument.viettrungluu@chromium.org2010-04-282-8/+6
| | | | | | | | | | | | Still to do: get rid of things which hang on to a handler just so they can pass it to Show(). BUG=38908 TEST=everything still works Review URL: http://codereview.chromium.org/1795007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45813 0039d316-1c4b-4281-b951-d872f2087c98
* Mac Bookmarks hover unit tests leak.dhollowa@chromium.org2010-04-281-2/+2
| | | | | | | | | | | Removes extra retains in unit tests that are now unneeded. Triggered valgrind report. BUG=42051 TEST=BookmarkBarFolderHoverStateTest.HoverState Review URL: http://codereview.chromium.org/1756016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45779 0039d316-1c4b-4281-b951-d872f2087c98
* Windows/Views: delete native bookmark manager code.viettrungluu@chromium.org2010-04-282-6/+0
| | | | | | | | | | | | Context menu code still needs cleanup/refactoring. String resources still need to be deleted. BUG=38908 TEST=everything still works Review URL: http://codereview.chromium.org/1730015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45776 0039d316-1c4b-4281-b951-d872f2087c98
* Crash: Moving bookmarks into subfolder in incognito windowdhollowa@chromium.org2010-04-272-3/+4
| | | | | | | | | | | | Fixes issue with bookmark hover where button target is dealloc'd without properly cancelling delayed hover button open. BUG=42051 TEST=Manual according to steps in bug. Review URL: http://codereview.chromium.org/1706017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45740 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Remove ToolbarButtonCell (and associated files).viettrungluu@chromium.org2010-04-274-42/+1
| | | | | | | | | | | | | | .xib changes: change all ToolbarButtonCells to GradientButtonCells. (Previously committed at r45698, reverted at r45703. I don't know why the local build and the try succeeded. This time, I fixed the slightly-broken include.) BUG=42582 TEST=builds properly *and* toolbar buttons and find bar buttons still work as before Review URL: http://codereview.chromium.org/1762012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45714 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 45698 - Mac: Remove ToolbarButtonCell (and associated files).avi@chromium.org2010-04-273-0/+41
| | | | | | | | | | | | | | .xib changes: change all ToolbarButtonCells to GradientButtonCells. BUG=42582 TEST=toolbar buttons and find bar buttons still work as before Review URL: http://codereview.chromium.org/1697011 TBR=viettrungluu@chromium.org Review URL: http://codereview.chromium.org/1695020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45703 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Remove ToolbarButtonCell (and associated files).viettrungluu@chromium.org2010-04-273-41/+0
| | | | | | | | | | | .xib changes: change all ToolbarButtonCells to GradientButtonCells. BUG=42582 TEST=toolbar buttons and find bar buttons still work as before Review URL: http://codereview.chromium.org/1697011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45698 0039d316-1c4b-4281-b951-d872f2087c98
* Use the native Mac localization bundle utility functions.avi@chromium.org2010-04-272-5/+3
| | | | | | | | | BUG=none TEST=no change Review URL: http://codereview.chromium.org/1791004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45694 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Brand code support on the Mac:thomasvl@chromium.org2010-04-273-8/+202
| | | | | | | | | | | | | - During keystone registration pull in the brand file at user to system level. - Clean up old user level brand files after moving to a system ticket. - During keystone ticket promotion, use the pref flight script to copy the brand information out to the system level. - When updating check to see if the user had manually updated the app and gotten a new brand code, if so, migrate that code into the right location. BUG=39131 TEST=email from tvl to QA with details. Review URL: http://codereview.chromium.org/1687012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45687 0039d316-1c4b-4281-b951-d872f2087c98
* Put an "(empty)" into the submenus of empty folders in the bookmark menu, to ↵avi@chromium.org2010-04-261-3/+10
| | | | | | | | | | | match the same in the non-menubar menus. BUG=http://crbug.com/41768 TEST=as in bug Review URL: http://codereview.chromium.org/1718016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45615 0039d316-1c4b-4281-b951-d872f2087c98
* Declare TranslateInfobarController as implementing NSMenuDelegate, requiredmark@chromium.org2010-04-261-2/+3
| | | | | | | | | | for the 10.6 SDK build after r45553. BUG=none TEST=none Review URL: http://codereview.chromium.org/1733018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45587 0039d316-1c4b-4281-b951-d872f2087c98
* Changes the tab menu to use pin and unpin instead of a check. The macsky@chromium.org2010-04-261-16/+5
| | | | | | | | | | | changes to use the right thing (pinned vs mini) will be done separately. BUG=none TEST=none Review URL: http://codereview.chromium.org/1725006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45581 0039d316-1c4b-4281-b951-d872f2087c98
* Remove empty nodes when deleting cookies.jochen@chromium.org2010-04-261-8/+3
| | | | | | | | | BUG=39389 TEST=none Review URL: http://codereview.chromium.org/1751013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45575 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Fix use-after-free in translate infobar options menu.jeremy@chromium.org2010-04-251-6/+14
| | | | | | | | | | | | | | | The "About Translate" command opens a new tab which closes the infobar, we where trying to update the options menu which acccessed an already released object. The fix is to match Windows behavior and only rebuild the options menu when clicked. Thanks to Rohit for diagnosing the problem! BUG=42030 TEST=repro in bug description. Review URL: http://codereview.chromium.org/1756006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45553 0039d316-1c4b-4281-b951-d872f2087c98
* Mac cleanup: get rid of probably-stale TODOs.viettrungluu@chromium.org2010-04-251-4/+0
| | | | | | | | | | | | See comments at <http://codereview.chromium.org/1737013>. TBR=jrg@chromium.org BUG=none TEST=none Review URL: http://codereview.chromium.org/1726007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45545 0039d316-1c4b-4281-b951-d872f2087c98
* Mac cleanup: remove a TODO and add ToolbarControllerTest.NoLocationBar ↵viettrungluu@chromium.org2010-04-242-4/+18
| | | | | | | | | | | (another TODO). BUG=none TEST=ToolbarControllerTest.NoLocationBar passes Review URL: http://codereview.chromium.org/1737013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45543 0039d316-1c4b-4281-b951-d872f2087c98
* Mac cleanup: Put consts and enums in info_bubble_view.h in a namespace.viettrungluu@chromium.org2010-04-2412-58/+66
| | | | | | | | | BUG=none TEST=everything still builds Review URL: http://codereview.chromium.org/1787001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45541 0039d316-1c4b-4281-b951-d872f2087c98
* Minor style fixes.viettrungluu@chromium.org2010-04-242-5/+6
| | | | | | | | | | TBR=feldstein BUG=none TEST=none Review URL: http://codereview.chromium.org/1712012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45531 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Fix issue 19421: IMEs do not work well in the omnibox due to a race ↵suzhe@chromium.org2010-04-243-14/+68
| | | | | | | | | | | | | | | | condition This CL makes following major changes: 1. Exclude marked text from GetText()'s result. 2. When the text field is in editing mode, EmphasizeURLComponents() changes its attributes through its editor rather than reseting its content. 3. When the text field is in editing mode, SetText() sets its content through its editor. BUG=19421 TEST=See bug report. Review URL: http://codereview.chromium.org/1549033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45524 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Update location-bar icon as user types.shess@chromium.org2010-04-231-0/+3
| | | | | | | | | | | | | | | | | | | Update in |OnChanged()|, just like Windows. NOTE: This CL requires the following change else it breaks the build: http://src.chromium.org/viewvc/chrome?view=rev&revision=44775 [Didn't think to put this note on that change, sorry.] BUG=41362 TEST=Type "www.google.com". You should have a globe icon. TEST=Add a space after first 'w'. Should get search icon. TEST=Generally, icon will switch around as you type. Originally committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=44572 Review URL: http://codereview.chromium.org/1640012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45500 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Slomo for download shelf/info bars.thakis@chromium.org2010-04-231-1/+1
| | | | | | | | | BUG=41393 TEST=shift-click close button in download shelf/info bars. Animation should slow down. Review URL: http://codereview.chromium.org/1719015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45482 0039d316-1c4b-4281-b951-d872f2087c98
* Re-instate the temporary revert from r45267. That reverted certainshess@chromium.org2010-04-2319-577/+938
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Omnibox, toolbar, tab animations, and other UI changes for purposes of testing and merging into mstone-5. Additionally reverts these CLs to fix the earlier revert: r45271: [Mac] Image references missing from Omnibox revert. r45268: GTK fix merge failure in uber-revert. Additional revert which fixed a bug for the branch: r45381: [Mac] Omnibox popup icons and text lined up under toolbar. Slight merge conflict which should be good: r45322: GTK: Implement OnDragCanceled() for autocomplete... Also ++kThemePackVersion and regenerate the cached theme pak. Re-instated changes: r45213: GTK: Override cursor colors in chrome-theme mode. r45103: Support drawing nano tabs in the tabstrip. r45084: GTK: Position the EV certificate stuff inside a green bubble. r44979: Subclassing the InfoBubble to handle anchoring bubbles basedon... r44957: GTK: Tint the geolocation icons in gtk mode. r44943: Changes FormatURL to not strip http if the host starts with ft... r44930: Remove an icon that is no longer used. r44929: SSL UI changes, Windows, code side (images are separate). r44859: SSL UI changes (icons). TBRed since trybots hate binary patches. r44822: GTK: Select better greens in the native omnibox popup. r44814: GTK: navigate to URL on PRIMARY when middle-clicking the locat... r44789: [Mac] Bookmark star missing on NTP and BMM. r44775: [Mac] Centralize hack to make tests work with AutocompleteClas... r44678: Display the SECURITY_WARNING status in the location bar for the r44648: [Mac] Add an arrow cursor rect for the location image. r44615: Revert r44611 because it may have broken "unit_tests" on "Vist... r44611: Display the SECURITY_WARNING status in the location bar for the r44577: Revert 44572 - [Mac] Update locationbar icon as user types. r44572: [Mac] Update location-bar icon as user types. r44555: GTK: Use correct button mask on reload button. r44545: [Mac] Omnibox text drag drag URL when select-all. r44523: GTK: Prevent inappropriate drag of location bar location icon. r44519: GTK: make the primary selection include the url's scheme when ... r44492: [Mac] Fix search icon in keyword search to be right-side-up. r44415: GTK: Update top padding on icons in the autocomplete popup. r44401: GTK: Tint omnibox icons in GTK mode differently. r44380: GTK: Move reload in gtk mode and fix omnibox popup location. r44282: Fixes crash in autocomplete when typing some URLs. The problem r44273: [Mac] PDF icons for omnibox nits. r44269: Fix build break due to bad merge resolve r44268: Shift omnibox dropdown in and up on Windows, and square off th... r44178: GTK: fix TTS padding. r44177: Round the top left and right edges of the toolbar. r44171: Images only checkin for try server goodness. r44163: GTK: fix padding of autocomplete popup. r44152: [Mac] PDF icons for omnibox. r44145: GTK: Theme the icons in the location bar and use GTK colors fo... r44140: Strips http from the omnibox r44131: Fixes bugs in new tab strip animations where they weren't doin... r44116: Change the default theme colors. r44117: Add newline to EOF to fix CrOS builder. r44115: Make the bottom edges of the opaque frame rounded. r44091: [Mac] No star icon or page actions in omnibox on popups. r44087: Don't allow drag or click on location icon when editing in omn... r44021: [GTK] Add TTS lens graphic to linux TTS box. r44008: [Mac] Tweak location icon spacing in omnibox. r43977: GTK: don't show the star or page actions in ShouldOnlyShowLoca... r43972: Make the firstrun bubble point at a better spot now that the l... r43971: [Mac] Location icon in omnibox as drag source. r43970: Make the star and page action icons not appear on popup windows. r43954: Fixes bug in TabStrip where dragging tab out then back in rapidly r43864: Tweaks to BoundsAnimator/SlideAnimation and TabStrip: r43787: Allow location icon to be dragged & dropped. This also fixes ... r43759: Changes end cap of tab-to-search images. r43740: Change bookmark bar toggle to ctrl-shift-b. r43723: Show Page Info dialog on mouse up, not mouse down. r43677: Fix Mac build failure. r43676: Replace omnibox icons with new set that are all the same size ... r43596: Fix browser test TestStarButtonAccObj. r43593: Disables TestStarButtonAccObj. r43582: Changes tab strip to use BoundsAnimator for tab strip animatio... r43563: GTK: don't show reload button for popup/app windows. r43562: Star/reload shuffle, Windows version. r43540: [Mac] Magnifying glass in keyword-search bubble. r43482: Adds images needed for new tab animation. I'm separating this ... r43422: Add reload mask resource. r43392: GTK: make the location icon a drag source. r43376: [Mac] Move star button into page-actions area of omnibox. r43357: [Mac] Line up omnibox popup under field. r43290: gtk: fix display of icons in omnibox popup r43269: GTK: fix reload button. r43249: [Mac] Rearrange SSL status icon/label in omnibox. r43248: BrowserThemePack: Adds persistant ids for the reload endcaps. r43241: GTK: more location bar updates. r43191: Fix memory leak in BrowserThemePack. r43154: GTK: set the new star button's ID r43151: Fix bad conflict resolution for r43146. r43146: GTK: toolbar reload/star shuffle. r43025: Show the location bar icon (almost) all the time, and have its... r43023: Add new images for new reload button. No code change. r42782: Remove this icon, now that it's no longer used (due to my secu... r42502: Omnibox M5 work, part 1: Security changes r42245: Check in new icons for omnibox security changes alone, so that... BUG=none TEST=People go back to complaining about missing http://. R=pkasting@chromium.org,beng@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45474 0039d316-1c4b-4281-b951-d872f2087c98
* Delete native Mac bookmark manager. Remove --disable-tabbed-bookmark-manager ↵viettrungluu@chromium.org2010-04-2311-2965/+2
| | | | | | | | | | | | | (everywhere). Still to do: delete native bookmark managers on other platforms. BUG=38908 TEST=Everything else still works. Review URL: http://codereview.chromium.org/1751011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45462 0039d316-1c4b-4281-b951-d872f2087c98
* Mac BookmarkBarFolderController side scrolling disabled.dhollowa@chromium.org2010-04-231-2/+11
| | | | | | | | | | | Fixes a small cosmetic bug where mousing down over an open BookmarkBarFolder's contents caused subtle side scrolling. BUG=none TEST=On Mac, (1) click on bookmark bar folder, (2) drag a bookmark to the left or right edge of the open folder's menu, (3) notice that subtle side scrolling happens as you get close to the edge. Expect: no side scrolling. Review URL: http://codereview.chromium.org/1756010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45444 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to fix Mac buildpkasting@chromium.org2010-04-231-1/+1
| | | | | | | | BUG=41466 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45407 0039d316-1c4b-4281-b951-d872f2087c98
* Don't select all when autofocusing the location bar on New Tab creation. ↵pkasting@chromium.org2010-04-238-15/+14
| | | | | | | | | | Users could already be typing in the omnibox before the load commits (e.g. due to a slow renderer process startup) and this typing would then be selected and overwritten. BUG=41466 TEST=On a very slow machine, typing before a new tab finishes loading should not be selected or cleared once the tab finishes loading. Review URL: http://codereview.chromium.org/1738004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45406 0039d316-1c4b-4281-b951-d872f2087c98
* Possible fix / workaround for issue where infobar fails to showjoth@chromium.org2010-04-221-1/+2
| | | | | | | | | BUG=41712 TEST=as per bug comment 8 http://crbug.com/41712#c8 Review URL: http://codereview.chromium.org/1679002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45295 0039d316-1c4b-4281-b951-d872f2087c98
* Bookmark Hover: Introduced an over-delete with attempt at timer safety.dhollowa@chromium.org2010-04-222-7/+0
| | | | | | | | | | | Removing redundant timer supspension. This was causing an over delete when dragging to parent folder. BUG=40006 TEST=BookmarkBarFolderControllerTest.HoverState Review URL: http://codereview.chromium.org/1766003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45279 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily revert certain Omnibox, toolbar, tab animations, and othershess@chromium.org2010-04-2219-939/+578
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | UI changes for purposes of testing and merging into mstone-5. Also ++kThemePackVersion and regenerate the cached theme pak. Reverted changes: r45213: GTK: Override cursor colors in chrome-theme mode. r45103: Support drawing nano tabs in the tabstrip. r45084: GTK: Position the EV certificate stuff inside a green bubble. r44979: Subclassing the InfoBubble to handle anchoring bubbles basedon... r44957: GTK: Tint the geolocation icons in gtk mode. r44943: Changes FormatURL to not strip http if the host starts with ft... r44930: Remove an icon that is no longer used. r44929: SSL UI changes, Windows, code side (images are separate). r44859: SSL UI changes (icons). TBRed since trybots hate binary patches. r44822: GTK: Select better greens in the native omnibox popup. r44814: GTK: navigate to URL on PRIMARY when middle-clicking the locat... r44789: [Mac] Bookmark star missing on NTP and BMM. r44775: [Mac] Centralize hack to make tests work with AutocompleteClas... r44678: Display the SECURITY_WARNING status in the location bar for the r44648: [Mac] Add an arrow cursor rect for the location image. r44615: Revert r44611 because it may have broken "unit_tests" on "Vist... r44611: Display the SECURITY_WARNING status in the location bar for the r44577: Revert 44572 - [Mac] Update locationbar icon as user types. r44572: [Mac] Update location-bar icon as user types. r44555: GTK: Use correct button mask on reload button. r44545: [Mac] Omnibox text drag drag URL when select-all. r44523: GTK: Prevent inappropriate drag of location bar location icon. r44519: GTK: make the primary selection include the url's scheme when ... r44492: [Mac] Fix search icon in keyword search to be right-side-up. r44415: GTK: Update top padding on icons in the autocomplete popup. r44401: GTK: Tint omnibox icons in GTK mode differently. r44380: GTK: Move reload in gtk mode and fix omnibox popup location. r44282: Fixes crash in autocomplete when typing some URLs. The problem r44273: [Mac] PDF icons for omnibox nits. r44269: Fix build break due to bad merge resolve r44268: Shift omnibox dropdown in and up on Windows, and square off th... r44178: GTK: fix TTS padding. r44177: Round the top left and right edges of the toolbar. r44171: Images only checkin for try server goodness. r44163: GTK: fix padding of autocomplete popup. r44152: [Mac] PDF icons for omnibox. r44145: GTK: Theme the icons in the location bar and use GTK colors fo... r44140: Strips http from the omnibox r44131: Fixes bugs in new tab strip animations where they weren't doin... r44116: Change the default theme colors. r44117: Add newline to EOF to fix CrOS builder. r44115: Make the bottom edges of the opaque frame rounded. r44091: [Mac] No star icon or page actions in omnibox on popups. r44087: Don't allow drag or click on location icon when editing in omn... r44021: [GTK] Add TTS lens graphic to linux TTS box. r44008: [Mac] Tweak location icon spacing in omnibox. r43977: GTK: don't show the star or page actions in ShouldOnlyShowLoca... r43972: Make the firstrun bubble point at a better spot now that the l... r43971: [Mac] Location icon in omnibox as drag source. r43970: Make the star and page action icons not appear on popup windows. r43954: Fixes bug in TabStrip where dragging tab out then back in rapidly r43864: Tweaks to BoundsAnimator/SlideAnimation and TabStrip: r43787: Allow location icon to be dragged & dropped. This also fixes ... r43759: Changes end cap of tab-to-search images. r43740: Change bookmark bar toggle to ctrl-shift-b. r43723: Show Page Info dialog on mouse up, not mouse down. r43677: Fix Mac build failure. r43676: Replace omnibox icons with new set that are all the same size ... r43596: Fix browser test TestStarButtonAccObj. r43593: Disables TestStarButtonAccObj. r43582: Changes tab strip to use BoundsAnimator for tab strip animatio... r43563: GTK: don't show reload button for popup/app windows. r43562: Star/reload shuffle, Windows version. r43540: [Mac] Magnifying glass in keyword-search bubble. r43482: Adds images needed for new tab animation. I'm separating this ... r43422: Add reload mask resource. r43392: GTK: make the location icon a drag source. r43376: [Mac] Move star button into page-actions area of omnibox. r43357: [Mac] Line up omnibox popup under field. r43290: gtk: fix display of icons in omnibox popup r43269: GTK: fix reload button. r43249: [Mac] Rearrange SSL status icon/label in omnibox. r43248: BrowserThemePack: Adds persistant ids for the reload endcaps. r43241: GTK: more location bar updates. r43191: Fix memory leak in BrowserThemePack. r43154: GTK: set the new star button's ID r43151: Fix bad conflict resolution for r43146. r43146: GTK: toolbar reload/star shuffle. r43025: Show the location bar icon (almost) all the time, and have its... r43023: Add new images for new reload button. No code change. r42782: Remove this icon, now that it's no longer used (due to my secu... r42502: Omnibox M5 work, part 1: Security changes r42245: Check in new icons for omnibox security changes alone, so that... BUG=none TEST=Eyjafjallajokull R=pkasting@chromium.org,beng@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45267 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug whereby an installed page action bubble points not at the page ↵mirandac@chromium.org2010-04-211-2/+5
| | | | | | | | | | action icon. BUG= 41374 TEST= install a page action extension. "installed bubble" points at the icon that was installed. it should work for multiple icons. Review URL: http://codereview.chromium.org/1762001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45228 0039d316-1c4b-4281-b951-d872f2087c98
* Put a button to link to proxy setup into the prefs dialog.avi@chromium.org2010-04-212-0/+23
| | | | | | | | | | | nib changes: Added two static strings, button. BUG=http://crbug.com/22009 TEST=as in bug Review URL: http://codereview.chromium.org/1759001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45227 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-02 06:15:43 +0000