summaryrefslogtreecommitdiffstats
path: root/chrome/browser/cocoa
Commit message (Collapse)AuthorAgeFilesLines
* block sad tab controller unittest that have leakages for now.kuan@chromium.org2009-12-161-0/+4
| | | | | | | BUG=27212 Review URL: http://codereview.chromium.org/500035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34628 0039d316-1c4b-4281-b951-d872f2087c98
* Support custom Linux version strings (e.g. release channel, downstream ↵mmoss@google.com2009-12-151-2/+2
| | | | | | | | | | | vendor name, etc.). Also reformat the Mac/Win version strings as per comments in http://codereview.chromium.org/506007. Review URL: http://codereview.chromium.org/506016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34609 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Fix a very silly leak in FindBarViewTest.rohitrao@chromium.org2009-12-151-6/+6
| | | | | | | | BUG=http://crbug.com/30391 TEST=Valgrind passes. Review URL: http://codereview.chromium.org/507012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34599 0039d316-1c4b-4281-b951-d872f2087c98
* mac: totally revamp "Aw Snap" page, implement new "Learn more" link, add ↵kuan@chromium.org2009-12-156-63/+318
| | | | | | | | | | | | | | | | | | | | unittests. - totally revamp "Aw Snap" page to use xib resource, to reduce initialization code - new SadTabController: - controls SadTabView, via xib - uses TabContents in init, so as to launch url for link; used to use BrowserList::GetLastActive but that's null in chrome-frame release - if TabContents is nil, remove link in view - encapsulates the setting up and removing of its SadTabView within and shield them from TabContentsView, which only access the controller - SadTabView repositions and resizes subviews when browser window is resized, including (un)wrapping of message. - action for link is decoupled from target to facilitate unittesting - new SadTabControllerTest that tests initing controller with and without TabContents, and clicking on link BUG=27212 TEST=Verify that "Aw Snap" page shows up correctly, with the new "Learn more" link centered beneath the message. Contents should be centered in window when the latter resizes. If necessary, message should be wrapped, or unwrapped if previously wrapped and new width can accommodate. Review URL: http://codereview.chromium.org/432015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34585 0039d316-1c4b-4281-b951-d872f2087c98
* Move channel (beta,dev,stable) determination code to a common location.jrg@chromium.org2009-12-151-9/+9
| | | | | | | | | | | | | | | | | | | | Add channel info to about:version. Linux about box work not done. Linux channel determination code still a stub. BUG=30444 How to verify: - on both Mac and Win, with a branded build: - confirm the About Box and about:version have channel info after the version number. Channel for PC comes from the registry so it'll be the channel of your official install, not this build. Channel for Mac comes from the Info.plist so it WILL be from the current version; stable if undefined. Review URL: http://codereview.chromium.org/506007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34583 0039d316-1c4b-4281-b951-d872f2087c98
* Make a shared app menu model and update win and mac to use it. Remove the ↵pinkerton@chromium.org2009-12-152-7/+17
| | | | | | | | | | NSMenu from Toolbar.xib. BUG=22646 TEST=the app menu works as it used to. Review URL: http://codereview.chromium.org/482006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34561 0039d316-1c4b-4281-b951-d872f2087c98
* Commit issue 464079 for feldstein: limit the clear browsing data window to ↵mirandac@chromium.org2009-12-155-15/+67
| | | | | | | | | | only pop up once. BUG= 24980 TEST= see http://codereview.chromium.org/464079/show Review URL: http://codereview.chromium.org/501001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34557 0039d316-1c4b-4281-b951-d872f2087c98
* Committing issue 484006 for feldstein.mirandac@chromium.org2009-12-157-90/+103
| | | | | | | | | | | Refactor close button to its own class. BUG= 23641 TEST= see http://codereview.chromium.org/484006 Review URL: http://codereview.chromium.org/501003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34556 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Close the font panel when closing the font settings sheet.rsesek@chromium.org2009-12-151-0/+2
| | | | | | | BUG=29885 TEST=Chromium-->Preferences-->Under the Hood-->Change font and language settings. Open a font panel by pressing Change then close the settings sheet by pressing Cancel. Font panel should not remain open. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34527 0039d316-1c4b-4281-b951-d872f2087c98
* First steps toward page actions on Mac. Page action icons shold show andpamg@google.com2009-12-147-67/+551
| | | | | | | | | | | | | | | | | | | | | perform their click actions when clicked. This is very rough, being committed in an early form so more people can contribute to the effort. Includes some early work from andybons too, toward making popups work. Known issues: * Icons don't refresh properly when an extension is installed or removed. Switching windows, then back again, updates the location bar properly. * Right- and middle-clicks do nothing * No tooltips, badges, installation previews, or popups yet * No unit tests yet BUG=12281 TEST=none yet Review URL: http://codereview.chromium.org/427009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34509 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor browser action apitest and port for mac.kkania@chromium.org2009-12-146-0/+20
| | | | | | | | BUG=29709 TEST=none Review URL: http://codereview.chromium.org/443013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34498 0039d316-1c4b-4281-b951-d872f2087c98
* Disable "open in incognito window" for incognito windows.avi@chromium.org2009-12-141-0/+8
| | | | | | | | | BUG=http://crbug.com/24637 TEST=as in bug Review URL: http://codereview.chromium.org/488018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34496 0039d316-1c4b-4281-b951-d872f2087c98
* Try 2: Completely redo how themes are stored on disk and processed at ↵erg@google.com2009-12-141-2/+4
| | | | | | | | | | | | | | | | | install time. Same as previous patch, except we now have a BrowserThemeProvider::GetDefaultDisplayProperty() so we don't have UMRs in ntp_resource_cache.cc. BUG=24493,21121 TEST=All the new unit tests pass. All the complex theme startup tests go faster. Previous Review URL: http://codereview.chromium.org/460050 Review URL: http://codereview.chromium.org/499004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34486 0039d316-1c4b-4281-b951-d872f2087c98
* Make KeywordEditorCocoaController implement the proper protocols. Also removersesek@chromium.org2009-12-132-4/+6
| | | | | | | | | | | unnecessary ones from FontLanguageSettingsController. BUG=30155 TEST=Build with 10.6 SDK. Review URL: http://codereview.chromium.org/496006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34445 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: remove extension shelf code.viettrungluu@chromium.org2009-12-126-499/+4
| | | | | | | | | | | | | Otherwise, I'll shortly have to update it and test other changes against the extension shelf (or let bitrot set in). The extension shelf was removed from Chrome/Chromium. This code was left in for possible future use since doing so posed no cost. The corresponding code remains in the Windows version (for experimental purposes), but has also been removed from the Linux version. If this code is ever needed again, this patch will be the one to try to revert. BUG=30178 TEST=Trybots, to make sure everything still compiles and unit tests run cleanly. Review URL: http://codereview.chromium.org/495004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34407 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Completely redo how themes are stored on disk and processed at installerg@google.com2009-12-111-4/+2
| | | | | | | | | | time," as it fails valgrind tests. This reverts commit 86faccd1028937a69ccc718718fd48c06c0cd471 (r34379). Review URL: http://codereview.chromium.org/490025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34385 0039d316-1c4b-4281-b951-d872f2087c98
* Completely redo how themes are stored on disk and processed at install time.erg@google.com2009-12-111-2/+4
| | | | | | | | | | | | | | | | | | | | Rewrites most of BrowserThemeProvider and adds a new class BrowserThemePack. BrowserThemePack takes all the logic of generating resources out of the BrowserThemeProvider, does all of them at theme install time (previously, we lazily generated all the button images and a good number of colors, which muddled logic quite a bit), and then writes all the data out into an mmap()able file to speed startup when a theme is installed. In addition, this changes how the GtkThemeProvider works. The GtkThemeProvider now generates all of its images lazily and doesn't reach into the implementation details of BrowserThemeProvider as it used to. BUG=24493,21121 TEST=All the new unit tests pass. All the complex theme startup tests go faster. Review URL: http://codereview.chromium.org/460050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34379 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Attempt to fix ref-after-free problems with NSTableView dataSource.shess@chromium.org2009-12-103-17/+22
| | | | | | | | | | | | | | | Clearing dataSource in the source's -dealloc seems generally good. HungRendererController having a local copy of the titles is in case the table view is redrawn as part of closing the window (this can happen if the window is closed while the user is mousing on the table, and perhaps at other times). BUG=29558 TEST=Crash noted in bug stops happening. Review URL: http://codereview.chromium.org/469016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34281 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor the keyboard events handling code related to ↵suzhe@chromium.org2009-12-102-2/+66
| | | | | | | | | | | | | | | | | | | | | | | | | RenderViewHostDelegate::View and TabContentsDelegate interfaces. Significant changes made by this CL: 1. The keyboard event handling code has been moved from TabContentsView implementation classes into BrowserWindow implementation classes. Please refer to this discussion thread: http://groups.google.com/group/chromium-dev/browse_thread/thread/e6e0b5cc105659b7/9953c4308bb0000c This change makes the keyboard event flow comply with the relationship between TabContents/TabContentsView and TabContentsDelegate/BrowserWindow. Besides it, the code is also simplified a lot, for example, the keyboard event handling code in chrome/browser/views/tab_contents/tab_contents_view_{gtk,win}.cc are now merged into one copy and moved into chrome/browser/views/frame/browser_view.cc. 2. A pre-handle phrase has been added into the keyboard event handling flow. A keyboard event will be first sent to the browser for pre-handling before being sent to the renderer. Then if the event was not handled by the renderer, it'll be sent to the browser again for post-handling. 3. The keyboard accelerator handling code of Windows and Linux ports have been optimized to get rid off extra command lookup. 4. The keyboard event message flow between the browser and the renderer is changed back to full async mode, all complex logics introduced by revision 29857 are removed. BUG=24479, 26054, 26131, 28839 TEST=See bug reports. Review URL: http://codereview.chromium.org/400012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34234 0039d316-1c4b-4281-b951-d872f2087c98
* extensions: Properly use string16 for Unicode text.evan@chromium.org2009-12-091-2/+2
| | | | | | | | BUG=29850 Review URL: http://codereview.chromium.org/477011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34203 0039d316-1c4b-4281-b951-d872f2087c98
* Display channel after version in about box. Mac.jrg@chromium.org2009-12-091-0/+4
| | | | | | | | | BUG=29917 TEST=Open about box on dev and beta. See channel in about box after version. Review URL: http://codereview.chromium.org/463063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34192 0039d316-1c4b-4281-b951-d872f2087c98
* Share the code that builds the page menu in a common model, make Mac and Win ↵pinkerton@chromium.org2009-12-096-15/+432
| | | | | | | | | | use it. Implement a mac menu controller that takes this model and generates an NSMenu. Remove the Page Menu NSMenu from Toolbar.xib since it's now created in code. BUG=22646 TEST=page menu should work as before Review URL: http://codereview.chromium.org/465130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34179 0039d316-1c4b-4281-b951-d872f2087c98
* Define X509Certificate::intermediate_ca_certs_ as a std::vector ofwtc@chromium.org2009-12-091-7/+6
| | | | | | | | | | | | | | | | OSCertHandle so that we can also use it on Windows. Remove the unused SSLClientSocketMac::intermediate_certs_ member. R=hawk BUG=28744 TEST=Can visit good HTTPS sites with no certificate errors. Clicking the "Certificate information" button in the page security information window should show a complete certificate chain (as opposed to just the server certificate). Review URL: http://codereview.chromium.org/452042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34175 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: add UMA calls for drag-and-drop of URLs on tab strip.viettrungluu@chromium.org2009-12-091-0/+2
| | | | | | | | | | | (Chrome/Win already has these, and we use the same names.) BUG=29799 TEST=none Review URL: http://codereview.chromium.org/465139 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34120 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Show group separators in the keyword editorrsesek@chromium.org2009-12-083-20/+167
| | | | | | | | | BUG=23570,21640 TEST=Chromium-->Preferences-->Manage. (1) See "Default" group. (2) Add an engine and it appears under an "Other" group header. (3) Make that new engine default and it moves under the "Default" group and the "Other" header disappears. Review URL: http://codereview.chromium.org/466022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34024 0039d316-1c4b-4281-b951-d872f2087c98
* More cleanups.thakis@chromium.org2009-12-072-31/+32
| | | | | | | | | | Rename tabModel_ to tabStripModel_. Belongs to codereview.chromium.org/465095. TEST=BUG=none Review URL: http://codereview.chromium.org/464061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33965 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Implement font and encoding settings in Under the Hood preferencesrsesek@chromium.org2009-12-075-0/+418
| | | | | | | | | | | | | * Font settings can now be changed for serif, sans serif, and fixed width. * The default encoding can now be changed via preferences. * Language settings are not yet implemented. See http://crbug.com/23828 BUG=20845 TEST=Chromium-->Preferences-->Under the Hood-->Change font and language settings Review URL: http://codereview.chromium.org/461005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33963 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: fix problem with un-minimizing windows using the app icon in the Dock.viettrungluu@chromium.org2009-12-071-2/+4
| | | | | | | | | | | More specifically, when detaching the status bubble window, don't just remove it as a child window but also remove it from the screen list. BUG=29054 TEST=Minimize all browser windows and make sure clicking on the app's Dock icon restores (un-minimizes) the last-used browser window; repeat under a variety of circumstances; see bug for more details. Also make sure that the status bubble continues to work properly. Review URL: http://codereview.chromium.org/460101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33955 0039d316-1c4b-4281-b951-d872f2087c98
* Some code cleanups.thakis@chromium.org2009-12-072-24/+24
| | | | | | | | | | Rename tabView_ to tabStripView_. Fix indentation. TEST=BUG=none Review URL: http://codereview.chromium.org/465095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33948 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Make a stop-gap visual indicator for dropping URLs on the tab strip.viettrungluu@chromium.org2009-12-053-9/+84
| | | | | | | | | | | A.k.a. a present for pkasting. Eventually we'll probably want to do something more sophisticated (at the very least arrows should fade in/out), but for now this doesn't look (much?) worse than what's on Win/Chrome. BUG=25405 TEST=Drag URLs to the tab strip, move around, make sure the ugly arrow appears in the right locations, dropping to confirm. Repeat with various themes to make sure arrow is reasonably visible. Review URL: http://codereview.chromium.org/466051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33924 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: implement drag-and-drop of URLs to tabs/tab strip.viettrungluu@chromium.org2009-12-048-10/+359
| | | | | | | | | | | | | Not yet implemented: visual feedback, dropping multiple URLs/files, perhaps key modifiers (?). Doing the visual feedback right (making the tabs move around, etc.) will require a fairly hefty work on the tabs code, so I'm splitting up the work. BUG=25405 TEST=Test dragging and dropping URLs/links, files, plain text (with a possibly-poorly-formed URL), etc. on the tab and on the empty part of the tab strip; web page should load in tab or in new tab, and that tab should be selected. Review URL: http://codereview.chromium.org/337055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33890 0039d316-1c4b-4281-b951-d872f2087c98
* Don't bounce the downloads folder if the download was auto-removed (e.g. themes)avi@chromium.org2009-12-042-10/+8
| | | | | | | | | BUG=http://crbug.com/28717 TEST=as in bug Review URL: http://codereview.chromium.org/465064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33854 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Route edit-state messages via observer rather than delegate.shess@chromium.org2009-12-046-79/+213
| | | | | | | | | | | | | | | | | | | AutocompleteTextField routes messages to AutocompleteEditViewMac via a Cocoa-style delegate and also a C++ observer class. The Cocoa-style delegate has been gradually being pruned down in favor of the observer, this CL completes the transformation. The noted bugs occur because some bit of Cocoa code was sending spurious delegate notifications. Since this code no longer depends on those notifications, the spurious notifications are no longer a problem for this case. BUG=19116, 17803 TEST=Login to gmail, select a message, j, k, and other keys should work (and not send you to the omnibox). Bring up the Print panel and cancel. Bring up a new tab and close it. gmail's accelerator keys should still work right (not send focus to omnibox). Review URL: http://codereview.chromium.org/391025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33853 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: restore window size/position when hiding bookmark bar or download shelf.viettrungluu@chromium.org2009-12-043-34/+253
| | | | | | | | | | | | | | | This applies in particular when the bookmark bar or download shelf causes the window to grow at the top (due to there not being enough space at the bottom of the screen). Note that resizing or moving reset the state (* for moving it's a bit more subtle), so hiding afterwards will always shrink the window from the bottom. BUG=29192 TEST=(1) Navigate to a normal (non-NTP) page and hide bookmark bar; move window close to the bottom of the screen (keeping the window fully on-screen); Shift-Cmd-B to show the bookmark bar (which show grow maybe a bit downwards and then upwards); Shift-Cmd-B to hide it again; it should shrink from the top and from the bottom, restoring its original size/position. (2) Do the same but move the window away from the bottom of the screen after the first Shift-Cmd-B; now upon hiding it should only shrink at the bottom. (3) Check that if the window is far enough away from the bottom of the screen to begin with, then growing/shrinking only occurs at the bottom. (4) Do (1)-(3) for the download shelf (download something to show the shelf; then hide it by closing it). Review URL: http://codereview.chromium.org/465024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33821 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: remove hacky way the New Tab button is obtained from the nib.viettrungluu@chromium.org2009-12-044-10/+21
| | | | | | | | | | | | | | | I added a member variable and an accessor/mutator ... and hooked up that up in the nib. Changes to BrowserWindow.xib: hook up the New Tab button to |newTabButton| in TabBar. Unit test fixed. Previously committed at r33758, reverted at r33761. BUG=none TEST=Make sure it builds, runs, and that the New Tab button still works. Review URL: http://codereview.chromium.org/460058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33771 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 33758 - Mac: remove hacky way the New Tab button is obtained from the ↵viettrungluu@chromium.org2009-12-043-15/+6
| | | | | | | | | | | | | | | | | | nib. I added a member variable and an accessor/mutator ... and hooked up that up in the nib. Changes to BrowserWindow.xib: hook up the New Tab button to |newTabButton| in TabBar. BUG=none TEST=Make sure it builds, runs, and that the New Tab button still works. Review URL: http://codereview.chromium.org/465042 TBR=viettrungluu@chromium.org Review URL: http://codereview.chromium.org/465045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33761 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: remove hacky way the New Tab button is obtained from the nib.viettrungluu@chromium.org2009-12-043-6/+15
| | | | | | | | | | | | | I added a member variable and an accessor/mutator ... and hooked up that up in the nib. Changes to BrowserWindow.xib: hook up the New Tab button to |newTabButton| in TabBar. BUG=none TEST=Make sure it builds, runs, and that the New Tab button still works. Review URL: http://codereview.chromium.org/465042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33758 0039d316-1c4b-4281-b951-d872f2087c98
* Created HtmlDialogTabContentsDelegate, which encapsulates the ↵akalin@chromium.org2009-12-032-110/+14
| | | | | | | | | | | | | TabContentsDelegate behavior for HTML dialogs. Made all three implementations (gtk, win32, and cocoa) use it. This also makes HTML dialogs not tied to a Browser instance. Also, unlike the current behavior, any links followed from an HTML dialog box will be opened in a non-incognito browser, even if the HTML dialog was launched from an incognito browser. According to beng, this is okay. BUG=28609 TEST=unittests, manual testing on linux/windows/os x with sync setup wizard Review URL: http://codereview.chromium.org/441011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33752 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the deprecated version of FixupURL and fix the callers.thakis@chromium.org2009-12-031-8/+7
| | | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/455022 Patch from tfarina. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33728 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: FIXME -> TODO, viettrungluu@gmail.com -> viettrungluu, remove ↵viettrungluu@chromium.org2009-12-038-13/+13
| | | | | | | | | | | whitespace at EOL. BUG=none TEST=none Review URL: http://codereview.chromium.org/467002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33687 0039d316-1c4b-4281-b951-d872f2087c98
* Mac unit test: fix StatusBubbleMacTest.UpdateSizeAndPosition flakiness.viettrungluu@chromium.org2009-12-031-1/+14
| | | | | | | | | | | | The success/failure of this test depends on the location of the mouse. Other StatusBubbleMacTest.* tests may have the same issue too. BUG=none TEST=trybots and less flakiness Review URL: http://codereview.chromium.org/460029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33649 0039d316-1c4b-4281-b951-d872f2087c98
* Makes 'Cancel' the default button for extension install/uninstall ↵andybons@chromium.org2009-12-021-2/+9
| | | | | | | | | | confirmation dialogs. BUG=26357 TEST=try to install any extension on Mac, verify that the default (blue) button with the key equivalent of 'Return' is the abort action, NOT the install action. Review URL: http://codereview.chromium.org/463008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33607 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes two problems caused by core animation race conditions. One involves ↵andybons@chromium.org2009-12-021-11/+24
| | | | | | | | | | clicking a browser action multiple times very quickly. The other has to do with the frame of the popup changing mid-animation. BUG=none TEST=none Review URL: http://codereview.chromium.org/464004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33598 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: disable bookmark bar animation in toolbar-less windows.viettrungluu@chromium.org2009-12-011-1/+5
| | | | | | | | | | | | | (It's still a bit odd that some of these windows (e.g., Developer Tools) display a location bar. The displayed bar is also a strange size and not properly framed. These are separate bugs.) BUG=29070 TEST=Open a normal web page and then also a Developer Tools window (Cmd-Opt-I). Focus the window (and tab) with the normal web page. Press Shift-Cmd-B a few times. Make sure no animation occurs in the Developer Tools window. Also make sure the bookmark bar animations occur normally in normal browser windows. Review URL: http://codereview.chromium.org/453020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33484 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: allow bookmark bar buttons to be dragged as URLs.viettrungluu@chromium.org2009-12-017-44/+160
| | | | | | | | | | | | | TODO #1: dragging of folder buttons. TODO #2: perhaps holding Option while dragging on the bookmark bar should force the bookmark to be copied instead of moved. BUG=17608, 28842 TEST=Make a bunch of (non-folder) bookmarks on the bookmark bar; try dragging these bookmark bar buttons to the desktop, to the web content area, to text boxes, to other browsers -- these should all do sensible things; make sure that dragging them around on the bookmark bar still rearranges them. Review URL: http://codereview.chromium.org/434095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33478 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: change tab change notifications to pass full TabChangeType.viettrungluu@chromium.org2009-12-014-27/+24
| | | | | | | | | | | | | This makes the Mac code better parallel that on other platforms. It will also be needed to make the "glow" animation for (unselected, title-changing) pinned tabs work. (I have a mostly-working patch which does the glow, but it's horribly hacky and to get it to completely work would either involve much more hackiness or significant refactoring. That's why the glow is not part of this CL.) Also: prevent changes in background tabs (e.g., loading finished) from killing any current bookmark bar animation. Still to do on this front (part of issue 27693): be smarter about bookmark bar updates in the selected tab. BUG=28154, 27693 TEST=Load lots of (slow-loading) pages in background tabs while pressing Shift-Cmd-B repeatedly; make sure changes in background (unselected) tabs don't cancel the animation. Review URL: http://codereview.chromium.org/449056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33455 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up property name and add comment about thread-safety.pinkerton@chromium.org2009-12-013-6/+6
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/456022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33446 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: minor cleanup for TabView.viettrungluu@chromium.org2009-12-012-23/+29
| | | | | | | | | | | This is only the beginning. BUG=none TEST=none Review URL: http://codereview.chromium.org/449038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33409 0039d316-1c4b-4281-b951-d872f2087c98
* Enable sync by default on all platforms.akalin@chromium.org2009-11-301-0/+6
| | | | | | | | | | | BUG=23073 TEST=ran without --enable-sync on OS X, made sure sync UI was still present Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33318 Review URL: http://codereview.chromium.org/438005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33342 0039d316-1c4b-4281-b951-d872f2087c98
* Disable BugReportWindowController tests.willchan@chromium.org2009-11-301-2/+4
| | | | | | | | BUG=http://crbug.com/29019 Review URL: http://codereview.chromium.org/457008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33338 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-05-11 12:39:40 +0000