summaryrefslogtreecommitdiffstats
path: root/chrome/browser/cocoa
Commit message (Collapse)AuthorAgeFilesLines
* Clean up construction of LocationBarViewMac objects.shess@chromium.org2009-04-273-25/+2
| | | | | | | | | | | This removes the need for SetField() accessors on AutocompleteEditViewMac and AutocompletePopupViewMac, and also removes the Init() wart on LocationBarViewMac. Now everything is wired up in the constructor. Review URL: http://codereview.chromium.org/92136 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14641 0039d316-1c4b-4281-b951-d872f2087c98
* Add a stub test for TabStripController. It doesn't fully work because of issuespinkerton@chromium.org2009-04-272-1/+131
| | | | | | creating WebContents objects. A bug has been filed to come back to it. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14601 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a NOTIMPLEMENTED() that's not necessary on Mac.pinkerton@chromium.org2009-04-271-1/+5
| | | | | | Review URL: http://codereview.chromium.org/97004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14600 0039d316-1c4b-4281-b951-d872f2087c98
* Unittest for FindBarCocoaController.rohitrao@chromium.org2009-04-245-10/+105
| | | | | | | TEST=The new unittest passes. BUG=10802 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14424 0039d316-1c4b-4281-b951-d872f2087c98
* Allow appkit-driven animations in unit tests to work correctly.pinkerton@chromium.org2009-04-232-4/+5
| | | | | | Review URL: http://codereview.chromium.org/95003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14301 0039d316-1c4b-4281-b951-d872f2087c98
* Fix problem with bookmark bar introduced by window sharing; prefjrg@chromium.org2009-04-2316-172/+256
| | | | | | | | | | | | change needs to change all open windows with the same preferences, not just the current one). Improve unit testing. Limit bookmark menu size width (1st pass). Cleanup/delete of code which no longer does much. Review URL: http://codereview.chromium.org/79068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14282 0039d316-1c4b-4281-b951-d872f2087c98
* Fix DIR_SOURCE_ROOT to work in bundles like Chromium.app. Add more ui tests. ↵pinkerton@chromium.org2009-04-226-8/+28
| | | | | | | | Add a resource for tabs with no title on mac. Fix window title reporting. Remove the Browser dependency from the tab strip (only needs a TabStripModel). Review URL: http://codereview.chromium.org/93025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14212 0039d316-1c4b-4281-b951-d872f2087c98
* Unit test for sad tab view.pinkerton@chromium.org2009-04-211-0/+39
| | | | | | Review URL: http://codereview.chromium.org/87028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14099 0039d316-1c4b-4281-b951-d872f2087c98
* Unit tests for button cells we use in the UI.pinkerton@chromium.org2009-04-212-0/+83
| | | | | | Review URL: http://codereview.chromium.org/87023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14098 0039d316-1c4b-4281-b951-d872f2087c98
* Add a bunch of basic unit tests for view classes.pinkerton@chromium.org2009-04-215-0/+200
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14095 0039d316-1c4b-4281-b951-d872f2087c98
* Rename web_contents_view to tab_contents_view to fix the mac build.brettw@chromium.org2009-04-211-1/+1
| | | | | | Review URL: http://codereview.chromium.org/88019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14086 0039d316-1c4b-4281-b951-d872f2087c98
* Test forcing the display of the controller's view.pinkerton@chromium.org2009-04-203-0/+11
| | | | | | Review URL: http://codereview.chromium.org/86002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14047 0039d316-1c4b-4281-b951-d872f2087c98
* Add a unit test for BaseView. Add a helper to get the contentView more easily.pinkerton@chromium.org2009-04-203-1/+60
| | | | | | Review URL: http://codereview.chromium.org/82001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14030 0039d316-1c4b-4281-b951-d872f2087c98
* Initial implementation of the FindBar on Mac.rohitrao@chromium.org2009-04-1712-18/+492
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13969 0039d316-1c4b-4281-b951-d872f2087c98
* Implement a unit test for the toolbar controller. Plumb the profile into the ↵pinkerton@chromium.org2009-04-176-19/+143
| | | | | | | | loation bar instead of picking it up globally, which cannnot be unit tested. Review URL: http://codereview.chromium.org/79041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13959 0039d316-1c4b-4281-b951-d872f2087c98
* Add a test helper to pull out some common code. Add a test for tab ↵pinkerton@chromium.org2009-04-166-28/+252
| | | | | | | | controller. Don't dead-strip un-referenced objective-C code in the unit_test target. Use the appropriate bundle when loading the tab nib. (take two, most of this was backed out earlier). Review URL: http://codereview.chromium.org/77004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13859 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 13839,13838.awalker@google.com2009-04-164-241/+2
| | | | | | Review URL: http://codereview.chromium.org/67220 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13840 0039d316-1c4b-4281-b951-d872f2087c98
* Add a helper, and add the test file that broke the build.pinkerton@chromium.org2009-04-162-0/+238
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13839 0039d316-1c4b-4281-b951-d872f2087c98
* Allow unit_tests (and other non-bundle executables) to rely on objectiveC that'spinkerton@chromium.org2009-04-162-2/+3
| | | | | | | not directly referenced (such as only in a nib file). Add test for tab controller. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13838 0039d316-1c4b-4281-b951-d872f2087c98
* Fix regression I introduced where Stop/Go button would toggle state ↵pkasting@chromium.org2009-04-152-2/+2
| | | | | | | | | | | instantly instead of having protections against accidental user actions while the mouse was hovering the button. I elected to condense ChangeMode() and ScheduleChangeMode() into one function, which as a result became pretty simple. BUG=9843 Review URL: http://codereview.chromium.org/67156 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13761 0039d316-1c4b-4281-b951-d872f2087c98
* Unit test for command observer bridge class. Add ifdef guards that were ↵pinkerton@chromium.org2009-04-152-0/+93
| | | | | | | | missing in the original header file. Review URL: http://codereview.chromium.org/73082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13755 0039d316-1c4b-4281-b951-d872f2087c98
* Add unit test for bookmark bar controller.pinkerton@chromium.org2009-04-153-6/+82
| | | | | | Review URL: http://codereview.chromium.org/73051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13740 0039d316-1c4b-4281-b951-d872f2087c98
* Remove two lines that were from a different experiment and got checked inpinkerton@chromium.org2009-04-141-3/+0
| | | | | | accidentally. Those lines only have an effect for non-textured windows. Patch from nicothakis@googlemail.com. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13704 0039d316-1c4b-4281-b951-d872f2087c98
* Add a Cocoa file picker.avi@google.com2009-04-144-10/+349
| | | | | | Review URL: http://codereview.chromium.org/73044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13695 0039d316-1c4b-4281-b951-d872f2087c98
* Add unit test for status bubble mac.pinkerton@chromium.org2009-04-142-0/+107
| | | | | | Review URL: http://codereview.chromium.org/67131 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13674 0039d316-1c4b-4281-b951-d872f2087c98
* Collapse bookmark bars into a single bar per window, rather than one per tab.pinkerton@chromium.org2009-04-1411-118/+191
| | | | | | | | Create a separate controller for the bar. Hide bar when it's not supposed to be visible instead of just allowing it to be covered by content (it's not always covered, which leads to drawing errors). git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13661 0039d316-1c4b-4281-b951-d872f2087c98
* Disable Leopard's automatic window title gradient height detection, as it getspinkerton@chromium.org2009-04-131-22/+69
| | | | | | confused by our tabs. Patch from rohitrao@google.com. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13591 0039d316-1c4b-4281-b951-d872f2087c98
* Convert more members to scoped pointers. Move status bubble into browser ↵pinkerton@chromium.org2009-04-1310-72/+58
| | | | | | | | window controller. Move extra window retain into BWC because it's needed for things in there, not the BrowserWindow impl. Be explicit about the ordering and nature of the ownership in BWC, which should be better since it's now all in one place. Clean up a lot of un-used cruft in tab strip and tab contents now that the toolbaris no longer there, preparing for the BookmarkBar to leave as well. Review URL: http://codereview.chromium.org/66047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13589 0039d316-1c4b-4281-b951-d872f2087c98
* Initial implemention of Mac Omnibox.shess@chromium.org2009-04-104-30/+173
| | | | | | | | | | | | | | | | AutocompletePopupViewMac implements AutocompletePopupView in terms of a bare NSWindow containing an NSTableView. AutocompleteTableTarget implements an Obj-C class to bridge from appkit callbacks back to the popup view (and from there to the model which contains the data it needs). AutocompleteEditViewMac implements AutocompleteEditView in terms of an NSTextField, which is passed down from a nib owner. It works with the popup view to make sure the popup is positioned correctly. AutocompleteFieldDelegate is an internal Obj-C class to bridge from appkit callbacks back to the edit view (and then the edit model). LocationBarViewMac implements LocationBar for interacting with the rest of the browser, and AutocompleteEditController for managing the edit and popup views. It is mostly placeholder code stolen from the gtk implementation. --- I've tried to implement an amount of code which worked and was useful, but which didn't drag on and on into the future. So no tab to search or hints or anything, sometimes ugly, selection may be funky, etc. Review URL: http://codereview.chromium.org/50074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13534 0039d316-1c4b-4281-b951-d872f2087c98
* Take two converting to scoped pointers, without ui_test failures.pinkerton@chromium.org2009-04-104-28/+32
| | | | | | Review URL: http://codereview.chromium.org/67039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13522 0039d316-1c4b-4281-b951-d872f2087c98
* backing out r13504 due to ui_test issuespinkerton@chromium.org2009-04-102-24/+25
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13512 0039d316-1c4b-4281-b951-d872f2087c98
* Fix dtor ordering, browser must destruct last.pinkerton@chromium.org2009-04-101-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13506 0039d316-1c4b-4281-b951-d872f2087c98
* Force c++ dtors to get called in objc interfaces (it was always on since ↵pinkerton@chromium.org2009-04-102-25/+24
| | | | | | | | gcc4.2, but this makes it explicit). Use scoped_* goodness. Review URL: http://codereview.chromium.org/70001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13504 0039d316-1c4b-4281-b951-d872f2087c98
* Re-order the steps used to create the new browser window on a tab drag in ↵pinkerton@chromium.org2009-04-092-7/+9
| | | | | | | | order to make sure the TabContents' delegate doesn't get clobbered. Fix the define of a file that had been moved a while ago. Review URL: http://codereview.chromium.org/67007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13455 0039d316-1c4b-4281-b951-d872f2087c98
* This CL adds a confirmation box when closing the browser with in-progress ↵jcampan@chromium.org2009-04-092-0/+6
| | | | | | | | | | downloads. BUG=1028 TEST=Start several bug downloads, close the browser. A dialog shows up to warn you are about to lose the downloads. Try the wait and continue button. Try again with several windows, and in Incognito mode. Review URL: http://codereview.chromium.org/62131 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13453 0039d316-1c4b-4281-b951-d872f2087c98
* Flatten down to a single toolbar per window, significantly simplifying the ↵pinkerton@chromium.org2009-04-0912-277/+347
| | | | | | | | tab strip as it now no longer needs to forward messages for everything. Created a toolbar controller to encapsulate much of the toolbar logic that was in the tab contents controller. Better parameterized the tab strip controller so that it could switch any view, not just the main window's content view, when switching tabs. Review URL: http://codereview.chromium.org/65011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13441 0039d316-1c4b-4281-b951-d872f2087c98
* Scaffolding cleanup.thestig@chromium.org2009-04-081-0/+2
| | | | | | Review URL: http://codereview.chromium.org/63142 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13394 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor tab model observer for cocoa into a separate class so it can be ↵pinkerton@chromium.org2009-04-086-106/+212
| | | | | | | | re-used. Mark tab as visible when switching to it so tabs loaded in the background work. Review URL: http://codereview.chromium.org/63087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13346 0039d316-1c4b-4281-b951-d872f2087c98
* Move location bar bridge out of tab_contents_controller.shess@chromium.org2009-04-085-75/+146
| | | | | | | | | | [So that I don't keep getting conflicts as I work to finish the omnibox change http://codereview.chromium.org/50074 ] Review URL: http://codereview.chromium.org/63096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13342 0039d316-1c4b-4281-b951-d872f2087c98
* Layout the tabs explicitly when creating a background tab. Update to correct ↵pinkerton@chromium.org2009-04-071-12/+20
| | | | | | | | tab model observer API so we once again get update messages. Review URL: http://codereview.chromium.org/63022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13249 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Initial implemention of Mac Omnibox."shess@chromium.org2009-04-075-234/+73
| | | | | | | | | | Reverts: http://codereview.chromium.org/50074 http://src.chromium.org/viewvc/chrome?view=rev&revision=13201 Review URL: http://codereview.chromium.org/63047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13227 0039d316-1c4b-4281-b951-d872f2087c98
* Initial implemention of Mac Omnibox.shess@chromium.org2009-04-065-73/+234
| | | | | | | | | | | | | | | | AutocompletePopupViewMac implements AutocompletePopupView in terms of a bare NSWindow containing an NSTableView. AutocompleteTableTarget implements an Obj-C class to bridge from appkit callbacks back to the popup view (and from there to the model which contains the data it needs). AutocompleteEditViewMac implements AutocompleteEditView in terms of an NSTextField, which is passed down from a nib owner. It works with the popup view to make sure the popup is positioned correctly. AutocompleteFieldDelegate is an internal Obj-C class to bridge from appkit callbacks back to the edit view (and then the edit model). LocationBarViewMac implements LocationBar for interacting with the rest of the browser, and AutocompleteEditController for managing the edit and popup views. It is mostly placeholder code stolen from the gtk implementation. --- I've tried to implement an amount of code which worked and was useful, but which didn't drag on and on into the future. So no tab to search or hints or anything, sometimes ugly, selection may be funky, etc. Review URL: http://codereview.chromium.org/50074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13201 0039d316-1c4b-4281-b951-d872f2087c98
* Correctly initialize all parts of the tab to unselected when it's created, ↵pinkerton@chromium.org2009-04-061-6/+12
| | | | | | | | keeping it in sync with the member var. Review URL: http://codereview.chromium.org/62074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13192 0039d316-1c4b-4281-b951-d872f2087c98
* Add some hysterisis to tab dragging on Mac.shess@chromium.org2009-04-031-0/+19
| | | | | | | | http://code.google.com/p/chromium/issues/detail?id=9670 Review URL: http://codereview.chromium.org/60072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13104 0039d316-1c4b-4281-b951-d872f2087c98
* Move HTML dialogs out of their own tab contents type. Moved functions to newbrettw@chromium.org2009-04-032-2/+2
| | | | | | | | | | | | | file html_dialog_ui.* Move WebContents view creation into the constructor, which makes a bunch of extra calls to CreateView unnecessary. Remove unused CallJavascriptFunction() functions in DOMUI. Review URL: http://codereview.chromium.org/56065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13065 0039d316-1c4b-4281-b951-d872f2087c98
* Make NTP work by correctly marking the kind of urls we type in. Patch from ↵pinkerton@chromium.org2009-03-301-1/+5
| | | | | | rohitrao@google.com. http://codereview.chromium.org/55058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12810 0039d316-1c4b-4281-b951-d872f2087c98
* Correctly position windows that are detached during a drag, instead of ↵pinkerton@chromium.org2009-03-272-14/+26
| | | | | | | | relying on the default window position in the nib. Stub a little more of WindowSizer, but only enough to get drag working. Default new windows to 1024x768. Review URL: http://codereview.chromium.org/55023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12677 0039d316-1c4b-4281-b951-d872f2087c98
* Forgot a file in last checkin.pinkerton@chromium.org2009-03-271-0/+14
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12657 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up close button in tabs. Patch from rohitrao@google.com.pinkerton@chromium.org2009-03-278-46/+33
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12656 0039d316-1c4b-4281-b951-d872f2087c98
* Don't order the bubble window front; it shows up just fine.avi@google.com2009-03-271-1/+0
| | | | | | | | | Fix by Rohit. http://crbug.com/9422 Review URL: http://codereview.chromium.org/55016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12655 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-09 02:34:02 +0000