summaryrefslogtreecommitdiffstats
path: root/chrome/browser/command_updater.cc
Commit message (Collapse)AuthorAgeFilesLines
* Moves command handling from Browser to a new object, BrowserCommandController.ben@chromium.org2012-06-271-5/+9
| | | | | | | | | | | | | | Notes: . BrowserCommandController now owns the CommandUpdater. . CommandHandler's ExecuteCommand API was massaged a little so that ExecuteCommand/IsCommandEnabled/SupportsCommand methods are always called on it, rather than the wrapping controller. . The creation of BCC was performed as a svn cp so that history for the various Exec methods could be easily carried forward. . Various "CanFoo" methods were extracted from the UpdateFooState() methods and moved to CanFoo(const Browser* browser) in browser_commands. http://crbug.com/133576 TEST=none Review URL: https://chromiumcodereview.appspot.com/10677009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144597 0039d316-1c4b-4281-b951-d872f2087c98
* Re-factor location bar/toolbar code to get rid of the browser dependency. ↵altimofeev@chromium.org2012-03-161-2/+8
| | | | | | | | | | | | | | | This CL is needed to allow code reusing by captive portal view, which will show web content using DomView. BUG=chromium-os:22630 TEST=browser_tests,unit_tests works Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126959 Reverted because of a misprint which was hidden by overloaded method (ExecuteCommand): http://codereview.chromium.org/9703099/ Review URL: http://codereview.chromium.org/9479008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127145 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 126959 - Re-factor location bar/toolbar code to get rid of the ↵thestig@chromium.org2012-03-161-8/+2
| | | | | | | | | | | | | browser dependency. This CL is needed to allow code reusing by captive portal view, which will show web content using DomView. BUG=chromium-os:22630 TEST=browser_tests,unit_tests works Review URL: http://codereview.chromium.org/9479008 TBR=altimofeev@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127083 0039d316-1c4b-4281-b951-d872f2087c98
* Re-factor location bar/toolbar code to get rid of the browser dependency. ↵altimofeev@chromium.org2012-03-151-2/+8
| | | | | | | | | | | This CL is needed to allow code reusing by captive portal view, which will show web content using DomView. BUG=chromium-os:22630 TEST=browser_tests,unit_tests works Review URL: http://codereview.chromium.org/9479008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126959 0039d316-1c4b-4281-b951-d872f2087c98
* some cleanup for base/stl_utildilmah@chromium.org2011-07-191-1/+1
| | | | | | | | | | | | | removed unused/irrelevant functions removed irrelevant comments Moved stl_util-inl.h => stl_util.h BUG=None TEST=None Review URL: http://codereview.chromium.org/7342047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93110 0039d316-1c4b-4281-b951-d872f2087c98
* Move implementation from header to source.erg@chromium.org2010-07-151-0/+6
| | | | | | | | | | | | | | | | | | | | This is an effort to speed up compile and link time, and also minimizing the size of the intermediary .o files on disk. For example, just moving the constructor/destructor from the classes in chrome/browser/pref_member.{cc,h} netted a 368k drop in total .o file size. In aggregate, this shrinks libbrowser.a by 10 megabytes, and a few odd megabytes on most other chrome .a files. A lot of this was done before I started harvesting what the most included symbols were across all of chrome's code. Most of them are in webkit, but there's plenty in base/ that are used everywhere to keep me busy for several patches to come. BUG=none TEST=none Review URL: http://codereview.chromium.org/3012001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52528 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce header dependencies in browser/phajdan.jr@chromium.org2009-06-131-2/+11
| | | | | | | | | | | | - remove unneeded header includes - move implementation bits out of headers - more explicit header deps In my scan of headers I got up to (including) dom_ui. Review URL: http://codereview.chromium.org/126071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18353 0039d316-1c4b-4281-b951-d872f2087c98
* Move scoped_vector.h and stl_util-inl.h to base/ben@chromium.org2009-05-051-1/+1
| | | | | | | | http://crbug.com/11387 Review URL: http://codereview.chromium.org/107001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15272 0039d316-1c4b-4281-b951-d872f2087c98
* Add a method to CommandUpdater to remove an observer from all commands at once.pinkerton@chromium.org2009-02-061-0/+10
| | | | | | Review URL: http://codereview.chromium.org/21140 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9350 0039d316-1c4b-4281-b951-d872f2087c98
* Rework the command updater to not be dependent on views::Button (needed for ↵ben@chromium.org2009-01-201-0/+61
porting). TEST=make sure back/forward buttons still enable/disable correctly depending on the length of the back/forward navigation list. Review URL: http://codereview.chromium.org/18343 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8332 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-04-03 12:29:18 +0000