summaryrefslogtreecommitdiffstats
path: root/chrome/browser/content_setting_bubble_model.cc
Commit message (Collapse)AuthorAgeFilesLines
* Move click-to-play to about:flags.bauerb@chromium.org2010-11-121-7/+2
| | | | | | | | | | | | | | | | XIB changes: Add an outlet |pluginDefaultSettingMatrix_| to ContentSettingsDialogController, hooked up to the associated matrix, to remove the click-to-play radio button. While I'm at it, clean up a bit: * Remove the old --disable-click-to-play flag that reverted to the M6 behavior for blocked plugins * Make ContentExceptionsWindowController use ContentSettingComboModel for the action popup. * Make HostContentSettingsMapTest use AutoReset to reset command line switches. BUG=62091 TEST=unit_tests Review URL: http://codereview.chromium.org/4643007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65953 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: More dtor deinlining. (Can almost see the end!)erg@google.com2010-10-221-0/+15
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3962004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63527 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes instant so that it correctly deals with child contents. I'vesky@chromium.org2010-10-141-7/+7
| | | | | | | | | | | | | | | changed around BlockedPopupContainer so that it can handle any types and made TabContents offer a mode to block all child content. BUG=58927 TEST=enable instant, go to a site that would normally show a popup on entering (or explicitly enable all popups). While typing in the omnibox the popup shouldn't appear, but as soon as you commit the instant result it should appear. Review URL: http://codereview.chromium.org/3694005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62553 0039d316-1c4b-4281-b951-d872f2087c98
* Change plugin content settings to three states: Allow, click-to-play, and block.bauerb@chromium.org2010-10-111-11/+24
| | | | | | | | | | | | | The click-to-play default setting says "Let me choose which plug-ins to run". XIB changes: Change the middle radio button label in plug-in default settings from IDS_PLUGINS_LOAD_SANDBOXED_RADIO to IDS_PLUGINS_ASK_RADIO. BUG=35316,56514,56270 TEST=ContentSettingsBubbleModelTest.*, mainly Review URL: http://codereview.chromium.org/3608007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62146 0039d316-1c4b-4281-b951-d872f2087c98
* Add DCHECK for misused string resources.estade@chromium.org2010-10-041-2/+1
| | | | | | | | | | | When replacing a placeholder in a localized string, make sure the correct number of placeholders were found (i.e. the same number of strings that the calling code passed). BUG=none TEST=running/testing the browser in debug doesn't cause errors Review URL: http://codereview.chromium.org/3396025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61420 0039d316-1c4b-4281-b951-d872f2087c98
* Remove vestigial cookie/web app permissions prompting UI now that the async ↵ben@chromium.org2010-09-171-6/+2
| | | | | | | | | | UI has been approved for M7.This allows me to more easily change the way the appmodal dialog system works. http://crbug.com/55121 TEST=existing tests Review URL: http://codereview.chromium.org/3299020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59838 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 58663 - Revert 58641 - Add user metrics for nonsandboxed plugin infobar.nsylvain@chromium.org2010-09-071-0/+2
| | | | | | | | | | | | | | | BUG=52341 TEST=none Review URL: http://codereview.chromium.org/3303003 TBR=bauerb@chromium.org Review URL: http://codereview.chromium.org/3300015 TBR=mal@chromium.org Review URL: http://codereview.chromium.org/3303011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58666 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 58641 - Add user metrics for nonsandboxed plugin infobar.mal@chromium.org2010-09-071-2/+0
| | | | | | | | | | | | BUG=52341 TEST=none Review URL: http://codereview.chromium.org/3303003 TBR=bauerb@chromium.org Review URL: http://codereview.chromium.org/3300015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58663 0039d316-1c4b-4281-b951-d872f2087c98
* Add user metrics for nonsandboxed plugin infobar.bauerb@chromium.org2010-09-061-0/+2
| | | | | | | | | BUG=52341 TEST=none Review URL: http://codereview.chromium.org/3303003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58641 0039d316-1c4b-4281-b951-d872f2087c98
* Enable click-to-play by default.bauerb@chromium.org2010-09-011-4/+4
| | | | | | | | | | | Click-to-play can be disabled using the --disable-click-to-play command line switch. BUG=35316 TEST=none Review URL: http://codereview.chromium.org/3250012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58147 0039d316-1c4b-4281-b951-d872f2087c98
* Move prefs-related files under chrome/browser/ into a prefs/ subdir.evan@chromium.org2010-08-261-1/+1
| | | | | | | | | | | | Rename includes, resort header include order in places where the rename changed the order. BUG=50548 TEST=compiles Review URL: http://codereview.chromium.org/3203008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57434 0039d316-1c4b-4281-b951-d872f2087c98
* Check that BlockedContents::blocked_popup_container is not NULL before using it.jschuh@google.com2010-08-241-1/+3
| | | | | | | | BUG=53176 TEST=None. Review URL: http://codereview.chromium.org/3204003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57249 0039d316-1c4b-4281-b951-d872f2087c98
* Reland 55888: Allow per-plugin content settings.bauerb@chromium.org2010-08-191-12/+93
| | | | | | | | | | | | | | | | | | | | | | | | | Now with Fixed Unit Tests! Run with --enable-resource-content-settings and --enable-click-to-play to enable. TabSpecificContentSettings now keeps track of which resources were blocked. The content setting bubble displays those resource, and selecting the "allow radio buttons adds exceptions for these resources. The infobar for non-sandboxed plug-ins now also shows a button to always allow the blocked plug-in on that site. Screenshot of the plugin bubble: http://imgur.com/6npqv.png Because we need to change the title and radio button labels depending on whether we track specific plug-ins, we copy them from the ContentSettingBubbleModel. XIB changes: Add a text field for the blocked plug-ins to ContentBlockedPlugins.xib, hooked up to the |blockedResourcesField_| outlet. BUG=39252,38432 TEST=HostContentSettingsMapTest.*,manual Review URL: http://codereview.chromium.org/2873104 Review URL: http://codereview.chromium.org/3124018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56687 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 55888: Allow per-plugin content settings.bauerb@chromium.org2010-08-121-93/+12
| | | | | | | | | | | | | | | | | | | | | | | Run with --enable-resource-content-settings and --enable-click-to-play to enable. TabSpecificContentSettings now keeps track of which resources were blocked. The content setting bubble displays those resource, and selecting the "allow radio buttons adds exceptions for these resources. The infobar for non-sandboxed plug-ins now also shows a button to always allow the blocked plug-in on that site. Screenshot of the plugin bubble: http://imgur.com/6npqv.png Because we need to change the title and radio button labels depending on whether we track specific plug-ins, we copy them from the ContentSettingBubbleModel. XIB changes: Add a text field for the blocked plug-ins to ContentBlockedPlugins.xib, hooked up to the |blockedResourcesField_| outlet. BUG=39252,38432 TEST=manual Review URL: http://codereview.chromium.org/2873104 TBR: bauerb@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55891 0039d316-1c4b-4281-b951-d872f2087c98
* Allow per-plugin content settings.bauerb@chromium.org2010-08-121-12/+93
| | | | | | | | | | | | | | | | | | | | | Run with --enable-resource-content-settings and --enable-click-to-play to enable. TabSpecificContentSettings now keeps track of which resources were blocked. The content setting bubble displays those resource, and selecting the "allow radio buttons adds exceptions for these resources. The infobar for non-sandboxed plug-ins now also shows a button to always allow the blocked plug-in on that site. Screenshot of the plugin bubble: http://imgur.com/6npqv.png Because we need to change the title and radio button labels depending on whether we track specific plug-ins, we copy them from the ContentSettingBubbleModel. XIB changes: Add a text field for the blocked plug-ins to ContentBlockedPlugins.xib, hooked up to the |blockedResourcesField_| outlet. BUG=39252,38432 TEST=manual Review URL: http://codereview.chromium.org/2873104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55888 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r55382. When blocking cookies, also show an icon in the location bar ↵jochen@chromium.org2010-08-111-4/+25
| | | | | | | | | | | | | | | when cookies are accessed. If the user choses to block cookies per default, this will grant access to the collected cookies dialog as soon as the page accesses cookies. Right now, the icon is only shown if cookies were actually blocked. BUG=45230 TEST=Canned*.*:ContentSetting*.*:TabSpecific*.* Review URL: http://codereview.chromium.org/3014056 Review URL: http://codereview.chromium.org/3121007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55692 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Clean up some headers in tab_contents_delegate.h.erg@google.com2010-08-101-0/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3145001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55635 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 55548 - Reland r55382. When blocking cookies, also show an icon in ↵jochen@chromium.org2010-08-101-25/+4
| | | | | | | | | | | | | | | | | | the location bar when cookies are accessed. If the user choses to block cookies per default, this will grant access to the collected cookies dialog as soon as the page accesses cookies. Right now, the icon is only shown if cookies were actually blocked. BUG=45230 TEST=Canned*.*:ContentSettingImage*.*:TabSpecific*.* Review URL: http://codereview.chromium.org/3014056 Review URL: http://codereview.chromium.org/3148002 TBR=jochen@chromium.org Review URL: http://codereview.chromium.org/3132003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55553 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r55382. When blocking cookies, also show an icon in the location bar ↵jochen@chromium.org2010-08-101-4/+25
| | | | | | | | | | | | | | | when cookies are accessed. If the user choses to block cookies per default, this will grant access to the collected cookies dialog as soon as the page accesses cookies. Right now, the icon is only shown if cookies were actually blocked. BUG=45230 TEST=Canned*.*:ContentSettingImage*.*:TabSpecific*.* Review URL: http://codereview.chromium.org/3014056 Review URL: http://codereview.chromium.org/3148002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55548 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 55536 - Reland r55382. When blocking cookies, also show an icon in ↵jochen@chromium.org2010-08-101-25/+4
| | | | | | | | | | | | | | | | | | the location bar when cookies are accessed. If the user choses to block cookies per default, this will grant access to the collected cookies dialog as soon as the page accesses cookies. Right now, the icon is only shown if cookies were actually blocked. BUG=45230 TEST=Canned*.*:ContentSettingImage*.*:TabSpecific*.* Review URL: http://codereview.chromium.org/3014056 Review URL: http://codereview.chromium.org/3146003 TBR=jochen@chromium.org Review URL: http://codereview.chromium.org/3127002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55540 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r55382. When blocking cookies, also show an icon in the location bar ↵jochen@chromium.org2010-08-101-4/+25
| | | | | | | | | | | | | | | when cookies are accessed. If the user choses to block cookies per default, this will grant access to the collected cookies dialog as soon as the page accesses cookies. Right now, the icon is only shown if cookies were actually blocked. BUG=45230 TEST=Canned*.*:ContentSettingImage*.*:TabSpecific*.* Review URL: http://codereview.chromium.org/3014056 Review URL: http://codereview.chromium.org/3146003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55536 0039d316-1c4b-4281-b951-d872f2087c98
* Speculative backout to see if this caused perf regressions.rohitrao@chromium.org2010-08-091-25/+4
| | | | | | | | | | | | | | | | Revert 55382 - When blocking cookies, also show an icon in the location bar when cookies are accessed. If the user choses to block cookies per default, this will grant access to the collected cookies dialog as soon as the page accesses cookies. Right now, the icon is only shown if cookies were actually blocked. BUG=45230 TEST=Canned*.*:ContentSettingImage*.*:TabSpecific*.* Review URL: http://codereview.chromium.org/3014056 TBR=jochen@chromium.org Review URL: http://codereview.chromium.org/3095009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55426 0039d316-1c4b-4281-b951-d872f2087c98
* When blocking cookies, also show an icon in the location bar when cookies ↵jochen@chromium.org2010-08-091-4/+25
| | | | | | | | | | | | | are accessed. If the user choses to block cookies per default, this will grant access to the collected cookies dialog as soon as the page accesses cookies. Right now, the icon is only shown if cookies were actually blocked. BUG=45230 TEST=Canned*.*:ContentSettingImage*.*:TabSpecific*.* Review URL: http://codereview.chromium.org/3014056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55382 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce a resource identifier for content settings.jochen@chromium.org2010-08-061-1/+2
| | | | | | | | | | | This will allow for having per plugin content settings, i.e. the content settings type would be plugin and the resource identifier would be to concrete plugin that is about to be loaded. BUG=39252 TEST=unit_tests Review URL: http://codereview.chromium.org/2878075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55213 0039d316-1c4b-4281-b951-d872f2087c98
* Add "Load all plugins on this page" button to blocked plugins bubble if ↵bauerb@chromium.org2010-08-031-0/+43
| | | | | | | | | | | | | | | click-to-play is enabled. Screenshot: http://imgur.com/ZKsQB.png XIB changes: Add a rounded rect button hooked up to |loadAllPlugins:| in the File's Owner and referenced by its |loadAllPluginsButton_| outlet, wrapped in a GTMWidthBasedTweaker. BUG=49677 TEST=ContentSettingBubbleModelTest.* Review URL: http://codereview.chromium.org/3015036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54720 0039d316-1c4b-4281-b951-d872f2087c98
* Flip the default for the cookie prompt to disabled.jochen@chromium.org2010-07-311-2/+2
| | | | | | | | | BUG=50083 TEST=none Review URL: http://codereview.chromium.org/3030033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54461 0039d316-1c4b-4281-b951-d872f2087c98
* Command line flag to disable the cookie prompt.jochen@chromium.org2010-07-301-1/+5
| | | | | | | | | | | | | The XIB change re-introduces the cookie tab view item with the "ask" setting as additinoal tab view item. The controller deletes the one not required according to the command line flag. BUG=50083 TEST=none Review URL: http://codereview.chromium.org/3075013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54308 0039d316-1c4b-4281-b951-d872f2087c98
* Preparatory work for adding content exceptions from the tab cookie view.bauerb@chromium.org2010-07-191-10/+2
| | | | | | | | Factor out HostContentSettingsMap::AddExceptionForURL() and add CookieTreeOriginNode::CreateContentException(). Review URL: http://codereview.chromium.org/2868059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52888 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r52486. Display a tab modal dialog of the allowed/blocked cookies.jochen@chromium.org2010-07-161-1/+8
| | | | | | | | | BUG=45230 TEST=CollectedCookiesTest.* Review URL: http://codereview.chromium.org/3034007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52655 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 52486 - Display a tab modal dialog of the allowed/blocked cookies.dmaclach@chromium.org2010-07-151-8/+1
| | | | | | | | | | | | BUG=45230 TEST=CollectedCookiesTest.* Review URL: http://codereview.chromium.org/2907003 TBR=jochen@chromium.org Review URL: http://codereview.chromium.org/3016003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52505 0039d316-1c4b-4281-b951-d872f2087c98
* Display a tab modal dialog of the allowed/blocked cookies.jochen@chromium.org2010-07-151-1/+8
| | | | | | | | | BUG=45230 TEST=CollectedCookiesTest.* Review URL: http://codereview.chromium.org/2907003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52486 0039d316-1c4b-4281-b951-d872f2087c98
* Display an info link in the blocked cookies info bubble.jochen@chromium.org2010-07-061-2/+36
| | | | | | | | | | | | | The link will pop up a dialog that displays the cookies blocked and accessed by the current page. The XIB change adds a link-styled button (cell type HyperlinkButtonCell) below the title and above the horizontal line on the bubble with the text IDS_BLOCKED_COOKIES_INFO. The button action is hooked up to showMoreInfo: in the File's Owner. BUG=45230 TEST=none Review URL: http://codereview.chromium.org/2799012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51656 0039d316-1c4b-4281-b951-d872f2087c98
* Store blocked and accessed cookies in the tab contents.jochen@chromium.org2010-07-021-2/+6
| | | | | | | | | | | This will enable chrome to display all cookies used/blocked on the current site to the user instead of just the information that something was blocked. The cookies are collected in data structures suitable for displaying them using the cookies tree model. BUG=45230 TEST=none Review URL: http://codereview.chromium.org/2370001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51545 0039d316-1c4b-4281-b951-d872f2087c98
* Add notifications content settings type.thakis@chromium.org2010-07-011-0/+6
| | | | | | | | | | | Not used anywhere yet, no functionality change. BUG=45547 TEST=none Review URL: http://codereview.chromium.org/2815042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51432 0039d316-1c4b-4281-b951-d872f2087c98
* Change a bunch of string types.estade@chromium.org2010-06-291-1/+1
| | | | | | | | | | | | | Started out just trying to change PrefService::GetString and ::SetString. This snowballed a little bit. Had to change a bunch of url strings in search_engines/ from wstring to string (some of them may be better off as GURLs, but UTF-8 is a step in the right direction, since that's what GURL uses internally, as well as externally via its setters/getters). TODO (later patch): things that ask for accepted languages should use std::string, not std::wstring. BUG=none TEST=try bots Review URL: http://codereview.chromium.org/2854015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51157 0039d316-1c4b-4281-b951-d872f2087c98
* Allow content setting changes in incognito mode.jochen@chromium.org2010-06-251-2/+0
| | | | | | | | | | | This removes the logic to disable the "remeber" functions in the UI elements (basically reverting r44084, but leaves the incognito host content setting map in place. Changes to this map are allowed but do not get stored in preferences. BUG=44480 TEST=none Review URL: http://codereview.chromium.org/2811025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50829 0039d316-1c4b-4281-b951-d872f2087c98
* Adds GeolocationSettingsStatebulach@chromium.org2010-05-111-42/+22
| | | | | | | | TEST=geolocation_settings_state_unittest.cc Review URL: http://codereview.chromium.org/1540034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46911 0039d316-1c4b-4281-b951-d872f2087c98
* Clear non-wildcard content settings before setting from bubble or prompt.jochen@chromium.org2010-04-261-0/+7
| | | | | | | | | BUG=42359 TEST=manual Review URL: http://codereview.chromium.org/1707011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45571 0039d316-1c4b-4281-b951-d872f2087c98
* Fix IDN urls in geolocation infobars and bubbles (but not exceptions dialog)joth@chromium.org2010-04-141-2/+6
| | | | | | | | | BUG=40278 TEST=As per adhoc method in the bug. Open infobar & bubble, check they show URL in arabic Review URL: http://codereview.chromium.org/1612017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44496 0039d316-1c4b-4281-b951-d872f2087c98
* Disable remember option in cookie prompt and content blocked notification ↵mnissler@chromium.org2010-04-091-0/+2
| | | | | | | | | | | bubbles when running OTR. BUG=37525 TEST=Manual, check cookie prompt and bubbles in OTR session Review URL: http://codereview.chromium.org/1629011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44084 0039d316-1c4b-4281-b951-d872f2087c98
* Simplify content settings bubble model "radio groups" to a single radio group.bulach@chromium.org2010-04-091-5/+5
| | | | | | | | | | | There's no longer a use case for multiple radio groups (was originally planned for Geolocation), simplify the model and its views. BUG=39073 TEST=content_setting_bubble_model_unittest Review URL: http://codereview.chromium.org/1575022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44070 0039d316-1c4b-4281-b951-d872f2087c98
* Implement patterns for content setting exceptions.jochen@chromium.org2010-04-081-2/+3
| | | | | | | | | BUG=37394 TEST=unit_tests + manual Review URL: http://codereview.chromium.org/1567010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43936 0039d316-1c4b-4281-b951-d872f2087c98
* Change the Clear these settings... link to be a reload page hint message ↵joth@chromium.org2010-04-071-6/+33
| | | | | | | | | | | | | | when a clear is pending. Also adds some unit tests for the geolocation bubble, and refactors the tests a bit to make this new test neater. BUG=40263 TEST=a) unit_tests --gtest_filter=ContentSettingBubbleModelTest* b) open a page using geolocation and test different combinations of global permission & exceptions for that page. Review URL: http://codereview.chromium.org/1605016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43844 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a geolocation tab in the content settings dialog (on Windows). Also ↵pkasting@chromium.org2010-03-301-4/+12
| | | | | | | | | | refactors the various views for this dialog in hopes of simplifying a few things. BUG=none TEST=Open content settings dialog, observe Location tab. (Note: Exceptions button is not wired up.) Review URL: http://codereview.chromium.org/1526004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43132 0039d316-1c4b-4281-b951-d872f2087c98
* Re-attempt at http://codereview.chromium.org/1344002joth@chromium.org2010-03-261-1/+68
| | | | | | | | | | | | | | | | Adds geolocaiton support to the location bar content image model and content bubble model. Most of these edits were lifted out of http://codereview.chromium.org/650180 TODO: add geolocation support to the views in the three UI platforms for the bubble model. (NOTE this change results in poorly formed bubble contents for the geolocaiton bubble, this will be fixed up in the following CLs) BUG=11246 TEST=open a site that uses geolocaiton, select allow/deny & click the icon. Review URL: http://codereview.chromium.org/1369002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42739 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 42665 - broke build as I missed a unit test when building locally.joth@chromium.org2010-03-251-68/+1
| | | | | | | | | | | | | | | | | | | | Adds geolocaiton support to the location bar content image model and content bubble model. Most of these edits were lifted out of http://codereview.chromium.org/650180 TODO: add geolocation support to the views in the three UI platforms for the bubble model. (NOTE this change results in poorly formed bubble contents for the geolocaiton bubble, this will be fixed up in the following CLs) BUG=11246 TEST=open a site that uses geolocaiton, select allow/deny & click the icon. Review URL: http://codereview.chromium.org/1344002 TBR=joth@chromium.org Review URL: http://codereview.chromium.org/1367002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42668 0039d316-1c4b-4281-b951-d872f2087c98
* Adds geolocaiton support to the location bar content image model and content ↵joth@chromium.org2010-03-251-1/+68
| | | | | | | | | | | | | | | | | | bubble model. Most of these edits were lifted out of http://codereview.chromium.org/650180 TODO: add geolocation support to the views in the three UI platforms for the bubble model. (NOTE this change results in poorly formed bubble contents for the geolocaiton bubble, this will be fixed up in the following CLs) BUG=11246 TEST=open a site that uses geolocaiton, select allow/deny & click the icon. Review URL: http://codereview.chromium.org/1344002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42665 0039d316-1c4b-4281-b951-d872f2087c98
* Adds ContentSettingBubbleModel.bulach@chromium.org2010-03-091-0/+188
Review URL: http://codereview.chromium.org/668075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41021 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-10 20:29:07 +0000