summaryrefslogtreecommitdiffstats
path: root/chrome/browser/cookie_modal_dialog.h
Commit message (Collapse)AuthorAgeFilesLines
* Reland 43183. Block database access on allowDatabase instead of ↵jochen@chromium.org2010-03-311-0/+6
| | | | | | databaseOpenFile. BUG=36435 TEST=Set cookie settings to ASK and open a page with web databases. Review URL: http://codereview.chromium.org/1338001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43185 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 43183 - Block database access on allowDatabase instead of ↵jochen@chromium.org2010-03-311-6/+0
| | | | | | | | | | | | | | databaseOpenFile. BUG=36435 TEST=Set cookie settings to ASK and open a page with web databases. Review URL: http://codereview.chromium.org/1338001 TBR=jochen@chromium.org Review URL: http://codereview.chromium.org/1595003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43184 0039d316-1c4b-4281-b951-d872f2087c98
* Block database access on allowDatabase instead of databaseOpenFile.jochen@chromium.org2010-03-311-0/+6
| | | | | | | | | BUG=36435 TEST=Set cookie settings to ASK and open a page with web databases. Review URL: http://codereview.chromium.org/1338001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43183 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Make cookie prompt dialog more Mac-likedanno@chromium.org2010-03-251-2/+2
| | | | | | | | | | | | | | | | | | | | | | | As per Alcor's recommendations, customize the Mac cookie prompt so that it is a less like windows/linux but more "maccy": add application icon for modal dialog, change layout and make radio buttons in "remember" choice small rather than regular. Also added unit tests. xib changes: - Add application icon to cookie prompt dialog, shifting all other elements to the right accordingly. - Change the size of the radio buttons in the "remember" choice to be small rather than regular. - Change the default text in in the information NSTextField to "Label" rather than a really long nonsensical debug string - Move the details view to be below the accept/block buttons. - Change the style of the disclosure control to be a button rather than triangle. Before: http://img257.yfrog.com/img257/3066/picture3fx.png After: http://img214.imageshack.us/img214/5553/picture9es.png and http://img200.imageshack.us/img200/1558/picture10pm.png BUG=38208 TEST=manual testing, added unit test for remember/block/accept controls Review URL: http://codereview.chromium.org/1102005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42597 0039d316-1c4b-4281-b951-d872f2087c98
* Put up a prompt to create appcaches if the Content Settings indicate to do ↵michaeln@chromium.org2010-03-241-9/+11
| | | | | | | | | | | so. Done for windows and linux (sorry mac, you're out of luck). Also put in place a GenericInfoView class. BUG=38362 TEST=manual and generic_info_view_unittest.cc Review URL: http://codereview.chromium.org/1115005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42525 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] augment modal cookie prompt on mac to include details panedanno@chromium.org2010-03-121-0/+17
| | | | | | | | | | | | | | | | Added two new xibs. The first is a cookie info view that is shared between the tree that shows browser data and the cookie modal prompt to block accepting cookies. The second is a window to replace the NSAlert modal dialog for the cookie prompt. Modified cookie tree code and added cookie prompt code to use new xibs. Changed "hidden" handling of cookie detail view to use bindings rather than explicit code. TODOs for http://crbug.com/36948 not in this CL: - changing the expiration for cookies isn't implemented TEST=manually testing of modal cookie prompt, new unit tests BUG=http://crbug.com/36948 Review URL: http://codereview.chromium.org/669127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41408 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Add modal cookies confirmation prompt.erg@chromium.org2010-02-241-0/+5
| | | | | | | | | BUG=35178,36183 TEST=none Review URL: http://codereview.chromium.org/652172 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39914 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Cookie confirmation dialog.thakis@chromium.org2010-02-241-0/+3
| | | | | | | | | | | | | This is not the final UI (the "more info" disclosure triangle is missing), but it's pretty close and, more importantly, functional. BUG=34894 TEST=Go to Preferences->under the hood->content settings->cookies and select "ask me every time". Then browser around and note that a message box pops up all the time. All the buttons on the message box should do what they claim. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=39756 Review URL: http://codereview.chromium.org/650206 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39867 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 39756 - Mac: Cookie confirmation dialog.thakis@chromium.org2010-02-231-3/+0
| | | | | | | | | | | | | | This is not the final UI (the "more info" disclosure triangle is missing), but it's pretty close and, more importantly, functional. BUG=34894 TEST=Go to Preferences>under the hood>content settings>cookies and select "ask me every time". Then browser around and note that a message box pops up all the time. All the buttons on the message box should do what they claim. Review URL: http://codereview.chromium.org/650206 TBR=thakis@chromium.org Review URL: http://codereview.chromium.org/652150 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39766 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Cookie confirmation dialog.thakis@chromium.org2010-02-231-0/+3
| | | | | | | | | | | This is not the final UI (the "more info" disclosure triangle is missing), but it's pretty close and, more importantly, functional. BUG=34894 TEST=Go to Preferences->under the hood->content settings->cookies and select "ask me every time". Then browser around and note that a message box pops up all the time. All the buttons on the message box should do what they claim. Review URL: http://codereview.chromium.org/650206 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39756 0039d316-1c4b-4281-b951-d872f2087c98
* Pass in the HostContentSettingsMap to the CookieModalDialog so IsValid can ↵jorlow@chromium.org2010-02-201-1/+10
| | | | | | | | | | | | | | | make its decision. Before, it used the TabContents to get the profile to get the map, but this was incorrect because the current tab isn't necessarily from the same profile as the original request. As long as we have the HostContentSettingsMap, we might as well handle "remember" in CookieModalDialog. This bug exists in 4.1. TEST=none BUG=none Review URL: http://codereview.chromium.org/651023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39558 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes two bugs in cookie prompting:sky@chromium.org2010-02-181-0/+1
| | | | | | | | | | | | | | | | | | . In certain situations we could crash because we weren't letting CookiePromptView::Init complete and then attempting to reference some NULL fields. I've fixed this by adding AppModalDialog::IsValid and moving the logic that was in Init to IsValid. This way we only create CookiePromptView when needed. . We were leaking AppModalDialogs. I've made CookiePromptView own the AppModalDialog and delete it when the CookiePromptView is deleted. BUG=36079 TEST=enable prompting for cookies, go to a bunch of sites make sure you don't crash. Review URL: http://codereview.chromium.org/632006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39328 0039d316-1c4b-4281-b951-d872f2087c98
* When we're initializing the modal dialog box which asks whether the page has ↵jorlow@chromium.org2010-02-171-1/+2
| | | | | | | | | | | | | | permission to access a "cookie", double check that the value has not since been set. If it has, close the window before it's even shown. This is a stop-gap solution. We should probably come up with something more elegent long term. TEST=Go to a page that starts a database transaction and immediately sets a local storage value. You should get one prompt instead of 2. BUG=36006 Review URL: http://codereview.chromium.org/619009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39270 0039d316-1c4b-4281-b951-d872f2087c98
* Implement CONTENT_SETTING_ASK for database. Also some cleanup of the dialog ↵jorlow@chromium.org2010-02-171-10/+21
| | | | | | | | | | | for local storage. BUG=34628 TEST=none Review URL: http://codereview.chromium.org/605028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39214 0039d316-1c4b-4281-b951-d872f2087c98
* Make the setItem CONTENT_SETTING_ASK dialog more useful by showing the ↵jorlow@chromium.org2010-02-121-10/+26
| | | | | | | | | | | | | actual key and value. Unfortunately, we're going to have to abuse cookie strings for 4.1 Once this goes in, I'll add new strings for the actual fields. This also cleans up the code some. TEST=Instead of size/modified information you'll see "name" and "content" in the dialog that comes up when asking whether to allow local storage. BUG=none Review URL: http://codereview.chromium.org/597061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38952 0039d316-1c4b-4281-b951-d872f2087c98
* Couple of tweaks to the cookie prompt dialog:sky@chromium.org2010-02-101-0/+3
| | | | | | | | | | | | | | | . Fixes bug that lead to randomly expanding and not (expanded_view_ wasn't in the member initializer list). . Fixed bug where expanding/collapsing would result in dialog changing to wrong size. . Persist expanded state to prefs. BUG=35092, 35165 TEST=see bugs Review URL: http://codereview.chromium.org/595014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38622 0039d316-1c4b-4281-b951-d872f2087c98
* Show an app modal dialog when the cookie policy is ASK.darin@chromium.org2010-02-081-3/+3
| | | | | | | | | | | | This hooks up the dialog for cookies and localstorage. It also includes support for remembering the decision, and in the case of cookies, support is added for forcing a cookie to be a stored as a session cookie. BUG=34625,34572 Review URL: http://codereview.chromium.org/583004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38393 0039d316-1c4b-4281-b951-d872f2087c98
* Refactored out JS specific part of modal dialog stack into its own class, ↵zelidrag@chromium.org2010-02-051-0/+65
exposed cookie/storage prompt as a modal dialog. BUG=32719 TEST=none, requires Darin to hook this with his code. Review URL: http://codereview.chromium.org/560030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38268 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-18 11:10:20 +0000