summaryrefslogtreecommitdiffstats
path: root/chrome/browser/debugger/devtools_window.h
Commit message (Collapse)AuthorAgeFilesLines
* Get rid of a bunch of tab_contents.h includes from chrome. These are all ↵jam@chromium.org2012-01-041-1/+1
| | | | | | | | | trivial changes to use WebContents instead of TabContents. BUG=98716 Review URL: http://codereview.chromium.org/9030032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116392 0039d316-1c4b-4281-b951-d872f2087c98
* Replace most of Browser::GetSelectedTabContents calls into ↵jam@chromium.org2012-01-031-1/+3
| | | | | | | | | | | | Browser::GetSelectedWebContents. I've converted the easy ones, I'll do the ones with more dependencies in a separate change to keep things trivial to review. I considered taking out GetSelectedTabContents altogether and having people just use GetSelectedTabContentsWrapper()->web_contents() per the existing comment in browser.h, but there are a lot of callers and it seemed too long to type. BUG=98716 TBR=joi Review URL: http://codereview.chromium.org/9015022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116122 0039d316-1c4b-4281-b951-d872f2087c98
* TBR=jampfeldman@chromium.org2011-12-291-0/+1
| | | | | | | | John: I've added a method and a message in the devtools subsystem. Review URL: http://codereview.chromium.org/9008043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115967 0039d316-1c4b-4281-b951-d872f2087c98
* Convert all of the WebContentsDelegate to use WebContents instead of ↵jam@chromium.org2011-12-281-3/+3
| | | | | | | | | | TabContents, and update all the dependent code. BUG=98716 TBR=joi Review URL: http://codereview.chromium.org/9008047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115932 0039d316-1c4b-4281-b951-d872f2087c98
* Move the PageNavigator interface and GlobalRequestID struct to ↵jam@chromium.org2011-12-281-2/+3
| | | | | | | | | | content\public and put them in the content namespace. Make PageNavigator use WebContents instead of TabContents. While I'm touching all the callers, I've removed the deprecated PageNavigator function and converted users to the new one. BUG=98716 TBR=joi Review URL: http://codereview.chromium.org/8991012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115858 0039d316-1c4b-4281-b951-d872f2087c98
* Convert SpeechInputBubble and BalloonHost to use WebContents instead of ↵jam@chromium.org2011-12-271-1/+1
| | | | | | | | | | TabContents, as well as all the dependent code. BUG=98716 TBR=joi Review URL: http://codereview.chromium.org/9016038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115810 0039d316-1c4b-4281-b951-d872f2087c98
* Move TabContentsDelegate to content/public/browser and put it in the content ↵tfarina@chromium.org2011-12-201-3/+3
| | | | | | | | | | | | | | namespace. - Rename TabContentsDelegate to WebContentsDelegate and move it to web_contents_delegate.* BUG=98716,105875 R=jam@chromium.org TBR=avi@chromium.org Review URL: http://codereview.chromium.org/9008013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115213 0039d316-1c4b-4281-b951-d872f2087c98
* Remove deprecated TabContentsDelegate::OpenURLFromTab variantjochen@chromium.org2011-12-021-7/+0
| | | | | | | | | | BUG=105028 TEST=no functional change Review URL: http://codereview.chromium.org/8772041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112706 0039d316-1c4b-4281-b951-d872f2087c98
* Define DevTools content APIyurys@chromium.org2011-12-011-10/+16
| | | | | | | | | | | | | | | The API consists of the following parts: * DevToolsManager routes messages between devtools agents and clients * DevToolsAgentHost provides an abstract interface to the debuggee, currently it is either RenderViewHost or Shared Worker. Client can obtain DevToolsAgentHost from DevToolsAgentHostRegistry. * DevToolsClientHost is an API that should be implemented by DevTools front-end. There is a default Chromium implementation living in chrome/ and a remote debugging server which also implements this interface. Clients can extend it in order to provide custom front-end. There is a default DevTools front-end implementation and content/ provides a way for creating corresponding DevToolsClientHost by means of DevToolsClientHost::CreateDevToolsFrontendHost. The embedder just needs to provide a concrete delegate. * This patch also removes DevToolsHost_ForwardToAgent and DevToolsHost_ForwardToClient IPC messages which were used to forward only one message. DevTools IPC messages are now hidden behind the devtools content API. BUG=104625 TEST=Existing tests Review URL: http://codereview.chromium.org/8549022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112473 0039d316-1c4b-4281-b951-d872f2087c98
* Move DevTools front-end IPC message handling to contentyurys@chromium.org2011-12-011-14/+11
| | | | | | | | | BUG=104625 TEST=Existing tests Review URL: http://codereview.chromium.org/8729024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112415 0039d316-1c4b-4281-b951-d872f2087c98
* Move RenderViewHostObserver to content/public/browser/ and put it into the ↵tfarina@chromium.org2011-11-251-7/+6
| | | | | | | | | | | content namespace. BUG=98716 R=jam@chromium.org Review URL: http://codereview.chromium.org/8676032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111604 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: remove obsolete methods from DevToolsClientHostyurys@chromium.org2011-11-221-2/+1
| | | | | | | | | BUG=104625 TEST=Existing tests Review URL: http://codereview.chromium.org/8636011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111139 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "DevTools: remove obsolete methods from DevToolsClientHost"yurys@chromium.org2011-11-221-0/+2
| | | | | | | | | | | This reverts commit 111135 BUG= TEST= Review URL: http://codereview.chromium.org/8636010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111137 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: remove obsolete methods from DevToolsClientHostyurys@chromium.org2011-11-221-2/+0
| | | | | | | | | BUG=None TEST=Existing tests Review URL: http://codereview.chromium.org/8634006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111135 0039d316-1c4b-4281-b951-d872f2087c98
* Add OVERRIDE to chrome/browser/.avi@chromium.org2011-11-211-12/+14
| | | | | | | | | BUG=104314 TEST=no change Review URL: http://codereview.chromium.org/8612007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110939 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Make detached DevTools window draggable by the titlebar - Chrome-side ↵asvitkine@chromium.org2011-11-101-0/+1
| | | | | | | | | | | | | | | plumbing. This depends on WebKit change: https://bugs.webkit.org/show_bug.cgi?id=71842 Also, sprinkle OVERRIDE all over devtools_client.h. BUG=44350 TEST=Open DevTools in undocked mode on the Mac. Drag the window by the empty space in the toolbar. The window should move. Review URL: http://codereview.chromium.org/8503022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109425 0039d316-1c4b-4281-b951-d872f2087c98
* Implement inspect action for workers in Task Manageryurys@chromium.org2011-11-021-0/+4
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/8423040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108279 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the asan fix.joaodasilva@chromium.org2011-10-201-1/+1
| | | | | | | | | | | | | | ChromeRenderViewHostObserver needs the value of render_view_host when cleaning up, but the user-after-free fix made render_view_host() always NULL in the dtor. The previous fix was http://codereview.chromium.org/8354034/ TBR=jam@chromium.org TEST=asan bots are happy Review URL: http://codereview.chromium.org/8352049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106509 0039d316-1c4b-4281-b951-d872f2087c98
* Move NotificationObserver, NotificationSource, and NotificationDetails to ↵jam@chromium.org2011-10-191-7/+7
| | | | | | | | | | | content/public/browser. This patch got way bigger than I wanted, but once I moved NotificationDetails, I figured I might as well mvoe the others since they're in the same files. In hindsight, I should have converted a subset of files at a time by leaving a using statement in the header. BUG=98716 TBR=joi git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106196 0039d316-1c4b-4281-b951-d872f2087c98
* Move PageTransition into content namespace. While I'm touching all these ↵jam@chromium.org2011-10-131-1/+1
| | | | | | | | | files, I've also updated it to use the enum naming convention in the Content API. BUG=98716 Review URL: http://codereview.chromium.org/8253002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105254 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: introduce WorkderDevToolsAgentHostyurys@chromium.org2011-09-081-1/+0
| | | | | | | | | | | | | | We already have RenderViewDevToolsAgent host for inspected pages. This patch introduces WorkderDevToolsAgentHost which implements DevToolsAgentHost interface for inspected shared workers. Also this patch moves part of devtools message routing for workers to DevToolsManager. BUG=None TEST=Existing DevTools tests Review URL: http://codereview.chromium.org/7737026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100112 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools handler now handles messages from both client and agent and is ↵yurys@chromium.org2011-08-311-11/+25
| | | | | | | | | | | created for all new render_view_hosts. This patch moves handling of IPC messages from agent to RenderViewDevToolsAgentHost and handling of client IPC messages to DevToolsWindow. BUG=None TEST=Existing DevTools tests Review URL: http://codereview.chromium.org/7778010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98964 0039d316-1c4b-4281-b951-d872f2087c98
* This is only the first part of the refactoring. The old method was preservedadriansc@google.com2011-08-021-1/+4
| | | | | | | | | | | | | | | | | | | | and not all call points were changed. The second part will deal with factoring out the old OpenURL method. Overall purpose: speed up calls, make it more flexible to plumb parameters to the call chain, reduce code repetition. It is necessary to add one more parameter (namely, override_encoding) to OpenURL in order to be able to restore the page encoding upon loading the contents. For solving this issue, it is necessary for the encoding to be restored from the BookmarkModel. BUG=2926 Review URL: http://codereview.chromium.org/7388007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95013 0039d316-1c4b-4281-b951-d872f2087c98
* Make PageNavigator::OpenURL and TabContentsDelegate::OpenURLFromTab return a ↵jochen@chromium.org2011-07-201-5/+6
| | | | | | | | | | | | | | TabContents The TabContents object is the one in which the URL will be opened if it can be determined immediately. BUG=none TEST=compiles Review URL: http://codereview.chromium.org/7343013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93275 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: bulk move of legacy protocol back to chrome/.pfeldman@chromium.org2011-07-201-5/+5
| | | | | | Review URL: http://codereview.chromium.org/7458015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93182 0039d316-1c4b-4281-b951-d872f2087c98
* Follow up to r93173: fixing check_deps and clangpfeldman@chromium.org2011-07-201-3/+3
| | | | | | Review URL: http://codereview.chromium.org/7453019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93176 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: move devtools_window to chrome/, remove most chrome/ dependencies ↵pfeldman@chromium.org2011-07-201-0/+129
| | | | | | | | | | | from devtools_manager. BUG= TEST= Review URL: http://codereview.chromium.org/7429006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93173 0039d316-1c4b-4281-b951-d872f2087c98
* Wholesale move of debugger sources to content.joi@chromium.org2011-06-291-110/+0
| | | | | | | | | | | | | | | | | Other references are modified only to point to the new location. Follow-up changes will move build rules for the debugger into content. This adds a somewhat permissive DEPS file to content/browser/debugger. Follow-up work will whittle that down to zero dependencies on chrome/. BUG=84078 TEST=existing Review URL: http://codereview.chromium.org/7274031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90912 0039d316-1c4b-4281-b951-d872f2087c98
* Moves NavigationController::session_id into RestoreTabHelper.sky@chromium.org2011-06-141-1/+1
| | | | | | | | | | BUG=none TEST=none R=nick@chromium.org,mpcomplete@chromium.org,jam@chromium.org Review URL: http://codereview.chromium.org/7104064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89083 0039d316-1c4b-4281-b951-d872f2087c98
* Browser::Type cleanup.jianli@chromium.org2011-05-051-1/+1
| | | | | | | | | | BUG=None TEST=Existing tests R=ben@chromium.org,stevenjb@chromium.org,phajdan.jr@chromium.org Review URL: http://codereview.chromium.org/6697032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84303 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the TabContentsDelegate::ToolbarSizeChanged() method as no one was ↵pkasting@chromium.org2011-04-151-1/+0
| | | | | | | | | | using it. Rename BrowserWindow::SelectedTabToolbarSizeChanged() to ToolbarSizeChanged() as there are no per-tab toolbars since we made the DownloadShelf per-window a while ago. BUG=none TEST=none Review URL: http://codereview.chromium.org/6870002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81834 0039d316-1c4b-4281-b951-d872f2087c98
* Added support for opening urls from devtools window.vsevik@chromium.org2011-04-151-1/+1
| | | | | | | | | BUG=77533 TEST=Select any text in DevTools(docked)/Network/Headers, open context menu, select "Go to ..."/"Search Google for ..", ensure new tab opens in browser. Review URL: http://codereview.chromium.org/6810018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81728 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: fix exception in console during DevTools startupyurys@chromium.org2011-04-071-1/+1
| | | | | | | | | | | When opening DevTools window there is an exception in the console: "Uncaught ReferenceError: WebInspector is not defined" because some commands are sent to the front-end before it's loaded. BUG=None TEST=Open DevTools window, you should see no exceptions in the console Review URL: http://codereview.chromium.org/6801044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80767 0039d316-1c4b-4281-b951-d872f2087c98
* Moves instant related methods off TabContents and to where they are used.sky@chromium.org2011-03-251-1/+1
| | | | | | | | | | R=estade@chromium.org,avi@chromium.org BUG=77091 TEST=none Review URL: http://codereview.chromium.org/6729010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79447 0039d316-1c4b-4281-b951-d872f2087c98
* Update a bunch of files to the new location of notification files.tfarina@chromium.org2011-03-081-2/+2
| | | | | | | | | | | First part of the remaining files. BUG=None TEST=None Review URL: http://codereview.chromium.org/6649001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77330 0039d316-1c4b-4281-b951-d872f2087c98
* Update more includes that were pointing to the old locations.jam@chromium.org2011-03-021-1/+1
| | | | | | | TBR=avi Review URL: http://codereview.chromium.org/6598086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76512 0039d316-1c4b-4281-b951-d872f2087c98
* Remove wstring from RVH's run Javascript command.avi@chromium.org2011-02-091-1/+1
| | | | | | | | | BUG=23581 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/6458013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74362 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 74118 - Remove wstring from RVH's run Javascript command.avi@chromium.org2011-02-081-1/+1
| | | | | | | | | | | | BUG=23581 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/6312154 TBR=avi@chromium.org Review URL: http://codereview.chromium.org/6459002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74158 0039d316-1c4b-4281-b951-d872f2087c98
* Remove wstring from RVH's run Javascript command.avi@chromium.org2011-02-081-1/+1
| | | | | | | | | BUG=23581 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/6312154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74118 0039d316-1c4b-4281-b951-d872f2087c98
* Move bookmark star from TabContents to TabContentsWrapper.avi@chromium.org2011-02-041-1/+0
| | | | | | | | | BUG=71097 TEST=Hammer on bookmark star on all platforms. Nothing should crash, break, or have any user-visible change. Review URL: http://codereview.chromium.org/6334066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73836 0039d316-1c4b-4281-b951-d872f2087c98
* Submitting http://codereview.chromium.org/6383011/ on behalf of serya@ :zelidrag@chromium.org2011-02-031-1/+2
| | | | | | | | | | | Prevent DevTools of been docked to a popup window. BUG=chromium-os:11078 TEST=Try to inspect element of a popup window (such as a Google Talk chat). Dock DevTools to a regular window. Review URL: http://codereview.chromium.org/6312093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73579 0039d316-1c4b-4281-b951-d872f2087c98
* TabContents::OnStartDownload crash.pfeldman@chromium.org2011-02-011-1/+1
| | | | | | | | | BUG=68522 TEST= Review URL: http://codereview.chromium.org/6260061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73285 0039d316-1c4b-4281-b951-d872f2087c98
* Makes devtools handle tab replaced notification. Thissky@chromium.org2011-01-311-1/+1
| | | | | | | | | | | | | | | | | works, but it causes a rather noticable flash as the inspector reloads. Do you have a suggestion of making it not do that? For background, when instant is enabled as you type in the omnibox a new tabcontents is created and overlaid on top of the existing tab. If the user presses enter or clicks on the page the instant tab replaced the old tab. BUG=68685 TEST=none Review URL: http://codereview.chromium.org/6172002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73217 0039d316-1c4b-4281-b951-d872f2087c98
* Bring back 'navigated' notification for --remote-shell-port protocolyurys@chromium.org2011-01-251-0/+2
| | | | | | Review URL: http://codereview.chromium.org/6094004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72498 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded includes of notification_service.h in other headers.thestig@chromium.org2010-12-151-2/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5783006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69321 0039d316-1c4b-4281-b951-d872f2087c98
* Even more virtual method deinlining.erg@google.com2010-12-131-1/+1
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/5741001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69041 0039d316-1c4b-4281-b951-d872f2087c98
* Make pink's TabContentsWrapper change compile on Windows.ben@chromium.org2010-11-181-3/+3
| | | | | | | | | | Code by pinkerton@, with modifications by evanm and myself to get it to build on windows/linux/chromeos. BUG=none TEST=none Review URL: http://codereview.chromium.org/4694008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66626 0039d316-1c4b-4281-b951-d872f2087c98
* Switch to inspected page tab when opening DevTools in docked mode.caseq@google.com2010-10-091-0/+1
| | | | | | | | | | | Open, not toggle, DevTools upon click on active view on chrome://extensions BUG=http://crbug.com/57217 TEST=none Review URL: http://codereview.chromium.org/3570018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62075 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding a previous CL (I fixed the ChromeOS build):jcivelli@chromium.org2010-08-231-0/+1
| | | | | | | | | | | | | | | Making window.focus()/blur() work only when there is a user gesture. Also making window.focus() select tab if it is not visible. The RenderViewHost now calls ActivateContent and the new DeactivateContent (instead of using the recently added TabContentsDelegate::Activate/Deactivate methods which have been removed). TBR=darin,sky BUG=29643,52346 TEST=Create a page with buttons that call window.focus()/blur() directly and with a timeout. When called directly, the calls should succeed (the browser should be activated/deactivated). When called with a timeout, nothing should happen. Also test that a popup calling window.opener.focus() cause the opening tab to become selected when it is not the current tab. Review URL: http://codereview.chromium.org/3174030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57124 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 57094 - Making window.focus()/blur() work only when there is a user ↵jcivelli@chromium.org2010-08-231-1/+0
| | | | | | | | | | | | | | | | | gesture. Also making window.focus() select tab if it is not visible. The RenderViewHost now calls ActivateContent and the new DeactivateContent (instead of using the recently added TabContentsDelegate::Activate/Deactivate methods which have been removed). BUG=29643,52346 TEST=Create a page with buttons that call window.focus()/blur() directly and with a timeout. When called directly, the calls should succeed (the browser should be activated/deactivated). When called with a timeout, nothing should happen. Also test that a popup calling window.opener.focus() cause the opening tab to become selected when it is not the current tab. Review URL: http://codereview.chromium.org/3156016 TBR=jcivelli@chromium.org Review URL: http://codereview.chromium.org/3201008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57105 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-10 00:38:03 +0000