summaryrefslogtreecommitdiffstats
path: root/chrome/browser/debugger
Commit message (Collapse)AuthorAgeFilesLines
* Reland r41641 "Make DevTools open docked by default..."xiyuan@chromium.org2010-03-222-2/+6
| | | | | | | | | | | | | | - Fix DevToolsSanityTest time out. The timeout is because the tests wait for Browser closed notification. However, docked DevTools does not have its own Browser object and hence the wait times out. BUG=none TEST=none Review URL: http://codereview.chromium.org/1025005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42226 0039d316-1c4b-4281-b951-d872f2087c98
* Repair remote debuggingyurys@chromium.org2010-03-181-2/+2
| | | | | | | | | | | | | | | | Original change http://codereview.chromium.org/982008 by luoyx. Change the first letter of two const strings to lowercase, to make them consistent with message from WebKit. Otherwise, debugger output messages won't be pushed out to remote clients. Contributed by Yuxiang Luo (luoyx@google.com) BUG=38387 TEST=Attach a remote debugger client to chrome, then open a testing page that has exception. Make sure exception information can be received. Review URL: http://codereview.chromium.org/1103001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41928 0039d316-1c4b-4281-b951-d872f2087c98
* Initial support for inspecting extension popups.rafaelw@chromium.org2010-03-171-0/+6
| | | | | | | | | | | | | | | | | | The primary change in this CL is a refactor which makes ExtensionPopup a bit more self-contained WRT its clients. It adds the ability to specify an "inspect_with_devtools" flag to its Show() method which will cause the popup to remain open regardless of losing focus and to focus a devtools window on the popup's render view host. This CL also pulls apart some aspects of the extension_popup_api from ExtensionFunctionDispatcher and ExtensionHost. Still remaining to be done are: 1) Also the popup to stay open when the host window drags (it current closes) 2) Support for GTK 3) Support for Mac BUG=24477 Review URL: http://codereview.chromium.org/1001002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41854 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Make DevTools open docked by default for chrome os."tony@chromium.org2010-03-161-1/+1
| | | | | | | | | | | This reverts commit r41641 because all the devtools interactive_ui_tests are failing. TBR=xiyuan Review URL: http://codereview.chromium.org/1007004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41691 0039d316-1c4b-4281-b951-d872f2087c98
* Make DevTools open docked by default for chrome os.xiyuan@chromium.org2010-03-151-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | - Change prefs::kDevToolsOpenDocked default to "true" for chrome os; - Fix a problem on chrome os that DevTools occupies the whole client area. This is because BrowserView::Show is called before gtk size allocated event and thus divider offset is calculated wrongly to 0. The fix is to move the "restore split offset" logic to UpdateDevToolsForContents before we do contents_split_ layout for show up DevTools; - Fix a problem that DevTools becomes invisible after undock then dock for linux toolkit_view/chromeos build. This is because browser/views/tab_contents/TabContentsViewGtk does not show/hide its contained TabContents like TabContentsViewWin. As mentioned in BrowserWindowGtk::UpdateDevToolsForContents, the fix is to hook up gtk show/hide signal and notify the contained TabContents about the visibility change. After the fix, remove the manual ShowContents for DevTools in BrowserWindowGtk::UpdateDevToolsForContents. <http://crosbug.com/333> BUG=333 TEST=Verify that DevTools show up as docked by default. Review URL: http://codereview.chromium.org/880003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41641 0039d316-1c4b-4281-b951-d872f2087c98
* More code cleanups found by -Wextra.evan@chromium.org2010-03-091-1/+1
| | | | | | | | (I'm still waiting on a v8 change to turn this on for the whole codebase...) Review URL: http://codereview.chromium.org/746001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41080 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 39450 - Disable 3 interactive tests for now. They started failing ↵dglazkov@chromium.org2010-02-191-6/+3
| | | | | | | | | | | | | | after the last WebKit roll. TEST=none BUG=36262 Review URL: http://codereview.chromium.org/651035 TBR=jorlow@chromium.org Review URL: http://codereview.chromium.org/650037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39454 0039d316-1c4b-4281-b951-d872f2087c98
* Disable 3 interactive tests for now. They started failing after the last ↵jorlow@chromium.org2010-02-191-3/+6
| | | | | | | | | | | WebKit roll. TEST=none BUG=36262 Review URL: http://codereview.chromium.org/651035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39450 0039d316-1c4b-4281-b951-d872f2087c98
* Move pref_{member,service} and important_file_writer from chrome/commonphajdan.jr@chromium.org2010-02-192-2/+2
| | | | | | | | | | | | | to chrome/browser. This is a part of an effort to remove bad dependency of chrome/common on chrome/browser. TEST=unit_tests and ui_tests, just moving code BUG=none Review URL: http://codereview.chromium.org/621004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39428 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Reduce header dependencies in chrome.phajdan.jr@chromium.org2010-02-092-0/+2
| | | | | | | | | BUG=none TEST=If it compiles it is perfect. Review URL: http://codereview.chromium.org/585008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38463 0039d316-1c4b-4281-b951-d872f2087c98
* linux: build with -Wextraevan@chromium.org2010-02-051-2/+2
| | | | | | | | | | | | 95% of this is removing "const" from return types, but turning this on found one bug! (A "for" loop that expected its iterator to go negative but which was using an unsigned type.) BUG=34160 Review URL: http://codereview.chromium.org/570012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38266 0039d316-1c4b-4281-b951-d872f2087c98
* BSD port: another chunk of chrome/browser ifdef cleaningpvalchev@google.com2010-02-031-0/+3
| | | | | | Review URL: http://codereview.chromium.org/553153 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38004 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: fix and reenable DevToolsSanityTest.TestShowScriptsTab. Only check ↵yurys@chromium.org2010-01-261-2/+1
| | | | | | | | | | | that main page script is present when the tab is shown. BUG=33107 TBR=pfeldman Review URL: http://codereview.chromium.org/553086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37100 0039d316-1c4b-4281-b951-d872f2087c98
* Disable failing browser test.jorlow@chromium.org2010-01-261-1/+2
| | | | | | | | | BUG=33107 TEST=none Review URL: http://codereview.chromium.org/549154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37067 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: prepare to injectiong inspector script into the inspected context.yurys@chromium.org2010-01-191-1/+1
| | | | | | | | BUG=29068 Review URL: http://codereview.chromium.org/552033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36518 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools crash: DevToolsWindow::SetDocked(bool)pfeldman@chromium.org2010-01-132-14/+25
| | | | | | | | BUG=32035 Review URL: http://codereview.chromium.org/541046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36122 0039d316-1c4b-4281-b951-d872f2087c98
* Fix issue: 32015: Keyboard shortcuts doesn't work when Devtool is dockedsuzhe@chromium.org2010-01-132-0/+17
| | | | | | | | | BUG=32015 TEST=Open devtool window and dock it into the browser window and move the focus into the devtool tab, then try if shortcut keys like ctrl-t are still work. Review URL: http://codereview.chromium.org/542049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36115 0039d316-1c4b-4281-b951-d872f2087c98
* Allow using system libevent instead of the bundled one.phajdan.jr@chromium.org2010-01-071-0/+4
| | | | | | | | | | | Patch by Bernard Cafarelli <voyageur@gentoo.org> TEST=none BUG=22140 Review URL: http://codereview.chromium.org/524061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35711 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Make devtools window dockable.thakis@chromium.org2010-01-052-5/+4
| | | | | | | | | | | | | | | | | | | | xib change: Deleted NSBox, added NSSplitView instead (with a thin divider and without any child views). I added the devtools tabcontents to TabContentsController; windows and linux instead add it to the browser window and switch it on every tab change. What I've done makes more sense to me and might work better with a) dragging a tab with docked devtools into a new window and b) toggling fullscreen. BUG=17368 TEST= * Inspect element, click the "attach" item in the lower left corner. Devtools should attach to the tab. Click it again, should detach. Re-attach, switch tabs. Should only be in the tab it was attached to. Open another devtools window in another tab, should be attached there. Drag tab with attached devtools into a new window, should work. * Inspect element with docked devtools, close devtools, inspect another element. devtools should open with the same size it had when it was closed, and should still be docked. * Hover link with docked devtools. Status bubble should not overlap devtools. * Go to http://www.pagetutor.com/keeper/http_authentication/index.html and make sure the http auth sheet still shows up Review URL: http://codereview.chromium.org/526001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35576 0039d316-1c4b-4281-b951-d872f2087c98
* Revert enabled DevToolsSanityTest.TestConsoleLog test.apavlov@chromium.org2009-12-301-1/+1
| | | | | | | | | | Fails on Linux TBR=pfeldman@chromium.org Review URL: http://codereview.chromium.org/519028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35381 0039d316-1c4b-4281-b951-d872f2087c98
* Enable DevToolsSanityTest.TestConsoleLog test (seems flaky)apavlov@chromium.org2009-12-301-1/+1
| | | | | | | | | | TBR=pfeldman@chromium.org BUG=none TEST=DevToolsSanityTest.TestConsoleLog Review URL: http://codereview.chromium.org/521015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35380 0039d316-1c4b-4281-b951-d872f2087c98
* Disable interactive ui test DevToolsSanityTest.TestConsoleLog which went red ↵michaeln@chromium.org2009-12-301-1/+1
| | | | | | | | | | | | with a webkit roll. TEST=none BUG=31302 TBR=pam Review URL: http://codereview.chromium.org/518024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35365 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: restore devtools tests.pfeldman@chromium.org2009-12-251-2/+2
| | | | | | | | BUG=515032 TBR=yurys git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35276 0039d316-1c4b-4281-b951-d872f2087c98
* Forbid reloading the Inspector window.apavlov@chromium.org2009-12-252-2/+5
| | | | | | | | | | | This CL disables reloading from the system menu, tab popup menu, and page context menu. BUG=27254,6902 TEST=none Review URL: http://codereview.chromium.org/391036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35275 0039d316-1c4b-4281-b951-d872f2087c98
* Disable 2 tests in DevToolsSanityTesthamaji@chromium.org2009-12-251-2/+2
| | | | | | | | | | | | DevToolsSanityTest.TestExpandScope and DevToolsSanityTest.TestDebugIntrinsicProperties are failing due to timeout. TBR=pamg TEST=none BUG=31149 Review URL: http://codereview.chromium.org/515032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35272 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: fix devtools sanity test that was affected by the inspector redesign.pfeldman@chromium.org2009-12-211-1/+1
| | | | | | | TBR=yurys git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35089 0039d316-1c4b-4281-b951-d872f2087c98
* Disable DevToolsSanityTest.TestExpandScope as it is failing from webkit roll.jparent@chromium.org2009-12-161-1/+1
| | | | | | | | | | TEST=none BUG=30618 Review URL: http://codereview.chromium.org/500077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34759 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: repair DevToolsExtensionDebugTest.TestContentScriptIsPresentyurys@chromium.org2009-12-151-1/+1
| | | | | | Review URL: http://codereview.chromium.org/500020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34545 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Restore sanity tests tests.pfeldman@chromium.org2009-12-151-16/+16
| | | | | | | | BUG=30418 Review URL: http://codereview.chromium.org/505005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34543 0039d316-1c4b-4281-b951-d872f2087c98
* Disable anther DevTools sanity test that was missed in r34516.tony@chromium.org2009-12-151-1/+1
| | | | | | | | | BUG=30418 TBR=pfeldman Review URL: http://codereview.chromium.org/500007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34522 0039d316-1c4b-4281-b951-d872f2087c98
* Disable DevTools sanity tests pending investigation.dglazkov@chromium.org2009-12-151-15/+15
| | | | | | | | | | | TBR=pfeldman TEST=none BUG=30418 Review URL: http://codereview.chromium.org/506005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34516 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: use WebDevToolsMessageData for devtools rpc messagesyurys@chromium.org2009-12-112-15/+9
| | | | | | | | Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=34333 Review URL: http://codereview.chromium.org/463065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34337 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "DevTools: use WebDevToolsMessageData for devtools rpc messages"yurys@chromium.org2009-12-112-9/+15
| | | | | | | | This reverts commit ea393f34b293ebf8b96bef5855b9f41faf82b192. Review URL: http://codereview.chromium.org/492018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34334 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: use WebDevToolsMessageData for devtools rpc messagesyurys@chromium.org2009-12-112-15/+9
| | | | | | Review URL: http://codereview.chromium.org/463065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34333 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Reduce header dependencies in chrome.phajdan.jr@chromium.org2009-11-301-1/+1
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/454004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33324 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 33301 and 33305 due to unit_tests breakage.maruel@chromium.org2009-11-301-1/+1
| | | | | | | | TBR=pawel Review URL: http://codereview.chromium.org/453007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33309 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Reduce header dependencies in chrome.phajdan.jr@chromium.org2009-11-301-1/+1
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/454004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33301 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: fix on Linux and reenable ↵yurys@chromium.org2009-11-301-1/+1
| | | | | | | | DevToolsSanityTest.TestPauseWhenScriptIsRunning Review URL: http://codereview.chromium.org/449013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33288 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: temporarily diable DevToolsSanityTest.TestPauseWhenScriptIsRunning ↵yurys@chromium.org2009-11-301-1/+1
| | | | | | | | | | which fails on Linux TBR=mnaganov@chromium.org Review URL: http://codereview.chromium.org/454003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33280 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: process pause script request on the IO thread. To pause already ↵yurys@chromium.org2009-11-301-0/+8
| | | | | | | | | | | running script we need to call v8::Debug::DebugBreak() on a thread different from the Render thread which may be busy with JS execution. BUG=28892 TEST=DevToolsSanityTest.TestPauseWhenScriptIsRunning Review URL: http://codereview.chromium.org/444017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33279 0039d316-1c4b-4281-b951-d872f2087c98
* Disable DevToolsExtensionDebugTest.TestContentScriptIsPresent becausensylvain@chromium.org2009-11-301-1/+2
| | | | | | | | it started failing after the webkit merge. Review URL: http://codereview.chromium.org/449008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33267 0039d316-1c4b-4281-b951-d872f2087c98
* Remove Content-Type workaround for cached resourcesapavlov@chromium.org2009-11-261-0/+6
| | | | | | | | | BUG=27364 TEST=DevToolsSanityTest.TestCachedResourceMimeType Review URL: http://codereview.chromium.org/437089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33206 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a flaky dev tools sanity test.ager@chromium.org2009-11-241-3/+0
| | | | | | | | | | | | | | | The test only works if the source of scripts are found in a specific order. This cannot be ensured since the source is found by traversing the heap. The scripts tab is only visible after processing the debugger test page, so only check for visibility in that case. Enable test on Linux again where it passes after this change. TEST=none BUG=26540 Review URL: http://codereview.chromium.org/434044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32968 0039d316-1c4b-4281-b951-d872f2087c98
* Use AutoReset (formerly ScopedBool) where possible.pkasting@chromium.org2009-11-201-2/+2
| | | | | | | | | | This frequently saves a tiny bit of code, but even when it doesn't I think it's more future-proof (less error-prone). BUG=none TEST=none Review URL: http://codereview.chromium.org/399096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32708 0039d316-1c4b-4281-b951-d872f2087c98
* Allow extension port connection requests to provide tab information.mad@chromium.org2009-11-191-1/+1
| | | | | | | | | | For Siggi: http://codereview.chromium.org/408015 BUG=0 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32536 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: add more manual Profiles tab tests.mnaganov@chromium.org2009-11-184-0/+179
| | | | | | Review URL: http://codereview.chromium.org/404002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32313 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Element styles manual testapavlov@chromium.org2009-11-171-0/+40
| | | | | | | | | BUG=none TEST=this Review URL: http://codereview.chromium.org/399034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32171 0039d316-1c4b-4281-b951-d872f2087c98
* Add Event Listeners sidebar pane manual testapavlov@chromium.org2009-11-161-0/+30
| | | | | | Review URL: http://codereview.chromium.org/391074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32066 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: add 2 manual profiler tests.mnaganov@chromium.org2009-11-163-0/+129
| | | | | | Review URL: http://codereview.chromium.org/399002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32056 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Add some devtools manual tests.pfeldman@chromium.org2009-11-1619-0/+445
| | | | | | Review URL: http://codereview.chromium.org/385134 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32053 0039d316-1c4b-4281-b951-d872f2087c98