| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/4220003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64418 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
See
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=interactive_ui_tests&tests=DevToolsSanityTest.TestProfilerTab
There's crbug.com/54592 for that.
BUG=54592
TEST=None
TBR=mnaganov@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Mostly this is removing FLAKY_ where the bug was fixed but the label never removed, but also switches some FLAKY_ to platform-specific FAILS_.
BUG=28372,32048,32070,35341,45561,48544,48562,52858
TEST=N/A
Review URL: http://codereview.chromium.org/4087009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64264 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4069003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63742 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=49600
TEST=none
Review URL: http://codereview.chromium.org/3965003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63520 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Extension events are no longer broadcast to an entire process. They are
filtered by extension. This allows me to move the cross-incognito check into
the browser, and remove a bunch of cruft associated with that.
BUG=58214
TEST=no functional change
Review URL: http://codereview.chromium.org/3775015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63448 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4009001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63420 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in devtools.
BUG=28083,59930
TEST=builds
Review URL: http://codereview.chromium.org/3851007
TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/3881003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63243 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=28083
TEST=builds
Review URL: http://codereview.chromium.org/3851007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63081 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=59727
TEST=interactive_ui_tests --gtest_filter=TestEnableResourcesTab
TBR=tyoshino@chromium.org
Review URL: http://codereview.chromium.org/3781019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63018 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(Only 916k this time off Debug Linux .a files)
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/3814013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62967 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(3.5 megs off debug linux .a files)
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/3806005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62654 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=54745
TEST=manual
Review URL: http://codereview.chromium.org/3582007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62627 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- Include browser_thread.h instead of chrome_thread.h in more 65 files.
BUG=56926
TEST=trybots
Review URL: http://codereview.chromium.org/3717003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Open, not toggle, DevTools upon click on active view on chrome://extensions
BUG=http://crbug.com/57217
TEST=none
Review URL: http://codereview.chromium.org/3570018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- Rename entries under debbuger, device_orientation, dom_ui.
BUG=56926
TEST=trybots
Review URL: http://codereview.chromium.org/3684001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62074 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=58553
=================================================
Fix instances of passing raw pointers to RefCounted objects in tasks.
Some of these manually handled it correctly by using AddRef()/Release() pairs. I switched them to make_scoped_refptr() to be more consistent. This also makes them cleanup properly on MessageLoop shutdown if we start deleting tasks.
BUG=28083
TEST=builds
Review URL: http://codereview.chromium.org/3581008
TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/3654001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62043 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This moves inner structs into the namespace toplevel so we can foreward declare
them; then we forward declare them in render_messages.h so we can drop that
header.
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/3616014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61996 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
to assure it's called in all code paths when DevTools is detached.
BUG=http://crbug.com/57302
TEST=none
Review URL: http://codereview.chromium.org/3564004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Some of these manually handled it correctly by using AddRef()/Release() pairs. I switched them to make_scoped_refptr() to be more consistent. This also makes them cleanup properly on MessageLoop shutdown if we start deleting tasks.
BUG=28083
TEST=builds
Review URL: http://codereview.chromium.org/3581008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61899 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Added DevToolsNetLogObserver (used by the above)
BUG=http://crbug.com/41916
TEST=none
Review URL: http://codereview.chromium.org/3133016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61648 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
before initializing DevTools extensions.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3519004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61630 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=unittests
Review URL: http://codereview.chromium.org/3544008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61540 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
executes script and uses a notification to post the results back.
BUG=54833
TEST=none
Review URL: http://codereview.chromium.org/3591008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61475 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removes changes to code in webkit/ that broke chrome_frame. Will debug that portion later.
(Shaves ~2MB off Linux Debug .a files)
BUG=none
TEST=compiles
First Review URL: http://codereview.chromium.org/3563004
Review URL: http://codereview.chromium.org/3621003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 27ea47d65cf8767f350113d5ad9e25170efde811 (r61237).
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/3609005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61240 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(Shaves ~2MB off Linux Debug .a files)
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/3563004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61237 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3512001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3425009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Apparently the session storage code was pretty horribly broken. It didn't correctly handle tabs being restored, didn't have the proper lifetime (this was the issue exposed in the bug), and had many leaks.
To fix this, things had to be plumbed fairly differently. We need to pass session storage in on TabContents creation to ensure that the first RenderView will have the correct session storage id. When closing a tab, we need to save the session storage with the restoration service. When restoring a tab, we pass it back into the tab contents class. When duplicating a tab, we clone the storage.
Lifetimes are now handled by standard reference counting code. A SessionStorageNamespace object wraps an ID. When it's instantiated, it allocates an ID. When it's destroyed, it deletes the ID. IDs make this process very lightweight (the heavyweight stuff is allocated on first use of SessionStorage) and it seperates the more complex lifetimes of SessionStorage namespaces (where less deterministic shutdown is more tollerable) from the LocalStorage namespace which needs to shutdown very precisely.
BUG=52393
TEST=Set some variable on session storage; close the tab; re-open the tab; the variable should still be set. You can also run through the repro steps in the bug.
Review URL: http://codereview.chromium.org/3325012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59350 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=53406
Review URL: http://codereview.chromium.org/3305023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59081 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
storage-panel-show.html
BUG=
TEST=
Review URL: http://codereview.chromium.org/3369003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58837 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
superseded by layout test
BUG=
TEST=
Review URL: http://codereview.chromium.org/3356011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58825 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
superseded by LayoutTests/inspector/debugger-eval-while-paused.html
BUG=53406
TEST=LayoutTests/inspector/debugger-eval-while-paused.html
Review URL: http://codereview.chromium.org/3309009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58668 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
a layout test
BUG=53664
TEST=DevToolsSanityTest.TestExpandScope
Review URL: http://codereview.chromium.org/3291013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58647 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/3362009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58640 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=54592
TEST=interactive_ui_tests
TBR=zmo
Review URL: http://codereview.chromium.org/3337014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58633 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=54591,54592
TEST=none
TBR=zmo
Review URL: http://codereview.chromium.org/3341015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58627 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57853 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
interactive ui bots.
BUG=53664
TEST=Mark DevToolsSanityTest.TestExpandScope as FAILS
TBR=chase@chromium.org
Review URL: http://codereview.chromium.org/3269002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57754 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=53406
TEST=none
TBR=dumi
Review URL: http://codereview.chromium.org/3174038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57496 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=53406
TEST=none
TBR=dumi
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
65992 to 66033
This time use DISABLED_ instead of FAILS_.
BUG=53406
TEST=none
TBR=dumi
Review URL: http://codereview.chromium.org/3186035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57484 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Temporarily disable the tests to roll WebKit.
BUG=53406
TEST=none
TBR=dumi
Review URL: http://codereview.chromium.org/3115030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rename includes, resort header include order in places where the rename
changed the order.
BUG=50548
TEST=compiles
Review URL: http://codereview.chromium.org/3203008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Rename (and resort) every #include.
BUG=50548
TEST=compiles
Review URL: http://codereview.chromium.org/3173043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57375 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The new file, render_messages_params.h, is included in 57 files, while
render_messages.h is included in 176 files. Moving the Params structs to their
own file allow pruning the included headers.
(Part 2 of this cleanup will be sorting the individual structs into themes
to further minimize header inclusion.)
BUG=51411
TEST=compiles
Review URL: http://codereview.chromium.org/3119035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57229 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Making window.focus()/blur() work only when there is a user gesture.
Also making window.focus() select tab if it is not visible.
The RenderViewHost now calls ActivateContent and the new DeactivateContent (instead of using the recently added TabContentsDelegate::Activate/Deactivate methods which have been removed).
TBR=darin,sky
BUG=29643,52346
TEST=Create a page with buttons that call window.focus()/blur() directly and with a timeout. When called directly, the calls should succeed (the browser should be activated/deactivated). When called with a timeout, nothing should happen. Also test that a popup calling window.opener.focus() cause the opening tab to become selected when it is not the current tab.
Review URL: http://codereview.chromium.org/3174030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57124 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
gesture.
Also making window.focus() select tab if it is not visible.
The RenderViewHost now calls ActivateContent and the new DeactivateContent (instead of using the recently added TabContentsDelegate::Activate/Deactivate methods which have been removed).
BUG=29643,52346
TEST=Create a page with buttons that call window.focus()/blur() directly and with a timeout. When called directly, the calls should succeed (the browser should be activated/deactivated). When called with a timeout, nothing should happen. Also test that a popup calling window.opener.focus() cause the opening tab to become selected when it is not the current tab.
Review URL: http://codereview.chromium.org/3156016
TBR=jcivelli@chromium.org
Review URL: http://codereview.chromium.org/3201008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57105 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also making window.focus() select tab if it is not visible.
The RenderViewHost now calls ActivateContent and the new DeactivateContent (instead of using the recently added TabContentsDelegate::Activate/Deactivate methods which have been removed).
BUG=29643,52346
TEST=Create a page with buttons that call window.focus()/blur() directly and with a timeout. When called directly, the calls should succeed (the browser should be activated/deactivated). When called with a timeout, nothing should happen. Also test that a popup calling window.opener.focus() cause the opening tab to become selected when it is not the current tab.
Review URL: http://codereview.chromium.org/3156016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57094 0039d316-1c4b-4281-b951-d872f2087c98
|