| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
GNOME 3 no longer shows an X button on dialogs, so we must show a close button.
BUG=102883
Review URL: http://codereview.chromium.org/9251028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118229 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This time without bustedness on Chrome OS.
Original patch: http://codereview.chromium.org/8910003/
TBR=mirandac@chromium.org
BUG=88109,93922,107160, chromium-os:24389
TEST=most scenarios with CrOS UI displaying the username, including signin dialogs
Review URL: http://codereview.chromium.org/9005016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115337 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reason: crash on sign in + constant crashing inside user session. Latter not consistent.
This reverts commit 1aba27d06e8a0e748d671e682fe610a85b3829b3.
TBR=tim@chromium.org
BUG=chromium-os24389
TEST=No crash on sign in or any constant crashing inside user session.
Review URL: http://codereview.chromium.org/8995010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114995 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead use SigninManager to store this information.
TBR=mirandac@chromium.org
BUG=88109,93922, 107160
TEST=most scenarios with CrOS UI displaying the username, including signin dialogs
Review URL: http://codereview.chromium.org/8910003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114880 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8651005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112510 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
essentially reverting cl: http://codereview.chromium.org/8115017/
and http://codereview.chromium.org/8177016/
yay.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/8734010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112120 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=105046
TEST=none
Review URL: http://codereview.chromium.org/8678015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111415 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. Avoid trying to layout the desktop when its size is set to 0x0 when minimized on Windows.
. Don't show the "Default Browser" UI in Aura either.
. Don't flash the active window inactive briefly when clicking on launcher items.
BUG=none
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109966
Review URL: http://codereview.chromium.org/8565015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110116 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. Avoid trying to layout the desktop when its size is set to 0x0 when minimized on Windows.
. Don't show the "Default Browser" UI in Aura either.
. Don't flash the active window inactive briefly when clicking on launcher items.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8565015
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/8564030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
. Avoid trying to layout the desktop when its size is set to 0x0 when minimized on Windows.
. Don't show the "Default Browser" UI in Aura either.
. Don't flash the active window inactive briefly when clicking on launcher items.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8565015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/8177016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104539 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/8115017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104230 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Restoring popups introduces some strange behaviors with extensions.
Until a good heuristic can be establised for when to restore popups on ChromeOS, and the behavior thoroughly tested, disable this feature.
BUG=chromium-os:11152,chromium-os:16898
TEST=See issues. Popups and panels should no longer be restored when starting ChromeOS.
Review URL: http://codereview.chromium.org/7533009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94723 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=everything compiles, infobars look okay for touch and non-touch
Review URL: http://codereview.chromium.org/7380005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92707 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The CrOS network menu shows the associated network in bold face and non-associated networks in regular face. The size of these fonts matches for non-touch builds but are different for touch builds.
BUG=none
TEST=on touch build, open network menu and check if all items are the same size
Review URL: http://codereview.chromium.org/7044121
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7014023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88062 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Adapt to the new icon methods from both WebFrame and
WebFrameClient.
- Touch icons will be fetched and stored if kEnableTouchIcon=1,
Currently it is disabled by default.
- Moved the kEnableTouchIcon definition to chrome_constants
so it could be seen in both browser and renderer code.
BUG=71571
TEST=Tested by existent unit test.
Review URL: http://codereview.chromium.org/7032013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85651 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
b.ViewHostMsg_UpdateFaviconURL can update multiple icon urls
BUG=71571
TEST=Tested with existing unit test and add 2 new unit tests
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=81158
Review URL: http://codereview.chromium.org/6672065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81258 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
touch in FaviconHelper.b.ViewHostMsg_UpdateFaviconURL can update multiple icon urlsBUG=71571TEST=Tested with existing unit test and add 2 new unit testsReview URL: http://codereview.chromium.org/6672065
TBR=michaelbai@google.com
Review URL: http://codereview.chromium.org/6820054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81167 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
b.ViewHostMsg_UpdateFaviconURL can update multiple icon urls
BUG=71571
TEST=Tested with existing unit test and add 2 new unit tests
Review URL: http://codereview.chromium.org/6672065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes tab titles a bit smaller (13->12 px) and the
omnibox text a bit larger (13->14 px). The omnibox text
size is only changed when a non-GTK+ theme is being used; we
continue using GTK+'s default font otherwise.
BUG=77285
TEST=manual: built it and checked that the font sizes are changed as specified above
Review URL: http://codereview.chromium.org/6711089
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=73941
TEST=Open Wrench menu. See About Chromium and selecting it brings up the about panel.
Review URL: http://codereview.chromium.org/6591102
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76636 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
gfx::Font deals with pixels (at least, its GetFontSize()
method is documented as returning them and that's what all
of the metrics-related methods return; I'm assuming that the
|font_size| argument in its constructors deals with the
same units). PlatformFontGtk's constructor treated
|font_size| as points, though, and mostly used points
internally.
This change makes PlatformFontGtk use pixels internally and
renames all of the variables to describe their units.
It also changes the size of the omnibox suggestion text:
- on Chrome OS, it matches the size of the omnibox text
- on Linux, it's slightly smaller (similar to Windows)
It also makes us update the suggestion text size when
switching between standard and GTK+ themes (the omnibox
itself already handled this correctly).
Tested with the following configurations in a regular GTK+
build:
120 DPI, GTK+ theme:
- 13-pixel tab text
- 16-pixel omnibox text
- 13-pixel omnibox popup text
- 16-pixel popup location text
96 DPI, GTK+ theme:
- 13-pixel tab text
- 13-pixel omnibox popup text
- 12-pixel omnibox popup text
- 13-pixel popup location text
72 DPI, GTK+ theme:
- 13-pixel tab text
- 9-pixel omnibox popup text
- 9-pixel omnibox popup text
- 9-pixel popup location text
120 DPI, Classic theme:
- 13-pixel tab text
- 13-pixel omnibox text
- 12-pixel omnibox popup text
- 10-pixel popup location text
96 DPI, Classic theme:
- 13-pixel tab text
- 13-pixel omnibox text
- 12-pixel omnibox popup text
- 10-pixel popup location text
72 DPI, Classic theme:
- 13-pixel tab text
- 13-pixel omnibox text
- 12-pixel omnibox popup text
- 10-pixel popup location text
Put more simply:
- Regular themes use hardcoded font sizes.
- The GTK+ theme uses a hardcoded font size for tabs and
sizes based on the DPI for the omnibox.
BUG=61433,26354,chromium-os:8658
TEST=see above. also took screenshots and checked that the onscreen font size matches that passed to gfx::Font and that the computed metrics are correct, and built a Chrome OS image to verify that things look reasonable, and verified that text isn't clipped on the "Aw, Snap!" page
Review URL: http://codereview.chromium.org/6378007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72985 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://code.google.com/p/chromium-os/issues/detail?id=6923
TEST=manual
Review URL: http://codereview.chromium.org/5758002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add timings for first owner login
This is a redo of a previously lgtm'd cl but on the right branch.
TBR:sky@chromium.org
BUG=chromium-os:8670
TEST=On a new machine login. When picture screen appears skip immediately
before this change that could block for 10+ seconds. Now it should
show the browser w/in 2 seconds
Review URL: http://codereview.chromium.org/4767002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:8740
TEST=manually done.
Review URL: http://codereview.chromium.org/4651002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also get rid of the type enum passed to TabReplacedAt since it can only be one option after phantom tabs are removed.
BUG=none
TEST=compile? good. pass tests? good.
Review URL: http://codereview.chromium.org/3539010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61303 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change makes it two points larger than the popup and
tab text. I am hesitant to make a similar change to the
GTK version, at least in this change, since there have
already been a bunch of omnibox-font-sizing problems there.
BUG=50568
TEST=built and tried it
Review URL: http://codereview.chromium.org/3181023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58524 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:6248
TEST=Open a popup window. URL should be readable (10 point font instead of 7).
Review URL: http://codereview.chromium.org/3338005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original CL: http://codereview.chromium.org/3191007
Initial change that allows to disable bookmarks in Chrome for Chrome OS
(BWSI mode). Added disable-bookmarks flag and disabled some UI elements.
BUG=chromium-os:4302
TEST=Run Chrome build for Chrome OS with --disable-bookmarks flag and
verify that the corresponding UI is disabled. Verify that BWSI mode runs
with this flag.
Review URL: http://codereview.chromium.org/3156035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57033 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56676 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original CL: http://codereview.chromium.org/3122014
Initial change that allows to disable bookmarks in Chrome for Chrome OS
(BWSI mode). Added disable-bookmarks flag and disabled some UI elements.
BUG=chromium-os:4302
TEST=Run Chrome build for Chrome OS with --disable-bookmarks flag and
verify that the corresponding UI is disabled. Verify that BWSI mode runs
with this flag.
Review URL: http://codereview.chromium.org/3191007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56669 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
we may yet try them again shortly.
BUG=46852
TEST=none
Review URL: http://codereview.chromium.org/2833026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50511 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Replace name link with name+error message in content browser;
- Show an error message ChromeOS's openItem;
- Update SimpleErrorBox so that it runs in a Chrome window;
- Put back "Show in folder" in download page and make it work with content
browser;
BUG=chromium-os:1637
TEST=Verify fix for chromium-os:1637 and verify error message pops up for unknown type file in downloads ui.
Review URL: http://codereview.chromium.org/2748007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49541 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
As current implementation BWSI mode = "Incognito session" so only incognito windows should be open.
BUG= http://crosbug.com/3473
TEST=Open BWSI mode from "New user" screen. Ctrl+N/Shift+Ctrl+N should open only Incognito windows.
Review URL: http://codereview.chromium.org/2580001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48855 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I reverted http://codereview.chromium.org/1986006 as part of that change, after talking with Ben and Aaron. (it breaks the UI tests on ChromeOS now that apps are enabled).
Disabling app launcher and enabling apps by default on ChromeOS .
BUG=3218
TEST=Open the new tab, the new new tab should be shown. Any installed
app should be showing in there.
Review URL: http://codereview.chromium.org/2149003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Disabling app launcher and enabling apps by default on ChromeOS .
BUG=3218
TEST=Open the new tab, the new new tab should be shown. Any installed
app should be showing in there.
Review URL: http://codereview.chromium.org/2135011
TBR=jcivelli@chromium.org
Review URL: http://codereview.chromium.org/2077020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48044 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=3218
TEST=Open the new tab, the new new tab should be shown. Any installed
app should be showing in there.
Review URL: http://codereview.chromium.org/2135011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
launcher pinned to the location bar.
BUG=3190
TEST=The app launcher icon on the top-left corner of the browser should
be gone. Opening a new tab by pressing the + button or typing
CTRL-T should bring the app launcher, it should be located on top
of the location bar.
Review URL: http://codereview.chromium.org/2060004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47314 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL rewires the old support for pinned tabs to support mini-tabs. This also
removes the kEnablePinnedTabs browser default now that all platforms support it.
Note that pinning is now only accessible through the context menu; drag-to-pin
has been removed.
BUG=36798, 32845
TEST=Right-click and pin two tabs. Test dragging on and off and around the tab strip.
TEST=Cmd+W a pinned tab and it should go phantom (renderer closes down) and the tab is made alpha.
Review URL: http://codereview.chromium.org/1119005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42548 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/656009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=36797
TEST=make sure pinned tabs work on linux.
Review URL: http://codereview.chromium.org/669163
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40767 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=34839
TEST=verify per bug report
Review URL: http://codereview.chromium.org/650161
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39746 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
pinning on views again as everything in place, except a couple of
bugs.
BUG=32845
TEST=none
Review URL: http://codereview.chromium.org/598027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38657 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/548221
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38530 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
a handful of things to resolve before I turn on pinning.
BUG=32845
TEST=none
Review URL: http://codereview.chromium.org/579011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38287 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
places where I left them using the variable with pinned when it should
be app because those places need to be radically whacked. I'll do that
next.
BUG=32845
TEST=none yet
Review URL: http://codereview.chromium.org/555173
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37880 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
it is closed, and effectively unloads the renderer and replaces it
with a new TabContents that loads when selected. A phantom tab is
currently rendered without a border. Phantom tabs do not prevent a
window from closing.
Long term only pinned app tabs will have the ability to be made
phantom, but this allows us to test the feature until app support is
all wired in.
BUG=32845
TEST=none yet
Review URL: http://codereview.chromium.org/553008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36815 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
authentication is succesful in Chrome OS.
BUG=1220
TEST=The menu option in the wrench menu should indicate that bookmarks are
synced on startup, and it should be possible to disable sync through the
options dialog.
Review URL: http://codereview.chromium.org/551053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36783 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
CROS_BUG=310
TEST=see bug
Review URL: http://codereview.chromium.org/550020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36058 0039d316-1c4b-4281-b951-d872f2087c98
|