| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=73941
TEST=Open Wrench menu. See About Chromium and selecting it brings up the about panel.
Review URL: http://codereview.chromium.org/6591102
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76636 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
gfx::Font deals with pixels (at least, its GetFontSize()
method is documented as returning them and that's what all
of the metrics-related methods return; I'm assuming that the
|font_size| argument in its constructors deals with the
same units). PlatformFontGtk's constructor treated
|font_size| as points, though, and mostly used points
internally.
This change makes PlatformFontGtk use pixels internally and
renames all of the variables to describe their units.
It also changes the size of the omnibox suggestion text:
- on Chrome OS, it matches the size of the omnibox text
- on Linux, it's slightly smaller (similar to Windows)
It also makes us update the suggestion text size when
switching between standard and GTK+ themes (the omnibox
itself already handled this correctly).
Tested with the following configurations in a regular GTK+
build:
120 DPI, GTK+ theme:
- 13-pixel tab text
- 16-pixel omnibox text
- 13-pixel omnibox popup text
- 16-pixel popup location text
96 DPI, GTK+ theme:
- 13-pixel tab text
- 13-pixel omnibox popup text
- 12-pixel omnibox popup text
- 13-pixel popup location text
72 DPI, GTK+ theme:
- 13-pixel tab text
- 9-pixel omnibox popup text
- 9-pixel omnibox popup text
- 9-pixel popup location text
120 DPI, Classic theme:
- 13-pixel tab text
- 13-pixel omnibox text
- 12-pixel omnibox popup text
- 10-pixel popup location text
96 DPI, Classic theme:
- 13-pixel tab text
- 13-pixel omnibox text
- 12-pixel omnibox popup text
- 10-pixel popup location text
72 DPI, Classic theme:
- 13-pixel tab text
- 13-pixel omnibox text
- 12-pixel omnibox popup text
- 10-pixel popup location text
Put more simply:
- Regular themes use hardcoded font sizes.
- The GTK+ theme uses a hardcoded font size for tabs and
sizes based on the DPI for the omnibox.
BUG=61433,26354,chromium-os:8658
TEST=see above. also took screenshots and checked that the onscreen font size matches that passed to gfx::Font and that the computed metrics are correct, and built a Chrome OS image to verify that things look reasonable, and verified that text isn't clipped on the "Aw, Snap!" page
Review URL: http://codereview.chromium.org/6378007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72985 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://code.google.com/p/chromium-os/issues/detail?id=6923
TEST=manual
Review URL: http://codereview.chromium.org/5758002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add timings for first owner login
This is a redo of a previously lgtm'd cl but on the right branch.
TBR:sky@chromium.org
BUG=chromium-os:8670
TEST=On a new machine login. When picture screen appears skip immediately
before this change that could block for 10+ seconds. Now it should
show the browser w/in 2 seconds
Review URL: http://codereview.chromium.org/4767002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:8740
TEST=manually done.
Review URL: http://codereview.chromium.org/4651002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also get rid of the type enum passed to TabReplacedAt since it can only be one option after phantom tabs are removed.
BUG=none
TEST=compile? good. pass tests? good.
Review URL: http://codereview.chromium.org/3539010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61303 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rename includes, resort header include order in places where the rename
changed the order.
BUG=50548
TEST=compiles
Review URL: http://codereview.chromium.org/3203008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original CL: http://codereview.chromium.org/3191007
Initial change that allows to disable bookmarks in Chrome for Chrome OS
(BWSI mode). Added disable-bookmarks flag and disabled some UI elements.
BUG=chromium-os:4302
TEST=Run Chrome build for Chrome OS with --disable-bookmarks flag and
verify that the corresponding UI is disabled. Verify that BWSI mode runs
with this flag.
Review URL: http://codereview.chromium.org/3156035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57033 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56676 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original CL: http://codereview.chromium.org/3122014
Initial change that allows to disable bookmarks in Chrome for Chrome OS
(BWSI mode). Added disable-bookmarks flag and disabled some UI elements.
BUG=chromium-os:4302
TEST=Run Chrome build for Chrome OS with --disable-bookmarks flag and
verify that the corresponding UI is disabled. Verify that BWSI mode runs
with this flag.
Review URL: http://codereview.chromium.org/3191007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56669 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=50273
TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux
TBR: erg
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
we may yet try them again shortly.
BUG=46852
TEST=none
Review URL: http://codereview.chromium.org/2833026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50511 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
As current implementation BWSI mode = "Incognito session" so only incognito windows should be open.
BUG= http://crosbug.com/3473
TEST=Open BWSI mode from "New user" screen. Ctrl+N/Shift+Ctrl+N should open only Incognito windows.
Review URL: http://codereview.chromium.org/2580001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48855 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I reverted http://codereview.chromium.org/1986006 as part of that change, after talking with Ben and Aaron. (it breaks the UI tests on ChromeOS now that apps are enabled).
Disabling app launcher and enabling apps by default on ChromeOS .
BUG=3218
TEST=Open the new tab, the new new tab should be shown. Any installed
app should be showing in there.
Review URL: http://codereview.chromium.org/2149003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Disabling app launcher and enabling apps by default on ChromeOS .
BUG=3218
TEST=Open the new tab, the new new tab should be shown. Any installed
app should be showing in there.
Review URL: http://codereview.chromium.org/2135011
TBR=jcivelli@chromium.org
Review URL: http://codereview.chromium.org/2077020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48044 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=3218
TEST=Open the new tab, the new new tab should be shown. Any installed
app should be showing in there.
Review URL: http://codereview.chromium.org/2135011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
launcher pinned to the location bar.
BUG=3190
TEST=The app launcher icon on the top-left corner of the browser should
be gone. Opening a new tab by pressing the + button or typing
CTRL-T should bring the app launcher, it should be located on top
of the location bar.
Review URL: http://codereview.chromium.org/2060004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47314 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL rewires the old support for pinned tabs to support mini-tabs. This also
removes the kEnablePinnedTabs browser default now that all platforms support it.
Note that pinning is now only accessible through the context menu; drag-to-pin
has been removed.
BUG=36798, 32845
TEST=Right-click and pin two tabs. Test dragging on and off and around the tab strip.
TEST=Cmd+W a pinned tab and it should go phantom (renderer closes down) and the tab is made alpha.
Review URL: http://codereview.chromium.org/1119005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42548 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/656009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=36797
TEST=make sure pinned tabs work on linux.
Review URL: http://codereview.chromium.org/669163
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40767 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=34839
TEST=verify per bug report
Review URL: http://codereview.chromium.org/650161
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39746 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
pinning on views again as everything in place, except a couple of
bugs.
BUG=32845
TEST=none
Review URL: http://codereview.chromium.org/598027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38657 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
a handful of things to resolve before I turn on pinning.
BUG=32845
TEST=none
Review URL: http://codereview.chromium.org/579011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38287 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
places where I left them using the variable with pinned when it should
be app because those places need to be radically whacked. I'll do that
next.
BUG=32845
TEST=none yet
Review URL: http://codereview.chromium.org/555173
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37880 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
it is closed, and effectively unloads the renderer and replaces it
with a new TabContents that loads when selected. A phantom tab is
currently rendered without a border. Phantom tabs do not prevent a
window from closing.
Long term only pinned app tabs will have the ability to be made
phantom, but this allows us to test the feature until app support is
all wired in.
BUG=32845
TEST=none yet
Review URL: http://codereview.chromium.org/553008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36815 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
authentication is succesful in Chrome OS.
BUG=1220
TEST=The menu option in the wrench menu should indicate that bookmarks are
synced on startup, and it should be possible to disable sync through the
options dialog.
Review URL: http://codereview.chromium.org/551053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36783 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
CROS_BUG=310
TEST=see bug
Review URL: http://codereview.chromium.org/550020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36058 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromiun-os:916
TEST=None
Review URL: http://codereview.chromium.org/506045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34837 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
NSMenu from Toolbar.xib.
BUG=22646
TEST=the app menu works as it used to.
Review URL: http://codereview.chromium.org/482006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34561 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
added support for baselines to GridLayout.
BUG=4374
TEST=On a new profile make sure the bookmark bar has a link to import
bookmarks, click the link and make sure you can import your bookmarks.
Review URL: http://codereview.chromium.org/440029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33336 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
chromeos.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/431029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32942 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With "On startup"/"Restore the pages that were open last" set (in Preferences), a window which was explicitly closed (using the red button, Cmd-Shift-W, the menu item -- but not due to quit) should not be restored on startup. This is the behaviour of Firefox and Camino (Safari doesn't appear to implement this feature).
Note about this patch: Depending on how we decide things will work for App mode, much more code could be disabled on Mac.
BUG=13341
TEST=Set the browser to restore pages on start (see above). Navigate somewhere interesting; close window; quit; restart; should open a browser with default window (NTP or homepage or whatever). Navigate somewhere; quit; restart; should open previously opened stuff. Make sure that session restore (also crash recovery) still work as expected.
Review URL: http://codereview.chromium.org/362016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31164 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GetType message to the end of the list and to keep the old message for
creating a new browser as well as adding one that takes the type. To change the params of the message requires updating the reference build. That's best done on a weekend when I'm bored.
Makes session restore on Chrome OS restore popups.
BUG=18862
TEST=none
Review URL: http://codereview.chromium.org/329040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30255 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=18862
TEST=none
Review URL: http://codereview.chromium.org/337030
TBR=sky@chromium.org
Review URL: http://codereview.chromium.org/335047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=18862
TEST=none
Review URL: http://codereview.chromium.org/337030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30194 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23502
TEST=none
Review URL: http://codereview.chromium.org/249050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27698 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
session crashed.
BUG=22835
TEST=On Chrome OS bring up Chrome, wait a few seconds, go to a
terminal and kill Chrome, when Chrome comes up again you should see
the crashed info bar.
Review URL: http://codereview.chromium.org/220018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26999 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/207055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26933 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
remains at 64.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/203055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26156 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
contains a clock, an application menu, and a non-working battery indicator.
The compact location bar can be toggled by COMPACT_NAV_BAR in browser_window_gtk.cc
Review URL: http://codereview.chromium.org/165272
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
chrome os as well as changing autocomplete edit/popup font sizes on
chrome os. As suggested by Evan I've moved these options into
chrome/browser/defaults.h so that we don't have a ton of #ifdefs every
where.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/155576
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20852 0039d316-1c4b-4281-b951-d872f2087c98
|