summaryrefslogtreecommitdiffstats
path: root/chrome/browser/diagnostics
Commit message (Collapse)AuthorAgeFilesLines
* Move json_value_serializer to content\common since it's used by code in ↵jam@chromium.org2011-04-161-1/+1
| | | | | | | | | content now. TBR=avi Review URL: http://codereview.chromium.org/6875018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81857 0039d316-1c4b-4281-b951-d872f2087c98
* Make the windows_version.h functions threadsafe by using a singleton. Add ↵pkasting@chromium.org2011-04-071-14/+7
| | | | | | | | | | | | accessors to the singleton for more values that various code wants, then convert almost everyone using OSVERSIONINFO or SYSTEM_INFO structs to calling these accessors. Declare an AtExitManager in the out-of-process test runner since it didn't have one and that breaks singleton-using code in the test executable (as opposed to in chrome.dll). A few other minor cleanups along the way (binding of "*", shorter code, etc.). Because I ran into problems with it while modifying gcapi.cc, I cleaned up our usage of strsafe.h a bit, so that files that don't need it don't include it and files that do use STRSAFE_NO_DEPRECATE instead of a modified #include order. BUG=none TEST=none Review URL: http://codereview.chromium.org/6816027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80851 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 80819 due to failed testsmmenke@chromium.org2011-04-071-7/+14
| | | | | | | TBR=pkasting@chromium.org Review URL: http://codereview.chromium.org/6816024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80824 0039d316-1c4b-4281-b951-d872f2087c98
* Make the windows_version.h functions threadsafe by using a singleton. Add ↵pkasting@chromium.org2011-04-071-14/+7
| | | | | | | | | | | | accessors to the singleton for more values that various code wants, then convert almost everyone using OSVERSIONINFO or SYSTEM_INFO structs to calling these accessors. Declare an AtExitManager in the out-of-process test runner since it didn't have one and that breaks singleton-using code in the test executable (as opposed to in chrome.dll). A few other minor cleanups along the way (binding of "*", shorter code, etc.). Because I ran into problems with it while modifying gcapi.cc, I cleaned up our usage of strsafe.h a bit, so that files that don't need it don't include it and files that do use STRSAFE_NO_DEPRECATE instead of a modified #include order. BUG=none TEST=none Review URL: http://codereview.chromium.org/6713107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80819 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 79705 - Revert 79651 - Coverity: Pass parameters by reference.dhollowa@chromium.org2011-03-291-1/+1
| | | | | | | | | | | | | | | | | | | | | Also remove an unused function that I found. CID=2634,4471,5392,6433,6434,6535,6777,6780,6781,6792,6810,7665,7759,8056,8072, 8637,8718,8726 BUG=none TEST=non R=csilv@chromium.org Review URL: http://codereview.chromium.org/6730046 TBR=jhawkins@chromium.org Review URL: http://codereview.chromium.org/6773015 TBR=dhollowa@chromium.org Review URL: http://codereview.chromium.org/6772013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79714 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 79651 - Coverity: Pass parameters by reference.dhollowa@chromium.org2011-03-291-1/+1
| | | | | | | | | | | | | | | | | | Also remove an unused function that I found. CID=2634,4471,5392,6433,6434,6535,6777,6780,6781,6792,6810,7665,7759,8056,8072, 8637,8718,8726 BUG=none TEST=non R=csilv@chromium.org Review URL: http://codereview.chromium.org/6730046 TBR=jhawkins@chromium.org Review URL: http://codereview.chromium.org/6773015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79705 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Pass parameters by reference.jhawkins@chromium.org2011-03-291-1/+1
| | | | | | | | | | | | | | | Also remove an unused function that I found. CID=2634,4471,5392,6433,6434,6535,6777,6780,6781,6792,6810,7665,7759,8056,8072, 8637,8718,8726 BUG=none TEST=non R=csilv@chromium.org Review URL: http://codereview.chromium.org/6730046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79651 0039d316-1c4b-4281-b951-d872f2087c98
* Move some files from base to base/memory.levin@chromium.org2011-03-281-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | raw_scoped_refptr_mismatch_checker.h ref_counted.cc ref_counted.h ref_counted_memory.cc ref_counted_memory.h ref_counted_unittest.cc scoped_callback_factory.h scoped_comptr_win.h scoped_handle.h scoped_native_library.cc scoped_native_library.h scoped_native_library_unittest.cc scoped_nsobject.h scoped_open_process.h scoped_ptr.h scoped_ptr_unittest.cc scoped_temp_dir.cc scoped_temp_dir.h scoped_temp_dir_unittest.cc scoped_vector.h singleton.h singleton_objc.h singleton_unittest.cc linked_ptr.h linked_ptr_unittest.cc weak_ptr.cc weak_ptr.h weak_ptr_unittest.cc BUG=None TEST=Compile Review URL: http://codereview.chromium.org/6714032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79524 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the check for inspector files since they're in resources.pak now.tony@chromium.org2011-03-233-7/+7
| | | | | | | | | | | | | | | | | In r79038, I moved the inspector files into resources.pak so we no longer need to check to see if inspector is available (it should always be there). Also fix chrome --diagnostics to check for resources.pak rather than the resources/Inspector dir. BUG=77167 TEST=Delete resources/inspector from disk, start chrome and right click on a page. Inspect Element should be there and work. Review URL: http://codereview.chromium.org/6726027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79170 0039d316-1c4b-4281-b951-d872f2087c98
* wstring: remove a needless wchar_t that is ASCIIevan@chromium.org2011-03-151-1/+1
| | | | | | | | | | | While I'm at it, remove kNotSignedInID. This was added in 2007 (!) and appears to be unused. BUG=76112 Review URL: http://codereview.chromium.org/6695004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78260 0039d316-1c4b-4281-b951-d872f2087c98
* Add some more debugging info to the --diagnostics for when checking filepath.finnur@chromium.org2011-02-081-4/+10
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/6413016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74104 0039d316-1c4b-4281-b951-d872f2087c98
* FilePath: Remove much of ToWStringHack, adding a LossyDisplayName()evan@chromium.org2011-02-041-2/+1
| | | | | | | | | | | | | | | The reason we don't want a free conversion between FilePaths and Unicode is that it can be lossy. But when displaying a string to the user, we're ok if it's lossy when we have no other option. This change introduces a LossyDisplayName() method that returns a string16, and converts many of the users of ToWStringHack to use it. BUG=69467 Review URL: http://codereview.chromium.org/6246036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73840 0039d316-1c4b-4281-b951-d872f2087c98
* Move ResourceBundle, DataPack to ui/baseben@chromium.org2011-01-201-0/+2
| | | | | | | | | | BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/6263008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72038 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Fix unchecked return values.kmadhusu@chromium.org2011-01-121-1/+5
| | | | | | | | | | CID=13943, 13746, 13749, 13597, 13249, 13145, 12875, 12874, 12871, 12438, 12436, 12431 BUG=none TEST=none Review URL: http://codereview.chromium.org/6076006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71179 0039d316-1c4b-4281-b951-d872f2087c98
* Fix minor CHECKED_RETURN Coverity complaint in code I added to the ↵finnur@chromium.org2011-01-111-1/+2
| | | | | | | | | | | | --diagnostics code. BUG=None TEST=None CID=14387 Review URL: http://codereview.chromium.org/6171004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71027 0039d316-1c4b-4281-b951-d872f2087c98
* Integrate about:conflicts with --diagnosticsfinnur@chromium.org2011-01-067-21/+96
| | | | | | | | | | | | | | | | | This should enable the user to find conflicting dlls that are crashing Chrome on startup. This changelist introduces a limited_mode for scanning, since the diagnostics tests run without the help of many Chrome services, so we can't use the File thread for asynchronous scanning or the notification system. Also changed the scanning so that if no signature/description is given in the blacklist, then we mark the DLL as a confirmed match if the name and the location match (before we used to match it as a 'suspected' match). A very sizable chunk of the blacklist is malware, which has no signature, so this gives us the ability to trigger the wrench badge on finding malware (that part remains opt-in through about:flags). Also added failure count to diagnostics output (sometimes the error scrolls off screen, so having a note at the bottom helps). BUG=51105 TEST=All diagnostics tests run as part of the unit tests. Review URL: http://codereview.chromium.org/6098004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70600 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 69592 - file_version_info was not finding Mac values correctly.dmaclach@chromium.org2010-12-181-0/+4
| | | | | | | | | | | | | | Changed file_version_info to find Mac values, and changed version_info to fail if values can't be found. BUG=NONE TEST=BUILD Review URL: http://codereview.chromium.org/5815001 TBR=dmaclach@chromium.org Review URL: http://codereview.chromium.org/6017003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69601 0039d316-1c4b-4281-b951-d872f2087c98
* file_version_info was not finding Mac values correctly.dmaclach@chromium.org2010-12-181-4/+0
| | | | | | | | | | | Changed file_version_info to find Mac values, and changed version_info to fail if values can't be found. BUG=NONE TEST=BUILD Review URL: http://codereview.chromium.org/5815001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69592 0039d316-1c4b-4281-b951-d872f2087c98
* Deinline even more destructors.erg@google.com2010-12-143-33/+64
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/5794003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69084 0039d316-1c4b-4281-b951-d872f2087c98
* Wrap GlobalDescriptors singleton in accessor method.evan@chromium.org2010-12-071-2/+2
| | | | | | | | | | | When I switched GlobalDescriptors to using LeakySingletonTraits in r67627, it didn't occur to me I had to fix all users of it. TEST=compiles Review URL: http://codereview.chromium.org/5517006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68518 0039d316-1c4b-4281-b951-d872f2087c98
* Rename CommandLine::ARGUMENTS_ONLY to NO_PROGRAM.mattm@chromium.org2010-10-211-1/+1
| | | | | | | | | | | ARGUMENTS_ONLY was misleading since CommandLine has methods for handling "switches" and "arguments", but that constructor still allows both. BUG=none TEST=still builds Review URL: http://codereview.chromium.org/3935001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63325 0039d316-1c4b-4281-b951-d872f2087c98
* Move windows version-related stuff out of base/win_util and into ↵brettw@chromium.org2010-10-151-5/+5
| | | | | | | | | | | | | | base/win/windows_version. Many files now only need to include this instead of all of win_util. Remove a bunch of unused code from base/win_util. There was a surprising amount. Replace the AppUserModel property key with the one from the SDK now that we use the Win7 SDK. Move GetLogonSessionOnlyDACL from win_util to ipc since it's only used in that one place. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3823002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62694 0039d316-1c4b-4281-b951-d872f2087c98
* Move Stats, histograms, and field trial into a metrics subdirectory of base andbrettw@chromium.org2010-10-141-1/+1
| | | | | | | | | put them in the base namespace. TEST=it compiles BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62510 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Disable DiagnosticsModelTest.RunAll."agl@chromium.org2010-10-071-2/+1
| | | | | | This reverts commit r61844. nsylvain fixed the builder. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61846 0039d316-1c4b-4281-b951-d872f2087c98
* Disable DiagnosticsModelTest.RunAll.agl@chromium.org2010-10-071-1/+2
| | | | | | | | | It's crashing the builder but we don't know why. However, we don't want to be blinded by it in the mean time. TBR=jar git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61844 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor version-getting info into a chrome::VersionInfo object.evan@chromium.org2010-08-271-12/+8
| | | | | | | | | | | | | | | I was trying to replace wstring usage in base::FileVersionInfo, but that class is rather Windows-specific with strange fields like "private_build()" where the value and encoding aren't clear. 95% of the users of FileVersionInfo actually just care about the current Chrome version, so we can provide a much simpler interface for them. We still use FileVersionInfo for retrieving information from e.g. plugin DLLs, but in those cases the usage is clearer. Review URL: http://codereview.chromium.org/3135028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57725 0039d316-1c4b-4281-b951-d872f2087c98
* Convert FormatBytes to string16.evan@chromium.org2010-08-191-4/+2
| | | | | | | | | | I considered ASCII, but it's producing what is intended to be a human-readable string. For example, in theory the "bytes/s" annotation could be localized into a language where the "b" is non-ASCII. Review URL: http://codereview.chromium.org/3107021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56771 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up unnecessary #includes of base/{scoped_ptr.h,string16.h}.viettrungluu@chromium.org2010-08-191-2/+1
| | | | | | | | | | | | Also fix a bunch of #includes. Folks, scoped_refptr<> is defined in base/ref_counted.h, not in base/scoped_ptr.h. BUG=none TEST=builds Review URL: http://codereview.chromium.org/3132024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56712 0039d316-1c4b-4281-b951-d872f2087c98
* Move bundled copy of sqlite one level deeper to better separate itphajdan.jr@chromium.org2010-08-181-1/+1
| | | | | | | | | | | | | from our patches, READMEs, etc. Also, add a shim header so we can use it for building with system sqlite. TEST=compile BUG=22208 Review URL: http://codereview.chromium.org/3108030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56619 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Convert FormatBytes to string16."evan@chromium.org2010-08-181-2/+4
| | | | | | This reverts commit r56603. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56608 0039d316-1c4b-4281-b951-d872f2087c98
* Convert FormatBytes to string16.evan@chromium.org2010-08-181-4/+2
| | | | | | | | | | I considered ASCII, but it's producing what is intended to be a human-readable string. For example, in theory the "bytes/s" annotation could be localized into a language where the "b" is non-ASCII. Review URL: http://codereview.chromium.org/3107021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56603 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Remove unneeded headers from base/ (part 1)thestig@chromium.org2010-08-051-4/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3071012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55034 0039d316-1c4b-4281-b951-d872f2087c98
* Add #include utf_string_conversions.h to all files that use ASCIIToWide andbrettw@chromium.org2010-08-031-0/+1
| | | | | | | | | | | | | | | ASCIIToUTF16. I removed string_util includes from a few places where it obviously wasn't needed. In a separate pass, I'm going to remove ASCIITo* from string_util, then I'm going to do an even later pass to find the unnecessary string_util.h includes and remove them. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3058027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54746 0039d316-1c4b-4281-b951-d872f2087c98
* Move the number conversions from string_util to a new file.brettw@chromium.org2010-07-302-4/+5
| | | | | | | | | | | | | Use the base namespace in the new file. Update callers. I removed all wstring variants and also the string->number ones that ignore the return value. That encourages people to write code and forget about error handling. TEST=included unit tests BUG=none Review URL: http://codereview.chromium.org/3056029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54355 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded headers from app/thestig@chromium.org2010-07-292-2/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2819063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54102 0039d316-1c4b-4281-b951-d872f2087c98
* `#pragma once` for app, base, chrome, gfx, ipc, net, skia, viewsthakis@chromium.org2010-07-265-0/+5
| | | | | | | | | BUG=50273 TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux TBR: erg git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity issues 9318, 9319: Uninitialized members in diagnostics_main.ccfinnur@chromium.org2010-07-241-3/+5
| | | | | | | | | BUG=None (Coverity issue id listed above) TEST=None Review URL: http://codereview.chromium.org/3047013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53594 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Break another common->app dependency.thestig@chromium.org2010-07-201-3/+5
| | | | | | | | BUG=46666 TEST=none Review URL: http://codereview.chromium.org/3007008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53113 0039d316-1c4b-4281-b951-d872f2087c98
* Upping the diagnostic mode limits for file sizecpu@chromium.org2010-07-141-2/+2
| | | | | | | | | | | | - The local state and the overall size of the profile dir BUG=42561 Review URL: http://codereview.chromium.org/2934019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52400 0039d316-1c4b-4281-b951-d872f2087c98
* diagnostics: Implement PosixConsole::Read function.tfarina@chromium.org2010-06-181-2/+9
| | | | | | | | | | BUG=42894 TEST=enable the "Press [enter] to continue" on Posix, run out/Debug/chrome --diagnostics and see if it can read the line. Review URL: http://codereview.chromium.org/2820009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50208 0039d316-1c4b-4281-b951-d872f2087c98
* diagnostics: Add VersionTest to linux.tfarina@chromium.org2010-06-172-1/+4
| | | | | | | | | | | Now with the mac build fixed. BUG=42894 TEST=out/Debug/chrome --diagnostics Review URL: http://codereview.chromium.org/2821009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50071 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 49875 - diagnostics: Add VersionTest to linux.michaeln@google.com2010-06-162-2/+1
| | | | | | | | | | | | BUG=42894 TEST=out/Debug/chrome --diagnostics Review URL: http://codereview.chromium.org/2856004 TBR=tfarina@chromium.org Review URL: http://codereview.chromium.org/2827010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49881 0039d316-1c4b-4281-b951-d872f2087c98
* diagnostics: Add VersionTest to linux.tfarina@chromium.org2010-06-162-1/+2
| | | | | | | | | BUG=42894 TEST=out/Debug/chrome --diagnostics Review URL: http://codereview.chromium.org/2856004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49875 0039d316-1c4b-4281-b951-d872f2087c98
* Posix: implement diagnostics mode console output.mattm@chromium.org2010-05-151-37/+144
| | | | | | | | | BUG=42894,42345 TEST=chrome --diagnostics Review URL: http://codereview.chromium.org/2115001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47348 0039d316-1c4b-4281-b951-d872f2087c98
* Changing linux platform for chromeos. This involved moving platform_util ↵dhg@chromium.org2010-04-291-1/+1
| | | | | | | | | | and extension_error_reporter to browser, so that the UIs surrounding them can be in the browser. BUG=none TEST=none Review URL: http://codereview.chromium.org/1705009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45986 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor FileVersionInfo into an interface with platform implementations.tony@chromium.org2010-04-141-1/+2
| | | | | | | | | | | | | This allows us to move the chrome specific version informaton used by Linux into src/chrome. Add a GetChromeVersionInfo() for Linux in src/chrome/app/ and make sure to use this in src/chrome. In src/webkit/glue, add a new glue method for getting the product version. When compiling chrome, use an implementation in src/chrome/renderer (which uses GetChromeVersionInfo()) and a stub implementation for test_shell. Review URL: http://codereview.chromium.org/1560027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44435 0039d316-1c4b-4281-b951-d872f2087c98
* Add diagnostic check for the Preferences filecpu@chromium.org2010-04-145-4/+90
| | | | | | | | | | | - Parses the json file BUG=27885 TEST=test modified Review URL: http://codereview.chromium.org/1609022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44429 0039d316-1c4b-4281-b951-d872f2087c98
* Allow specifiying a different user-data-dir for diagnostic modecpu@chromium.org2010-04-096-27/+62
| | | | | | | | | | | - Polish the db tests a little bit, now there are critical and non-critical and it handles better is chrome is already running BUG=27885 TEST=none Review URL: http://codereview.chromium.org/1540027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44122 0039d316-1c4b-4281-b951-d872f2087c98
* Include the appcache and database tracker databases into the sql diagnostics ↵michaeln@chromium.org2010-04-024-71/+69
| | | | | | | | | | | | fold. TEST=manual BUG=none Review URL: http://codereview.chromium.org/1508016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43534 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land sqlite diagnosticscpu@chromium.org2010-03-314-6/+125
| | | | | | | | | | | | | | - Forgot to update a stupid number in the tests See http://codereview.chromium.org/1548005 BUG=27885 TEST=included Review URL: http://codereview.chromium.org/1543006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43169 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-16 03:35:51 +0000