| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
To reduce the size of this change I've left stub header files in chrome/browser/dom_ui/.
I'll updated the references and delete the stub files later.
BUG=59945, 59946
TEST=trybots
Review URL: http://codereview.chromium.org/6538075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75660 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome/browser/webui. Part 5."
This reverts commit 1088003ee7026f2b830d2451f79ce772c44a7cea.
BUG=59945, 59946
TEST=trybots
TBR=avi@chromium.org
Original Review: http://codereview.chromium.org/6538053/
Review URL: http://codereview.chromium.org/6532069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75478 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome/browser/webui. Part 5.
BUG=59945, 59946
TEST=trybots
Review URL: http://codereview.chromium.org/6538053
TBR=tfarina@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75456 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Part 5.
BUG=59945, 59946
TEST=trybots
Review URL: http://codereview.chromium.org/6538053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Part 3.
BUG=59945, 59946
TEST=trybots
Review URL: http://codereview.chromium.org/6541006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75340 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=59945
TEST=trybots
Review URL: http://codereview.chromium.org/6478014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74395 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a typedef for WebUI to allow us renaming the class now, and then renaming the other entries in small chunks.
Also rename the file from dom_ui.[cc,h] to web_ui.[cc,h].
BUG=59945
TEST=trybots
Review URL: http://codereview.chromium.org/6458016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74386 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Rerun RenderWidgetHostUnitTest.*
Review URL: http://codereview.chromium.org/6010004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71238 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/5648004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68606 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=49113
TEST=none
Review URL: http://codereview.chromium.org/5088001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66709 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
sections if both sections were shown under the old version
of the ntp.
Also clean up some old cruft.
BUG=55610
TEST=Upgrade Chrome from an older version to a version with
this change with at least one app installed. Should see only
apps section. Do it with no apps installed, should see only
MV section.
Review URL: http://codereview.chromium.org/3393013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60216 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* When there are no apps, don't show the apps section.
* Expand the MV section by default, like it was in M6.
* Fix bug where recently closed is incorrectly toggleable.
* Stop showing miniview items for MV section when there is no more room.
* Don't show filler MV items in miniview.
* MV section is 5px too high because we were only apply extra padding
to the first section, even if that section was disabled.
TEST=Visual inspection.
Review URL: http://codereview.chromium.org/3292003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=eroman@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57492 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=eroman@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57478 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This doesn't do any behavior changes -- it just implements
the styling. So we still have multi expand, and the recently
closed section is still toggleable.
I also didn't make the changes to the placement or text of
the web store icon. I will make those separately.
Screen caps:
http://aaronboodman.com/z_dropbox/cr3156049/
BUG=53248
Review URL: http://codereview.chromium.org/3156049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
just added notification_observer.h.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3120021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56824 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DOMUIThumbnailSource objects are deleted on the IO thread, while they are used
on the UI thread. The DataSource documentation says that they should not live
on the IO thread, but for almost all DataSources, the only reference held is
the one by ChromeURLDataManager, which lives on the IO thread. Since I had a racy
stack where the object was being used on the UI thread while its destructor was
running on the IO thread, forcing destruction on the UI thread should fix
the crash.
Pretty much everything but changing the templated base class of DataSource to
always DeleteOnUIThread is my usual cleanup.
BUG=34115
TEST=none
Review URL: http://codereview.chromium.org/3061009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53873 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR: arv
BUG=49328
TEST=no bookmark bar promo on first run to empty profile. or ever.
Review URL: http://codereview.chromium.org/3053015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53804 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=50273
TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux
TBR: erg
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=49328
TEST=First tip seen on import to empty profile is import bookmarks promo. This promo appears on the first 5 browser restarts, unless bookmarks are imported.
Review URL: http://codereview.chromium.org/2805089
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52993 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
that works with all test prefixes (DISABLED, FLAKY, FAILS).
TEST=none
BUG=44549
Review URL: http://codereview.chromium.org/2439001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48634 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This changes the NTP to closer match Cole's mocks. Here are some of the differences:
1. Show app icons if the user has any extension apps installed
2. Remove most visited list. Only thumbnail support from now on.
3. Remove the checkboxes for list vs thumb mode.
4. Add a caption for the most visited section.
5. Make the captions click targets for toggling the sections.
6. Multiple collapsed sections are on the same line
7. Move tips to the upper right.
8. Fix bug where we always reserved padding for the promo messages which lead to scrollbars showing up in cases where we don't want them.
9. Use the App icon instead of a dummy icon
BUG=41270
TEST=Start with --enable-extension-apps and install some apps. These should show up on the NTP
Review URL: http://codereview.chromium.org/1646014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
95% of this is removing "const" from return types, but turning this
on found one bug! (A "for" loop that expected its iterator to go negative but
which was using an unsigned type.)
BUG=34160
Review URL: http://codereview.chromium.org/570012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38266 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It caused New Tab Warm on Windows to regress to the speed before adding
the cache on Windows.
This reverts commit r32899.
TBR=arv
Review URL: http://codereview.chromium.org/431024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
trip to the UI thread later. Not sure if this will make a
difference.
Move the NTP and CSS handler init to after adding the MostVistedHandler.
This should allow an earlier db fetch for the cases when the HTML/CSS
are not in the cache (e.g., browser startup).
Review URL: http://codereview.chromium.org/439013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32899 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
HTML for the NTP each time, keep a cached copy as part of the
profile.
- This changes the handling of StartDataRequest to always happen
on the UI thread since it needs to use the Profile. Previously
we would generate on the UI thread then handle all the requests
on the IO thread.
- first_view_ got changed into a static bool. I also removed it
from being added to the json because it didn't appear to be used
anywhere.
- Merge the incognito and regular handler into one since I added
that as a flag to the request in a previous change.
I plan to add the CSS to NTPResourceCache next.
BUG=23120
Review URL: http://codereview.chromium.org/399055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32520 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
chrome url request data sources. This will allow me to merge
IncognitoTabHTMLSource and NewTabHTMLSource and allow me clean
up DOMUIThemeSource, but those will be follow up changes.
Review URL: http://codereview.chromium.org/397019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32126 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DOMUIThemeSource and try to use it after it was deleted.
Instead, always cache the original profile pointer (which will
live longer).
While I'm here, get rid of the profile_ cached in
NewTabHTMLSource because we don't need it after the ctor is done
running.
BUG=26840
Review URL: http://codereview.chromium.org/372072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31513 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The bustage seems to be a WebKit change upstream. It is not reverted in
WebKit and merger. So bring the innocent change back in.
TBR=jam
TEST=green tree
Review URL: http://codereview.chromium.org/375009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31214 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
XP tests are failing, the guess is r31175 and r31176.
TBR=beng
TEST=XP tests go green
Review URL: http://codereview.chromium.org/376008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31201 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=26749
Review URL: http://codereview.chromium.org/361025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31175 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change adds 2 new menu items to the option menu.
There is pref migration code to make tips and sync visible by default.
BUG=24319
TEST=Hide and show the different sections and reload to make sure it
is persisted across instances of NTP.
Review URL: http://codereview.chromium.org/337011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(Working on cleaning chrome/ so hopefully we can lint it by default.)
Review URL: http://codereview.chromium.org/274040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28971 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/271057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28758 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
I'm going to be modifying this file a lot and the single big file
was hard to work with.
Review URL: http://codereview.chromium.org/265040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We were attaching the paint observer to the a RenderWidgetHost that
was getting immediately swapped out when the new tab page started
to load. Instead, wait and use the DOM UI callback methods which
happen right after NewTabUI is created.
Review URL: http://codereview.chromium.org/242115
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27850 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG= http://crbug.com/20392
TEST= Open several windows and new tabs. Change theme. Note that NTP background images all update correctly.
Review URL: http://codereview.chromium.org/243067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27841 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=17668
TEST=Run the test
Review URL: http://codereview.chromium.org/160108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21854 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Update the UI to not say tips or recommendations.
BUG=None
TEST=Starting chrome should not show any tips byt default
Review URL: http://codereview.chromium.org/160138
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21615 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG= none.
TEST= New NTP should come up with a default title in Tips and Suggestions box, then be loaded with actual data from popgadget.
Review URL: http://codereview.chromium.org/149255
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20466 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=arv
Review URL: http://codereview.chromium.org/151108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19651 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/150112
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19603 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This renames the command line flags a bit.
--new-tab-page=path/to/file.html
--old-new-tab-page
BUG=13362
TEST=Launch chrome and you should see the new new tab page.
Review URL: http://codereview.chromium.org/151054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19593 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/149116
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I changed the command line switch "--new-new-tab-page" to
"-new-tab-page=<path>" so we can continue to iterate.
BUG=13362
TEST=The new new tab page should be on by default.
Review URL: http://codereview.chromium.org/147226
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19438 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
and stores it in user prefs, where it can be used by the new tab page.
BUG = http://crbug.com/13363
Review URL: http://codereview.chromium.org/125052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=2381
Review URL: http://codereview.chromium.org/115607
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the prototype new new tab page.
Split the DownloadsDOMHandler into its own file.
The prototype is rough and has bugs. Don't file any bugs on it!
TEST=Run with the command line above and you should see an alternative
new tab page.
Review URL: http://codereview.chromium.org/115426
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16351 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115413
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16205 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16021 0039d316-1c4b-4281-b951-d872f2087c98
|