| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is in preparation to a subsequent CL where Singleton<T> will restrict access to only the type being made singleton.
This primarily covers files in chrome os and other directories, missed in the previous CL.
In a couple of files i changed Singleton<T> usage to LazyInstance<T>, because changing the method name to GetInstance() in there would require a whole lot of updates throughout the chrome os codebase.
BUG=65298
TEST=all existing tests should pass.
Review URL: http://codereview.chromium.org/5734002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69007 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is in preparation to a subsequent CL where Singleton<T> will restrict access to only the type being made singleton.
I also moved pepper::ResourceTracker to a lazy instance since there were too many places in code where this class was being accessed from and this was a smaller change than renaming methods in that case.
BUG=65298
TEST=all existing tests should pass.
Review URL: http://codereview.chromium.org/5685007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=64263
TEST=trybots
Review URL: http://codereview.chromium.org/5755004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68959 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
reporting option, the alert is obsolete.
BUG=none
TEST=Green tree and no 'restart required' alerts when enabling metrics in Chrome builds.
Review URL: http://codereview.chromium.org/4778002
TBR=csilv@chromium.org
Review URL: http://codereview.chromium.org/5752004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=64263
TEST=compiled locally, trybots
Review URL: http://codereview.chromium.org/5607004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68935 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
can be changed.
BUG=62875
TEST=none
Review URL: http://codereview.chromium.org/5799001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68923 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
option, the alert is obsolete.
BUG=none
TEST=Green tree and no 'restart required' alerts when enabling metrics in Chrome builds.
Review URL: http://codereview.chromium.org/4778002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68919 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Move the sync settings into the Personal Stuff page.
* Fix disabling input elements from JS.
* Fix handling of boolean prefs in select controls.
BUG=59279
TEST=none
Review URL: http://codereview.chromium.org/5779001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68918 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5682007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5762001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68809 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5629007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This still uses the old-style controls for adding and removing entries, but it moves them to the sub-page as an incremental step toward the mocks.
BUG=63817
TEST=The new Manage Startup Pages button in the Basics section should open a subpage where pages can be added and removed.
Review URL: http://codereview.chromium.org/5594006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68755 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
new GetInstance() method for remaining files with singleton classes under chrome/browser.
For types declared and used within the same .cc file, I changed them over to LazyInstance<T>.
BUG=65298
TEST=all existing tests should continue to pass.
Review URL: http://codereview.chromium.org/5711001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This patch introduces general support in PluginGroup for multiple version ranges with one minimum secure version each, to be used e.g. for multiple major versions currently supported by their manufacturer.
BUG=65207
TEST=test_shell_tests: PluginGroupTest*
Review URL: http://codereview.chromium.org/5621006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68726 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
files.
This CL includes half of the files under chrome/browser using Singleton<T>.
The rest of the files will be sent in a second CL.
In one case I used a LazyInstance<T> instead of Singleton<T> as that was simpler and necessary since T was a typedef and can't add member functions to it.
BUG=65298
TEST=all existing tests should continue to pass.
Review URL: http://codereview.chromium.org/5519016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68723 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/5648004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68606 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
it access the file system. Fix up a few call sites.
BUG=60825
TEST=none
Review URL: http://codereview.chromium.org/5566003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68533 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Original review: http://codereview.chromium.org/5320001/
Review URL: http://codereview.chromium.org/5625008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68515 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the beginning of the implementation of the infrastructure to support a DOMui based login screen. The login page that is in this is not meant to be a final version. The authentication currently does not actually use libcros, but instead is stubbed. I have uploaded this to get some review before proceeded with the authentication and hooking this into the system.
The login page is reached in the browser from chrome://login.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4457003
Patch from Ryan Harrison <rharrison@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68488 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5606008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68424 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=58763
TEST=manual
Review URL: http://codereview.chromium.org/5601003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68398 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5574003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68380 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The description for IDS_ABOUT_PAGE_TITLE (Title used for about options panel)
was ambiguous enough to confuse translators:
1. Title used for <about> <options panel> (original intention)
2. Title used for <about options> panel (misunderstanding)
And unfortunately for Japanese, 2 was translated.
2 ways to fix this, clarify the description or use IDS_ABOUT.
As title on the wrench menu use IDS_ABOUT ("About &PRODUCT_NAME"),
using IDS_ABOUT for the title for the options panel makes sense.
BUG=none
TEST=manually open chrome://settings/about (or wrench menu -> about) and see tht title displayed properly.
Review URL: http://codereview.chromium.org/5567001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68336 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5512009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68323 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- Remove 'Select trusted SSL certificates' text.
BUG=63841
TEST=visual
Review URL: http://codereview.chromium.org/5573008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68301 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=63820
TEST=visual
Review URL: http://codereview.chromium.org/5513006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68280 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5320001
TBR=thestig@chromium.org
Review URL: http://codereview.chromium.org/5529004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68244 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5320001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
update it.
BUG=57904
TEST=none
Review URL: http://codereview.chromium.org/5524004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68101 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
file_path_watcher into subdir
profile* into profiles/ subdir
login* into ui/login
visitedlink* into subdir
BUG=none
TEST=none
TBR=brettw
Review URL: http://codereview.chromium.org/5606002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68069 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Move the 'Enable Autofill' checkbox to the main page.
- Change 'Autofill options' to 'Manage Autofill settings'
BUG=63828, 63829
TEST=run chrome with --enable-tabbed-options, these two changes should be verified
on the Personal Stuff page.
Review URL: http://codereview.chromium.org/5379004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68060 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes a crash in which if a feedback tab is open and a user opens it from a different tab again, feedback will crash on sending a report. This is due to browser_navigator; this change decouples us from the Singleton tab logic and adds our own.
Additionally, code to take screenshots on other platforms is also added.
BUG=64971,61847
TEST=Tested by opening feedback from multiple tabs; sent reports successfully. Additionally tested with sending screenshots from Linux.
Review URL: http://codereview.chromium.org/5514001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tab_menu_model->ui/tabs
tab_contents_wrapper->ui/tab_contents
view_ids.h->ui
status_bubble.h->ui
options*->ui/options
show_options_url*->ui/options
location_bar*->ui/omnibox
input_window*->ui
browser_uitests->ui/tests
BUG=none
TEST=none
TBR=brettw
Review URL: http://codereview.chromium.org/5582002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68047 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
separate classes.
BUG=64753
TEST=compiles
Review URL: http://codereview.chromium.org/5574001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68005 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=19991
TEST=lock cert database with "certutil -d sql:.pki/nssdb -W", try to export a cert.
Review URL: http://codereview.chromium.org/5509001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67927 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:9737
TEST=Verify fix for chromium-os:9737
Review URL: http://codereview.chromium.org/5494001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67907 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=brettw
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67854 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The ChromeNetLog is now owned by the browser process,
and passed to the IOThread on creation.
NetLog entries can be added from any thread.
Observers must be able to handle having log entries added
from any thread. Observers can add/remove themselves on any
thread.
BUG=63334
TEST=None, yet
Review URL: http://codereview.chromium.org/4118004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67851 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=64153
TEST=manual
Review URL: http://codereview.chromium.org/5372006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
For official Windows builds only, remove the flag and turn on the cloud print
proxy setup UI.
BUG=60092
TEST=On an official Windows build, cloud print gone from about:flags, present in both tabbed and untabbed options (under the hood).
Review URL: http://codereview.chromium.org/5409001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67765 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=64263
TEST=compiled locally, trybots
Review URL: http://codereview.chromium.org/5384002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67762 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Default to show expanded apps (i.e. most visited and recently closed
secion is closed by default);
- Move closed section bar up to underneath the expanded sections;
- Add a seprate line between expanded and closed section bar;
- Change the closed section menu footer text to "Expand"
BUG=chromium-os:9737
TEST=Verify fix for chromium-os:9737 and no change to non chrome os version.
Review URL: http://codereview.chromium.org/5340007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67736 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=agl
BUG=53659
TEST=none
Review URL: http://codereview.chromium.org/4091005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67722 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=64660
TEST=build succeeds (no effective code change)
Review URL: http://codereview.chromium.org/5367006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67706 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=51105
TEST=None
Review URL: http://codereview.chromium.org/5259008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67702 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5139006
TBR=thestig@chromium.org
Review URL: http://codereview.chromium.org/5270010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67674 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/5271007/
BUG=chromium-os:8836,chromium:61847
TEST=Ran the new UI, checking and unchecking various boxes, trying different screenshots and submitting.
Review URL: http://codereview.chromium.org/5372007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67672 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=52451
TEST=Manually create app shortcuts for urls and apps.
Review URL: http://codereview.chromium.org/5273004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5139006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67662 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
.) UI matched to the Chrome settings DOM UI
.) User-mail is now unchangeable
.) Changed the screenshot input to a nicer toggle system
.) Saved screenshots are only now loaded when the user choses to see them
.) Check boxes for everything
.) Privacy policy added
.) Text changed around as per request by Chrome OS marketing
BUG=chromium-os:8836,chromium:61847
TEST=Ran the new UI, checking and unchecking various boxes, trying different screenshots and submitting. More tests being done by the feedback team.
Review URL: http://codereview.chromium.org/5271007
TBR=rkc@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67650 0039d316-1c4b-4281-b951-d872f2087c98
|