| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
TopSites has been enabed since r64072. It's now time to remove
the dead code.
BUG=69492
TEST=Make sure thumbnails are correctly updated as before. try bots.
Review URL: http://codereview.chromium.org/6283001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71634 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Manager.
BUG=69145
TEST=manual
Review URL: http://codereview.chromium.org/6307004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71616 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(This was a TODO for jhawkins).
BUG=None
TEST=manual
Review URL: http://codereview.chromium.org/6344004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71615 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the default yellow one.
BUG=69704
TEST=bookmark folder icons are blue in the WEBUI bookmark manager
Review URL: http://codereview.chromium.org/6331003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6335001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71547 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=64263
TEST=compiled locally, trybots
Review URL: http://codereview.chromium.org/6338002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71522 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=23581
TEST=no visible changes; all tests pass
Review URL: http://codereview.chromium.org/6322001
TBR=avi@chromium.org
Review URL: http://codereview.chromium.org/6291003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71500 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23581
TEST=no visible changes; all tests pass
Review URL: http://codereview.chromium.org/6322001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71485 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also moves more common code into InlineEditableItem, and fixes some styling issues with inline-editable lists.
BUG=63817
TEST=Startup pages should be editable in DOMUI prefs. Also, the lead selection in an editable list should show top and bottom borders.
Review URL: http://codereview.chromium.org/6303003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71464 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Return NULL when GetProfileSyncService() is called without a cros_user
argument (if not already initialized) and protect the settings code when
sync service is NULL.
A side effect of this is that sync will be disabled if chrome is not started
from the login screen in ChromeOS (e.g. when debugging), instead of being
initialized without a valid backend, so e.g. settings will not have a sync
section, and about:sync will show 'sync disabled'.
BUG=chromium-os:10777,chromium-os:10893
TEST=Test proxy settings from login screen, sync settings page, and about:sync.
Review URL: http://codereview.chromium.org/6260002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71457 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
builder per thestig's suggestion fixed the flakiness).
BUG=69389
TEST=none
Review URL: http://codereview.chromium.org/6289002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71449 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=brettw
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71446 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=58235
TEST=none
Review URL: http://codereview.chromium.org/6260003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71436 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Write chrome://sync-internals DOMUI page which is like about:sync but
automatically updates on sync events.
Make about:sync{,-internals} aliases for chrome://sync-internals.
More diagnostic capabilities will be added to chrome://sync-internals
in future CLs.
BUG=69500
TEST=Manual
Review URL: http://codereview.chromium.org/6299002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=67218
TEST=Remoting status is shown on the advanced options page.
Review URL: http://codereview.chromium.org/6214003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71410 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6260001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71368 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
killed instead of crashing.
It also adds "about:kill" to simulate kills.
On ChromeOS killed tabs will be reloaded as soon as the user clicks on them unless they are the only tab, or the currently focused tab is killed.
BUG=http://crosbug.com/10043, http://crosbug.com/10711
TEST=Built linux and ChromeOS Chrome and killed a tab, and then did about:crash and made sure that the "Aw, Snap!" page was displayed. Did about:kill and made sure kill page was displayed.
Review URL: http://codereview.chromium.org/6053012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71360 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=open cert manager, try to import non-existent file / etc
Review URL: http://codereview.chromium.org/6277001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71346 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
dialog is checked.
BUG=58235
TEST=none
Review URL: http://codereview.chromium.org/6122008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71304 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=64263
TEST=compiled locally, trybots
Review URL: http://codereview.chromium.org/6166010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71285 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use pref ui for <select> where possible. This simplifies the zoom select and fixes the sync select.
Also add more error checking.
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/6174009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71284 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6122006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71283 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This was based off of davidben's WIP cl http://codereview.chromium.org/3186021/show.
BUG=42073
TEST=add password to NSS DB with "certutil -d sql:.pki/nssdb -W", try client auth, <keygen>, cert manager
Review URL: http://codereview.chromium.org/5686002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71281 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Rerun RenderWidgetHostUnitTest.*
Review URL: http://codereview.chromium.org/6010004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71238 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Mark PrintPreviewUITest.PrintCommandDisabled flaky.
BUG=69389,69390
TEST=none
Review URL: http://codereview.chromium.org/6184003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71175 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(This was a TODO for phajdan.jr).
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/6188004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also removed console spam while I'm here.
BUG=63842
TEST=none
Review URL: http://codereview.chromium.org/6155008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71126 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Validation feedback still needs polish, but this is completely functional, so I'll leave that for a follow-up.
This introduces a new shared class for editable lists; we should migrate the existing editable lists to it, expanding as necessary, but I didn't want to make this patch too unwieldly.
BUG=63825,61742
TEST=Search engines should be editable and addable inline in DOMUI prefs.
Review URL: http://codereview.chromium.org/6151004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71121 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Change hide message from 'Hide this message' to 'No thanks, hide this'.
2. Hide promo text when a default app is launched (this was already happening on uninstall).
3. Uninstall default apps when promo expires or is purposefully hidden.
4. Collapse apps section when promo expires or is purposefully hidden.
BUG=67292,69268
TEST=none
Review URL: http://codereview.chromium.org/6162006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It should now match the mocks modulo the adobe flash settings link (not sure why the mocks show it as a checkbox; AFAIK making it a checkbox is outside our ability to do).
also make it work (the time period select dropdown was broken).
BUG=69163,63843
TEST=manual
Review URL: http://codereview.chromium.org/6110006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71090 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6086003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70978 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Update references to use headers in chrome/browser/ui/views.
Update copyright dates in affected files.
/chrome/browser/ui/views/constrained_html_delegate_win.cc
Add space before 'private' label (presubmit warning)
/chrome/browser/ui/views/toolbar_view.cc
Add space before 'cleanup' label (presubmit warning)
BUG=69082
TEST=Compiling...
Review URL: http://codereview.chromium.org/6204002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70965 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added a new method to browser window to get a screenshot in a platform independent way.
Changed user feedback UI code to use the new method.
BUG=65119
TEST=Tested with sending feedback with the new code. Screenshots are being taken and sent correctly.
Review URL: http://codereview.chromium.org/6145001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70951 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6149003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70946 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
UITestBase into ProxyLauncher.
The primary changes are in ui_test.* and proxy_launcher.*. The changes in the remaining files are mostly just changing namespaces from UITestBase:: to ProxyLauncher::.
BUG=None.
TEST=All tests should pass. No functionality change.
Review URL: http://codereview.chromium.org/5967003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70827 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
require a passphrase the first time.
BUG=63014,58935
TEST=test
Review URL: http://codereview.chromium.org/5563004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70825 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This should fix the bug, crbug.com/68548, where the process limit is not honored when process per tab is defined.
BUG=6106003
Review URL: http://codereview.chromium.org/6106003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70815 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=59972
TEST=none
Review URL: http://codereview.chromium.org/6177002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=brettw
Review URL: http://codereview.chromium.org/6154001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add column header for data.
Move the Learn more link to appear last.
BUG=51105
TEST=None
Review URL: http://codereview.chromium.org/5981012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70727 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
under-the-hood have changed. More tests on the way.
BUG=30519,62753
TEST=unit_tests,sync_integration_tests
Review URL: http://codereview.chromium.org/5705004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70645 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=67218
TEST=None
Review URL: http://codereview.chromium.org/5974012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70577 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
settings" button is pressed.
BUG=63690
TEST=webui version does not crash in debug builds, native version no longer needs temporary exception
Review URL: http://codereview.chromium.org/5969011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70557 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=59281
TEST=none
Review URL: http://codereview.chromium.org/6083007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70476 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
are installed in webstore-non-supported locales.
BUG=67073
Review URL: http://codereview.chromium.org/6040005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70463 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and a lot of events are being logged in a short period.
Does this by collecting events on the IO thread, and then
sending them all off to Javascript event 100 ms.
Also makes net-internals event ordering match the order they're handled by the ChromeNetLog. I believe that currently all sources live on a single thread, so don't think that matters a whole lot right now, but you never know...
BUG=57214
TEST=manual
Review URL: http://codereview.chromium.org/5918002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70417 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=28174
TEST=manual
Review URL: http://codereview.chromium.org/6063007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70404 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/5977010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fix up callers to use the new location & namespace. Remove includes from
files where it wasn't necessary.
TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/6046009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70359 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/6028009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70345 0039d316-1c4b-4281-b951-d872f2087c98
|