| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
To reduce the size of this change I've left stub header files in chrome/browser/dom_ui/.
I'll updated the references and delete the stub files later.
BUG=59945, 59946
TEST=trybots
Review URL: http://codereview.chromium.org/6538075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75660 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
preview data.
To display initial page range text, we need expected pages count value. Therefore, I added a |expected_pages_count| field to ViewHostMsg_DidPreviewDocument_Params structure.
BUG=none
TEST=Enable print preview on mac. In the preview tab after loading the preview data an initial page range text is displayed.
Review URL: http://codereview.chromium.org/6542002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75599 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The last references to chrome/browser/dom_ui/options/* have been updated so it's
safe to delete the stub headers.
BUG=59945, 59946
TEST=compiled locally and trybots
Review URL: http://codereview.chromium.org/6542033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75501 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To reduce the size of this change I've left stub header files in chrome/browser/dom_ui/options.
I'll updated the references and delete the stub files later.
BUG=59945, 59946
TEST=trybots
Review URL: http://codereview.chromium.org/6469067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75496 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome/browser/webui. Part 5."
This reverts commit 1088003ee7026f2b830d2451f79ce772c44a7cea.
BUG=59945, 59946
TEST=trybots
TBR=avi@chromium.org
Original Review: http://codereview.chromium.org/6538053/
Review URL: http://codereview.chromium.org/6532069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75478 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There seemed to be a timing issue on Mac and non-views Linux build that
prevented the button handlers from being properly installed. By always
installing the handlers and basing their behavior on the visibility of the ui
instead, things work on all platforms.
BUG=none
TEST=Start up Mac Chromium with --enable-cloud-print-proxy, go to Under the Hood, and try to start cloud print - with this patch, the sign in UI will start.
Review URL: http://codereview.chromium.org/6541027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75458 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome/browser/webui. Part 5.
BUG=59945, 59946
TEST=trybots
Review URL: http://codereview.chromium.org/6538053
TBR=tfarina@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75456 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Part 5.
BUG=59945, 59946
TEST=trybots
Review URL: http://codereview.chromium.org/6538053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
promo-related code into a new PromoResourceService class that inherits WebResourceService.
This refactoring will allow us to re-use WebResourceService class for GPU Blacklist updates purpose.
This CL tries to minimize the code change and adds no new logic.
BUG=68802
TEST=unittest,promo functions working fine as before.
Review URL: http://codereview.chromium.org/6542003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75403 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
clicks the "Make Chrome my default browser" button, we should reset the browser.check_default_browser to true.
BUG=73208
TEST=Follow steps listed in bug, observe that the infobar again shows up.
Review URL: http://codereview.chromium.org/6542018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75401 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Part 4.
BUG=59945, 59946
TEST=trybots
Review URL: http://codereview.chromium.org/6532045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75380 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Part 3.
BUG=59945, 59946
TEST=trybots
Review URL: http://codereview.chromium.org/6541006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75340 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The theme on the gallery that corresponds to classic has a real extension id
that we need to detect. By the time the BrowserThemeProvider can detect it, it
has already been unpacked so just hard code the extension ID into chrome.
BUG=67751
TEST=Install a theme, verify that 'use classic theme' is enabled, install Default theme, verify that 'use classic theme' is disabled
Review URL: http://codereview.chromium.org/6532033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75321 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Part 2.
BUG=59945, 59946
TEST=trybots
Review URL: http://codereview.chromium.org/6531028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75315 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Enable print preview on Mac, make sure print button in print preview works.
Review URL: http://codereview.chromium.org/6479004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75302 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
builder per thestig's suggestion fixed the flakiness).
BUG=69389
TEST=none
Review URL: http://codereview.chromium.org/6289002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75291 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change adds a simple DOMUI interface to the HSTS list. Since the
list is stored, hashed in memory and on disk, there's no list of
entries. But the set can be queried and we can provide insertion and
deletion.
BUG=none
TEST=Open about:net-internals, goto HSTS tab.
Review URL: http://codereview.chromium.org/6500010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75282 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This policy allows for locking the user to download files only to the specified location.
When the policy is set the UI elements should be inactive and the save dialog should never appear.
Changes in the Preferences.xib file only wire the enabled status of the download location and save prompt checkbox elements to a variable that tracks the managed state of the DefaultDownloadDir pref. No UI elements were harmed in this change.
BUG=59768
TEST=All old download manager tests shouldn't break. UI should behave correctly when policy is set.
Review URL: http://codereview.chromium.org/6525054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75255 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
chrome/browser/webui.
BUG=59946, 59945
TEST=trybots
Review URL: http://codereview.chromium.org/6539004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75252 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=72750
TEST=More DownloadTests should pass on ChromeOS.
Review URL: http://codereview.chromium.org/6525033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75181 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
undercounts apps that are launched via a URL that redirects to the app's web extent.
BUG=62410
TEST=None.
Review URL: http://codereview.chromium.org/6312189
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75122 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
duplicating the names. Especially as it'll be easy for the two to
diverge, but I'm going with it for these reasons:
. It avoids timing problems between when Add is invoked and when the
IO thread processes it.
. It avoids having to make ChromeURLDataManager know about its
Backend.
. It avoids any synchronization code.
I plan on using it to avoid registering a DataSource that has already
been registered.
BUG=52022
TEST=none
Review URL: http://codereview.chromium.org/6517014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74960 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=59945
TEST=trybots
Review URL: http://codereview.chromium.org/6499004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74950 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
They were found with:
$ git gs dom_ui_
$ git gs ::DOM_UI
BUG=59945
TEST=trybots
Review URL: http://codereview.chromium.org/6520019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DOM UI options handler cleanup:
- improve StripColon
- remove superfluous parens (clang would catch these if they weren't inside ifdefs)
- move a couple more files to the abbreviated string definition style
- use SetBoolean rather than SetString("true")
BUG=none
TEST=trybots
Review URL: http://codereview.chromium.org/6484046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74880 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/6484043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74879 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Middle-click does the same. Note that some apps default to opening
in a new tab.
Also consolidated code to compute window disposition from a click for
GTK, Views and DOM UI.
BUG=chromium-os:7555
TEST=Install an app that normally loads in the same tab as the new tab page,
like Notepad:
https://chrome.google.com/webstore/detail/imflbkfmiojnkhopijhajoodloaklbln?hl=en-US#
* Click on Notepad. Verify it launches in same tab
* Control-click on it. Verify opens in new tab
* Middle-click on it. Verify opens in new tab
* Right-click, select "Notepad" from menu. Verify launches in same tab
* Right-click, set Notepad to launch in new window. Control-click on Notepad. Verify it launches in a new window, and the new tab page is still open.
* Also try loading a normal web page, then control-clicking on links, control-shift-clicking on links, and shift-clicking on links. Verify behavior matches last release.
Review URL: http://codereview.chromium.org/6293024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74877 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=51726
TEST=Unit tests
Review URL: http://codereview.chromium.org/6474015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74875 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6513006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74868 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DOM UI options handler cleanup:
- improve StripColon
- remove superfluous parens (clang would catch these if they weren't inside ifdefs)
- move a couple more files to the abbreviated string definition style
- use SetBoolean rather than SetString("true")
BUG=none
TEST=trybots
Review URL: http://codereview.chromium.org/6525005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- improve StripColon
- remove superfluous parens (clang would catch these if they weren't inside ifdefs)
- move a couple more files to the abbreviated string definition style
- use SetBoolean rather than SetString("true")
BUG=none
TEST=trybots
Review URL: http://codereview.chromium.org/6490016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74860 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:11931
TEST=Test various sync errors.
Review URL: http://codereview.chromium.org/6512008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74853 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=59945
TEST=trybots
Review URL: http://codereview.chromium.org/6519012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74839 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Wording change from "Restart" to "Relaunch" when pertaining to relaunchinging the application after an update. The word "Restart" is specific to restarting the machine as a whole, and "Relaunch" pertains to relaunching a particular application. Making this change across platforms.
BUG=69998
TEST=Visual inspection
Review URL: http://codereview.chromium.org/6510009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74820 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change adds "FAILS_" prefix to NavBeforeNTPCommits, AboutHangInNTP, and NTPHasThumbnails on Linux and Mac since it started failing since around r74087.
TBR=rvargas,dmazzoni,yusukes
BUG=72286
TEST=make the debug bots green.
Review URL: http://codereview.chromium.org/6447001
TBR=hbono@chromium.org
Review URL: http://codereview.chromium.org/6475007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74790 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was found with:
$ git gs "[Dd][Oo][Mm][Uu][Ii]"
BUG=59945
TEST=trybots
Review URL: http://codereview.chromium.org/6518001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74773 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=59945
TEST=trybots
Review URL: http://codereview.chromium.org/6513010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74771 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=59945
TEST=trybots
Review URL: http://codereview.chromium.org/6480046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Turns out it's used after all.
BUG=none
TEST=chrome://settings doesn't say undefined in huge letters at the top left
Review URL: http://codereview.chromium.org/6513005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=59945
TEST=trybots
Review URL: http://codereview.chromium.org/6507014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74721 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=72274
TEST=manual
Review URL: http://codereview.chromium.org/6507002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74715 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=59945
TEST=trybots
Review URL: http://codereview.chromium.org/6507012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=59945
TEST=trybots
Review URL: http://codereview.chromium.org/6512002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74703 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=70097
TEST=unit tests
Review URL: http://codereview.chromium.org/6488013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74695 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= 59945
TEST=trybots
Review URL: http://codereview.chromium.org/6485016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74681 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compile
Review URL: http://codereview.chromium.org/6485017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74658 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
A few files were missed in a previous refactor (http://codereview.chromium.org/6480001/).
BUG=72040
TEST=none
Review URL: http://codereview.chromium.org/6488006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74568 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=72274
TEST=no visible change for now
Review URL: http://codereview.chromium.org/6461012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74533 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CreateNewFolder should be on file thread.
Delete TaskProxy on ui thread where applicable.
Use scoped_refptr for TaskProxy lifetime management.
Deprecate use of current_task_ as much as possible by using function args instead.
Fix a bug where certain actions cannot be performed running Cros chrome on linux due to over-zealous security. This includes downloads, deletes and copies.
Filter out .crdownload files.
Fix lint errors.
BUG=chromium-os:8130
TEST=Create a folder using advanced filesystem Save As dialog in debug mode, threading asserts should no longer fire. Download a large non-dangerous file, .crdownload file should no longer appear.
Review URL: http://codereview.chromium.org/6246118
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74524 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A few files were missed in a previous refactor (http://codereview.chromium.org/6480001/).
BUG=72040
TEST=none
Review URL: http://codereview.chromium.org/6488006
TBR=backer@chromium.org
Review URL: http://codereview.chromium.org/6488012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74520 0039d316-1c4b-4281-b951-d872f2087c98
|