summaryrefslogtreecommitdiffstats
path: root/chrome/browser/dom_ui
Commit message (Collapse)AuthorAgeFilesLines
* Move pref_{member,service} and important_file_writer from chrome/commonphajdan.jr@chromium.org2010-02-197-8/+8
| | | | | | | | | | | | | to chrome/browser. This is a part of an effort to remove bad dependency of chrome/common on chrome/browser. TEST=unit_tests and ui_tests, just moving code BUG=none Review URL: http://codereview.chromium.org/621004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39428 0039d316-1c4b-4281-b951-d872f2087c98
* Pulled out Callback code into base/callback.h. This is the first step ↵akalin@chromium.org2010-02-1913-1/+13
| | | | | | | | | | | | | towards redoing the Callback interfaces. Added and removed includes as needed. BUG=35223 TEST=trybots Review URL: http://codereview.chromium.org/646061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39419 0039d316-1c4b-4281-b951-d872f2087c98
* Change hardcoded "chrome" scheme to constant.jochen@chromium.org2010-02-161-9/+8
| | | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/604030 Patch from Bernhard Bauer <bauerb@google.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39092 0039d316-1c4b-4281-b951-d872f2087c98
* Adding deletion to filebrowser, adding pause/resume to shelf.dhg@chromium.org2010-02-121-15/+120
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/597055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38934 0039d316-1c4b-4281-b951-d872f2087c98
* Do not delete cookies when deleting history.jochen@chromium.org2010-02-111-1/+0
| | | | | | | | | BUG=35302 TEST=delete history of last day, check cookies Review URL: http://codereview.chromium.org/593046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38723 0039d316-1c4b-4281-b951-d872f2087c98
* Only show one FileBrowse pop up for the same folderxiyuan@chromium.org2010-02-102-15/+42
| | | | | | | | | | | | Check existing FileBrowse pop ups before opening new one so that we only show one per folder; BUG=none TEST=On ChromeOS, download multiple files to default downloads dir and there should be only one FileBrowse pop up showing up. Review URL: http://codereview.chromium.org/601013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38624 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Reduce header dependencies in chrome.phajdan.jr@chromium.org2010-02-091-0/+1
| | | | | | | | | BUG=none TEST=If it compiles it is perfect. Review URL: http://codereview.chromium.org/585008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38463 0039d316-1c4b-4281-b951-d872f2087c98
* linux: build with -Wextraevan@chromium.org2010-02-054-10/+10
| | | | | | | | | | | | 95% of this is removing "const" from return types, but turning this on found one bug! (A "for" loop that expected its iterator to go negative but which was using an unsigned type.) BUG=34160 Review URL: http://codereview.chromium.org/570012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38266 0039d316-1c4b-4281-b951-d872f2087c98
* Show the filebrowse ui rather than the download shelf in chromeos.xiyuan@chromium.org2010-02-052-2/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This cl displays the filebrowse ui rather than download shelf for downloads in chrom(e|ium) os. It conditionally replaces (with preprocessor macros) the Browser::OnStartDownload method to do this. The cl adds a static FileBrowseUI::OpenPopup(profile, hashArgument), which opens the file browse ui and passes it the provided hash argument. This is invoked directly from Browser::OnStartDownload. The USBMountObserver code was changed to call this static method, rather than open the popup by hand as it had been doing. I'm not sure about ownership of the Browser* returned by OpenPopup, but based on other code in the tree I assume chrome will deal with freeing it when appropriate. Before this change, USBMountObserver would add the window to registrar_ *before* showing it. Now that FileBrowseUI::OpenPopup returns a which which is already visible, this is no longer the case. I assume this won't be a problem. Commit this for rginda. Original review: http://codereview.chromium.org/555167 BUG=none TEST=none Review URL: http://codereview.chromium.org/564022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38222 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor chromeos cros files into subdir 'cros'chocobo@chromium.org2010-02-041-1/+1
| | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/572012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38128 0039d316-1c4b-4281-b951-d872f2087c98
* BSD port: another chunk of chrome/browser ifdef cleaningpvalchev@google.com2010-02-031-4/+4
| | | | | | Review URL: http://codereview.chromium.org/553153 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38004 0039d316-1c4b-4281-b951-d872f2087c98
* Replace GtkFileChooser with file browser for ChromeOSxiyuan@chromium.org2010-01-294-121/+136
| | | | | | | | | | | | | - Remove dialogs_gtk.cc and add select_file_dialog.cc for chrome os build; - select_file_dialog.cc provides a SelectFileDialogImpl that serves file browse html via HTMLDialogUI; BUG=none TEST=none Review URL: http://codereview.chromium.org/543137 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37547 0039d316-1c4b-4281-b951-d872f2087c98
* Revert previously disabled mac tests.rohitrao@chromium.org2010-01-291-6/+0
| | | | | | | | | | Reverts the following cls: 37467, 37475, 37481, 37486, 37488, 37489, 37494 BUG=33451 TEST=Please please pass. Review URL: http://codereview.chromium.org/558047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37536 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: remove obsolete references to chrome://inspector/yurys@chromium.org2010-01-291-7/+0
| | | | | | Review URL: http://codereview.chromium.org/558040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37505 0039d316-1c4b-4281-b951-d872f2087c98
* Disable NewTabUITest.HomePageLinkvictorw@chromium.org2010-01-291-0/+3
| | | | | | | | | | TBR=aa BUG=33451 TEST=mac bot ui test green Review URL: http://codereview.chromium.org/552226 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37481 0039d316-1c4b-4281-b951-d872f2087c98
* Temporaily disable crashing NewTabUITestvictorw@chromium.org2010-01-291-1/+1
| | | | | | | | | | TBR=aa BUG=33451 TEST=mac bot green Review URL: http://codereview.chromium.org/554126 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37475 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily disable crashing UI test.aa@chromium.org2010-01-291-0/+3
| | | | | | TBR=darin@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37467 0039d316-1c4b-4281-b951-d872f2087c98
* Add promo for extensions and bookmark sync back into the Mac NTP. Also, fix ↵mirandac@chromium.org2010-01-271-6/+0
| | | | | | | | | | | | | font size bug that snuck in with a recent webkit roll. BUG= 33291 TEST= run a Mac build with a new profile. See the extension / sync promo line and the puzzle piece on the NTP. Review URL: http://codereview.chromium.org/552193 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37334 0039d316-1c4b-4281-b951-d872f2087c98
* Split platform specific settings out from locale_settings.grd so we cantony@chromium.org2010-01-221-2/+1
| | | | | | | | | | | | | | | | | | have per platform config and overrides. This is easier to manage than the mess of <if>'s in the existing grd and xtb files. Each platform only builds its locale_settings_{win,mac,linux}.grd file. All the grd files generate the same platform_locale_settings.h header (for easy inclusion in .cc files). We use the fallback feature of grit to only specify locale specific values in xtb files if we want to override the default for the locale. BUG=28590 Review URL: http://codereview.chromium.org/545132 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36849 0039d316-1c4b-4281-b951-d872f2087c98
* Adding tab browsing for filebrowser.xiyuan@chromium.org2010-01-201-6/+80
| | | | | | | | | | | Committing this CL on dhg's behalf. Original Review: http://codereview.chromium.org/542083 BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36675 0039d316-1c4b-4281-b951-d872f2087c98
* The search terms are escaped using + or %20 for space depending on whether ↵avayvod@google.com2010-01-151-1/+1
| | | | | | | | | | | | replacement is in query part of the URL or not. Removed duplicate EscapeQueryParamValue functions without |use_plus| argument. BUG=24571 TEST=Verify that space is escaped as stated in description; see bug description for example with search on Wikipedia. Review URL: http://codereview.chromium.org/543077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36398 0039d316-1c4b-4281-b951-d872f2087c98
* Support dragging a virtual file out of the browser.jianli@chromium.org2010-01-151-0/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/351029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36378 0039d316-1c4b-4281-b951-d872f2087c98
* Show the sync login dialog in response to NTP sync link being clicked when ↵tim@chromium.org2010-01-131-0/+7
| | | | | | | | | | | | | | | the sync service is showing an INVALID_GAIA_CREDENTIALS or CAPTCHA_REQUIRED auth error, instead of just showing the 'Synced to ...' yellowbox. BUG=32116 TEST=manually generated auth error, observed NTP sync error, clicked re-login link, observed login dialog opened. Review URL: http://codereview.chromium.org/541038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36076 0039d316-1c4b-4281-b951-d872f2087c98
* 1. Increase the width for 'date-container' in download.html to 110px to make ↵jshin@chromium.org2010-01-111-1/+12
| | | | | | | | | | | | | | | room for dates in some languages. Increase the margin-left (LTR) and margin-rigth(RTL) accordingly. 2. Decrease the web font size (dom UI font size) for Bengali on Vista or later to 84% (the same value as used for English) while using 110% for XP. This is done by introducing a new 'string' (IDS_WEB_FONT_SIZE_XP) on Windows (other platforms won't get this). BUG=21699 TEST=Run Chrome with '--lang=ml' (--lang=kn, --lang=bn) on Windows and go to the download page. Make sure that dates are in a single line. Review URL: http://codereview.chromium.org/381009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35908 0039d316-1c4b-4281-b951-d872f2087c98
* linux: reduce header interdependenciesevan@chromium.org2009-12-292-0/+2
| | | | | | | | | | | | By analyzing gcc -H output, I found some of our worst offenders for headers bringing in other headers. native_web_keyboard_event.h was responsible for just under 60,000 extra includes! This change will in theory make the build faster. Review URL: http://codereview.chromium.org/524004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35326 0039d316-1c4b-4281-b951-d872f2087c98
* [More BTP includes.]erg@google.com2009-12-181-0/+1
| | | | | | | | | | | | | | | | | | | | | | Uninstall themes when all theme infobars are gone; not on each infobar's destruction. There are multiple problems with the current implementation: - It handles multiple tabs with theme install infobars badly. - It has a subtle race condition where installing a second theme, and then installing the original theme (note: not clicking undo) uninstalled both themes. Instead, only uninstall unused themes when all infobars are closed down. BUG=none TEST=Install theme A. Install theme B. Install theme A. Restart chrome. Theme A should show. TEST=Install theme A in window 1. Install theme B in window 2. Install theme C in window 3. Clicking undo in any of those windows in any order should work. Previous Review URL: http://codereview.chromium.org/504052 Review URL: http://codereview.chromium.org/501096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34900 0039d316-1c4b-4281-b951-d872f2087c98
* TBR: Revert to fix Chromos.erg@google.com2009-12-171-1/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34891 0039d316-1c4b-4281-b951-d872f2087c98
* Uninstall themes when all theme infobars are gone; not on each infobar's ↵erg@google.com2009-12-171-0/+1
| | | | | | | | | | | | | | | | | | | | destruction. There are multiple problems with the current implementation: - It handles multiple tabs with theme install infobars badly. - It has a subtle race condition where installing a second theme, and then installing the original theme (note: not clicking undo) uninstalled both themes. Instead, only uninstall unused themes when all infobars are closed down. BUG=none TEST=Install theme A. Install theme B. Install theme A. Restart chrome. Theme A should show. TEST=Install theme A in window 1. Install theme B in window 2. Install theme C in window 3. Clicking undo in any of those windows in any order should work. Review URL: http://codereview.chromium.org/504052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34890 0039d316-1c4b-4281-b951-d872f2087c98
* Don't show "show in foloder" in chrome os.oshima@chromium.org2009-12-171-2/+5
| | | | | | | | | BUG=chromiun-os:916 TEST=None Review URL: http://codereview.chromium.org/506045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34837 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the "Bookmark sync" menu itemarv@chromium.org2009-12-151-19/+5
| | | | | | | | | | | | This also cleans up the states. BUG=28419 TEST=The menu item should be gone but we should still see errors from bookmark sync on the NTP Review URL: http://codereview.chromium.org/501029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34608 0039d316-1c4b-4281-b951-d872f2087c98
* Creating new CL for uploading a picture from ChromiumOSdavemoore@chromium.org2009-12-111-9/+177
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/452016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34351 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the crashing chromeos sync tests and revert the patch that disabled them.albertb@google.com2009-12-101-14/+3
| | | | | | | | BUG=29994 Review URL: http://codereview.chromium.org/490007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34283 0039d316-1c4b-4281-b951-d872f2087c98
* Disables a handful of tests for chromeos as they're crashing.sky@chromium.org2009-12-101-3/+14
| | | | | | | | | | BUG=29994 TEST=none TBR=albertb Review URL: http://codereview.chromium.org/486013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34254 0039d316-1c4b-4281-b951-d872f2087c98
* A collection of fixes allowing the chrome.experimental.popup.* set of APIs ↵twiz@google.com2009-12-101-1/+1
| | | | | | | | to function in circumstances where there is no Browser instance present. This is a symptom of a tab-contents view hosted in an ExternalTabContainer.The major change here is the removal of the explicit dependency on a Browser instance across all of the delegates involved when showing a pop-up API. I modified the following delegates:- ExtensionPopupHost::Delegate- TabContentsDelegate- ExtensionFunctionDispatcher::DelegateBecause the pop-up requires a Profile, and a gfx::NativeWindow, I added methods to the above interfaces to provide them.BUG=noneTEST=ExtensionApiTest.FLAKY_Popup Review URL: http://codereview.chromium.org/434046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34219 0039d316-1c4b-4281-b951-d872f2087c98
* Created HtmlDialogTabContentsDelegate, which encapsulates the ↵akalin@chromium.org2009-12-033-0/+331
| | | | | | | | | | | | | TabContentsDelegate behavior for HTML dialogs. Made all three implementations (gtk, win32, and cocoa) use it. This also makes HTML dialogs not tied to a Browser instance. Also, unlike the current behavior, any links followed from an HTML dialog box will be opened in a non-incognito browser, even if the HTML dialog was launched from an incognito browser. According to beng, this is okay. BUG=28609 TEST=unittests, manual testing on linux/windows/os x with sync setup wizard Review URL: http://codereview.chromium.org/441011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33752 0039d316-1c4b-4281-b951-d872f2087c98
* Change WideToASCII to WideToUTF8 to ensure that CJK tips are properly displayed.mirandac@chromium.org2009-12-031-1/+1
| | | | | | | | | BUG= none TEST= CJK tips should display properly. Review URL: http://codereview.chromium.org/467003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33712 0039d316-1c4b-4281-b951-d872f2087c98
* Notify user that Chrome is already synced if promo banner "sync me" link is ↵mirandac@chromium.org2009-12-032-2/+7
| | | | | | | | | | | clicked. BUG= 28795 TEST= sync bookmarks, then click "sync" link in promo again. see notification that you are already synced. Review URL: http://codereview.chromium.org/462011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33685 0039d316-1c4b-4281-b951-d872f2087c98
* Put "make this my home page" link into the tip section.mirandac@chromium.org2009-12-024-20/+43
| | | | | | | | | | | BUG= 28196 TEST= "make this my home page" should show up as a tip. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33527 Review URL: http://codereview.chromium.org/449073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33609 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Reduce header dependencies in chrome.phajdan.jr@chromium.org2009-12-022-0/+2
| | | | | | Review URL: http://codereview.chromium.org/457025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33561 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 33527 - Put "make this my home page" link into the tip section.mirandac@chromium.org2009-12-023-32/+12
| | | | | | | | | | | | BUG= 28196 TEST= "make this my home page" should show up as a tip. Review URL: http://codereview.chromium.org/449073 TBR=mirandac@chromium.org Review URL: http://codereview.chromium.org/460007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33538 0039d316-1c4b-4281-b951-d872f2087c98
* Put "make this my home page" link into the tip section.mirandac@chromium.org2009-12-023-12/+32
| | | | | | | | | BUG= 28196 TEST= "make this my home page" should show up as a tip. Review URL: http://codereview.chromium.org/449073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33527 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Reduce header dependencies in chrome.phajdan.jr@chromium.org2009-11-302-0/+2
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/454004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33324 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 33301 and 33305 due to unit_tests breakage.maruel@chromium.org2009-11-302-2/+0
| | | | | | | | TBR=pawel Review URL: http://codereview.chromium.org/453007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33309 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Reduce header dependencies in chrome.phajdan.jr@chromium.org2009-11-302-0/+2
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/454004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33301 0039d316-1c4b-4281-b951-d872f2087c98
* Convert a few other places from using ApplyAccelerator (async) totony@chromium.org2009-11-251-4/+6
| | | | | | | | using RunCommand (sync). Review URL: http://codereview.chromium.org/436031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33131 0039d316-1c4b-4281-b951-d872f2087c98
* Many changes to DictionaryValues:pkasting@chromium.org2009-11-252-10/+6
| | | | | | | | | | | | | | | | | * Add support for keys with "." in them via new XXXWithoutPathExpansion() APIs. * Use these APIs with all key iterator usage. * SetXXX() calls cannot fail, so change them from bool to void. * Change GetSize() to size() since it's cheap, and add empty(). Other: * Use standard for loop format in more places (e.g. instead of while loops when they're really doing a for loop). * Shorten a few bits of code. BUG=567 TEST=none Review URL: http://codereview.chromium.org/441008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33109 0039d316-1c4b-4281-b951-d872f2087c98
* Changed SyncStatusUIHelper namespace class into a real namespace ↵akalin@chromium.org2009-11-252-8/+8
| | | | | | | | | | | | | | | | | | | (sync_ui_util), per style guide. Changed static functions into anonymous-namespace functions. Renamed files/namespaces from sync_status_ui_helper to sync_ui_util. Moved sync_ui_util_mac.mm functions into sync_ui_util namespace. Updated all callers. BUG=none TEST=trybots Review URL: http://codereview.chromium.org/414065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33044 0039d316-1c4b-4281-b951-d872f2087c98
* Move some theme images to being serviced on the IO thread. Fortony@chromium.org2009-11-241-5/+16
| | | | | | | | | | | | | | | | | Linux Release builds on my machine, all the chrome://theme/ image requests block for 300-400ms during browser startup (it's faster after startup). Something is blocking the UI thread so move image requests that aren't themed off the UI thread. This is safe to do because ResourceBundle is thread safe. I still see chrome://theme/theme_ntp_attribution and chrome://theme/theme_ntp_background blocking so I will look into those next (I think with the default theme, they shouldn't be loaded at all). Review URL: http://codereview.chromium.org/440009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32985 0039d316-1c4b-4281-b951-d872f2087c98
* fix buildtony@chromium.org2009-11-241-0/+1
| | | | | | | | TBR=arv Review URL: http://codereview.chromium.org/431038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32966 0039d316-1c4b-4281-b951-d872f2087c98
* Merge in part of the last perf change. Move when we initializetony@chromium.org2009-11-242-20/+24
| | | | | | | | | | | | | | | the CSS/HTML for the NTP. This should allow the history query to happen sooner. Move the first_view logic out of NewTabHTMLSource. It can cause the CSS cache to get flushed, so make sure to run it before the CSS is generated. Also make sure we only hang on to the original profile. I think the incognito profile can be deleted out from under us when the last incognito window is closed. Review URL: http://codereview.chromium.org/434038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32965 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-13 08:10:24 +0000