summaryrefslogtreecommitdiffstats
path: root/chrome/browser/dom_ui
Commit message (Collapse)AuthorAgeFilesLines
* Change chrome-ui to chrome. I didn't go too far in converting existing ↵glen@chromium.org2009-05-063-5/+5
| | | | | | | | | | | | | | strings to using the url_constant (shipshipship). Users (such as those on Beta and Dev using session restore) attempting to load the old pages will see a blank white screen. BUG=11272 TEST=Verify that the inspector, debugger, history, downloads and newtab pages load with chrome:// URLS. Verify that replacing the chrome:// with chrome-ui:// does not work. Review URL: http://codereview.chromium.org/101026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15378 0039d316-1c4b-4281-b951-d872f2087c98
* Move l10n_util to app/ben@chromium.org2009-05-055-5/+5
| | | | | | | http://crbug.com/11387 Review URL: http://codereview.chromium.org/109043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15352 0039d316-1c4b-4281-b951-d872f2087c98
* Move scoped_vector.h and stl_util-inl.h to base/ben@chromium.org2009-05-051-1/+1
| | | | | | | | http://crbug.com/11387 Review URL: http://codereview.chromium.org/107001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15272 0039d316-1c4b-4281-b951-d872f2087c98
* Adds toplevel app/ directory and moves ResourceBundle into it.ben@chromium.org2009-05-056-8/+6
| | | | | | | | | | | No changes to resource bundle yet, just the move to keep this CL as compact as possible. Adds new vcproj and gyp file for app dir. http://crbug.com/11387 Review URL: http://codereview.chromium.org/100354 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15264 0039d316-1c4b-4281-b951-d872f2087c98
* Replace all occurrances of WebContents with TabContents.brettw@chromium.org2009-05-0417-53/+53
| | | | | | Review URL: http://codereview.chromium.org/99177 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15194 0039d316-1c4b-4281-b951-d872f2087c98
* Changes closed windows on the new tab page to show the Chromium/Chromesky@chromium.org2009-04-231-2/+4
| | | | | | | | | | | | | | icon and the text to show the number of closed windows. BUG=9022 TEST=With more than one window open close a window. Go to the new tab page and make sure you see an entry for the closed window. The entry should have the chrome/chromium logo and instead of 'Window' it should say the number of tabs in the window. Review URL: http://codereview.chromium.org/92022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14309 0039d316-1c4b-4281-b951-d872f2087c98
* Don't delete the DOM UI property for the callback when the DOM UI is torn down.brettw@chromium.org2009-04-221-2/+8
| | | | | | | | | | With my ownership changes, the TabContents owns the RVHManager which owns the DOMUI. This means that the DOM UI is deleted from ~TabContents and it will crash during destruction if we access the TabContents to delete the property. Review URL: http://codereview.chromium.org/92042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14253 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land my change to clean up TabContents/WebContents ownership. Thisbrettw@chromium.org2009-04-202-16/+9
| | | | | | | | | | | | | | | | | | | | | | | | is the same except in tab_strip_model_unittest I fixed a leak by making a WebContents on the stack, I added a factory to the SiteInstance unittest to prevent another leak, and I re-added a NULL set to the external_tab_container. Fix the ownership model of TabContents and NavigationController. Previously the NavigationController owned the TabContents, and there were extra steps required at creation and destruction to clean everything up properly. NavigationController is now a member of TabContents, and there is no setup or tear down necessary other than the constructor and destructor. I could remove the tab contents creation in the NavigationController, as well as all the weird destruction code in WebContents which got moved to the destructor. I made the controller getter return a reference since the ownership is clear and there is no possibility of NULL. This required changing a lot of tiles, but many of them were simplified since they no longer have to NULL check. Previous review URL: http://codereview.chromium.org/69043 Review URL: http://codereview.chromium.org/67294 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14053 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 14005.brettw@chromium.org2009-04-182-9/+16
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14006 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the ownership model of TabContents and NavigationController. Previously thebrettw@chromium.org2009-04-182-16/+9
| | | | | | | | | | | | | | | | | NavigationController owned the TabContents, and there were extra steps required at creation and destruction to clean everything up properly. NavigationController is now a member of TabContents, and there is no setup or tear down necessary other than the constructor and destructor. I could remove the tab contents creation in the NavigationController, as well as all the weird destruction code in WebContents which got moved to the destructor. I made the controller getter return a reference since the ownership is clear and there is no possibility of NULL. This required changing a lot of tiles, but many of them were simplified since they no longer have to NULL check. Review URL: http://codereview.chromium.org/69043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14005 0039d316-1c4b-4281-b951-d872f2087c98
* History observer was observing the wrong profile in incognito mode.glen@chromium.org2009-04-171-2/+4
| | | | | | | | | BUG=9984 TEST=Open two history tabs, one inside an incognito window. Delete a day's history in each and observe that the changes are reflected in the other. Review URL: http://codereview.chromium.org/67250 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13937 0039d316-1c4b-4281-b951-d872f2087c98
* Remove TabContentsType from the NavigationController external interface and inbrettw@chromium.org2009-04-151-1/+1
| | | | | | | some related areas. I removed all uses of this in the previous patch. Review URL: http://codereview.chromium.org/73057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13730 0039d316-1c4b-4281-b951-d872f2087c98
* Few changes to the NTP remove thumbnails:jcampan@chromium.org2009-04-151-30/+56
| | | | | | | | | | | | | | - some minor string changes - there is now a Cancel button next to the Done button to restore the thumbnails removed during the current editing session - link and favico are opacified as well in remove mode - now using a dictionary instead of a list to store the URL blacklist for faster access - now storing URL hashes instead of URLs (for privacy and also because the DictionaryValue breaks down keys on . characters) BUG=None TEST=Make sure removing thumbnails works as expected. Start removing thumbnails then click Cancel, verify that the thumbnails just removed are restored. Review URL: http://codereview.chromium.org/69007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13723 0039d316-1c4b-4281-b951-d872f2087c98
* Fix syntax error.estade@chromium.org2009-04-141-1/+1
| | | | | | | | TBR=mmoss Review URL: http://codereview.chromium.org/69009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13721 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up icon loader/manager in preparation for porting.estade@chromium.org2009-04-142-4/+9
| | | | | | | | Remove a bunch of unused functions and change wstrings to filepaths and remove an obsolete enum. Review URL: http://codereview.chromium.org/73007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13718 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the DOMUIHost. It is not used by any code.brettw@chromium.org2009-04-133-158/+2
| | | | | | | This also does a minor fix for forward-declares of RenderViewHostFactory. Review URL: http://codereview.chromium.org/66046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13637 0039d316-1c4b-4281-b951-d872f2087c98
* This CL adds some UI to remove most-visited thumbnails from the New Tab Page.jcampan@chromium.org2009-04-132-6/+102
| | | | | | | | | | | | | | | | | | The URL of removed thumbnails is added to a blacklist, which is a user pref. I had to modify the VisitSegmentDatabase::QuerySegmentUsage not to return a fixed number of items, as now we may filter the ones we get back. Note: this adds between 20 and 30ms to the first NTP load on my machine (a 3 to 5% increase). BUG=685 TEST=Open the NTP. Click the 'Edit thumbnails' link. Remove some thumbnails. Press Done. Edit again, use the "Restore removed" link. Review URL: http://codereview.chromium.org/67037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13611 0039d316-1c4b-4281-b951-d872f2087c98
* Change the download UI not to report xx bytes of 0 bytes. Just report "xx ↵thestig@chromium.org2009-04-091-11/+14
| | | | | | | | | | bytes" instead, so this does not require additional translations. BUG=9782 Review URL: http://codereview.chromium.org/67005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13467 0039d316-1c4b-4281-b951-d872f2087c98
* Cloned from 62030arv@chromium.org2009-04-071-4/+16
| | | | | | | | | | | | | | | Add a "Clear All" link to the downloads page. Fixes jankiness of the blue bar in the download page as it loads. Improve rendering time of the downloads page by chunking the number of download items to do before scheduling the timeout. BUG=9033 Review URL: http://codereview.chromium.org/62115 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13285 0039d316-1c4b-4281-b951-d872f2087c98
* Disables the download item on the download-shelf when the file is opened.jcampan@chromium.org2009-04-071-0/+1
| | | | | | | | | | | This is to mitigate against multiple clicks when a file takes some time to show anything to the user when opened (typically a setup.exe). By changing the title and disabling the button, we indicate to the user that an action was taken. BUG=7264 TEST=Download a file (image for example). In the download shelf, press the download item. The download item text should change to "Opening..." and it should be disabled (not responsive to clicks/drag and drops). Review URL: http://codereview.chromium.org/58014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13273 0039d316-1c4b-4281-b951-d872f2087c98
* Make the RenderViewHostFactory a global. This prevents us from having to passbrettw@chromium.org2009-04-072-3/+1
| | | | | | | | | a factory pointer around all the time. Removing TestTabContents will require making the Browser object keep track of the Factory pointer as well, so I think the global is the best approach and cleans some things up. Review URL: http://codereview.chromium.org/62044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13255 0039d316-1c4b-4281-b951-d872f2087c98
* Support p13n HTML dialogs.tim@chromium.org2009-04-071-0/+11
| | | | | | Review URL: http://codereview.chromium.org/62084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13215 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some uses of custom tab contents types from some tests.brettw@chromium.org2009-04-041-1/+0
| | | | | | | | | | | | | | | This required redoing the tests that used it to use the new RenderViewHost test harness. This is mostly straightforward, but required more work for the NavigationController tests. I removed a few random places that were testing for the tab types. I also made different versions of a few functions that don't take tab contents types next to the existing ones that do, so my touched code won't have to be changed again when I remove the tab contents types. Review URL: http://codereview.chromium.org/62039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13132 0039d316-1c4b-4281-b951-d872f2087c98
* Make the throbber throb sooner after you navigate. This fixes the new tab page,brettw@chromium.org2009-04-041-1/+1
| | | | | | | | | | | | | | which would not start throbbing until the load committed. I think this was always broken, but switching the tab contents types covered it up. Now I have a flag that goes along with the tab updating that indicates if it's a load update or a full update. This is necessary to avoid updating the title to the page's URL until it does actually commit. BUG=9310 Review URL: http://codereview.chromium.org/60066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13131 0039d316-1c4b-4281-b951-d872f2087c98
* Make the font family and the font size used in dom UI localizable. This is a ↵jungshik@google.com2009-04-035-12/+26
| | | | | | | | | | | | | | | | | | | | | | | part 1 of the fix for bug 7319 and will be followed by part 2 for non-DOM UI. For some Indian languages (Malayalam, Bengali and Telugu), we have to use a bigger size and a font family for that script on Windows. This is because Windows' stock fonts for those scripts are smaller than fonts for other scripts at a given size. I removed 'WEB' style in chrome_font.h because it's not used anywhere any more after our switch to the html UI. In addition, IDS_WEB_FONT_FAMILY is recycled to localize the font family (or the list of font families) for html UI. I also back-ported the support for setting 'style.fooBar' property to our copy of Jstemplate (JstProcessor.prototype.jstValues_). BUG=7319 Review URL: http://codereview.chromium.org/57025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13114 0039d316-1c4b-4281-b951-d872f2087c98
* Move HTML dialogs out of their own tab contents type. Moved functions to newbrettw@chromium.org2009-04-037-196/+159
| | | | | | | | | | | | | file html_dialog_ui.* Move WebContents view creation into the constructor, which makes a bunch of extra calls to CreateView unnecessary. Remove unused CallJavascriptFunction() functions in DOMUI. Review URL: http://codereview.chromium.org/56065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13065 0039d316-1c4b-4281-b951-d872f2087c98
* Installing extensions (drag/drop, download crx file) will now begeorged@chromium.org2009-04-011-1/+1
| | | | | | | | | handled by the Chrome instance w/o shell execute. This will install the extension in the proper profile using the running bits. Review URL: http://codereview.chromium.org/55046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13000 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some line endings in browser/dom_ui.brettw@chromium.org2009-03-302-115/+115
| | | | | | Review URL: http://codereview.chromium.org/57028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12818 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the DOMUIToStandard unit test and uncomment it. The NavigationControllerbrettw@chromium.org2009-03-301-8/+20
| | | | | | | | wasn't getting hooked up properly to the WebContents, and we were getting the wrong RenderViewHost out of it later on in the test. Review URL: http://codereview.chromium.org/55045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12773 0039d316-1c4b-4281-b951-d872f2087c98
* Comment out the crashing test so the tree can be open while I fix it.brettw@chromium.org2009-03-271-0/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12706 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 12673.brettw@chromium.org2009-03-271-48/+63
| | | | | | Review URL: http://codereview.chromium.org/56020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12700 0039d316-1c4b-4281-b951-d872f2087c98
* Fix lineendings for dom ui unittest.brettw@chromium.org2009-03-271-116/+116
| | | | | | Review URL: http://codereview.chromium.org/55037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12691 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Fix issues with DOM UI that cause focus to not be set to the URL bar ↵evan@chromium.org2009-03-271-133/+116
| | | | | | | | and the" This reverts commit r12668 because it failed to compile on Mac. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12673 0039d316-1c4b-4281-b951-d872f2087c98
* Fix issues with DOM UI that cause focus to not be set to the URL bar and thebrettw@chromium.org2009-03-271-116/+133
| | | | | | | | | | | URL to be hidden improperly. This code takes into account the somewhat crazy state that happens during initial tab load. BUG=9352 TEST=unit test should cover it Review URL: http://codereview.chromium.org/55015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12668 0039d316-1c4b-4281-b951-d872f2087c98
* Add date information to the downloads page.glen@chromium.org2009-03-271-0/+4
| | | | | | | | | BUG=8433 Review URL: http://codereview.chromium.org/55002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12661 0039d316-1c4b-4281-b951-d872f2087c98
* Minor tweaks to get chrome-ui://extensions working on the Mac.jrg@chromium.org2009-03-261-102/+97
| | | | | | Review URL: http://codereview.chromium.org/42627 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12586 0039d316-1c4b-4281-b951-d872f2087c98
* Fix purify error for DOM UI unit test.brettw@chromium.org2009-03-261-2/+1
| | | | | | Review URL: http://codereview.chromium.org/42633 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12533 0039d316-1c4b-4281-b951-d872f2087c98
* Make the bookmarks bar disappear when the load after the new tab page commitsbrettw@chromium.org2009-03-253-14/+141
| | | | | | | | | | | | | | | | | | | rather than when it is pending. This makes it change at the same time the page changes. To support this, we now have to keep track of both a pending and a committed DOMUI object. This is tracked by the RenderManager, which does a similar swapping between pending and committed RenderViewHosts. Previous review URL: http://codereview.chromium.org/42512 The only difference is I swapped the order of creating the DOM UI in RenderViewHostManager::Navigate. BUG=8963 Review URL: http://codereview.chromium.org/42623 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12515 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 12469.brettw@chromium.org2009-03-252-136/+14
| | | | | | Review URL: http://codereview.chromium.org/53062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12476 0039d316-1c4b-4281-b951-d872f2087c98
* Make the bookmarks bar disappear when the load after the new tab page commitsbrettw@chromium.org2009-03-252-14/+136
| | | | | | | | | | | | | | rather than when it is pending. This makes it change at the same time the page changes. To support this, we now have to keep track of both a pending and a committed DOMUI object. This is tracked by the RenderManager, which does a similar swapping between pending and committed RenderViewHosts. BUG=8963 Review URL: http://codereview.chromium.org/42512 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12469 0039d316-1c4b-4281-b951-d872f2087c98
* New tab page was linking to the wrong URL for the history page. We don't ↵glen@chromium.org2009-03-241-15/+2
| | | | | | | | | | need the message and can just put an actual URL in the page. BUG=8961 Review URL: http://codereview.chromium.org/49014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12375 0039d316-1c4b-4281-b951-d872f2087c98
* Add a progress meter to the downloads page.glen@chromium.org2009-03-241-2/+47
| | | | | | | | | | | | | | Add the progress status text indicator code from the old history page. Make 'cancel' visible when paused. More RTL fixes. BUG=8220,8334 Review URL: http://codereview.chromium.org/42550 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12366 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crash in new tab page when searching from a field other than thesky@google.com2009-03-241-4/+6
| | | | | | | | | | | first. BUG=8583 TEST=see bug Review URL: http://codereview.chromium.org/42566 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12364 0039d316-1c4b-4281-b951-d872f2087c98
* Merge DOMUIContents into WebContents.brettw@chromium.org2009-03-1721-1114/+933
| | | | | | | I did a lot of cleanup of the DOM UI system as part of this. Review URL: http://codereview.chromium.org/42227 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11925 0039d316-1c4b-4281-b951-d872f2087c98
* Use devtool_ prefix instead of dev_tools_ to be consistent with the rest code.yurys@google.com2009-03-173-7/+7
| | | | | | Review URL: http://codereview.chromium.org/42281 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11863 0039d316-1c4b-4281-b951-d872f2087c98
* Removed unneeded includes of base/time.h.thestig@chromium.org2009-03-161-3/+0
| | | | | | Review URL: http://codereview.chromium.org/48019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11766 0039d316-1c4b-4281-b951-d872f2087c98
* Rename DebuggerContents to DebuggerUI and move to the dom_ui folder.brettw@chromium.org2009-03-133-3/+179
| | | | | | Review URL: http://codereview.chromium.org/46036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11655 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash when with chrome-ui://about/" or anything invalidamit@chromium.org2009-03-131-4/+4
| | | | | | | | | | | | If DOMUIContents::InitCurrentUI returns true then current_ui_ should always be valid. Changed logic inside to make sure that this is the case. Review URL: http://codereview.chromium.org/46009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11634 0039d316-1c4b-4281-b951-d872f2087c98
* Moving the storing/restoring of the focus from TabContents to ↵jcampan@chromium.org2009-03-122-3/+6
| | | | | | | | | | | | WebContentsView. This makes TabContents less dependent on views. This requires few contortions with DOMUIs (NTP, history and downloads tab) as they still need to set the initial focus specifically. BUG=None TEST=Run the interactive tests. Review URL: http://codereview.chromium.org/39269 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11501 0039d316-1c4b-4281-b951-d872f2087c98
* Stop history search going on beyond the start of history.glen@chromium.org2009-03-113-10/+20
| | | | | | | | | | Stop losing first-searches on history page due to BUG=8438,8456 Review URL: http://codereview.chromium.org/43054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11411 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-10 06:54:21 +0000