| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
TabContentsDelegate behavior for HTML dialogs. Made all three implementations (gtk, win32, and cocoa) use it.
This also makes HTML dialogs not tied to a Browser instance. Also, unlike the current behavior, any links followed from an HTML dialog box will be opened in a non-incognito browser, even if the HTML dialog was launched from an incognito browser. According to beng, this is okay.
BUG=28609
TEST=unittests, manual testing on linux/windows/os x with sync setup wizard
Review URL: http://codereview.chromium.org/441011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= none
TEST= CJK tips should display properly.
Review URL: http://codereview.chromium.org/467003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33712 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
clicked.
BUG= 28795
TEST= sync bookmarks, then click "sync" link in promo again. see notification that you are already synced.
Review URL: http://codereview.chromium.org/462011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33685 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG= 28196
TEST= "make this my home page" should show up as a tip.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33527
Review URL: http://codereview.chromium.org/449073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33609 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/457025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33561 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG= 28196
TEST= "make this my home page" should show up as a tip.
Review URL: http://codereview.chromium.org/449073
TBR=mirandac@chromium.org
Review URL: http://codereview.chromium.org/460007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33538 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= 28196
TEST= "make this my home page" should show up as a tip.
Review URL: http://codereview.chromium.org/449073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33527 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/454004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33324 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=pawel
Review URL: http://codereview.chromium.org/453007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33309 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/454004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33301 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
using RunCommand (sync).
Review URL: http://codereview.chromium.org/436031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Add support for keys with "." in them via new XXXWithoutPathExpansion() APIs.
* Use these APIs with all key iterator usage.
* SetXXX() calls cannot fail, so change them from bool to void.
* Change GetSize() to size() since it's cheap, and add empty().
Other:
* Use standard for loop format in more places (e.g. instead of while loops when they're really doing a for loop).
* Shorten a few bits of code.
BUG=567
TEST=none
Review URL: http://codereview.chromium.org/441008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33109 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(sync_ui_util), per style guide.
Changed static functions into anonymous-namespace functions.
Renamed files/namespaces from sync_status_ui_helper to sync_ui_util.
Moved sync_ui_util_mac.mm functions into sync_ui_util namespace.
Updated all callers.
BUG=none
TEST=trybots
Review URL: http://codereview.chromium.org/414065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33044 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Linux Release builds on my machine, all the chrome://theme/ image
requests block for 300-400ms during browser startup (it's faster
after startup). Something is blocking the UI thread so move
image requests that aren't themed off the UI thread. This is
safe to do because ResourceBundle is thread safe.
I still see chrome://theme/theme_ntp_attribution and
chrome://theme/theme_ntp_background blocking so I will look
into those next (I think with the default theme, they shouldn't
be loaded at all).
Review URL: http://codereview.chromium.org/440009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32985 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=arv
Review URL: http://codereview.chromium.org/431038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the CSS/HTML for the NTP. This should allow the history query
to happen sooner.
Move the first_view logic out of NewTabHTMLSource. It can cause the CSS cache to get flushed, so make sure to run it before the CSS is generated.
Also make sure we only hang on to the original profile. I think
the incognito profile can be deleted out from under us when the
last incognito window is closed.
Review URL: http://codereview.chromium.org/434038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32965 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It caused New Tab Warm on Windows to regress to the speed before adding
the cache on Windows.
This reverts commit r32899.
TBR=arv
Review URL: http://codereview.chromium.org/431024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
trip to the UI thread later. Not sure if this will make a
difference.
Move the NTP and CSS handler init to after adding the MostVistedHandler.
This should allow an earlier db fetch for the cases when the HTML/CSS
are not in the cache (e.g., browser startup).
Review URL: http://codereview.chromium.org/439013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32899 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
be identical to LoadDataResourceBytes. Migrate callers to
LoadDataResourceBytes.
Review URL: http://codereview.chromium.org/437019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= 28433
TEST= click on puzzle piece and promo line "extension" links; chrome UI language should be included as a parameter in the link.
Review URL: http://codereview.chromium.org/434002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32820 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moving the HTML to the cache saved 8ms on New Tab Warm on Windows,
maybe we can shave a few more ms off by moving the CSS.
The last change had a regression on the mac new tab perf, so I suspect
it's the extra round trip to the UI thread when trying to load the CSS
(the UI thread is probably just busy at that time). Instead, I'm moving
the generation of the CSS to the time the object is constructed, rather
than when the resource is requested. This is like the code before,
except sometimes we'll hit the cache.
BUG=26228
Review URL: http://codereview.chromium.org/427003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32815 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Part 2: to be merged into 249.
BUG=28050, 27338
TEST= old bookmark sync promo should no longer appear on NTP.
Review URL: http://codereview.chromium.org/414076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32759 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG= 28050, 27338
TEST= old bookmark sync promo should no longer appear on NTP.
Review URL: http://codereview.chromium.org/420004
TBR=mirandac@chromium.org
Review URL: http://codereview.chromium.org/414075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32756 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= 28050, 27338
TEST= old bookmark sync promo should no longer appear on NTP.
Review URL: http://codereview.chromium.org/420004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32754 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
scoped_refptr<T>
Review URL: http://codereview.chromium.org/418007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32706 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
slowed down NTP on mac.
This reverts commit r32649.
Review URL: http://codereview.chromium.org/425004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moving the HTML to the cache saved 8ms on New Tab Warm on Windows,
maybe we can shave a few more ms off by moving the CSS.
http://build.chromium.org/buildbot/perf/xp-release-dual-core/new-tab-ui-warm/report.html?history=150
After this change, I'm going to try to do some cleanup to merge
NewTabHTMLSource into DOMUIThemeSource since these classes are both
quite small now.
BUG=26228
Review URL: http://codereview.chromium.org/413004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make bookmark sync link start up the sync process. Make the message more aesthetically pleasing.
Improve the overall layout of the message; ensure it doesn't overlap the NTP content. Also add a border to the notification line so that it matches the promo line in appearance, and stands out against themes of all colors.
BUG= 27853, 28047
TEST= start chrome, click on "bookmark sync" in promo message on NTP. chrome should start up the bookmark sync process.
Review URL: http://codereview.chromium.org/402021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
That was only needed because of clickjacking.
BUG=28227
Review URL: http://codereview.chromium.org/411004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32588 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
28k of pak file size, but will make the binary a tad bit larger.
BUG=28174
Review URL: http://codereview.chromium.org/407007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32556 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
HTML for the NTP each time, keep a cached copy as part of the
profile.
- This changes the handling of StartDataRequest to always happen
on the UI thread since it needs to use the Profile. Previously
we would generate on the UI thread then handle all the requests
on the IO thread.
- first_view_ got changed into a static bool. I also removed it
from being added to the json because it didn't appear to be used
anywhere.
- Merge the incognito and regular handler into one since I added
that as a flag to the request in a previous change.
I plan to add the CSS to NTPResourceCache next.
BUG=23120
Review URL: http://codereview.chromium.org/399055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32520 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Effectively revert revision 28193 (http://codereview.chromium.org/258037), this makes Mac match the other platform for what at it's core is used for the chrome concept of locale.
- For the ApplicationLanguage, the browser will end up with what Cocoa picks (same as before)
- All other process types will honor the language they got on the command line when starting up.
- When asked the apps language, have the same side effect as Windows and Linux has of pushing the language through to ICU also (so dates format right, etc.)
- During browser startup, if someone passed a language, bail because Mac can't support that.
TEST=The tips on the NTP and the dates on the history page are in the same language at the UI.
BUG=26856
BUG=22727
Review URL: http://codereview.chromium.org/399086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32515 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Don't show promo for extensions on Mac, as they're not available yet. Decrement promo counter even when NTP is not home page, and do not remove puzzle piece when promo line is closed. When message bar is closed, make it zip off bottom of screen instead of just disappearing.
BUG= 27814, 25258, 27815
TEST= see various bugs.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32176
Review URL: http://codereview.chromium.org/385135
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32413 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Don't show promo for extensions on Mac, as they're not available yet. Decrement promo counter even when NTP is not home page, and do not remove puzzle piece when promo line is closed. When message bar is closed, make it zip off bottom of screen instead of just disappearing.
BUG= 27814, 25258, 27815
TEST= see various bugs.
Review URL: http://codereview.chromium.org/385135
TBR=mirandac@chromium.org
Review URL: http://codereview.chromium.org/399051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32237 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
git grep 'RecordAction(L' | xargs sed -i -e s/RecordAction(L/RecordAction(/
This cuts more than 10k off my binary. Which is nothing compared
to the size of the binary, but that's a whole lot of zero bytes!
This is less code this way anyway.
Review URL: http://codereview.chromium.org/399026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32194 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Don't show promo for extensions on Mac, as they're not available yet. Decrement promo counter even when NTP is not home page, and do not remove puzzle piece when promo line is closed. When message bar is closed, make it zip off bottom of screen instead of just disappearing.
BUG= 27814, 25258, 27815
TEST= see various bugs.
Review URL: http://codereview.chromium.org/385135
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32176 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
chrome url request data sources. This will allow me to merge
IncognitoTabHTMLSource and NewTabHTMLSource and allow me clean
up DOMUIThemeSource, but those will be follow up changes.
Review URL: http://codereview.chromium.org/397019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32126 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= 27393, 26744
TEST= promotional messages should show up on NTP.
Review URL: http://codereview.chromium.org/394005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32027 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
the really hard ones which will need actual review instead of rubber-stamping.)
Review URL: http://codereview.chromium.org/386026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31932 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This also fixes an l10n issue where the string was hard coded in English.
Instead of using the tips infrastructure, after setting the home page we send
an ack to the NTP and show a notification. In this way the user will see the
notification even if they have hidden the tips.
Added a ui test that clicks on the link and checks the state of the UI
afterwards.
BUG=25101
TEST=Set your home page to non NTP. Go the the NTP by opening a new tab. Click
on the link "Make this my home page" at the bottom. You should see a banner at
the top. Pressing Alt-Home should now go to the NTP.
Review URL: http://codereview.chromium.org/392005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31823 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changing the dom_ui so that it has a new call which allows the
javascript
of the page to open a new window.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/385074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31816 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Added ProfileSyncService::IsSyncEnabled().
BUG=23073
TEST=manually (OS X),trybot
Review URL: http://codereview.chromium.org/389019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31789 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/385023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31669 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The code to display the dialog looks up an
Extension by id but doesn't return disabled ones.
So I added that option to the function.
I also added a check so that we don't show the
Options button enabled when the extension is
disabled, since you need the extension to be
enabled for the Options page to work.
BUG=26910
TEST=Disable an extension that has an Option page,
make sure Options is not enabled after disabling,
then uninstall it. It should uninstall.
Review URL: http://codereview.chromium.org/385014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31612 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DOMUIThemeSource and try to use it after it was deleted.
Instead, always cache the original profile pointer (which will
live longer).
While I'm here, get rid of the profile_ cached in
NewTabHTMLSource because we don't need it after the ctor is done
running.
BUG=26840
Review URL: http://codereview.chromium.org/372072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31513 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The bustage seems to be a WebKit change upstream. It is not reverted in
WebKit and merger. So bring the innocent change back in.
TBR=jam
TEST=green tree
Review URL: http://codereview.chromium.org/375009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31214 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
XP tests are failing, the guess is r31175 and r31176.
TBR=beng
TEST=XP tests go green
Review URL: http://codereview.chromium.org/376008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31201 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We now rewrite chrome-internal: (the old NTP URL) to chrome://newtab. Before, we were not properly showing the NTP for this URL, which caused some problems with further navigations (particularly form submissions) from that tab.
Also, the default kHomePage string is now chrome://newtab instead of the outdated chrome-internal:. The logic in GeneralPageView is already designed to not show this URL in the preferences dialog.
BUG=6564
TEST=NewTabUITest.ChromeInternalLoadsNTP
Review URL: http://codereview.chromium.org/363019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31182 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=26749
Review URL: http://codereview.chromium.org/361025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31175 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=26749
Review URL: http://codereview.chromium.org/360043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31167 0039d316-1c4b-4281-b951-d872f2087c98
|