summaryrefslogtreecommitdiffstats
path: root/chrome/browser/dom_ui
Commit message (Collapse)AuthorAgeFilesLines
* Unify LocalStrings.arv@chromium.org2010-03-161-1/+1
| | | | | | | | | | | The main difference is that we are now using $1 - $9 instead of %s. This is more consistent with the C++ code as well. BUG=None TEST=None Review URL: http://codereview.chromium.org/1045003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41760 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Make automation framework more solid by making sure thatphajdan.jr@chromium.org2010-03-161-3/+3
| | | | | | | | | | | | | | | | | | | important return values are not ignored. The macro used here, WARN_UNUSED_RESULT, takes effect only for GCC, but that's enough since we have bots for all platforms. Adding these warnings already detected some cases where a return value was ignored. In some of them the test was trying to get the information about success "some other way", in some it could sometimes confuse test failure with test success. TEST=ui_tests BUG=none Review URL: http://codereview.chromium.org/948002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41696 0039d316-1c4b-4281-b951-d872f2087c98
* Move base/gfx contents to gfx/ben@chromium.org2010-03-141-1/+1
| | | | | | | | | TBR=darin BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41559 0039d316-1c4b-4281-b951-d872f2087c98
* Show favicons for extensions.arv@chromium.org2010-03-122-2/+12
| | | | | | | | | | | This uses the 16x16 icon as defined in the manifest for extension pages. BUG=36514 TEST=Open the new bookmark manager. It should now show its favicon. Review URL: http://codereview.chromium.org/650185 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41462 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a hook to be a sink for media content in chrome.dhg@chromium.org2010-03-122-2/+70
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/903001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41443 0039d316-1c4b-4281-b951-d872f2087c98
* win: string_util.h -> utf_string_conversions.h fix.jhawkins@google.com2010-03-111-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/830002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41292 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Add more NULL-checks to UI tests that were lacking them to avoid ↵phajdan.jr@chromium.org2010-03-111-0/+4
| | | | | | | | | | | crashiness. TEST=none BUG=none Review URL: http://codereview.chromium.org/841002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41273 0039d316-1c4b-4281-b951-d872f2087c98
* Adding initial version of the mediaplayer. This only hooks into the system ↵dhg@chromium.org2010-03-104-0/+642
| | | | | | | | | | if the user selects a file via the filebrowser. BUG=none TEST=none Review URL: http://codereview.chromium.org/749001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41191 0039d316-1c4b-4281-b951-d872f2087c98
* Fix few remaining issues with incognito extensions.mpcomplete@chromium.org2010-03-101-0/+1
| | | | | | | | | | | - Open the options page in a regular browser window. - Rip out the "incognito" permission and revise the warning dialog. BUG=37677 Review URL: http://codereview.chromium.org/749002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41109 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing my localization laziness.dhg@chromium.org2010-03-091-1/+32
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/683001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41033 0039d316-1c4b-4281-b951-d872f2087c98
* chrome 5: string_util.h -> utf_string_conversions.h fix.jhawkins@chromium.org2010-03-084-6/+12
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/671024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40963 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing extension install case. Changing the file browser to only get the ↵dhg@chromium.org2010-03-081-3/+85
| | | | | | | | | | list of current downloads, not the history. BUG=none TEST=none Review URL: http://codereview.chromium.org/669186 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40903 0039d316-1c4b-4281-b951-d872f2087c98
* Fix missing favicon for chrome://extensions/arv@chromium.org2010-03-081-0/+3
| | | | | | | | | | | | It was mistakenly removed in r40468. BUG=None TEST=None TBR=aa@chromium.org Review URL: http://codereview.chromium.org/669261 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40881 0039d316-1c4b-4281-b951-d872f2087c98
* Next part of removing the dependency of chrome/common on chrome/browserphajdan.jr@chromium.org2010-03-061-0/+1
| | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/669184 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40834 0039d316-1c4b-4281-b951-d872f2087c98
* Pulls the latest googleurl to get the fix forbrettw@chromium.org2010-03-061-4/+1
| | | | | | | | | | | | | | | | BUG=http://crbug.com/160 and integrates the update to IsStandard in that version. Adds several internal schemes as "standard" and initializes them at startup. Fixes a few hardcoded URL schemes I noticed. Make typing "//foo" into the URL bar treat slashes in "strict" mode on Windows, which means we'll only accept UNC if you use backslashes. This matches IE's behavior. BUG=http://crbug.com/33038 TEST=covered by unit tests git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40818 0039d316-1c4b-4281-b951-d872f2087c98
* Implement edit mode for history page.jochen@chromium.org2010-03-052-47/+71
| | | | | | | | | BUG=35338 TEST=none Review URL: http://codereview.chromium.org/660283 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40722 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor: Move the code that handles "chrome://net-internals/*" from the net ↵eroman@chromium.org2010-03-041-33/+3
| | | | | | | | | | | | module to the chrome module. This is in preparation for making a javascript frontend to it, and merging in the functionality from about:network. There is no behavior change here, just moving code around. Review URL: http://codereview.chromium.org/668039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40608 0039d316-1c4b-4281-b951-d872f2087c98
* Remove strings that are no longer used by the NTP.arv@chromium.org2010-03-031-43/+0
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/666007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40565 0039d316-1c4b-4281-b951-d872f2087c98
* Add command line option to use a tabbed bookmark manager.arv@chromium.org2010-03-033-10/+119
| | | | | | | | | | | Start with --enable-tabbed-bookmark-manager. This will show chrome://bookmarks in a tab instead of the old bookmark manager. However, to get the bookmark manager extension to show you need to use --load-extension=path_to_extension. The extension uses the chrome_url_override to show the extension instead of the bookmark manager. BUG=4890 TEST=See description Review URL: http://codereview.chromium.org/661019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40468 0039d316-1c4b-4281-b951-d872f2087c98
* Further tweaks to incognito extensions.mpcomplete@chromium.org2010-03-021-0/+8
| | | | | | | | | | | | | | | - Add a warning to the incognito new tab page that your extensions are disabled in that mode. - Toggling an extension in incognito will reload the extension, fixing a bug where browser actions in existing incognito windows would not get updated. BUG=36292 BUG=32365 TEST=run chrome with --enable-experimental-extension-apis and some extensions loaded, and open an incognito window. Enable some extensions in incognito and make sure things work. Review URL: http://codereview.chromium.org/660220 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40403 0039d316-1c4b-4281-b951-d872f2087c98
* Fix browser side handling of moveTo by resizing the content area; not the ↵erg@chromium.org2010-03-021-3/+6
| | | | | | | | | | | window. BUG=27365 TEST=none Review URL: http://codereview.chromium.org/661187 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40386 0039d316-1c4b-4281-b951-d872f2087c98
* Allow users to enable extensions in incognito. Requiresmpcomplete@chromium.org2010-02-251-2/+4
| | | | | | | | | | | | | --enable-experimental-extension-apis . The UI needs work. Tab and window events are hooked up so that they work with incognito tabs/windows when enabled. BUG=32365 BUG=36292 Review URL: http://codereview.chromium.org/657041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40057 0039d316-1c4b-4281-b951-d872f2087c98
* This change makes incognito downloads show up in the downloads page of an ↵estade@chromium.org2010-02-241-3/+2
| | | | | | | | | | | | incognito window. These downloads are not persisted to history; hence they do not persist between incognito sessions. There is no special UI for the incognito downloads. That can be added later. BUG=28702 Review URL: http://codereview.chromium.org/650065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39910 0039d316-1c4b-4281-b951-d872f2087c98
* Move pref_{member,service} and important_file_writer from chrome/commonphajdan.jr@chromium.org2010-02-197-8/+8
| | | | | | | | | | | | | to chrome/browser. This is a part of an effort to remove bad dependency of chrome/common on chrome/browser. TEST=unit_tests and ui_tests, just moving code BUG=none Review URL: http://codereview.chromium.org/621004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39428 0039d316-1c4b-4281-b951-d872f2087c98
* Pulled out Callback code into base/callback.h. This is the first step ↵akalin@chromium.org2010-02-1913-1/+13
| | | | | | | | | | | | | towards redoing the Callback interfaces. Added and removed includes as needed. BUG=35223 TEST=trybots Review URL: http://codereview.chromium.org/646061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39419 0039d316-1c4b-4281-b951-d872f2087c98
* Change hardcoded "chrome" scheme to constant.jochen@chromium.org2010-02-161-9/+8
| | | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/604030 Patch from Bernhard Bauer <bauerb@google.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39092 0039d316-1c4b-4281-b951-d872f2087c98
* Adding deletion to filebrowser, adding pause/resume to shelf.dhg@chromium.org2010-02-121-15/+120
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/597055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38934 0039d316-1c4b-4281-b951-d872f2087c98
* Do not delete cookies when deleting history.jochen@chromium.org2010-02-111-1/+0
| | | | | | | | | BUG=35302 TEST=delete history of last day, check cookies Review URL: http://codereview.chromium.org/593046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38723 0039d316-1c4b-4281-b951-d872f2087c98
* Only show one FileBrowse pop up for the same folderxiyuan@chromium.org2010-02-102-15/+42
| | | | | | | | | | | | Check existing FileBrowse pop ups before opening new one so that we only show one per folder; BUG=none TEST=On ChromeOS, download multiple files to default downloads dir and there should be only one FileBrowse pop up showing up. Review URL: http://codereview.chromium.org/601013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38624 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Reduce header dependencies in chrome.phajdan.jr@chromium.org2010-02-091-0/+1
| | | | | | | | | BUG=none TEST=If it compiles it is perfect. Review URL: http://codereview.chromium.org/585008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38463 0039d316-1c4b-4281-b951-d872f2087c98
* linux: build with -Wextraevan@chromium.org2010-02-054-10/+10
| | | | | | | | | | | | 95% of this is removing "const" from return types, but turning this on found one bug! (A "for" loop that expected its iterator to go negative but which was using an unsigned type.) BUG=34160 Review URL: http://codereview.chromium.org/570012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38266 0039d316-1c4b-4281-b951-d872f2087c98
* Show the filebrowse ui rather than the download shelf in chromeos.xiyuan@chromium.org2010-02-052-2/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This cl displays the filebrowse ui rather than download shelf for downloads in chrom(e|ium) os. It conditionally replaces (with preprocessor macros) the Browser::OnStartDownload method to do this. The cl adds a static FileBrowseUI::OpenPopup(profile, hashArgument), which opens the file browse ui and passes it the provided hash argument. This is invoked directly from Browser::OnStartDownload. The USBMountObserver code was changed to call this static method, rather than open the popup by hand as it had been doing. I'm not sure about ownership of the Browser* returned by OpenPopup, but based on other code in the tree I assume chrome will deal with freeing it when appropriate. Before this change, USBMountObserver would add the window to registrar_ *before* showing it. Now that FileBrowseUI::OpenPopup returns a which which is already visible, this is no longer the case. I assume this won't be a problem. Commit this for rginda. Original review: http://codereview.chromium.org/555167 BUG=none TEST=none Review URL: http://codereview.chromium.org/564022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38222 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor chromeos cros files into subdir 'cros'chocobo@chromium.org2010-02-041-1/+1
| | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/572012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38128 0039d316-1c4b-4281-b951-d872f2087c98
* BSD port: another chunk of chrome/browser ifdef cleaningpvalchev@google.com2010-02-031-4/+4
| | | | | | Review URL: http://codereview.chromium.org/553153 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38004 0039d316-1c4b-4281-b951-d872f2087c98
* Replace GtkFileChooser with file browser for ChromeOSxiyuan@chromium.org2010-01-294-121/+136
| | | | | | | | | | | | | - Remove dialogs_gtk.cc and add select_file_dialog.cc for chrome os build; - select_file_dialog.cc provides a SelectFileDialogImpl that serves file browse html via HTMLDialogUI; BUG=none TEST=none Review URL: http://codereview.chromium.org/543137 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37547 0039d316-1c4b-4281-b951-d872f2087c98
* Revert previously disabled mac tests.rohitrao@chromium.org2010-01-291-6/+0
| | | | | | | | | | Reverts the following cls: 37467, 37475, 37481, 37486, 37488, 37489, 37494 BUG=33451 TEST=Please please pass. Review URL: http://codereview.chromium.org/558047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37536 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: remove obsolete references to chrome://inspector/yurys@chromium.org2010-01-291-7/+0
| | | | | | Review URL: http://codereview.chromium.org/558040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37505 0039d316-1c4b-4281-b951-d872f2087c98
* Disable NewTabUITest.HomePageLinkvictorw@chromium.org2010-01-291-0/+3
| | | | | | | | | | TBR=aa BUG=33451 TEST=mac bot ui test green Review URL: http://codereview.chromium.org/552226 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37481 0039d316-1c4b-4281-b951-d872f2087c98
* Temporaily disable crashing NewTabUITestvictorw@chromium.org2010-01-291-1/+1
| | | | | | | | | | TBR=aa BUG=33451 TEST=mac bot green Review URL: http://codereview.chromium.org/554126 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37475 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily disable crashing UI test.aa@chromium.org2010-01-291-0/+3
| | | | | | TBR=darin@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37467 0039d316-1c4b-4281-b951-d872f2087c98
* Add promo for extensions and bookmark sync back into the Mac NTP. Also, fix ↵mirandac@chromium.org2010-01-271-6/+0
| | | | | | | | | | | | | font size bug that snuck in with a recent webkit roll. BUG= 33291 TEST= run a Mac build with a new profile. See the extension / sync promo line and the puzzle piece on the NTP. Review URL: http://codereview.chromium.org/552193 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37334 0039d316-1c4b-4281-b951-d872f2087c98
* Split platform specific settings out from locale_settings.grd so we cantony@chromium.org2010-01-221-2/+1
| | | | | | | | | | | | | | | | | | have per platform config and overrides. This is easier to manage than the mess of <if>'s in the existing grd and xtb files. Each platform only builds its locale_settings_{win,mac,linux}.grd file. All the grd files generate the same platform_locale_settings.h header (for easy inclusion in .cc files). We use the fallback feature of grit to only specify locale specific values in xtb files if we want to override the default for the locale. BUG=28590 Review URL: http://codereview.chromium.org/545132 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36849 0039d316-1c4b-4281-b951-d872f2087c98
* Adding tab browsing for filebrowser.xiyuan@chromium.org2010-01-201-6/+80
| | | | | | | | | | | Committing this CL on dhg's behalf. Original Review: http://codereview.chromium.org/542083 BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36675 0039d316-1c4b-4281-b951-d872f2087c98
* The search terms are escaped using + or %20 for space depending on whether ↵avayvod@google.com2010-01-151-1/+1
| | | | | | | | | | | | replacement is in query part of the URL or not. Removed duplicate EscapeQueryParamValue functions without |use_plus| argument. BUG=24571 TEST=Verify that space is escaped as stated in description; see bug description for example with search on Wikipedia. Review URL: http://codereview.chromium.org/543077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36398 0039d316-1c4b-4281-b951-d872f2087c98
* Support dragging a virtual file out of the browser.jianli@chromium.org2010-01-151-0/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/351029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36378 0039d316-1c4b-4281-b951-d872f2087c98
* Show the sync login dialog in response to NTP sync link being clicked when ↵tim@chromium.org2010-01-131-0/+7
| | | | | | | | | | | | | | | the sync service is showing an INVALID_GAIA_CREDENTIALS or CAPTCHA_REQUIRED auth error, instead of just showing the 'Synced to ...' yellowbox. BUG=32116 TEST=manually generated auth error, observed NTP sync error, clicked re-login link, observed login dialog opened. Review URL: http://codereview.chromium.org/541038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36076 0039d316-1c4b-4281-b951-d872f2087c98
* 1. Increase the width for 'date-container' in download.html to 110px to make ↵jshin@chromium.org2010-01-111-1/+12
| | | | | | | | | | | | | | | room for dates in some languages. Increase the margin-left (LTR) and margin-rigth(RTL) accordingly. 2. Decrease the web font size (dom UI font size) for Bengali on Vista or later to 84% (the same value as used for English) while using 110% for XP. This is done by introducing a new 'string' (IDS_WEB_FONT_SIZE_XP) on Windows (other platforms won't get this). BUG=21699 TEST=Run Chrome with '--lang=ml' (--lang=kn, --lang=bn) on Windows and go to the download page. Make sure that dates are in a single line. Review URL: http://codereview.chromium.org/381009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35908 0039d316-1c4b-4281-b951-d872f2087c98
* linux: reduce header interdependenciesevan@chromium.org2009-12-292-0/+2
| | | | | | | | | | | | By analyzing gcc -H output, I found some of our worst offenders for headers bringing in other headers. native_web_keyboard_event.h was responsible for just under 60,000 extra includes! This change will in theory make the build faster. Review URL: http://codereview.chromium.org/524004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35326 0039d316-1c4b-4281-b951-d872f2087c98
* [More BTP includes.]erg@google.com2009-12-181-0/+1
| | | | | | | | | | | | | | | | | | | | | | Uninstall themes when all theme infobars are gone; not on each infobar's destruction. There are multiple problems with the current implementation: - It handles multiple tabs with theme install infobars badly. - It has a subtle race condition where installing a second theme, and then installing the original theme (note: not clicking undo) uninstalled both themes. Instead, only uninstall unused themes when all infobars are closed down. BUG=none TEST=Install theme A. Install theme B. Install theme A. Restart chrome. Theme A should show. TEST=Install theme A in window 1. Install theme B in window 2. Install theme C in window 3. Clicking undo in any of those windows in any order should work. Previous Review URL: http://codereview.chromium.org/504052 Review URL: http://codereview.chromium.org/501096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34900 0039d316-1c4b-4281-b951-d872f2087c98
* TBR: Revert to fix Chromos.erg@google.com2009-12-171-1/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34891 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-02 09:59:07 +0000