| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
This reverts commit 52788 and re-enables 2 UI tests.
TBR=phajdan.jr
Review URL: http://codereview.chromium.org/2856044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52942 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=49037,49038
TEST=Verify skeleton overlay dialogs for 'Clear Browser Data' and 'Font Settings' when using --enable-tabbed-options.
Review URL: http://codereview.chromium.org/2812063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
register screen.
Restrict chrome://register to OOBE wizard only.
Actually delete about:register.
BUG= http://crosbug.com/4813
TEST=none
Review URL: http://codereview.chromium.org/3044001
TBR=nkostylev@google.com
Review URL: http://codereview.chromium.org/3026007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52905 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Restrict chrome://register to OOBE wizard only.
Actually delete about:register.
BUG= http://crosbug.com/4813
TEST=none
Review URL: http://codereview.chromium.org/3044001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=sargrass
BUG=none
TEST=chromeos builder goes green
TBR=csilv@chromium.org
Review URL: http://codereview.chromium.org/3032006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52812 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=48883
TEST=Exercise Personal Stuff page via --enabled-tabbed-options
Review URL: http://codereview.chromium.org/2819046
TBR=sargrass@google.com
Review URL: http://codereview.chromium.org/3012007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52810 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=sargrass
BUG=none
TEST=chromeos builder goes green
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52795 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=49389
Review URL: http://codereview.chromium.org/2854050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52788 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=48883
TEST=Exercise Personal Stuff page via --enabled-tabbed-options
Review URL: http://codereview.chromium.org/2819046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52787 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=oshima
TEST=compile, please
BUG=48913
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52759 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's hard to find things in the download directory. DownloadFile and DownloadFileManager
were bundled together. Similarly for DownloadItem and DownloadManager, which was much less
intuitive. Some 3-5 line structs were also in one bag with something else. I extracted them
to their own small file.
TEST=unit_tests, browser_tests, ui_tests
BUG=48913
Review URL: http://codereview.chromium.org/2806054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
wizard is started from options.
BUG=19776
TEST=manually tested
Review URL: http://codereview.chromium.org/2976009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52689 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add a "Accounts" subpage for ChromeOS;
- Two checkboxes for allowing BWSI and allowing guest signin;
- Make measureItem in list.js returns 0 instead of -1. The itemHeight is -1
when the list is not visible. And 0 will let redraw to call measureItem
again;
- Add an onVisibilityChanged callback that is called when "visible" property
is changed; And use that to trigger user list's redraw;
- Use a mock settings object so that the UI flow could be tested;
- Update options_page.css to add a few css missed from dhg's overlay cl;
BUG=chromium-os:4734
TEST=None. This is a draft version and will be changed after UX feedbacks.
Review URL: http://codereview.chromium.org/2935011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52676 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=48713
TEST=Changing search engines in DOMUP prefs should be persisted.
Review URL: http://codereview.chromium.org/2883024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
That will allow registering custom JS handlers.
BUG= http://crosbug.com/4813
NONE=none
Review URL: http://codereview.chromium.org/2870051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52639 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Complete implementation of SSL security options for all platforms.
- Implemented the 'Clear auto-opening settings' button.
- Correctly show logging checkbox for Chrome builds only.
- Mostly-complete support for the download path section.
BUG=48482
TEST=Exercise advanced panel in options window using --enable-tabbed-options.
Review URL: http://codereview.chromium.org/2893012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52525 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Correct throbber path in choose_datatypes.html (I overlooked this)
* Change CSS style settings for throbber to a form the inliner could understand, so the image got inlined properly
* Remove references to throbber path from sync_setup_wizard.cc (no longer needed)
* Fix improper use of url_constants.* (only paths that need to be in common/ should be there) and change sync hostname constant name to match other hostnames' naming scheme
BUG=40984
TEST=Signing into GAIA in sync setup dialog should show a throbber
Review URL: http://codereview.chromium.org/2840035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52501 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=manual testing of plugins page, ConfigurationPolicyPrefStoreTest*
BUG=45856
Review URL: http://codereview.chromium.org/2833034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52487 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This changes the ExtensionDOMUI favicon loading to use a ImageLoadingTracker which handles reading the file in the correct thread as well as resizing it.
BUG=47964
TEST=Install one of the extensions in the bug. Open the options page for the extension. The icon in the tab should be 16x16 pixels.
Review URL: http://codereview.chromium.org/2918007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52376 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also disables all the not-yet-implemented controls so it's clear what works and what doesn't.
Fixes a earlier bad merge that introduced a duplicate include of the sync options.
BUG=48713
TEST=Running with --enable-tabbed-options, default browser display and button should work in prefs.
Review URL: http://codereview.chromium.org/2945017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52335 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also disables all the not-yet-implemented controls so it's clear what works and what doesn't.
BUG=48713
TEST=Running with --enable-tabbed-options, default browser display and button should work in prefs.
Review URL: http://codereview.chromium.org/2927012
TBR=stuartmorgan@chromium.org
Review URL: http://codereview.chromium.org/2891025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52320 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also disables all the not-yet-implemented controls so it's clear what works and what doesn't.
BUG=48713
TEST=Running with --enable-tabbed-options, default browser display and button should work in prefs.
Review URL: http://codereview.chromium.org/2927012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52318 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moving PluginGroup into common is necessary in order to enable the renderer process to check if a plugin is outdated.
Also, make PluginUpdater static since it doesn't contain any state anymore.
BUG=47731
TEST=PluginGroupTest.*
Review URL: http://codereview.chromium.org/2955005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52307 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=48941
TEST=OptionsUITest.LoadOptionsByURL
TBR=nkostylev
Review URL: http://codereview.chromium.org/2910011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52296 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
block.
BUG=48941
TEST=none
Review URL: http://codereview.chromium.org/2963006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52291 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is more like a boilerplate place holder.
Will add the contents in a separate change.
BUG=chromiumo-os:4573
TEST=manually
Review URL: http://codereview.chromium.org/2958003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52290 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=45316
TEST=Configure SyncDisabled policy and check the UI.
Review URL: http://codereview.chromium.org/2905003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52288 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This dialog cannot be opend from UI yet.
The execution path will be added once "Languages and Input" dialog is ready.
TEST=manually check on the netbook by uncommenting TODO lines.
BUG=chromium-os:4806
Review URL: http://codereview.chromium.org/2853032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52279 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also, convert it to a subpage.
Also, make subpage nav items hidden when not in use.
BUG=48863
TEST=manual
Review URL: http://codereview.chromium.org/2901008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52251 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Always mark HTML/CSS as "flattenhtml" unless not possible
* Remove resources not needed due to flattening
* Simplify dom_ui code now that most resources won't be loaded that route
The change to index.html is needed to make the flattener do the right thing (otherwise the stylesheet doesn't get inlined).
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2907009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52146 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
* Always mark HTML/CSS as "flattenhtml" unless not possible
* Remove resources not needed (due to flattening, or just extra). I assume the "test" files don't need to ship with Chrome and are just for local testing.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2944007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52145 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Missing pieces:
- Add the other tabs besides the first two.
- The tab switching mechanism might need some work (it definitely needs to look better, and perhaps should also work with the back/forward buttons).
- none of the <button>s work
- I added the Content Settings page as one of the main options pages for now, but in the end it should show up when a user clicks the "Content Settings..." button in Under the Hood.
There is a bit of extra code because content settings don't use prefs, so I had to sort of replicate the pref_ui code.
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/2804039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
prefs, to manage preferences set by extensions.
Update various callers of the PrefValueStore constructor accordingly.
The initial user will be the proxy extension API.
BUG=266
TEST=covered by unit tests
Review URL: http://codereview.chromium.org/2823037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52088 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2812043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52007 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is just the HTML and CSS and the skeleton of some of the JavaScript. Only the checkbox for the Home button currently works. Remaining functionality will be added over time.
BUG=48713
TEST=Basics page in options should show options; "Show Home button" should work.
Review URL: http://codereview.chromium.org/2972001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52006 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The favicon used to be loaded from a png file in
the resources directory. Since the file is gone,
this no longer works. Instead, check for the bookmark
manager extension earlier and load the image from the
pak file.
BUG=48218
Review URL: http://codereview.chromium.org/2960002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=jhawkins
BUG=48521
TEST=unit tests no longer red due to this change.
Review URL: http://codereview.chromium.org/2897001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51811 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- All checkboxes are functional, partial functionality for buttons.
- Download path controls TBD.
- Security SSL checkboxes on non-Mac platform TBD.
- Added placeholder files for Browser and Personal option panels.
- Moved placeholder CSS into a new options_page.css file.
- Unit testing TBD.
BUG=48482
TEST=Launch browser with --enable-tabbed-options and bring up options window.
Review URL: http://codereview.chromium.org/2830036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51770 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=48093
TEST=tested that plugin doesn't load w/o --enable-chromoting.
Review URL: http://codereview.chromium.org/2818043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2800035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=open New Tab page, see thumbnails. Same with chrome --top-sites.
Review URL: http://codereview.chromium.org/2815045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51728 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Factor out SetPagesValue - this adds prepopulated pages, pinned and blacklisted urls.
2. Add broken camera placeholder for missing thumbnails.
3. Remove 'old database' warning if running without TopSites flag.
BUG=None
TEST=chrome --top-sites; pinned, blacklisted urls work now.
Review URL: http://codereview.chromium.org/2805062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51565 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
preference and sets its default value to false. After this we'll have to add the UI to set it.
BUG=4362
TEST=none
Review URL: http://codereview.chromium.org/2873032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51563 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
They occasionally fail on other platforms too.
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=NewTabUITest.ChromeInternalLoadsNTP&testType=ui_tests
BUG=45001
TEST=green
Review URL: http://codereview.chromium.org/2825034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51549 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Re-landing patch by mavrommatis, original review here:
<http://codereview.chromium.org/1991005>
Original description follows:
(1) Group plugins with the same name together. (2) Show a download link for
plugin versions with known security problems in about:plugins.
BUG=3910,47858
TEST=Open "chrome://plugins", see that plugins are grouped, and that any vulnerable plugins are marked red. Try enabling and disabling plugin groups. Also, if the internal PDF plugin is enabled, it should stay enabled after a restart.
Review URL: http://codereview.chromium.org/2811037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51510 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=47881
TEST=Unit tests
Review URL: http://codereview.chromium.org/2805050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=zelidrag
BUG=47977
TEST=Green ChromeOS bot
Review URL: http://codereview.chromium.org/2833043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51259 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
new tab page.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/2886002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changed grit to support generic <!--include file="..."--> tag in html files to support the scenario above.
TEST=make sure chrome:options page still shows correctly
BUG=chromium-os:4429
Review URL: http://codereview.chromium.org/2835009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51203 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
show update link for out-of-date ones.
Tracking patch by mavrommatis, original review here:
<http://codereview.chromium.org/1991005>
Original description follows:
(1) Group plugins with the same name together. (2) Show a download link for
plugin versions with known security problems in about:plugins.
BUG=3910
TEST=Open "chrome://plugins", see that plugins are grouped, and that any vulnerable plugins are marked red. Try enabling and disabling plugin groups.
Review URL: http://codereview.chromium.org/2835018
TBR=bauerb@chromium.org
Review URL: http://codereview.chromium.org/2805048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51191 0039d316-1c4b-4281-b951-d872f2087c98
|