summaryrefslogtreecommitdiffstats
path: root/chrome/browser/dom_ui
Commit message (Collapse)AuthorAgeFilesLines
* Coverity: Initialize pending_buf_size_ in the constructor.jhawkins@chromium.org2009-09-241-1/+4
| | | | | | | | | CID=1639 BUG=none TEST=none Review URL: http://codereview.chromium.org/218011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27108 0039d316-1c4b-4281-b951-d872f2087c98
* Move functions from skia/ext to app/gfx where possible: most of skia_utils.* ↵pkasting@chromium.org2009-09-241-3/+3
| | | | | | | | | | | | | and image_operations.* can be moved because they are not used by WebKit code. This also fixes the spelling of "Convolusion" to "Convolution" and updates some copyrights. This is a re-do of r26975, this time with WebKit update and some fixes to compile on Mac and Linux. BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27031 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 26975.pkasting@chromium.org2009-09-231-3/+3
| | | | | | Review URL: http://codereview.chromium.org/222011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26979 0039d316-1c4b-4281-b951-d872f2087c98
* Move functions from skia/ext to app/gfx where possible: most of skia_utils.* ↵pkasting@chromium.org2009-09-231-3/+3
| | | | | | | | | | | | and image_operations.* can be moved because they are not used by WebKit code. This also fixes the spelling of "Convolusion" to "Convolution" and updates some copyrights. BUG=none TEST=none Review URL: http://codereview.chromium.org/207059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26975 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a theme promo in the lower right cornerarv@chromium.org2009-09-232-4/+16
| | | | | | | | | BUG=None TEST=The theme promo should show up in the lower right corner and when clicked should navigate to the Chrome theme gallery. The promo should go away after 5 runs of chrome Review URL: http://codereview.chromium.org/217020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26894 0039d316-1c4b-4281-b951-d872f2087c98
* Fix check for wr_list validity not covering entire use.mattm@chromium.org2009-09-181-3/+2
| | | | | | | | | | | (Coverity FORWARD_NULL error CID 6043.) BUG=17101 TEST=none Review URL: http://codereview.chromium.org/209038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26607 0039d316-1c4b-4281-b951-d872f2087c98
* Change the URLs used to access "view-cache:" and "view-net-internals:".eroman@chromium.org2009-09-141-0/+35
| | | | | | | | | | | | | | | | | | "net-internal:*" ==> "chrome://net-internals/*" "view-cache:*" ==> "chrome://net-internals/view-cache/*" "view-cache:stats" ==> "chrome://net-internals/httpcache.stats" As before, there are also aliases from the "about:*" page: "about:net-internal[/*]" aliases "chrome://net-internals/*" "about:cache[/*]" aliases "chrome://net-internals/view-cache" BUG=http://crbug.com/21551 Review URL: http://codereview.chromium.org/202067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26158 0039d316-1c4b-4281-b951-d872f2087c98
* Move StringPiece into the base namespace. It is collidingtony@chromium.org2009-09-105-8/+8
| | | | | | | | | | with the StringPiece class in icu4.2, which is a problem when trying to use the system version of icu. Review URL: http://codereview.chromium.org/193072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25920 0039d316-1c4b-4281-b951-d872f2087c98
* Fix problem of white box appearing in themes without an NTP background image.mirandac@chromium.org2009-09-101-8/+8
| | | | | | | | | BUG= http://crbug.com/21290 TEST= Install a theme without an NTP image (greyscale). Look at NTP with bookmarkbar attached and detached. See no white box at bottom of NTP. Review URL: http://codereview.chromium.org/194066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25861 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that tips change when the Chrome language changes.mirandac@chromium.org2009-09-101-0/+15
| | | | | | | | | BUG= http://crbug.com/21394 TEST= Change chrome language. Close and reopen browser. Tips should appear in new language, or, if not available, they should not appear. Review URL: http://codereview.chromium.org/199073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25834 0039d316-1c4b-4281-b951-d872f2087c98
* Fix to use FilePath version of PathService::Get.thestig@chromium.org2009-09-091-1/+1
| | | | | | | | | | | BUG=None TEST=None Original Review URL: http://codereview.chromium.org/174189 Patch from Thiago Farina <thiago.farina@gmail.com>. Review URL: http://codereview.chromium.org/193047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25778 0039d316-1c4b-4281-b951-d872f2087c98
* NNTP: Fix issue with pinning the pre-populated thumbnails.arv@google.com2009-09-041-49/+66
| | | | | | | | | | | | BUG=20801 TEST=Create a new profile and open the new tab page. Pin and reorder the pre-populated thumbnails. The thumbnails and favicons should continue to work. Review URL: http://codereview.chromium.org/195010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25422 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Revert "Allow DOMUI pages to call window.open(), giving DOMUI ↵mpcomplete@chromium.org2009-09-032-79/+73
| | | | | | | | | | | | privileges to the new"" Second attempt at r25250. The tests were broken in Release mode due to a race. Should be fixed. BUG=17636 Review URL: http://codereview.chromium.org/172120 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25329 0039d316-1c4b-4281-b951-d872f2087c98
* NNTP: Fix link and link underline colorsarv@google.com2009-09-031-0/+7
| | | | | | | | | | | | | The fall back color for the link underline is the link color with the alpha channel set to 1/3 of the link color. BUG=20697 TEST=All links on the NTP should have different underline color. Also, try with different themes. Review URL: http://codereview.chromium.org/194004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25318 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Themes: Add basic unit tests for gtk themes.erg@google.com2009-09-031-1/+1
| | | | | | Review URL: http://codereview.chromium.org/186019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25317 0039d316-1c4b-4281-b951-d872f2087c98
* Add warnings around the new tab page command line switch and its use so peoplebrettw@chromium.org2009-09-031-0/+4
| | | | | | | | | | don't get confused and copy this pattern (as happened recently). BUG=none TEST=none Review URL: http://codereview.chromium.org/186018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25282 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r25250: "Allow DOMUI pages to call window.open(), giving DOMUI ↵mpcomplete@chromium.org2009-09-022-73/+79
| | | | | | | | privileges to the new" Review URL: http://codereview.chromium.org/171127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25256 0039d316-1c4b-4281-b951-d872f2087c98
* Allow DOMUI pages to call window.open(), giving DOMUI privileges to the newmpcomplete@chromium.org2009-09-022-79/+73
| | | | | | | | | | | window (assuming it is on the same site instance). BUG=17636 TEST=no Review URL: http://codereview.chromium.org/173649 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25250 0039d316-1c4b-4281-b951-d872f2087c98
* Improve New Tab Page load performance.mark@chromium.org2009-09-025-67/+167
| | | | | | | | | | | | | | | | | | | | | | | | This change nets another 65ms (20%) improvement in the duration between the renderer requesting the NTP and it having all of the resources for the NTP available and being completely done with layout on my Mac laptop in release mode. Move the handling of important resource requests needed for NTP layout from the UI thread onto the IO thread. This is handled by caching the necessary data on the UI thread when possible, so that no profile or theme access is needed to service the request. There is often a lot of contention for the UI thread when a new tab is created, and allowing these requests to be handled more directly by the IO thread allows the renderer to lay the page out while the browser is still busy doing UI work. http://groups.google.com/group/chromium-dev/browse_thread/thread/7148074f807dc5f7 TEST=Do the new tab page and new incognito tab page still work? Are they faster? BUG=13337 Review URL: http://codereview.chromium.org/179069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25232 0039d316-1c4b-4281-b951-d872f2087c98
* Fix issue with the ordering of the most visited items.arv@google.com2009-09-021-34/+48
| | | | | | | | | | | | | | | | | | | | | This change allows the pinned items to work better after the history has been cleared. Previously we were limited byt the amount of items returned by the history. Now pinned items still show up even after the history has been cleared. Also, this change makes the filler items flow to the left of pinned items as necessary. BUG=20817 TEST=Launch chrome with a new profile. Navigate around so that you have at least 5 non prepoluated thumbnails on the NTP. Pin the second and the fifth item. Now clear your history. The pinned items should stay in place and the fillers should flow around them. Review URL: http://codereview.chromium.org/184001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25229 0039d316-1c4b-4281-b951-d872f2087c98
* Revert accidental commits: r25115 and r25116mpcomplete@chromium.org2009-09-012-64/+80
| | | | | | Review URL: http://codereview.chromium.org/183045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25120 0039d316-1c4b-4281-b951-d872f2087c98
* Merge branch 'api' of /src/chrome/src into apimpcomplete@chromium.org2009-09-012-80/+64
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25115 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 24982.mirandac@chromium.org2009-09-011-1/+1
| | | | | | Review URL: http://codereview.chromium.org/175041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24987 0039d316-1c4b-4281-b951-d872f2087c98
* This is only for 195; will be reverted immediately.mirandac@chromium.org2009-09-011-1/+1
| | | | | | Review URL: http://codereview.chromium.org/179052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24982 0039d316-1c4b-4281-b951-d872f2087c98
* Experiment with dislodging the Extension Shelf and having it only appear on ↵finnur@chromium.org2009-08-303-3/+12
| | | | | | | | | | | the New Tab page. BUG=http://crbug.com/20415 TEST=With the extension toolstrip visible, go to the New Tab page and press Ctrl + Alt + B. Watch the toolstrip merge into the New Tab page and back again into a separate toolstrip (when you press Ctrl + Alt + B again). Also, when you do this on a regular webpage (as opposed to NTP) this should toggle the toolstrip visiblity. Review URL: http://codereview.chromium.org/175017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24864 0039d316-1c4b-4281-b951-d872f2087c98
* Show Make this my homepage link on new tab page.kuchhal@chromium.org2009-08-281-0/+47
| | | | | | | | BUG=20254 Review URL: http://codereview.chromium.org/179012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24813 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a FaviconService class tied to the profile.arv@google.com2009-08-288-12/+58
| | | | | | | | | | | | | | | | | | | Original issue: http://codereview.chromium.org/115212/show The favicons service is the entry point to getting favicons. Make the DOMUIFactory handle the favicons of DOMUI pages so since DOMUI pages are never added to the history. BUG=5840 TEST=Open a new window and open history and downloads (Ctrl+H and Ctrl+J) in this window. Then close the window and open the NTP. The recently closed windows/tabs should show the favicons for the hsitroy and downloads page. Review URL: http://codereview.chromium.org/178001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24806 0039d316-1c4b-4281-b951-d872f2087c98
* Remove JSTemplate from NTParv@google.com2009-08-281-1/+0
| | | | | | | | | | | | | | This should reduce the time to show the NTP with about 5ms :-) Fix a bug with tips causing an exception when there are no tips. BUG=None TEST=None Review URL: http://codereview.chromium.org/178015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24751 0039d316-1c4b-4281-b951-d872f2087c98
* Turn tips on by default, and turn off tip loading during UI testing.mirandac@chromium.org2009-08-261-1/+1
| | | | | | | | | BUG= none TEST= none Review URL: http://codereview.chromium.org/173444 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24418 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 24385.mirandac@chromium.org2009-08-261-1/+1
| | | | | | Review URL: http://codereview.chromium.org/173443 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24399 0039d316-1c4b-4281-b951-d872f2087c98
* Turn on tips by default.mirandac@chromium.org2009-08-261-1/+1
| | | | | | | | | BUG= none TEST= none Review URL: http://codereview.chromium.org/173371 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24385 0039d316-1c4b-4281-b951-d872f2087c98
* Add single line of tips to NNTP.mirandac@chromium.org2009-08-262-47/+18
| | | | | | | | | BUG= http://crbug.com/19162 TEST= Start browser with NNTP, note line of tips at bottom. Review URL: http://codereview.chromium.org/173087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24384 0039d316-1c4b-4281-b951-d872f2087c98
* - Fix bug where white logo wasn't showingglen@chromium.org2009-08-251-0/+3
| | | | | | | | | | | - Add attribution support back to the NTP BUG=20019 TEST=Install a theme with a white logo and attribution, and verify that both display correctly. Review URL: http://codereview.chromium.org/173372 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24323 0039d316-1c4b-4281-b951-d872f2087c98
* Removed personalization_strings.h and moved all the strings into ↵idana@chromium.org2009-08-201-8/+23
| | | | | | | | | | | | | generated_resources.grd. I'll take care of the Setup Wizard strings/resources in my next patch. BUG=none TEST=none Review URL: http://codereview.chromium.org/173069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23863 0039d316-1c4b-4281-b951-d872f2087c98
* Remove personalization.h/cc by putting things in final resting placestim@chromium.org2009-08-202-12/+6
| | | | | | Review URL: http://codereview.chromium.org/173085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23833 0039d316-1c4b-4281-b951-d872f2087c98
* NNTP: Remove the DownloadsHandler from the new tab page.arv@google.com2009-08-201-13/+0
| | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/174099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23824 0039d316-1c4b-4281-b951-d872f2087c98
* Made the Sync UI work in the New New tab page.idana@chromium.org2009-08-173-69/+83
| | | | | | | | | | There are no significant logic changes except the addition of a link which points to the web ui. BUG=none Review URL: http://codereview.chromium.org/172007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23591 0039d316-1c4b-4281-b951-d872f2087c98
* Implement drag and drop of downloads for the Mac downloads page.paul@chromium.org2009-08-171-2/+4
| | | | | | | | | | BUG=15776 (http://crbug.com/15776) TEST=Download an item, open the download page, drag the icon of the download to the desktop. Review URL: http://codereview.chromium.org/164459 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23548 0039d316-1c4b-4281-b951-d872f2087c98
* Some personalization cleanup:tim@chromium.org2009-08-153-24/+6
| | | | | | | | | | | | | | | | - Removes ProfilePersonalization (which is why the CL appears huge) - Makes Profile do the work ProfilePersonalization did for creating PSS - cloudy:stats > about:sync - Removes the cloudy:// scheme and uses chrome:// for resources. (Note SyncResourcesSource is a straight copy of CloudyResourceSource). - Moves prefs and switches to pref_names and chrome_switches. BUG=none TEST=ProfileSyncServiceTest, LiveBookmarkSyncTests, SyncSetupWizardTest Review URL: http://codereview.chromium.org/164544 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23505 0039d316-1c4b-4281-b951-d872f2087c98
* With the recent NNTP changes, we change the way themes work - they're now ↵glen@chromium.org2009-08-111-10/+23
| | | | | | | | | | | | | closer to NTP1 theming - ntp_section_* is used to control the display of the light blue sections, and we've added ntp_header that controls the dark blue hover color, ntp_header falls back to ntp_section if provided. Also fix a minor bug where the default theme was saving theme data - we were generating colors before saving the provided colors. BUG=18720,18722 TEST=Install a theme and verify that the recently closed section is themed correctly. Review URL: http://codereview.chromium.org/165192 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23081 0039d316-1c4b-4281-b951-d872f2087c98
* Build browser/sync files by default using a stubbed-out syncapitim@chromium.org2009-08-111-1/+1
| | | | | | | | | implementation. The stub will be replaced once the rest of sync/engine lands as we open source the sync engine code. Review URL: http://codereview.chromium.org/165257 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23004 0039d316-1c4b-4281-b951-d872f2087c98
* Add UMA histograms for chrome-sync.We add the following ↵brg@chromium.com2009-08-111-1/+2
| | | | | | | | | | | | | | | histograms:Sync.MergeAndSyncNeededCountNumber of times merge and sync is needed to run.Sync.AuthorizationTimeTime taken during initial authorization.Sync.UserPerceivedAuthorizationTimeTime the user spends looking at the authorization dialog.Sync.BookmarkAssociationTimeTime taken during bookmark association.Sync.ReauthorizationTimeTime taken from startup for the user to reauthorize. Sync.Events This is an enumeration of distinct events of the following types: Number of times sync was started from the ad in NTP.Number of times sync was started from the Wrench menu.Number of times sync was started from Wrench->Options.Number of times sync was stopped from Wrench->Options.Number of times sync was stopped during the sign-on process.Number of times sync was stopped after successfully authorized.Number of times sync was cancelled when the merge dialog was surfaces. BUG=None. Test=None. Review URL: http://codereview.chromium.org/165111 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23001 0039d316-1c4b-4281-b951-d872f2087c98
* Change "Cancelled" to "Canceled". Original patch by Thiago Farina (see ↵pkasting@chromium.org2009-08-101-1/+1
| | | | | | | | | http://codereview.chromium.org/165097 ), r=me. BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22933 0039d316-1c4b-4281-b951-d872f2087c98
* NNTP: Remove tips and downloads and introduce a recently closed bar instead.arv@google.com2009-08-061-20/+4
| | | | | | | | | | | | | | Make the list mode only show one column and make the items look like links. BUG=None TEST= On the new tab page try opening and closing tabs and windows. The closed tabs and windows should appear in the recently closed bar at the bottom. Review URL: http://codereview.chromium.org/165095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22691 0039d316-1c4b-4281-b951-d872f2087c98
* Apply theme to incognito NTP.mirandac@chromium.org2009-08-063-7/+60
| | | | | | | | | BUG= http://crbug.com/18480 TEST= Open incognito window. Note that NTP is themed. Review URL: http://codereview.chromium.org/164002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22613 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of r22559.aa@chromium.org2009-08-062-2/+2
| | | | | | | | | | | | | | | | | | This caused an easily reproducible crash: 1. Start with a fresh profile 2. Navigate to google.com 3. Restart 4. Navigate to google.com 5. crash The change from pass-by-value to pass-by-ref in fav_icon_helper.* seems to be to blame, but I can't see it right off. TBR=phajdan.jr@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22595 0039d316-1c4b-4281-b951-d872f2087c98
* Bunch of Coverity fixes, rather minor severity.phajdan.jr@chromium.org2009-08-062-2/+2
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/159862 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22559 0039d316-1c4b-4281-b951-d872f2087c98
* Use the theme ID as as the cache-buster, making subsequent NNTP loads much ↵glen@chromium.org2009-08-051-2/+3
| | | | | | | | | | | faster. BUG=18427 TEST=Install a few themes, verify that the NNTP never gets out of sync with the installed theme. Review URL: http://codereview.chromium.org/159900 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22462 0039d316-1c4b-4281-b951-d872f2087c98
* Make the DOMUIThemeSource load and pass through a PNG, rather than relying ↵glen@chromium.org2009-08-052-20/+12
| | | | | | | | | | | on decode/encode. BUG=18427 TEST=Install a giant theme, load the NNTP, verify that you can type in the omnibox without delay while the page is loading. Review URL: http://codereview.chromium.org/159891 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22457 0039d316-1c4b-4281-b951-d872f2087c98
* Add files to browser/sync and tweak includes.tim@chromium.org2009-08-055-10/+271
| | | | | | | | | | | | | Create browser/sync/glue and /engine. Create sync watchlist and add a few folks. No GYP change here so no build changes should occur. chrome.gyp CL is coming shortly, as well as live_sync tests. Review URL: http://codereview.chromium.org/160598 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22454 0039d316-1c4b-4281-b951-d872f2087c98