summaryrefslogtreecommitdiffstats
path: root/chrome/browser/dom_ui
Commit message (Collapse)AuthorAgeFilesLines
* linux: reduce header interdependenciesevan@chromium.org2009-12-292-0/+2
| | | | | | | | | | | | By analyzing gcc -H output, I found some of our worst offenders for headers bringing in other headers. native_web_keyboard_event.h was responsible for just under 60,000 extra includes! This change will in theory make the build faster. Review URL: http://codereview.chromium.org/524004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35326 0039d316-1c4b-4281-b951-d872f2087c98
* [More BTP includes.]erg@google.com2009-12-181-0/+1
| | | | | | | | | | | | | | | | | | | | | | Uninstall themes when all theme infobars are gone; not on each infobar's destruction. There are multiple problems with the current implementation: - It handles multiple tabs with theme install infobars badly. - It has a subtle race condition where installing a second theme, and then installing the original theme (note: not clicking undo) uninstalled both themes. Instead, only uninstall unused themes when all infobars are closed down. BUG=none TEST=Install theme A. Install theme B. Install theme A. Restart chrome. Theme A should show. TEST=Install theme A in window 1. Install theme B in window 2. Install theme C in window 3. Clicking undo in any of those windows in any order should work. Previous Review URL: http://codereview.chromium.org/504052 Review URL: http://codereview.chromium.org/501096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34900 0039d316-1c4b-4281-b951-d872f2087c98
* TBR: Revert to fix Chromos.erg@google.com2009-12-171-1/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34891 0039d316-1c4b-4281-b951-d872f2087c98
* Uninstall themes when all theme infobars are gone; not on each infobar's ↵erg@google.com2009-12-171-0/+1
| | | | | | | | | | | | | | | | | | | | destruction. There are multiple problems with the current implementation: - It handles multiple tabs with theme install infobars badly. - It has a subtle race condition where installing a second theme, and then installing the original theme (note: not clicking undo) uninstalled both themes. Instead, only uninstall unused themes when all infobars are closed down. BUG=none TEST=Install theme A. Install theme B. Install theme A. Restart chrome. Theme A should show. TEST=Install theme A in window 1. Install theme B in window 2. Install theme C in window 3. Clicking undo in any of those windows in any order should work. Review URL: http://codereview.chromium.org/504052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34890 0039d316-1c4b-4281-b951-d872f2087c98
* Don't show "show in foloder" in chrome os.oshima@chromium.org2009-12-171-2/+5
| | | | | | | | | BUG=chromiun-os:916 TEST=None Review URL: http://codereview.chromium.org/506045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34837 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the "Bookmark sync" menu itemarv@chromium.org2009-12-151-19/+5
| | | | | | | | | | | | This also cleans up the states. BUG=28419 TEST=The menu item should be gone but we should still see errors from bookmark sync on the NTP Review URL: http://codereview.chromium.org/501029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34608 0039d316-1c4b-4281-b951-d872f2087c98
* Creating new CL for uploading a picture from ChromiumOSdavemoore@chromium.org2009-12-111-9/+177
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/452016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34351 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the crashing chromeos sync tests and revert the patch that disabled them.albertb@google.com2009-12-101-14/+3
| | | | | | | | BUG=29994 Review URL: http://codereview.chromium.org/490007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34283 0039d316-1c4b-4281-b951-d872f2087c98
* Disables a handful of tests for chromeos as they're crashing.sky@chromium.org2009-12-101-3/+14
| | | | | | | | | | BUG=29994 TEST=none TBR=albertb Review URL: http://codereview.chromium.org/486013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34254 0039d316-1c4b-4281-b951-d872f2087c98
* A collection of fixes allowing the chrome.experimental.popup.* set of APIs ↵twiz@google.com2009-12-101-1/+1
| | | | | | | | to function in circumstances where there is no Browser instance present. This is a symptom of a tab-contents view hosted in an ExternalTabContainer.The major change here is the removal of the explicit dependency on a Browser instance across all of the delegates involved when showing a pop-up API. I modified the following delegates:- ExtensionPopupHost::Delegate- TabContentsDelegate- ExtensionFunctionDispatcher::DelegateBecause the pop-up requires a Profile, and a gfx::NativeWindow, I added methods to the above interfaces to provide them.BUG=noneTEST=ExtensionApiTest.FLAKY_Popup Review URL: http://codereview.chromium.org/434046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34219 0039d316-1c4b-4281-b951-d872f2087c98
* Created HtmlDialogTabContentsDelegate, which encapsulates the ↵akalin@chromium.org2009-12-033-0/+331
| | | | | | | | | | | | | TabContentsDelegate behavior for HTML dialogs. Made all three implementations (gtk, win32, and cocoa) use it. This also makes HTML dialogs not tied to a Browser instance. Also, unlike the current behavior, any links followed from an HTML dialog box will be opened in a non-incognito browser, even if the HTML dialog was launched from an incognito browser. According to beng, this is okay. BUG=28609 TEST=unittests, manual testing on linux/windows/os x with sync setup wizard Review URL: http://codereview.chromium.org/441011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33752 0039d316-1c4b-4281-b951-d872f2087c98
* Change WideToASCII to WideToUTF8 to ensure that CJK tips are properly displayed.mirandac@chromium.org2009-12-031-1/+1
| | | | | | | | | BUG= none TEST= CJK tips should display properly. Review URL: http://codereview.chromium.org/467003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33712 0039d316-1c4b-4281-b951-d872f2087c98
* Notify user that Chrome is already synced if promo banner "sync me" link is ↵mirandac@chromium.org2009-12-032-2/+7
| | | | | | | | | | | clicked. BUG= 28795 TEST= sync bookmarks, then click "sync" link in promo again. see notification that you are already synced. Review URL: http://codereview.chromium.org/462011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33685 0039d316-1c4b-4281-b951-d872f2087c98
* Put "make this my home page" link into the tip section.mirandac@chromium.org2009-12-024-20/+43
| | | | | | | | | | | BUG= 28196 TEST= "make this my home page" should show up as a tip. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33527 Review URL: http://codereview.chromium.org/449073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33609 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Reduce header dependencies in chrome.phajdan.jr@chromium.org2009-12-022-0/+2
| | | | | | Review URL: http://codereview.chromium.org/457025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33561 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 33527 - Put "make this my home page" link into the tip section.mirandac@chromium.org2009-12-023-32/+12
| | | | | | | | | | | | BUG= 28196 TEST= "make this my home page" should show up as a tip. Review URL: http://codereview.chromium.org/449073 TBR=mirandac@chromium.org Review URL: http://codereview.chromium.org/460007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33538 0039d316-1c4b-4281-b951-d872f2087c98
* Put "make this my home page" link into the tip section.mirandac@chromium.org2009-12-023-12/+32
| | | | | | | | | BUG= 28196 TEST= "make this my home page" should show up as a tip. Review URL: http://codereview.chromium.org/449073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33527 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Reduce header dependencies in chrome.phajdan.jr@chromium.org2009-11-302-0/+2
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/454004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33324 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 33301 and 33305 due to unit_tests breakage.maruel@chromium.org2009-11-302-2/+0
| | | | | | | | TBR=pawel Review URL: http://codereview.chromium.org/453007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33309 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Reduce header dependencies in chrome.phajdan.jr@chromium.org2009-11-302-0/+2
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/454004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33301 0039d316-1c4b-4281-b951-d872f2087c98
* Convert a few other places from using ApplyAccelerator (async) totony@chromium.org2009-11-251-4/+6
| | | | | | | | using RunCommand (sync). Review URL: http://codereview.chromium.org/436031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33131 0039d316-1c4b-4281-b951-d872f2087c98
* Many changes to DictionaryValues:pkasting@chromium.org2009-11-252-10/+6
| | | | | | | | | | | | | | | | | * Add support for keys with "." in them via new XXXWithoutPathExpansion() APIs. * Use these APIs with all key iterator usage. * SetXXX() calls cannot fail, so change them from bool to void. * Change GetSize() to size() since it's cheap, and add empty(). Other: * Use standard for loop format in more places (e.g. instead of while loops when they're really doing a for loop). * Shorten a few bits of code. BUG=567 TEST=none Review URL: http://codereview.chromium.org/441008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33109 0039d316-1c4b-4281-b951-d872f2087c98
* Changed SyncStatusUIHelper namespace class into a real namespace ↵akalin@chromium.org2009-11-252-8/+8
| | | | | | | | | | | | | | | | | | | (sync_ui_util), per style guide. Changed static functions into anonymous-namespace functions. Renamed files/namespaces from sync_status_ui_helper to sync_ui_util. Moved sync_ui_util_mac.mm functions into sync_ui_util namespace. Updated all callers. BUG=none TEST=trybots Review URL: http://codereview.chromium.org/414065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33044 0039d316-1c4b-4281-b951-d872f2087c98
* Move some theme images to being serviced on the IO thread. Fortony@chromium.org2009-11-241-5/+16
| | | | | | | | | | | | | | | | | Linux Release builds on my machine, all the chrome://theme/ image requests block for 300-400ms during browser startup (it's faster after startup). Something is blocking the UI thread so move image requests that aren't themed off the UI thread. This is safe to do because ResourceBundle is thread safe. I still see chrome://theme/theme_ntp_attribution and chrome://theme/theme_ntp_background blocking so I will look into those next (I think with the default theme, they shouldn't be loaded at all). Review URL: http://codereview.chromium.org/440009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32985 0039d316-1c4b-4281-b951-d872f2087c98
* fix buildtony@chromium.org2009-11-241-0/+1
| | | | | | | | TBR=arv Review URL: http://codereview.chromium.org/431038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32966 0039d316-1c4b-4281-b951-d872f2087c98
* Merge in part of the last perf change. Move when we initializetony@chromium.org2009-11-242-20/+24
| | | | | | | | | | | | | | | the CSS/HTML for the NTP. This should allow the history query to happen sooner. Move the first_view logic out of NewTabHTMLSource. It can cause the CSS cache to get flushed, so make sure to run it before the CSS is generated. Also make sure we only hang on to the original profile. I think the incognito profile can be deleted out from under us when the last incognito window is closed. Review URL: http://codereview.chromium.org/434038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32965 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Move the NTP HTML generation to early so we can avoid an extra"tony@chromium.org2009-11-243-23/+20
| | | | | | | | | | | | | It caused New Tab Warm on Windows to regress to the speed before adding the cache on Windows. This reverts commit r32899. TBR=arv Review URL: http://codereview.chromium.org/431024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32906 0039d316-1c4b-4281-b951-d872f2087c98
* Move the NTP HTML generation to early so we can avoid an extratony@chromium.org2009-11-243-20/+23
| | | | | | | | | | | | | trip to the UI thread later. Not sure if this will make a difference. Move the NTP and CSS handler init to after adding the MostVistedHandler. This should allow an earlier db fetch for the cases when the HTML/CSS are not in the cache (e.g., browser startup). Review URL: http://codereview.chromium.org/439013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32899 0039d316-1c4b-4281-b951-d872f2087c98
* Remove ResourceBundle::LoadImageResourceBytes since it appears totony@chromium.org2009-11-234-5/+5
| | | | | | | | | be identical to LoadDataResourceBytes. Migrate callers to LoadDataResourceBytes. Review URL: http://codereview.chromium.org/437019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32885 0039d316-1c4b-4281-b951-d872f2087c98
* Add locale as a parameter to the extension link.mirandac@chromium.org2009-11-231-4/+5
| | | | | | | | | BUG= 28433 TEST= click on puzzle piece and promo line "extension" links; chrome UI language should be included as a parameter in the link. Review URL: http://codereview.chromium.org/434002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32820 0039d316-1c4b-4281-b951-d872f2087c98
* Take 2 at moving NTP CSS resources into the NTP resource cache.tony@chromium.org2009-11-237-268/+287
| | | | | | | | | | | | | | | | | | Moving the HTML to the cache saved 8ms on New Tab Warm on Windows, maybe we can shave a few more ms off by moving the CSS. The last change had a regression on the mac new tab perf, so I suspect it's the extra round trip to the UI thread when trying to load the CSS (the UI thread is probably just busy at that time). Instead, I'm moving the generation of the CSS to the time the object is constructed, rather than when the resource is requested. This is like the code before, except sometimes we'll hit the cache. BUG=26228 Review URL: http://codereview.chromium.org/427003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32815 0039d316-1c4b-4281-b951-d872f2087c98
* Remove old bookmark sync promo from new tab page. mirandac@chromium.org2009-11-212-10/+1
| | | | | | | | | | | Part 2: to be merged into 249. BUG=28050, 27338 TEST= old bookmark sync promo should no longer appear on NTP. Review URL: http://codereview.chromium.org/414076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32759 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 32754 - Remove old bookmark sync promo from new tab page.mirandac@chromium.org2009-11-212-1/+10
| | | | | | | | | | | | BUG= 28050, 27338 TEST= old bookmark sync promo should no longer appear on NTP. Review URL: http://codereview.chromium.org/420004 TBR=mirandac@chromium.org Review URL: http://codereview.chromium.org/414075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32756 0039d316-1c4b-4281-b951-d872f2087c98
* Remove old bookmark sync promo from new tab page.mirandac@chromium.org2009-11-212-10/+1
| | | | | | | | | BUG= 28050, 27338 TEST= old bookmark sync promo should no longer appear on NTP. Review URL: http://codereview.chromium.org/420004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32754 0039d316-1c4b-4281-b951-d872f2087c98
* Forces T*s to scoped_refptr<T> when PostTask()ing to a function expecting ↵jamesr@chromium.org2009-11-207-33/+20
| | | | | | | | scoped_refptr<T> Review URL: http://codereview.chromium.org/418007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32706 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Move NTP CSS resources into the NTP resource cache." because it ↵tony@chromium.org2009-11-206-277/+281
| | | | | | | | | | slowed down NTP on mac. This reverts commit r32649. Review URL: http://codereview.chromium.org/425004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32675 0039d316-1c4b-4281-b951-d872f2087c98
* Move NTP CSS resources into the NTP resource cache.tony@chromium.org2009-11-206-281/+277
| | | | | | | | | | | | | | | | | Moving the HTML to the cache saved 8ms on New Tab Warm on Windows, maybe we can shave a few more ms off by moving the CSS. http://build.chromium.org/buildbot/perf/xp-release-dual-core/new-tab-ui-warm/report.html?history=150 After this change, I'm going to try to do some cleanup to merge NewTabHTMLSource into DOMUIThemeSource since these classes are both quite small now. BUG=26228 Review URL: http://codereview.chromium.org/413004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32649 0039d316-1c4b-4281-b951-d872f2087c98
* More tweaks and fixes for extension and bookmark sync promo. mirandac@chromium.org2009-11-201-3/+2
| | | | | | | | | | | | Make bookmark sync link start up the sync process. Make the message more aesthetically pleasing. Improve the overall layout of the message; ensure it doesn't overlap the NTP content. Also add a border to the notification line so that it matches the promo line in appearance, and stands out against themes of all colors. BUG= 27853, 28047 TEST= start chrome, click on "bookmark sync" in promo message on NTP. chrome should start up the bookmark sync process. Review URL: http://codereview.chromium.org/402021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32619 0039d316-1c4b-4281-b951-d872f2087c98
* Special case the gallery to not show the scary download roadblock.aa@chromium.org2009-11-201-2/+3
| | | | | | | | | | That was only needed because of clickjacking. BUG=28227 Review URL: http://codereview.chromium.org/411004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32588 0039d316-1c4b-4281-b951-d872f2087c98
* Move URLs out of *.pak files and put them into code. This savestony@chromium.org2009-11-191-2/+15
| | | | | | | | | | 28k of pak file size, but will make the binary a tad bit larger. BUG=28174 Review URL: http://codereview.chromium.org/407007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32556 0039d316-1c4b-4281-b951-d872f2087c98
* Implement a NTP resource cache. Instead of re-generating thetony@chromium.org2009-11-194-377/+377
| | | | | | | | | | | | | | | | | | | | | | | HTML for the NTP each time, keep a cached copy as part of the profile. - This changes the handling of StartDataRequest to always happen on the UI thread since it needs to use the Profile. Previously we would generate on the UI thread then handle all the requests on the IO thread. - first_view_ got changed into a static bool. I also removed it from being added to the json because it didn't appear to be used anywhere. - Merge the incognito and regular handler into one since I added that as a flag to the request in a previous change. I plan to add the CSS to NTPResourceCache next. BUG=23120 Review URL: http://codereview.chromium.org/399055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32520 0039d316-1c4b-4281-b951-d872f2087c98
* Mac language/locale cleanupthomasvl@chromium.org2009-11-191-3/+3
| | | | | | | | | | | | | | | - Effectively revert revision 28193 (http://codereview.chromium.org/258037), this makes Mac match the other platform for what at it's core is used for the chrome concept of locale. - For the ApplicationLanguage, the browser will end up with what Cocoa picks (same as before) - All other process types will honor the language they got on the command line when starting up. - When asked the apps language, have the same side effect as Windows and Linux has of pushing the language through to ICU also (so dates format right, etc.) - During browser startup, if someone passed a language, bail because Mac can't support that. TEST=The tips on the NTP and the dates on the history page are in the same language at the UI. BUG=26856 BUG=22727 Review URL: http://codereview.chromium.org/399086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32515 0039d316-1c4b-4281-b951-d872f2087c98
* Tweaks and fixes for NTP extension promo.mirandac@chromium.org2009-11-182-15/+19
| | | | | | | | | | | | Don't show promo for extensions on Mac, as they're not available yet. Decrement promo counter even when NTP is not home page, and do not remove puzzle piece when promo line is closed. When message bar is closed, make it zip off bottom of screen instead of just disappearing. BUG= 27814, 25258, 27815 TEST= see various bugs. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32176 Review URL: http://codereview.chromium.org/385135 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32413 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 32176 - Tweaks and fixes for NTP extension promo.mirandac@chromium.org2009-11-182-19/+13
| | | | | | | | | | | | | Don't show promo for extensions on Mac, as they're not available yet. Decrement promo counter even when NTP is not home page, and do not remove puzzle piece when promo line is closed. When message bar is closed, make it zip off bottom of screen instead of just disappearing. BUG= 27814, 25258, 27815 TEST= see various bugs. Review URL: http://codereview.chromium.org/385135 TBR=mirandac@chromium.org Review URL: http://codereview.chromium.org/399051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32237 0039d316-1c4b-4281-b951-d872f2087c98
* Use plain strings instead of wstrings for UMA actionsevan@chromium.org2009-11-171-1/+2
| | | | | | | | | | | | git grep 'RecordAction(L' | xargs sed -i -e s/RecordAction(L/RecordAction(/ This cuts more than 10k off my binary. Which is nothing compared to the size of the binary, but that's a whole lot of zero bytes! This is less code this way anyway. Review URL: http://codereview.chromium.org/399026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32194 0039d316-1c4b-4281-b951-d872f2087c98
* Tweaks and fixes for NTP extension promo.mirandac@chromium.org2009-11-172-13/+19
| | | | | | | | | | Don't show promo for extensions on Mac, as they're not available yet. Decrement promo counter even when NTP is not home page, and do not remove puzzle piece when promo line is closed. When message bar is closed, make it zip off bottom of screen instead of just disappearing. BUG= 27814, 25258, 27815 TEST= see various bugs. Review URL: http://codereview.chromium.org/385135 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32176 0039d316-1c4b-4281-b951-d872f2087c98
* Plumb through off the record state from the URL request to thetony@chromium.org2009-11-1719-28/+54
| | | | | | | | | | chrome url request data sources. This will allow me to merge IncognitoTabHTMLSource and NewTabHTMLSource and allow me clean up DOMUIThemeSource, but those will be follow up changes. Review URL: http://codereview.chromium.org/397019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32126 0039d316-1c4b-4281-b951-d872f2087c98
* Add message and image to NTP to promote extensions and bookmark sync.mirandac@chromium.org2009-11-152-4/+47
| | | | | | | | | BUG= 27393, 26744 TEST= promotional messages should show up on NTP. Review URL: http://codereview.chromium.org/394005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32027 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes almost all of the rest of lint errors in the chrome/ directory (minus ↵erg@google.com2009-11-131-1/+1
| | | | | | | | the really hard ones which will need actual review instead of rubber-stamping.) Review URL: http://codereview.chromium.org/386026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31932 0039d316-1c4b-4281-b951-d872f2087c98
* NTP: Hide "Make this my home page" after setting the home page.arv@chromium.org2009-11-122-21/+90
| | | | | | | | | | | | | | | | | | | | This also fixes an l10n issue where the string was hard coded in English. Instead of using the tips infrastructure, after setting the home page we send an ack to the NTP and show a notification. In this way the user will see the notification even if they have hidden the tips. Added a ui test that clicks on the link and checks the state of the UI afterwards. BUG=25101 TEST=Set your home page to non NTP. Go the the NTP by opening a new tab. Click on the link "Make this my home page" at the bottom. You should see a banner at the top. Pressing Alt-Home should now go to the NTP. Review URL: http://codereview.chromium.org/392005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31823 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-12 09:56:21 +0000