summaryrefslogtreecommitdiffstats
path: root/chrome/browser/dom_ui
Commit message (Collapse)AuthorAgeFilesLines
* Remove the unused handlers as wellarv@chromium.org2009-10-201-321/+1
| | | | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/292001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29579 0039d316-1c4b-4281-b951-d872f2087c98
* First fix to minimize copying of image data.erg@google.com2009-10-1916-54/+48
| | | | | | | | | | | | | | | | | | | | | | | | | | | This is the first of multiple patches that clean up handling of memory regarding images. Previously, the code did several memcpy()s or equivalents. This change: - Creates an abstract interface RefCountedMemory which provides access to the front() of a memory range and the size() of it. It is a RefCountedThreadSafe. - Adds a RefCountedStaticMemory class which isa RefCountedMemory. - Pushes RefCountedBytes up into base/ from chrome/ and make it conform to RefCountedMemory. - Have ResourceBundle return RefCountedStaticMemory to the mmaped() or DLL loaded resources instead of memcpy()ing them. - General cleanups to minimize copies in constructing RefCountedBytes. - Use the above consistent interface in the BrowserThemeProvider, along with special casing the loading of the new tab page background. This patch is mostly cleanups and there should only be a slight performance gain if any. Most of the real speedups should come in subsequent patches. BUG=http://crbug.com/24493 TEST=Slightly faster on Perf bot; does not introduce crashes. Review URL: http://codereview.chromium.org/288005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29412 0039d316-1c4b-4281-b951-d872f2087c98
* Rename CHROME_PERSONALIZATION to BROWSER_SYNC.nick@chromium.org2009-10-173-5/+5
| | | | | | | | | | Avoid #ifdef in general, favoring #if defined(). In one spot, use PlatformThread::Sleep instead of rolling our own. Review URL: http://codereview.chromium.org/267125 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29360 0039d316-1c4b-4281-b951-d872f2087c98
* NTP: Fix startup visual state arv@chromium.org2009-10-161-2/+16
| | | | | | | | | | | | | | | This inject the template data earlier in the document so that we can set the initial visual state based on the user preference. This prevents flickering when the user is not showing the most visited thumbnails. BUG=24513 TEST=Use a theme with a background image to make this easier to spot. Hide the most visited. Restart Chrome. The thumbnails should not flicker Review URL: http://codereview.chromium.org/269095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29314 0039d316-1c4b-4281-b951-d872f2087c98
* Facelifts to sync UItim@chromium.org2009-10-152-27/+40
| | | | | | | | BUG=23136,24858,21596 TEST=SyncSetupWizardTest Review URL: http://codereview.chromium.org/270081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29197 0039d316-1c4b-4281-b951-d872f2087c98
* Add a ui test to verify that using the typical_history profiletony@chromium.org2009-10-151-0/+48
| | | | | | | | | | | | results in thumbnails. I could have added this directly to the new tab startup tests, but that would mean turning on DOM automation for the new tab tests. I was trying to avoid the extra code in the new tab startup tests. Review URL: http://codereview.chromium.org/269060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29145 0039d316-1c4b-4281-b951-d872f2087c98
* More style nits.erg@google.com2009-10-1410-31/+38
| | | | | | | | (Working on cleaning chrome/ so hopefully we can lint it by default.) Review URL: http://codereview.chromium.org/274040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28971 0039d316-1c4b-4281-b951-d872f2087c98
* Use FilePaths in chrome_url_data_manager.evan@chromium.org2009-10-122-14/+14
| | | | | | | | | BUG=24672 TEST=still compiles Review URL: http://codereview.chromium.org/267065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28760 0039d316-1c4b-4281-b951-d872f2087c98
* Remove old NTParv@chromium.org2009-10-123-27/+5
| | | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/271057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28758 0039d316-1c4b-4281-b951-d872f2087c98
* Header dependency cleanup in chrome/phajdan.jr@chromium.org2009-10-121-0/+1
| | | | | | | | | | | | - reduce header dependencies - remove things that shouldn't be #included in a header, like string_util.h and theme_resources.h! TEST=none BUG=none Review URL: http://codereview.chromium.org/245011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28705 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r28645 - "Render sync code inactive..."tim@chromium.org2009-10-101-0/+6
| | | | | | | | Vive le sync! Review URL: http://codereview.chromium.org/269044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28649 0039d316-1c4b-4281-b951-d872f2087c98
* Render sync code inactive without any way to enable.tim@chromium.org2009-10-101-6/+0
| | | | | | | | | | | | **** I WILL REVERT THIS PATCH IMMEDIATELY. It is a kill switch that may need to be merged in later. *** Patching this CL is a quick shut-off mechanism in the event sync needs to de disabled prior to a release build. TEST=No sync UI visible. about:sync shows 'SYNC_DISABLED', no 'Sync Data' folder created when run. Review URL: http://codereview.chromium.org/270049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28645 0039d316-1c4b-4281-b951-d872f2087c98
* Move more ICU-dependent stuff from base into base/i18n. Some test stuff alsobrettw@chromium.org2009-10-092-2/+2
| | | | | | | | | | | | depended on this, so to make the DEPS work out, I made a new base/test directory where I moved the testing-related files into a new directory base/test. TEST=none BUG=none Review URL: http://codereview.chromium.org/266038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28569 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Theme the bookmark bar on the new tab page.erg@chromium.org2009-10-091-0/+4
| | | | | | | | | | | | | | | | | - XIB change: The controller has a connection to buttonView_. - BrowserThemeProviderMac: Fix a bug where we weren't returning default colors; we returned nil instead. - The majority of the implementation is actually the cross platform NtpBackgroundUtil::PaintBackgroundDetachedMode. We do platform specific drawing on top of the background, though. TEST=BookmarkBarToolbarViewTest.DisplayAsFloatingBarWithNoImage TEST=BookmarkBarToolbarViewTest.DisplayAsFloatingBarWithBgImage BUG=http://crbug.com/17625 Review URL: http://codereview.chromium.org/266027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28560 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Revert "Start the database query for the new tab page results as soon""tony@chromium.org2009-10-092-39/+93
| | | | | | | | | | | | | | This re-applies r28549 with a NULL pointer check for the HistoryService, which can be NULL during unit tests. It also means that if the user does a view-source on the new tab page, we make a wasted query to the history service, but I guess that's not a big deal. TBR=arv Review URL: http://codereview.chromium.org/267039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28559 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Start the database query for the new tab page results astony@chromium.org2009-10-092-85/+34
| | | | | | | | | | soon" because TabContentsTest.NTPViewSource is crashing on linux. This reverts commit r28549. Review URL: http://codereview.chromium.org/273004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28551 0039d316-1c4b-4281-b951-d872f2087c98
* Start the database query for the new tab page results as soontony@chromium.org2009-10-092-34/+85
| | | | | | | | | | | as we create the MostVisitedHandler. I find that in practice, once the new tab page is warm, we get the results before the new tab page html loads. Review URL: http://codereview.chromium.org/267034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28549 0039d316-1c4b-4281-b951-d872f2087c98
* Move MostVisitedHandler into a separate file because it's big.tony@chromium.org2009-10-084-811/+860
| | | | | | | | | I'm going to be modifying this file a lot and the single big file was hard to work with. Review URL: http://codereview.chromium.org/265040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28435 0039d316-1c4b-4281-b951-d872f2087c98
* Fix tips in OS X to respect system language settings instead of locale.mirandac@chromium.org2009-10-071-5/+5
| | | | | | | | | | | | BUG= http://crbug.com/22727 TEST= Set preferred language to a different setting from the locale in the OS X system settings. Make sure that the language of the tips matches the language setting (which should be the same as that of the Chrome UI). If tips are not available in the Chrome UI language, no tips should be shown. Review URL: http://codereview.chromium.org/258037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28193 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r28050 and put the paint observer timeout back to 2 sec.tony@chromium.org2009-10-061-1/+1
| | | | | | | | | The new tab times didn't change on linux/mac so that's probably not the problem. This will speed up the new tab tests. Review URL: http://codereview.chromium.org/256083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28175 0039d316-1c4b-4281-b951-d872f2087c98
* Modify extension request IPC messages to pass a ListValue instead of a string.mpcomplete@chromium.org2009-10-062-15/+3
| | | | | | | | | | | | This allows us to pass binary values through extension requests. I use this in my next CL to pass SkBitmaps. BUG=23269 TEST=no Review URL: http://codereview.chromium.org/251093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28130 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Implements the special bookmark bar on NTP.erg@chromium.org2009-10-061-8/+8
| | | | | | | | | | | | | Based mostly on Ben's patch, but made it compile, work, and descoped moving the bookmark bar around the view heiarchy. XIB modification: The root view is now a BookmarkBarToolbarView instead of an NSView and is [BookmarkBarController view]. BUG=17625 Review URL: http://codereview.chromium.org/246034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28074 0039d316-1c4b-4281-b951-d872f2087c98
* Remove references to DOMUIContents. It looks like the class doesn't exist.tony@chromium.org2009-10-051-1/+1
| | | | | | Review URL: http://codereview.chromium.org/257055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28063 0039d316-1c4b-4281-b951-d872f2087c98
* Up the new tab paint observer timeout from 2s to 5s. Trying to seetony@chromium.org2009-10-051-2/+2
| | | | | | | | | | | | if this gets us more accurate data on new tab times. BUG=21398 TBR=evanm (ok'ed in person) Review URL: http://codereview.chromium.org/257052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28050 0039d316-1c4b-4281-b951-d872f2087c98
* Move the JPEG and PNG codecs from base/gfx to app/gfx/codec. Move the classesbrettw@chromium.org2009-10-035-9/+6
| | | | | | | | | | | | | | | into the gfx namespace. Combine the PNGEncoder and PNGDecoder. There were separate when we had different executables for the browser and renderer, and linked the encoder only in one of them (which saved us some space used by libpng). This hasn't been the case for years, so combining them (again) makes sense. TEST=none BUG=none Review URL: http://codereview.chromium.org/243076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27930 0039d316-1c4b-4281-b951-d872f2087c98
* Add histograms that track how long it takes to open the new tab page.tony@chromium.org2009-10-021-0/+20
| | | | | | | | | | | | | | | This doesn't time all loads of the new tab page, just new foreground tabs using ctrl+t or the plus button. This includes the time it takes to create the tab contents and logs the time until JS has started executing, domcontentloaded, and onload. Note: onload doesn't mean the page is done loading. We have "NewTabUI load" for that. BUG=23120 Review URL: http://codereview.chromium.org/242107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27918 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the NewTabUI load UMA metric.tony@chromium.org2009-10-022-9/+20
| | | | | | | | | | | We were attaching the paint observer to the a RenderWidgetHost that was getting immediately swapped out when the new tab page started to load. Instead, wait and use the DOM UI callback methods which happen right after NewTabUI is created. Review URL: http://codereview.chromium.org/242115 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27850 0039d316-1c4b-4281-b951-d872f2087c98
* Fix NTP so that it updates on theme change.mirandac@chromium.org2009-10-022-5/+15
| | | | | | | | | | BUG= http://crbug.com/20392 TEST= Open several windows and new tabs. Change theme. Note that NTP background images all update correctly. Review URL: http://codereview.chromium.org/243067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27841 0039d316-1c4b-4281-b951-d872f2087c98
* Fix linux views build.estade@chromium.org2009-10-021-2/+2
| | | | | | | | TBR=nsylvain Review URL: http://codereview.chromium.org/255049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27805 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Detach bookmark bar on NTP.estade@chromium.org2009-10-011-0/+4
| | | | | | | | | | | | | | | | | | | TODO=get alignment right for NTP background when alignment != top TODO=fancy-pants animation (on windows this animation looks rather janky anyway so I'm not eager to work on this) TODO=tweak in gtk mode (border color=?) TEST=fiddle a lot, make sure there are no problems with find bar occlusion. TEST=install a bunch of different themes; everything looks right (up to TODOs) TEST=switch back and forth between gtk theme and chromium theme TEST=popup windows still work TEST=poked around in valgrind TEST=poked around with fullscreen BUG=18780 Review URL: http://codereview.chromium.org/243057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27801 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Check return value of GetInteger.mattm@chromium.org2009-10-011-2/+1
| | | | | | | | | | CID=6192 BUG=none TEST=none Review URL: http://codereview.chromium.org/257013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27763 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: tips_cache_->GetSize() returns an unsigned int so the comparison ↵jhawkins@chromium.org2009-09-301-1/+3
| | | | | | | | | | | >= 0 is always true. Change the check to != 0 to actually have an effect. CID=6044 BUG=none TEST=none Review URL: http://codereview.chromium.org/255030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27662 0039d316-1c4b-4281-b951-d872f2087c98
* BrowsingDataRemover* should not be scoped.kuchhal@chromium.org2009-09-302-8/+8
| | | | | | | | | | | BrowsingDataRemover deletes itself (see browsing_data_remover.cc: MessageLoop::current()->DeleteSoon(FROM_HERE, this)). BUG=22068 Review URL: http://codereview.chromium.org/218001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27607 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 27389.darin@chromium.org2009-09-301-2/+2
| | | | | | Review URL: http://codereview.chromium.org/246027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27594 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the enable-sync flag from the Chrome command line and enable sync by ↵brg@chromium.com2009-09-292-1/+11
| | | | | | | | | | default. BUG=none Test=Sync my bookmarks should be enabled by default. Review URL: http://codereview.chromium.org/248024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27472 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 27379, in hopes of fixing browser_tests.senorblanco@chromium.org2009-09-281-2/+2
| | | | | | | | TBR=darin Review URL: http://codereview.chromium.org/248021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27389 0039d316-1c4b-4281-b951-d872f2087c98
* Assert that thread-safe reference counting is used withdarin@chromium.org2009-09-281-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | cross-thread NewRunnableMethod. This assertion caught such an error in VisitedLinkMaster! My approach, modify RunnableMethodTraits<T> to assert that when ReleaseCallee happens on a different thread from RetainCallee that the type supports thread-safe reference counting. I do this by adding a static method to both RefCounted<T> and RefCountedThreadSafe<T>. This results in a little ugliness in cases where people implement AddRef and Release by hand (to make the no-ops). There may be a nicer way to deal with those few cases. R=brettw BUG=none TEST=none Review URL: http://codereview.chromium.org/251012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27379 0039d316-1c4b-4281-b951-d872f2087c98
* Misc. Cleanup related to OOP Profile Importjeremy@chromium.org2009-09-251-0/+1
| | | | | | | | | * Add PROFILE_IMPORT_PROCESS type to ChildProfileInfo. * Other small bits of cleanup. Review URL: http://codereview.chromium.org/220027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27222 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize pending_buf_size_ in the constructor.jhawkins@chromium.org2009-09-241-1/+4
| | | | | | | | | CID=1639 BUG=none TEST=none Review URL: http://codereview.chromium.org/218011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27108 0039d316-1c4b-4281-b951-d872f2087c98
* Move functions from skia/ext to app/gfx where possible: most of skia_utils.* ↵pkasting@chromium.org2009-09-241-3/+3
| | | | | | | | | | | | | and image_operations.* can be moved because they are not used by WebKit code. This also fixes the spelling of "Convolusion" to "Convolution" and updates some copyrights. This is a re-do of r26975, this time with WebKit update and some fixes to compile on Mac and Linux. BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27031 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 26975.pkasting@chromium.org2009-09-231-3/+3
| | | | | | Review URL: http://codereview.chromium.org/222011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26979 0039d316-1c4b-4281-b951-d872f2087c98
* Move functions from skia/ext to app/gfx where possible: most of skia_utils.* ↵pkasting@chromium.org2009-09-231-3/+3
| | | | | | | | | | | | and image_operations.* can be moved because they are not used by WebKit code. This also fixes the spelling of "Convolusion" to "Convolution" and updates some copyrights. BUG=none TEST=none Review URL: http://codereview.chromium.org/207059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26975 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a theme promo in the lower right cornerarv@chromium.org2009-09-232-4/+16
| | | | | | | | | BUG=None TEST=The theme promo should show up in the lower right corner and when clicked should navigate to the Chrome theme gallery. The promo should go away after 5 runs of chrome Review URL: http://codereview.chromium.org/217020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26894 0039d316-1c4b-4281-b951-d872f2087c98
* Fix check for wr_list validity not covering entire use.mattm@chromium.org2009-09-181-3/+2
| | | | | | | | | | | (Coverity FORWARD_NULL error CID 6043.) BUG=17101 TEST=none Review URL: http://codereview.chromium.org/209038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26607 0039d316-1c4b-4281-b951-d872f2087c98
* Change the URLs used to access "view-cache:" and "view-net-internals:".eroman@chromium.org2009-09-141-0/+35
| | | | | | | | | | | | | | | | | | "net-internal:*" ==> "chrome://net-internals/*" "view-cache:*" ==> "chrome://net-internals/view-cache/*" "view-cache:stats" ==> "chrome://net-internals/httpcache.stats" As before, there are also aliases from the "about:*" page: "about:net-internal[/*]" aliases "chrome://net-internals/*" "about:cache[/*]" aliases "chrome://net-internals/view-cache" BUG=http://crbug.com/21551 Review URL: http://codereview.chromium.org/202067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26158 0039d316-1c4b-4281-b951-d872f2087c98
* Move StringPiece into the base namespace. It is collidingtony@chromium.org2009-09-105-8/+8
| | | | | | | | | | with the StringPiece class in icu4.2, which is a problem when trying to use the system version of icu. Review URL: http://codereview.chromium.org/193072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25920 0039d316-1c4b-4281-b951-d872f2087c98
* Fix problem of white box appearing in themes without an NTP background image.mirandac@chromium.org2009-09-101-8/+8
| | | | | | | | | BUG= http://crbug.com/21290 TEST= Install a theme without an NTP image (greyscale). Look at NTP with bookmarkbar attached and detached. See no white box at bottom of NTP. Review URL: http://codereview.chromium.org/194066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25861 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that tips change when the Chrome language changes.mirandac@chromium.org2009-09-101-0/+15
| | | | | | | | | BUG= http://crbug.com/21394 TEST= Change chrome language. Close and reopen browser. Tips should appear in new language, or, if not available, they should not appear. Review URL: http://codereview.chromium.org/199073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25834 0039d316-1c4b-4281-b951-d872f2087c98
* Fix to use FilePath version of PathService::Get.thestig@chromium.org2009-09-091-1/+1
| | | | | | | | | | | BUG=None TEST=None Original Review URL: http://codereview.chromium.org/174189 Patch from Thiago Farina <thiago.farina@gmail.com>. Review URL: http://codereview.chromium.org/193047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25778 0039d316-1c4b-4281-b951-d872f2087c98
* NNTP: Fix issue with pinning the pre-populated thumbnails.arv@google.com2009-09-041-49/+66
| | | | | | | | | | | | BUG=20801 TEST=Create a new profile and open the new tab page. Pin and reorder the pre-populated thumbnails. The thumbnails and favicons should continue to work. Review URL: http://codereview.chromium.org/195010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25422 0039d316-1c4b-4281-b951-d872f2087c98