summaryrefslogtreecommitdiffstats
path: root/chrome/browser/dom_ui
Commit message (Collapse)AuthorAgeFilesLines
* Make use of the new Js Template i18n for print domuimhm@chromium.org2009-07-151-4/+3
| | | | | | | | | | | Provides a simpler js template engine for print tab which is optimized better than JsTemplate. BUG=173, 947 TEST=print page loads fine. Review URL: http://codereview.chromium.org/155479 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20702 0039d316-1c4b-4281-b951-d872f2087c98
* Update tooltips according to Roma. I ended up calling "Unpin" "Don'tarv@google.com2009-07-141-1/+6
| | | | | | | | | | | | | | keep on this page" since all the other suggestions are pretty bad as they are. BUG=None TEST=The tooltips should have been updated Review URL: http://codereview.chromium.org/155532 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20671 0039d316-1c4b-4281-b951-d872f2087c98
* Hookup Print HTML page to the DOM UI for Print Preview and Settingsmhm@chromium.org2009-07-144-7/+91
| | | | | | | | | | | | | | Depends on initial foundation: http://src.chromium.org/viewvc/chrome?view=rev&revision=19906 And html mockup: http://src.chromium.org/viewvc/chrome?view=rev&revision=19918 BUG=173, 947 TEST=The user will see the print html page as a html test webpage. Review URL: http://codereview.chromium.org/155067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20595 0039d316-1c4b-4281-b951-d872f2087c98
* This provides a simpler js template engine than JsTemplate. It has beenarv@google.com2009-07-143-9/+11
| | | | | | | | | | | | | | | | | | optimized for the way we do internationalization with JST before and is about 4 times faster (average 4.8ms vs 22.8ms) for the history page. The syntax for this is very similar to JsTemplates. It uses the attributes i18n-values and i18n-content which worls like jsvalues and jscontent except that it does not allow arbitrary expressions. BUG=None TEST=All UI pages should work as before Review URL: http://codereview.chromium.org/149420 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20590 0039d316-1c4b-4281-b951-d872f2087c98
* Turn backend tip service on by default.mirandac@chromium.org2009-07-122-6/+6
| | | | | | | | | | BUG= none. TEST= New NTP should come up with a default title in Tips and Suggestions box, then be loaded with actual data from popgadget. Review URL: http://codereview.chromium.org/149255 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20466 0039d316-1c4b-4281-b951-d872f2087c98
* Change ThumbnailStore to use sqlite instead of individual files try 2. ↵meelapshah@chromium.org2009-07-092-5/+2
| | | | | | | | Previous try failed interactive_ui_tests. Review URL: http://codereview.chromium.org/149361 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20272 0039d316-1c4b-4281-b951-d872f2087c98
* Do some refactoring of renderer_host.brettw@chromium.org2009-07-061-1/+1
| | | | | | | | | | | | | | | | | | | This removes the last dependency on tab_contents from the renderer_host code and into the RenderViewHostDelegate. Some of the tests depended on tab_contents, so I moved to a new directory with the tab_contents include allowed via DEPS. Now DEPS can enforce that no additional tab_contents includes are added to renderer_host. RenderViewHost delegate is now pure virtual. After spending a while *again* figuring out why my code didn't work, only to find it was because the default implementation of a function was getting called instead of the real one, I decided to make this pure virtual. It is implemented by TabContents, which implements basically everything, and two other places that implement less. Only two lists of duplicate functions seems not too bad, although long-term it would be nice if this delegate was somehow more succinct. Review URL: http://codereview.chromium.org/155071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19982 0039d316-1c4b-4281-b951-d872f2087c98
* Reapply r19950. Turns out it wasn't at fault for breaking the vista tests.willchan@chromium.org2009-07-062-0/+18
| | | | | | | | | | | This reverts commit 6c6d8665c114217a14fea346cca97006e4c3daa7. BUG=none TEST=none TBR=nsylvain Review URL: http://codereview.chromium.org/155097 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19961 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r19950 since it broke vista tests.willchan@chromium.org2009-07-062-18/+0
| | | | | | | | | | Revert "Add checks to track down crashes in URLRequestChromeJob." BUG=none TEST=none Review URL: http://codereview.chromium.org/155092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19957 0039d316-1c4b-4281-b951-d872f2087c98
* Add checks to track down crashes in URLRequestChromeJob.willchan@chromium.org2009-07-062-0/+18
| | | | | | | | | BUG=http://crbug.com/13924 TEST=none Review URL: http://codereview.chromium.org/155011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19950 0039d316-1c4b-4281-b951-d872f2087c98
* Foundations for Print Preview and Setupmhm@chromium.org2009-07-033-0/+40
| | | | | | | | | | | | | Create the foundations of implementing a tab for printing should be in the form of: print:http://www.google.com I have followed similar approach as what has been done with view-source: and chrome-extension: BUG=173, 947 TEST=none Review URL: http://codereview.chromium.org/150207 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19906 0039d316-1c4b-4281-b951-d872f2087c98
* Modify ThumbnailStore to make one call to the HistoryBackend using ↵meelapshah@chromium.org2009-07-032-38/+2
| | | | | | | | | | | QueryTopURLsAndRedirects instead of a seperate call for each URL. Also clean up some of the code and fix bug 14644. BUG=14644 TEST=none Review URL: http://codereview.chromium.org/149126 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19879 0039d316-1c4b-4281-b951-d872f2087c98
* Remove null link from "welcome to tips" default suggestion. Also make some ↵mirandac@chromium.org2009-07-013-3/+12
| | | | | | | | | | | hard-coded strings in new tab page into localizable .grd strings, and fix bug introduced in r19556. BUG= http://crbug.com/15467 TEST= Run with new new tab page for the first time, with no tips stored in preferences. Note that welcome tip is not a link. Review URL: http://codereview.chromium.org/147247 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19740 0039d316-1c4b-4281-b951-d872f2087c98
* In this episode, we implement the DOMUI interface for extension views that ↵aa@chromium.org2009-07-013-4/+24
| | | | | | | | | | are rendered in the main tab contents area. This gets us loaded and unloaded at the right place and removes many special cases for extensions from the RenderViewHost and RenderViewHostDelegate hierarchy. BUG=13936 Review URL: http://codereview.chromium.org/126137 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19717 0039d316-1c4b-4281-b951-d872f2087c98
* A recent refactoring of the DOM UI had caused the download page to be blank.jcampan@chromium.org2009-06-301-0/+1
| | | | | | | | | | A call to Init had been removed. BUG=http://crbug.com/15680 TEST=Download a file. Open the download page (CTRL-J) it should show the download. Review URL: http://codereview.chromium.org/151110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19681 0039d316-1c4b-4281-b951-d872f2087c98
* Reland arv's NNTP enablery after it was reverted in 19603glen@chromium.org2009-06-302-33/+32
| | | | | | | | TBR=arv Review URL: http://codereview.chromium.org/151108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19651 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 19593.glen@chromium.org2009-06-302-32/+33
| | | | | | Review URL: http://codereview.chromium.org/150112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19603 0039d316-1c4b-4281-b951-d872f2087c98
* Enable the NNTP by default.arv@google.com2009-06-302-33/+32
| | | | | | | | | | | | | | | | | This renames the command line flags a bit. --new-tab-page=path/to/file.html --old-new-tab-page BUG=13362 TEST=Launch chrome and you should see the new new tab page. Review URL: http://codereview.chromium.org/151054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19593 0039d316-1c4b-4281-b951-d872f2087c98
* Take two for http://codereview.chromium.org/131094tim@chromium.org2009-06-2914-152/+194
| | | | | | | | This time without browser_tests timeout that caused the revert. The problem was BrowsingHistoryHandler trying to use a dom_ui_ before being attached. Review URL: http://codereview.chromium.org/149117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19556 0039d316-1c4b-4281-b951-d872f2087c98
* Fix memory leak in tips handler.finnur@chromium.org2009-06-291-1/+1
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/150052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19533 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the forgotten renames of recommendations to tips.arv@google.com2009-06-271-4/+4
| | | | | | | | | | BUG=15491 TEST=Open the options menu and there should be no "null" in the UI Review URL: http://codereview.chromium.org/147249 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19467 0039d316-1c4b-4281-b951-d872f2087c98
* revert cl 19438rvargas@google.com2009-06-272-25/+362
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/149116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19444 0039d316-1c4b-4281-b951-d872f2087c98
* Make the new new tab page the default new tab page.arv@google.com2009-06-262-362/+25
| | | | | | | | | | | | | I changed the command line switch "--new-new-tab-page" to "-new-tab-page=<path>" so we can continue to iterate. BUG=13362 TEST=The new new tab page should be on by default. Review URL: http://codereview.chromium.org/147226 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19438 0039d316-1c4b-4281-b951-d872f2087c98
* Make bookmark model public interface use const BookmarkNode* instead ofmunjal@chromium.org2009-06-261-12/+12
| | | | | | | | | | | | | | | BookmarkNode*. This helps in making the BookmarkNode class setters public also without worrying about someone inadvertently changing BookmarkNode properties directly for bookmark model bookmarks. Change all the call sites to reflect this. BUG=none TEST=none Review URL: http://codereview.chromium.org/146116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19428 0039d316-1c4b-4281-b951-d872f2087c98
* Validates links which are to be passed on to the NTP by ensuring that they ↵mirandac@chromium.org2009-06-262-8/+14
| | | | | | | | | | | start with "http://" or "https://". BUG= http://crbug.com/15457 TEST= Change cached tip link in preferences file to be invalid. Note that this tip will not be included on the NTP. Review URL: http://codereview.chromium.org/149083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19415 0039d316-1c4b-4281-b951-d872f2087c98
* Revert cl 19359 due to browser_tests timeout.tim@chromium.org2009-06-2614-182/+144
| | | | | | | TBR=nsylvain Review URL: http://codereview.chromium.org/147206 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19363 0039d316-1c4b-4281-b951-d872f2087c98
* Add a 'RegisterMessages' function to DOMMessageHandler to make it easy to ↵tim@chromium.org2009-06-2614-144/+182
| | | | | | | | | | | | | | construct these objects by deferring the DOMUI dependency to the init / "Attach" step. Add GetMessageHandlers to HtmlDialogUIDelegate to allow sending/receiving messages to the page hosted in the dialog as opposed to only on open/close. BUG=none TEST=none Review URL: http://codereview.chromium.org/131094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19359 0039d316-1c4b-4281-b951-d872f2087c98
* Hooks backend tip service into new tab page. Also changes tip service to ↵mirandac@chromium.org2009-06-256-113/+100
| | | | | | | | | | | load tips from popgadget, at http://www.google.com/labs/popgadget/world. BUG= http://crbug.com/14962 TEST= Enable new tab page. See welcome message. On reload afterwards (and always after that, as long as preferences file isn't removed), see browsing recommendations appear in bottom right corner. Review URL: http://codereview.chromium.org/147109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19306 0039d316-1c4b-4281-b951-d872f2087c98
* Add tooltips to buttons on the new new tab page as well as remove thearv@google.com2009-06-241-17/+22
| | | | | | | | | | | | | | edit link. BUG=14958, 15073 TEST=On the new new tab page. No "edit" link should show up after a long hover of a thumbnail. The pin/unpin, remove, show/hide thumbnails, show/hide list should all show tooltips. Review URL: http://codereview.chromium.org/146108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19196 0039d316-1c4b-4281-b951-d872f2087c98
* Add looking up/caching of redirect lists to find the best thumbnail.meelapshah@chromium.org2009-06-242-6/+49
| | | | | | | | | Added timer to clean unpopular thumbnails from the cache/disk every hour. Still need to implement removal of blacklisted urls. Review URL: http://codereview.chromium.org/126237 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19189 0039d316-1c4b-4281-b951-d872f2087c98
* In case current language is RTL we mark file names as LTR to avoid problems ↵cira@chromium.org2009-06-241-1/+5
| | | | | | | | like A-B.jpg becoming B.jpg-A on download page and new-new-tab/download section.BUG=http://crbug.com/15094TEST=Start Chrome with --lang=he --new-new-tab options and check that filename with - in the name has the proper form (check bug on how to get the file). I've checked LTR language (sr) too and output remains correct. Review URL: http://codereview.chromium.org/146064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19150 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Nuke legacy debugger.pfeldman@chromium.org2009-06-243-161/+0
| | | | | | Review URL: http://codereview.chromium.org/146027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19108 0039d316-1c4b-4281-b951-d872f2087c98
* Update the New New Tab Page. There are still a lot of things that arearv@google.com2009-06-223-3/+131
| | | | | | | | | | | | | | not implemented but it is time to get this submitted and iron out the remaining issues. BUG=13362 TEST=Start chrome with --new-new-tab-page and look at play arouind with the new tab page. Review URL: http://codereview.chromium.org/132027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18989 0039d316-1c4b-4281-b951-d872f2087c98
* First draft of web resource service; fetches data from a JSON feed mirandac@chromium.org2009-06-192-2/+2
| | | | | | | | | | | | and stores it in user prefs, where it can be used by the new tab page. BUG = http://crbug.com/13363 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18766 Review URL: http://codereview.chromium.org/125052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18842 0039d316-1c4b-4281-b951-d872f2087c98
* First draft of web resource service; fetches data from a JSON feed mirandac@chromium.org2009-06-184-0/+168
| | | | | | | | | | and stores it in user prefs, where it can be used by the new tab page. BUG = http://crbug.com/13363 Review URL: http://codereview.chromium.org/125052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18766 0039d316-1c4b-4281-b951-d872f2087c98
* Add file icons to chrome://downloads/ on the Mac. Add Skia helpermark@chromium.org2009-06-161-4/+3
| | | | | | | | | | CGImageToSkBitmap(). Patch by Robert Sesek <rsesek@bluestatic.org> Review URL: http://codereview.chromium.org/118488 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18517 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug where keyword editor would end up prefixing all keyword urlssky@chromium.org2009-06-151-2/+2
| | | | | | | | | | | | | | | | with "http://" if they didn't have one. This proves problematic as for the google search url we don't have http:// and don't want it. The fix is to only add http:// if the url field is editable. If the url field isn't editable, we know the user hasn't editted it and don't need to try and fix it up. BUG=13282 TEST=see bug, but also make sure you don't run into any other problems with the keyword editor. Review URL: http://codereview.chromium.org/126052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18410 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce header dependencies in browser/phajdan.jr@chromium.org2009-06-135-4/+11
| | | | | | | | | | | | - remove unneeded header includes - move implementation bits out of headers - more explicit header deps In my scan of headers I got up to (including) dom_ui. Review URL: http://codereview.chromium.org/126071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18353 0039d316-1c4b-4281-b951-d872f2087c98
* Show the remaining time in the downloads page.arv@google.com2009-06-101-2/+2
| | | | | | | | | | BUG=13386 TEST=Download a large file and make sure that you see the speed in the donwloads page. Review URL: http://codereview.chromium.org/119428 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18102 0039d316-1c4b-4281-b951-d872f2087c98
* Modified ThumbnailStore to cache/store JPEGs insteadbrettw@chromium.org2009-06-091-0/+22
| | | | | | | | | | | | | of SkBitmaps. Add command line flag "--thumbnail-store" to enable using the ThumbnailStore facility instead of the current ThumbnailDatabase. Original review: http://codereview.chromium.org/118409 Patch by Meelap Shah git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17971 0039d316-1c4b-4281-b951-d872f2087c98
* Second (and hopefully the final) fix for the issue 805:yusukes@google.com2009-06-061-0/+6
| | | | | | | | | | | | | | | | Killed (1) the "start download" (big arrow) animation and (2) fade and resize animation on NTP page, when the following conditions is met: (XP) Chromium is used over RDP. (Vista) "Turn off all unnecessary animations (when possible)" option in "Control Panel - Ease of Access Center - Make the computer easier to see" is checked. Note that the option automatically becomes checked when a user turns off the "Menu and window animation" option of a remote-desktop client. Review: http://codereview.chromium.org/115304 BUG=805 TEST=For (1), download a file and verify the arrow doesn't appear over RDP. For (2), set NTP as your homepage, start chromium on RDP session, verify fade animations on thumbnails are killed, then resize browser window, verify resize animations on thumbnails are also killed. Do the same thing with --new-new-tab-page command line flag. Review URL: http://codereview.chromium.org/118307 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17827 0039d316-1c4b-4281-b951-d872f2087c98
* Don't call HandleGetMostVisited on the backend after each black listarv@google.com2009-06-061-15/+8
| | | | | | | | | | | | | | | | | operation. Instead let JS do the call as needed. This is in preparation for the new new tab page which will do other things when an URL is blacklisted. Also, fix some issue in the last CL BUG=13362 TEST=Add and clear most visted items like before. Things should work as before Review URL: http://codereview.chromium.org/118350 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17817 0039d316-1c4b-4281-b951-d872f2087c98
* More theme bits for the NTP and window frame.glen@chromium.org2009-06-052-2/+12
| | | | | | | | | BUG=12768,13352 TEST=Verify that a theme with attribution works on the NTP and a theme with an overlay shows up Review URL: http://codereview.chromium.org/119227 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17773 0039d316-1c4b-4281-b951-d872f2087c98
* Adds the backend for pinned items on the most visited page.arv@google.com2009-06-051-17/+179
| | | | | | | | | | | | The pinned items are stored in the pref ntp.pinned_urls. TEST=For now this should not change the behavior of the most visited thumbnails. BUG=13362 Review URL: http://codereview.chromium.org/118269 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17766 0039d316-1c4b-4281-b951-d872f2087c98
* Allow themes to change the background of the new tab page. Adds support for ↵glen@chromium.org2009-06-023-4/+61
| | | | | | | | | | | display properties to themes (stored internally as ints/enums, but parsed from text). BUG=12768 TEST=Install a theme with an new tab page background and verify that the background appears on the new tab page. Review URL: http://codereview.chromium.org/115910 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17431 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity underground warfare: Uninitalized membercpu@google.com2009-05-301-1/+5
| | | | | | | | | | | | - Fix ctor to init members - CID 4186 BUG = none TEST = well, it is a unit test Review URL: http://codereview.chromium.org/112076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17276 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce header dependencies in net/phajdan.jr@chromium.org2009-05-291-0/+2
| | | | | | | | TEST=none Review URL: http://codereview.chromium.org/115870 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17178 0039d316-1c4b-4281-b951-d872f2087c98
* Headers cleanup in chrome/commonphajdan.jr@chromium.org2009-05-291-0/+1
| | | | | | | | | - reduce header dependencies - miscellanous cleanups (whitespace, explicit deps) Review URL: http://codereview.chromium.org/113945 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17177 0039d316-1c4b-4281-b951-d872f2087c98
* Allow passing in a file path to a file that will be used for the new new tabarv@google.com2009-05-291-4/+48
| | | | | | | | | | | | | | page. This allows faster prototyping (F5) of the NNTP. TEST=Start Chrome with --new-new-tab-page=path/to/file.html. The NTP should show the file. Make a visible change in the file and reload the tab page and the change should be visible immidiately. BUG=None Review URL: http://codereview.chromium.org/113927 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17150 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes multiple definitions for DragDownload.sky@chromium.org2009-05-271-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/115811 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16992 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-20 06:48:22 +0000