summaryrefslogtreecommitdiffstats
path: root/chrome/browser/download/download_status_updater_unittest.cc
Commit message (Collapse)AuthorAgeFilesLines
* [Downloads] Add real observers to MockDownloadItem.asanka@chromium.org2014-05-101-6/+0
| | | | | | | | | | | | Managing observer lists is needed by all the tests that end up calling DownloadItem::AddObserver. This CL adds real observers to MockDownloadItem so that tests don't need to mock this behavior. BUG=367311 Review URL: https://codereview.chromium.org/248713004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269585 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of the message_loop header in chrome/browser/, part 4.avi@chromium.org2013-07-181-1/+1
| | | | | | | | | | BUG=260807 TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/19556004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212189 0039d316-1c4b-4281-b951-d872f2087c98
* BrowserContext should simply own DownloadManagercaio.de.oliveira.filho@intel.com2013-05-291-9/+9
| | | | | | | | | | | | | | | | | | | This patch changes BrowserContext so it store a DownloadManager directly (as UserData), instead of storing a refptr to it. Client code (mostly tests) that used refptrs was changed to use either raw pointers or to use scoped_ptr/ScopedVector in case of DownloadManagers created by it. The Bind() in DownloadManagerImpl::CheckForFileRemoval() is now using a weak pointer to itself. BUG=237871 TEST=content_unittests and {unit,browser}_tests with *Download* and *SavePage* Review URL: https://chromiumcodereview.appspot.com/15701007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202743 0039d316-1c4b-4281-b951-d872f2087c98
* chrome: Use base::MessageLoop. (Part 3)xhwang@chromium.org2013-05-281-1/+1
| | | | | | | | | | | | This CL updates chrome/browser/* other than chrome/browser/ui which is in another CL. BUG=236029 TBR=brettw Review URL: https://chromiumcodereview.appspot.com/14113053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202664 0039d316-1c4b-4281-b951-d872f2087c98
* Use DownloadItem::GetState() in c/b/{download,extensions}caio.de.oliveira.filho@intel.com2013-05-241-4/+6
| | | | | | | | | | | | | | | | | Stop using DownloadItem::Is*() functions that have an equivalent state exposed via GetState(). Rationale is that there shouldn't be multiple ways of getting the same state information. To make review easier, this patch covers chrome/browser/download and chrome/browser/extensions. The remaining cases and changing the DownloadItem to remove the Is*() functions will come later. BUG=241141 TEST=browser_tests and unit_tests both with *Download*:*SavePage* filters Review URL: https://chromiumcodereview.appspot.com/15880002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202229 0039d316-1c4b-4281-b951-d872f2087c98
* Make DownloadHistory observe manager, itemsbenjhayden@chromium.org2012-11-201-8/+8
| | | | | | | | | | | | | | | | | Rip out half of DownloadManagerDelegate. Make DownloadManager create persisted DownloadItems one at a time and return them to DownloadHistory. Move DownloadPersistentStoreInfo from content to chrome. Kill DownloadDatabase::CheckThread(). (Leftover from 85408.) Change DownloadDatabase::RemoveDownloads() to take an explicit set of db_handles. Merge DownloadDatabase::UpdateDownload[Path](). After this CL, I'll send out another one to remove the usage of CancelableRequest from the downloads-specific HistoryService APIs. BUG=154309 Review URL: https://chromiumcodereview.appspot.com/10915180 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168670 0039d316-1c4b-4281-b951-d872f2087c98
* chrome/browser: Update calls from RunAllPending() to RunUntilIdle().tfarina@chromium.org2012-11-171-1/+1
| | | | | | | | | | | | RunAllPending() is deprecated and we should switch to RunUntilIdle(). BUG=131220 TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/11413050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168416 0039d316-1c4b-4281-b951-d872f2087c98
* Ignore historical downloads in DownloadStatusUpdater::OnDownloadCreatedbenjhayden@chromium.org2012-09-201-1/+1
| | | | | | | | BUG=150743 Review URL: https://chromiumcodereview.appspot.com/10943032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157846 0039d316-1c4b-4281-b951-d872f2087c98
* HyperbolicDownloadItemNotifier observes ALL the items!benjhayden@chromium.org2012-09-131-26/+32
| | | | | | | | | | | | | This is a common enough pattern that is rarely implemented correctly. This probably would have prevented the crash in DownloadsDOMHandler. DownloadsDOMHandler uses HyperbolicDownloadItemNotifier::GetManager() not because it needs to, but in order to demonstrate how to respect ManagerGoingDown(). jam: chrome/OWNERS jhawkins: chrome/browser/ui/webui Review URL: https://chromiumcodereview.appspot.com/10831377 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156654 0039d316-1c4b-4281-b951-d872f2087c98
* Reland Make DownloadManager::GetAllDownloads return all downloads regardless ↵benjhayden@chromium.org2012-09-101-2/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | of state, persistence, temporariness, or save page. Callers such as download_status_updater_mac now need to explicitly check whether filenames are empty. Also change some callers from SearchDownloads() over to GetAllDownloads(). This is an experiment in preparation for DownloadHistory-that-is-an-Observer, which removes the persisted concept from content. http://codereview.chromium.org/10665049/ I tried to inspect each caller in this CL to check that it would be ok with this change, but I might have missed something. Reviewers breakdown: Done: rdsmith: * jam: chrome/browser/automation michaeln: chrome/browser/browsing_data jcivelli: content/public/test Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155351 BUG=147359 Review URL: https://chromiumcodereview.appspot.com/10913015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155829 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 155351 - Make DownloadManager::GetAllDownloads return all downloads ↵rdsmith@chromium.org2012-09-071-4/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | regardless of state, persistence, temporariness, or save page. Also change some callers from SearchDownloads() over to GetAllDownloads(). This is an experiment in preparation for DownloadHistory-that-is-an-Observer, which removes the persisted concept from content. http://codereview.chromium.org/10665049/ I tried to inspect each caller in this CL to check that it would be ok with this change, but I might have missed something. Reviewers breakdown: Done: rdsmith: * jam: chrome/browser/automation michaeln: chrome/browser/browsing_data jcivelli: content/public/test Review URL: https://chromiumcodereview.appspot.com/10913015 TBR=benjhayden@chromium.org BUG=147359 Review URL: https://chromiumcodereview.appspot.com/10914158 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155503 0039d316-1c4b-4281-b951-d872f2087c98
* Make DownloadManager::GetAllDownloads return all downloads regardless of ↵benjhayden@chromium.org2012-09-071-2/+4
| | | | | | | | | | | | | | | | | | | | | | state, persistence, temporariness, or save page. Also change some callers from SearchDownloads() over to GetAllDownloads(). This is an experiment in preparation for DownloadHistory-that-is-an-Observer, which removes the persisted concept from content. http://codereview.chromium.org/10665049/ I tried to inspect each caller in this CL to check that it would be ok with this change, but I might have missed something. Reviewers breakdown: Done: rdsmith: * jam: chrome/browser/automation michaeln: chrome/browser/browsing_data jcivelli: content/public/test Review URL: https://chromiumcodereview.appspot.com/10913015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155351 0039d316-1c4b-4281-b951-d872f2087c98
* Unify and clean up system download notifications, add Mountain Lion support.avi@chromium.org2012-08-121-17/+68
| | | | | | | | | | BUG=138962 TEST=as in bug Review URL: https://chromiumcodereview.appspot.com/10827207 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151195 0039d316-1c4b-4281-b951-d872f2087c98
* Move test_browser_thread.h from content\test to content\public\test. This ↵jam@chromium.org2012-06-041-1/+1
| | | | | | | | | | way we can enforce that internal content headers don't leak to embedders. BUG=98716 TBR=phajdan.jr Review URL: https://chromiumcodereview.appspot.com/10500016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140254 0039d316-1c4b-4281-b951-d872f2087c98
* Move mock download test headers from content\test to content\public\test. ↵jam@chromium.org2012-06-021-2/+2
| | | | | | | | | | This way we can enforce that internal content headers don't leak to embedders. BUG=98716 TBR=phajdan.jr Review URL: https://chromiumcodereview.appspot.com/10501012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140208 0039d316-1c4b-4281-b951-d872f2087c98
* Move download_types.h to content/public and rename it to match the one ↵jam@chromium.org2012-03-131-1/+0
| | | | | | | | | struct that's in it. Also move that struct to the content namespace. BUG=98716 Review URL: https://chromiumcodereview.appspot.com/9694044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126435 0039d316-1c4b-4281-b951-d872f2087c98
* download_request_handle.h isn't used by chrome.jam@chromium.org2012-03-011-1/+0
| | | | | | | BUG=98716 Review URL: https://chromiumcodereview.appspot.com/9569031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124530 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate DownloadProgressUpdated.avi@chromium.org2012-02-091-1/+8
| | | | | | | | | | | | | | | content::DownloadManagerDelegate::DownloadProgressUpdated was called out of sync with the content::DownloadItem::Observer calls. Eliminate it, as the notification that it provides is anti-useful. BUG=112841 TEST=as in bug Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=121031 Reverted: https://src.chromium.org/viewvc/chrome?view=rev&revision=121041 Review URL: http://codereview.chromium.org/9363001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121134 0039d316-1c4b-4281-b951-d872f2087c98
* Remove DownloadManager* dependency on DownloadStatusUpdater rdsmith@chromium.org2012-02-041-0/+283
| | | | | | | | | | | by making DownloadStatusUpdater an observer of DownloadManager. BUG=107264 Review URL: http://codereview.chromium.org/9005027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120487 0039d316-1c4b-4281-b951-d872f2087c98
* Move the core download files to content.jam@chromium.org2011-08-151-164/+0
| | | | | | Review URL: http://codereview.chromium.org/7618048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96829 0039d316-1c4b-4281-b951-d872f2087c98
* Move some files from base to base/memory.levin@chromium.org2011-03-281-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | raw_scoped_refptr_mismatch_checker.h ref_counted.cc ref_counted.h ref_counted_memory.cc ref_counted_memory.h ref_counted_unittest.cc scoped_callback_factory.h scoped_comptr_win.h scoped_handle.h scoped_native_library.cc scoped_native_library.h scoped_native_library_unittest.cc scoped_nsobject.h scoped_open_process.h scoped_ptr.h scoped_ptr_unittest.cc scoped_temp_dir.cc scoped_temp_dir.h scoped_temp_dir_unittest.cc scoped_vector.h singleton.h singleton_objc.h singleton_unittest.cc linked_ptr.h linked_ptr_unittest.cc weak_ptr.cc weak_ptr.h weak_ptr_unittest.cc BUG=None TEST=Compile Review URL: http://codereview.chromium.org/6714032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79524 0039d316-1c4b-4281-b951-d872f2087c98
* Fix DCHECK assertion failures in DownloadStatusUpdater.phajdan.jr@chromium.org2010-10-061-4/+9
| | | | | | | | | | | | They indicate real problems, including possible NULL pointer dereferences. BUG=57577 TEST=none Review URL: http://codereview.chromium.org/3519005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61634 0039d316-1c4b-4281-b951-d872f2087c98
* Create DownloadStatusUpdater to keep track of download progressphajdan.jr@chromium.org2010-09-271-0/+159
and update the application icon. We can't do that in DownloadManager because there are multiple DownloadManagers (one per Profile) and they would overwrite each other's updates. BUG=none TEST=none Review URL: http://codereview.chromium.org/3454018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60625 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-25 13:43:54 +0000