summaryrefslogtreecommitdiffstats
path: root/chrome/browser/download/save_package.h
Commit message (Collapse)AuthorAgeFilesLines
* Move the save file code from chrome to content. This is just a file move so ↵jam@chromium.org2011-07-141-327/+0
| | | | | | | | | | | the DEPS in content\browser\download is very permissive for now. The one exception is save_package.cc, where I had to split off the usage of SelectFileDialog because the code depended on grit which can't be used in content (circular dependencies in gyp). TBR=rdsmith BUG=82782 Review URL: http://codereview.chromium.org/7373004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92623 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 91861 - When the download folder does not exist, change the download ↵johnme@google.com2011-07-081-4/+0
| | | | | | | | | | | | | | | | | folder to a user's "Downloads" (or something depending on the platform) Description of reverted commit follows: - Set the download folder to Foo. You can download a PDF file to Foo without being asked anything (if you do not choose "Ask where to save each file before downloading"). Then delete Foo. Now, if you try to download the PDF file, then a file chooser dialog is displayed suggesting your "Downloads" folder. - Set the download folder to Foo. Save an HTML to Bar by right-clicking and choosing "Save as ..." on the tab. If you try to save the HTML, the file chooser dialog is displayed suggesting Bar. Then delete Bar. Now, if you try to save the HTML, the file chooser dialog is displayed suggesting Foo. Then delete Foo. If you try to save the HTML, the file chooser dialog is displayed suggesting your "Downloads" folder. - Set the download folder to Foo. Observe that Foo is displayed as the download location in the preferences page. Then delete Foo and reload the preferences page. Observe that your "Downloads" folder is displayed as the download location in the preferences page. If you are opening multiple preferences pages, then this change is automatically reflected to all the preferences pages. BUG=32552 TEST=SavePageBrowserTest.SavedFolder1,SavePageBrowserTest.SavedFolder2,SavePageBrowserTest.SavedFolder3,DownloadTest.DownloadedFolder,DownloadManagerTest.StartDownload,BaseFileTest.*,DownloadFileTest.RenameFileFinal Review URL: http://codereview.chromium.org/6973052 TBR=haraken@google.com Review URL: http://codereview.chromium.org/7324031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91869 0039d316-1c4b-4281-b951-d872f2087c98
* When the download folder does not exist, change the download folder to a ↵haraken@google.com2011-07-081-0/+4
| | | | | | | | | | | | | | | | user's "Downloads" (or something depending on the platform) - Set the download folder to Foo. You can download a PDF file to Foo without being asked anything (if you do not choose "Ask where to save each file before downloading"). Then delete Foo. Now, if you try to download the PDF file, then a file chooser dialog is displayed suggesting your "Downloads" folder. - Set the download folder to Foo. Save an HTML to Bar by right-clicking and choosing "Save as ..." on the tab. If you try to save the HTML, the file chooser dialog is displayed suggesting Bar. Then delete Bar. Now, if you try to save the HTML, the file chooser dialog is displayed suggesting Foo. Then delete Foo. If you try to save the HTML, the file chooser dialog is displayed suggesting your "Downloads" folder. - Set the download folder to Foo. Observe that Foo is displayed as the download location in the preferences page. Then delete Foo and reload the preferences page. Observe that your "Downloads" folder is displayed as the download location in the preferences page. If you are opening multiple preferences pages, then this change is automatically reflected to all the preferences pages. BUG=32552 TEST=SavePageBrowserTest.SavedFolder1,SavePageBrowserTest.SavedFolder2,SavePageBrowserTest.SavedFolder3,DownloadTest.DownloadedFolder,DownloadManagerTest.StartDownload,BaseFileTest.*,DownloadFileTest.RenameFileFinal Review URL: http://codereview.chromium.org/6973052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91861 0039d316-1c4b-4281-b951-d872f2087c98
* Virtual destructors should have virtual keyword.hans@chromium.org2011-05-251-1/+1
| | | | | | | | | | | | | | | | | Make sure user-declared virtual destructors always have the virtual keyword. The Clang style-check plugin will check for this soon. No functionality change: virtual is only added to destructors that are already implicitly virtual. Also fix a couple of in-line destructor definitions. BUG=83408 TEST=none Review URL: http://codereview.chromium.org/7064033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86587 0039d316-1c4b-4281-b951-d872f2087c98
* Use TCW in SavePackage.avi@chromium.org2011-05-121-4/+7
| | | | | | | | | BUG=71097 TEST=none Review URL: http://codereview.chromium.org/7013009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85151 0039d316-1c4b-4281-b951-d872f2087c98
* More progress towards removing content settings code from the content layer. ↵jam@chromium.org2011-05-101-8/+0
| | | | | | | | | We can't use CookiePolicy anymore since, being in the network layer, we can't give it render_process_id/render_view_id, which are needed to put up the content settings UI. Instead of the networking code calling CookiePolicy then calling the delegate (ResourceDispatcherHost) to inform it if something is blocked, we directly ask the delegate if something is allowed. ResourceDispatcherHost then calls the embedder, and passes along the IDs to identify the tab. In the next change, I'll use this mechansim in RenderMessageFilter and remove the CookiePolicy class. BUG=76793 Review URL: http://codereview.chromium.org/6995013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84881 0039d316-1c4b-4281-b951-d872f2087c98
* Alphabetize and remove unnecessary forward declaration of TabContents in ↵cbentzel@chromium.org2011-04-081-6/+5
| | | | | | | | | | | save_package.h BUG=None TEST=builds Review URL: http://codereview.chromium.org/6812019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80931 0039d316-1c4b-4281-b951-d872f2087c98
* Moved URLRequestContextGetter to net/ so it can be used by projects such as ↵sanjeevr@chromium.org2011-03-311-2/+5
| | | | | | | | | | jingle. BUG=None TEST=Build. Review URL: http://codereview.chromium.org/6778025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80033 0039d316-1c4b-4281-b951-d872f2087c98
* Move some files from base to base/memory.levin@chromium.org2011-03-281-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | raw_scoped_refptr_mismatch_checker.h ref_counted.cc ref_counted.h ref_counted_memory.cc ref_counted_memory.h ref_counted_unittest.cc scoped_callback_factory.h scoped_comptr_win.h scoped_handle.h scoped_native_library.cc scoped_native_library.h scoped_native_library_unittest.cc scoped_nsobject.h scoped_open_process.h scoped_ptr.h scoped_ptr_unittest.cc scoped_temp_dir.cc scoped_temp_dir.h scoped_temp_dir_unittest.cc scoped_vector.h singleton.h singleton_objc.h singleton_unittest.cc linked_ptr.h linked_ptr_unittest.cc weak_ptr.cc weak_ptr.h weak_ptr_unittest.cc BUG=None TEST=Compile Review URL: http://codereview.chromium.org/6714032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79524 0039d316-1c4b-4281-b951-d872f2087c98
* Reverted 76780 -- Adding Save Page downloads to downloads history.rdsmith@chromium.org2011-03-231-7/+0
| | | | | | | | | | | This fixes issue 76963, in which a tab closure while a page is being saved results in a crash. See that issue for details. BUG=76963 TEST=Relevant tests pass, can't repro 76963. Review URL: http://codereview.chromium.org/6708075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79180 0039d316-1c4b-4281-b951-d872f2087c98
* Add files saved using 'Save page as' to the download history.rdsmith@chromium.org2011-03-031-0/+7
| | | | | | | | | | | | | Contributed by fuzzac@gmail.com. BUG=4823 TEST=Open any web page. Save the page using 'Save page as'. Make sure the file is listed in the downloads page. Review URL: http://codereview.chromium.org/6312027 Patch from Magnus Danielsson <fuzzac@gmail.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76780 0039d316-1c4b-4281-b951-d872f2087c98
* Update more includes that were pointing to the old locations.jam@chromium.org2011-03-021-1/+1
| | | | | | | TBR=avi Review URL: http://codereview.chromium.org/6598086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76512 0039d316-1c4b-4281-b951-d872f2087c98
* Make TabContentsObserver handle registration automatically, as well as ↵jam@chromium.org2011-02-171-2/+0
| | | | | | | | exposing getters for TC, routing_id, and sending messages. Review URL: http://codereview.chromium.org/6537004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75226 0039d316-1c4b-4281-b951-d872f2087c98
* Clamp posix file names to NAME_MAX.thestig@chromium.org2011-02-111-0/+12
| | | | | | | | | | | | | Note: This is one out of two patches that together will fix sub-frame exporting during 'save page as'. The other one is here: https://bugs.webkit.org/show_bug.cgi?id=53897 Patch from Magnus Danielsson <fuzzac@gmail.com> Original CL: http://codereview.chromium.org/6286140/ BUG=25303 TEST=Open www.cnn.com and click 'save page as'. Check the log to make sure no files failed to save due to too long file names. Review URL: http://codereview.chromium.org/6474018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74684 0039d316-1c4b-4281-b951-d872f2087c98
* Carnitas: move browser/shell_dialogs.{h,cc} to browser/uiestade@chromium.org2011-02-111-1/+1
| | | | | | | | | BUG=none TEST=compile Review URL: http://codereview.chromium.org/6485017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74658 0039d316-1c4b-4281-b951-d872f2087c98
* Rename WebNavigationObserver to TabContentsObserver.jam@chromium.org2011-01-281-3/+3
| | | | | | Review URL: http://codereview.chromium.org/6404001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72916 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of a few more interfaces from RenderViewHostDelegate that aren't needed.jam@chromium.org2011-01-251-18/+14
| | | | | | Review URL: http://codereview.chromium.org/6374009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72522 0039d316-1c4b-4281-b951-d872f2087c98
* net: Remove typedef net::URLRequest URLRequest;tfarina@chromium.org2010-11-301-1/+1
| | | | | | | | | BUG=64263 TEST=compiled locally, trybots Review URL: http://codereview.chromium.org/5384002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67762 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid disk IO in SavePackage on the UI thread. Also cleaned up the code a bit.jam@chromium.org2010-11-051-7/+10
| | | | | | | BUG=61775 Review URL: http://codereview.chromium.org/4478002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65249 0039d316-1c4b-4281-b951-d872f2087c98
* Fix suggested save file name for title-less pages.estade@chromium.org2010-08-131-4/+9
| | | | | | | | | | | regressed in r48691 BUG=51963 TEST=TODO Review URL: http://codereview.chromium.org/3150012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56091 0039d316-1c4b-4281-b951-d872f2087c98
* `#pragma once` for app, base, chrome, gfx, ipc, net, skia, viewsthakis@chromium.org2010-07-261-0/+1
| | | | | | | | | BUG=50273 TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux TBR: erg git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
* Download code cleanup:phajdan.jr@chromium.org2010-07-141-28/+1
| | | | | | | | | | | | | | | - convert some private static members to anonymous functions - move some methods from public to private This should make the interface of some download classes smaller, and hopefully easier to understand. BUG=48913 TEST=unit_tests, browser_tests, ui_tests Review URL: http://codereview.chromium.org/2974007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52327 0039d316-1c4b-4281-b951-d872f2087c98
* Fix save complete web page crasherestade@chromium.org2010-04-261-9/+9
| | | | | | | | | | | | | Repeatedly saving a page may cause a crash. See the bug for a full discussion. This fixes that by making sure the curretn SavePackage is the same one that called into SaveFileManager::RenameAllFiles. One more hack on the giant, teetering pile of hacks that is the SavePackage system. Can't hurt, right? BUG=42454 TEST=see bug Review URL: http://codereview.chromium.org/1729016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45599 0039d316-1c4b-4281-b951-d872f2087c98
* Browser and unit test cases for patch submitted for Issue 23584 undertony@chromium.org2010-04-081-1/+6
| | | | | | | | | | | | | | http://codereview.chromium.org/660264. BUG=23584 TEST=covered by unit tests and browser tests Original patch by Chamal De Silva <chamal.desilva@gmail.com> at http://codereview.chromium.org/669262/show Review URL: http://codereview.chromium.org/1562017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43934 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes Issue 34722: Meaningless value in 'Save as type' combobox of 'Save ↵georgey@chromium.org2010-02-231-2/+13
| | | | | | | | | | | | page as...' dialog Adds extension base don MIME type of the page. Adds capability of the complete save of the "application/xhtml+xml" pages BUG=34722 TEST=In the bug + try pages with other MIME types, such as "text/xml", "text/plain" or "text/css" Review URL: http://codereview.chromium.org/650176 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39804 0039d316-1c4b-4281-b951-d872f2087c98
* Support dragging a virtual file out of the browser.jianli@chromium.org2010-01-151-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/351029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36378 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Revert r31175 r31176 r31187"hclam@chromium.org2009-11-061-2/+4
| | | | | | | | | | | | The bustage seems to be a WebKit change upstream. It is not reverted in WebKit and merger. So bring the innocent change back in. TBR=jam TEST=green tree Review URL: http://codereview.chromium.org/375009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31214 0039d316-1c4b-4281-b951-d872f2087c98
* Rever r31175 r31176 r31187hclam@chromium.org2009-11-061-4/+2
| | | | | | | | | | | XP tests are failing, the guess is r31175 and r31176. TBR=beng TEST=XP tests go green Review URL: http://codereview.chromium.org/376008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31201 0039d316-1c4b-4281-b951-d872f2087c98
* Sixth patch in making destructors of refcounted objects private.jam@chromium.org2009-11-061-2/+4
| | | | | | | | BUG=26749 Review URL: http://codereview.chromium.org/370001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31176 0039d316-1c4b-4281-b951-d872f2087c98
* Move initialization of ChromeURLRequestContexts to the IO thread.eroman@chromium.org2009-10-231-2/+2
| | | | | | | | | | | | | | | | | | | | | | | Before, these URLRequestContexts were lazily created from the UI thread. Unfortunately that model made it easy for consumers on the UI thread to poke at stuff which was being used from the IO thread, and introduce races. So instead of providing a URLRequestContext*, the Profile now vends a URLRequestContextGetter*. The consequence of this is: * Consumers on the UI thread can no longer get access to a URLRequestContext. * Consumers on the IO thread need to call URLRequestContextGetter::GetURLRequestContext() to get at the context. This uses the same style lazy-creation of URLRequestContexts, albeit from the IO thread. OK, so now the smelly part: There were a couple of consumers of URLRequestContext on the UI thread that can't easily be moved to the IO thread -- these are the consumers of the cookie store. Before they could happily mess with the cookie store from the UI thread, and this was fine since CookieStore is threadsafe. However under the new model, they have no way to get at the URLRequestContext from the UI thread, hence can't get a pointer to the cookie store. To support that use-cases, I bastardized the API some by adding a URLRequestContextGetter::GetCookieStore() method that lets UI thread consumers get a pointer to the cookie store, since we know this particular cross-thread usage is safe. BUG=http://crbug.com/22294 Review URL: http://codereview.chromium.org/258008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29880 0039d316-1c4b-4281-b951-d872f2087c98
* Make on-demand download directory creation safe.estade@chromium.org2009-10-091-0/+3
| | | | | | | | | | | If the SavePackage or SaveFileManager went down at the wrong time (most likely during shutdown), we potentially could have crashed. Avoid this race by using a specialized Task instaed of SaveFileManager, and by making the SavePackage callback task scoped. BUG=none TEST=downloads still work, whether or not the downloads dir exists. Review URL: http://codereview.chromium.org/262019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28511 0039d316-1c4b-4281-b951-d872f2087c98
* Create the download folder if it doesn't exist. That is, the actual download ↵thestig@chromium.org2009-09-251-0/+4
| | | | | | | | | | folder, not the default one. BUG=21759 TEST=none Review URL: http://codereview.chromium.org/219017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27266 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Add a SavePackageType, SAVE_TYPE_UNKNOWN, which represents the ↵jhawkins@chromium.org2009-09-231-1/+3
| | | | | | | | | | | state of the save type before the user has selected a save type. Initialize save_type_ to this value in the constructor. CID=3809 BUG=none TEST=none Review URL: http://codereview.chromium.org/220016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26983 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure proper paths when saving pages with no title.paul@chromium.org2009-07-101-4/+7
| | | | | | | | | | | | | | | | | | | When saving a page with no title, such as a text file, attempt to use a sane value for the save name by retrieving the last component of the URL (if one exists). This prevents the case where a page http://www.foo.com/a/path/name.txt is saved as file "http www" with extension type "foo.com a path name.txt". This change also makes the SavePackage code a little more flexible and simpler to test. BUG=none TEST=Covered by unittest. Review URL: http://codereview.chromium.org/155266 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20432 0039d316-1c4b-4281-b951-d872f2087c98
* Do some refactoring of renderer_host.brettw@chromium.org2009-07-061-0/+1
| | | | | | | | | | | | | | | | | | | This removes the last dependency on tab_contents from the renderer_host code and into the RenderViewHostDelegate. Some of the tests depended on tab_contents, so I moved to a new directory with the tab_contents include allowed via DEPS. Now DEPS can enforce that no additional tab_contents includes are added to renderer_host. RenderViewHost delegate is now pure virtual. After spending a while *again* figuring out why my code didn't work, only to find it was because the default implementation of a function was getting called instead of the real one, I decided to make this pure virtual. It is implemented by TabContents, which implements basically everything, and two other places that implement less. Only two lists of duplicate functions seems not too bad, although long-term it would be nice if this delegate was somehow more succinct. Review URL: http://codereview.chromium.org/155071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19982 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce header dependencies in chrome/browser/phajdan.jr@chromium.org2009-06-161-5/+2
| | | | | | | | In my scan of headers I got up to browser/gtk/ Review URL: http://codereview.chromium.org/126131 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18500 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure proper extension when saving an HTML page.estade@chromium.org2009-05-191-6/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | When an HTML page has a title, it is used as the suggested file name in saving the page. Then the file extension is guessed from the suggested file name. This results in a wrong extension if the title contains a period ".". This the source of Bug 10581. Merely setting ignore_suggested_ext to true in win_util::SaveFileAsWithFilter is not a good fix, because then we have an issue in saving a page without a title, where the extension can be correctly derived from the suggested file name. This change solves the issue by appending ".htm" to the suggested file name if the page content type is HTML and the suggested file name doesn't have a proper extension. BUG=10581 -------- patch by yuzo@google.com review here: <http://codereview.chromium.org/115235> git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16355 0039d316-1c4b-4281-b951-d872f2087c98
* Replace all occurrances of WebContents with TabContents.brettw@chromium.org2009-05-041-5/+5
| | | | | | Review URL: http://codereview.chromium.org/99177 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15194 0039d316-1c4b-4281-b951-d872f2087c98
* Add a Cocoa file picker.avi@google.com2009-04-141-7/+1
| | | | | | Review URL: http://codereview.chromium.org/73044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13695 0039d316-1c4b-4281-b951-d872f2087c98
* First pass of refactoring dialogs.avi@chromium.org2009-04-061-2/+2
| | | | | | Review URL: http://codereview.chromium.org/60110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13168 0039d316-1c4b-4281-b951-d872f2087c98
* Remove Windows "Save As" dialogs from Save Page code.In this change:- ↵paulg@google.com2009-03-301-23/+31
| | | | | | | | convert SavePackage to use async SelectFileDialog- return the chosen filter index in the FileSelected callback- some clean up of save_package.ccBUG=8691 (http://crbug.com/8691) Review URL: http://codereview.chromium.org/45048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12799 0039d316-1c4b-4281-b951-d872f2087c98
* Removed unneeded includes of base/time.h.thestig@chromium.org2009-03-161-1/+0
| | | | | | Review URL: http://codereview.chromium.org/48019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11766 0039d316-1c4b-4281-b951-d872f2087c98
* NO CODE CHANGEdeanm@chromium.org2009-03-101-1/+0
| | | | | | | | | Normalize end of file newlines in chrome/. All files end in a single newline. Review URL: http://codereview.chromium.org/42015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11331 0039d316-1c4b-4281-b951-d872f2087c98
* Port save_package_unittest to posix.estade@chromium.org2009-02-201-2/+2
| | | | | | Review URL: http://codereview.chromium.org/20514 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10070 0039d316-1c4b-4281-b951-d872f2087c98
* Bring up save_package, save_item, save_file_manager on posix.estade@chromium.org2009-02-191-4/+4
| | | | | | Review URL: http://codereview.chromium.org/20479 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9999 0039d316-1c4b-4281-b951-d872f2087c98
* Change url wstrings to GURLSestade@chromium.org2009-02-121-3/+3
| | | | | | Review URL: http://codereview.chromium.org/20273 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9635 0039d316-1c4b-4281-b951-d872f2087c98
* Port some strings in download/save_package.ccestade@chromium.org2009-02-111-36/+24
| | | | | | Review URL: http://codereview.chromium.org/23004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9547 0039d316-1c4b-4281-b951-d872f2087c98
* Move files out of browser and into either renderer_host or tab_contents.brettw@chromium.org2009-01-221-1/+1
| | | | | | | This also fixes a crash in the web contents unit test in a commented-out test and re-enable it. Review URL: http://codereview.chromium.org/18504 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8470 0039d316-1c4b-4281-b951-d872f2087c98
* Add a UI test to make sure we sanitize the filenametc@google.com2009-01-071-0/+4
| | | | | | | | | | | of files saved using the "Save page as..." menu item. This involves adding a new automation provider method for disabling the dialog prompting for a filename. Review URL: http://codereview.chromium.org/16555 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7683 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent files saved via the "Save as..." page menu item fromtc@google.com2009-01-061-1/+3
| | | | | | | | | | | | | | | | | being named maliciously. This is mainly copying some code from the download manager because it seems like a pretty large task to refactor the save-as code right now. Here's a demo page: http://ponderer.org/tests/title-with-.exe.html Clean up the naming convention of register prefs for the safe browsing service to make it more like the other register methods. Review URL: http://codereview.chromium.org/16523 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7595 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-02 17:06:18 +0000