summaryrefslogtreecommitdiffstats
path: root/chrome/browser/download
Commit message (Collapse)AuthorAgeFilesLines
* Adds the ability for save dialogs to take a default extension.sky@google.com2008-11-121-0/+1
| | | | | | | | | BUG=4287 TEST=see bug Review URL: http://codereview.chromium.org/10621 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5304 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug where carpet bombing dialog would come in some situations itsky@google.com2008-11-111-10/+20
| | | | | | | | | | | | should not have. BUG=4136 TEST=see bug for details, along with 4220. You should also verify that carpet bombing dialog comes up when it should. Review URL: http://codereview.chromium.org/10270 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5148 0039d316-1c4b-4281-b951-d872f2087c98
* A crasher would happen if you donwload an exe and the download has completed ↵jcampan@chromium.org2008-11-071-1/+2
| | | | | | | | | | | | | by the time the download item is created, you have the download tab opened and you press on the discard button. This is because such downloads gets added to a vector that is used to unregister the DownloadTabView as an observer. We were deleting the download item before notifying the DownloadTabView, which would cause it to access the deleted download item. BUG=4134 TEST=Open the download tab, start the download of a short exe. Click the discard button in the dangerous download prompt. Review URL: http://codereview.chromium.org/9435 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4940 0039d316-1c4b-4281-b951-d872f2087c98
* Tell the user that HTML documents can harm their computer because they can. abarth@chromium.org2008-11-052-3/+10
| | | | | | | | | | | This patch blocks all the extensions that we register. R=nsylvain BUG=1463961 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4769 0039d316-1c4b-4281-b951-d872f2087c98
* Rewrote the clipboard API to be more concurrent. Added a helper class to ↵estade@chromium.org2008-11-051-8/+5
| | | | | | | | make it more foolproof. Updated all clients and unittests. Mac port by jeremy@chromium.org Review URL: http://codereview.chromium.org/9154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4719 0039d316-1c4b-4281-b951-d872f2087c98
* Rolling backabarth@chromium.org2008-11-041-8/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4604 0039d316-1c4b-4281-b951-d872f2087c98
* Tell the user that HTML documents can harm their computer because they can. abarth@chromium.org2008-11-041-1/+8
| | | | | | | | | | | This patch blocks all the extensions that we register. R=nsylvain BUG=1463961 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4603 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug where languages that have a long string for thepaulg@google.com2008-10-312-2/+28
| | | | | | | | | | | | | | | | dangerous download warning cause an overlap with the label for that download's URL. We now use a locale-specific pixel value which changes the height of each download's view on the download page so that this overlap no longer happens. BUG=3824 (http://code.google.com/p/chromium/issues/detail?id=3824) Review URL: http://codereview.chromium.org/8933 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4323 0039d316-1c4b-4281-b951-d872f2087c98
* Background:nsylvain@chromium.org2008-10-311-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | 1. We can tell chrome to "always open this type of file" when downloading. This is disabled for executable for security reasons. 2. When downloading an executable files we download a .download instead. -=-= The problem is that the "always open this type of file" is enabled for executables during the download because we check the extension of the file to know if it's an executable or not, and during download we see .download, and we don't consider it an executable. The fix is to look at the "original_name" when it's present to get the extension of the real file, not the .download. BUG:3814 Review URL: http://codereview.chromium.org/8918 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4306 0039d316-1c4b-4281-b951-d872f2087c98
* Begin the first small step towards using FilePath everywhere:evanm@google.com2008-10-302-5/+6
| | | | | | | | | | - Add some transition APIs. - Start migrating some code to transition APIs. Review URL: http://codereview.chromium.org/8825 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4254 0039d316-1c4b-4281-b951-d872f2087c98
* Remove downloads from the completed dangerous downloads listpaulg@google.com2008-10-301-0/+6
| | | | | | | | | | | | | | | | when they are deleted via "Clear browsing data". There was definite crash a shutdown, and sporadic crashes when idling (but after a dangerous download was complete but not yet confirmed) after a user cleared their browsing data, since the dangerous list kept around a pointer to a download that had been deleted elsewhere. BUG=3498 (http://code.google.com/p/chromium/issues/detail?id=3498) Review URL: http://codereview.chromium.org/8728 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4200 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for Save Page downloads not notifying their observers on completion.glen@chromium.org2008-10-291-0/+1
| | | | | | | | BUG=3417 Review URL: http://codereview.chromium.org/8804 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4177 0039d316-1c4b-4281-b951-d872f2087c98
* Do not localize the name of 'download' directory. Chrome's UI languages can bejungshik@google.com2008-10-282-6/+5
| | | | | | | | | | | | | | | | | | | changed and a user will be confused as to where her download goes. Add DIR_DEFAULT_DOWNLOADS to chrome_paths (which is set to 'Downloads' under DIR_USER_DOCUMENTS) and use that in both save_package and download_manager. This patch does not offer a migration path. BUG=3097 TEST=Switch Chrome's UI to non-English and download a file. The file should be downloaded to '..\My Documents\Downloads' rather than '..\My Documents\<'Downloads' in that language>. Review URL: http://codereview.chromium.org/7945 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4049 0039d316-1c4b-4281-b951-d872f2087c98
* Plumb the referrer throughout the OpenURL APIs.ericroman@google.com2008-10-271-4/+5
| | | | | | | | | | | | | http://code.google.com/p/chromium/issues/detail?id=3224 Caveats: * Did not update TabNavigation yet. Hence session restore will continue to load the tabs with empty referrer. * Did not plumb referrer into incognito url open. (Not sure what the right thing to do is here with respect to privacy vs compatibility.) * Did not plumb referrer throughout the automation controller. No functional impact here, but it makes the code inconsistent with the non-automation version. Review URL: http://codereview.chromium.org/8186 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4036 0039d316-1c4b-4281-b951-d872f2087c98
* Move Time, TimeDelta and TimeTicks into namespace base.dsh@google.com2008-10-276-11/+19
| | | | | | Review URL: http://codereview.chromium.org/7995 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4022 0039d316-1c4b-4281-b951-d872f2087c98
* We were still warning about a dangerous download when the user has picked ↵jcampan@chromium.org2008-10-171-2/+8
| | | | | | | | | | the option to always ask for download. BUG=3539 TEST=Select the option "always ask for download". Download an exe. You should not see a dangerous download warning. Review URL: http://codereview.chromium.org/7634 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3570 0039d316-1c4b-4281-b951-d872f2087c98
* Adds the anti-carpet bombing dialog. More specifically a newsky@google.com2008-10-173-0/+812
| | | | | | | | | | | | | | | | | EventHandler now exists between the buffered event handler and download event handler. This new event handler asks the DownloadRequestManager whether the download is allowed. This may prompt the user and then the download continues or is canceled. The DownloadRequestManager receives the request on the IO thread, forwards to the UI thread, makes the decision, then notifies back on the IO thread. BUG=3422 TEST=make sure you don't see any problems downloading content. Review URL: http://codereview.chromium.org/7479 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3543 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug 3470, where the download tab would show the temporary name for ↵jcampan@chromium.org2008-10-173-21/+64
| | | | | | | | | | | | dangerous downloads (see download_tab_view.cc). Also fixes bug 3471, where if the same file is downloaded again while the first one is not finished, they would get the same name. For dangerous downloads, we now uniquify the path on download start (so the UI shows a file name most likely to be the final name), and on download complete (so if there 2 simultaneous downloads of the same file the last one does not overwrite the first). BUG=3470, 3471 TEST=see bugs Review URL: http://codereview.chromium.org/7395 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3536 0039d316-1c4b-4281-b951-d872f2087c98
* Rename ChromeViews namespace to viewsben@chromium.org2008-10-162-4/+4
| | | | | | http://crbug.com/2188 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3495 0039d316-1c4b-4281-b951-d872f2087c98
* Change the prefix for unconfirmed, potentially dangerous downloads mal@chromium.org2008-10-161-1/+1
| | | | | | | | | | | | | | | | | from: dangerous_download_%d to: unconfirmed %d We want to avoid alarming names in the UI. I'm open to better suggestions for the prefix. R= jcampan@chromium.org, brian@chromium.org Review URL: http://codereview.chromium.org/7107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3455 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crasher when shutting down with a pending dangerous download.jcampan@chromium.org2008-10-151-2/+4
| | | | | | | | BUG=3457 TEST=See bug Review URL: http://codereview.chromium.org/7406 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3396 0039d316-1c4b-4281-b951-d872f2087c98
* This CL adds prompting for dangerous types of files (executable) when they ↵jcampan@chromium.org2008-10-107-45/+304
| | | | | | | | | | | | | | | | are automatically downloaded. The file is saved with a temporary name (dangerous_download_xxxx.download) in the download directory and the user is presented (in the download shelf and the download tab if opened) with a warning message and buttons to save/discard the download. If discarded the download is removed (and its file deleted). If saved, download goes as usual. Dangerous downloads not confirmed by the user are deleted on shutdown. TEST=Download a small exe file, try using the save/discard button from the download shelf and from the download tab (the intent is that the file has been entirely downloaded by the time you take action). Try again with a slow/big download (that time the download is expected not to be finished when approved/discarded). Review URL: http://codereview.chromium.org/6043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3228 0039d316-1c4b-4281-b951-d872f2087c98
* Port some more of chrome/ to Linux.deanm@google.com2008-10-023-17/+22
| | | | | | | | Original review: http://codereview.chromium.org/4247 Patch from Pawel Hajdan Jr. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2793 0039d316-1c4b-4281-b951-d872f2087c98
* Cross-platform wrappers for fopen, _wfopen_s, etc.mark@chromium.org2008-10-012-7/+7
| | | | | | | | | Patch by Paweł Hajdan jr <phajdan.jr@gmail.com>. http://codereview.chromium.org/6005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2760 0039d316-1c4b-4281-b951-d872f2087c98
* Move a bunch of stuff out of WebContents. I removed a bunch of render view ↵brettw@google.com2008-09-253-41/+47
| | | | | | | | | host pass-throughs and just made the callers call the render view host directly. I don't think we're trying to isolate the layers to this degree, and WebContents is so big these just added noise. I removed the RenderViewHost->WebContents->SavePackage pass-through by using a delegate that the SavePackage implements (like we already do for find in page). I also noticed some file upload stuff wasn't used at all and removed it. Review URL: http://codereview.chromium.org/4088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2612 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes two crashers in saving page:sky@google.com2008-09-163-15/+18
| | | | | | | | | | | | | | | 1. GetTabID was being called AFTER the process was destroyed, which means we could try and deref NULL. By caching the value we don't have to worry about whether the web contents goes away or not. 2. A PostTask was done, then we assumed the SaveItem still exists. That isn't the case if the user canceled the save. BUG=2206 TEST=none, just make sure save page as still works correctly. Review URL: http://codereview.chromium.org/3034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2261 0039d316-1c4b-4281-b951-d872f2087c98
* Move the Save Page code to the browser/download/ directory.paulg@google.com2008-09-1413-0/+3083
| | | | | | Review URL: http://codereview.chromium.org/3040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2174 0039d316-1c4b-4281-b951-d872f2087c98
* Move the download code to new directories:paulg@google.com2008-09-1311-0/+3860
browser/download/ browser/views/ Review URL: http://codereview.chromium.org/2826 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2166 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-18 23:50:18 +0000