summaryrefslogtreecommitdiffstats
path: root/chrome/browser/download
Commit message (Collapse)AuthorAgeFilesLines
* Argh, reverting the change to remove the "crx" file extensionaa@chromium.org2009-08-131-3/+17
| | | | | | | | | | | | | | | | | | hack in DownloadManager. For those playing along at home, this change makes it so that we once again consider any file that ends in ".crx" an extension. The problem is that file:// URLs are not-sniffable, so with this change we cannot install extensions from file:// URLs. We need to fix things so that we consider file associations for local files, I guess. TBR=mpcomplete@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23362 0039d316-1c4b-4281-b951-d872f2087c98
* Refactors OSExchangeData for easier portability.sky@chromium.org2009-08-121-6/+8
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/164401 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23230 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the temporary hack that considered any file that endedaa@chromium.org2009-08-111-17/+3
| | | | | | | | | | | in ".crx" a Chrome extension now that all the relevant servers are fixed. BUG=13296 Review URL: http://codereview.chromium.org/164344 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23118 0039d316-1c4b-4281-b951-d872f2087c98
* Add "dangerous download" view on OS X, for now for dmg files. Also fix ↵thakis@chromium.org2009-08-112-14/+6
| | | | | | | | | | | download item layout. BUG=14667,17831 TEST=Download a dmg file. Make sure the "dangerous download" view appears. Check that both buttons work, and that the dmg filename is elided correctly. Also test that "Remove" on a normal download item's context menu relayouts the remaining items on the shelf. Review URL: http://codereview.chromium.org/165295 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23103 0039d316-1c4b-4281-b951-d872f2087c98
* Commit patch for Pierre-Antoine LaFayette, original CL:paul@chromium.org2009-08-111-3/+16
| | | | | | | | | | | | | | | | | http://codereview.chromium.org/164119 Items in the Downloads page should be loaded like a normal OS file when dragged to a Tab content area. We need the URL to be set to the file path in the IDataObject so that WebDropData can properly handle the file. BUG=9266 TEST=Drag an item with a supported MIME type from the Downloads page to a Tab content area. It should load within the browser. Drag an item with an unsupported MIME type and it should not open it. Review URL: http://codereview.chromium.org/165260 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22983 0039d316-1c4b-4281-b951-d872f2087c98
* Change "Cancelled" to "Canceled". Original patch by Thiago Farina (see ↵pkasting@chromium.org2009-08-101-2/+2
| | | | | | | | | http://codereview.chromium.org/165097 ), r=me. BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22933 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the size of a cancelled download in the download shelf.paul@chromium.org2009-08-061-2/+1
| | | | | | | | | | | | | Patch created by Thiago Farina, original CL: http://codereview.chromium.org/160465 BUG=17180 (http://crbug.com/17180) TEST=Download some file, then cancel it and notice the shelf UI does not any longer display the size of download. Review URL: http://codereview.chromium.org/165073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22666 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug where a download isn't canceled when the user requests it.paul@chromium.org2009-08-052-7/+21
| | | | | | | | | | | | | | | This particular bug only occurs when the user is prompted via save file dialog and then chooses cancel. In this case, the file selection code path for canceling was not the same as regular cancel case, so the network requests continued. BUG=18160 TEST=When prompted to save a download, choose cancel and notice that there is no further network traffic due to that download. Review URL: http://codereview.chromium.org/160627 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22557 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up SavePage UI test, remove dead code.phajdan.jr@chromium.org2009-08-051-21/+2
| | | | | | | | | | | As most of the tests moved to the browser test, this is now unneeded. TEST=none BUG=none Review URL: http://codereview.chromium.org/160666 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22511 0039d316-1c4b-4281-b951-d872f2087c98
* Port more tests from save_page_uitest.cc to save_page_browsertest.cc.phajdan.jr@chromium.org2009-08-042-53/+58
| | | | | | | | | | | Also add more detailed checks for saved page contents. TEST=Covered by browser_tests. http://crbug.com/3791 Review URL: http://codereview.chromium.org/159858 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22413 0039d316-1c4b-4281-b951-d872f2087c98
* Include Pause/Resume in the context menu for the item in the download shelf.mhm@chromium.org2009-08-042-0/+16
| | | | | | | | | | | | | The pause and resume context item will only appear when the download is in progress. It will not show on the context menu if the download has been cancelled or completed. It is a toggle state, either pause or resume, not both. BUG=16929 (http://www.crbug.com/16929) TEST=Download a large file, right click pause, then resume. As well, download a small file, wait till finishes, right click, you will see no pause/resume. Review URL: http://codereview.chromium.org/159844 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22406 0039d316-1c4b-4281-b951-d872f2087c98
* Allow cancellable download items to be removable from download shelf.mhm@chromium.org2009-08-031-1/+2
| | | | | | | | BUG=18235 (http://crbug.com/18235) TEST=Cancel a big download and remove it. Review URL: http://codereview.chromium.org/159769 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22276 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 22273.mhm@chromium.org2009-08-031-4/+1
| | | | | | Review URL: http://codereview.chromium.org/160524 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22274 0039d316-1c4b-4281-b951-d872f2087c98
* Allow cancellable download items to be removable from download shelf.mhm@chromium.org2009-08-031-1/+4
| | | | | | | | BUG=18235 (http://crbug.com/18235) TEST=Cancel a big download and remove it. Review URL: http://codereview.chromium.org/159769 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22273 0039d316-1c4b-4281-b951-d872f2087c98
* Try again to land: http://codereview.chromium.org/160483aa@chromium.org2009-08-011-3/+12
| | | | | | | | | | | | | | | | | | Ever closer. Extract a client interface out of CrxInstaller and use it to implement ExtensionInstallUI. There is (still) no dialog here. But the next CL will, um, definitely have it. Also, fixed the issue with theme preview infobars not updating if you install a theme while another one is already previewed. TBR=mpcomplete@chromium.org BUG=17932 Review URL: http://codereview.chromium.org/160501 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22244 0039d316-1c4b-4281-b951-d872f2087c98
* Rollback 22228aa@chromium.org2009-08-011-12/+3
| | | | | | TBR=mpcomplete@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22231 0039d316-1c4b-4281-b951-d872f2087c98
* Ever closer. Extract a client interface out of CrxInstaller andaa@chromium.org2009-07-311-3/+12
| | | | | | | | | | | | | | | use it to implement ExtensionInstallUI. There is (still) no dialog here. But the next CL will, um, definitely have it. Also, fixed the issue with theme preview infobars not updating if you install a theme while another one is already previewed. BUG=17932 Review URL: http://codereview.chromium.org/160483 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22228 0039d316-1c4b-4281-b951-d872f2087c98
* Convert parts of SavePage UI tests to more reliable browser tests.phajdan.jr@chromium.org2009-07-313-50/+126
| | | | | | | | | | | Use a real notification for download completion - that's the main unflakying point. TEST=none http://crbug.com/3791 Review URL: http://codereview.chromium.org/160480 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22212 0039d316-1c4b-4281-b951-d872f2087c98
* Add "Remove from list" for download item in the download shelf.mhm@chromium.org2009-07-312-4/+12
| | | | | | | | | | This would remove the download list (CTRL+J) as well. BUG=60 (http://crbug.com/60) TEST=Download a file from the net, download shelf appears, click the download item's arrow and "Remove from list". The item removes from the shelf and list. Review URL: http://codereview.chromium.org/155749 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22143 0039d316-1c4b-4281-b951-d872f2087c98
* Remove duplication of DieFileDie, and move it to proper location.phajdan.jr@chromium.org2009-07-301-7/+8
| | | | | | | | | TEST=none http://crbug.com/18085 Review URL: http://codereview.chromium.org/159658 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22103 0039d316-1c4b-4281-b951-d872f2087c98
* Move mock url request classes to a location when browser tests will be able ↵phajdan.jr@chromium.org2009-07-302-3/+3
| | | | | | | | | | | to use them too. TEST=none BUG=none Review URL: http://codereview.chromium.org/160366 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22056 0039d316-1c4b-4281-b951-d872f2087c98
* Make the DownloadRequestDialogDelegateGtk always report some response to the ↵estade@chromium.org2009-07-291-6/+0
| | | | | | | | | | | | download request manager. We weren't reporting Cancel on page navigation, which meant the download request manager had a stale pointer that it later tried to dereference. BUG=18021 Review URL: http://codereview.chromium.org/160361 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22011 0039d316-1c4b-4281-b951-d872f2087c98
* Implement the "This site is attempting to downloadthakis@chromium.org2009-07-292-8/+0
| | | | | | | | | | | multiple files. Do you want to allow this?" dialog on linux. BUG=12757 TEST=Download several files from the same domain. After the first download, you should be prompted for every additional file you want to download from that domain (try for example http://amnoid.de/ddsview/download.html , click on the "download" link twice). Review URL: http://codereview.chromium.org/159528 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21966 0039d316-1c4b-4281-b951-d872f2087c98
* Fix exception in DownloadManager if the download has no extension.aa@chromium.org2009-07-261-1/+2
| | | | | | | TBR=erikkay Review URL: http://codereview.chromium.org/159392 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21628 0039d316-1c4b-4281-b951-d872f2087c98
* Modify detection of Chrome extensions in download manager. Itaa@chromium.org2009-07-261-3/+17
| | | | | | | | | | | | | | turns out many servers send the no-sniff option, including the one we use for our sample extensions. So we can't rely on mime types to detect Chrome extensions, at least until we have some place to put our samples that doesn't have this problem. TBR=erikkay Review URL: http://codereview.chromium.org/159391 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21627 0039d316-1c4b-4281-b951-d872f2087c98
* Try again to commit r21622: Add infobar preview for themes,aa@chromium.org2009-07-261-2/+4
| | | | | | | | remove --enable-extension requirement. Review URL: http://codereview.chromium.org/159390 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21626 0039d316-1c4b-4281-b951-d872f2087c98
* Revert revisions 21622-21624.aa@chromium.org2009-07-261-4/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21625 0039d316-1c4b-4281-b951-d872f2087c98
* Add infobar preview for themes, remove --enable-extensionaa@chromium.org2009-07-261-2/+4
| | | | | | | requirement. Review URL: http://codereview.chromium.org/160141 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21622 0039d316-1c4b-4281-b951-d872f2087c98
* Make the download manager display a scary file warning if anaa@chromium.org2009-07-251-2/+10
| | | | | | | extensions is not from the gallery. Review URL: http://codereview.chromium.org/159379 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21620 0039d316-1c4b-4281-b951-d872f2087c98
* Implement mimetype sniffing for extensions.aa@chromium.org2009-07-253-3/+13
| | | | | | | | | | | abarth: can you review the changes to mime_sniffer.cc? paul: everything else? BUG=13296 TEST=Added unit tests Review URL: http://codereview.chromium.org/159345 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21612 0039d316-1c4b-4281-b951-d872f2087c98
* Use referrer_url instead of download url to decide whether aaa@chromium.org2009-07-253-6/+18
| | | | | | | theme installation can happens sans-prompt. Review URL: http://codereview.chromium.org/160087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21603 0039d316-1c4b-4281-b951-d872f2087c98
* Nasty short-term hack to special case display of dialogaa@chromium.org2009-07-222-5/+6
| | | | | | | | | | | | | | | on theme installation. It should not be displayed if the theme was installed from our gallery URL. I intend to fix this very soon, but I wanted it to make this coming build, so I did this quick thing for now. Also, I found another bug in ExtensionsService install logic. There was a test, it was ensuring the wrong behavior :(. Review URL: http://codereview.chromium.org/155936 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21321 0039d316-1c4b-4281-b951-d872f2087c98
* Add newline to end of download_manager.ccglen@chromium.org2009-07-151-1/+2
| | | | | | | | | BUG=none TEST=none TBR=sverrir git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20790 0039d316-1c4b-4281-b951-d872f2087c98
* Remove auto-open items from the download shelf on auto-open. This has the ↵glen@chromium.org2009-07-152-19/+22
| | | | | | | | | | | | | delicious side-effect of auto-closing the download shelf after extensions are downloaded and auto installed. While we're here, also add proper colors to the download buttons. BUG=16232 TEST=Install a theme from the web, make sure the download shelf isn't shown after installation. Do the same for a filetype that is set to auto-open. Make sure the shelf stays open for other filetypes. Review URL: http://codereview.chromium.org/149580 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20787 0039d316-1c4b-4281-b951-d872f2087c98
* Fix auto-opening file types not auto-opening.avi@chromium.org2009-07-151-3/+6
| | | | | | | | | BUG=http://crbug.com/16085 TEST=As described in bug Review URL: http://codereview.chromium.org/149692 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20772 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable save page ui tests. I could not get these to fail. I will watch ↵estade@chromium.org2009-07-141-14/+3
| | | | | | | | | | the tree after committing. TBR=evan Review URL: http://codereview.chromium.org/149595 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20670 0039d316-1c4b-4281-b951-d872f2087c98
* Make DownloadShelf a pure interface.estade@chromium.org2009-07-142-28/+2
| | | | | | | | | http://crbug.com/15474 TEST=none Review URL: http://codereview.chromium.org/149594 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20668 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable previously flaky download ui tests. I can't reproduce the ↵estade@chromium.org2009-07-131-21/+5
| | | | | | | | | | failures. Will watch tree after commit. TBR=evan Review URL: http://codereview.chromium.org/155449 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20575 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r20553.thestig@chromium.org2009-07-132-4/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20554 0039d316-1c4b-4281-b951-d872f2087c98
* Additional svn ignores for native_client and Makefile.thestig@chromium.org2009-07-132-0/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20553 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure proper paths when saving pages with no title.paul@chromium.org2009-07-103-35/+100
| | | | | | | | | | | | | | | | | | | When saving a page with no title, such as a text file, attempt to use a sane value for the save name by retrieving the last component of the URL (if one exists). This prevents the case where a page http://www.foo.com/a/path/name.txt is saved as file "http www" with extension type "foo.com a path name.txt". This change also makes the SavePackage code a little more flexible and simpler to test. BUG=none TEST=Covered by unittest. Review URL: http://codereview.chromium.org/155266 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20432 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Themes: Set bg/text colors for the download shelf.erg@google.com2009-07-101-0/+2
| | | | | | | | (This does not change the button image.) Review URL: http://codereview.chromium.org/155365 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20403 0039d316-1c4b-4281-b951-d872f2087c98
* Sprinkle some defensiveness into the UI tests so that they don't explode if ↵stuartmorgan@chromium.org2009-07-072-3/+8
| | | | | | | | | | the proxy doesn't respond (e.g., due to a timeout). BUG=none TEST=Hopefully the Mac valgrind bots will more reliably run all their tests (although there are likely more issues like this lurking). Review URL: http://codereview.chromium.org/149281 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20096 0039d316-1c4b-4281-b951-d872f2087c98
* Move extension install to after .crx download completesrafaelw@chromium.org2009-07-071-4/+1
| | | | | | | | | | | This was resulting in some situations where we attempted to unpack the .crx while its file was still in use by the download manager. BUG=15881 R=mpcomplete Review URL: http://codereview.chromium.org/149161 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20083 0039d316-1c4b-4281-b951-d872f2087c98
* Make default extension for downloading html "html" rather than "htm" on ↵estade@chromium.org2009-07-073-15/+39
| | | | | | | | | | | non-windows platforms. BUG= http://crbug.com/15999 TEST=un-disable and run save page uitest on linux (it's only disabled because it's flaky, for some unrelated reason) Review URL: http://codereview.chromium.org/155095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19997 0039d316-1c4b-4281-b951-d872f2087c98
* Do some refactoring of renderer_host.brettw@chromium.org2009-07-062-1/+2
| | | | | | | | | | | | | | | | | | | This removes the last dependency on tab_contents from the renderer_host code and into the RenderViewHostDelegate. Some of the tests depended on tab_contents, so I moved to a new directory with the tab_contents include allowed via DEPS. Now DEPS can enforce that no additional tab_contents includes are added to renderer_host. RenderViewHost delegate is now pure virtual. After spending a while *again* figuring out why my code didn't work, only to find it was because the default implementation of a function was getting called instead of the real one, I decided to make this pure virtual. It is implemented by TabContents, which implements basically everything, and two other places that implement less. Only two lists of duplicate functions seems not too bad, although long-term it would be nice if this delegate was somehow more succinct. Review URL: http://codereview.chromium.org/155071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19982 0039d316-1c4b-4281-b951-d872f2087c98
* Enable opening downloads from the Mac download shelf.paul@chromium.org2009-07-011-10/+1
| | | | | | | | | | | Also added a stub for an unused method on Canvas in order to link. TEST=Selecting "Open" from the shelf menu will open a download BUG=15661 Review URL: http://codereview.chromium.org/150079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19691 0039d316-1c4b-4281-b951-d872f2087c98
* Enable "Save As" on Mac.paul@chromium.org2009-06-301-5/+0
| | | | | | | | | TEST=Right clicking an image and choosing "Save As" now works. BUG=15638 Review URL: http://codereview.chromium.org/151042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19565 0039d316-1c4b-4281-b951-d872f2087c98
* Allow extension extensions to be case-insensitive.avi@chromium.org2009-06-291-22/+5
| | | | | | | | | BUG=none TEST=try to load an extension with a capital letter or two in the extension's extension. It should load. Review URL: http://codereview.chromium.org/147017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19520 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for reverted cl http://codereview.chromium.org/147123davemoore@chromium.org2009-06-271-0/+1
| | | | | | | | | | | | | A recent change broke the load times. It also revealed some deficiencies. This adds a new time marker for when a load is committed, which is a more interesting value than the start of the load (which we still keep). Also, the first layout time wasn't an interesting time to keep, instead we keep the time of the first paint. The histograms were modified to use the new values when appropriate. Review URL: http://codereview.chromium.org/149099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19465 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-31 21:19:20 +0000