summaryrefslogtreecommitdiffstats
path: root/chrome/browser/download
Commit message (Collapse)AuthorAgeFilesLines
* We were still warning about a dangerous download when the user has picked ↵jcampan@chromium.org2008-10-171-2/+8
| | | | | | | | | | the option to always ask for download. BUG=3539 TEST=Select the option "always ask for download". Download an exe. You should not see a dangerous download warning. Review URL: http://codereview.chromium.org/7634 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3570 0039d316-1c4b-4281-b951-d872f2087c98
* Adds the anti-carpet bombing dialog. More specifically a newsky@google.com2008-10-173-0/+812
| | | | | | | | | | | | | | | | | EventHandler now exists between the buffered event handler and download event handler. This new event handler asks the DownloadRequestManager whether the download is allowed. This may prompt the user and then the download continues or is canceled. The DownloadRequestManager receives the request on the IO thread, forwards to the UI thread, makes the decision, then notifies back on the IO thread. BUG=3422 TEST=make sure you don't see any problems downloading content. Review URL: http://codereview.chromium.org/7479 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3543 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug 3470, where the download tab would show the temporary name for ↵jcampan@chromium.org2008-10-173-21/+64
| | | | | | | | | | | | dangerous downloads (see download_tab_view.cc). Also fixes bug 3471, where if the same file is downloaded again while the first one is not finished, they would get the same name. For dangerous downloads, we now uniquify the path on download start (so the UI shows a file name most likely to be the final name), and on download complete (so if there 2 simultaneous downloads of the same file the last one does not overwrite the first). BUG=3470, 3471 TEST=see bugs Review URL: http://codereview.chromium.org/7395 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3536 0039d316-1c4b-4281-b951-d872f2087c98
* Rename ChromeViews namespace to viewsben@chromium.org2008-10-162-4/+4
| | | | | | http://crbug.com/2188 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3495 0039d316-1c4b-4281-b951-d872f2087c98
* Change the prefix for unconfirmed, potentially dangerous downloads mal@chromium.org2008-10-161-1/+1
| | | | | | | | | | | | | | | | | from: dangerous_download_%d to: unconfirmed %d We want to avoid alarming names in the UI. I'm open to better suggestions for the prefix. R= jcampan@chromium.org, brian@chromium.org Review URL: http://codereview.chromium.org/7107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3455 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crasher when shutting down with a pending dangerous download.jcampan@chromium.org2008-10-151-2/+4
| | | | | | | | BUG=3457 TEST=See bug Review URL: http://codereview.chromium.org/7406 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3396 0039d316-1c4b-4281-b951-d872f2087c98
* This CL adds prompting for dangerous types of files (executable) when they ↵jcampan@chromium.org2008-10-107-45/+304
| | | | | | | | | | | | | | | | are automatically downloaded. The file is saved with a temporary name (dangerous_download_xxxx.download) in the download directory and the user is presented (in the download shelf and the download tab if opened) with a warning message and buttons to save/discard the download. If discarded the download is removed (and its file deleted). If saved, download goes as usual. Dangerous downloads not confirmed by the user are deleted on shutdown. TEST=Download a small exe file, try using the save/discard button from the download shelf and from the download tab (the intent is that the file has been entirely downloaded by the time you take action). Try again with a slow/big download (that time the download is expected not to be finished when approved/discarded). Review URL: http://codereview.chromium.org/6043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3228 0039d316-1c4b-4281-b951-d872f2087c98
* Port some more of chrome/ to Linux.deanm@google.com2008-10-023-17/+22
| | | | | | | | Original review: http://codereview.chromium.org/4247 Patch from Pawel Hajdan Jr. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2793 0039d316-1c4b-4281-b951-d872f2087c98
* Cross-platform wrappers for fopen, _wfopen_s, etc.mark@chromium.org2008-10-012-7/+7
| | | | | | | | | Patch by Paweł Hajdan jr <phajdan.jr@gmail.com>. http://codereview.chromium.org/6005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2760 0039d316-1c4b-4281-b951-d872f2087c98
* Move a bunch of stuff out of WebContents. I removed a bunch of render view ↵brettw@google.com2008-09-253-41/+47
| | | | | | | | | host pass-throughs and just made the callers call the render view host directly. I don't think we're trying to isolate the layers to this degree, and WebContents is so big these just added noise. I removed the RenderViewHost->WebContents->SavePackage pass-through by using a delegate that the SavePackage implements (like we already do for find in page). I also noticed some file upload stuff wasn't used at all and removed it. Review URL: http://codereview.chromium.org/4088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2612 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes two crashers in saving page:sky@google.com2008-09-163-15/+18
| | | | | | | | | | | | | | | 1. GetTabID was being called AFTER the process was destroyed, which means we could try and deref NULL. By caching the value we don't have to worry about whether the web contents goes away or not. 2. A PostTask was done, then we assumed the SaveItem still exists. That isn't the case if the user canceled the save. BUG=2206 TEST=none, just make sure save page as still works correctly. Review URL: http://codereview.chromium.org/3034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2261 0039d316-1c4b-4281-b951-d872f2087c98
* Move the Save Page code to the browser/download/ directory.paulg@google.com2008-09-1413-0/+3083
| | | | | | Review URL: http://codereview.chromium.org/3040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2174 0039d316-1c4b-4281-b951-d872f2087c98
* Move the download code to new directories:paulg@google.com2008-09-1311-0/+3860
browser/download/ browser/views/ Review URL: http://codereview.chromium.org/2826 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2166 0039d316-1c4b-4281-b951-d872f2087c98