summaryrefslogtreecommitdiffstats
path: root/chrome/browser/download
Commit message (Collapse)AuthorAgeFilesLines
* Make sure download shelf items and download items don't share names.mhm@chromium.org2009-10-011-1/+1
| | | | | | | | | BUG=23046 TEST=Compiled and ran on Windows Review URL: http://codereview.chromium.org/242082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27696 0039d316-1c4b-4281-b951-d872f2087c98
* Landing patch from contributor Thiago Farina.finnur@chromium.org2009-09-302-2/+2
| | | | | | | | | | | Update GetDownloadDirectory to take FilePath instead of wstring to avoid conversions "To and From wstring". BUG=None TEST=run ui_tests.exe Review URL: http://codereview.chromium.org/243047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27653 0039d316-1c4b-4281-b951-d872f2087c98
* Add kMDItemWhereFroms metadata attribute to downloaded files. Combine with ↵pinkerton@chromium.org2009-09-291-3/+5
| | | | | | | | | | quarantine utility function and move into chrome/browser/cocoa, since common/ is not the right place for browser code. BUG=22289 TEST=file downloading Review URL: http://codereview.chromium.org/220037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27483 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize all of the member variables in the default constructor.jhawkins@chromium.org2009-09-281-11/+20
| | | | | | | | | CID=1424 BUG=none TEST=none Review URL: http://codereview.chromium.org/245029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27402 0039d316-1c4b-4281-b951-d872f2087c98
* Update the TabContents::SavePage parameter to take FilePath instead of ↵rsesek@chromium.org2009-09-261-6/+3
| | | | | | | | | | | | wstring to avoid conversions "To and From wstring". BUG=None TEST=run unit_tests.exe Review URL: http://codereview.chromium.org/217008 Patch from tfarina. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27331 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the context menu item 'Remove from shelf' from download shelfmhm@chromium.org2009-09-262-12/+0
| | | | | | | | | BUG=23078 TEST=No more menu item on download item Review URL: http://codereview.chromium.org/246004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27312 0039d316-1c4b-4281-b951-d872f2087c98
* Create the download folder if it doesn't exist. That is, the actual download ↵thestig@chromium.org2009-09-254-49/+84
| | | | | | | | | | folder, not the default one. BUG=21759 TEST=none Review URL: http://codereview.chromium.org/219017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27266 0039d316-1c4b-4281-b951-d872f2087c98
* Make extension installation work when the "ask for destinationaa@chromium.org2009-09-251-2/+7
| | | | | | | | | | | of every download" preference is set. BUG=23011 TEST=Set the preference in question, install an extension. You should not get a save as dialog and it should install correctly. Review URL: http://codereview.chromium.org/252005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27262 0039d316-1c4b-4281-b951-d872f2087c98
* linux: port some of the download manager unit testevan@chromium.org2009-09-251-23/+137
| | | | | | | | | | | | Mostly lots of #ifdefs tracking platform behaviors. I tried to make the logic correct for Mac, too, but I didn't enable Mac here. BUG=21632 Review URL: http://codereview.chromium.org/220025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27260 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize file_loop_ and io_loop_ in the constructor.jhawkins@chromium.org2009-09-251-0/+2
| | | | | | | | | CID=1405 BUG=none TEST=none Review URL: http://codereview.chromium.org/245004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27215 0039d316-1c4b-4281-b951-d872f2087c98
* linux: drop temp_scaffolding_stubsevan@chromium.org2009-09-251-1/+7
| | | | | | | | | It was mostly unneeded, but I had to excise the last bits of RLZ and move some NOTIMPLEMENTED bits to where they belong. Review URL: http://codereview.chromium.org/219042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27161 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize tab_contents_ and wait_state_ in the constructor.jhawkins@chromium.org2009-09-241-0/+2
| | | | | | | | | CID=1510 BUG=none TEST=none Review URL: http://codereview.chromium.org/218036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27120 0039d316-1c4b-4281-b951-d872f2087c98
* Move functions from skia/ext to app/gfx where possible: most of skia_utils.* ↵pkasting@chromium.org2009-09-241-0/+1
| | | | | | | | | | | | | and image_operations.* can be moved because they are not used by WebKit code. This also fixes the spelling of "Convolusion" to "Convolution" and updates some copyrights. This is a re-do of r26975, this time with WebKit update and some fixes to compile on Mac and Linux. BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27031 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize SavePackageParam::save_type to SAVE_TYPE_UNKNOWN in the ↵jhawkins@chromium.org2009-09-231-1/+3
| | | | | | | | | | | constructor. CID=2275 BUG=none TEST=none Review URL: http://codereview.chromium.org/219020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27014 0039d316-1c4b-4281-b951-d872f2087c98
* Implements file contents support in OSExchangeData and DropTargetsky@chromium.org2009-09-232-21/+35
| | | | | | | | | | | | | for gtk. Makes html and file contents support in OSExchangeData only for windows (as that is the only place we need it), and makes dragging files work. BUG=none TEST=none Review URL: http://codereview.chromium.org/232002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26995 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Add a SavePackageType, SAVE_TYPE_UNKNOWN, which represents the ↵jhawkins@chromium.org2009-09-232-2/+6
| | | | | | | | | | | state of the save type before the user has selected a save type. Initialize save_type_ to this value in the constructor. CID=3809 BUG=none TEST=none Review URL: http://codereview.chromium.org/220016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26983 0039d316-1c4b-4281-b951-d872f2087c98
* Two minor fixes to extensions/download manager integration:aa@chromium.org2009-09-223-17/+37
| | | | | | | | | | | - Don't show installed extensions in download view - Make "Save as..." work for extensions BUG=19080,20183 Review URL: http://codereview.chromium.org/209064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26788 0039d316-1c4b-4281-b951-d872f2087c98
* Fix coverity issue found in flaky DownloadTest, which should also decrease ↵phajdan.jr@chromium.org2009-09-181-7/+8
| | | | | | | | | | | | | flakiness. Big thanks to mattm for finding the issue! TEST=none BUG=20809 Review URL: http://codereview.chromium.org/209033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26629 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug where we access a view after deletion.paul@chromium.org2009-09-182-0/+5
| | | | | | | | | | | | | | | | | When the download shelf menu option 'Remove' is chosen, the view is removed and deleted (along with the object representing the download) so we must not access them after the removal. This CL NULLs the download pointer in the menu to prevent any futher access. BUG=20810 TEST=Remove an item from the download shelf and Chrome should not crash. Review URL: http://codereview.chromium.org/216018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26536 0039d316-1c4b-4281-b951-d872f2087c98
* prefs::kDownloadDefaultDirectory should always be initialized in ↵thestig@chromium.org2009-09-171-13/+5
| | | | | | | | | | DownloadManager::RegisterUserPrefs, remove code that assumes otherwise. BUG=none TEST=none Review URL: http://codereview.chromium.org/209003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26496 0039d316-1c4b-4281-b951-d872f2087c98
* Add pause and resume to Linux download shelf.craig.schlenter@chromium.org2009-09-161-1/+5
| | | | | | | | BUG=16929 Review URL: http://codereview.chromium.org/203069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26344 0039d316-1c4b-4281-b951-d872f2087c98
* Replace a bunch of hardcoded URLs with constants from url_constants.hbrettw@chromium.org2009-09-152-2/+3
| | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/193092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26263 0039d316-1c4b-4281-b951-d872f2087c98
* Fix two issues with a downloaded file's extension:paul@chromium.org2009-09-111-0/+3
| | | | | | | | | | | | | | | | | | | 1. On Mac, we were prepending an extra '.' to the extension causing it to fail a comparison (resulting in second extension being added). 2. For downloads with the extension '.tgz' and mime type 'application/x-gzip', we were appending an extra '.gz' extension. The extension compare code is starting to get a little long, but I don't think it's too bad if there are only a few of these cases. BUG=21591,21595 TEST=1. Download a file on Mac with a well known extension type (mp3, gz) and notice that there are no double extensions. 2. Download a tgz file and notice that the file's extension is '.tgz', not '.tgz.gz'. Review URL: http://codereview.chromium.org/195064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26028 0039d316-1c4b-4281-b951-d872f2087c98
* Increase number of tries in CheckInternetZoneIdentifier.phajdan.jr@chromium.org2009-09-111-1/+1
| | | | | | | | | | | | Hopefully this will be enough to kill flakiness. But I'm afraid it'll require some better solution in the end. TEST=ui_tests BUG=20809 Review URL: http://codereview.chromium.org/203033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26004 0039d316-1c4b-4281-b951-d872f2087c98
* Speculative fix for Mac quarantine crashstuartmorgan@google.com2009-09-102-1/+15
| | | | | | | | | BUG=13120 TEST=Quaraniting should continue to work on the Mac, and zone information should still be set on Windows. Review URL: http://codereview.chromium.org/193075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25904 0039d316-1c4b-4281-b951-d872f2087c98
* Sleep and poll (yuck!) in DownloadTest while verifying Internet ZoneIdentifier.phajdan.jr@chromium.org2009-09-031-21/+41
| | | | | | | | | | | | | There seems to be no other reliable way to do that due to Windows file semantics. This should decrease the flakiness. TEST=Covered by ui_tests. http://crbug.com/20809 Review URL: http://codereview.chromium.org/192010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25390 0039d316-1c4b-4281-b951-d872f2087c98
* Add "loading..." message to theme install to counter jank.mirandac@chromium.org2009-09-031-0/+6
| | | | | | | | | BUG= http://crbug.com/17696 TEST= Install a theme. Note that a "loading" message appears to notify you that a theme is loading. Review URL: http://codereview.chromium.org/191011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25383 0039d316-1c4b-4281-b951-d872f2087c98
* Exclude specific browser_tests that don't yet work on Mac.paul@chromium.org2009-09-021-0/+10
| | | | | | | | | BUG=16322 (http://crbug.com/16322) TEST=Covered by browser_tests. Review URL: http://codereview.chromium.org/189007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25265 0039d316-1c4b-4281-b951-d872f2087c98
* Disable flakey DownloadTest::ContentDispositiondglazkov@chromium.org2009-09-021-1/+1
| | | | | | | | | | | TBR=paul TEST=none BUG=20888 Review URL: http://codereview.chromium.org/188011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25190 0039d316-1c4b-4281-b951-d872f2087c98
* Replace the RenderProcessHost.PID function that returns the OS-generatedbrettw@chromium.org2009-08-314-21/+19
| | | | | | | | | | | | | | | | | | | | process ID with an internally-generated id() function. This allows us the guarantee that the IDs are unique over the entire run of the application. This also cleans up some code associated with managing the PID. The main potentially interesting change is now the PID is set uniquely for every creation of RenderProcessHost. It used to be set cleared if the process went away, and re-set if the process was re-created. The ID generation is in ChildProcesInfo so it is also unique between workers and plugins. I had to change some significant things in resource_dispatcher_host_unittest to take into account this new generation of IDs. BUG=17828 TEST=none Review URL: http://codereview.chromium.org/160203 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24899 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Fix a ton of compiler warnings."tony@chromium.org2009-08-282-11/+1
| | | | | | | | | | | This reverts commit r24792. TBR=estade Review URL: http://codereview.chromium.org/179028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24796 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a ton of compiler warnings.estade@chromium.org2009-08-282-1/+11
| | | | | | | | | | | | | | | Most of these are classes with virtual methods lacking virtual destructors or NULL used in non-pointer context. BUG=none TEST=app_unittests && base_unittests --gtest_filter=-ConditionVariableTest.LargeFastTaskTest patch by Jacob Mandelson <jlmjlm [at] gmail> http://codereview.chromium.org/171028/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24792 0039d316-1c4b-4281-b951-d872f2087c98
* Don't show extension disabled infobar when manually updatingaa@chromium.org2009-08-281-0/+1
| | | | | | | | | | extensions that increase privilges. BUG=20461 Review URL: http://codereview.chromium.org/174637 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24775 0039d316-1c4b-4281-b951-d872f2087c98
* POSIX doesn't have reserved filenames; so don't worry about a download ↵estade@chromium.org2009-08-261-2/+0
| | | | | | | | | trying to use one. BUG=19456 Review URL: http://codereview.chromium.org/173238 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24506 0039d316-1c4b-4281-b951-d872f2087c98
* Try one more time to lock down content sniffing foraa@chromium.org2009-08-251-17/+3
| | | | | | | | | | | | | | | | | | Chrome extensions. Last time I tried to check this in, I had to roll it back because it made installing extensions from file:// URLs not work. Turned out that we just have to add a single line mapping the ".crx" extension to our mimetype. BUG=13296 TEST=Install an extension from the interweb, it should install. Install an extension from disk, it should install. Review URL: http://codereview.chromium.org/174380 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24216 0039d316-1c4b-4281-b951-d872f2087c98
* Add a UI test for "Encoding" menu. Please see crbug.com/5515 for more ↵jnd@chromium.org2009-08-221-18/+10
| | | | | | | | details.This change list is based on http://codereview.chromium.org/18417 which was written by xlyuan@chromiumBug=5515 ( http://crbug.com/5515 ) Review URL: http://codereview.chromium.org/165393 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24073 0039d316-1c4b-4281-b951-d872f2087c98
* Show the extension install UI when the user clicks Reenable for a ↵mpcomplete@chromium.org2009-08-181-0/+1
| | | | | | | | | | | | | | | disabled-on-upgrade extension. Also fix a couple misc bugs with disabled extensions: - Fix a crash when trying to reenable an uninstalled disabled extension. - Fix a bug where upgrading a disabled extension would reenable it. BUG=12140 TEST=no Review URL: http://codereview.chromium.org/172006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23675 0039d316-1c4b-4281-b951-d872f2087c98
* Show or open downloaded items on the UI thread for Mac. This ispaul@chromium.org2009-08-186-27/+61
| | | | | | | | | | | | required because NSWorkspace, which is used for the open or show operation, must be called on the main thread. BUG=19447 (http://crbug.com/19447) TEST=Repro steps fully described in the bug report. Review URL: http://codereview.chromium.org/172074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23667 0039d316-1c4b-4281-b951-d872f2087c98
* Renames the function CreateTemporaryFilename to CreateTemporaryFile and ↵erikkay@chromium.org2009-08-183-3/+3
| | | | | | | | | | | | | | track down all callers, also removes the deprecated function that uses std::wstring. BUG=3078 (http://crbug.com/3078) TEST=run base_unittests, installer_util_unittests, net_unittests, setup_unittests, and unit_tests. Review URL: http://codereview.chromium.org/164537 Patch from Thiago Farina. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23631 0039d316-1c4b-4281-b951-d872f2087c98
* Implement drag and drop of downloads for the Mac downloads page.paul@chromium.org2009-08-172-7/+12
| | | | | | | | | | BUG=15776 (http://crbug.com/15776) TEST=Download an item, open the download page, drag the icon of the download to the desktop. Review URL: http://codereview.chromium.org/164459 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23548 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug where we can sometimes incorrectly decide a downloadaa@chromium.org2009-08-141-1/+1
| | | | | | | | | | | is not an extension. BUG=19340 TEST=See bug for details. Review URL: http://codereview.chromium.org/170007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23474 0039d316-1c4b-4281-b951-d872f2087c98
* Argh, reverting the change to remove the "crx" file extensionaa@chromium.org2009-08-131-3/+17
| | | | | | | | | | | | | | | | | | hack in DownloadManager. For those playing along at home, this change makes it so that we once again consider any file that ends in ".crx" an extension. The problem is that file:// URLs are not-sniffable, so with this change we cannot install extensions from file:// URLs. We need to fix things so that we consider file associations for local files, I guess. TBR=mpcomplete@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23362 0039d316-1c4b-4281-b951-d872f2087c98
* Refactors OSExchangeData for easier portability.sky@chromium.org2009-08-121-6/+8
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/164401 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23230 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the temporary hack that considered any file that endedaa@chromium.org2009-08-111-17/+3
| | | | | | | | | | | in ".crx" a Chrome extension now that all the relevant servers are fixed. BUG=13296 Review URL: http://codereview.chromium.org/164344 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23118 0039d316-1c4b-4281-b951-d872f2087c98
* Add "dangerous download" view on OS X, for now for dmg files. Also fix ↵thakis@chromium.org2009-08-112-14/+6
| | | | | | | | | | | download item layout. BUG=14667,17831 TEST=Download a dmg file. Make sure the "dangerous download" view appears. Check that both buttons work, and that the dmg filename is elided correctly. Also test that "Remove" on a normal download item's context menu relayouts the remaining items on the shelf. Review URL: http://codereview.chromium.org/165295 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23103 0039d316-1c4b-4281-b951-d872f2087c98
* Commit patch for Pierre-Antoine LaFayette, original CL:paul@chromium.org2009-08-111-3/+16
| | | | | | | | | | | | | | | | | http://codereview.chromium.org/164119 Items in the Downloads page should be loaded like a normal OS file when dragged to a Tab content area. We need the URL to be set to the file path in the IDataObject so that WebDropData can properly handle the file. BUG=9266 TEST=Drag an item with a supported MIME type from the Downloads page to a Tab content area. It should load within the browser. Drag an item with an unsupported MIME type and it should not open it. Review URL: http://codereview.chromium.org/165260 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22983 0039d316-1c4b-4281-b951-d872f2087c98
* Change "Cancelled" to "Canceled". Original patch by Thiago Farina (see ↵pkasting@chromium.org2009-08-101-2/+2
| | | | | | | | | http://codereview.chromium.org/165097 ), r=me. BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22933 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the size of a cancelled download in the download shelf.paul@chromium.org2009-08-061-2/+1
| | | | | | | | | | | | | Patch created by Thiago Farina, original CL: http://codereview.chromium.org/160465 BUG=17180 (http://crbug.com/17180) TEST=Download some file, then cancel it and notice the shelf UI does not any longer display the size of download. Review URL: http://codereview.chromium.org/165073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22666 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug where a download isn't canceled when the user requests it.paul@chromium.org2009-08-052-7/+21
| | | | | | | | | | | | | | | This particular bug only occurs when the user is prompted via save file dialog and then chooses cancel. In this case, the file selection code path for canceling was not the same as regular cancel case, so the network requests continued. BUG=18160 TEST=When prompted to save a download, choose cancel and notice that there is no further network traffic due to that download. Review URL: http://codereview.chromium.org/160627 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22557 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up SavePage UI test, remove dead code.phajdan.jr@chromium.org2009-08-051-21/+2
| | | | | | | | | | | As most of the tests moved to the browser test, this is now unneeded. TEST=none BUG=none Review URL: http://codereview.chromium.org/160666 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22511 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 21:10:56 +0000