| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
disabled on the beta branch.
TBR=karen@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10700172
git-svn-id: svn://svn.chromium.org/chrome/branches/1180/src@146234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=132937
TEST=download progress indicator is more hidpi (still isn't perfect)
Review URL: https://chromiumcodereview.appspot.com/10666011
TBR=avi@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10702007
git-svn-id: svn://svn.chromium.org/chrome/branches/1180/src@144477 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The grd changes were made by http://pastie.org/4132407 (and
then cleaned up manually).
BUG=132910
TEST=Look at various icons (blocked plugins, "press tab to search", etc)
TBR=sky
Review URL: https://chromiumcodereview.appspot.com/10642014
TBR=thakis@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10656014
git-svn-id: svn://svn.chromium.org/chrome/branches/1180/src@143848 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
error.
Also, setup the 'learn more' link for off-store install
failure, but don't enable yet as we don't quite have anything
to link to.
BUG=55584
TBR=yoz@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10559056
TBR=aa@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10581043
git-svn-id: svn://svn.chromium.org/chrome/branches/1180/src@143213 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=133025
TBR=yoz@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10559026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=NONE.
TEST=compiles, unit tests pass.
Review URL: https://chromiumcodereview.appspot.com/10553026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142615 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
plumbing through the Browser window. In two places (file_manager_util.cc and download_crx_util.cc) there is no context so I left those with FindLastActiveWithProfile for now.
BUG=129187
Review URL: https://chromiumcodereview.appspot.com/10548057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142489 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ResourceLoader. This class is responsible for driving the URLRequest (calling
Start, Read, and servicing events).
This change also generalizes ResourceThrottleController so that it can be used
by ResourceHandler implementations to resume or cancel a resource load. The
ResourceLoader is a ResourceController. (In a follow-up patch, the
BufferedResourceHandler will also become a ResourceController. This will
enable us to make the "resume" behavior sane.)
The ResourceDispatcherHostImpl now keeps a set of ResourceLoader objects
instead of URLRequests. The ResourceLoader owns its URLRequest as well as
ResourceHandler (chain). Numerous fields from ResourceRequestInfo become
member variables of ResourceLoader because they are only needed by
ResourceLoader. This helps cleanup some code. ResourceDispatcherHostImpl
is no longer a friend of ResourceRequestInfoImpl, and indeed RRII no longer
has any private getter/setters intended for use by RDHI!
The ResourceDispatcherHostImpl used to maintain a set of transferred
URLRequests. This set is eliminated in favor of just storing a boolean
flag on ResourceLoader (is_transferring_). When transferring a request
from one RenderView to another, we still replace the ResourceHandler
as before, but we keep the ResourceLoader. This means the logic for
completing the transfer becomes a member function on ResourceLoader.
See ResourceLoader::CompleteTransfer().
NOTE: I left it as future cleanup to improve some of the methods on
ResourceLoader that are essentially just copy/pasted from RDHI. For
example, I suspect that the new deferred_stage_ member variable will
make called_on_response_started_, has_started_reading_, and is_paused_
obsolete. I plan to make these simplifications along with making
BufferedResourceHandler implement ResourceController. For now, I'm
just trying to minimize changes since this CL is already too big.
R=jam@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10501004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142108 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
switched to WebContentsViewAura.
BUG=132221
TEST=no crash on draggin files in download manager.
Review URL: https://chromiumcodereview.appspot.com/10541150
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142017 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
"TCW"
BUG=131026
TEST=no change
Review URL: https://chromiumcodereview.appspot.com/10534104
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141730 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CID_COUNT=4
CID=104190,104193,104197,104204
BUG=none
TEST=none
R=groby
TBR=rdsmith,vrk,tommi
Review URL: https://chromiumcodereview.appspot.com/10538083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141688 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=97804,112525
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10535113
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141682 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
GetOwningTabContentsForWebContents
BUG=131026
TEST=no change
Review URL: https://chromiumcodereview.appspot.com/10535120
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141602 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=jhawkins@chromium.org
BUG=None
TEST=None
Review URL: https://chromiumcodereview.appspot.com/10545091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141517 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
browser/ui/blocked_content
BUG=131026
TEST=no change
Review URL: https://chromiumcodereview.appspot.com/10536092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141477 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
called. This is because the delegate needs to do cleanup in response (especially update its persistent store).
BUG=131692
Review URL: https://chromiumcodereview.appspot.com/10535093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141422 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=55584
TBR=jhawkins@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10542048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Add SubstituteGDataDownloadPathCallback step between CheckVisitedReferrerBeforeDone and CheckIfSuggestedPathExists.
* Change the signature of ChooseDownloadPath with DownloadItem* arg only.
* DownloadFilePicker has an empty ctor and does most of the work in Init() now.
* DownloadFilePicker::SetSuggestedPath is a virtual that is overriden by DownloadFilePickerChromeOS to suggest the gdata path instead.
* GetSaveDir takes an addition skip_dir_check boolean param. We shouldn't do the directory existence check for cloud folders.
BUG=127159
TEST=manual
TBR=rdsmith@chromium.org,avi@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10501014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141318 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As part of the effort to build unit-tests on Android, this CL abstracts out
references to the Browser object from the extension install ui code.
For this, ExtensionInstallUI has been renamed ExtensionInstallPrompt and the
UI specific bits have been moved to a new class that took the old name
ExtensionInstallUI.
BUG=None
TEST=You should be able to install an extension.
All browser tests/unit tests should pass.
Review URL: https://chromiumcodereview.appspot.com/10388252
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141261 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Downloads.
BUG=131026
TEST=no change
Review URL: https://chromiumcodereview.appspot.com/10545064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141235 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is in preparation for adding a GetNativeWindow() method to
the BaseWindow interface.
BUG=None
TEST=None
Review URL: https://chromiumcodereview.appspot.com/10538039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141071 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Bug=None
Test=Compiles
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=140877
Review URL: https://chromiumcodereview.appspot.com/10512021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141002 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/10537046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bug=None
Test=Compiles
Review URL: https://chromiumcodereview.appspot.com/10512021
TBR=pkotwicz@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10546037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140882 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Bug=None
Test=Compiles
Review URL: https://chromiumcodereview.appspot.com/10512021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140877 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
content.
BUG=98716
Review URL: https://chromiumcodereview.appspot.com/10545034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140780 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This matches all the other objects that content depends on.
In a followup change, I'll make content support NULL DownloadManagerDelegates to match the rest of the delegate interfaces.
BUG=98716
Review URL: https://chromiumcodereview.appspot.com/10535026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140761 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=131026
TEST=no change
Review URL: https://chromiumcodereview.appspot.com/10542010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140754 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=130844,122469
Review URL: https://chromiumcodereview.appspot.com/10538019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140702 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10535025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140672 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ImageSkia
Used same conversion script as 10437006
Modified the following files afterwards:
1 chrome/browser/background/background_application_list_model.cc
2 chrome/browser/extensions/extension_install_ui.cc
3 chrome/browser/extensions/extension_install_ui.h
4 chrome/browser/speech/speech_recognition_bubble.cc
5 chrome/browser/speech/speech_recognition_bubble_controller_unittest.cc
6 chrome/browser/speech/speech_recognition_bubble_gtk.cc
7 chrome/browser/speech/speech_recognition_tray_icon_controller.h
8 chrome/browser/task_manager/task_manager_resource_providers.cc
9 chrome/browser/ui/panels/panel_browser_frame_view.cc
10 chrome/browser/ui/search_engines/template_url_table_model.cc
11 chrome/browser/ui/search_engines/template_url_table_model.h
12 chrome/browser/ui/views/autocomplete/autocomplete_result_view.cc
13 chrome/browser/ui/views/avatar_menu_button.cc
14 chrome/browser/ui/views/detachable_toolbar_view.cc
15 chrome/browser/ui/views/download/download_item_view.cc
16 chrome/browser/ui/views/extensions/extension_install_dialog_view.cc
17 chrome/browser/ui/views/location_bar/icon_label_bubble_view.h
18 chrome/browser/ui/views/location_bar/location_bar_view.cc
19 chrome/browser/ui/views/tab_icon_view.cc
20 chrome/browser/ui/views/tab_icon_view.h
21 chrome/browser/ui/views/tabs/tab_strip.cc
Include, whitespace changes in
1 chrome/browser/automation/automation_provider_observers.cc
2 chrome/browser/background/background_application_list_model.h
3 chrome/browser/background/background_mode_manager.cc
4 chrome/browser/custom_home_pages_table_model.h
5 chrome/browser/download/download_util.cc
6 chrome/browser/extensions/extension_function_dispatcher.cc
7 chrome/browser/extensions/extension_install_dialog.cc
8 chrome/browser/extensions/extension_install_dialog.h
9 chrome/browser/ntp_background_util.cc
10 chrome/browser/speech/speech_recognition_bubble.h
11 chrome/browser/task_manager/task_manager.h
12 chrome/browser/ui/cocoa/infobars/mock_confirm_infobar_delegate.cc
13 chrome/browser/ui/cocoa/infobars/mock_link_infobar_delegate.cc
14 chrome/browser/ui/cocoa/task_manager_mac.h
15 chrome/browser/ui/views/about_chrome_view.cc
16 chrome/browser/ui/views/avatar_menu_bubble_view.cc
17 chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc
18 chrome/browser/ui/views/download/download_item_view.h
19 chrome/browser/ui/views/find_bar_view.cc
20 chrome/browser/ui/views/infobars/extension_infobar.cc
21 chrome/browser/ui/views/notifications/balloon_view.cc
22 chrome/browser/ui/views/page_info_bubble_view.cc
23 chrome/browser/ui/views/tabs/base_tab.cc
24 chrome/browser/ui/views/tabs/tab.cc
25 chrome/browser/ui/views/toolbar_view.cc
Review URL: https://chromiumcodereview.appspot.com/10453101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140628 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a more accurate name. Off store extension install is
still supported, just not as easily.
BUG=55584
TBR=jhawkins
Review URL: https://chromiumcodereview.appspot.com/10511015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140569 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
favicons to user ImageSkia
Used same conversion script as 10437006
Modified the following files afterwards:
1 chrome/browser/background/background_application_list_model.cc
2 chrome/browser/extensions/extension_install_ui.cc
3 chrome/browser/extensions/extension_install_ui.h
4 chrome/browser/speech/speech_recognition_bubble.cc
5 chrome/browser/speech/speech_recognition_bubble_controller_unittest.cc
6 chrome/browser/speech/speech_recognition_bubble_gtk.cc
7 chrome/browser/speech/speech_recognition_tray_icon_controller.h
8 chrome/browser/task_manager/task_manager_resource_providers.cc
9 chrome/browser/ui/panels/panel_browser_frame_view.cc
10 chrome/browser/ui/search_engines/template_url_table_model.cc
11 chrome/browser/ui/search_engines/template_url_table_model.h
12 chrome/browser/ui/views/autocomplete/autocomplete_result_view.cc
13 chrome/browser/ui/views/avatar_menu_button.cc
14 chrome/browser/ui/views/detachable_toolbar_view.cc
15 chrome/browser/ui/views/download/download_item_view.cc
16 chrome/browser/ui/views/extensions/extension_install_dialog_view.cc
17 chrome/browser/ui/views/location_bar/icon_label_bubble_view.h
18 chrome/browser/ui/views/location_bar/location_bar_view.cc
19 chrome/browser/ui/views/tab_icon_view.cc
20 chrome/browser/ui/views/tab_icon_view.h
21 chrome/browser/ui/views/tabs/tab_strip.cc
Include, whitespace changes in
1 chrome/browser/automation/automation_provider_observers.cc
2 chrome/browser/background/background_application_list_model.h
3 chrome/browser/background/background_mode_manager.cc
4 chrome/browser/custom_home_pages_table_model.h
5 chrome/browser/download/download_util.cc
6 chrome/browser/extensions/extension_function_dispatcher.cc
7 chrome/browser/extensions/extension_install_dialog.cc
8 chrome/browser/extensions/extension_install_dialog.h
9 chrome/browser/ntp_background_util.cc
10 chrome/browser/speech/speech_recognition_bubble.h
11 chrome/browser/task_manager/task_manager.h
12 chrome/browser/ui/cocoa/infobars/mock_confirm_infobar_delegate.cc
13 chrome/browser/ui/cocoa/infobars/mock_link_infobar_delegate.cc
14 chrome/browser/ui/cocoa/task_manager_mac.h
15 chrome/browser/ui/views/about_chrome_view.cc
16 chrome/browser/ui/views/avatar_menu_bubble_view.cc
17 chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc
18 chrome/browser/ui/views/download/download_item_view.h
19 chrome/browser/ui/views/find_bar_view.cc
20 chrome/browser/ui/views/infobars/extension_infobar.cc
21 chrome/browser/ui/views/notifications/balloon_view.cc
22 chrome/browser/ui/views/page_info_bubble_view.cc
23 chrome/browser/ui/views/tabs/base_tab.cc
24 chrome/browser/ui/views/tabs/tab.cc
25 chrome/browser/ui/views/toolbar_view.cc
Review URL: https://chromiumcodereview.appspot.com/10453101
TBR=pkotwicz@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10534009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140532 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ImageSkia
Used same conversion script as 10437006
Modified the following files afterwards:
1 chrome/browser/background/background_application_list_model.cc
2 chrome/browser/extensions/extension_install_ui.cc
3 chrome/browser/extensions/extension_install_ui.h
4 chrome/browser/speech/speech_recognition_bubble.cc
5 chrome/browser/speech/speech_recognition_bubble_controller_unittest.cc
6 chrome/browser/speech/speech_recognition_bubble_gtk.cc
7 chrome/browser/speech/speech_recognition_tray_icon_controller.h
8 chrome/browser/task_manager/task_manager_resource_providers.cc
9 chrome/browser/ui/panels/panel_browser_frame_view.cc
10 chrome/browser/ui/search_engines/template_url_table_model.cc
11 chrome/browser/ui/search_engines/template_url_table_model.h
12 chrome/browser/ui/views/autocomplete/autocomplete_result_view.cc
13 chrome/browser/ui/views/avatar_menu_button.cc
14 chrome/browser/ui/views/detachable_toolbar_view.cc
15 chrome/browser/ui/views/download/download_item_view.cc
16 chrome/browser/ui/views/extensions/extension_install_dialog_view.cc
17 chrome/browser/ui/views/location_bar/icon_label_bubble_view.h
18 chrome/browser/ui/views/location_bar/location_bar_view.cc
19 chrome/browser/ui/views/tab_icon_view.cc
20 chrome/browser/ui/views/tab_icon_view.h
21 chrome/browser/ui/views/tabs/tab_strip.cc
Include, whitespace changes in
1 chrome/browser/automation/automation_provider_observers.cc
2 chrome/browser/background/background_application_list_model.h
3 chrome/browser/background/background_mode_manager.cc
4 chrome/browser/custom_home_pages_table_model.h
5 chrome/browser/download/download_util.cc
6 chrome/browser/extensions/extension_function_dispatcher.cc
7 chrome/browser/extensions/extension_install_dialog.cc
8 chrome/browser/extensions/extension_install_dialog.h
9 chrome/browser/ntp_background_util.cc
10 chrome/browser/speech/speech_recognition_bubble.h
11 chrome/browser/task_manager/task_manager.h
12 chrome/browser/ui/cocoa/infobars/mock_confirm_infobar_delegate.cc
13 chrome/browser/ui/cocoa/infobars/mock_link_infobar_delegate.cc
14 chrome/browser/ui/cocoa/task_manager_mac.h
15 chrome/browser/ui/views/about_chrome_view.cc
16 chrome/browser/ui/views/avatar_menu_bubble_view.cc
17 chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc
18 chrome/browser/ui/views/download/download_item_view.h
19 chrome/browser/ui/views/find_bar_view.cc
20 chrome/browser/ui/views/infobars/extension_infobar.cc
21 chrome/browser/ui/views/notifications/balloon_view.cc
22 chrome/browser/ui/views/page_info_bubble_view.cc
23 chrome/browser/ui/views/tabs/base_tab.cc
24 chrome/browser/ui/views/tabs/tab.cc
25 chrome/browser/ui/views/toolbar_view.cc
Review URL: https://chromiumcodereview.appspot.com/10453101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140531 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
In order to install extensions and user scripts, users will now need to download them and drag them onto chrome://extensions. Theme install works as before.
BUG=55584
Review URL: https://chromiumcodereview.appspot.com/10519010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140527 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=131026
TEST=no change
Review URL: https://chromiumcodereview.appspot.com/10528002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140523 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Add method SubstituteGDataDownloadPath for the gdata->temporary path substitution logic. Call this from DownloadFilePickerChromeos and SavePackageFilePickerChromeOS.
* Replace SetGDataPath with SetDownloadParams to set up a gdata download.
BUG=127159
TEST=manual
Review URL: https://chromiumcodereview.appspot.com/10492007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140345 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=NONE
Review URL: https://chromiumcodereview.appspot.com/10501011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
enforce that internal content headers don't leak to embedders.
BUG=98716
TBR=phajdan.jr
Review URL: https://chromiumcodereview.appspot.com/10502009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140261 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
way we can enforce that internal content headers don't leak to embedders.
BUG=98716
TBR=phajdan.jr
Review URL: https://chromiumcodereview.appspot.com/10500016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140254 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
out too often.
BUG=130950
TBR=benjhayden@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10499011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This way we can enforce that internal content headers don't leak to embedders.
BUG=98716
TBR=phajdan.jr
Review URL: https://chromiumcodereview.appspot.com/10501012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
can enforce that internal content headers don't leak to embedders. Move these headers into the content namespace in the process.
BUG=98716
TBR=phajdan.jr
Review URL: https://chromiumcodereview.appspot.com/10497009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140199 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=130514
TEST=unit tests
Review URL: https://chromiumcodereview.appspot.com/10448101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139823 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome/browser/ui/views/frame to use ImageSkia
Do conversion using the same sed script as for 10437006
Modified by hand afterwards:
1 chrome/browser/download/download_util.cc
2 chrome/browser/ui/panels/panel_browser_frame_view.cc
3 chrome/browser/ui/panels/panel_browser_frame_view.h
4 chrome/browser/ui/toolbar/wrench_menu_model.cc
5 chrome/browser/ui/views/ash/browser_non_client_frame_view_ash.cc
6 chrome/browser/ui/views/ash/browser_non_client_frame_view_ash.h
7 chrome/browser/ui/views/constrained_window_views.cc
8 chrome/browser/ui/views/frame/glass_browser_frame_view.cc
9 chrome/browser/ui/views/tab_icon_view.h
10 ui/base/dragdrop/drag_utils.h
11 ui/base/dragdrop/drag_utils_gtk.cc
12 ui/base/dragdrop/drag_utils_win.cc
13 ui/base/native_theme/native_theme_android.cc
14 ui/base/native_theme/native_theme_android.h
15 ui/base/native_theme/native_theme_base.cc
16 ui/base/native_theme/native_theme_base.h
17 ui/views/widget/native_widget_private.h
18 ui/views/window/frame_background.h
19 ui/views/window/window_resources.h
Line wrapping and include fixes
chrome/browser/ui/views/frame/app_panel_browser_frame_view.cc
1 chrome/browser/ui/views/frame/browser_view.cc
2 chrome/browser/ui/views/frame/opaque_browser_frame_view.cc
3 ui/base/dragdrop/drag_utils_aura.cc
4 ui/base/dragdrop/os_exchange_data_provider_aura.h
5 ui/base/native_theme/native_theme_aura.cc
6 ui/views/button_drag_utils.h
7 ui/views/painter.cc
8 ui/views/painter.h
9 ui/views/widget/native_widget_aura.cc
10 ui/views/widget/widget_delegate.h
11 ui/views/window/custom_frame_view.cc
12 ui/views/window/custom_frame_view.h
Test=Compiles, Webkit layout tests fast/ pass
Bug=124566
Review URL: https://chromiumcodereview.appspot.com/10447053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139734 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Removes dependency on DownloadStateInfo in chrome/.
- Adds unit tests for ChromeDownloadManagerDelegate.
- Cleanup methods for filename determination in DownloadItem to eliminate setters.
BUG=78085
TEST=unit tests
Review URL: https://chromiumcodereview.appspot.com/10083010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139682 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
downloads automatically
Automatically cancel automatic (non-user-gesture) downloads from bubbles after the first.
Merge DownloadRequestLimiterObserver into TabDownloadState. (NavigationController and WebContents are 1:1.)
TODO eventually: send a message to extensions' consoles about chrome.downloads.download() when automatic downloads are automatically cancelled.
Every WebContents continues to get one automatic download.
This patch is based on Avi's https://chromiumcodereview.appspot.com/10409031/
BUG=128368
Review URL: https://chromiumcodereview.appspot.com/10412061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139554 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* cache related methods, enums, etc have been moved out of GDataRootDirectory and GDataFile into GDataCache. Some of these methods have been renamed.
* GDataCache is an interface, with a map implementation GDataCacheMap. This is in preperation for a database implementation.
* CacheMap is now map of <string, CacheEntry> instead of <string, CacheEntry*>
* GetCacheEntry returns a scoped_ptr<CacheEntry> instead of CacheEntry*.
* GDataFileSystem has a cache_ data member, and root_-> is now cache_-> for cache methods.
* cache_ may only be accessed on the blocking thread pool. Added assertions to this effect, and removed all locking for cache_ access.
* Got rid of InitializeCacheIfNecessary. The cache is initialized upon startup on the blocking pool instead of lazily. GDataFileSystemTest::InitializeCache was modified to make this work.
* Fixed ~GDataRootDirectory - stale root_ was being accessed in ~GDataDirectory.
* The only change in most files is that GDataRootDirectory:: and GDataFile:: is now GDataCache::
* Added gdata_cache_unittest.cc for cache api tests.
BUG=127856,129506
TEST=unit tests pass.
Review URL: https://chromiumcodereview.appspot.com/10332188
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139288 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move the check later into install so that:
1) The download bar goes away.
2) There's an error message.
3) The same thing happens when double-clicking a crx, on systems that associate crx with Chrome.
Also, made themes exempt from this policy since there is no danger in installing a theme. This left themes with a dangerous download bar that said 'Installing extensions, themes, and apps can harm your computer', which isn't even true for themes. It was only there to protect against clickjacking. Removed that and replaced with standard install dialog.
Had to update a bunch of strings.
BUG=55584
TEST=Run chrome with --enable-off-store-extension-install=0, navigate to a crx file. Should see error dialog.
TBR=sky
Review URL: https://chromiumcodereview.appspot.com/10452009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139217 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=owners
Review URL: https://chromiumcodereview.appspot.com/10386221
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139172 0039d316-1c4b-4281-b951-d872f2087c98
|