| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
with mime_type "application/x-tar".
BUG=5772
Review URL: http://codereview.chromium.org/42622
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12509 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Note that this only works if you are using a gnome or kde session. Support for other sessions will be added in the future.
Review URL: http://codereview.chromium.org/52034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12395 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This DCHECK occurs when we click Allow on the "This webpage is trying to download multiple files" dialog.
When...
DownloadRequestDialogDelegate
... and ...
DownloadRequestDialogDelegateWin
... were created, both classes by accident contained a host_ member.
This causes a DCHECK in...
DownloadRequestDialogDelegateWin::DeleteDelegate()
... because the host_ in the child class is never initialized. I
believe the intent is to check the host_ of the parent class, so
I deleted the definition of host from xxxDelegateWin.
Review URL: http://codereview.chromium.org/50072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12220 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
I did a lot of cleanup of the DOM UI system as part of this.
Review URL: http://codereview.chromium.org/42227
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11925 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=sky
Review URL: http://codereview.chromium.org/48058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11841 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11829 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/48019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/46020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11659 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
to ~400.
Review URL: http://codereview.chromium.org/46039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11651 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Reverting for now. Will try again later
Review URL: http://codereview.chromium.org/46046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11648 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=ojan
Review URL: http://codereview.chromium.org/46040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11642 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Only the Save As file selection dialog is implemented for now.
Review URL: http://codereview.chromium.org/42152
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11594 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42155
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11593 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/43148
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11590 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
"host_id". This allows ResourceDispatcher to be used by child processes other than renderers. I've done minor related cleanup on the way to make the code simpler.
Review URL: http://codereview.chromium.org/42054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11509 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
have selected in your prefs instead of always choosing the chrome::DIR_DEFAULT_DOWNLOADS path.
This will only affect you if you have not used 'save as...' before and do not have a SaveFileDefaultDirectory set.
Patch contributed by Paul Robinson <paulRobinson85@googlemail.com>
BUG=8049
Review URL: http://codereview.chromium.org/43016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11465 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/7191
Review URL: http://codereview.chromium.org/43046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11459 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/43039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Normalize end of file newlines in chrome/. All files end in a single newline.
Review URL: http://codereview.chromium.org/42015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11331 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/41002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11288 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Small fix to get them to display (need to include webkit strings in our
language pak files).
Review URL: http://codereview.chromium.org/39296
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11286 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
until WM_NCDESTROY. This involves adding a specific method to allow delegates to destroy themselves to WindowDelegate, and moving all delete this calls into implementations of that method (to allow delegates to still respond to WM_DESTROY which is legit).
Review URL: http://codereview.chromium.org/40192
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11132 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
* Delete DownloadDestinationContextMenu, which is not used anywhere.
* Delete the unused download menu item types from the ContextMenuCommands enum.
* Merge BaseContextMenu and DownloadShelfContextMenu, move them from download_util.{h,cc} to download_shelf.{h,cc}
* Take the windows-specific code from the new DownloadShelfContextMenu and put it in DownloadShelfContextMenuWin in download_item_view.cc (the only place it's used). DownloadShelfContextMenuWin extends DownloadShelfContextMenu and Menu::Delegate.
Review URL: http://codereview.chromium.org/40184
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11068 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Split the lines >80 cols. (Part 1)
Review URL: http://codereview.chromium.org/39206
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11032 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
It shows and hides at appropriate times, and that's about it.
TEST=navigate to a savable page and select "save page as" from the page menu. Click the x. Save the page again. The shelf should pop up, go away, pop up again.
Review URL: http://codereview.chromium.org/38004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10927 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Update callers as well.
This patch builds on a patch by mark.a.lindner@gmail.com which can be found at http://codereview.chromium.org/28294
Review URL: http://codereview.chromium.org/27370
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10860 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
than the string methods.
Update the pref service unit test and enable it on linux.
Also switch over some wstrings to filepaths where appropriate.
BUG=8154
Review URL: http://codereview.chromium.org/27354
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10844 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
the download manager. Move chrome_paths_mac from a .cc to a .mm to allow Cocoa.
Review URL: http://codereview.chromium.org/39041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10820 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Side effect of removing some views dependencies from places they don't belong.
Review URL: http://codereview.chromium.org/28252
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10657 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
R=brettw
Review URL: http://codereview.chromium.org/28157
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10438 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/31008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10437 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
* rearrange some IFDEFs
* trim whitespace on suggest name
Also fix a relatively new bug in DomSerializer.
Review URL: http://codereview.chromium.org/27106
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10314 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
There's still no UI though.
Review URL: http://codereview.chromium.org/27097
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10299 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Pull out the dialog delegate to a separate file so we can swap it out with other implementations on other platforms.
Also, build download_request_manager.cc on POSIX.
Review URL: http://codereview.chromium.org/27062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10270 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
extensions when judging whether a file is executable.
Also, store known executable file extensions as narrow strings since they are all ASCII anyway.
r=jcampan
BUG=7455
Review URL: http://codereview.chromium.org/29003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10246 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
tbr=jhawkins
Review URL: http://codereview.chromium.org/28052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10229 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
* Move BaseDownloadItemModel to download_item_model.h. Previously it was in a windows-specific file in chrome/browser/views/.
* Move SavePageModel to download_item_model.{cc,h}.
Review URL: http://codereview.chromium.org/28033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/28045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10224 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
FilePath::Extension() returns ".extension" whereas file_util::GetExtensionFromFilename() returns just "extension"
Review URL: http://codereview.chromium.org/27071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10221 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
the headers too.
Review URL: http://codereview.chromium.org/21472
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10167 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Also shuffle a bunch of headers.
Review URL: http://codereview.chromium.org/27024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10155 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20514
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
This effectively mocks out prompt-spawning win_util calls and keeps untested lines of code to a minimum.
Review URL: http://codereview.chromium.org/21492
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10044 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/20479
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9999 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=7616
Review URL: http://codereview.chromium.org/21482
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9988 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
- Trade in some old wstrings for FilePaths.
- Remove some unnecessary headers.
Review URL: http://codereview.chromium.org/21466
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9986 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
a locale_settings.h file that we use on all platforms. However,
the rc generation isn't correct yet, so for now, use the existing
locale_settings_*.rc files.
Also go ahead and generate the en-US locale pak on linux.
Review URL: http://codereview.chromium.org/20447
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
filenames/file extensions.
Review URL: http://codereview.chromium.org/21327
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9809 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- fix scons dependencies by adding a target for grit/theme_resources.h
- fix mac build by adding grit to unittest include path
- fix check deps by adding rules for /grit dir.
Create a chrome_resources.vcproj that holds grd files that hold
non-string resources. Put browser_resources.grd into this vcproj.
Port theme_resources.rc/theme_resources.h to theme_resources.grd
and put it in the vcproj too.
I did a find/replace on the theme_resources include line.
Modify grit so header files go in grit_generated_resources/grit/
so the include path can be cleaner. I'll migrate the others
in follow up patches.
theme_resources.rc had a conditional include of distribution_resources.rc
so I had to add support for preprocessor defines to visual studio.
Review URL: http://codereview.chromium.org/24011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9664 0039d316-1c4b-4281-b951-d872f2087c98
|