summaryrefslogtreecommitdiffstats
path: root/chrome/browser/download
Commit message (Collapse)AuthorAgeFilesLines
* Make WebContentsObserver::web_contents() publiclucinka.brozkova2014-09-041-5/+0
| | | | | | | | | | WebContentsObserver::web_contents() is now public + cleanup of unnecessary getters. BUG=408560 Review URL: https://codereview.chromium.org/525793002 Cr-Commit-Position: refs/heads/master@{#293274}
* Remove .apk from dangerous file extension listfelt2014-08-281-1/+0
| | | | | | | | BUG=404472 Review URL: https://codereview.chromium.org/512983003 Cr-Commit-Position: refs/heads/master@{#292473}
* Finish converting chrome_strings target to use qualified paths.thestig2014-08-271-1/+1
| | | | | | | | BUG=401588 Review URL: https://codereview.chromium.org/507913002 Cr-Commit-Position: refs/heads/master@{#292111}
* Remove implicit conversions from scoped_refptr to T* in chrome/browser/download/dcheng2014-08-261-9/+5
| | | | | | | | | | | This patch was generated by running the rewrite_scoped_refptr clang tool on a Linux build. BUG=110610 Review URL: https://codereview.chromium.org/511483002 Cr-Commit-Position: refs/heads/master@{#291997}
* Change base/file_utils.h includes to base/files/file_utils.h in chrome/thestig2014-08-267-7/+7
| | | | | | Review URL: https://codereview.chromium.org/486843004 Cr-Commit-Position: refs/heads/master@{#291880}
* Fix a typo in DownloadUIControllerTest.dhnishi@chromium.org2014-08-221-1/+1
| | | | | | | | | TBR=asanka@chromium.org Review URL: https://codereview.chromium.org/501473004 Cr-Commit-Position: refs/heads/master@{#291541} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291541 0039d316-1c4b-4281-b951-d872f2087c98
* Use a qualified path for chromium_strings, google_chrome_strings, and ↵thestig@chromium.org2014-08-228-10/+10
| | | | | | | | | | | generated_resources. (part 1) BUG=401588 Review URL: https://codereview.chromium.org/469993006 Cr-Commit-Position: refs/heads/master@{#291367} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291367 0039d316-1c4b-4281-b951-d872f2087c98
* Experience sampling instrumentation for dangerous downloads warningscthomp@chromium.org2014-08-162-0/+29
| | | | | | | | | BUG=384635 Review URL: https://codereview.chromium.org/402293002 Cr-Commit-Position: refs/heads/master@{#290076} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290076 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 289312 "Move StringToUpperASCII and LowerCaseEqualsASCII ..."brettw@chromium.org2014-08-131-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | > Move StringToUpperASCII and LowerCaseEqualsASCII to the base namespace > > Convert LowerCaseEqualsASCII to take StringPiece. In the current patch this is > generally a NOP but will allow me to delete the other 4 variants in a followup > (wanted to do that separately since that will require more review, since > callsites will be changed in nontrivial ways). > > In some cases, LowerCaseEqualsASCII is called with a WebString, which no > longer is implicitly converted. I added base::string16(...) around such > calls to force the right conversion. It happened in these files: > window_container_type.cc > savable_resources.cc > render_view_impl.cc > blink_ax_tree_source.cc > password_form_conversion_utils.cc > translate_helper.cc > chrome_render_view_observer.cc > dom_serializer_browsertest.cc > > R=jamesr@chromium.org > > Review URL: https://codereview.chromium.org/448143008 TBR=brettw@chromium.org Review URL: https://codereview.chromium.org/474483002 Cr-Commit-Position: refs/heads/master@{#289320} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289320 0039d316-1c4b-4281-b951-d872f2087c98
* Move StringToUpperASCII and LowerCaseEqualsASCII to the base namespacebrettw@chromium.org2014-08-131-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | Convert LowerCaseEqualsASCII to take StringPiece. In the current patch this is generally a NOP but will allow me to delete the other 4 variants in a followup (wanted to do that separately since that will require more review, since callsites will be changed in nontrivial ways). In some cases, LowerCaseEqualsASCII is called with a WebString, which no longer is implicitly converted. I added base::string16(...) around such calls to force the right conversion. It happened in these files: window_container_type.cc savable_resources.cc render_view_impl.cc blink_ax_tree_source.cc password_form_conversion_utils.cc translate_helper.cc chrome_render_view_observer.cc dom_serializer_browsertest.cc R=jamesr@chromium.org Review URL: https://codereview.chromium.org/448143008 Cr-Commit-Position: refs/heads/master@{#289312} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289312 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded #includes for grit/, ui/base/l10n/l10n_util.h and ↵thestig@chromium.org2014-08-083-6/+0
| | | | | | | | | | | | | | | | ui/base/resource/resource_bundle.h. For files that have #include from the list above, the heuristics for determining if the #includes are needed are as follows: grit -> with a few exceptions, grep for ID[RS] l10n_util.h -> grep l10n_util:: resource_bundle.h -> egrep '(GetImageNamed|GetNativeImageNamed|GetRawDataResource|GetLocalizedString|GetImageSkiaNamed|ResourceBundle)' Review URL: https://codereview.chromium.org/454583002 Cr-Commit-Position: refs/heads/master@{#288450} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288450 0039d316-1c4b-4281-b951-d872f2087c98
* Move file_util_icu to base::i18n namespacebrettw@chromium.org2014-08-071-1/+1
| | | | | | | | TBR=sky Review URL: https://codereview.chromium.org/447403002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288170 0039d316-1c4b-4281-b951-d872f2087c98
* Move the rest of test_file_util to base namespace.brettw@chromium.org2014-08-072-5/+5
| | | | | | | | R=rvargas@chromium.org Review URL: https://codereview.chromium.org/444163003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288158 0039d316-1c4b-4281-b951-d872f2087c98
* Sanitize referrer in context menus.nasko@chromium.org2014-08-051-0/+112
| | | | | | | | | | | This CL adds a method to content::Referrer that allows for sanitizing the referrer before making a network request and uses it to scrub the Referer header for requests originating in the context menu. It is based on work started by cbentzel@ in https://codereview.chromium.org/277903002/. BUG=357473 Review URL: https://codereview.chromium.org/438283002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287579 0039d316-1c4b-4281-b951-d872f2087c98
* Move extension notifications to extensions/browser/notification_types.hjamescook@chromium.org2014-07-311-6/+4
| | | | | | | | | | | | | | | | | | As part of the extensions module refactor we temporarily allowed the use of chrome_notification_types.h in src/extensions. However, this allowed code moving into src/extensions to listen to notifications from Chrome, which was a layering violation. This CL moves all the extensions notifications into their own header and cleans up DEPS to disallow the exception. BUG=392622 TEST=compiles, unit_tests, browser_tests, extensions_unittests TBR=miket@chromium.org for apps/ Review URL: https://codereview.chromium.org/425303002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286770 0039d316-1c4b-4281-b951-d872f2087c98
* Remove CancelableRequestTracker & CancelableRequestConsumersdefresne@chromium.org2014-07-291-1/+0
| | | | | | | | | | | | | | | Code has been deprecated for a long time and there are no clients remaining so remove the //chrome/browser/common/cancelable_request.{h,cc} files. Remove unused properties, parent classes and includes related to the old CancelableRequestTracker or CancelableRequestProvider. BUG=155883 R=sky@chromium.org Review URL: https://codereview.chromium.org/421213005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286173 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unused CancelableRequestConsumer usage from download test.tfarina@chromium.org2014-07-281-2/+0
| | | | | | | | | | | BUG=371818 TEST=browser_tests --gtest_filter=DownloadTest.* R=asanka@chromium.org,sdefresne@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/424603002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285915 0039d316-1c4b-4281-b951-d872f2087c98
* Relands "Removed InProcessBrowserTest::CleanUpOnMainThread()"atwilson@chromium.org2014-07-251-1/+1
| | | | | | | | | | | | | This reverts r285278 and re-lands r285173 with a fix for a chromeos test. Originally landed as https://codereview.chromium.org/366813007. BUG=381181 TBR=jam Review URL: https://codereview.chromium.org/419523003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285636 0039d316-1c4b-4281-b951-d872f2087c98
* Windows: Fix a corner case where we still think Adobe Reader is up to date ↵thestig@chromium.org2014-07-251-1/+3
| | | | | | | | | | | after it has been uninstalled. BUG=370746 TEST=Manual, see https://code.google.com/p/chromium/issues/detail?id=370746#c43 Review URL: https://codereview.chromium.org/419163003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285553 0039d316-1c4b-4281-b951-d872f2087c98
* Remove Create*Value (except CreateNullValue)estade@chromium.org2014-07-251-2/+2
| | | | | | | | BUG=160586 Review URL: https://codereview.chromium.org/415423002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285496 0039d316-1c4b-4281-b951-d872f2087c98
* Added SERVER_UNAUTHORIZED download interrupt reason.ljagielski@opera.com2014-07-242-0/+20
| | | | | | | | | | | | | chrome/app/generated_resources.grd: added messages for DOWNLOAD_INTERRUPT_REASON_SERVER_UNAUTHORIZED content/browser/download: handling of DOWNLOAD_INTERRUPT_REASON_SERVER_UNAUTHORIZED BUG=386146 Review URL: https://codereview.chromium.org/351863002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285359 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 285173 "Removed InProcessBrowserTest::CleanUpOnMainThread()"asvitkine@chromium.org2014-07-241-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | suspected to have broken ChromeOS browsertests: SessionRestoreTestChromeOS.RestoreAppsV1 SessionRestoreTestChromeOS.RestoreBrowserWindows SessionRestoreTestChromeOS.RestoreMaximized Sample failure output: SessionRestoreTestChromeOS.RestoreBrowserWindows (run #1): [ RUN ] SessionRestoreTestChromeOS.RestoreBrowserWindows [7235:7235:0724/051700:WARNING:chrome_browser_main_chromeos.cc(275)] Running as stub user with profile dir: test-user Xlib: extension "RANDR" missing on display ":9". [7235:7377:0724/051700:WARNING:local_extension_cache.cc(199)] Extensions will not be installed from update URLs until /var/cache/external_cache/.initialized exists. ../../chrome/browser/sessions/session_restore_browsertest_chromeos.cc:118: Failure Value of: total_count Actual: 1 Expected: 2u Which is: 2 [7235:7331:0724/051701:WARNING:raw_channel_posix.cc(214)] recvmsg: Connection reset by peer [ FAILED ] SessionRestoreTestChromeOS.RestoreBrowserWindows, where TypeParam = and GetParam() = (827 ms) > Removed InProcessBrowserTest::CleanUpOnMainThread() > > Changed all instances of superfluous InProcessBrowserTest::CleanUpOnMainThread() > API to use BrowserTestBase::TearDownOnMainThread() instead. > > BUG=381181 > TBR=rockot@chromium.org,sky@chromium.org,nkostylev@chromium.org > > Review URL: https://codereview.chromium.org/366813007 TBR=atwilson@chromium.org Review URL: https://codereview.chromium.org/415133002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285278 0039d316-1c4b-4281-b951-d872f2087c98
* Removed InProcessBrowserTest::CleanUpOnMainThread()atwilson@chromium.org2014-07-241-1/+1
| | | | | | | | | | | | Changed all instances of superfluous InProcessBrowserTest::CleanUpOnMainThread() API to use BrowserTestBase::TearDownOnMainThread() instead. BUG=381181 TBR=rockot@chromium.org,sky@chromium.org,nkostylev@chromium.org Review URL: https://codereview.chromium.org/366813007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285173 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of some uses of CreateIntegerValueestade@chromium.org2014-07-221-2/+2
| | | | | | | | BUG=160586 Review URL: https://codereview.chromium.org/385263004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284600 0039d316-1c4b-4281-b951-d872f2087c98
* Enables permission bubbles to remain visible during fullscreen on Mac.leng@chromium.org2014-07-211-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | Adds IsVisible() function to PermissionBubbleView so that the browser window knows if it is currently being shown. It's added to the base class, rather than just the cocoa implementation, because similar functionality will likely be used for views in the future. Adds alwaysShowDropdown property to the PresentationModeController. When set to YES, it disables hiding of the dropdown - toolbar and tab strip. Also adds a hack to ensure the UI is drawn correctly when entering fullscreen mode. Specifically, for the duration of the animation, the top-level view for the browser window has setWantsLayer set to YES. Without this, tabStripView is not rendered into the destination frame for the animation. (It is a sibling of the content view, not a subview, and I believe that the non-layer-based render path bypasses it when the animation begins.) I could not come up with any other mechanism to fix this, and without it, fullscreen looks quite bad - the toolbar displays properly, but the tab strip is missing. BUG=384260 Review URL: https://codereview.chromium.org/390503003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284438 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of the rest of CreateStringValueestade@chromium.org2014-07-181-1/+1
| | | | | | | | BUG=160586 Review URL: https://codereview.chromium.org/388963002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284201 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate CreateBooleanValue from test filesestade@chromium.org2014-07-171-1/+1
| | | | | | | | BUG=160586 Review URL: https://codereview.chromium.org/397793002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283665 0039d316-1c4b-4281-b951-d872f2087c98
* MacViews: Refactor DownloadShelf paint functions to remove views dependencytapted@chromium.org2014-07-162-60/+37
| | | | | | | | | | | | | | | | | | We want to build Chrome with toolkit-views available, but port things gradually. This change converts a View* argument into a callback argument that calls the required member function on View. This lets us get rid of eleven #ifdef guards which would otherwise need to change (now, and again once the download shelf is ported to use views on Mac). BUG=390755 Review URL: https://codereview.chromium.org/377223002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283330 0039d316-1c4b-4281-b951-d872f2087c98
* Stamp out CreateStringValue in chrome/estade@chromium.org2014-07-091-1/+1
| | | | | | | | | | | Gets rid of the rest of CreateStringValue in non-test code in src/chrome/ BUG=160586 TBR=jar@chromium.org,dconnelly@chromium.org Review URL: https://codereview.chromium.org/372103006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281939 0039d316-1c4b-4281-b951-d872f2087c98
* Windows: Add an "Open in Adobe Reader" menu item for PDF files in the ↵thestig@chromium.org2014-07-038-44/+258
| | | | | | | | | | download shelf. BUG=370746 Review URL: https://codereview.chromium.org/324593004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281172 0039d316-1c4b-4281-b951-d872f2087c98
* Port HistoryService::GetVisibleVisitCountToHost to CancelableTaskTrackersdefresne@chromium.org2014-07-012-6/+9
| | | | | | | | | | | | | | | | | | | | Callback no longer receive a HistoryService::Handle, but instead client code should use the returned base::CancelableTaskTracker::TaskId to cancel an individual task. Simplify implementation of BrowserFeatureExtractor as all the methods from HistoryService that are called uses base::CancelableTaskTracker by removing the mapping from HistoryService::Handle to request and using a scoped_ptr to deal with the lifetime of the ClientPhishingRequest object. BUG=371818 TBR=jochen Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280110 Review URL: https://codereview.chromium.org/351553004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280796 0039d316-1c4b-4281-b951-d872f2087c98
* Make ".html" always the default extension for save-as-html feature.kinaba@chromium.org2014-06-282-7/+2
| | | | | | | | | | | | | | | | Two changes are involved. One is that putting ".html" in front of ".htm" in the extension list of the file dialog. This way, Chrome OS file dialog automatically corrects the extension to ".html" when the user switched mhtml/html type selector. The other change is to set the default extension to ".html" on Windows, where we have been using ".htm". BUG=384204 Review URL: https://codereview.chromium.org/330853003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280513 0039d316-1c4b-4281-b951-d872f2087c98
* Extensions: Split extensions utility IPC messages into its own file.thestig@chromium.org2014-06-271-2/+7
| | | | | | | | | | Disable extensions code on Android so they do not use these messages. BUG=349436 Review URL: https://codereview.chromium.org/345693002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280242 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of Port HistoryService::GetVisibleVisitCountToHost to ↵leng@chromium.org2014-06-262-9/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | CancelableTaskTracker (https://codereview.chromium.org/351553004/) Reason for revert: Failures on Linux ASAN LSan Tests (2): OnPhishingDetectionDoneDisabled OnPhishingDetectionDoneMultiplePings OnPhishingDetectionDoneNotPhishing OnPhishingDetectionDoneShowInterstitia http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/4236 Original issue's description: > Port HistoryService::GetVisibleVisitCountToHost to CancelableTaskTracker > > Callback no longer receive a HistoryService::Handle, but instead client > code should use the returned base::CancelableTaskTracker::TaskId to > cancel an individual task. > > Simplify implementation of BrowserFeatureExtractor as all the methods > from HistoryService that are called uses base::CancelableTaskTracker by > removing the mapping from HistoryService::Handle to request and using a > scoped_ptr to deal with the lifetime of the ClientPhishingRequest object. > > BUG=371818 > TBR=jochen > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280110 TBR=blundell@chromium.org,jochen@chromium.org,bryner@chromium.org,noelutz@chromium.org,sdefresne@chromium.org NOTREECHECKS=true NOTRY=true BUG=371818 Review URL: https://codereview.chromium.org/351363002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280137 0039d316-1c4b-4281-b951-d872f2087c98
* Port HistoryService::GetVisibleVisitCountToHost to CancelableTaskTrackersdefresne@chromium.org2014-06-262-6/+9
| | | | | | | | | | | | | | | | | | Callback no longer receive a HistoryService::Handle, but instead client code should use the returned base::CancelableTaskTracker::TaskId to cancel an individual task. Simplify implementation of BrowserFeatureExtractor as all the methods from HistoryService that are called uses base::CancelableTaskTracker by removing the mapping from HistoryService::Handle to request and using a scoped_ptr to deal with the lifetime of the ClientPhishingRequest object. BUG=371818 TBR=jochen Review URL: https://codereview.chromium.org/351553004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280110 0039d316-1c4b-4281-b951-d872f2087c98
* Add mime type information to the download databaseohrn@opera.com2014-06-123-4/+20
| | | | | | | | BUG=328382 Review URL: https://codereview.chromium.org/319703002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276775 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Use PostTaskAndReplyWithResults instead of passing callbacks around ↵thestig@chromium.org2014-06-122-22/+35
| | | | | | | | in downloads code. Review URL: https://codereview.chromium.org/324883006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276613 0039d316-1c4b-4281-b951-d872f2087c98
* Add a browsertest for the feedback service, to serve as a basis for more ↵felt@chromium.org2014-06-101-0/+57
| | | | | | | | | | extensive testing for Issue 146003005. BUG=NONE Review URL: https://codereview.chromium.org/197883010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276017 0039d316-1c4b-4281-b951-d872f2087c98
* Move about://-related constants from //content to //urlblundell@chromium.org2014-06-102-2/+2
| | | | | | | | | | | kAboutScheme and kAboutBlankURL are used in code shared by iOS, and are general enough to live in //url instead of //content. TBR=yoz,benm Review URL: https://codereview.chromium.org/325443002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275988 0039d316-1c4b-4281-b951-d872f2087c98
* Consolidate SDK forwards in sdk_forward_declarations.h.avi@chromium.org2014-06-071-37/+1
| | | | | | | | | | BUG=none TEST=none TBR=ben@chromium.org Review URL: https://codereview.chromium.org/322623002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275578 0039d316-1c4b-4281-b951-d872f2087c98
* Add fade eliding for Views Labels; related cleanup.msw@chromium.org2014-06-051-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | Support fade eliding behavior for Views Label[Button]. (needed for forthcoming LabelButton conversions, etc.) Remove unused head fading behavior, refine fade tail. (fades the end opposite the text's horizontal alignment) (centered fading uses content directionality alignment) (RenderText fades both ends of explicitly centered text) Consolidate gfx::ElideBehavior and Label::ElideBehavior. Nix Canvas::TruncateFadeMode and RenderText fade_[head|tail]. Add ELIDE_EMAIL and FADE_TAIL enum values, hide ElideEmail. Consolidate and rename Canvas::DrawFadedString functions. Refine Examples, cleanup enum and function uses. BUG=155363,249938 TEST=No apparent eliding behavior changes or regressions. R=sky@chromium.org Review URL: https://codereview.chromium.org/312233003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275265 0039d316-1c4b-4281-b951-d872f2087c98
* Android: Eliminate alarms, downloads, and omnibox extensions code.thestig@chromium.org2014-06-056-16/+30
| | | | | | | | BUG=305852 Review URL: https://codereview.chromium.org/300573005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275062 0039d316-1c4b-4281-b951-d872f2087c98
* Change all component_strings references to be to components_stringsblundell@chromium.org2014-05-281-1/+1
| | | | | | | | | | | | | | | | | There is an inconsistency wherein some references to components strings are "components_strings" (e.g., components_strings.grd), but some are "component_strings" (e.g., the XTB and pakfiles). This CL changes all references to "component_strings" to be to "components_strings": - XTB files - pakfiles - generated header file TBR=thakis Review URL: https://codereview.chromium.org/307563003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273224 0039d316-1c4b-4281-b951-d872f2087c98
* Session restore shouldn't care about profile home pages.marja@chromium.org2014-05-221-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The logic where we treated an empty URL as home page is outdated. This CL contains the following additional fixes: 1) Disallow using empty URLs to denote anything (home page, new tab page...) and force the callers of chrome::Navigate to specify which URL they want to open. Using empty URLs was hiding bugs (see below). 2) Fixed StartupBrowserCreatorTest.UpdateWithTwoProfiles and ProfilesWithoutPagesNotLaunched so that they don't work by accident (about:blank used to be the home page - it wasn't restoring the previous session, but launching the home page). 3) There was some code passing GURL("new_tab_page") around, and comparing against that. But that's an invalid URL, so GURL will just make it empty, and the result is not what is expected. (E.g,. GURL("foo") == GURL("new_tab_page")). 4) Fixed other places which were passing GURL("something_invalid") around and pretending it's something meaningful. It was just a coincidence that nothing was broken. BUG=371852 R=sky@chromium.org Review URL: https://codereview.chromium.org/292713003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272182 0039d316-1c4b-4281-b951-d872f2087c98
* infobars: Componentize ConfirmInfoBarDelegate.tfarina@chromium.org2014-05-222-2/+2
| | | | | | | | | | | | | | | | | | Changes: 1- Change it to use ui_strings.h 2- Use IDS_APP_OK and IDS_APP_CANCEL from ui_strings. 3- Move to components/infobars/core from chrome/browser/infobars (done with tools/git/move_source_file.py). BUG=373234 TEST=chrome still links and run fine. R=droger@chromium.org, pkasting@chromium.org TBR=ben # for trivial chrome/ changes Review URL: https://codereview.chromium.org/289083004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272036 0039d316-1c4b-4281-b951-d872f2087c98
* [Downloads] Ask DownloadHistory if a download was from history.asanka@chromium.org2014-05-1511-109/+444
| | | | | | | | | | | | | | | | | Observers of downloads currently assume that any download that is created in the IN_PROGRESS state must be a new download, while all others were restored from history. Pending changes to how downloads are created in response to failed requests will mean that this assumption will no longer hold. This CL adds a WasRestoredFromHistory() method to DownloadHistory which determines whether a given download was restored from history. BUG=7648 Review URL: https://codereview.chromium.org/230103002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270749 0039d316-1c4b-4281-b951-d872f2087c98
* components: Extract pref_registry component out of user_prefs.tfarina@chromium.org2014-05-152-2/+2
| | | | | | | | | | | | | | | The reason for doing this is that user_prefs depends on content_browser, which brings a lot of extra dependencies that takes a lot of time to build (yeah, I'm looking at you Blink and V8) and bookmarks is one of the targets that should not depend on content. BUG=359565 TEST=green trybots R=blundell@chromium.org, sky@chromium.org, yoz@chromium.org Review URL: https://codereview.chromium.org/271793003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270722 0039d316-1c4b-4281-b951-d872f2087c98
* Support saving a web page as a plain HTMLhashimoto@chromium.org2014-05-152-95/+100
| | | | | | | | | | Merge ShouldSaveAsMHTML() branch and can_save_as_complete_ branch. BUG=369875 Review URL: https://codereview.chromium.org/269413002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270640 0039d316-1c4b-4281-b951-d872f2087c98
* s/precendence/precedence/derat@chromium.org2014-05-151-1/+1
| | | | | | | | | | | | | "precedence" is misspelled as "precendence" in the docs for the chrome.power API. Fix it there as well as several other places where it occurs. BUG=none TBR=sky@chromium.org,brettw@chromium.org Review URL: https://codereview.chromium.org/283113002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270539 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup CanDownload WebContentsDelegate APIfsamuel@chromium.org2014-05-135-16/+9
| | | | | | | | | | | | | | It seems we were passing an opaque request ID in WebContentsDelegate::CanDownload that wasn't used anywhere. Instead, for <webview>, we would simply like the URL that generated the download request. This CL simplifies the API and reduces cruft and code complexity BUG=364141, 330264 TBR=sgurun@chromium.org Review URL: https://codereview.chromium.org/286543002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270242 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-01 01:47:25 +0000