summaryrefslogtreecommitdiffstats
path: root/chrome/browser/download
Commit message (Collapse)AuthorAgeFilesLines
* Re-enable save page ui tests. I could not get these to fail. I will watch ↵estade@chromium.org2009-07-141-14/+3
| | | | | | | | | | the tree after committing. TBR=evan Review URL: http://codereview.chromium.org/149595 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20670 0039d316-1c4b-4281-b951-d872f2087c98
* Make DownloadShelf a pure interface.estade@chromium.org2009-07-142-28/+2
| | | | | | | | | http://crbug.com/15474 TEST=none Review URL: http://codereview.chromium.org/149594 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20668 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable previously flaky download ui tests. I can't reproduce the ↵estade@chromium.org2009-07-131-21/+5
| | | | | | | | | | failures. Will watch tree after commit. TBR=evan Review URL: http://codereview.chromium.org/155449 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20575 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r20553.thestig@chromium.org2009-07-132-4/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20554 0039d316-1c4b-4281-b951-d872f2087c98
* Additional svn ignores for native_client and Makefile.thestig@chromium.org2009-07-132-0/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20553 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure proper paths when saving pages with no title.paul@chromium.org2009-07-103-35/+100
| | | | | | | | | | | | | | | | | | | When saving a page with no title, such as a text file, attempt to use a sane value for the save name by retrieving the last component of the URL (if one exists). This prevents the case where a page http://www.foo.com/a/path/name.txt is saved as file "http www" with extension type "foo.com a path name.txt". This change also makes the SavePackage code a little more flexible and simpler to test. BUG=none TEST=Covered by unittest. Review URL: http://codereview.chromium.org/155266 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20432 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Themes: Set bg/text colors for the download shelf.erg@google.com2009-07-101-0/+2
| | | | | | | | (This does not change the button image.) Review URL: http://codereview.chromium.org/155365 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20403 0039d316-1c4b-4281-b951-d872f2087c98
* Sprinkle some defensiveness into the UI tests so that they don't explode if ↵stuartmorgan@chromium.org2009-07-072-3/+8
| | | | | | | | | | the proxy doesn't respond (e.g., due to a timeout). BUG=none TEST=Hopefully the Mac valgrind bots will more reliably run all their tests (although there are likely more issues like this lurking). Review URL: http://codereview.chromium.org/149281 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20096 0039d316-1c4b-4281-b951-d872f2087c98
* Move extension install to after .crx download completesrafaelw@chromium.org2009-07-071-4/+1
| | | | | | | | | | | This was resulting in some situations where we attempted to unpack the .crx while its file was still in use by the download manager. BUG=15881 R=mpcomplete Review URL: http://codereview.chromium.org/149161 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20083 0039d316-1c4b-4281-b951-d872f2087c98
* Make default extension for downloading html "html" rather than "htm" on ↵estade@chromium.org2009-07-073-15/+39
| | | | | | | | | | | non-windows platforms. BUG= http://crbug.com/15999 TEST=un-disable and run save page uitest on linux (it's only disabled because it's flaky, for some unrelated reason) Review URL: http://codereview.chromium.org/155095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19997 0039d316-1c4b-4281-b951-d872f2087c98
* Do some refactoring of renderer_host.brettw@chromium.org2009-07-062-1/+2
| | | | | | | | | | | | | | | | | | | This removes the last dependency on tab_contents from the renderer_host code and into the RenderViewHostDelegate. Some of the tests depended on tab_contents, so I moved to a new directory with the tab_contents include allowed via DEPS. Now DEPS can enforce that no additional tab_contents includes are added to renderer_host. RenderViewHost delegate is now pure virtual. After spending a while *again* figuring out why my code didn't work, only to find it was because the default implementation of a function was getting called instead of the real one, I decided to make this pure virtual. It is implemented by TabContents, which implements basically everything, and two other places that implement less. Only two lists of duplicate functions seems not too bad, although long-term it would be nice if this delegate was somehow more succinct. Review URL: http://codereview.chromium.org/155071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19982 0039d316-1c4b-4281-b951-d872f2087c98
* Enable opening downloads from the Mac download shelf.paul@chromium.org2009-07-011-10/+1
| | | | | | | | | | | Also added a stub for an unused method on Canvas in order to link. TEST=Selecting "Open" from the shelf menu will open a download BUG=15661 Review URL: http://codereview.chromium.org/150079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19691 0039d316-1c4b-4281-b951-d872f2087c98
* Enable "Save As" on Mac.paul@chromium.org2009-06-301-5/+0
| | | | | | | | | TEST=Right clicking an image and choosing "Save As" now works. BUG=15638 Review URL: http://codereview.chromium.org/151042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19565 0039d316-1c4b-4281-b951-d872f2087c98
* Allow extension extensions to be case-insensitive.avi@chromium.org2009-06-291-22/+5
| | | | | | | | | BUG=none TEST=try to load an extension with a capital letter or two in the extension's extension. It should load. Review URL: http://codereview.chromium.org/147017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19520 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for reverted cl http://codereview.chromium.org/147123davemoore@chromium.org2009-06-271-0/+1
| | | | | | | | | | | | | A recent change broke the load times. It also revealed some deficiencies. This adds a new time marker for when a load is committed, which is a more interesting value than the start of the load (which we still keep). Also, the first layout time wasn't an interesting time to keep, instead we keep the time of the first paint. The histograms were modified to use the new values when appropriate. Review URL: http://codereview.chromium.org/149099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19465 0039d316-1c4b-4281-b951-d872f2087c98
* The following 3 ui tests have been flaky on Linux.jshin@chromium.org2009-06-262-4/+12
| | | | | | | | | | | | | | | | | DownloadTest.DownloadMimeType DownlaodTest.ContentDisposition SavePageTest.FilenameFromPageTitle BUG=15416,15244 http://crbug.com/15416 http://crbug.com/15244 TEST=Linux UI test bots do not fail due to these tests TBR=estade Original review: http://codereview.chromium.org/147179 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19334 0039d316-1c4b-4281-b951-d872f2087c98
* Update WebKit to 45111 and Skia to 239amanda@chromium.org2009-06-251-1/+1
| | | | | | Review URL: http://codereview.chromium.org/147121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19211 0039d316-1c4b-4281-b951-d872f2087c98
* Disable PerWindowShelf test on Linux because it's flakyjshin@chromium.org2009-06-241-1/+4
| | | | | | | | | BUG=15211 (http://crbug.com/15211 ) TEST=PerWindowShelf test does not show up as a failure on Linux bot TBR=thakis Review URL: http://codereview.chromium.org/146091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19135 0039d316-1c4b-4281-b951-d872f2087c98
* Disable some UI tests on Linux due to crashiness and/or flakiness:mpcomplete@google.com2009-06-192-4/+23
| | | | | | | | | | | | | - SavePageTest.SaveHTMLOnly - SavePageTest.SaveCompleteHTML - DownloadTest.UnknownSize - DownloadTest.IncognitoDownload BUG=14746,14755 TEST=no Review URL: http://codereview.chromium.org/139006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18857 0039d316-1c4b-4281-b951-d872f2087c98
* Initial download shelf on OS X.thakis@chromium.org2009-06-182-5/+5
| | | | | | | | | | | | | | | | | | | This has lots of missing stuff (e.g. a custom download item view that shows download progress, the popup is the same for in-progress and completed downloads, no animation, everything looks ugly, the info bubble overlaps the shelf when it's visible, no "open download manager page" link, etc), but the basic functionality is hooked up: The shelf appears when files are downloaded, and something ugly is added to the shelf for each download. The popup's "Reveral in Finder" even works. The shelf is per-window as it should be. BUG=12500 TEST=Download something and check the shelf appears. Click the close button and make sure it disappears again. Review URL: http://codereview.chromium.org/93129 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18757 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the windows specific bits from login_prompt.cc and make ↵erg@chromium.org2009-06-171-1/+1
| | | | | | | | | | LoginPromptWin conform to a general cross platform interface. (Also tightens the interface for ConstrainedWindows a bit more) Review URL: http://codereview.chromium.org/125217 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18623 0039d316-1c4b-4281-b951-d872f2087c98
* Add a UI test for downloading in incognito mode.paul@chromium.org2009-06-161-1/+43
| | | | | | | | | | | | | This test opens an incognito window and verifies that downloads work and that closing the incognito window does not crash (see bug http://crbug.com/13983). TEST=Test should run and not crash. BUG=none Review URL: http://codereview.chromium.org/126181 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18534 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce header dependencies in chrome/browser/phajdan.jr@chromium.org2009-06-169-18/+16
| | | | | | | | In my scan of headers I got up to browser/gtk/ Review URL: http://codereview.chromium.org/126131 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18500 0039d316-1c4b-4281-b951-d872f2087c98
* Revert thakis's changes to download_file.cc from r17595.estade@chromium.org2009-06-121-15/+8
| | | | | | | | BUG=13991 Review URL: http://codereview.chromium.org/126066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18307 0039d316-1c4b-4281-b951-d872f2087c98
* Issue 3791: SavePageTest.* is crapidanan@chromium.org2009-06-111-14/+20
| | | | | | | | | | | | | Modifying flaky test so that it waits for a file to stop being written rather than starts existing. Otherwise the compare check fails some times. I know Windows has a more efficient API to do this but for the sake of multiplatform compatibility, the solution is completely generic. BUG=3791 Review URL: http://codereview.chromium.org/123026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18187 0039d316-1c4b-4281-b951-d872f2087c98
* Save as dialog should show html filesmhm@chromium.org2009-06-111-0/+2
| | | | | | | | | | | | Currently "htm" files are hardcoded, that is the reason why its only seen. Adding "html" to the vector extension would fix this issue. BUG=13429 (http://crbug.com/13429) TEST=Can now see html in the save file dialog. Review URL: http://codereview.chromium.org/119409 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18119 0039d316-1c4b-4281-b951-d872f2087c98
* Disable extensions in incognito mode.mpcomplete@google.com2009-06-111-2/+2
| | | | | | | | | | | Add a browsertest to make sure we don't crash with an incognito window open. Had to finagle utility_process_host to make it work in a browsertest. BUG=12326 TEST=none Review URL: http://codereview.chromium.org/118476 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18116 0039d316-1c4b-4281-b951-d872f2087c98
* Implement OpenItem on the Mac, and have the download manager call it when ↵stuartmorgan@chromium.org2009-06-101-1/+6
| | | | | | | | | | clicking a file link. BUG=13552 TEST=Clicking a file link in the download manager should open the file. Review URL: http://codereview.chromium.org/119398 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18061 0039d316-1c4b-4281-b951-d872f2087c98
* Don't prompt before installing a Theme, move existing prompt so that users ↵glen@chromium.org2009-06-051-13/+1
| | | | | | | | | | | | aren't prompted twice in the case when they have extensions disabled. Theme installation confirmation will be done through an infobar (allowing you to preview a lot of themes quickly without dealing with dialogs) - see CL 119235. BUG=none TEST=Install a theme, verify that you don't get prompted. Install an extension and verify that you do get prompted. Review URL: http://codereview.chromium.org/119232 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17755 0039d316-1c4b-4281-b951-d872f2087c98
* Move download shelf from per-tab to per-window. Also disable auto-hiding ofthakis@chromium.org2009-06-046-54/+91
| | | | | | | | | | | | | | the shelf. BUG=9025 TEST=Download file in one tab, open new tab, and check that download shelf is still open. Also try the shelf's close button and the "show all downloads" link. When saving a file, the download animation should not show up. Review URL: http://codereview.chromium.org/115740 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17595 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce header dependencies in base/phajdan.jr@chromium.org2009-06-031-0/+1
| | | | | | | | Also adds more explicit #includes for needed things. Review URL: http://codereview.chromium.org/118162 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17479 0039d316-1c4b-4281-b951-d872f2087c98
* Allow themes to be installed without any commandline flag, still require ↵glen@chromium.org2009-05-291-28/+9
| | | | | | | | | | | flag for Extensions. Expand themes unittests. BUG=12205,12231 TEST=Without any flags, try installing an extension and a theme. The extension should fail and the theme should succeed. Attempts to install a theme with extension components in the manifest should similarly result in failure. Review URL: http://codereview.chromium.org/115798 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17240 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: call xdg-open on downloaded files to open them.estade@chromium.org2009-05-282-19/+13
| | | | | | | | BUG=12299 TEST=1) right click/save as on some image. Clicking on the download item's filename area should launch it in some image viewer (assuming xdg-open works for you---as it happens, ubuntu broke xdg-open for desktops that are not gnome, kde, or xfce). 2) Download a large file. Click on the download item before it is finished. The text should change to "opening in..." and the checkbox in the dropdown menu should show as checked. 3) completed downloads should have the "open when finished" menu item replaced by the "open" menu item. Selecting that should also open the download. Review URL: http://codereview.chromium.org/112064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17106 0039d316-1c4b-4281-b951-d872f2087c98
* Make automation proxy objects to ref_counted. That allows to process async ↵stoyan@chromium.org2009-05-282-12/+12
| | | | | | | | | | | notifications directly in channel background thread. Add support for listener-less ChannelProxy. BUG=none TEST=none Review URL: http://codereview.chromium.org/113722 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17093 0039d316-1c4b-4281-b951-d872f2087c98
* Generalize the code that checks for user actions in the render view to work ↵estade@chromium.org2009-05-281-2/+7
| | | | | | | | | | | | on all platforms. Also, on linux, assume the user denies every download which we would have prompted him with. BUG=12709 TEST=windows is still carpet-bombing resilient and linux can download from the same page more than once. Review URL: http://codereview.chromium.org/113925 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17089 0039d316-1c4b-4281-b951-d872f2087c98
* Dangerous download dialog for linux.estade@chromium.org2009-05-273-13/+27
| | | | | | | | | BUG=11780 TEST=go to cygwin.com, click "install or update now". The download shelf should appear with a dangerous download dialog, which should animate properly and without undue jank. Clicking "cancel" should delete the item and hide the shelf (since it's the only thing in the shelf). Clicking "save" should make it become a normal download item. Review URL: http://codereview.chromium.org/113920 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17041 0039d316-1c4b-4281-b951-d872f2087c98
* Gets a couple of download classes to compile on linux. Updates thesky@chromium.org2009-05-262-10/+17
| | | | | | | | | | | views build so that we only include the gtk classes we need. BUG=none TEST=none Review URL: http://codereview.chromium.org/115788 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16899 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused code from ExtensionsService.mpcomplete@google.com2009-05-261-1/+1
| | | | | | | | Move extension.* from browser to common, so it can be included by the utility process. Review URL: http://codereview.chromium.org/115716 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16880 0039d316-1c4b-4281-b951-d872f2087c98
* Remove one more notimpl.estade@chromium.org2009-05-211-4/+3
| | | | | | | | BUG=12052 Review URL: http://codereview.chromium.org/113713 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16628 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure proper extension when saving an HTML page.estade@chromium.org2009-05-194-24/+72
| | | | | | | | | | | | | | | | | | | | | | | | | | | When an HTML page has a title, it is used as the suggested file name in saving the page. Then the file extension is guessed from the suggested file name. This results in a wrong extension if the title contains a period ".". This the source of Bug 10581. Merely setting ignore_suggested_ext to true in win_util::SaveFileAsWithFilter is not a good fix, because then we have an issue in saving a page without a title, where the extension can be correctly derived from the suggested file name. This change solves the issue by appending ".htm" to the suggested file name if the page content type is HTML and the suggested file name doesn't have a proper extension. BUG=10581 -------- patch by yuzo@google.com review here: <http://codereview.chromium.org/115235> git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16355 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Add download shelf first show animation.estade@chromium.org2009-05-151-0/+18
| | | | | | | | http://crbug.com/8631 Review URL: http://codereview.chromium.org/113428 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16196 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Take download shelf and infobar close animations into account during ↵estade@chromium.org2009-05-152-1/+4
| | | | | | | | | | render view sizing. http://crbug.com/11080 Review URL: http://codereview.chromium.org/113322 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16193 0039d316-1c4b-4281-b951-d872f2087c98
* ChromeCanvas->gfx::Canvasben@chromium.org2009-05-152-5/+5
| | | | | | | | | | | Rename files too. TBR=brettw http://crbug.com/11387 Review URL: http://codereview.chromium.org/113443 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16148 0039d316-1c4b-4281-b951-d872f2087c98
* This CL updates chrome to the latest version of skia, retrieved via DEPS, andsenorblanco@chromium.org2009-05-131-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | placed in third_party. All relevant skia changes (for all 3 platforms) have been upstreamed. Most of this CL is mind-numbingly repetitive. Things of interest are: skia.gyp (now points at third_party versions), DEPS, and SkUserConfig.h. stdint.h: Skia now requires C99 integer types, which MSVC doesn't support natively. I have put typedefs in config/win/stdint.h. Note that the new version of skia appears to render rects whose coordinates are "backwards" (ie., x2 < x1 or y2 < y1), which were formerly culled. There were a couple obvious instances of this in the code which I fixed, but there may be more. There were ~35 layout test failures due to minor pixel differences which I rebaselined on Windows and Linux, and 8 genuine failures related to masks and stroked text, which I have put in text_expectations.txt and assigned to myself. (There was another change which broke ~1700 tests on each platform, but I put that change behind an #ifdef for now). R=brettw Review URL: http://codereview.chromium.org/65012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15949 0039d316-1c4b-4281-b951-d872f2087c98
* Download progress and complete animation on linux.estade@chromium.org2009-05-112-20/+31
| | | | | | Review URL: http://codereview.chromium.org/113179 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15798 0039d316-1c4b-4281-b951-d872f2087c98
* Move win_util.h from common to app.ben@chromium.org2009-05-084-8/+2
| | | | | | | | http://crbug.com/11387 Review URL: http://codereview.chromium.org/113169 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15694 0039d316-1c4b-4281-b951-d872f2087c98
* Move color_utils, text_elider, drag_utils, accessibility_types, ↵ben@chromium.org2009-05-081-1/+1
| | | | | | | | | standard_layout to new locations in app/ and views/ http://crbug.com/11387 Review URL: http://codereview.chromium.org/113143 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15687 0039d316-1c4b-4281-b951-d872f2087c98
* Various popup UI fixes:pkasting@chromium.org2009-05-081-4/+3
| | | | | | | | | | | | | * Remove "show popup notification" option, pref, and all associated machinery. * Toggling whitelisting on for a site no longer hides the "manage" button. * Toggling whitelisting off for a site re-blocks (not closes) its popups, and does not hide the "manage" button. Also rips the whitelist hooks out of TabContents in preparation for getting the whitelist values directly from the BlockedPopupContainer, since there was no reason to plumb everything through TabContents. BUG=11440 Review URL: http://codereview.chromium.org/115112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15670 0039d316-1c4b-4281-b951-d872f2087c98
* Move src/chrome/views to src/views. RS=darin http://crbug.com/11387ben@chromium.org2009-05-084-8/+8
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15604 0039d316-1c4b-4281-b951-d872f2087c98
* Skip the download shelf altogether for extension downloads. The current UI ↵erikkay@google.com2009-05-062-17/+35
| | | | | | | | | looks pretty weird with it. This won't work great for larger extensions that take more than a couple of seconds to download, but we'll address that with extension specific UI when the DL manager is refactored. TEST=download a crx file, verify that it installs with no shelf. download another type of file, verify that it uses the shelf properly. Review URL: http://codereview.chromium.org/113038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15450 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-01 04:29:28 +0000