summaryrefslogtreecommitdiffstats
path: root/chrome/browser/download
Commit message (Collapse)AuthorAgeFilesLines
* Move RTL related functions from app/l10n_util to base/i18n/rtlben@chromium.org2010-03-202-9/+11
| | | | | | | | | | TBR=darin BUG=none TEST=none Review URL: http://codereview.chromium.org/1073005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42182 0039d316-1c4b-4281-b951-d872f2087c98
* Resubmit 1025006: Refactor app-related manifest propertiesaa@chromium.org2010-03-191-1/+1
| | | | | | | | so that they don't include the name 'app'. TBR=erikkay@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42146 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 42091 - Refactor apprelated manifest properties so that they don'tandybons@chromium.org2010-03-191-1/+1
| | | | | | | | | | | | | | | include the name 'app'. I think these will be useful for normal extensions, too. Also extract an ExtensionExtent class out of Extension. I think this will be useful for passing by value to the IO thread. Review URL: http://codereview.chromium.org/1025006 TBR=aa@chromium.org Review URL: http://codereview.chromium.org/1120005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42104 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor app-related manifest properties so that they don'taa@chromium.org2010-03-191-1/+1
| | | | | | | | | | | | include the name 'app'. I think these will be useful for normal extensions, too. Also extract an ExtensionExtent class out of Extension. I think this will be useful for passing by value to the IO thread. Review URL: http://codereview.chromium.org/1025006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42091 0039d316-1c4b-4281-b951-d872f2087c98
* Win7: Show download progress in superbar.mhm@chromium.org2010-03-191-1/+38
| | | | | | | | | | | Use ITaskbarList3 interface to show progress bar when downloading items. BUG=8039 TEST=Download a couple of files, notice it progress. Look at the screenshot in the main issue. Review URL: http://codereview.chromium.org/944001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42066 0039d316-1c4b-4281-b951-d872f2087c98
* Force an app's orgin to be the origin of the URL the crx isaa@chromium.org2010-03-181-0/+1
| | | | | | | | | | | | downloaded from. Added machinery to be able to switch this behavior off, so that in the future, we can turn it off for the gallery. BUG=32361 Review URL: http://codereview.chromium.org/890002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41994 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the problem that a Save As dialog pops up on drag-out when "Ask where to ↵jianli@chromium.org2010-03-181-4/+7
| | | | | | | | | | | save each file before downloading" option is checked. BUG=none TEST=none Review URL: http://codereview.chromium.org/1050006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41962 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: implement extension bookmark manager drag api.estade@chromium.org2010-03-181-1/+1
| | | | | | | | | | | Also, cross-platform: eschew RenderViewHostDelegate:BookmarkDrag::DragData type in favor of BookmarkDragData. BUG=37702 TEST=manual Review URL: http://codereview.chromium.org/1029004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41959 0039d316-1c4b-4281-b951-d872f2087c98
* Move some more files to toplevel gfx dir.ben@chromium.org2010-03-172-2/+2
| | | | | | | | | TBR=darin BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41812 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Make automation framework more solid by making sure thatphajdan.jr@chromium.org2010-03-161-4/+4
| | | | | | | | | | | | | | | | | | | important return values are not ignored. The macro used here, WARN_UNUSED_RESULT, takes effect only for GCC, but that's enough since we have bots for all platforms. Adding these warnings already detected some cases where a return value was ignored. In some of them the test was trying to get the information about success "some other way", in some it could sometimes confuse test failure with test success. TEST=ui_tests BUG=none Review URL: http://codereview.chromium.org/948002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41696 0039d316-1c4b-4281-b951-d872f2087c98
* Move base/gfx contents to gfx/ben@chromium.org2010-03-141-1/+1
| | | | | | | | | TBR=darin BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41559 0039d316-1c4b-4281-b951-d872f2087c98
* Don't fail when default download folder doesn't existkinuko@chromium.org2010-03-131-2/+4
| | | | | | | | | BUG=37836 TEST=as described in the bug Review URL: http://codereview.chromium.org/871001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41509 0039d316-1c4b-4281-b951-d872f2087c98
* Mechanical refactor of CrxInstaller signatures. This will makeaa@chromium.org2010-03-121-20/+15
| | | | | | | | | it easier to add additional configuration features to CrxInstaller. Review URL: http://codereview.chromium.org/875003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41503 0039d316-1c4b-4281-b951-d872f2087c98
* win: string_util.h -> utf_string_conversions.h fix.jhawkins@google.com2010-03-111-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/830002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41292 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Add more NULL-checks to UI tests that were lacking them to avoid ↵phajdan.jr@chromium.org2010-03-112-8/+9
| | | | | | | | | | | crashiness. TEST=none BUG=none Review URL: http://codereview.chromium.org/841002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41273 0039d316-1c4b-4281-b951-d872f2087c98
* Start a download in the user's download directory to lower rename failure ↵kinuko@chromium.org2010-03-094-22/+61
| | | | | | | | | | | possibilities BUG=8737 TEST=Check 'Ask where to save each file before downloading' true in the 'Under the Hood' preference and start a download. A temporary file org.chromium.XXXXXX or com.google.chrome.XXXXXX should appear in the user's download directory (e.g. ~/Downloads). After selecting the final destination file the temporary file should go away (and be renamed to the final name). Review URL: http://codereview.chromium.org/672020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40996 0039d316-1c4b-4281-b951-d872f2087c98
* Fix file permissions in save_as mode on POSIX.kinuko@chromium.org2010-03-091-0/+4
| | | | | | | | | BUG=36107 TEST=Check 'Ask where to save each file before downloading' in 'Under the Hood' preference, start a download and check the file permission. Review URL: http://codereview.chromium.org/672019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40977 0039d316-1c4b-4281-b951-d872f2087c98
* chrome 6: string_util.h -> utf_string_conversions.h fix.jhawkins@chromium.org2010-03-083-3/+4
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/671025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40964 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing extension install case. Changing the file browser to only get the ↵dhg@chromium.org2010-03-082-0/+22
| | | | | | | | | | list of current downloads, not the history. BUG=none TEST=none Review URL: http://codereview.chromium.org/669186 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40903 0039d316-1c4b-4281-b951-d872f2087c98
* Add ocx to the dangerous extensions listabarth@chromium.org2010-03-071-0/+1
| | | | | | | | | | BUG=37447 TEST=Serve an .ocx via content-disposition attachment header. Check if the warning message appears. Patch by the great and powerful Inferno. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40859 0039d316-1c4b-4281-b951-d872f2087c98
* Handle CreateFile() trimming trailing dots and spaces in downloads.jschuh@google.com2010-03-031-0/+27
| | | | | | | | | BUG=37007 TEST=unit_tests --gtest_filter=DownloadManagerTest.* Review URL: http://codereview.chromium.org/660297 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40479 0039d316-1c4b-4281-b951-d872f2087c98
* Modified SavePackage(TabContents* tab_contents) of save_package.cc.tony@chromium.org2010-03-021-1/+9
| | | | | | | | | | | | | | | | | | Used the same fix provided for issue 12748. This is done to retrieve actual url of the web page displayed in tab instead of displayed url. Displayed url is different from actual url when viewing source of a web page. ex: view-source:http://www.google.lk/ This is the reason why chrome fails to save source of web page. BUG = 23584 TEST= Visit a web page. Right click and select "view page source". Right click and select Save as. Select web page complete in save dialog. Click save. Source is saved without being cancelled. Repeat the above steps, but select web page only instead of complete in save dialog. Source is saved without chrome getting crashed. Review URL: http://codereview.chromium.org/660264 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40338 0039d316-1c4b-4281-b951-d872f2087c98
* Don't make pause/resume item in download context menu a check item (the name ↵estade@chromium.org2010-02-252-43/+45
| | | | | | | | | | | | | already toggles between pause and resume) also, share more code between windows and linux. DownloadShelfContextMenu{Win,Linux} don't need to both implement menus::SimpleMenuModel::Delegate. BUG=24759 TEST=download item context menu still works. Review URL: http://codereview.chromium.org/652200 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40051 0039d316-1c4b-4281-b951-d872f2087c98
* Posix: Set download file's permissions correctly.thestig@chromium.org2010-02-241-3/+14
| | | | | | | | BUG=36107 TEST=see bug. Review URL: http://codereview.chromium.org/661025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39953 0039d316-1c4b-4281-b951-d872f2087c98
* This change makes incognito downloads show up in the downloads page of an ↵estade@chromium.org2010-02-244-14/+144
| | | | | | | | | | | | incognito window. These downloads are not persisted to history; hence they do not persist between incognito sessions. There is no special UI for the incognito downloads. That can be added later. BUG=28702 Review URL: http://codereview.chromium.org/650065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39910 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: handle dom_ui-generated download drag events.estade@chromium.org2010-02-241-3/+7
| | | | | | | | | BUG=36512 TEST=drag a file out of the downloads page Review URL: http://codereview.chromium.org/657026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39815 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes Issue 34722: Meaningless value in 'Save as type' combobox of 'Save ↵georgey@chromium.org2010-02-233-8/+133
| | | | | | | | | | | | page as...' dialog Adds extension base don MIME type of the page. Adds capability of the complete save of the "application/xhtml+xml" pages BUG=34722 TEST=In the bug + try pages with other MIME types, such as "text/xml", "text/plain" or "text/css" Review URL: http://codereview.chromium.org/650176 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39804 0039d316-1c4b-4281-b951-d872f2087c98
* Add "deb" and "rpm" to dangerous extension list on linux.estade@chromium.org2010-02-221-0/+2
| | | | | | | | | BUG=31144 TEST=download a .deb or .rpm file, download shelf should warn Review URL: http://codereview.chromium.org/650165 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39669 0039d316-1c4b-4281-b951-d872f2087c98
* Make use of SimpleMenuModel in DownloadShelfContextMenuWin and ↵estade@chromium.org2010-02-192-4/+58
| | | | | | | | | | | | | | DownloadShelfContextMenuGtk. BUG=31365 TEST=manually patch by Thiago Farina original review at http://codereview.chromium.org/552251/show Review URL: http://codereview.chromium.org/647059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39496 0039d316-1c4b-4281-b951-d872f2087c98
* Move pref_{member,service} and important_file_writer from chrome/commonphajdan.jr@chromium.org2010-02-193-3/+3
| | | | | | | | | | | | | to chrome/browser. This is a part of an effort to remove bad dependency of chrome/common on chrome/browser. TEST=unit_tests and ui_tests, just moving code BUG=none Review URL: http://codereview.chromium.org/621004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39428 0039d316-1c4b-4281-b951-d872f2087c98
* Pulled out Callback code into base/callback.h. This is the first step ↵akalin@chromium.org2010-02-191-0/+1
| | | | | | | | | | | | | towards redoing the Callback interfaces. Added and removed includes as needed. BUG=35223 TEST=trybots Review URL: http://codereview.chromium.org/646061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39419 0039d316-1c4b-4281-b951-d872f2087c98
* Support dragging a virtual file out of the browser on Linux. This is based ↵jianli@chromium.org2010-02-193-2/+91
| | | | | | | | | | | on the discussion of drag-out feature on whatwg: http://list.whatwg.org/htdig.cgi/whatwg-whatwg.org/2009-August/022122.html BUG=none TEST=To test, drag an element that adds the DownloadURL format data via event.DataTransfer.setData, to the desktop or a folder. Review URL: http://codereview.chromium.org/600154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39405 0039d316-1c4b-4281-b951-d872f2087c98
* Support dragging a virtual file out of the browser on MacOSX. This is based ↵jianli@chromium.org2010-02-112-3/+13
| | | | | | | | | | | on the discussion of drag-out feature on whatwg: http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2009-August/022122.html BUG=none TEST=To test, drag an element that adds the DownloadURL format data via event.DataTransfer.setData, to the desktop or a folder. Review URL: http://codereview.chromium.org/598043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38838 0039d316-1c4b-4281-b951-d872f2087c98
* Mark download tests as flaky on all platform, just the sad truth.phajdan.jr@chromium.org2010-02-101-21/+17
| | | | | | | | | | TBR=dglazkov, kuchhal TEST=still flaky BUG=35275, 20809 Review URL: http://codereview.chromium.org/601030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38630 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug in DownloadFile::Rename where we need to seek to the end of the file.jianli@chromium.org2010-02-102-1/+6
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/601018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38628 0039d316-1c4b-4281-b951-d872f2087c98
* Disable DownloadTest.DownloadMimeType for now.jianli@chromium.org2010-02-101-1/+1
| | | | | | | | | | BUG=none TEST=none TBR=mpcomplete Review URL: http://codereview.chromium.org/595015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38558 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor DragDownloadFile so that it can be used by both Windows and MacOSX.jianli@chromium.org2010-02-1010-348/+493
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/572014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38545 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Reduce header dependencies in chrome.phajdan.jr@chromium.org2010-02-092-6/+6
| | | | | | | | | BUG=none TEST=If it compiles it is perfect. Review URL: http://codereview.chromium.org/585008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38463 0039d316-1c4b-4281-b951-d872f2087c98
* Show the filebrowse ui rather than the download shelf in chromeos.xiyuan@chromium.org2010-02-051-3/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This cl displays the filebrowse ui rather than download shelf for downloads in chrom(e|ium) os. It conditionally replaces (with preprocessor macros) the Browser::OnStartDownload method to do this. The cl adds a static FileBrowseUI::OpenPopup(profile, hashArgument), which opens the file browse ui and passes it the provided hash argument. This is invoked directly from Browser::OnStartDownload. The USBMountObserver code was changed to call this static method, rather than open the popup by hand as it had been doing. I'm not sure about ownership of the Browser* returned by OpenPopup, but based on other code in the tree I assume chrome will deal with freeing it when appropriate. Before this change, USBMountObserver would add the window to registrar_ *before* showing it. Now that FileBrowseUI::OpenPopup returns a which which is already visible, this is no longer the case. I assume this won't be a problem. Commit this for rginda. Original review: http://codereview.chromium.org/555167 BUG=none TEST=none Review URL: http://codereview.chromium.org/564022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38222 0039d316-1c4b-4281-b951-d872f2087c98
* BSD port: another chunk of chrome/browser ifdef cleaningpvalchev@google.com2010-02-032-11/+11
| | | | | | Review URL: http://codereview.chromium.org/553153 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38004 0039d316-1c4b-4281-b951-d872f2087c98
* Add temporary download progress overlay to the dock icon for the Mac (real ↵avi@chromium.org2010-02-014-0/+58
| | | | | | | | | | | UI coming soon), and provide the hooks for the Win7 implementation. BUG=http://crbug.com/8039 TEST=download; see progress in the dock icon Review URL: http://codereview.chromium.org/545157 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37698 0039d316-1c4b-4281-b951-d872f2087c98
* Replace GtkFileChooser with file browser for ChromeOSxiyuan@chromium.org2010-01-292-0/+115
| | | | | | | | | | | | | - Remove dialogs_gtk.cc and add select_file_dialog.cc for chrome os build; - select_file_dialog.cc provides a SelectFileDialogImpl that serves file browse html via HTMLDialogUI; BUG=none TEST=none Review URL: http://codereview.chromium.org/543137 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37547 0039d316-1c4b-4281-b951-d872f2087c98
* Add infobar warning user of extension install failure when trying to install ↵estade@chromium.org2010-01-261-5/+25
| | | | | | | | | | in incognito mode. BUG=27945 Review URL: http://codereview.chromium.org/543155 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37162 0039d316-1c4b-4281-b951-d872f2087c98
* Default to FOLDERID_Downloads on Windows Vista/7 when safe.dimich@google.com2010-01-251-0/+6
| | | | | | | | | Landing for DCheng@. Codereview: http://codereview.chromium.org/553040 TEST=none BUG=13610 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37023 0039d316-1c4b-4281-b951-d872f2087c98
* Don't accidentally add downloads with db_handle = kUninitializedHandle, ↵thestig@chromium.org2010-01-212-13/+32
| | | | | | | | | | which can happen if the sqlite history db is corrupt / offline. BUG=25492 TEST=none Review URL: http://codereview.chromium.org/492017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36736 0039d316-1c4b-4281-b951-d872f2087c98
* Initialize is_extension_install_ properly.craig.schlenter@chromium.org2010-01-201-0/+1
| | | | | | | | | | BUG=32541 TEST=Start chromium a couple of times, click on downloaded PDFs and make sure none of them are misinterpreted as an extension install. Review URL: http://codereview.chromium.org/542114 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36630 0039d316-1c4b-4281-b951-d872f2087c98
* Support dragging a virtual file out of the browser.jianli@chromium.org2010-01-1512-52/+480
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/351029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36378 0039d316-1c4b-4281-b951-d872f2087c98
* Fix by gdk (Garret Kelly)rolandsteiner@chromium.org2010-01-132-4/+6
| | | | | | | | | | | | | | | Resolve issue 30641 Extension files were being selected for auto-open even though an install of the extension was not requested. This patch changes this behaviour so that download an extension (that's not explicitly requested as an extension install) does not force an attempt to install it. BUG=30641 TEST=Right-click an extension link and "Save Link As...". Download appears in shelf. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36106 0039d316-1c4b-4281-b951-d872f2087c98
* Handle extensions correctly when the default download location is not writablekinuko@chromium.org2009-12-253-34/+25
| | | | | | | | | | | | | | | | | | | | BUG=28668 TEST=Set the Download location a NON-writable location (such as '/Application' on Mac) in 'Under the Hood' preferences. Make sure 'Ask where to save...' is kept unchecked. Go to 'https://tools.google.com/chrome/intl/en/themes/index.html' and click 'apply theme'. Make sure 'Save as...' dialog opens to ask users for an alternative download location. Save the file in a writable directory. Make sure the theme applies (or an extension installation dialog opens for extensions). Make sure the download does NOT appear in Downloads history. Make sure it also works for chrome extensions. TEST=(regression) Make sure theme/extension installation works as expected in normal cases (when the default download location is pointing to a writable location and 'Ask where to save...' is unchecked in 'Under the Hood' preferences.) Make sure the download does NOT appear in Downloads history. Make sure the same thing happens for chrome extensions. TEST=(regression) Make sure right-clicking on theme/extension files and selecting 'Save link as...' works as a normal download. Make sure the file is downloaded and saved with the given name. Make sure the theme does NOT apply and an extension installation dialog does NOT open. Make sure the download appears in Downloads history. Review URL: http://codereview.chromium.org/486009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35269 0039d316-1c4b-4281-b951-d872f2087c98
* Chromium to use upstream WebPageSerializer instead of glue/DomSerializer.yaar@chromium.org2009-12-231-6/+6
| | | | | | | | See corresponding changes in webkit here: https://bugs.webkit.org/show_bug.cgi?id=31737 Review URL: http://codereview.chromium.org/434087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35216 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-31 21:09:33 +0000